Page MenuHomeFreeBSD

Fix rfb handshake after r355301.
ClosedPublic

Authored by araujo on Dec 19 2019, 3:23 AM.
Tags
None
Referenced Files
F143874782: D22873.diff
Sun, Feb 1, 8:58 AM
Unknown Object (File)
Dec 31 2025, 2:08 AM
Unknown Object (File)
Dec 30 2025, 12:08 PM
Unknown Object (File)
Dec 28 2025, 2:36 AM
Unknown Object (File)
Dec 20 2025, 4:23 PM
Unknown Object (File)
Dec 11 2025, 3:11 AM
Unknown Object (File)
Nov 9 2025, 2:52 PM
Unknown Object (File)
Nov 8 2025, 10:07 PM

Details

Reviewers
jhb
vmaffione
rgrimes
Group Reviewers
bhyve
Summary

The change to the defintion of 'const char *vbuf' in rfb.c is wrong.
The protocol version string must be send as "RFB 003.008\n" and not as
"RFB 003.008\n\r", otherwise the VNC client isn't able to complete the
handshake (it doesn't recognize the protocol version). While it stays
connected, it doesn't show anything.

Submitted by: Yamagi lists@yamagi.org

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28226
Build 26350: arc lint + arc unit