Page MenuHomeFreeBSD

afedorov (Aleksandr Fedorov)
User

Projects

User Details

User Since
Jan 18 2019, 4:52 AM (282 w, 4 d)

Recent Activity

Sun, Jun 2

afedorov added inline comments to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Sun, Jun 2, 7:43 PM

May 16 2024

afedorov added inline comments to D45120: Add bhyve uart raw tcp backend.
May 16 2024, 6:28 PM

Apr 23 2024

afedorov added inline comments to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Apr 23 2024, 6:58 PM

Apr 22 2024

afedorov added inline comments to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Apr 22 2024, 12:49 PM

Apr 21 2024

afedorov added inline comments to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Apr 21 2024, 6:18 PM
afedorov added a comment to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Apr 21 2024, 1:02 PM

Apr 4 2024

afedorov accepted D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Apr 4 2024, 6:34 PM

Apr 3 2024

afedorov added inline comments to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..
Apr 3 2024, 6:08 PM
afedorov added reviewers for D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages.: glebius, donner, afedorov.
Apr 3 2024, 5:13 PM
afedorov added a comment to D44615: Allow ng_bridge to automatically assign [up]link numbers for connect messages..

My main objection is that backward compatibility is broken. We can no longer have uplink[N] and link[N] at the same time. This may break existing software.

Apr 3 2024, 5:12 PM

Feb 8 2024

afedorov added inline comments to D43776: Fix crash handling updating checksums on mbufs in ng_nat(4)..
Feb 8 2024, 7:03 PM

Feb 5 2024

afedorov added inline comments to D43717: speaker: Use standard C bool.
Feb 5 2024, 12:46 PM

Dec 20 2023

afedorov closed D39369: ng_eiface(4): Set IFF_KNOWSEPOCH flag to avoid enter net epoch recursively..

Abandon due to D39510

Dec 20 2023, 6:58 PM

Nov 24 2023

afedorov abandoned D39374: ng_eiface(4): Increase default TX queue size to 4096 items..

I don't like this approach. We should stop using IF_QUEUE altogether.

Nov 24 2023, 5:54 PM

Nov 21 2023

afedorov accepted D42690: netgraph: increase size of sockaddr_ng to match maximum node name.
Nov 21 2023, 4:26 PM
afedorov accepted D42691: ng_socket: with getsockname() return node ID for unnamed node.
Nov 21 2023, 4:21 PM

Nov 17 2023

afedorov accepted D42636: ng_ksocket: fix upcall clearing on node shutdown.
Nov 17 2023, 7:36 AM
afedorov accepted D42637: ng_ksocket: fix accept(2).
Nov 17 2023, 7:36 AM

Aug 14 2023

afedorov added reviewers for D41448: Buffering syslogd output to pipe: jfree, emaste, markj.
Aug 14 2023, 3:51 PM

Jun 20 2023

afedorov added a comment to D34717: Warm Migration feature for bhyve [Part 1].

@elenamihailescu22_gmail.com , I really respect your work and what you have done.

Jun 20 2023, 5:03 PM · bhyve
afedorov added a reviewer for D34718: Warm Migration feature for bhyve [Part 2]: rew.
Jun 20 2023, 4:41 PM · bhyve
afedorov added reviewers for D34718: Warm Migration feature for bhyve [Part 2]: markj, jhb.
Jun 20 2023, 2:53 PM · bhyve
afedorov added a comment to D34717: Warm Migration feature for bhyve [Part 1].

@corvink , I think this commit is too early. Because we haven't finished supporting snapshots, but this commit already fixes the user interface for live migration, which is not finished at all.

Jun 20 2023, 2:48 PM · bhyve
afedorov requested changes to D34718: Warm Migration feature for bhyve [Part 2].

I think we should bring support for snapshots first. And enable BHYVE_SNAPSHOT by default.

Jun 20 2023, 2:40 PM · bhyve
afedorov added a reviewer for D34719: Warm Migration feature for bhyve [Part 3]: afedorov.
Jun 20 2023, 1:26 PM · bhyve
afedorov added a reviewer for D34718: Warm Migration feature for bhyve [Part 2]: afedorov.
Jun 20 2023, 12:13 PM · bhyve

Apr 25 2023

afedorov added a comment to D39805: vmm: Dynamically allocate a couple of per-CPU state save areas.

Would anyone be willing to test this on an AMD system?

Apr 25 2023, 6:51 PM

Apr 16 2023

afedorov added a comment to D39374: ng_eiface(4): Increase default TX queue size to 4096 items..

up

Apr 16 2023, 6:09 PM

Mar 31 2023

afedorov requested review of D39374: ng_eiface(4): Increase default TX queue size to 4096 items..
Mar 31 2023, 5:50 PM
afedorov added a comment to D39369: ng_eiface(4): Set IFF_KNOWSEPOCH flag to avoid enter net epoch recursively..
In D39369#896103, @zlei wrote:

Generally looks good to me.

The patch slightly increases RX PPS: ~ 100 Kpps.

From to ?

Mar 31 2023, 4:47 PM
afedorov updated the test plan for D39369: ng_eiface(4): Set IFF_KNOWSEPOCH flag to avoid enter net epoch recursively..
Mar 31 2023, 4:46 PM
afedorov requested review of D39369: ng_eiface(4): Set IFF_KNOWSEPOCH flag to avoid enter net epoch recursively..
Mar 31 2023, 3:24 PM

Mar 4 2023

afedorov added a comment to D38843: epair: Simplify the transmit path and reduce tail latency.

@kp , just out of curiosity. How many packets per second did you get in your test after this patch?

Mar 4 2023, 6:41 PM

Sep 13 2022

afedorov closed D36496: netgraph(4): Don't process NGQF_MESG items in NET_EPOCH context..
Sep 13 2022, 2:25 PM
afedorov committed rG0e6e2c4ef3d1: netgraph(4): Don't process NGQF_MESG items in NET_EPOCH context. (authored by afedorov).
netgraph(4): Don't process NGQF_MESG items in NET_EPOCH context.
Sep 13 2022, 2:25 PM

Sep 9 2022

afedorov added a comment to D36496: netgraph(4): Don't process NGQF_MESG items in NET_EPOCH context..

@vmaffione ?

Sep 9 2022, 11:52 AM

Sep 8 2022

afedorov requested review of D36496: netgraph(4): Don't process NGQF_MESG items in NET_EPOCH context..
Sep 8 2022, 4:38 PM

Sep 6 2022

afedorov added a comment to D36451: [RFC] add pr_sockaddr_buf and pr_peeraddr_buf.

Thanks. I will submit this patch in a separate review where we can discuss the details.

Sep 6 2022, 6:53 PM
afedorov added a comment to D36451: [RFC] add pr_sockaddr_buf and pr_peeraddr_buf.

My main objection is that it is bad to extend 'struct protosw' for only one consumer ( ng_kocket(4) ).

Sep 6 2022, 4:57 PM
afedorov added a comment to D36451: [RFC] add pr_sockaddr_buf and pr_peeraddr_buf.
In D36451#828133, @mjg wrote:

can i get some feedback here? the netgraph panic is partially blocking other work

Sep 6 2022, 4:21 PM

Jul 21 2022

afedorov added inline comments to D33401: zfs: add kqfilter support for zvol's with volmode=dev.
Jul 21 2022, 2:58 PM
afedorov added inline comments to D33401: zfs: add kqfilter support for zvol's with volmode=dev.
Jul 21 2022, 2:56 PM
afedorov added a comment to D33401: zfs: add kqfilter support for zvol's with volmode=dev.

@rew, do you have any plans to continue this work? If not, I'd like to take over.

Jul 21 2022, 12:38 PM

Jun 23 2022

afedorov added a reviewer for D35575: bhyve: Support Hyper-V (base) and hyperv clock: howard0su_gmail.com.
Jun 23 2022, 2:55 PM · bhyve
afedorov added a reviewer for D35575: bhyve: Support Hyper-V (base) and hyperv clock: kib.
Jun 23 2022, 2:54 PM · bhyve

Feb 23 2022

afedorov committed rG009a56b2e416: if_vtnet(4): Restore the ability to set promisc mode. (authored by afedorov).
if_vtnet(4): Restore the ability to set promisc mode.
Feb 23 2022, 11:10 AM
afedorov committed rG543b492fa569: if_vxlan(4): Allow netmap_generic to intercept RX packets. (authored by afedorov).
if_vxlan(4): Allow netmap_generic to intercept RX packets.
Feb 23 2022, 11:03 AM
afedorov committed rGf40063d32977: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap (authored by afedorov).
md(4): Add dummy support of the BIO_FLUSH command for malloc and swap
Feb 23 2022, 11:00 AM

Feb 21 2022

afedorov added a comment to D34319: bridge: Don't share broadcast packets.

Looks good to me.

Feb 21 2022, 12:50 PM

Feb 19 2022

afedorov added a comment to D34319: bridge: Don't share broadcast packets.

I'm concerned about two things:

Feb 19 2022, 11:57 AM

Feb 17 2022

afedorov committed rGcb28dfb27d12: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap (authored by afedorov).
md(4): Add dummy support of the BIO_FLUSH command for malloc and swap
Feb 17 2022, 7:25 PM
afedorov closed D34260: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap backend..
Feb 17 2022, 7:25 PM
afedorov added a comment to D33326: bhyve: reset event after blockif resize.

I have this problem in STABLE-13 with disk image located on NFS share.

Feb 17 2022, 9:24 AM

Feb 16 2022

afedorov added inline comments to D34298: mbuf / lro: move defines from mbuf.h to tcp_lro.h.
Feb 16 2022, 7:16 PM

Feb 15 2022

afedorov added a comment to D34260: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap backend..

@vmaffione , do you have any objections?

Feb 15 2022, 5:12 PM

Feb 14 2022

afedorov added a comment to D34260: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap backend..

BTW, mdstart_vnode() does not set bio_resid after handling a BIO_FLUSH. I suspect it does not matter in practice, since by convention BIO_FLUSH commands have bio_length == 0.

Feb 14 2022, 12:33 PM
afedorov updated the diff for D34260: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap backend..
Feb 14 2022, 12:32 PM

Feb 13 2022

afedorov requested review of D34260: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap backend..
Feb 13 2022, 1:15 PM
afedorov committed rG85cd9f7e989b: ng pppoe(4): Add the required NET_EPOCH section to the hook (authored by afedorov).
ng pppoe(4): Add the required NET_EPOCH section to the hook
Feb 13 2022, 12:09 PM

Feb 9 2022

afedorov committed rGb27e6e91d0ad: ng pppoe(4): Add the required NET_EPOCH section to the hook (authored by afedorov).
ng pppoe(4): Add the required NET_EPOCH section to the hook
Feb 9 2022, 7:04 PM
afedorov closed D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. .
Feb 9 2022, 7:04 PM

Feb 8 2022

afedorov added a comment to D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. .

Question: there are three more locations in that source file where NG_SEND_DATA_ONLY() is called and it is not apparent that we are inside NET_EPOCH.
Should we enter NET_EPOCH also there, or we are already in?

Feb 8 2022, 11:43 AM

Feb 7 2022

afedorov added a reviewer for D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. : jhb.
Feb 7 2022, 4:47 PM

Feb 6 2022

afedorov requested review of D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. .
Feb 6 2022, 12:49 PM
afedorov committed rGceaf442ff236: if_vxlan(4): Allow netmap_generic to intercept RX packets. (authored by afedorov).
if_vxlan(4): Allow netmap_generic to intercept RX packets.
Feb 6 2022, 12:32 PM
afedorov closed D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Feb 6 2022, 12:32 PM

Feb 5 2022

afedorov closed D30639: if_vtnet(4): Restore the ability to set promisc mode..
Feb 5 2022, 3:54 PM
afedorov committed rGfc035df8af32: if_vtnet(4): Restore the ability to set promisc mode. (authored by afedorov).
if_vtnet(4): Restore the ability to set promisc mode.
Feb 5 2022, 3:54 PM

Dec 22 2021

afedorov added a reviewer for D33448: vmm: vlapic resume can eat 100% CPU by vlapic_callout_handler: kib.
Dec 22 2021, 5:34 PM · bhyve

Dec 16 2021

afedorov added a comment to D26268: bhyve: snapshot virtio queues can fail.

Should this be committed?

Dec 16 2021, 3:15 PM · bhyve

Dec 15 2021

afedorov added reviewers for D33448: vmm: vlapic resume can eat 100% CPU by vlapic_callout_handler: jhb, markj, elenamihailescu22_gmail.com.
Dec 15 2021, 8:28 AM · bhyve

Nov 9 2021

afedorov added a comment to D32905: Add ETHER_ALIGN support to ng_device(4)..

I don't understand what the alignment does in this case.
Does it fix a bug or is it an optimization?
What part of the code requires this alignment, is it the TCP/IP stack?
Because not only ng_eiface(4) can inject Ethernet packets into the network stack.

Nov 9 2021, 5:06 PM

Nov 8 2021

afedorov added a comment to D32879: ext2fs: extract crc16 into sys/crc16.h.

The polynomial 0x8005 is CRC-16-IBM or CRC-16-ANSI.

Nov 8 2021, 6:47 PM

Oct 21 2021

afedorov abandoned D23987: [if_vtnet] Add VIRTIO_NET_F_MTU flag support..

This is done in FreeBSD 13.

Oct 21 2021, 4:18 PM
afedorov added a comment to D32550: ng_ether: implement 'attach'.

I am also against the use of generic messages.

Oct 21 2021, 4:00 PM

Sep 13 2021

afedorov added inline comments to D31941: Cast pointer to uintptr_t to avoid alignment warnings..
Sep 13 2021, 7:25 PM

Aug 12 2021

afedorov accepted D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

I looked at other nodes that implement the ng_newhook_t method. They already use M_NOWAIT, so I think this patch is good.

Aug 12 2021, 7:26 AM

Aug 10 2021

afedorov added a reviewer for D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine: afedorov.
Aug 10 2021, 3:12 PM
afedorov added a comment to D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

The load simply allows this bug to manifest itself. Under load, the node's queue already contains the item's, so if a message item is sent at that moment (ngtstl shutdown), it will also go to the queue and will be processed by ngthread(). Without load, the queue is mostly empty, the message item will be delivered/processed by the thread of the calling process directly: ngctl -> syscall (sandto(2)) -> ngc_send (ng_socket(4)) -> ng_eiface(4) without entering to the EPOCH section. Therefore, the bug does not manifest itself.

Aug 10 2021, 3:04 PM
afedorov added a comment to D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

JFYI, the same situation. If you call "ngctl shutdown ngeth0:" under load:

Aug 10 2021, 9:07 AM
afedorov added a comment to D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

I think the problem is somewhat broader. Any message item can be added to the node's queue under load or if the queue is blocked. This message item will be processed by ngthread() in the EPOCH section. There are many places in the code of the nodes that perform actions prohibited in the EPOCH section.

Aug 10 2021, 9:02 AM

Jul 22 2021

afedorov added a comment to D31263: bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf.

Overall, this patch looks good to me.

Jul 22 2021, 12:19 PM

Jul 7 2021

afedorov added inline comments to D31077: if_epair: rework.
Jul 7 2021, 3:09 PM

Jun 15 2021

afedorov added inline comments to D30668: Intel I225 Driver.
Jun 15 2021, 7:21 PM
afedorov added inline comments to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 15 2021, 2:24 PM

Jun 5 2021

afedorov added a comment to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
In D30638#688320, @np wrote:

I know it's not directly related but the 'if' here is not needed. If you're tightening the len checks in the function then maybe clean this too?

out:

if (m != NULL)
        m_freem(m);
Jun 5 2021, 9:15 AM
afedorov updated the diff for D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
  • Move ethernet packet length check to vxlan_input().
Jun 5 2021, 9:11 AM

Jun 4 2021

afedorov updated the diff for D30639: if_vtnet(4): Restore the ability to set promisc mode..
Jun 4 2021, 4:38 PM
afedorov added inline comments to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 4 2021, 4:31 PM
afedorov updated the summary of D30639: if_vtnet(4): Restore the ability to set promisc mode..
Jun 4 2021, 4:19 PM
afedorov requested review of D30639: if_vtnet(4): Restore the ability to set promisc mode..
Jun 4 2021, 4:16 PM
afedorov requested review of D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 4 2021, 4:02 PM
afedorov added inline comments to D30629: tests/netgraph: Inital framework for testing libnetgraph.
Jun 4 2021, 9:52 AM

Jun 3 2021

afedorov added a comment to D30618: arm64: add snd_hda to GENERIC.

I prefer having sound loaded as a module in fact, but until we have module autoloading by PCI ID this should be available in GENERIC.

Jun 3 2021, 2:54 PM

May 18 2021

afedorov added inline comments to D30288: mmc: Add mmc-pwrseq driver.
May 18 2021, 9:48 AM

Apr 28 2021

afedorov added a comment to D30020: bhyve: add virtio-input emulation.

The capsicum support should look something like this:

Apr 28 2021, 1:39 PM · bhyve
afedorov added a comment to D30020: bhyve: add virtio-input emulation.

Have you tested this code with CAPSICUM enabled?

Apr 28 2021, 10:17 AM · bhyve

Apr 7 2021

afedorov added reviewers for D29531: Add kvmclock timecounter support to FreeBSD: kib, markj.
Apr 7 2021, 5:58 PM
afedorov added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

As I mentioned previously, the other thing to consider when using kvmclock in the current patch is the need for a system call for clock_gettime(), gettimeofday(), etc.

Apr 7 2021, 5:57 PM
afedorov added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

@me_freebsd_mathieu.digital, what a CPU model was used for testing?

Apr 7 2021, 4:35 PM