Page MenuHomeFreeBSD

afedorov (Aleksandr Fedorov)
User

Projects

User Details

User Since
Jan 18 2019, 4:52 AM (139 w, 3 h)

Recent Activity

Mon, Sep 13

afedorov added inline comments to D31941: Use a char * to avoid alignment warnings..
Mon, Sep 13, 7:25 PM

Aug 12 2021

afedorov accepted D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

I looked at other nodes that implement the ng_newhook_t method. They already use M_NOWAIT, so I think this patch is good.

Aug 12 2021, 7:26 AM

Aug 10 2021

afedorov added a reviewer for D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine: afedorov.
Aug 10 2021, 3:12 PM
afedorov added a comment to D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

The load simply allows this bug to manifest itself. Under load, the node's queue already contains the item's, so if a message item is sent at that moment (ngtstl shutdown), it will also go to the queue and will be processed by ngthread(). Without load, the queue is mostly empty, the message item will be delivered/processed by the thread of the calling process directly: ngctl -> syscall (sandto(2)) -> ngc_send (ng_socket(4)) -> ng_eiface(4) without entering to the EPOCH section. Therefore, the bug does not manifest itself.

Aug 10 2021, 3:04 PM
afedorov added a comment to D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

JFYI, the same situation. If you call "ngctl shutdown ngeth0:" under load:

Aug 10 2021, 9:07 AM
afedorov added a comment to D31486: ng_bridge: Use M_NOWAIT when allocating memory in the newhook routine.

I think the problem is somewhat broader. Any message item can be added to the node's queue under load or if the queue is blocked. This message item will be processed by ngthread() in the EPOCH section. There are many places in the code of the nodes that perform actions prohibited in the EPOCH section.

Aug 10 2021, 9:02 AM

Jul 22 2021

afedorov added a comment to D31263: bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf.

Overall, this patch looks good to me.

Jul 22 2021, 12:19 PM

Jul 7 2021

afedorov added inline comments to D31077: if_epair: rework.
Jul 7 2021, 3:09 PM

Jun 15 2021

afedorov added inline comments to D30668: Intel I225 Driver.
Jun 15 2021, 7:21 PM
afedorov added inline comments to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 15 2021, 2:24 PM

Jun 5 2021

afedorov added a comment to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
In D30638#688320, @np wrote:

I know it's not directly related but the 'if' here is not needed. If you're tightening the len checks in the function then maybe clean this too?

out:

if (m != NULL)
        m_freem(m);
Jun 5 2021, 9:15 AM
afedorov updated the diff for D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
  • Move ethernet packet length check to vxlan_input().
Jun 5 2021, 9:11 AM

Jun 4 2021

afedorov updated the diff for D30639: if_vtnet(4): Restore the ability to set promisc mode..
Jun 4 2021, 4:38 PM
afedorov added inline comments to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 4 2021, 4:31 PM
afedorov updated the summary of D30639: if_vtnet(4): Restore the ability to set promisc mode..
Jun 4 2021, 4:19 PM
afedorov requested review of D30639: if_vtnet(4): Restore the ability to set promisc mode..
Jun 4 2021, 4:16 PM
afedorov requested review of D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 4 2021, 4:02 PM
afedorov added inline comments to D30629: tests/netgraph: Inital framework for testing libnetgraph.
Jun 4 2021, 9:52 AM

Jun 3 2021

afedorov added a comment to D30618: arm64: add snd_hda to GENERIC.

I prefer having sound loaded as a module in fact, but until we have module autoloading by PCI ID this should be available in GENERIC.

Jun 3 2021, 2:54 PM

May 18 2021

afedorov added inline comments to D30288: mmc: Add mmc-pwrseq driver.
May 18 2021, 9:48 AM

Apr 28 2021

afedorov added a comment to D30020: bhyve: add virtio-input emulation.

The capsicum support should look something like this:

Apr 28 2021, 1:39 PM · bhyve
afedorov added a comment to D30020: bhyve: add virtio-input emulation.

Have you tested this code with CAPSICUM enabled?

Apr 28 2021, 10:17 AM · bhyve

Apr 7 2021

afedorov added reviewers for D29531: Add kvmclock timecounter support to FreeBSD: kib, markj.
Apr 7 2021, 5:58 PM
afedorov added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

As I mentioned previously, the other thing to consider when using kvmclock in the current patch is the need for a system call for clock_gettime(), gettimeofday(), etc.

Apr 7 2021, 5:57 PM
afedorov added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

@me_freebsd_mathieu.digital, what a CPU model was used for testing?

Apr 7 2021, 4:35 PM

Mar 30 2021

afedorov accepted D29433: bhyve: change vq_getchain to return iovecs in both directions.
Mar 30 2021, 5:06 AM

Mar 28 2021

afedorov accepted D29433: bhyve: change vq_getchain to return iovecs in both directions.
Mar 28 2021, 8:59 AM

Mar 27 2021

afedorov added inline comments to D29433: bhyve: change vq_getchain to return iovecs in both directions.
Mar 27 2021, 8:10 AM

Mar 11 2021

afedorov accepted D29054: tests/sys/netgraph/ng_macfilter_test: Fix invalid TAP output.

I have no objections.

Mar 11 2021, 3:02 PM

Mar 2 2021

afedorov added inline comments to D29011: wg: Fix some mbuf leaks in the input path.
Mar 2 2021, 5:19 PM

Mar 1 2021

afedorov added a member for Jails: afedorov.
Mar 1 2021, 4:44 PM

Feb 20 2021

afedorov added a comment to D28516: netgraph/ng_bridge: learn MACs via control message.

I'm not an English expert, so you may be right.
Technically, I have no questions, I think this patch can be committed.

Feb 20 2021, 8:23 PM
afedorov added a reviewer for D28516: netgraph/ng_bridge: learn MACs via control message: bcr.
Feb 20 2021, 8:04 PM

Feb 18 2021

afedorov added a comment to D28516: netgraph/ng_bridge: learn MACs via control message.

Did you mean D28559?

Feb 18 2021, 7:18 PM
afedorov added inline comments to D28516: netgraph/ng_bridge: learn MACs via control message.
Feb 18 2021, 9:17 AM

Feb 15 2021

afedorov updated subscribers of D28679: vnode: move write cluster support data to inodes..

I have no competence in this area. Maybe you wanted to add @fsu to the reviewers? He was working on improving ext2/3/4 support.

Feb 15 2021, 2:54 PM
afedorov removed a reviewer for D28679: vnode: move write cluster support data to inodes.: afedorov.
Feb 15 2021, 2:51 PM

Feb 5 2021

afedorov added inline comments to D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
Feb 5 2021, 10:50 AM

Jan 13 2021

afedorov updated subscribers of D28123: netgraph/ng_bridge: become multithreaded.

Lutz, do you have any plans for the upcoming changes?
I also thought about getting rid of ng_bridge from NG_NODE_FORCE_WRITER. Since rcv_data is always called in the NET_EPOCH context, I think we can do it like @kp did it for if_bridge(4) (see D24250).

Jan 13 2021, 10:23 AM
afedorov accepted D28125: netgraph/ng_bridge: switch to counter framework.
Jan 13 2021, 7:44 AM
afedorov added a reviewer for D28125: netgraph/ng_bridge: switch to counter framework: afedorov.
Jan 13 2021, 7:43 AM

Dec 18 2020

afedorov added a reviewer for D27662: netgraph: Fix ng_ether's shutdown handing: glebius.
Dec 18 2020, 3:53 PM
afedorov added a comment to D27662: netgraph: Fix ng_ether's shutdown handing.

I don't really like how ng_etner(4) is implemented as a whole. But I think this patch is correct and should be committed.

Dec 18 2020, 3:53 PM
afedorov accepted D27662: netgraph: Fix ng_ether's shutdown handing.
Dec 18 2020, 3:44 PM
afedorov added a reviewer for D27662: netgraph: Fix ng_ether's shutdown handing: afedorov.
Dec 18 2020, 3:44 PM

Dec 17 2020

afedorov closed D27382: [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path..
Dec 17 2020, 6:15 PM
afedorov committed rS368727: [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path..
[ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path.
Dec 17 2020, 6:15 PM
afedorov closed D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Dec 17 2020, 4:53 PM
afedorov committed rS368720: [bhyve] virtio-net: Do not allow receiving packets until features have been….
[bhyve] virtio-net: Do not allow receiving packets until features have been…
Dec 17 2020, 4:52 PM

Dec 6 2020

afedorov added a comment to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..

@grehan do you have any objections?

Dec 6 2020, 6:28 PM

Dec 3 2020

afedorov added inline comments to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Dec 3 2020, 2:00 PM

Nov 29 2020

afedorov added inline comments to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Nov 29 2020, 10:31 AM
afedorov updated the diff for D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..

Eliminate issues identified by reviewers.

Nov 29 2020, 10:27 AM

Nov 27 2020

afedorov added a comment to D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..

@vmaffione, what do you think about this patch?

Nov 27 2020, 3:38 PM

Nov 26 2020

afedorov updated the diff for D27382: [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path..

Fix indentation.

Nov 26 2020, 2:58 PM
afedorov added inline comments to D27382: [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path..
Nov 26 2020, 2:37 PM
afedorov updated the diff for D27382: [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path..

Add a comment about locking.

Nov 26 2020, 2:34 PM
afedorov updated the diff for D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Nov 26 2020, 2:14 PM
afedorov added a reviewer for D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated.: bryanv.
Nov 26 2020, 1:26 PM
afedorov requested review of D27382: [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path..
Nov 26 2020, 1:24 PM
afedorov requested review of D27381: [bhyve] virtio-net: Do not allow receiving packets until features have been negotiated..
Nov 26 2020, 12:22 PM

Nov 19 2020

afedorov added a reviewer for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type): glebius.
Nov 19 2020, 8:19 PM
afedorov added inline comments to D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
Nov 19 2020, 8:04 PM
afedorov added inline comments to D27268: New netgraph node: macfilter.
Nov 19 2020, 7:55 PM

Nov 18 2020

afedorov added inline comments to D27268: New netgraph node: macfilter.
Nov 18 2020, 6:25 PM
afedorov added inline comments to D27268: New netgraph node: macfilter.
Nov 18 2020, 6:10 PM
afedorov added inline comments to D27268: New netgraph node: macfilter.
Nov 18 2020, 5:57 PM
afedorov added inline comments to D27268: New netgraph node: macfilter.
Nov 18 2020, 4:17 PM

Oct 14 2020

afedorov added a reviewer for D26755: Add hash table lookup for IPv6 raw sockets.: mav.
Oct 14 2020, 7:31 PM

Oct 13 2020

afedorov added a reviewer for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall: bcr.
Oct 13 2020, 2:43 PM · Linux Emulation
afedorov added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

I see various errors in the man page:

Oct 13 2020, 2:43 PM · Linux Emulation

Oct 5 2020

afedorov added reviewers for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall: kib, trasz, markj.
Oct 5 2020, 4:58 PM · Linux Emulation

Sep 29 2020

afedorov added a comment to D21968: netgraph/ng_source: Allow ng_source to inject into any netgraph network.

Do you have any performance measurements?
Is it have advantages over injecting packets through ng_socket(4) or ng_device(4)?

Sep 29 2020, 12:20 PM
afedorov added reviewers for D21965: usr.sbin/ngctl: Generate more compact GraphWiz output: glebius, jhb, markj, kevans.
Sep 29 2020, 12:08 PM

Sep 25 2020

afedorov added a comment to D26548: ng_l2tp: Fix callout synchronization in the RACK timeout handler.

Is this PR: 241133 ?

Sep 25 2020, 10:40 AM

Sep 20 2020

afedorov added a comment to D26489: IP address parsing in netgraph eating too many characters.

After looking at your abandoned review (D26420) where you add parsing of IPv6 addresses. I wondered if we could use the generic inet_aton(3) functions available from kernel space?

Sep 20 2020, 10:14 AM · network

Sep 14 2020

lwhsu renamed afedorov from aleksandr.fedorov_itglobal.com to afedorov.
Sep 14 2020, 4:26 PM

Aug 18 2020

afedorov added a reviewer for D6611: net: translate inbound checksum offloading flags to outbound when forwarding: rgrimes.
Aug 18 2020, 7:00 PM
afedorov added reviewers for D6611: net: translate inbound checksum offloading flags to outbound when forwarding: jhb, vmaffione.
Aug 18 2020, 6:52 PM
afedorov added a comment to D6611: net: translate inbound checksum offloading flags to outbound when forwarding.

Sorry to start a discussion here, but we have a similar problem with bhyve. When it is necessary to deliver packets from VM with partial checksum and TSO to the host stack (inbound path).
For example, we need to solve the next path:
VM (virtio-net, TSO, partial checksum) -> if_bridge/ng_bridge -> if_tuntap/ng_eiface -> host stack.

Aug 18 2020, 6:52 PM

Aug 16 2020

afedorov added a comment to D26035: Refactor configuration management in bhyve..

I really like the changes related to option handling.

Aug 16 2020, 5:44 PM
afedorov added inline comments to D6612: net: allow fast-forwarding TSO packets.
Aug 16 2020, 3:34 PM

Jun 23 2020

afedorov added inline comments to D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.
Jun 23 2020, 7:07 AM · network

May 16 2020

afedorov added inline comments to D24846: [bhyve(8)] Add the netgraph network backend decription to the manpage..
May 16 2020, 8:11 AM
afedorov updated the diff for D24846: [bhyve(8)] Add the netgraph network backend decription to the manpage..
May 16 2020, 8:10 AM

May 15 2020

afedorov requested review of D24846: [bhyve(8)] Add the netgraph network backend decription to the manpage..
May 15 2020, 8:00 AM

May 8 2020

afedorov added a comment to D24620: [bhyve] Add Netgraph network backend..

@vmaffione , do you have any objections?

May 8 2020, 6:22 PM
afedorov updated the diff for D24620: [bhyve] Add Netgraph network backend..
  • Rebase
  • Use ',' as options separator.
  • Move '#include <sys/sysctl.h>' to NETGRAPH section.
May 8 2020, 6:19 PM
afedorov updated the diff for D24735: [bhyve] Pass a complete string of parameters to network backends.
  • Free optscopy early.
  • While I'm here, fix a memory leak in e1000 frontend.
May 8 2020, 5:00 PM

May 7 2020

afedorov added a comment to D24735: [bhyve] Pass a complete string of parameters to network backends.
  • Fix the indicated issues.
May 7 2020, 11:11 AM
afedorov updated the diff for D24735: [bhyve] Pass a complete string of parameters to network backends.
May 7 2020, 11:05 AM

May 6 2020

afedorov added a comment to D24723: bhyve: update man page to describe the virtio-net mtu option.

It looks good to me. Thank you.

May 6 2020, 3:06 PM
afedorov updated the test plan for D24735: [bhyve] Pass a complete string of parameters to network backends.
May 6 2020, 3:02 PM
afedorov requested review of D24735: [bhyve] Pass a complete string of parameters to network backends.
May 6 2020, 3:00 PM

May 5 2020

afedorov added a comment to D24620: [bhyve] Add Netgraph network backend..

@vmaffione , I left '/' as a separator, because ';' used by the shell (tcsh, sh), so there is a need to enclosure the option string.
I think the best solution is still to pass the full line of options to the backend. Then we can use ',' as the delimiter.
I have not completely understood how backward compatibility can be broken? May you clarify?

May 5 2020, 6:56 PM
afedorov added a comment to D24620: [bhyve] Add Netgraph network backend..
  • Reuse tap backend functions.
May 5 2020, 6:44 PM
afedorov updated the diff for D24620: [bhyve] Add Netgraph network backend..
May 5 2020, 6:43 PM
afedorov added a comment to D24620: [bhyve] Add Netgraph network backend..

@vmaffione do you have any objections?

May 5 2020, 3:50 PM

May 4 2020

afedorov updated the diff for D24620: [bhyve] Add Netgraph network backend..
  • Revert: 'relpath' -> 'path' option.
  • Correctly calculate the maximum available socket buffer size, as is done in the kernel.
May 4 2020, 12:06 PM
afedorov added a comment to D24620: [bhyve] Add Netgraph network backend..

Please keep it "path".
"relpath" is useless in this situation, because your node is not yet connected and can't use a relative path at all.

May 4 2020, 11:28 AM