Page MenuHomeFreeBSD

howard0su_gmail.com (Howard Su)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2015, 8:57 AM (214 w, 6 d)

Recent Activity

Oct 12 2016

howard0su_gmail.com added a comment to D8224: hyperv/vss: implement the VSS (Volume Shadow Copy Service).

Did we consider the generic apporach to implement suspend inside vfs and VM?

Oct 12 2016, 5:27 AM

Sep 3 2016

howard0su_gmail.com added a comment to D4558: Make FORTH optional for various loaders..

All Makefile changed in this change includes src.opts.mk in the beginning of files.

Sep 3 2016, 2:39 PM
howard0su_gmail.com updated the diff for D4558: Make FORTH optional for various loaders..

rebase to -Current

Sep 3 2016, 2:38 PM
howard0su_gmail.com added a comment to D7756: pxeboot: add nfs.read_size tunable.

updated a new revision to address comments.

Sep 3 2016, 2:26 PM
howard0su_gmail.com updated the diff for D7756: pxeboot: add nfs.read_size tunable.

Update

Sep 3 2016, 2:24 PM
howard0su_gmail.com updated the diff for D7756: pxeboot: add nfs.read_size tunable.

Address comments on man page

Sep 3 2016, 2:21 PM

Sep 2 2016

howard0su_gmail.com retitled D7756: pxeboot: add nfs.read_size tunable from to pxeboot: add nfs.read_size tunable.
Sep 2 2016, 7:10 AM

Aug 10 2016

howard0su_gmail.com added inline comments to D7457: hyperv/hn: Switch to vmbus xact APIs for NVS initialization.
Aug 10 2016, 4:04 AM
howard0su_gmail.com added inline comments to D7456: hyperv/vmbus: Add APIs for various types of transactions..
Aug 10 2016, 4:03 AM

Aug 7 2016

howard0su_gmail.com added reviewers for D7435: hyperv: normalize the initialization code path: sepherosa_gmail.com, honzhan_microsoft.com, decui_microsoft.com.
Aug 7 2016, 10:46 PM
howard0su_gmail.com retitled D7435: hyperv: normalize the initialization code path from to hyperv: normalize the initialization code path.
Aug 7 2016, 10:45 PM

May 30 2016

howard0su_gmail.com added inline comments to D6636: hyperv/vmbus: Redefine SynIC message..
May 30 2016, 12:35 PM

May 17 2016

howard0su_gmail.com accepted D6417: hyperv/vmbus: Minor function definition style fixup.
May 17 2016, 11:00 AM
howard0su_gmail.com accepted D6416: hyperv/vmbus: Fix SYSINIT function prototype and usage..
May 17 2016, 11:00 AM
howard0su_gmail.com accepted D6414: hyperv/vmbus: Staticize vmbus_devclass.
May 17 2016, 10:54 AM

May 15 2016

howard0su_gmail.com added inline comments to D6333: hyperv/vmbus: Simplify event processing.
May 15 2016, 12:01 AM

Apr 21 2016

howard0su_gmail.com abandoned D5164: HyperV/vmm: improve locking of hv_ring_buffer.
Apr 21 2016, 2:45 AM
howard0su_gmail.com added a comment to D5958: hyperv: load hyperv driver from boot loader automatically..

this change didn't touch efi boot code. need more working here.

Apr 21 2016, 2:45 AM

Apr 19 2016

howard0su_gmail.com retitled D6001: Don't define KLD_MODULE when build module with kernel from to Don't define KLD_MODULE when build module with kernel.
Apr 19 2016, 3:09 PM
howard0su_gmail.com abandoned D5909: hyperv/hv: use MSR to hint hypervisor on entering idle..

This need more testing and some change in my private tree is dependency for this change.

Apr 19 2016, 2:54 PM

Apr 16 2016

howard0su_gmail.com updated the diff for D5956: hyperv: add meta .ko to load all hyperv related .ko.

update copyright line

Apr 16 2016, 10:25 AM
howard0su_gmail.com updated the diff for D5958: hyperv: load hyperv driver from boot loader automatically..

Don't remove hyperv from GENERIC. Add boot loader logic only.

Apr 16 2016, 10:22 AM

Apr 15 2016

howard0su_gmail.com added inline comments to D5921: altq: remove NULL check after malloc with M_WAITOK.
Apr 15 2016, 10:40 AM
howard0su_gmail.com added inline comments to D5909: hyperv/hv: use MSR to hint hypervisor on entering idle..
Apr 15 2016, 10:35 AM
howard0su_gmail.com added reviewers for D5909: hyperv/hv: use MSR to hint hypervisor on entering idle.: decui_microsoft.com, honzhan_microsoft.com, sepherosa_gmail.com.
Apr 15 2016, 8:06 AM
howard0su_gmail.com added a comment to D5958: hyperv: load hyperv driver from boot loader automatically..

Can we leave the device hyperv in GENERIC? Since atomic ops will have significant cost if hyperv drivers are loaded as modules. We can remove the device hyperv from GENERIC after atomic ops only have inlined version on amd64 (like other archs)

Apr 15 2016, 7:28 AM
howard0su_gmail.com added reviewers for D5957: hyperv/vmbus: make hyperv eventtimer as a module: decui_microsoft.com, honzhan_microsoft.com, sepherosa_gmail.com.
Apr 15 2016, 7:23 AM
howard0su_gmail.com added reviewers for D5956: hyperv: add meta .ko to load all hyperv related .ko: decui_microsoft.com, honzhan_microsoft.com, sepherosa_gmail.com.
Apr 15 2016, 7:18 AM
howard0su_gmail.com added reviewers for D5958: hyperv: load hyperv driver from boot loader automatically.: decui_microsoft.com, honzhan_microsoft.com, sepherosa_gmail.com.
Apr 15 2016, 7:08 AM
howard0su_gmail.com retitled D5958: hyperv: load hyperv driver from boot loader automatically. from to hyperv: load hyperv driver from boot loader automatically..
Apr 15 2016, 6:52 AM
howard0su_gmail.com retitled D5957: hyperv/vmbus: make hyperv eventtimer as a module from to hyperv/vmbus: make hyperv eventtimer as a module.
Apr 15 2016, 6:49 AM
howard0su_gmail.com retitled D5956: hyperv: add meta .ko to load all hyperv related .ko from to hyperv: add meta .ko to load all hyperv related .ko.
Apr 15 2016, 6:46 AM

Apr 12 2016

howard0su_gmail.com added a comment to D5922: usb: malloc with M_WAITOK never returns NULL.

Hi,
In the USB core M_NOWAIT should be used, and NULL checks should be preserved. The NULL checks are active for embedded products (non-FreeBSD) where the malloc implementation does not support M_WAITOK.
--HPS

Apr 12 2016, 3:33 PM
howard0su_gmail.com added a reviewer for D5921: altq: remove NULL check after malloc with M_WAITOK: bz.
Apr 12 2016, 2:24 PM
howard0su_gmail.com added a reviewer for D5922: usb: malloc with M_WAITOK never returns NULL: hselasky.
Apr 12 2016, 2:23 PM
howard0su_gmail.com added a reviewer for D5920: hyperv: fix error case where dereferencing NULL point: sepherosa_gmail.com.

please use a different fix to the problem as we discussed

Apr 12 2016, 2:21 PM
howard0su_gmail.com added a reviewer for D5911: hyperv/VMBUS: Check event pages inide hv_vmbus_on_events: sepherosa_gmail.com.
Apr 12 2016, 2:21 PM
howard0su_gmail.com abandoned D5904: Remove NULL check before free(9).

I have to split this into small changeset and manually cleanup more stlye(9)

Apr 12 2016, 2:16 PM
howard0su_gmail.com added reviewers for D5910: hyperv: make Hyper-V driver compiled as .ko file: decui_microsoft.com, sepherosa_gmail.com, jhb, honzhan_microsoft.com, kib.
Apr 12 2016, 2:14 PM
howard0su_gmail.com retitled D5922: usb: malloc with M_WAITOK never returns NULL from to usb: malloc with M_WAITOK never returns NULL.
Apr 12 2016, 12:43 AM
howard0su_gmail.com retitled D5921: altq: remove NULL check after malloc with M_WAITOK from to altq: remove NULL check after malloc with M_WAITOK.
Apr 12 2016, 12:05 AM
howard0su_gmail.com retitled D5920: hyperv: fix error case where dereferencing NULL point from to hyperv: fix error case where dereferencing NULL point.
Apr 12 2016, 12:01 AM

Apr 11 2016

howard0su_gmail.com abandoned D5813: hyperv/vmbus: make hyperv eventtimer as a module.
Apr 11 2016, 12:58 PM
howard0su_gmail.com retitled D5911: hyperv/VMBUS: Check event pages inide hv_vmbus_on_events from to hyperv/VMBUS: Check event pages inide hv_vmbus_on_events.
Apr 11 2016, 12:35 PM
howard0su_gmail.com retitled D5910: hyperv: make Hyper-V driver compiled as .ko file from to hyperv: make Hyper-V driver compiled as .ko file.
Apr 11 2016, 12:33 PM
howard0su_gmail.com updated the diff for D5909: hyperv/hv: use MSR to hint hypervisor on entering idle..

mismerge one line, add it back

Apr 11 2016, 12:30 PM
howard0su_gmail.com retitled D5909: hyperv/hv: use MSR to hint hypervisor on entering idle. from to hyperv/hv: use MSR to hint hypervisor on entering idle..
Apr 11 2016, 12:19 PM
howard0su_gmail.com updated the diff for D5904: Remove NULL check before free(9).
Apr 11 2016, 7:49 AM
howard0su_gmail.com added a comment to D5904: Remove NULL check before free(9).

The patch is still refining. I submit this to see if there is strong objection not to do this. (remove null check)

Apr 11 2016, 6:37 AM
howard0su_gmail.com retitled D5905: Remove unnecessary NULL check from to Remove unnecessary NULL check.
Apr 11 2016, 6:00 AM
howard0su_gmail.com retitled D5904: Remove NULL check before free(9) from to Remove NULL check before free(9).
Apr 11 2016, 5:28 AM

Apr 9 2016

howard0su_gmail.com abandoned D5400: hyperv/vmbus: replace hv_guid with uuid.
Apr 9 2016, 6:55 AM

Apr 7 2016

howard0su_gmail.com abandoned D5254: hyperv/vmbus: static assign IDT vector for hv.
Apr 7 2016, 12:09 AM

Apr 6 2016

howard0su_gmail.com added a comment to D5849: x86: Allow interrupt vector allocation/free even on UP.

the name of IPI sounds strange to me as you are enabling this in UP.

Apr 6 2016, 8:34 AM
howard0su_gmail.com added inline comments to D5850: hyperv: Use lapic_{alloc,free}_ipi to allocate private interrupt vector.
Apr 6 2016, 8:33 AM

Apr 2 2016

howard0su_gmail.com retitled D5813: hyperv/vmbus: make hyperv eventtimer as a module from to hyperv/vmbus: make hyperv eventtimer as a module.
Apr 2 2016, 2:04 PM
howard0su_gmail.com retitled D5812: hyperv/vmbus: change channel_msg_lock to default mtx from to hyperv/vmbus: change channel_msg_lock to default mtx.
Apr 2 2016, 7:19 AM

Mar 29 2016

howard0su_gmail.com added a reviewer for D5755: ehci: pass MPSAFE when calling bus_setup_intr: mmel.
Mar 29 2016, 1:20 PM

Mar 27 2016

howard0su_gmail.com retitled D5755: ehci: pass MPSAFE when calling bus_setup_intr from to ehci: pass MPSAFE when calling bus_setup_intr.
Mar 27 2016, 3:40 PM

Mar 24 2016

howard0su_gmail.com added inline comments to D5508: hyperv: netvsc: VRSS step1: multiple channel support.
Mar 24 2016, 4:49 PM
howard0su_gmail.com added a comment to D5727: loader: set hw.vga.textmode=1 on hypervisors.

Even failed to boot in one of VM with 24 vCPU

Mar 24 2016, 12:34 PM

Mar 23 2016

howard0su_gmail.com added a comment to D5715: hyperv/vmbus: use a better retry method in hv_vmbus_post_message().

Yeah, the more NICs you have the higher chance you got this panic.
My worry is, now that the code sleeps in the globally shared taskqueue_thread. I'd suggest to create two vmbus taskqueues, instead of sharing the global taskqueue_fast/taskqueue_thread. Though that should be done in another patch.

Mar 23 2016, 3:51 AM

Mar 22 2016

howard0su_gmail.com added a comment to D5086: hyperv: vmbus: refactor msg handler by replacing swi with task queue.

a different version with same idea is already committed.

Mar 22 2016, 12:26 PM

Mar 21 2016

howard0su_gmail.com added reviewers for D5696: Use SINT4 instead of SINT2 for eventtimer messages.: decui_microsoft.com, sepherosa_gmail.com, honzhan_microsoft.com.
Mar 21 2016, 1:04 PM
howard0su_gmail.com updated the diff for D5215: Use taskqueue_fast to process messages.

split patch

Mar 21 2016, 1:03 PM
howard0su_gmail.com retitled D5696: Use SINT4 instead of SINT2 for eventtimer messages. from to Use SINT4 instead of SINT2 for eventtimer messages..
Mar 21 2016, 12:58 PM
howard0su_gmail.com updated the diff for D5215: Use taskqueue_fast to process messages.

Use SINT4 for eventtimer instead of SINT2 that shares with others.

Mar 21 2016, 6:28 AM
howard0su_gmail.com added a reviewer for D5651: hyperv/vmbus: introduce snprinf_hv_guid: sepherosa_gmail.com.

Can u review?

Mar 21 2016, 3:07 AM

Mar 18 2016

howard0su_gmail.com retitled D5669: add bus_child_pnpinfo_str from to add bus_child_pnpinfo_str.
Mar 18 2016, 3:13 AM
howard0su_gmail.com updated the diff for D5651: hyperv/vmbus: introduce snprinf_hv_guid.

address review feedback

Mar 18 2016, 3:11 AM
howard0su_gmail.com added a comment to D5651: hyperv/vmbus: introduce snprinf_hv_guid.

Add const and KASSERT too?

I didn't see your comments before I made the change. I added const.

Mar 18 2016, 3:05 AM
howard0su_gmail.com updated the diff for D5651: hyperv/vmbus: introduce snprinf_hv_guid.

add const

Mar 18 2016, 3:03 AM

Mar 17 2016

howard0su_gmail.com updated the diff for D5651: hyperv/vmbus: introduce snprinf_hv_guid.

Update guid print function

Mar 17 2016, 6:17 AM

Mar 16 2016

howard0su_gmail.com retitled D5651: hyperv/vmbus: introduce snprinf_hv_guid from to hyperv/vmbus: introduce snprinf_hv_guid.
Mar 16 2016, 2:54 PM

Mar 14 2016

howard0su_gmail.com added inline comments to D5400: hyperv/vmbus: replace hv_guid with uuid.
Mar 14 2016, 11:17 AM
howard0su_gmail.com added a reviewer for D5254: hyperv/vmbus: static assign IDT vector for hv: jhb.

Add jhb@ to seek for input on IDT thing

Mar 14 2016, 6:44 AM
howard0su_gmail.com updated the diff for D5254: hyperv/vmbus: static assign IDT vector for hv.

fix comment

Mar 14 2016, 4:24 AM
howard0su_gmail.com abandoned D5364: fix acpi idle assert and hv driver..

This is not for -current branch.

Mar 14 2016, 2:06 AM
howard0su_gmail.com added a comment to D5400: hyperv/vmbus: replace hv_guid with uuid.

Let me split this change into several smaller ones for non-guid related changes.

Mar 14 2016, 12:19 AM

Mar 13 2016

howard0su_gmail.com updated the diff for D5254: hyperv/vmbus: static assign IDT vector for hv.

Rebase to master. Rename {IDT|IRQ}_EVTCHN to _HYPERVISOR

Mar 13 2016, 2:02 PM
howard0su_gmail.com updated the diff for D5215: Use taskqueue_fast to process messages.

Rebase to master and use taskqueue_enqueue for fast queue

Mar 13 2016, 1:19 PM
howard0su_gmail.com added a comment to D5254: hyperv/vmbus: static assign IDT vector for hv.

Shall we commit this without changing the IDT name?

Mar 13 2016, 12:42 PM
howard0su_gmail.com added inline comments to D5619: Remove unnecessary sema, use msleep instead.
Mar 13 2016, 12:13 PM

Mar 12 2016

howard0su_gmail.com added inline comments to D5400: hyperv/vmbus: replace hv_guid with uuid.
Mar 12 2016, 2:25 PM
howard0su_gmail.com added reviewers for D5215: Use taskqueue_fast to process messages: sepherosa_gmail.com, honzhan_microsoft.com, decui_microsoft.com.
Mar 12 2016, 2:22 PM
howard0su_gmail.com added reviewers for D5619: Remove unnecessary sema, use msleep instead: sepherosa_gmail.com, decui_microsoft.com, honzhan_microsoft.com.
Mar 12 2016, 2:21 PM
howard0su_gmail.com retitled D5619: Remove unnecessary sema, use msleep instead from to Remove unnecessary sema, use msleep instead.
Mar 12 2016, 2:21 PM

Feb 26 2016

howard0su_gmail.com added a comment to D5436: hyperv: Use mfence to make sure about the store-load order for msgs.

there is more wmb and mb() in the tree. please cleanup them together to switch to atomic(9)

Feb 26 2016, 3:29 AM

Feb 23 2016

howard0su_gmail.com updated D5254: hyperv/vmbus: static assign IDT vector for hv.
Feb 23 2016, 12:00 PM
howard0su_gmail.com updated the diff for D5254: hyperv/vmbus: static assign IDT vector for hv.

update local_apic code to mark IDT_EVTCHN is used when HYPERV is enabled.

Feb 23 2016, 11:57 AM
howard0su_gmail.com added a comment to D5402: hyperv: vmbus: add statistic (stats) for ring buffer.

I suggest we don't create other node under sysctl. each device already have the node in sysctl tree. dev.hn.0 for example. I suggest to put the stats under it.

Feb 23 2016, 11:22 AM
howard0su_gmail.com updated the diff for D5400: hyperv/vmbus: replace hv_guid with uuid.

Implement is_perf_channel parameter in open_channel call

Feb 23 2016, 6:45 AM
howard0su_gmail.com updated the diff for D5400: hyperv/vmbus: replace hv_guid with uuid.

Update the change for utility drivers

Feb 23 2016, 6:39 AM
howard0su_gmail.com updated the test plan for D5343: WIP: hyperv/kvp Cleanup KVP logic.
Feb 23 2016, 4:54 AM
howard0su_gmail.com added reviewers for D5400: hyperv/vmbus: replace hv_guid with uuid: decui_microsoft.com, sepherosa_gmail.com, honzhan_microsoft.com.
Feb 23 2016, 4:52 AM
howard0su_gmail.com retitled D5400: hyperv/vmbus: replace hv_guid with uuid from to hyperv/vmbus: replace hv_guid with uuid.
Feb 23 2016, 4:50 AM
howard0su_gmail.com added a reviewer for D5364: fix acpi idle assert and hv driver.: jhb.
Feb 23 2016, 2:05 AM
howard0su_gmail.com updated the diff for D5364: fix acpi idle assert and hv driver..

Remove unrelated changes

Feb 23 2016, 2:04 AM

Feb 22 2016

howard0su_gmail.com added a comment to D5164: HyperV/vmm: improve locking of hv_ring_buffer.

No. Since read/peek are happened in single thread, no mb is needed. Peek is just a normal read except it copies less data and doesn't advance the read position.

Feb 22 2016, 2:32 AM

Feb 20 2016

howard0su_gmail.com retitled D5364: fix acpi idle assert and hv driver. from to fix acpi idle assert and hv driver..
Feb 20 2016, 7:16 AM