User Details
- User Since
- Nov 17 2015, 5:29 AM (394 w, 3 d)
Aug 19 2021
Jul 17 2018
Looks good to me. I'll commit it shortly.
May 1 2018
Apr 26 2018
I'm hitting a panic with stable/10. Can you please MFC this patch form the HEAD to stable/10?
Mar 23 2018
If there is no new comment, I'm going to commit the patch next week.
Mar 14 2018
I manually tested the patch with releng/{10.3, 10.4, 11.0, 11.1}, stable/{10, 11), and master on local Windows Server 2012 R2, 2016 and Azure, and I don't hit any regression. For Azure testing, I created multiple VMs (Standard D4 v2 (8 vcpus, 28 GB memory) ) in West Central US region and ran a lot of "hot add/remove disks" tests, e.g.
a) hot add and remove a disk on LUN0
b) hot add and remove a disk on LUN1
c) hot add and remove a disk on LUN9
d) hot add and remove a disk on LUN0, and LUN9
e) hot add and remove a disk on LUN1, and LUN9
f) hot add and remove a disk on LUN0~7
g) hot add and remove a disk on LUN0~6, LUN8
h) hot add and remove a disk on LUN1, 9, 10, 11, 12, 13, 14, 15
i) hot add and remove a disk on LUN0, 9, 10, 11, 12, 15, 18, 63
I didn't find any issue.
Sep 1 2017
Aug 31 2017
May 2 2017
Sephe will send out a patchset that will handle the issue in a better way.
Sephe will send out a patchset that will handle the issue in a better way.
We need this patch to make PCIe pass-through work for Hyper-V UEFI VM (Generation 2 VM).
Apr 28 2017
Apr 1 2017
Mar 6 2017
Feb 27 2017
Cc'ed more people to have more input.
Feb 22 2017
Fixed the typo: aviable -> available.
Feb 21 2017
Feb 20 2017
Yes, it's a workaround. Let's try to unblock Hyper-V for the usual case first: currently FreeBSD 10.3, 11, and the HEAD can't boot as UEFI VM on Hyper-V due to this bug.
Feb 15 2017
Thanks! No hurry. This is is only a trivial fix to improve error handling.
We don't have a strong dependency on it at all. Just to make sure I don't forget this patch. :-)
@hselasky, can you please review this patch?
Feb 11 2017
@hselasky, thank you!
@hselasky, thanks Mellanox very much for reviewing and testing the patch!
Feb 10 2017
I assigned enough memory to the VM. :-)
Jan 26 2017
fixed the comment typo pointed out by David.
Jan 9 2017
update the patches per Sephe's comments:
Jan 6 2017
Since sephe's patch (https://reviews.freebsd.org/D8905) is accepted, let me update this patch accordingly.
Let me update the patch, because the previous version causes a sysctl NULL pointer dereferencing issue: we must make sure mlx4_en_sysctl_stat() is called after mlx4_en_create_rx/tx_ring(), otherwise the stat sysctl nodes can't reference the correct ring pointers.
Found a bug in MLX4 VF driver:
in my Hyper-V SR-IOV VF test with MlX ConnectX-3 VF, the VF works fine when the VM has <=12 virtual CPUs, but if the VM has >=13 vCPUs, the VF driver fails to load:
Dec 30 2016
- Moved these bits to the end of hn_stop().
- Call hn_rxfilter_config() by force after the MTU changes.
- fixed a typo in Summary: "to to" -> "to".
This addressed all the comments.
Dec 29 2016
Dec 26 2016
Moved the new field to the end of the struct.
Dec 21 2016
addressed sephe's comment by using a better method: let's move mlx4_en_sysctl_stat() to an earlier place.
Dec 20 2016
Dec 14 2016
updated the patch.
Nov 23 2016
addressed jhb's comment
Nov 22 2016
Added a comment before the line "OLD_FILES+=usr/share/man/man4/hv_ata_pci_disengage.4.gz"
Nov 21 2016
hv_ata_pci_disengage.4.gz doesn't exist for ALL architectures any longer.
Don't forget usr/share/man/man4/hv_ata_pci_disengage.4.gz.
updated ObsoleteFiles.inc accordingly (removing the manuals for ARCHs other than amd64 and i386)
Nov 18 2016
Nov 10 2016
Cleaned up some comments.
Ceaned up vmbus_pcib_detach() according to discussions with Hyper-V team.
Nov 3 2016
This new version addressed jhb's comment: "use bus_read_4(hbus->cfg_res, xxx)".
This new version addressed jhb and sephe's comments.
Good suggestion! I've made a patch with the 2-pass method. Will upload it shortly.
Hi jhb, Thanks for the suggestion! I'll update the patch with the pcib_host_res_* APIs.
Nov 2 2016
I uploaded the new version to address the comments.
This new version addressed Sephe's comments.
This new version addressed Sephe's comment.
Nov 1 2016
The changes to VMBus were moved to 2 separate patches:
https://reviews.freebsd.org/D8410, and
https://reviews.freebsd.org/D8409
removed the get instance guid method, and moved the get_vcpu_id method to a separate patch (https://reviews.freebsd.org/D8410)
Oct 25 2016
Sep 29 2016
Well, I managed to rebase my patch. Will upload it.
Oh, I overlooked the patch.. sorry.
Sep 23 2016
Please review v2.
I moved the MEMEN/PORTEN clear/restore from pci_write_bar() to pci_reserve_map().