Page MenuHomeFreeBSD

mmel (Michal Meloun)
User

Projects

User Details

User Since
Feb 3 2015, 4:54 AM (480 w, 6 d)

Recent Activity

Jan 23 2024

mmel added a comment to D40474: intrng: call pic_init_secondary on all registered PICs.

I think it's the wrong way. The initiation of child PICs is the job of the parent PIC and must be done in right order and in coordination with the parent PIC. Please see D43452 for more details.

Jan 23 2024, 8:17 AM
mmel added a comment to D35899: intrng: Allow alternative IPI PICs to be registered and used.

However, these new IPIs still generate interrupts/exceptions - so some form of more or less abstract PIC is still needed. Of course, if these instructions have evolved into a fixed part of the CPU (that is, the IPI will be generated by the exact instruction and raise an exact exception), we can hardcode it and omit it from INTRNQ...

Jan 23 2024, 8:10 AM
mmel accepted D35898: intrng: Extract arm/arm64 IPI->PIC glue code.
Jan 23 2024, 7:08 AM
mmel accepted D35897: intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg.
Jan 23 2024, 6:23 AM

Jan 17 2024

mmel accepted D43479: arm64: fix db_read_bytes() for size == 8.

Thanks fixing my bugs..

Jan 17 2024, 5:17 PM

Dec 29 2023

mmel added a comment to D43229: tegra210: use UTF-8, not ISO-8859.

Maximum PLL lock time is 20 microsecond. Alternatively, we may use the 'us' to avoid UTF-8 in source files.

Dec 29 2023, 7:20 AM
mmel accepted D43229: tegra210: use UTF-8, not ISO-8859.
Dec 29 2023, 7:11 AM

Sep 24 2023

mmel added a comment to D41565: arm: Add a userspace physical timer check.

I'm afraid that using virtual time outside the hypervisor environment is somewhat problematic, or creates a new (not always fulfilled) dependency on firmware. The virtual timer uses the value stored in CNTVOFF as an offset to generate the timer value. CNTVOFF is stored in a bank with an undefined reset value, so it *MUST* be initialized, otherwise we can end up with a situation where each core will have a different, non-zero value - so each core will have a different time. So the actual code expects someone (firmware, hypervisor) to initialize CNTVOFF on all cores - which is not always true (or better said, it is uncommon in the ARMv7 world and guaranteed in ARM64 ).

Sep 24 2023, 7:17 AM

Sep 23 2023

mmel added a comment to D41946: Add support for host32 for DIRDEPS_BUILD.

This broke (at least) armv7 cross-buildworld on amd64.

Sep 23 2023, 5:50 PM

Sep 14 2023

mmel added a comment to D40161: arm64/intrng: add support for FIQs.

I certainly don't want to block your work. I just don't want to introduce new KPIs that are problematic ( at least for me) for further expansion , nothing else.

Sep 14 2023, 7:28 PM
mmel added a comment to D40161: arm64/intrng: add support for FIQs.

I see. So if I assume that the full implementation should have multiple roots (per type). My main objection is about using bitfield for interrupt type. Is misleading, not much compatible with multiple root implementation and it allows only single bit value almost everywhere.

Sep 14 2023, 9:42 AM

Sep 13 2023

mmel added a comment to D40161: arm64/intrng: add support for FIQs.

The problem is that the FIQ tree may have a different topology than a normal interrupts. So instead of passing flags to the root handler, we should create a new root for the FIQ tree (or for any other type of interrupt), including a new intr_pic_claim_root_<foo>() (or we can convert intr_irq_root_dev and irq_root_* to arrays or so...).

Sep 13 2023, 3:04 AM

Sep 8 2023

mmel accepted D41762: cpufreq_dt: Find the closest frequency.
Sep 8 2023, 5:00 AM
mmel accepted D41767: kern: Globally define abs64.
Sep 8 2023, 5:00 AM

Sep 7 2023

mmel added inline comments to D41762: cpufreq_dt: Find the closest frequency.
Sep 7 2023, 5:56 AM

Aug 13 2023

mmel committed rGe59b6e48f4c8: gdtoa: Regenerate configuration headers for 32-bit arm. (authored by mmel).
gdtoa: Regenerate configuration headers for 32-bit arm.
Aug 13 2023, 7:36 AM

May 9 2023

mmel requested changes to D39333: intrng: expose lower-level device interface for INTRNG.

I strongly disagree, it's a clear step backwards. Intrng was designed with strong layer separation and you are trying to break it in a similar way to x86.
The consumer interface for interrupts is in the kern_intr.c file and no one else is allowed to use it. The provider interface is intr_isrc_*. All other functions should (and must) remain private or unpublished outside of intrng.

May 9 2023, 4:56 AM

Apr 27 2023

mmel accepted D39843: arm: Remove TI code from GENERIC.
Apr 27 2023, 6:36 AM

Apr 26 2023

mmel accepted D39668: arm64: add tests for swp/swpb emulation.

More than enough, thanks. And sorry for starting this in the wrong review.

Apr 26 2023, 7:05 AM
mmel accepted D39667: arm64: emulate swp/swpb instructions.
Apr 26 2023, 7:02 AM

Apr 24 2023

mmel added a comment to D39668: arm64: add tests for swp/swpb emulation.

I see. So in this case can we enable swp emulation using sysctl, disabled by default? I'm worried that this may cause bad behavior for ports build for arm32 - the port may detect swp during build. A bit paranoid, I know.

Apr 24 2023, 6:03 AM

Apr 21 2023

mmel added a comment to D39668: arm64: add tests for swp/swpb emulation.

Hmm, the SWP/SWPB instruction is obsolete in ARMv7 ISA (in favor of atomic operations). It not supported/implemented on ARMv7 SMP cpus and arm32 kernel doesn't support it at all. IMHO we should be consistent at least between arm32 and compat32 on aarch64.

Apr 21 2023, 8:57 AM

Mar 26 2023

mmel accepted D39277: arm64: cpu_switch: don't zero out pcb_onfault.
Mar 26 2023, 4:58 PM

Mar 22 2023

mmel accepted D39013: arm: Introduce MK_KERNEL_BIN to control generation of kernel.bin.

fyi, original idea was provide (not-preferred) way how to (limited) boot FreeBSD on a board with a problematic u-boot that might be locked or need lots of GPL or Linux specific utilities. It was easy for arm64 (where any u-boot can handle a booti image that is generic and has an easy format), but it's hard for armv7, where bootm needs an external program and the resulting image is not generic - it has a built-in load and boot address.
from my current point of view something like user submake stubs will be better (in simple words - be may include and run user definable makefile fragment) -> so system make can try to run this fragment for postprocessing

Mar 22 2023, 6:53 AM

Feb 11 2023

mmel accepted D38437: intrng: track counter allocation with a bitmap.

I like that a lot, I'd do it anyway, thanks. .

Feb 11 2023, 3:42 PM

Jan 17 2023

mmel accepted D32954: Retire non-NEW_PCIB code and remove config option.

IMHO NEW_PCIB is an essential feature for all arm/arm64 FDT based boards. Or more generally, it is essential for all boards where the bootloader/firmware does not fully initialize all PCI hardware, i.e. all systems without ACPI.

Jan 17 2023, 6:05 AM

Jan 3 2023

mmel committed rGe4ef4c5d66c3: extres/phy: Add mode setting function. (authored by mmel).
extres/phy: Add mode setting function.
Jan 3 2023, 9:22 AM

Nov 14 2022

mmel requested changes to D37325: Add clk_list_freq() methods.

I don't think this feature is appropriate for a generic layer. Practically no physical clock can implement it. A PLL can typically produce trillions of discrete frequencies, which makes it practically impossible to enumerate.

Nov 14 2022, 6:59 AM
mmel accepted D37357: Add support for an array of hwresets.

LGTM

Nov 14 2022, 6:26 AM

Oct 29 2022

mmel added inline comments to D36466: FreeBSD enablement for ARM64 in Hyper-V.
Oct 29 2022, 5:24 AM

Oct 28 2022

mmel accepted D34661: arm64: add a spin-table implementation for Apple Silicon.

Thanks .

Oct 28 2022, 8:30 PM
mmel added inline comments to D36744: FreeBSD enablement for ARM64 in Hyper-V.
Oct 28 2022, 8:21 PM
mmel added inline comments to D36466: FreeBSD enablement for ARM64 in Hyper-V.
Oct 28 2022, 8:01 PM

Oct 27 2022

mmel added inline comments to D34661: arm64: add a spin-table implementation for Apple Silicon.
Oct 27 2022, 5:44 AM

Oct 2 2022

mmel added a comment to D36610: kern/intr: implement intrcnt/intrnames sysctl from event counters.

Isn't that a bit (I don't want to say too much) excessive? All that's needed is to teach sysctl about skipping deleted (empty) intrnames, and to add topology sx lock to deliver a consistent view into user space (plus an allocator for free intrnames item in isrc->isrc_index). I'm almost certain that this big unnecessary change is uncommittable.

Oct 2 2022, 5:22 PM
mmel requested changes to D35607: intrng: purge INTR_SOLO.

I see a misunderstanding here.
INTR_SOLO have nothing to do with shared interrupts. It's a fast path for cascading interrupts, and instead of removing it, we should extend it to support pass-through interrupts, polish the API for it, and put it in the regular build. Both of these are common in the arm/aarch64 world, and we lose performance significantly in these cases (and the big question is whether this should help us for LPI interrupts as well).

Oct 2 2022, 5:18 PM

Jul 30 2022

mmel added a comment to D35899: intrng: Allow alternative IPI PICs to be registered and used.

I don't have a single problem with intr_irq_root_dev partitioning. I feel that this implementation (priority based selection) is probably not viable in the long term and it seems to be RISC-V specific (i.e. not suitable for a platform independent framework). But decoupling the IPI controller from the root controller will allow us to do it all in a platform-specific "virtual" layer, so I don't went block you. But I have a slight problem with keeping the fallback IPI functionality in the root interrupt controller. We actually only have a few root controllers in the codebase, so adding a one-line intr_ipi_pic_register() function to all of them is not a big deal, which an reduce future bloating of spaghettis like functionally. What do you think?

Jul 30 2022, 11:50 AM
mmel accepted D35897: intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg.
Jul 30 2022, 11:23 AM

Jul 16 2022

mmel accepted D35764: arm64, qoriq_therm: fix handling sites on version 1 and 2.
Jul 16 2022, 6:58 AM
mmel accepted D35759: arm64, qoriq_therm: configure the number of sites base don SoC.

Perfect, many thanks for cooperation.

Jul 16 2022, 6:52 AM

Jul 10 2022

mmel added a comment to D35759: arm64, qoriq_therm: configure the number of sites base don SoC.

I'm so sorry, but NACK.
This is the wrong way. A thermal sensor is not a thermal zone - > one sensor can be part of multiple zones, and one zone can consist of multiple sensors. The zone is a property of the board/case, while the sensor is (mostly) a property of the SOC. We should not mix them.
Moreover an in this case, since the sensors are located on the SoC, there is no reason why we should not hardcode its name (and number of sensors) directly in the driver.

Jul 10 2022, 4:50 PM

Jul 4 2022

mmel accepted D35701: pca954x: harmonize pca9547 and pca954x and add pca9540 support.
Jul 4 2022, 5:00 AM

Jul 3 2022

mmel added inline comments to D35701: pca954x: harmonize pca9547 and pca954x and add pca9540 support.
Jul 3 2022, 4:00 PM
mmel accepted D35699: dwc3: add more quirks and checks.

That's fine with me, thank you.

Jul 3 2022, 3:46 PM
mmel added a comment to D35699: dwc3: add more quirks and checks.

Only minor nit.
Is necessary to shadow HWPARAMS? Shadowing the HW registry is always a pain and a source of confusion and errors. IMHO it should only be used as a last resort...

Jul 3 2022, 7:01 AM

Jul 1 2022

mmel accepted D35617: arm64: NXP add LS1088a clockgen support.

Thanks

Jul 1 2022, 2:52 PM
mmel added a comment to D35617: arm64: NXP add LS1088a clockgen support.

And why didn't you leave it enabled? IMHO all HWACCEL blocks look the same, so the risk of a possible error is minimal.

Jul 1 2022, 2:07 PM
mmel added a comment to D35617: arm64: NXP add LS1088a clockgen support.

How is '#ifdef HWACCEL3' compatible with the generic kernel and why do we need it at all?

Jul 1 2022, 6:03 AM

Jun 16 2022

mmel added inline comments to D35496: if_dwc: add detach method.
Jun 16 2022, 9:07 AM

Jun 9 2022

mmel accepted D35435: arm64: Fix the condition used to test for AP initialization.

It solved my problem and it boots without any problems on all my arm64 boards. Thanks.

Jun 9 2022, 7:30 AM

Jun 8 2022

mmel added inline comments to D24158: Remove the secondary_stacks array in arm64 and riscv kernels..
Jun 8 2022, 7:29 AM

Feb 25 2022

mmel added a comment to D30560: sdhci: extend bus_dma_tag boundary to 64-bit space.

ping

Feb 25 2022, 7:59 AM

Feb 23 2022

mmel committed rG01f8011736ff: iicbus: Add missing dependency for iicbus module. (authored by mmel).
iicbus: Add missing dependency for iicbus module.
Feb 23 2022, 3:31 PM
mmel added a comment to D34031: bus_if: Add a default implementation of get_property.
In D34031#777724, @mindal_semihalf.com wrote:

Hmm, I just did a simple test by adding a call to kdb_backtrace to ofw_bus_default_get_node and removing ofw_pci.c from the build.
Is this the scenario where you expected ENXIO to be returned from ofw_bus_get_node?
I'm not sure if I understand you correctly here.

Feb 23 2022, 8:45 AM

Feb 22 2022

mmel added a comment to D34031: bus_if: Add a default implementation of get_property.
In D34031#777672, @mindal_semihalf.com wrote:

This only applies to buses derived from simple/ofwbus, not to others (e.g. pci). For other device objects, the ofw_bus_get_node() function returns ENXIO (which may be a valid node ID). However, calling a class function on an object that is not derived from the given class should be considered an error.

Do you mean the case when kobj_lookup_method fails to find anything and we end up in kobj_error_method?
I don't think this is a possible scenario.
The default implementation - ofw_bus_default_get_node returns -1.
Note that BUS_GET_PROPERTY being resolved to simplebus_get_property implies that the bus was derived from ofw.
Because of that the OFW_BUS_GET_NODE will always have an implementation, possibly the default one.

Yes, I mean we end up in kobj_error_method. And that's a very real scenario. In newbus, the default method is only applied for the given class and its subclasses. *Not for all classes*

Feb 22 2022, 10:54 AM
mmel added a comment to D30560: sdhci: extend bus_dma_tag boundary to 64-bit space.

Unfortunately, it looks bad.
Up until SDHCI v3.0, SDMA is strictly 32-bit, only ADMA mode (which we don't support yet, it is optionally 64-bit). As you can see at https://cgit.freebsd.org/src/tree/sys/dev/sdhci/sdhci.c#n1977, the driver ends up writing only the 32-part of buffer physical address to the DMA base register.

Feb 22 2022, 6:29 AM
mmel added a comment to D34333: Support non-posted MMIO on arm64 with FDT.

Just a very minor notice . Wouldn't it be better to name the VM memory attribute by function, not by type? Different architectures may have different attribute mapping requirements for the PCI configuration space, and something like a global VM_MEMATTR_PCI_CONFIG (may be aliased to platform specific VM_MEMATTR_DEVICE_NP on arm64) gives us a much better chance of having cross-platform drivers without #ifdef hell.

Feb 22 2022, 5:54 AM

Feb 21 2022

mmel accepted D30079: Map arm64 pci config memory as non-posted.

Ahh right, thanks.

Feb 21 2022, 5:11 PM
mmel added a comment to D30079: Map arm64 pci config memory as non-posted.

There is also a tegra pcie driver that is common to arm and arm64 , so we should define VM_MEMATTR_DEVICE_NP for arm as well. But I'm not sure if we have the rest of the necessary infrastructure implemented on arm.

Feb 21 2022, 4:39 PM

Feb 20 2022

mmel committed rG7504f32c2e59: ofw_iicbus: Use uint32_t for iic bus address argument, not int. (authored by mmel).
ofw_iicbus: Use uint32_t for iic bus address argument, not int.
Feb 20 2022, 1:49 PM
mmel committed rG960ce3f7b2b0: Fix a534b50e245d on powerpc. (authored by mmel).
Fix a534b50e245d on powerpc.
Feb 20 2022, 1:49 PM
mmel committed rGa534b50e245d: tegra: Improve the detection of the secondary function (RTC) of the MAX77620. (authored by mmel).
tegra: Improve the detection of the secondary function (RTC) of the MAX77620.
Feb 20 2022, 11:39 AM
mmel committed rG1bd3e8ba6966: ofw_iicbus: Add method for manual setting of basic OFW parameters. (authored by mmel).
ofw_iicbus: Add method for manual setting of basic OFW parameters.
Feb 20 2022, 11:39 AM

Feb 18 2022

mmel added a comment to D34031: bus_if: Add a default implementation of get_property.
In D34031#776866, @mindal_semihalf.com wrote:

That's exactly how I initially did this, take a look at https://reviews.freebsd.org/D33457?id=100979#inline-208849.

I see and I think that original implementation was more correct.

Feb 18 2022, 4:26 PM
mmel added a comment to D34031: bus_if: Add a default implementation of get_property.

I don't think that's right. We can't expect that all indirect descendants of simplebus were instantiated by simplebus. Typically all enumerable buses (e.g. pci or multifunction devices represented by single FDT node) are not derived from simplebus. You cannot use ofw_bus_get_node(child) on those.
IMHO we can have a single generic implementation of <foo>_get_property for a given bus , but it should be explicitly defined in the device_methods structure for all appropriate drives.

Feb 18 2022, 2:20 PM

Feb 14 2022

mmel added a comment to D34027: sdhci_fsl_fdt: Fix tuning code.

Yes, I've applied all the patches. The problem is that the HS SD card (i.e. without debugging) also doesn't work and I don't know why.

Feb 14 2022, 1:03 PM
mmel added a comment to D34027: sdhci_fsl_fdt: Fix tuning code.

Due to problems with the D32706 I can't verify this on Honeycomb, plus I've never been able to have a working HW tuning. The current state is that this whole series of patches leaves Honeycomb with a non-functioning SD and eMMC. I currently have almost no free time to hack this problem, so everything is taking forever, sorry :(

Feb 14 2022, 12:20 PM

Feb 7 2022

mmel added a comment to D32706: sdhci_fsl_fdt: Provide more accurate clk calculation.

First of all, I apologize for being too harsh.
The problem is that this patch breaks both SD and eMMC on Honeycomb (LX2160). the eMMC is not detected at all, abd HSSSD card fires out with tons of CRC errors.
Unfortunately however this patch break SD and eMMC on Honezcomb (LX2160).
After further digging, I thing that fsl_sdhc_fdt_set_clock() is broken from day zero.
fsl_sdhc_fdt_set_clock() was supposed to be paired with fsl_sdhc_fdt_get_clock() to perform a conversion of differences between SDHCI and eSDHCl clock register format.

Feb 7 2022, 2:41 PM

Feb 5 2022

mmel added a comment to D32706: sdhci_fsl_fdt: Provide more accurate clk calculation.

Unfortunately this does not work at all and should be reverted.
eSDHC implements two versions of the clock divider, which are selected by the ESDHCCTL[CRS] bit.

Feb 5 2022, 9:17 AM

Jan 31 2022

mmel accepted D34028: sdhci_fsl_fdt: Apply errata for LX2160A.
Jan 31 2022, 9:42 AM
mmel accepted D33981: sdhci_fsl_fdt: Fix pulse width errata application.
Jan 31 2022, 9:41 AM

Jan 20 2022

mmel committed rGd6529c0d12a2: pci_dw_mv: Don't enable unhandled interrupts. (authored by mmel).
pci_dw_mv: Don't enable unhandled interrupts.
Jan 20 2022, 10:37 AM
mmel committed rG139afdb1721f: simple_mfd: switch to controllable locking for syscon provider. (authored by mmel).
simple_mfd: switch to controllable locking for syscon provider.
Jan 20 2022, 10:35 AM
mmel committed rG8c12f9dea14f: mvebu_gpio: fix interrupt cause register configuration (authored by mw).
mvebu_gpio: fix interrupt cause register configuration
Jan 20 2022, 10:25 AM
mmel committed rG40a0633862cd: mvebu_gpio: Fix settings of gpio pin direction. (authored by mmel).
mvebu_gpio: Fix settings of gpio pin direction.
Jan 20 2022, 10:25 AM
mmel committed rG9ddb35ef1fd2: mvebu_gpio: Multiple fixes. (authored by mmel).
mvebu_gpio: Multiple fixes.
Jan 20 2022, 10:24 AM
mmel committed rGf84b424eaf23: tegra/ahci: do not advertise enclosure management facility (authored by mmel).
tegra/ahci: do not advertise enclosure management facility
Jan 20 2022, 10:20 AM
mmel committed rG7a647bb04500: tegra124: Implement new get_gate method for tegra124 clocks. (authored by mmel).
tegra124: Implement new get_gate method for tegra124 clocks.
Jan 20 2022, 10:19 AM
mmel committed rG6f63b227bd2b: tegra210: Implement new get_gate method for tegra210 clocks. (authored by mmel).
tegra210: Implement new get_gate method for tegra210 clocks.
Jan 20 2022, 10:19 AM
mmel committed rGf277be277de7: extres/clk: Add a method to detect the HW state of the clock gate. (authored by mmel).
extres/clk: Add a method to detect the HW state of the clock gate.
Jan 20 2022, 10:19 AM
mmel committed rG3d4b9e5fa16a: extres/clk: Improve sysctl dump of clocks. (authored by mmel).
extres/clk: Improve sysctl dump of clocks.
Jan 20 2022, 10:18 AM
mmel committed rG79631b49eeda: arm: Fix handling of undefined instruction aborts in THUMB2 mode. (authored by mmel).
arm: Fix handling of undefined instruction aborts in THUMB2 mode.
Jan 20 2022, 10:14 AM
mmel committed rGa5e76683b2de: dwmmc: Calculate the maximum transaction length correctly. (authored by mmel).
dwmmc: Calculate the maximum transaction length correctly.
Jan 20 2022, 10:14 AM
mmel committed rG8e3cc69a4e4a: booti: Enable loading the kernel image to any address aligned to 2 MB (authored by mmel).
booti: Enable loading the kernel image to any address aligned to 2 MB
Jan 20 2022, 10:14 AM
mmel committed rG2ace1585b0f6: intrng: remove now redundant shadow variable. (authored by mmel).
intrng: remove now redundant shadow variable.
Jan 20 2022, 10:10 AM
mmel committed rGa3ccd06dd965: intrng: Releasing interrupt source should clear interrupt table full state. (authored by mmel).
intrng: Releasing interrupt source should clear interrupt table full state.
Jan 20 2022, 10:10 AM
mmel committed rG57dd17dd60e7: Fix error value returned by ofw_bus_gen_get_node(). (authored by mmel).
Fix error value returned by ofw_bus_gen_get_node().
Jan 20 2022, 10:07 AM

Jan 10 2022

mmel added inline comments to D33804: Remove the arm FIQ support.
Jan 10 2022, 2:49 PM

Jan 6 2022

mmel accepted D33761: libsoft: Remove.

LGTM

Jan 6 2022, 7:31 AM

Dec 30 2021

mmel accepted D33697: loader: tftp: Copy the first block into the cache.

Tried and tested - it fixes my previous problem, thanks.

Dec 30 2021, 11:07 AM

Dec 27 2021

mmel added a comment to D33445: clk: add initial frequency / gate config methods.

You know I'm "creative", especially when it comes to booting SBC.
The failing sequence is:

Dec 27 2021, 9:02 AM

Dec 26 2021

mmel accepted D33445: clk: add initial frequency / gate config methods.
Dec 26 2021, 12:05 PM

Dec 25 2021

mmel added a comment to D33410: loader: tftp: Add preload method.

Unfortunately thiss broke tftp kernel loading.
The tftp_open() function will prefetch the first block and leave tftpfile->currblock set to 1, so the first block is never loaded into the cache.
The trivial fix is to reset it back to 0, it works for me but I'm not sure if that's the right solution.

Dec 25 2021, 2:42 PM

Dec 24 2021

mmel committed rG6e9119768dad: tegra/ahci: do not advertise enclosure management facility (authored by mmel).
tegra/ahci: do not advertise enclosure management facility
Dec 24 2021, 7:38 PM
mmel committed rGbe01656fa4cd: tegra124: Implement new get_gate method for tegra124 clocks. (authored by mmel).
tegra124: Implement new get_gate method for tegra124 clocks.
Dec 24 2021, 7:17 PM
mmel committed rG7c0ec6638548: tegra210: Implement new get_gate method for tegra210 clocks. (authored by mmel).
tegra210: Implement new get_gate method for tegra210 clocks.
Dec 24 2021, 6:45 PM
mmel committed rG1a74d77f8512: extres/clk: Add a method to detect the HW state of the clock gate. (authored by mmel).
extres/clk: Add a method to detect the HW state of the clock gate.
Dec 24 2021, 6:45 PM
mmel committed rG72a2f3b5e28a: extres/clk: Improve sysctl dump of clocks. (authored by mmel).
extres/clk: Improve sysctl dump of clocks.
Dec 24 2021, 6:45 PM

Dec 23 2021

mmel requested changes to D33445: clk: add initial frequency / gate config methods.

Sorry for the strong language, please don't take it the wrong way.
clknode_init_freq_value() - this function is completely unnecessary, and only complicates an already complicated interface. Moreover, it is only used here as papering over a real problem in sysctl dump code. Ii really don't want that.

Dec 23 2021, 9:30 AM

Dec 10 2021

mmel accepted D33372: Fix set but not used warnings in arm64 rockchip.

LGTM

Dec 10 2021, 12:30 PM