Page MenuHomeFreeBSD
Differential D47847

arm: Use constants from sys/intr.h, not genassym
ClosedPublic
Actions

Authored by imp on Nov 29 2024, 9:22 PM.
Tags
None
Referenced Files
F146448732: D47847.id.diff
Mon, Mar 2, 6:55 PM
Unknown Object (File)
Mon, Mar 2, 12:59 PM
Unknown Object (File)
Mon, Mar 2, 1:34 AM
Unknown Object (File)
Jan 26 2026, 12:34 PM
Unknown Object (File)
Jan 26 2026, 12:33 PM
Unknown Object (File)
Jan 26 2026, 12:33 PM
Unknown Object (File)
Jan 26 2026, 2:14 AM
Unknown Object (File)
Jan 26 2026, 2:00 AM
View All Files
Subscribers
ehem_freebsd_m5p.com
emaste
riscv

Details

Reviewers
kevans
mmel
andrew
manu
Commits
rGd1e843b3f976: arm: Use constants from sys/intr.h, not genassym
Summary

We can now include sys/intr.h to get these constants rather than using
genassym. Opt for this simpler method.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Nov 29 2024, 9:22 PM
Herald added a reviewer: andrew. · View Herald TranscriptNov 29 2024, 9:22 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, emaste. · View Herald Transcript
imp requested review of this revision.Nov 29 2024, 9:22 PM
imp added a parent revision: D47846: sys/intr.h: Make it safe to include from assembler.
Harbormaster completed remote builds in B60886: Diff 147178.Nov 29 2024, 9:22 PM
imp added a child revision: D47848: genassym: Remove stale *if.h depends.Nov 29 2024, 9:22 PM
andrew accepted this revision.Nov 29 2024, 9:29 PM
This revision is now accepted and ready to land.Nov 29 2024, 9:29 PM
ehem_freebsd_m5p.com added a subscriber: ehem_freebsd_m5p.com.Nov 29 2024, 10:22 PM

I dislike making the interrupt headers assembly-safe merely for this. If this is really desired, then have the all constants in machine/intr.h (which is better anyway).

mmel accepted this revision.Nov 30 2024, 12:24 PM
Closed by commit rGd1e843b3f976: arm: Use constants from sys/intr.h, not genassym (authored by imp). · Explain WhyDec 6 2024, 5:55 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGd1e843b3f976: arm: Use constants from sys/intr.h, not genassym.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
1 line
4 lines
arm64/
arm64/
1 line
5 lines
riscv/
riscv/
2 lines

Diff 147610

View Options

sys/arm/arm/exception.S

Loading...
View Options

sys/arm/arm/genassym.c

Loading...
View Options

sys/arm64/arm64/exception.S

Loading...
View Options

sys/arm64/arm64/genassym.c

Loading...
View Options

sys/riscv/riscv/genassym.c

Loading...