Sat, Dec 8
Fri, Dec 7
Wed, Dec 5
markj: Regarding the question on pxm prefix. I used the convention starting with the filename. I kind of settled for acpi_pxm since I could not think of a better filename and prefix (which covers SRAT for resource affinity and SLIT for locality).
Tue, Dec 4
markj: please see the inline comment, and let me know if think there is further changes needed. Thanks.
Mon, Dec 3
This mostly LGTM, a couple of nits inline.
Sat, Dec 1
Fri, Nov 30
Thu, Nov 29
There is also problem with the pinctrl (I have this mostly worked out now).
I2C doesn't work (doesn't know why for now).
Some clocks IDs aren't correct.
I honestly don't know how this was tested.
Wed, Nov 28
Only ppll is in pmucru.. you mean it has different rates?
This doesn't work.
The PLL in the pmucru are wait different.
Currently building world for my rockpro64, will test and commit after.
Fri, Nov 23
Mon, Nov 19
Addressed comments from jhb's review:
- fixed comment stye & reworded as suggested.
- removed 'id' field until it is needed (in a later patch)
Fri, Nov 16
Thanks for the review, will update the diff with the changes (and a fix related use of max).
Thu, Nov 15
Wed, Nov 14
looks good to me. thanks.
Tue, Nov 13
Nov 11 2018
Nov 3 2018
Oct 30 2018
can you, please, subclass phy to USB specialized variant (say phyusb or usbphy)? You can use clk (clkdiv, clkmux ...) as template. We should implement lots of USB OTG related function here. VBUS voltage and over-current detection, ID pin status change interrupt, OTG state machine and I thing that should use proper layering from beginning.
If you too busy for this, I can implement (empty) subclass in next 2-3 days.
Oct 29 2018
Oct 22 2018
removed pmu driver
I meant to set this to "request changes", sorry.
Oct 12 2018
This looks good, just remove the pmu driver for now as we don't use it.
Aug 16 2018
few style notes
Aug 15 2018
Jun 5 2018
Jun 4 2018
other than the minor style nits, this looks good.
May 25 2018
s/all SDHCI/all MMC/