Aug 16 2018
few style notes
Aug 15 2018
Jun 5 2018
Jun 4 2018
other than the minor style nits, this looks good.
May 25 2018
s/all SDHCI/all MMC/
May 12 2018
May 9 2018
Given the simplicity of this unwinding code, I think it's reasonable to just keep it inline like we do on amd64. DTrace reimplements quite a lot of "standard" code for the same reason as we do here.
May 8 2018
Preemptively remove a redundant check for INKERNEL(fp).
Why not just exclude it in fbt_provide_module_function? I'd prefer we keep the unwinding code together, maybe with a comment that it may be called from such a context.
however, in the future a patch that enabled instrumentation of inlined functions could accidentally break DTrace on aarch64.
Ok for me, also tested on pine64
Nov 26 2017
Don't allow PSR_AARCH32 to be set in sigreturn().
Considering that there is no need to split up this into two code paths for 32-bit/64-bit at least for what I'm trying to achieve, would you mind if I went ahead, committing this change as is? Once this change and D13148 land, I can work towards getting the sysent for cloudabi32 committed.
Nov 24 2017
Nov 19 2017
Announce armv7 instead of armv6.
Are we expecting to run armv6 code, or should we just support armv7?
This will allow userspace to switch between AArch64 and AArch32 via sigreturn. sys_sigreturn has checks on the PSR bits to ensure they are safe to install that this will break.
I split the syncronous exception out into a new handler in my compat32 patch as it allows further sanity checks, e.g. that the kernel thinks the current process should be in 32-bit mode.