Hi! Can we have a little skeleton manpage in this commit? Here is an example of a minimum implementation that is enormously useful, just 40 lines: https://freshbsd.org/freebsd/src/commit/fd1ee28bd01429aa8c38199d5fc069e8b0b75442

All of these clock drivers share too much common code. Firstly, why don't you subclass these from the base class in mdtk_clk.c? If that's not sufficient, why don't you use a new base class that implements all this glue and subclass it?

I fixed style(9) issues.

I fixed the copyright in the source code.

I fixed 8 space tabs.

This looks fairly good, modulo the style issues.

address copyright/dates

OT: I just scheduled an Amazon.co.uk return of an RK3399 based system, because the seller didn't provide the required accessories (case, PSU, MicroSD boot media, and HDMI-C cabling). What I actually wanted/needed was a BeagleBone Black, as IEEE 1588 is what I'm turning up...

In D43399#1179757, @christos wrote:

Please rebase all relevant patches, including this one, on top of main, stack them properly, and also re-generate and update the diffs with full context: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Please rebase all relevant patches, including this one, on top of main, stack them properly, and also re-generate and update the diffs with full context: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Can you please:

• Rebase it on top of the current main branch.
• Generate the diffs with full context git diff -U999999.
• Organize the commit message, test plan and additional notes. Things are a bit all over the place now.

The gic_page_size change should be split out to a new review.

This is a showstopper for Snapdragon Elite support...

git diff -U999999