Mar 29 2022
Feb 17 2022
I'll do the commit. Thanks to Greg for writing this and to everyone who helped to review it!
Feb 16 2022
Who is going to do the actual commit? I'm happy to do it if no-one else wants to? Whoever does it has csprng@ green-light.
Last nit can be done pre-commit or I can whack it post-commit; ok from lua perspective.
Is this ready to be committed? I'm happy to do it myself but markm said he was going to commit (prior to the latest round of changes) -- don't want to commit prematurely if you're still waiting for something.
Feb 8 2022
Jan 29 2022
Jan 28 2022
Yep, I've had basically the exact same opinion as @delphij about the copyright. Let's go with Intel.
Jan 27 2022
Jan 26 2022
So seems like it's easier to just do it all in core.lua, which is where lots of config accesses are anyway.
Jan 17 2022
Jan 16 2022
err, I have not addressed the "isUEFIBoot" thing and the "This file needs a copyright / license at the top" thing…
Jan 15 2022
Thanks! Can you also MFC it to stable/13 after a week?
Jan 14 2022
Is this waiting for anything else before it gets committed?
Nov 16 2021
Nov 15 2021
I did a minor edit on the proposed commit message to clarify some things (sorry I do not have it as a diff)
As a result, although the tests on 32-bit architectures with ASLR enabled were
mostly on par with what was observed on 64-bit ones, the defaults for the
former are not changed. Also, for the sake of safety keep the feature disabled for 32-bit
executables on 64-bit machines, too.
Yes, leave it. I think it is verbose but explicit so that more people can notice that if pointed to.
I suggest also dropping the
In case any change in the OS behavior is observed, that can be possibly caused by this patch, it is recommended to use email@example.com mailing list for reporting and discussing the encountered issue. Also,
Nov 12 2021
I think it is better to provide short and concise list of potential issues with ASLR, like this:
- changed ABI due to modified layout of address space
- address space fragmentation
- non-reproducable address space layout between runs
- harder debugging
- some debuggers automatically disable ASLR for spawned targets, making target' environment different between debug and non-debug runs
Nov 4 2021
Limit setting of __elfN(pie_aslr_enabled) for only 64-bit PIE binaries.
Nov 2 2021
Typo to fix on commit but otherwise looks fine to me
Nov 1 2021
Oct 29 2021
Hi! Any comments/remarks to the updated version?
Oct 27 2021
Collect all PPIs since they indeed could be different on different CPUs
(Though we're not at all set up to be able to handle that if that's true...)