Sorry, I was too brief. In the past, Martin gave me many versions of the clock code for pre-review, so I have a tendency to respond briefly.
The issue is the audsys/audiosys driver (at least, I didn't check the other clocks). It is not a leaf node, but it has subnodes, so it must implement the simplebus class together with the MT_CLK class. This is impossible in the current situation because both classes have their own softc.
The audsys driver version in review only derives simplebus, which means it cannot work at all. It doesn't have a method for physical access to clock related registers or locking functions (CLKDEV interface).

In D58812#1350834, @mmel wrote:

This code is fundamentally incomplete and unusable in its current state.

• All PLL clocks are crudely faked with fixed clock events instead of being dynamic, without any check.
• The UART silently accepts and programs invalid baud rates without any error reporting.
  • pinctrl implements barely ~10% of the properties defined in the bindings, rendering it effectively useless. -Several clock driver nodes (simplebus being a clear example) lack required functionality and must be rewritten from scratch.

This code is nowhere near ready and demands substantial rework. I'm sorry, but the quality of this AI slope is significantly below my acceptance limit.

This code is fundamentally incomplete and unusable in its current state.

• All PLL clocks are crudely faked with fixed clock events instead of being dynamic, without any check.
• The UART silently accepts and programs invalid baud rates without any error reporting.
  • pinctrl implements barely ~10% of the properties defined in the bindings, rendering it effectively useless. -Several clock driver nodes (simplebus being a clear example) lack required functionality and must be rewritten from scratch.

This code is nowhere near ready and demands substantial rework. I'm sorry, but the quality of this AI slope is significantly below my acceptance limit.

This in general looks fine. I'll go try building it in a day or two. thanks!

Fix the review and remove foreign code

I remove panic() functions

Hi! Can we have a little skeleton manpage in this commit? Here is an example of a minimum implementation that is enormously useful, just 40 lines: https://freshbsd.org/freebsd/src/commit/fd1ee28bd01429aa8c38199d5fc069e8b0b75442

All of these clock drivers share too much common code. Firstly, why don't you subclass these from the base class in mdtk_clk.c? If that's not sufficient, why don't you use a new base class that implements all this glue and subclass it?

I fixed style(9) issues.

I fixed the copyright in the source code.

I fixed 8 space tabs.

This looks fairly good, modulo the style issues.

address copyright/dates

OT: I just scheduled an Amazon.co.uk return of an RK3399 based system, because the seller didn't provide the required accessories (case, PSU, MicroSD boot media, and HDMI-C cabling). What I actually wanted/needed was a BeagleBone Black, as IEEE 1588 is what I'm turning up...

In D43399#1179757, @christos wrote:

Please rebase all relevant patches, including this one, on top of main, stack them properly, and also re-generate and update the diffs with full context: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Please rebase all relevant patches, including this one, on top of main, stack them properly, and also re-generate and update the diffs with full context: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface