Page MenuHomeFreeBSD

karels (Mike Karels)
User

Projects

User Details

User Since
Mar 1 2015, 6:19 PM (225 w, 2 d)

Recent Activity

Apr 22 2019

karels added inline comments to D19594: Fix udp_output() locking strategy in one case.
Apr 22 2019, 12:22 PM

Mar 19 2019

karels accepted D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

Although I have a couple of inline comments, I wouldn't object to committing this as-is. Touching up would be fine too.

Mar 19 2019, 6:34 AM

Mar 7 2019

karels accepted D19490: Improve ARP logging.

This seems good to me. If this is not to be MFC'd, compatibility wouldn't matter (in which case I wouldn't have reduced the number of spares). It's nice to have things in order, but maybe this isn't the time to break compatibility given the small scope.

Mar 7 2019, 11:46 PM
karels added inline comments to D19490: Improve ARP logging.
Mar 7 2019, 1:39 AM

Feb 26 2019

karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

I agree with John that we should do everything we can to eliminate class A/B/C rather than just shuffle it around. Removing those macros will cause some turmoil; e.g. libc's inet_netof and inet_lnaof assume classes, and don't know about local netmasks. They should probably go away. I don't know how painful that will be. But we are way overdue to get rid of this stuff, and it appears that Linux (Ubuntu) doesn't have them. But the old A/B/C are a somewhat different problem than making Class E usable.

Feb 26 2019, 11:59 PM

Feb 25 2019

karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

Hi, John! Very, very long time no (anything). I am very happy to see tests in this area. I certainly expect this to work with minimal changes (i.e. this one). Re: Classs A/B/C: I'd be quite happy to see those definitions go away. Re: "loopback net": I'm aware of a small number of things using that other than 127.0.0.1 (including one of my company's legacy products), but they are minor. I still remember driving a Sun workstation crazy by pinging 127.0.0.2 (there was a network route, but obviously only one address recognized.).

Feb 25 2019, 12:44 AM

Feb 24 2019

karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

Sorry, that reference should have been RFC 1112, not RFC 112.

Feb 24 2019, 6:57 PM
karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

It looks like I am the guilty party in calling Class E IN_EXPERIMENTAL, which went in when "Class D" became multicast. I suspect it was actually called that in some document, although it doesn't really matter. https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml doesn't call it Class E, but refers to RFC112, which does. In any case, assuming that https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml is still current, the treatment is the same.

Feb 24 2019, 6:40 PM
karels added inline comments to D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.
Feb 24 2019, 5:52 PM
karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

I don't understand the purpose of this review. As it says, these changes should not be committed. I'm not actually sure of the official status of Class E, although I suspect it is still experimental/not for production use.

Feb 24 2019, 5:45 PM
karels accepted D18904: Make arp return errors.
Feb 24 2019, 2:31 PM
karels added a comment to D18904: Make arp return errors.

Generally looks good, one small comment inline.

Feb 24 2019, 1:48 PM

Jan 26 2019

karels added a comment to D18904: Make arp return errors.

I agree that arprequest_int is rather opaque. At first I thought that is was just the version that returns int, which is not useful. arprequest_internal would be better. Otherwise, I have no objection; returning any errors seems like a good thing. And yes, I did not see any of the earlier (presumed) emails for this review.

Jan 26 2019, 11:43 PM

Dec 8 2018

karels committed rS341737: MFC r340474:.
MFC r340474:
Dec 8 2018, 2:54 PM

Nov 16 2018

karels committed rS340474: Fix flags collision causing inability to enable CBQ in ALTQ.
Fix flags collision causing inability to enable CBQ in ALTQ
Nov 16 2018, 3:42 AM
karels closed D17758: Fix flags collision causing inability to enable CBQ in ALTQ.
Nov 16 2018, 3:42 AM

Oct 30 2018

karels created D17758: Fix flags collision causing inability to enable CBQ in ALTQ.
Oct 30 2018, 1:32 AM

Sep 22 2018

karels added a comment to D17246: Hold a write lock across udp_notify().

LGTM also

Sep 22 2018, 12:17 PM

Sep 19 2018

karels accepted D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates.

It would be good to see if the crashes stop before committing this, but it looks right to me.

Sep 19 2018, 12:01 AM

Sep 6 2018

karels accepted D17062: Cleanup unused inpcb fields/flags.
Sep 6 2018, 7:35 PM

Sep 3 2018

karels accepted D17006: Apply RO_RTFREE() to more places.
Sep 3 2018, 8:01 PM
karels accepted D17007: Appl RO_INVALIDATE_CACHE() to more netinet6 code.
Sep 3 2018, 7:58 PM
karels accepted D17004: Remove code duplicating in route.h.
Sep 3 2018, 7:56 PM
karels accepted D17005: Adjust inp_route to inp_route6 in netinet6 code.
Sep 3 2018, 7:55 PM

Sep 1 2018

karels added a comment to D16654: IPv6 transport for bsnmp.

I believe I understand the issue with route caching. in6_selectroute_fib checks for loopback,and substitutes the interface with the local address. ip6_output doesn't need to know that interface, it should just skip the scope check in that case. I'll email a possible kernel patch to Andrey and Harti.

Sep 1 2018, 12:47 PM

Aug 28 2018

karels added a comment to D6262: Implement L2 lookup caching for TCP and UDP.

You are right, inp_route6 would be better. I'm sure I copied and pasted, then didn't make as many changes as I should have. I will happily approve a review to make that change if you test that it compiles :-).

Aug 28 2018, 12:31 AM

May 17 2018

karels added a comment to D15459: Use __SCCSID for SCCS IDs in libkvm sources..

Looks good to me. I could go either way on the blank line.

May 17 2018, 1:47 AM

Mar 10 2018

karels committed rS330712: Change ps(1) output width to unlimited if not interactive.
Change ps(1) output width to unlimited if not interactive
Mar 10 2018, 12:11 AM
karels closed D14614: Change ps(1) output width to unlimited if not interactive.
Mar 10 2018, 12:11 AM

Mar 9 2018

karels added a comment to D14614: Change ps(1) output width to unlimited if not interactive.

Thanks for catching the typo.

Mar 9 2018, 12:58 AM

Mar 8 2018

karels created D14614: Change ps(1) output width to unlimited if not interactive.
Mar 8 2018, 12:57 AM

Feb 28 2018

karels committed rS330091: Revert r314685 in ps.
Revert r314685 in ps
Feb 28 2018, 12:17 AM
karels closed D14530: Revert r314685 in ps.
Feb 28 2018, 12:17 AM

Feb 27 2018

karels created D14530: Revert r314685 in ps.
Feb 27 2018, 12:42 AM

Feb 10 2018

karels added a comment to D14291: Allow route change requests to not specify the gateway..

I agree with the change as well; the regression seems to have happened when the code was refactored and the "add" and "change" code became joined.

Feb 10 2018, 7:30 PM

Jan 23 2018

karels accepted D13990: Increment the route table gen count after a modify.

Looks good.

Jan 23 2018, 1:52 AM

Jan 22 2018

karels accepted D13989: Reduce code duplication for inpcb route caching.
Jan 22 2018, 5:38 AM
karels accepted D13988: Invalidate inpcb LLE cache if cached route is invalidated.
Jan 22 2018, 5:38 AM
karels added a comment to D13988: Invalidate inpcb LLE cache if cached route is invalidated.

Got it. I didn't realize it, but Phabricator lists the reviews in reverse order, so that's the order I looked at them.

Jan 22 2018, 5:38 AM

Jan 20 2018

karels added a comment to D13990: Increment the route table gen count after a modify.

I just realized that this is necessary when the L3 gateway changes. The L3 cache doesn't need to be invalidated, but L2 does. A comment to this effect would be helpful.

Jan 20 2018, 3:19 AM
karels added a comment to D13988: Invalidate inpcb LLE cache if cached route is invalidated.

Could this use the new invalidate macro?

Jan 20 2018, 2:59 AM
karels added a comment to D13989: Reduce code duplication for inpcb route caching.

Was there a place where only L3 was invalidated?

Jan 20 2018, 2:37 AM
karels added a comment to D13990: Increment the route table gen count after a modify.

Why is this necessary, or desirable? If a route that is cached is modified, that doesn't invalidate it. It should still be the best route if it was before.

Jan 20 2018, 2:32 AM

Jan 13 2018

karels committed rS327923: Add info about SW_WATCHDOG change to be dynamic in the common case..
Add info about SW_WATCHDOG change to be dynamic in the common case.
Jan 13 2018, 2:15 PM
karels committed rS327920: MFC r327505:.
MFC r327505:
Jan 13 2018, 2:10 PM

Jan 3 2018

karels committed rS327512: Add info about SW_WATCHDOG change to be dynamic in the common case..
Add info about SW_WATCHDOG change to be dynamic in the common case.
Jan 3 2018, 6:41 AM
karels committed rS327505: make SW_WATCHDOG dynamic.
make SW_WATCHDOG dynamic
Jan 3 2018, 12:56 AM
karels closed D13713: make SW_WATCHDOG dynamic.
Jan 3 2018, 12:56 AM

Jan 2 2018

karels added inline comments to D13713: make SW_WATCHDOG dynamic.
Jan 2 2018, 5:40 AM
karels updated the diff for D13713: make SW_WATCHDOG dynamic.

Tweak man page

Jan 2 2018, 5:31 AM

Jan 1 2018

karels added a comment to D13713: make SW_WATCHDOG dynamic.

A list of ioctl names didn't seem very useful to me, so I extracted the information from the header file.

Jan 1 2018, 4:16 PM
karels updated the diff for D13713: make SW_WATCHDOG dynamic.

Update man page

Jan 1 2018, 4:15 PM
karels added a comment to D13713: make SW_WATCHDOG dynamic.

IIRC, there are ten of these ioctls, although I didn't add any. I thought I'd correct the obvious out-of-date statement, but wasn't sure I could correctly document all of those added over time. Suggestions?

Jan 1 2018, 2:11 AM

Dec 31 2017

karels added a comment to D13713: make SW_WATCHDOG dynamic.

Rod, perhaps you have never needed this functionality; but have you ever had a system hang? Along the same lines, there are probably about 1000 bits of code that you haven't needed in the kernel; should we add options to remove each of them? This way lies madness. There are two hardclock routines; which are you using? Should we ifdef out the other?

Dec 31 2017, 6:07 PM
karels added a comment to D13713: make SW_WATCHDOG dynamic.

Sorry, my last comment was responding to imp@; it crossed with the comment from rgrimes.

Dec 31 2017, 5:33 PM
karels added a comment to D13713: make SW_WATCHDOG dynamic.

Thanks. About loadable hardware watchdogs: that should work if they attach before watchdogd starts.

Dec 31 2017, 5:18 PM
karels created D13713: make SW_WATCHDOG dynamic.
Dec 31 2017, 2:49 PM

Dec 18 2017

karels committed rS326928: MFC r326734:.
MFC r326734:
Dec 18 2017, 5:29 AM

Dec 9 2017

karels committed rS326734: gifconfig_gif0 no longer works, document replacement.
gifconfig_gif0 no longer works, document replacement
Dec 9 2017, 5:28 PM
karels closed D13130: gifconfig_gif0 no longer works, document replacement.
Dec 9 2017, 5:28 PM

Nov 27 2017

karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Update date.

Nov 27 2017, 11:03 PM

Nov 25 2017

karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Fix macro usage, update text

Nov 25 2017, 11:05 PM

Nov 24 2017

karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 24 2017, 10:03 PM

Nov 18 2017

karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 6:41 PM
karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 6:16 PM
karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Another attempt to clarify, flesh out example.

Nov 18 2017, 6:11 PM
karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 3:07 PM
karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 3:51 AM

Nov 17 2017

karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Update Dd date

Nov 17 2017, 10:01 AM
karels created D13130: gifconfig_gif0 no longer works, document replacement.
Nov 17 2017, 5:07 AM

Sep 26 2017

karels added inline comments to D12430: tcp: Don't "negotiate" MSS..
Sep 26 2017, 3:35 AM
karels added inline comments to D12430: tcp: Don't "negotiate" MSS..
Sep 26 2017, 3:10 AM

Sep 24 2017

karels accepted D12430: tcp: Don't "negotiate" MSS..

I hadn't noticed this snippet of code before. It was definitely wrong.

Sep 24 2017, 1:36 PM

Aug 29 2017

karels closed D10135: Enable route and LLE (ndp) caching in TCP/IPv6.

Commited in https://reviews.freebsd.org/rS316065

Aug 29 2017, 12:33 PM

Apr 22 2017

karels committed rS317286: MFC r316065: Enable route and LLE (ndp) caching in TCP/IPv6.
MFC r316065: Enable route and LLE (ndp) caching in TCP/IPv6
Apr 22 2017, 6:55 PM

Apr 10 2017

karels committed rS316668: Fix reference count leak with L2 caching..
Fix reference count leak with L2 caching.
Apr 10 2017, 1:26 AM

Mar 27 2017

karels committed rS316065: Enable route and LLE (ndp) caching in TCP/IPv6.
Enable route and LLE (ndp) caching in TCP/IPv6
Mar 27 2017, 11:48 PM

Mar 25 2017

karels created D10135: Enable route and LLE (ndp) caching in TCP/IPv6.
Mar 25 2017, 4:38 PM
karels closed D10059: Fix reference count leak with L2 caching. by committing rS315956: Fix reference count leak with L2 caching..
Mar 25 2017, 3:06 PM
karels committed rS315956: Fix reference count leak with L2 caching..
Fix reference count leak with L2 caching.
Mar 25 2017, 3:06 PM

Mar 20 2017

karels added reviewers for D10059: Fix reference count leak with L2 caching.: gnn, ae.
Mar 20 2017, 12:37 AM
karels created D10059: Fix reference count leak with L2 caching..
Mar 20 2017, 12:27 AM

Dec 31 2016

karels added a comment to D8904: inet: Fix routing issue by calling if_up().

I think the change is a step in the right direction. Certainly, "ifconfig xxN down" followed by an implicit UP should not cause any change to the routing table. Does anyone know why the "down" is removing the route? That seems wrong to me.

Dec 31 2016, 5:47 PM
karels added a comment to D8905: if: Defer the if_up until the ifnet.if_ioctl is called..

Seems fine to me; will let someone else approve.

Dec 31 2016, 5:45 PM

Sep 21 2016

karels committed rS306060: MFC r304713:.
MFC r304713:
Sep 21 2016, 12:07 AM

Aug 24 2016

karels closed D7591: Fix L2 caching for UDP over IPv6 by committing rS304713: Fix L2 caching for UDP over IPv6.
Aug 24 2016, 12:52 AM
karels committed rS304713: Fix L2 caching for UDP over IPv6.
Fix L2 caching for UDP over IPv6
Aug 24 2016, 12:52 AM

Aug 22 2016

karels committed rS304642: MFC r304546: Disable L2 caching for UDP over IPv6.
MFC r304546: Disable L2 caching for UDP over IPv6
Aug 22 2016, 10:30 PM
karels added a reviewer for D7591: Fix L2 caching for UDP over IPv6: peter.
Aug 22 2016, 5:03 AM
karels added a comment to D7591: Fix L2 caching for UDP over IPv6.

btw, the second chunk (first after include) is new since original version.

Aug 22 2016, 4:52 AM
karels added a comment to D7591: Fix L2 caching for UDP over IPv6.

This patch has been tested by Mike Andrews, who will continue monitoring. I've asked Peter if he can test.

Aug 22 2016, 4:39 AM
karels retitled D7591: Fix L2 caching for UDP over IPv6 from to Fix L2 caching for UDP over IPv6.
Aug 22 2016, 4:02 AM

Aug 20 2016

karels committed rS304546: MFC r304545: Disable L2 caching for UDP over IPv6.
MFC r304545: Disable L2 caching for UDP over IPv6
Aug 20 2016, 8:56 PM
karels committed rS304545: Disable L2 caching for UDP over IPv6.
Disable L2 caching for UDP over IPv6
Aug 20 2016, 8:47 PM

Aug 14 2016

karels committed rS304088: MFC r303978: Fix kernel build with TCP_RFC7413 option.
MFC r303978: Fix kernel build with TCP_RFC7413 option
Aug 14 2016, 6:30 PM
karels committed rS304086: MFC r303978; Fix kernel build with TCP_RFC7413 option.
MFC r303978; Fix kernel build with TCP_RFC7413 option
Aug 14 2016, 4:57 PM

Aug 11 2016

karels committed rS303978: Fix kernel build with TCP_RFC7413 option.
Fix kernel build with TCP_RFC7413 option
Aug 11 2016, 11:52 PM

Aug 3 2016

karels committed rS303698: MFC r303171: Fix per-connection L2 caching in fast path.
MFC r303171: Fix per-connection L2 caching in fast path
Aug 3 2016, 6:33 AM

Jul 24 2016

karels added a comment to D7251: Avoid calling in_pcbnotifyall() to flush cached routes.

I'm looking into the account issue.

Jul 24 2016, 5:33 AM

Jul 22 2016

karels added a comment to D7251: Avoid calling in_pcbnotifyall() to flush cached routes.

I'm not sure my acceptance "counts" using mike-karels.net; if you add karels@, I can re-approve.

Jul 22 2016, 11:33 PM