Page MenuHomeFreeBSD

karels (Mike Karels)
User

Projects

User Details

User Since
Mar 1 2015, 6:19 PM (376 w, 4 d)

Recent Activity

Mon, May 9

karels committed R10:1de9aa4d4f79: genet: fix output packet corruption in uncommon case (authored by karels).
genet: fix output packet corruption in uncommon case
Mon, May 9, 1:47 PM

Thu, Apr 21

karels committed R10:a28c89928a4d: genet: fix problems with interface down/up (authored by karels).
genet: fix problems with interface down/up
Thu, Apr 21, 2:41 PM

Apr 19 2022

karels committed R9:4807f4c3fc02: 13.1 relnotes: Add note on kernel dump support for dwmmc and sdhci (authored by karels).
13.1 relnotes: Add note on kernel dump support for dwmmc and sdhci
Apr 19 2022, 6:04 PM

Apr 14 2022

karels committed R10:8f45652b6bcc: genet: fix problems with interface down/up (authored by karels).
genet: fix problems with interface down/up
Apr 14 2022, 7:11 PM
karels closed D34919: 13.1 relnotes: remove WiFi 6 item..
Apr 14 2022, 6:55 PM
karels committed R9:8744ac2e573b: 13.1 relnotes: remove WiFi 6 item. (authored by karels).
13.1 relnotes: remove WiFi 6 item.
Apr 14 2022, 6:55 PM
karels requested review of D34919: 13.1 relnotes: remove WiFi 6 item..
Apr 14 2022, 6:17 PM

Apr 13 2022

karels closed D34892: 13.1 relnotes: Change previous entries to avoid imperative..
Apr 13 2022, 1:33 AM
karels committed R9:c4e48b65b76f: 13.1 relnotes: Change previous entries to avoid imperative. (authored by karels).
13.1 relnotes: Change previous entries to avoid imperative.
Apr 13 2022, 1:33 AM

Apr 12 2022

karels requested review of D34892: 13.1 relnotes: Change previous entries to avoid imperative..
Apr 12 2022, 9:44 PM
karels closed D34881: 13.1 relnotes: Add entries for most of the Relnotes: notations in log.
Apr 12 2022, 9:38 PM
karels committed R9:8db9ef195171: 13.1 relnotes: Add entries for most of the "Relnotes:" notations in log (authored by karels).
13.1 relnotes: Add entries for most of the "Relnotes:" notations in log
Apr 12 2022, 9:38 PM
karels updated the diff for D34881: 13.1 relnotes: Add entries for most of the Relnotes: notations in log.

Change new items to use only one sentence per line; other touchups.

Apr 12 2022, 4:59 AM
karels added a comment to D34881: 13.1 relnotes: Add entries for most of the Relnotes: notations in log.

I was also wondering whether I should change the older entries from the imperative "Add ..." to "... was added" etc. That should be a separate commit though. Comments?

Apr 12 2022, 12:29 AM
karels committed R10:96d89102f0f3: Switch RELNOTES to 13.1 (authored by karels).
Switch RELNOTES to 13.1
Apr 12 2022, 12:07 AM

Apr 11 2022

karels committed R10:6ca0ca7b4cb5: IPv4 multicast: fix LOR in shutdown path (authored by karels).
IPv4 multicast: fix LOR in shutdown path
Apr 11 2022, 7:52 PM
karels closed D34845: IPv4 multicast: fix LOR in shutdown path.
Apr 11 2022, 7:52 PM
karels added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

I moved the initialization of nifp into the loop construct. I'm also going to correct the comment at line 833 to say that we release our request for promiscuous multicast. If this sounds OK, I'll commit, otherwise push a new version for the review.

Apr 11 2022, 7:25 PM
karels added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

I looked again at the race. I don't think there is one. As ALLMULTI is reference-counted, it doesn't really matter if we drop it after another mrouter has added it.

Apr 11 2022, 4:56 PM
karels added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

I'll mention the race in the comment.

Apr 11 2022, 3:05 PM
karels requested review of D34881: 13.1 relnotes: Add entries for most of the Relnotes: notations in log.
Apr 11 2022, 2:51 PM
karels closed D34864: 13.1 relnotes: Add sections derived from 13.1 RELNOTES file..
Apr 11 2022, 1:46 PM
karels committed R9:c16cd8dfe3e2: 13.1 relnotes: Add sections derived from 13.1 RELNOTES file. (authored by karels).
13.1 relnotes: Add sections derived from 13.1 RELNOTES file.
Apr 11 2022, 1:46 PM

Apr 10 2022

karels requested review of D34864: 13.1 relnotes: Add sections derived from 13.1 RELNOTES file..
Apr 10 2022, 3:25 PM
karels added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

Any comments or approvals?

Apr 10 2022, 3:24 PM

Apr 8 2022

karels added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

There is a potential race here, if a multicast router socket is opened while this is still closing, as the if_allmulti() calls are done with no lock. I don't see a good solution, and that seems highly unlikely.

Apr 8 2022, 3:51 PM
karels requested review of D34845: IPv4 multicast: fix LOR in shutdown path.
Apr 8 2022, 3:48 PM

Apr 6 2022

karels closed D34788: Add note about IPv4 lowest-address broadcast change..
Apr 6 2022, 1:14 PM
karels committed R9:b7be927df519: 13.1 relnotes: Add note about IPv4 lowest-address broadcast change. (authored by karels).
13.1 relnotes: Add note about IPv4 lowest-address broadcast change.
Apr 6 2022, 1:13 PM
karels added a comment to D34788: Add note about IPv4 lowest-address broadcast change..

Am I allowed/able to commit this with only a src commit bit, or can someone else do it?

Apr 6 2022, 3:19 AM
karels added a comment to D34788: Add note about IPv4 lowest-address broadcast change..

I used the previous URL because it was cited in the commit, but I suppose it makes sense to use the newer one.

Apr 6 2022, 12:08 AM
karels updated the diff for D34788: Add note about IPv4 lowest-address broadcast change..

Update URL.

Apr 6 2022, 12:07 AM

Apr 5 2022

karels added a comment to D34788: Add note about IPv4 lowest-address broadcast change..

Any comments from the doc folks?

Apr 5 2022, 10:02 PM
karels requested review of D34788: Add note about IPv4 lowest-address broadcast change..
Apr 5 2022, 5:58 PM

Apr 4 2022

karels committed R10:a999acabfc72: Add release note about change to lowest address in IPv4 (sub)net. (authored by karels).
Add release note about change to lowest address in IPv4 (sub)net.
Apr 4 2022, 10:07 PM

Mar 22 2022

karels committed R10:04cd74b4cdb1: IPv4 multicast: fix netstat -g (authored by karels).
IPv4 multicast: fix netstat -g
Mar 22 2022, 12:42 PM
karels committed R10:2cf1e120c654: Enter epoch when addding IPv4 multicast forwarding cache entry (authored by karels).
Enter epoch when addding IPv4 multicast forwarding cache entry
Mar 22 2022, 12:42 PM
karels closed D34627: IPv4 multicast: fix netstat -g.
Mar 22 2022, 12:42 PM
karels closed D34624: Enter epoch when addding IPv4 multicast forwarding cache entry.
Mar 22 2022, 12:42 PM

Mar 21 2022

karels requested review of D34627: IPv4 multicast: fix netstat -g.
Mar 21 2022, 8:06 PM
karels added a reviewer for D34624: Enter epoch when addding IPv4 multicast forwarding cache entry: wma.
Mar 21 2022, 7:56 PM
karels requested review of D34624: Enter epoch when addding IPv4 multicast forwarding cache entry.
Mar 21 2022, 3:07 PM

Mar 9 2022

karels committed R10:caa14c7b600d: fdt: Expose the model, compatible and freebsd dts brandind as sysctl (authored by manu).
fdt: Expose the model, compatible and freebsd dts brandind as sysctl
Mar 9 2022, 3:36 PM
karels committed R10:c0d9004101db: Add serial-number to hw.fdt sysctl area if found in fdt. (authored by karels).
Add serial-number to hw.fdt sysctl area if found in fdt.
Mar 9 2022, 3:36 PM

Mar 3 2022

karels committed R10:b8b0c65e8a43: Add serial-number to hw.fdt sysctl area if found in fdt. (authored by karels).
Add serial-number to hw.fdt sysctl area if found in fdt.
Mar 3 2022, 1:09 PM
karels closed D34356: Add serial-number to hw.fdt sysctl area if found in fdt..
Mar 3 2022, 1:08 PM

Mar 2 2022

karels added a comment to D34356: Add serial-number to hw.fdt sysctl area if found in fdt..

Where do we stand on this? Is the change acceptable?

Mar 2 2022, 10:44 PM

Feb 24 2022

karels added a comment to D34356: Add serial-number to hw.fdt sysctl area if found in fdt..

Oops, you are right; I tried to combine tests and it failed to check for a final NUL properly. Fixed, and I changed to isprint(); that should be liberal enough.

Feb 24 2022, 6:55 PM
karels updated the diff for D34356: Add serial-number to hw.fdt sysctl area if found in fdt..

Fix test for missing NUL, switch to isprint().

Feb 24 2022, 6:53 PM
karels updated the diff for D34356: Add serial-number to hw.fdt sysctl area if found in fdt..

Check for ASCII string for serial-number, check len of hw.fdt strings.

Feb 24 2022, 3:51 PM
karels added a comment to D34356: Add serial-number to hw.fdt sysctl area if found in fdt..

Would it be sufficient to check for ASCII with a NUL termination at the end?

Feb 24 2022, 1:25 PM

Feb 23 2022

karels added inline comments to D34356: Add serial-number to hw.fdt sysctl area if found in fdt..
Feb 23 2022, 11:27 PM
karels requested review of D34356: Add serial-number to hw.fdt sysctl area if found in fdt..
Feb 23 2022, 9:10 PM

Dec 17 2021

karels committed R10:93a95ebbf7c8: Add genet.4 for RPi 4 Ethernet (authored by karels).
Add genet.4 for RPi 4 Ethernet
Dec 17 2021, 4:04 PM

Dec 14 2021

karels committed R10:6ccff5c0452c: Add genet.4 for RPi 4 Ethernet (authored by karels).
Add genet.4 for RPi 4 Ethernet
Dec 14 2021, 1:47 PM
karels closed D33360: Add genet.4 for RPi 4 Ethernet.
Dec 14 2021, 1:47 PM

Dec 13 2021

karels updated the diff for D33360: Add genet.4 for RPi 4 Ethernet.

Added copyright; touched up hardware info

Dec 13 2021, 5:35 PM

Dec 10 2021

karels added inline comments to D33274: IPv4: fix redirect sending conditions.
Dec 10 2021, 6:55 PM
karels committed R10:c25b0c36dd1e: kernel: partially revert e9efb1125a15, default inet mask (authored by karels).
kernel: partially revert e9efb1125a15, default inet mask
Dec 10 2021, 4:31 PM
karels committed R10:c7444d9cb3a9: systat: clean up code assuming network classes (authored by karels).
systat: clean up code assuming network classes
Dec 10 2021, 4:31 PM
karels committed R10:5abf4c8aa762: sockstat: change check for wildcard sockets to avoid historical classes (authored by karels).
sockstat: change check for wildcard sockets to avoid historical classes
Dec 10 2021, 4:31 PM
karels committed R10:e5d4e532a0dc: mountd: deprecate exports to a network without mask (authored by karels).
mountd: deprecate exports to a network without mask
Dec 10 2021, 4:30 PM
karels committed R10:2cd55edbb288: netstat: reduce use of historical Internet classes (authored by karels).
netstat: reduce use of historical Internet classes
Dec 10 2021, 4:30 PM
karels committed R10:1ab4b70db5d0: res_init: remove unused inet_makeaddr with IN_LOOPBACKNET (authored by karels).
res_init: remove unused inet_makeaddr with IN_LOOPBACKNET
Dec 10 2021, 4:30 PM
karels committed R10:d98a0edb267e: man pages: deprecate Internet Class A/B/C (authored by karels).
man pages: deprecate Internet Class A/B/C
Dec 10 2021, 4:30 PM
karels committed R10:4dbba5ab609c: ifconfig: warn if setting an Internet address without mask (authored by karels).
ifconfig: warn if setting an Internet address without mask
Dec 10 2021, 4:30 PM
karels committed R10:cdae3f501d1b: kernel: deprecate Internet Class A/B/C (authored by karels).
kernel: deprecate Internet Class A/B/C
Dec 10 2021, 4:29 PM

Dec 9 2021

karels added a comment to D33360: Add genet.4 for RPi 4 Ethernet.

Good point. I had more hardware information in the Description section originally, but moved it to Hardware. I'll try to come up with something more generic. I still want to mention the RPi 4, as that is the most common.

Dec 9 2021, 5:38 PM
karels added inline comments to D33360: Add genet.4 for RPi 4 Ethernet.
Dec 9 2021, 3:09 PM
karels requested review of D33360: Add genet.4 for RPi 4 Ethernet.
Dec 9 2021, 2:16 PM

Nov 14 2021

karels closed D32951: kernel: partially revert e9efb1125a1584338640ec796c315318c66ef7d7.
Nov 14 2021, 8:14 PM
karels committed R10:2f35e7d9fa03: kernel: partially revert e9efb1125a15, default inet mask (authored by karels).
kernel: partially revert e9efb1125a15, default inet mask
Nov 14 2021, 8:14 PM

Nov 11 2021

karels requested review of D32951: kernel: partially revert e9efb1125a1584338640ec796c315318c66ef7d7.
Nov 11 2021, 10:03 PM

Nov 9 2021

karels committed R10:a2e7dfca8649: systat: clean up code assuming network classes (authored by karels).
systat: clean up code assuming network classes
Nov 9 2021, 3:37 PM
karels committed R10:bd27c71c4573: netstat: reduce use of historical Internet classes (authored by karels).
netstat: reduce use of historical Internet classes
Nov 9 2021, 3:36 PM
karels committed R10:64acb29b7d96: sockstat: change check for wildcard sockets to avoid historical classes (authored by karels).
sockstat: change check for wildcard sockets to avoid historical classes
Nov 9 2021, 3:36 PM
karels committed R10:92aebdeaff57: mountd: deprecate exports to a network without mask (authored by karels).
mountd: deprecate exports to a network without mask
Nov 9 2021, 3:36 PM
karels committed R10:0bf7f99b2a1f: res_init: remove unused inet_makeaddr with IN_LOOPBACKNET (authored by karels).
res_init: remove unused inet_makeaddr with IN_LOOPBACKNET
Nov 9 2021, 3:36 PM
karels closed D32720: systat: clean up code assuming network classes.
Nov 9 2021, 3:36 PM
karels committed R10:12bd931d8c64: man pages: deprecate Internet Class A/B/C (authored by karels).
man pages: deprecate Internet Class A/B/C
Nov 9 2021, 3:36 PM
karels committed R10:d8237b955528: ifconfig: warn if setting an Internet address without mask (authored by karels).
ifconfig: warn if setting an Internet address without mask
Nov 9 2021, 3:36 PM
karels closed D32715: sockstat: change check for wildcard sockets to avoid historical classes.
Nov 9 2021, 3:36 PM
karels committed R10:20d59403961d: kernel: deprecate Internet Class A/B/C (authored by karels).
kernel: deprecate Internet Class A/B/C
Nov 9 2021, 3:36 PM
karels closed D32714: netstat: reduce use of historical Internet classes.
Nov 9 2021, 3:36 PM
karels closed D32713: mountd: deprecate exports to a network without mask.
Nov 9 2021, 3:36 PM
karels closed D32711: man pages: deprecate Internet Class A/B/C.
Nov 9 2021, 3:36 PM
karels closed D32709: ifconfig: warn if setting an Internet address without mask.
Nov 9 2021, 3:36 PM
karels closed D32708: kernel: deprecate Internet Class A/B/C.
Nov 9 2021, 3:36 PM
karels abandoned D32712: res_init: remove unused inet_makeaddr with IN_LOOPBACKNET.

Abandoning since there are no reviewers, will commit without review.

Nov 9 2021, 3:20 PM

Nov 4 2021

karels updated the diff for D32708: kernel: deprecate Internet Class A/B/C.

Add missing newline

Nov 4 2021, 7:23 PM
karels updated the diff for D32709: ifconfig: warn if setting an Internet address without mask.

Fix delete case

Nov 4 2021, 7:05 PM

Nov 2 2021

karels added inline comments to D32708: kernel: deprecate Internet Class A/B/C.
Nov 2 2021, 6:56 PM
karels added a comment to D32709: ifconfig: warn if setting an Internet address without mask.

No one seems to have done structural work on ifconfig for a while. Suggestions for other reviewers welcome, but I think it is pretty well tested.

Nov 2 2021, 4:05 PM
karels updated the diff for D32709: ifconfig: warn if setting an Internet address without mask.

Change getifflags() err_ok parameter to bool

Nov 2 2021, 4:03 PM

Nov 1 2021

karels abandoned D32716: sendmail: do not use IN_CLASS macros.

Closing review, patch in progress upstream.

Nov 1 2021, 7:38 PM
karels added a comment to D32716: sendmail: do not use IN_CLASS macros.

Thanks, sounds good.

Nov 1 2021, 7:37 PM

Oct 29 2021

karels added a comment to D32716: sendmail: do not use IN_CLASS macros.

The current code works for now, but there is a proposal for a change that would make the old code fail. Note that IN_LOOPBACK() is not in Linux; not sure about other BSDs. The change could be conditional on #ifdef IN_LOOPBACK.

Oct 29 2021, 12:54 PM

Oct 28 2021

karels requested review of D32720: systat: clean up code assuming network classes.
Oct 28 2021, 11:43 PM
karels added inline comments to D32715: sockstat: change check for wildcard sockets to avoid historical classes.
Oct 28 2021, 10:38 PM
karels added inline comments to D32713: mountd: deprecate exports to a network without mask.
Oct 28 2021, 7:41 PM