Updates per comments

Closed by commit rG108230743472: pwd.1: replace /home with /sys in example (authored by karels).

Closed by commit rGd3c32c80a16b: release/tools/vmimage.subr: switch zfs dataset from /usr/home to /home (authored by karels).

Maybe the current code should just be moved under arm64.

In D40111#913448, @markj wrote:

In D40111#913442, @karels wrote:

This change seems to work; /home is mounted from zroot/home, and /usr/home does not exist. /home has no contents, but that is presumably expected.

In D40085#913404, @markj wrote:

I think you will also want to modify poudriere, which can create FreeBSD images and also references usr/home in some places.

Add missing backslash

Adding @markj, at least for context.

Adding @markj, at least for context.

In D40085#913341, @mhorne wrote:

Thanks for your work in handling this, @karels. The pw(8) changes, and tests, make sense to me, but it's not really my code to accept.

One last-minute nit.

I notice that this still uses "master", although in a different sense. I can't think of a better word though.

On re-reading this chapter, I think I understand the usage of /compat/linux, /compat/ubuntu, etc. But I don't think that it's very clear how they interact. It may be worth a paragraph near the beginning to say /compat/linux is meant for Centos, /compat/ubuntu for Debian/Ubuntu, etc. They are treated differently, in that the rc script does things automagically for /compat/linux.

For what it's worth, I don't see problems with the driver, but I worked on the code (long ago), and don't know arm or watchdogs well enough to approve this. Someone else should approve.

Looks good to me too.

I think this chapter is looking good, at least after a quick pass. Just a few comments so far.

In D39824#906723, @emaste wrote:

Would like a comment in the file mentioning what hardware this applies to

Looks good to me, but I didn't review the previous version. It fixes the bug for me too.

I agree, this is better.

I'd like to see this go in, so I'm accepting even though I don't know anything about zfskeys.

LGTM, but it would be good for manpages to look too.

Mateusz, I assume this was your change for zfskeys. Can you review this? The form looks fine to me, but I don't know zfskeys.

LGTM, but I'd wait for manpages to weigh in too.

I assume that the new test used to crash or otherwise burn. The new test and other changes look good.

I think this looks right as far as it goes.

LGTM, but I don't know the details here.

I vocalized this as "dash r" myself, even though it is really a hyphen, but debated "a" vs "an". I like your alternative version, it reads correctly either way.

Any Doc Committers able to accept and approve?

address review comment

Add gitrefs for updates on hostid/machine-id.

LGTM on form; I'll trust you and Andrew on the sets of EFI types.

LGTM

Maybe manpages should review this one too.

@bcr (or another doc committer), can you approve again?

Address review comments, other minor wording changes.

This fixes the problem on my RPi 4B.

@bcr, can I take your acceptance as doc approval?