Page MenuHomeFreeBSD

karels (Mike Karels)
User

Projects

User Details

User Since
Mar 1 2015, 6:19 PM (249 w, 4 d)

Recent Activity

Sat, Nov 23

karels committed rS355030: MFC r354633:.
MFC r354633:
Sat, Nov 23, 1:23 PM
karels committed rS355029: MFC r354633:.
MFC r354633:
Sat, Nov 23, 1:20 PM

Nov 12 2019

karels committed rS354633: Fix netstat -gs with ip_mroute module and/or vnet.
Fix netstat -gs with ip_mroute module and/or vnet
Nov 12 2019, 1:03 AM
karels closed D22311: Fix netstat -gs with ip_mroute module and/or vnet.
Nov 12 2019, 1:03 AM
karels added a comment to D22311: Fix netstat -gs with ip_mroute module and/or vnet.

Conrad: this fixes a current problem with live systems, debugging a multicast problem. I am not aware of any requests to get multicast stats from a kernel core.

Nov 12 2019, 12:59 AM

Nov 11 2019

karels updated the diff for D22311: Fix netstat -gs with ip_mroute module and/or vnet.

Fix parens

Nov 11 2019, 5:46 AM
karels created D22311: Fix netstat -gs with ip_mroute module and/or vnet.
Nov 11 2019, 5:38 AM

Oct 3 2019

karels committed rS353028: MFC r352867: Add support for ps -H on corefiles in libkvm.
MFC r352867: Add support for ps -H on corefiles in libkvm
Oct 3 2019, 2:52 AM

Sep 29 2019

karels committed rS352867: MFC r352597: Add support for ps -H on corefiles in libkvm.
MFC r352597: Add support for ps -H on corefiles in libkvm
Sep 29 2019, 6:13 AM

Sep 22 2019

karels committed rS352597: Add support for ps -H on corefiles in libkvm.
Add support for ps -H on corefiles in libkvm
Sep 22 2019, 1:56 PM
karels closed D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Sep 22 2019, 1:56 PM

Sep 12 2019

karels updated the diff for D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.

Remove incomplete ifdefs.

Sep 12 2019, 1:56 AM

Sep 6 2019

karels added inline comments to D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Sep 6 2019, 11:38 PM
karels committed rS351966: MFC r351379 r351385 r351592:.
MFC r351379 r351385 r351592:
Sep 6 2019, 9:53 PM
karels updated the diff for D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.

Upload correct version with nested loops.

Sep 6 2019, 1:38 PM
karels updated the diff for D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.

Change to use nested loops for procs and threads; deal with zombproc

Sep 6 2019, 1:23 PM

Sep 1 2019

karels committed rD53357: Update expiration on karels@freebsd.org gpg key..
Update expiration on karels@freebsd.org gpg key.
Sep 1 2019, 10:03 PM

Aug 30 2019

karels added a comment to D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.

I took yet another tack last night, and it is better than previous attempts. It seems to be working correctly, but needs more testing. The changes are much bigger, mostly due to code motions. (svn diff is now 286 lines, about twice as big.) I'll test more, then decide whether to proceed with it.

Aug 30 2019, 10:52 PM
karels added inline comments to D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Aug 30 2019, 2:14 AM
karels added a comment to D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.

Thanks, John.

Aug 30 2019, 1:25 AM

Aug 29 2019

karels created D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Aug 29 2019, 3:09 AM
karels committed rS351592: Fix address annotation in xml output from w.
Fix address annotation in xml output from w
Aug 29 2019, 2:44 AM
karels closed D21390: Fix address annotation in xml output from w.
Aug 29 2019, 2:44 AM

Aug 24 2019

karels added a reviewer for D21390: Fix address annotation in xml output from w: marcel.
Aug 24 2019, 1:16 AM
karels created D21390: Fix address annotation in xml output from w.
Aug 24 2019, 1:09 AM

Aug 22 2019

karels committed rS351379: Change w(1) to compute FROM (host) field size dynamically.
Change w(1) to compute FROM (host) field size dynamically
Aug 22 2019, 3:28 AM
karels closed D21211: Change w(1) to compute FROM (host) field size dynamically.
Aug 22 2019, 3:28 AM

Aug 19 2019

karels added a comment to D21211: Change w(1) to compute FROM (host) field size dynamically.

Conrad: it has now been more than a week since Marcel asked a question. If you can't or won't explain why you oppose this change, I think you need to drop your block on the review.

Aug 19 2019, 11:37 PM

Aug 12 2019

karels added a comment to D21211: Change w(1) to compute FROM (host) field size dynamically.

change macro to take parameter

Aug 12 2019, 1:04 AM
karels added a comment to D21211: Change w(1) to compute FROM (host) field size dynamically.

Sorry that this was unclear. There is a limitation in phabricator to the kinds of negative feedback metadata one can provide. It's "request changes" or nothing.

Aug 12 2019, 1:04 AM

Aug 11 2019

karels added a comment to D21211: Change w(1) to compute FROM (host) field size dynamically.

@cem: phabricator says "cem requested changes to this revision.", but I see no changes requested.

Aug 11 2019, 7:37 PM
D21211: Change w(1) to compute FROM (host) field size dynamically now requires review to proceed.

minor corrections

Aug 11 2019, 1:55 PM
karels added a comment to D21211: Change w(1) to compute FROM (host) field size dynamically.

@cem: Not if it is an improvement on another change, and makes better use of the existing space.

Aug 11 2019, 1:34 PM
karels created D21211: Change w(1) to compute FROM (host) field size dynamically.
Aug 11 2019, 12:23 AM

Apr 22 2019

karels added inline comments to D19594: Fix udp_output() locking strategy in one case.
Apr 22 2019, 12:22 PM

Mar 19 2019

karels accepted D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

Although I have a couple of inline comments, I wouldn't object to committing this as-is. Touching up would be fine too.

Mar 19 2019, 6:34 AM

Mar 7 2019

karels accepted D19490: Improve ARP logging.

This seems good to me. If this is not to be MFC'd, compatibility wouldn't matter (in which case I wouldn't have reduced the number of spares). It's nice to have things in order, but maybe this isn't the time to break compatibility given the small scope.

Mar 7 2019, 11:46 PM
karels added inline comments to D19490: Improve ARP logging.
Mar 7 2019, 1:39 AM

Feb 26 2019

karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

I agree with John that we should do everything we can to eliminate class A/B/C rather than just shuffle it around. Removing those macros will cause some turmoil; e.g. libc's inet_netof and inet_lnaof assume classes, and don't know about local netmasks. They should probably go away. I don't know how painful that will be. But we are way overdue to get rid of this stuff, and it appears that Linux (Ubuntu) doesn't have them. But the old A/B/C are a somewhat different problem than making Class E usable.

Feb 26 2019, 11:59 PM

Feb 25 2019

karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

Hi, John! Very, very long time no (anything). I am very happy to see tests in this area. I certainly expect this to work with minimal changes (i.e. this one). Re: Classs A/B/C: I'd be quite happy to see those definitions go away. Re: "loopback net": I'm aware of a small number of things using that other than 127.0.0.1 (including one of my company's legacy products), but they are minor. I still remember driving a Sun workstation crazy by pinging 127.0.0.2 (there was a network route, but obviously only one address recognized.).

Feb 25 2019, 12:44 AM

Feb 24 2019

karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

Sorry, that reference should have been RFC 1112, not RFC 112.

Feb 24 2019, 6:57 PM
karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

It looks like I am the guilty party in calling Class E IN_EXPERIMENTAL, which went in when "Class D" became multicast. I suspect it was actually called that in some document, although it doesn't really matter. https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml doesn't call it Class E, but refers to RFC112, which does. In any case, assuming that https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml is still current, the treatment is the same.

Feb 24 2019, 6:40 PM
karels added inline comments to D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.
Feb 24 2019, 5:52 PM
karels added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

I don't understand the purpose of this review. As it says, these changes should not be committed. I'm not actually sure of the official status of Class E, although I suspect it is still experimental/not for production use.

Feb 24 2019, 5:45 PM
karels accepted D18904: Make arp return errors.
Feb 24 2019, 2:31 PM
karels added a comment to D18904: Make arp return errors.

Generally looks good, one small comment inline.

Feb 24 2019, 1:48 PM

Jan 26 2019

karels added a comment to D18904: Make arp return errors.

I agree that arprequest_int is rather opaque. At first I thought that is was just the version that returns int, which is not useful. arprequest_internal would be better. Otherwise, I have no objection; returning any errors seems like a good thing. And yes, I did not see any of the earlier (presumed) emails for this review.

Jan 26 2019, 11:43 PM

Dec 8 2018

karels committed rS341737: MFC r340474:.
MFC r340474:
Dec 8 2018, 2:54 PM

Nov 16 2018

karels committed rS340474: Fix flags collision causing inability to enable CBQ in ALTQ.
Fix flags collision causing inability to enable CBQ in ALTQ
Nov 16 2018, 3:42 AM
karels closed D17758: Fix flags collision causing inability to enable CBQ in ALTQ.
Nov 16 2018, 3:42 AM

Oct 30 2018

karels created D17758: Fix flags collision causing inability to enable CBQ in ALTQ.
Oct 30 2018, 1:32 AM

Sep 22 2018

karels added a comment to D17246: Hold a write lock across udp_notify().

LGTM also

Sep 22 2018, 12:17 PM

Sep 19 2018

karels accepted D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates.

It would be good to see if the crashes stop before committing this, but it looks right to me.

Sep 19 2018, 12:01 AM

Sep 6 2018

karels accepted D17062: Cleanup unused inpcb fields/flags.
Sep 6 2018, 7:35 PM

Sep 3 2018

karels accepted D17006: Apply RO_RTFREE() to more places.
Sep 3 2018, 8:01 PM
karels accepted D17007: Appl RO_INVALIDATE_CACHE() to more netinet6 code.
Sep 3 2018, 7:58 PM
karels accepted D17004: Remove code duplicating in route.h.
Sep 3 2018, 7:56 PM
karels accepted D17005: Adjust inp_route to inp_route6 in netinet6 code.
Sep 3 2018, 7:55 PM

Sep 1 2018

karels added a comment to D16654: IPv6 transport for bsnmp.

I believe I understand the issue with route caching. in6_selectroute_fib checks for loopback,and substitutes the interface with the local address. ip6_output doesn't need to know that interface, it should just skip the scope check in that case. I'll email a possible kernel patch to Andrey and Harti.

Sep 1 2018, 12:47 PM

Aug 28 2018

karels added a comment to D6262: Implement L2 lookup caching for TCP and UDP.

You are right, inp_route6 would be better. I'm sure I copied and pasted, then didn't make as many changes as I should have. I will happily approve a review to make that change if you test that it compiles :-).

Aug 28 2018, 12:31 AM

May 17 2018

karels added a comment to D15459: Use __SCCSID for SCCS IDs in libkvm sources..

Looks good to me. I could go either way on the blank line.

May 17 2018, 1:47 AM

Mar 10 2018

karels committed rS330712: Change ps(1) output width to unlimited if not interactive.
Change ps(1) output width to unlimited if not interactive
Mar 10 2018, 12:11 AM
karels closed D14614: Change ps(1) output width to unlimited if not interactive.
Mar 10 2018, 12:11 AM

Mar 9 2018

karels added a comment to D14614: Change ps(1) output width to unlimited if not interactive.

Thanks for catching the typo.

Mar 9 2018, 12:58 AM

Mar 8 2018

karels created D14614: Change ps(1) output width to unlimited if not interactive.
Mar 8 2018, 12:57 AM

Feb 28 2018

karels committed rS330091: Revert r314685 in ps.
Revert r314685 in ps
Feb 28 2018, 12:17 AM
karels closed D14530: Revert r314685 in ps.
Feb 28 2018, 12:17 AM

Feb 27 2018

karels created D14530: Revert r314685 in ps.
Feb 27 2018, 12:42 AM

Feb 10 2018

karels added a comment to D14291: Allow route change requests to not specify the gateway..

I agree with the change as well; the regression seems to have happened when the code was refactored and the "add" and "change" code became joined.

Feb 10 2018, 7:30 PM

Jan 23 2018

karels accepted D13990: Increment the route table gen count after a modify.

Looks good.

Jan 23 2018, 1:52 AM

Jan 22 2018

karels accepted D13989: Reduce code duplication for inpcb route caching.
Jan 22 2018, 5:38 AM
karels accepted D13988: Invalidate inpcb LLE cache if cached route is invalidated.
Jan 22 2018, 5:38 AM
karels added a comment to D13988: Invalidate inpcb LLE cache if cached route is invalidated.

Got it. I didn't realize it, but Phabricator lists the reviews in reverse order, so that's the order I looked at them.

Jan 22 2018, 5:38 AM

Jan 20 2018

karels added a comment to D13990: Increment the route table gen count after a modify.

I just realized that this is necessary when the L3 gateway changes. The L3 cache doesn't need to be invalidated, but L2 does. A comment to this effect would be helpful.

Jan 20 2018, 3:19 AM
karels added a comment to D13988: Invalidate inpcb LLE cache if cached route is invalidated.

Could this use the new invalidate macro?

Jan 20 2018, 2:59 AM
karels added a comment to D13989: Reduce code duplication for inpcb route caching.

Was there a place where only L3 was invalidated?

Jan 20 2018, 2:37 AM
karels added a comment to D13990: Increment the route table gen count after a modify.

Why is this necessary, or desirable? If a route that is cached is modified, that doesn't invalidate it. It should still be the best route if it was before.

Jan 20 2018, 2:32 AM

Jan 13 2018

karels committed rS327923: Add info about SW_WATCHDOG change to be dynamic in the common case..
Add info about SW_WATCHDOG change to be dynamic in the common case.
Jan 13 2018, 2:15 PM
karels committed rS327920: MFC r327505:.
MFC r327505:
Jan 13 2018, 2:10 PM

Jan 3 2018

karels committed rS327512: Add info about SW_WATCHDOG change to be dynamic in the common case..
Add info about SW_WATCHDOG change to be dynamic in the common case.
Jan 3 2018, 6:41 AM
karels committed rS327505: make SW_WATCHDOG dynamic.
make SW_WATCHDOG dynamic
Jan 3 2018, 12:56 AM
karels closed D13713: make SW_WATCHDOG dynamic.
Jan 3 2018, 12:56 AM

Jan 2 2018

karels added inline comments to D13713: make SW_WATCHDOG dynamic.
Jan 2 2018, 5:40 AM
karels updated the diff for D13713: make SW_WATCHDOG dynamic.

Tweak man page

Jan 2 2018, 5:31 AM

Jan 1 2018

karels added a comment to D13713: make SW_WATCHDOG dynamic.

A list of ioctl names didn't seem very useful to me, so I extracted the information from the header file.

Jan 1 2018, 4:16 PM
karels updated the diff for D13713: make SW_WATCHDOG dynamic.

Update man page

Jan 1 2018, 4:15 PM
karels added a comment to D13713: make SW_WATCHDOG dynamic.

IIRC, there are ten of these ioctls, although I didn't add any. I thought I'd correct the obvious out-of-date statement, but wasn't sure I could correctly document all of those added over time. Suggestions?

Jan 1 2018, 2:11 AM

Dec 31 2017

karels added a comment to D13713: make SW_WATCHDOG dynamic.

Rod, perhaps you have never needed this functionality; but have you ever had a system hang? Along the same lines, there are probably about 1000 bits of code that you haven't needed in the kernel; should we add options to remove each of them? This way lies madness. There are two hardclock routines; which are you using? Should we ifdef out the other?

Dec 31 2017, 6:07 PM
karels added a comment to D13713: make SW_WATCHDOG dynamic.

Sorry, my last comment was responding to imp@; it crossed with the comment from rgrimes.

Dec 31 2017, 5:33 PM
karels added a comment to D13713: make SW_WATCHDOG dynamic.

Thanks. About loadable hardware watchdogs: that should work if they attach before watchdogd starts.

Dec 31 2017, 5:18 PM
karels created D13713: make SW_WATCHDOG dynamic.
Dec 31 2017, 2:49 PM

Dec 18 2017

karels committed rS326928: MFC r326734:.
MFC r326734:
Dec 18 2017, 5:29 AM

Dec 9 2017

karels committed rS326734: gifconfig_gif0 no longer works, document replacement.
gifconfig_gif0 no longer works, document replacement
Dec 9 2017, 5:28 PM
karels closed D13130: gifconfig_gif0 no longer works, document replacement.
Dec 9 2017, 5:28 PM

Nov 27 2017

karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Update date.

Nov 27 2017, 11:03 PM

Nov 25 2017

karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Fix macro usage, update text

Nov 25 2017, 11:05 PM

Nov 24 2017

karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 24 2017, 10:03 PM

Nov 18 2017

karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 6:41 PM
karels added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 6:16 PM
karels updated the diff for D13130: gifconfig_gif0 no longer works, document replacement.

Another attempt to clarify, flesh out example.

Nov 18 2017, 6:11 PM