pw: Test home directory ownership and mode.
ClosedPublic
Actions

Authored by des on May 6 2024, 1:57 PM.

Details

Reviewers

• karels
imp

Group Reviewers

tests

Commits

rGe12b7446bddc: pw: Test home directory ownership and mode.

Summary

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des requested review of this revision.May 6 2024, 1:57 PM

des created this revision.

Harbormaster completed remote builds in B57596: Diff 138160.May 6 2024, 1:57 PM

This is sort of tangential, and it wouldn't have caught the adduser bug, but I noticed that while several existing test cases verify the existence of the home directory after pw -m, none of them verify its ownership or permissions.

des added a reviewer: tests.May 6 2024, 3:35 PM

Seems like a good idea. I don't know atf usage well though.

This looks good.

This revision is now accepted and ready to land.May 6 2024, 3:53 PM

Closed by commit rGe12b7446bddc: pw: Test home directory ownership and mode. (authored by des). · Explain WhyMay 6 2024, 4:21 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGe12b7446bddc: pw: Test home directory ownership and mode..

des mentioned this in rG2f59ee828754: pw: Rename some enums..May 9 2024, 1:16 PM

des mentioned this in rGe3bd4b9288cc: pw: Rename some enums..

des mentioned this in rG1691bcc8b02c: pw: Rename some enums..May 9 2024, 2:31 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pw/

tests/

pw_useradd_test.sh

17 lines

Diff 138167

View Options

usr.sbin/pw/tests/pw_useradd_test.sh

pw: Test home directory ownership and mode.ClosedPublicActions