Fix up this review to work with DTS import from Linux 6.4

Background why this driver is added:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm/boot/dts/am33xx-clocks.dtsi?h=v6.1.64&id=c2f2646057bcf3f86a75f6a8aa9fbd159a1d4784

• Replaced the DEFINE_CLASS_0 -> struct driver_t
• removed pinctrl_single_pins_write / read
• update pinctrl_single_syscon_unlocked_write_4/read_4 to honor pinctrl-single,register-width. (even if the functionnames will be misleading and give the impression its an 4byte version of read/write)
• removed pinctrl_single_syscon_unlocked_modify_4
• update error handling after fdt_pinctrl_register() call to release syscon in case of failure.

Thank you Manu. Followed your advice to move the bus_alloc_resource/syscon interface to the end of the attach function to avoid complicated error paths.

Replaced by D42124

Mike, no you need more patches for it to boot. You will get it this week.
Beaglebone black boots with some u-boot issues regarding the ethernet and USB due to DTS missmatch to the one provided by Linux..
Pocketbeagle will not boot if you have a uboot version >= 2003.01.

D27889 are required to get AM335x to boot.

Update for latest DTS.
Previous I created clk_link in ti_prcm, but latest DTS introduce clkctrl in the very first ti,sysc nodes as a consequence the clk_link will be created in ti_sysc.c.
This patch alone will not boot the am335x, need a simplepmbus driver aswell.

• cleanup gpio gdbclk in ti_clk_clkctrl and use a TI_CLKCTRL_GATE subclock instead
• prepare for am572x subtypes, am335x only use TI_CLKCTRL_GATE
• Fix some wrong mappings like timer7 and so on

rpokala: Thank you for your comments.

pwmbus.9
change type for argument channel and the pointer nchannel (int -> u_int)

In D29137#652543, @lwhsu wrote:

.dD field in manual page needs to be updated.

Remove share/man/man9/pwmbus.9
Fix space around &

Update ti_prcm.c to add clk link in probe() instead of attach to avoid the need to declare syscon_generic.c attach as public.
Remove attach() function in ti_prcm.c and use inherited one from syscon_generic.c

Remove syscon_generic_handle from syscon_generic.c and add into ti_prcm.c and ti_scm_syscon.c

• Add parents for ti,clkctrl.
• since the node scm_conf@0 (compatible "syscon", "simple-bus") needs to be attached as soon as posible during boot and syscon_generic are in pass BUS_PASS_DEFAULT I readded ti_scm_syscon.c and removed more or less everything but the probe() function and "subclass" syscon_generic. Added checks in probe() to ensure it not connect to other SoCs syscon nodes.

Yes, this revision is nothing to care about anymore.

Fix cpu reset functions in ti_prcm.c

Remove #ifdefs in conf.c
Add nullconsole.c / spinconsole.c to Makefile.inc (arm, arm64 and riscv).

In D26402#591631, @mmel wrote:

Already committed as part of other change.

Use D26401 D26402 and D26468 instead

Thanks, should be better now.

If src.conf contains
WITHOUT_LOADER_ZFS=true
WITHOUT_ZFS=true

remove some confused \0

Copy clk_div.c, clk_gate.c and clk_mux from sys/dev/extres/clk/ and extend them with options to use syscon if the parent are syscon, otherwise use clkdev.

Michal, thanks for your guidance.

Thanks Thomas - didnt try GENERIC build.

Correct initialize of gates clkdef.flags

In D25118#558687, @mmel wrote:

It also looks OK for me. I have a few small items that we should rethink or fix, but we can do all of these (including pandaboard support) as follow-up fixes. I can commit this as is over the weekend and then we can start discussing improvements (and I also hope to have a little more free time from next week).
Oscar, manu do you agree?
Problematic (for me) items are:

• The ti_dpll_clk_set_freq routine should respect rounding (dpll) and DRY_RUN.
• I’m not a big friend of bulk clock enable in ti_sysc_clock_enable().
• probably , it will be easier to convert scm_clocks and prcm_clocks instances from FDT data driven to compiled-in table driven clocks implementation.

But all these are minor and should be discussed firstly...

Fix sys/arm/ti/ti_pruss.c to activate pruss subsystems
Add shim driver ti_prm to reset the pruss.