Page MenuHomeFreeBSD

oskar.holmlund_ohdata.se (Oskar Holmlund)
User

Projects

User Details

User Since
May 30 2020, 11:28 AM (69 w, 2 d)

Recent Activity

Jul 26 2021

oskar.holmlund_ohdata.se added a comment to D31311: simple-pm-bus driver.

D27889 are required to get AM335x to boot.

Jul 26 2021, 6:54 PM · ARM
oskar.holmlund_ohdata.se requested review of D31311: simple-pm-bus driver.
Jul 26 2021, 6:53 PM · ARM
oskar.holmlund_ohdata.se updated the diff for D27889: TI SoC rework clk support.

Update for latest DTS.
Previous I created clk_link in ti_prcm, but latest DTS introduce clkctrl in the very first ti,sysc nodes as a consequence the clk_link will be created in ti_sysc.c.
This patch alone will not boot the am335x, need a simplepmbus driver aswell.

Jul 26 2021, 6:48 PM · ARM
oskar.holmlund_ohdata.se added a comment to D27889: TI SoC rework clk support.
  • cleanup gpio gdbclk in ti_clk_clkctrl and use a TI_CLKCTRL_GATE subclock instead
  • prepare for am572x subtypes, am335x only use TI_CLKCTRL_GATE
  • Fix some wrong mappings like timer7 and so on
Jul 26 2021, 6:45 PM · ARM

Jul 24 2021

oskar.holmlund_ohdata.se added a member for riscv: oskar.holmlund_ohdata.se.
Jul 24 2021, 10:37 PM

Jul 18 2021

oskar.holmlund_ohdata.se updated the diff for D27889: TI SoC rework clk support.
Jul 18 2021, 10:05 PM · ARM
oskar.holmlund_ohdata.se committed R10:8cdb4491c90d: arm: TI AM335x fix gpio_pin numbers in lookup table. (authored by oskar.holmlund_ohdata.se).
arm: TI AM335x fix gpio_pin numbers in lookup table.
Jul 18 2021, 9:25 AM
oskar.holmlund_ohdata.se closed D31164: AM335x: fix gpio_pin numbers in lookup table.
Jul 18 2021, 9:24 AM · ARM

Jul 13 2021

oskar.holmlund_ohdata.se requested review of D31164: AM335x: fix gpio_pin numbers in lookup table.
Jul 13 2021, 4:14 PM · ARM

Jun 14 2021

oskar.holmlund_ohdata.se closed D30746: arm: AM335x ehrpwm fix bitmask.
Jun 14 2021, 6:49 AM · ARM
oskar.holmlund_ohdata.se committed R10:ac6dcaf8f4c4: arm: TI am335x ehrpwm fix bitmask (authored by oskar.holmlund_ohdata.se).
arm: TI am335x ehrpwm fix bitmask
Jun 14 2021, 6:49 AM

Jun 12 2021

oskar.holmlund_ohdata.se requested review of D30746: arm: AM335x ehrpwm fix bitmask.
Jun 12 2021, 9:53 AM · ARM
oskar.holmlund_ohdata.se committed R10:e7424879e3f6: arm: ti am335x ehrpwm add support for flags (PWM_POLARITY_INVERTED) (authored by oskar.holmlund_ohdata.se).
arm: ti am335x ehrpwm add support for flags (PWM_POLARITY_INVERTED)
Jun 12 2021, 7:04 AM
oskar.holmlund_ohdata.se closed D29547: am335x_ehrpwm.c add support for flags (PWM_POLARITY_INVERTED).
Jun 12 2021, 7:04 AM · ARM
oskar.holmlund_ohdata.se committed R10:dbaf4b653976: arm: ti am335x ehrpwm remove sysctl interface (authored by oskar.holmlund_ohdata.se).
arm: ti am335x ehrpwm remove sysctl interface
Jun 12 2021, 6:37 AM
oskar.holmlund_ohdata.se closed D29546: am335x_ehrpwm.c remove sysctl interface.
Jun 12 2021, 6:36 AM · ARM

Apr 30 2021

oskar.holmlund_ohdata.se closed D29996: Add committer entries for myself, OH.
Apr 30 2021, 1:32 PM
oskar.holmlund_ohdata.se committed R9:e633f0b9dfa5: Add committers entries for Oskar Holmlund (oh) (authored by oskar.holmlund_ohdata.se).
Add committers entries for Oskar Holmlund (oh)
Apr 30 2021, 1:32 PM
oskar.holmlund_ohdata.se closed D29890: Add myself as src commiters.
Apr 30 2021, 1:30 PM
oskar.holmlund_ohdata.se committed R10:7b88cd8bbf37: Add myself(oh) as src committer and mentor(manu). (authored by oskar.holmlund_ohdata.se).
Add myself(oh) as src committer and mentor(manu).
Apr 30 2021, 1:30 PM

Apr 26 2021

oskar.holmlund_ohdata.se requested review of D29996: Add committer entries for myself, OH.
Apr 26 2021, 5:05 PM

Apr 21 2021

oskar.holmlund_ohdata.se updated the summary of D29890: Add myself as src commiters.
Apr 21 2021, 5:00 PM
oskar.holmlund_ohdata.se requested review of D29890: Add myself as src commiters.
Apr 21 2021, 4:59 PM

Apr 2 2021

oskar.holmlund_ohdata.se requested review of D29547: am335x_ehrpwm.c add support for flags (PWM_POLARITY_INVERTED).
Apr 2 2021, 9:24 AM · ARM
oskar.holmlund_ohdata.se requested review of D29546: am335x_ehrpwm.c remove sysctl interface.
Apr 2 2021, 9:11 AM · ARM

Mar 10 2021

oskar.holmlund_ohdata.se added a comment to D29139: share/man/man9/pwmbus.9 fix types in arguments.

rpokala: Thank you for your comments.

Mar 10 2021, 9:59 AM
oskar.holmlund_ohdata.se updated the diff for D29139: share/man/man9/pwmbus.9 fix types in arguments.

pwmbus.9
change type for argument channel and the pointer nchannel (int -> u_int)

Mar 10 2021, 9:58 AM

Mar 9 2021

oskar.holmlund_ohdata.se added a comment to D29137: usr.sbin/pwm/pwm add support for flags.

.dD field in manual page needs to be updated.

Mar 9 2021, 10:05 AM · ARM
oskar.holmlund_ohdata.se requested review of D29139: share/man/man9/pwmbus.9 fix types in arguments.
Mar 9 2021, 10:05 AM
oskar.holmlund_ohdata.se updated the diff for D29137: usr.sbin/pwm/pwm add support for flags.

Remove share/man/man9/pwmbus.9
Fix space around &

Mar 9 2021, 10:02 AM · ARM
oskar.holmlund_ohdata.se requested review of D29137: usr.sbin/pwm/pwm add support for flags.
Mar 9 2021, 8:28 AM · ARM

Feb 21 2021

oskar.holmlund_ohdata.se requested review of D28841: am335x_dmtpps module complains about version missmatch ti_sysc.
Feb 21 2021, 6:22 PM · ARM

Feb 4 2021

oskar.holmlund_ohdata.se updated the diff for D27889: TI SoC rework clk support.

Update ti_prcm.c to add clk link in probe() instead of attach to avoid the need to declare syscon_generic.c attach as public.
Remove attach() function in ti_prcm.c and use inherited one from syscon_generic.c

Feb 4 2021, 12:23 AM · ARM

Jan 15 2021

oskar.holmlund_ohdata.se updated the diff for D27889: TI SoC rework clk support.

Remove syscon_generic_handle from syscon_generic.c and add into ti_prcm.c and ti_scm_syscon.c

Jan 15 2021, 12:29 AM · ARM
oskar.holmlund_ohdata.se updated the diff for D27889: TI SoC rework clk support.
  • Add parents for ti,clkctrl.
  • since the node scm_conf@0 (compatible "syscon", "simple-bus") needs to be attached as soon as posible during boot and syscon_generic are in pass BUS_PASS_DEFAULT I readded ti_scm_syscon.c and removed more or less everything but the probe() function and "subclass" syscon_generic. Added checks in probe() to ensure it not connect to other SoCs syscon nodes.
Jan 15 2021, 12:02 AM · ARM

Jan 5 2021

oskar.holmlund_ohdata.se abandoned D26552: Revert DTS for omap family for stable/12 and releng 12.2.

Yes, this revision is nothing to care about anymore.

Jan 5 2021, 3:41 PM · ARM

Jan 4 2021

oskar.holmlund_ohdata.se updated the diff for D27889: TI SoC rework clk support.

Fix cpu reset functions in ti_prcm.c

Jan 4 2021, 8:08 AM · ARM

Jan 2 2021

oskar.holmlund_ohdata.se added inline comments to D27889: TI SoC rework clk support.
Jan 2 2021, 12:05 PM · ARM
oskar.holmlund_ohdata.se requested review of D27889: TI SoC rework clk support.
Jan 2 2021, 11:52 AM · ARM

Nov 27 2020

oskar.holmlund_ohdata.se requested review of D27397: Add IRQ resource to ti_spi.c.
Nov 27 2020, 5:46 PM · ARM
oskar.holmlund_ohdata.se requested review of D27396: Add IRQ resource to SPIBUS.
Nov 27 2020, 5:30 PM · ARM

Oct 18 2020

oskar.holmlund_ohdata.se updated the diff for D26829: Mute efi/loader.

Remove #ifdefs in conf.c
Add nullconsole.c / spinconsole.c to Makefile.inc (arm, arm64 and riscv).

Oct 18 2020, 5:29 AM · ARM

Oct 17 2020

oskar.holmlund_ohdata.se requested review of D26829: Mute efi/loader.
Oct 17 2020, 2:34 PM · ARM

Sep 26 2020

oskar.holmlund_ohdata.se added a comment to D26402: Update syscon_generic.c to support simplebus and clkdev interface.
In D26402#591631, @mmel wrote:

Already committed as part of other change.

Sep 26 2020, 11:32 AM · ARM

Sep 25 2020

oskar.holmlund_ohdata.se requested review of D26552: Revert DTS for omap family for stable/12 and releng 12.2.
Sep 25 2020, 9:15 AM · ARM

Sep 24 2020

oskar.holmlund_ohdata.se abandoned D26405: Take 2: Update syscon_generic.c to support simplebus.

Use D26401 D26402 and D26468 instead

Sep 24 2020, 6:42 AM · ARM
oskar.holmlund_ohdata.se added a comment to D25512: WIP bootnext: Next Generation.

Thanks, should be better now.

Sep 24 2020, 5:28 AM

Sep 23 2020

oskar.holmlund_ohdata.se added a comment to D25512: WIP bootnext: Next Generation.

If src.conf contains
WITHOUT_LOADER_ZFS=true
WITHOUT_ZFS=true

Sep 23 2020, 4:47 PM
oskar.holmlund_ohdata.se updated the diff for D26195: TI AM335x: Cleanup after migration to dev/extres/clk framework.

remove some confused \0

Sep 23 2020, 1:39 PM · ARM

Sep 17 2020

oskar.holmlund_ohdata.se updated the diff for D26401: remove ti_scm_syscon.c.

Copy clk_div.c, clk_gate.c and clk_mux from sys/dev/extres/clk/ and extend them with options to use syscon if the parent are syscon, otherwise use clkdev.

Sep 17 2020, 4:49 PM · ARM
oskar.holmlund_ohdata.se requested review of D26468: Add simplebus_detach() .
Sep 17 2020, 4:38 PM · ARM
oskar.holmlund_ohdata.se updated the diff for D26402: Update syscon_generic.c to support simplebus and clkdev interface.

Michal, thanks for your guidance.

Sep 17 2020, 4:25 PM · ARM

Sep 11 2020

oskar.holmlund_ohdata.se requested review of D26405: Take 2: Update syscon_generic.c to support simplebus.
Sep 11 2020, 2:30 PM · ARM
oskar.holmlund_ohdata.se updated the diff for D26402: Update syscon_generic.c to support simplebus and clkdev interface.

Thanks Thomas - didnt try GENERIC build.

Sep 11 2020, 2:13 PM · ARM

Sep 10 2020

oskar.holmlund_ohdata.se updated the diff for D26195: TI AM335x: Cleanup after migration to dev/extres/clk framework.

Correct initialize of gates clkdef.flags

Sep 10 2020, 8:26 PM · ARM
oskar.holmlund_ohdata.se requested review of D26402: Update syscon_generic.c to support simplebus and clkdev interface.
Sep 10 2020, 8:22 PM · ARM
oskar.holmlund_ohdata.se requested review of D26401: remove ti_scm_syscon.c.
Sep 10 2020, 8:01 PM · ARM

Aug 26 2020

oskar.holmlund_ohdata.se requested review of D26195: TI AM335x: Cleanup after migration to dev/extres/clk framework.
Aug 26 2020, 3:01 PM · ARM
oskar.holmlund_ohdata.se requested review of D26194: Fix Beaglebone black MMC after DTS update .
Aug 26 2020, 2:11 PM · ARM

Jun 23 2020

oskar.holmlund_ohdata.se requested review of D25190: U-Boot beaglebone black will not boot from eMMC.
Jun 23 2020, 3:26 AM
oskar.holmlund_ohdata.se requested review of D25375: Fix compile error in devel/libpru.
Jun 23 2020, 3:22 AM

Jun 20 2020

oskar.holmlund_ohdata.se requested review of D25378: Remove cmake dependency from devel/pructl.
Jun 20 2020, 7:32 PM
oskar.holmlund_ohdata.se requested review of D25376: Remove cmake dependency from devel/libpru.
Jun 20 2020, 7:21 PM

Jun 19 2020

oskar.holmlund_ohdata.se added a comment to D25118: Ti AM335x move to dev/extres/clk framework.
In D25118#558687, @mmel wrote:

It also looks OK for me. I have a few small items that we should rethink or fix, but we can do all of these (including pandaboard support) as follow-up fixes. I can commit this as is over the weekend and then we can start discussing improvements (and I also hope to have a little more free time from next week).
Oscar, manu do you agree?
Problematic (for me) items are:

  • The ti_dpll_clk_set_freq routine should respect rounding (dpll) and DRY_RUN.
  • I’m not a big friend of bulk clock enable in ti_sysc_clock_enable().
  • probably , it will be easier to convert scm_clocks and prcm_clocks instances from FDT data driven to compiled-in table driven clocks implementation.

But all these are minor and should be discussed firstly...

Jun 19 2020, 10:18 PM · ARM

Jun 18 2020

oskar.holmlund_ohdata.se updated the diff for D25118: Ti AM335x move to dev/extres/clk framework.

Fix sys/arm/ti/ti_pruss.c to activate pruss subsystems
Add shim driver ti_prm to reset the pruss.

Jun 18 2020, 9:18 AM · ARM

Jun 13 2020

oskar.holmlund_ohdata.se updated the diff for D25118: Ti AM335x move to dev/extres/clk framework.

Create a "virtual clock" (not mentioned in the dts) for gdbclk functional clocks for GPIO1-4 and get rid of changes in dev/extres/clk/clk.c (D25175) needed in earlier revision.

Jun 13 2020, 5:55 PM · ARM
oskar.holmlund_ohdata.se abandoned D25175: Add functions to sys/dev/extres/clk.

Thank you @mmel for the background and direction.

Jun 13 2020, 5:47 PM · ARM

Jun 10 2020

oskar.holmlund_ohdata.se added inline comments to D25175: Add functions to sys/dev/extres/clk.
Jun 10 2020, 11:59 AM · ARM

Jun 8 2020

oskar.holmlund_ohdata.se updated the test plan for D25190: U-Boot beaglebone black will not boot from eMMC.
Jun 8 2020, 3:28 PM

Jun 7 2020

oskar.holmlund_ohdata.se updated the diff for D25118: Ti AM335x move to dev/extres/clk framework.

Update sys/arm/ti/am335x/am335x_scm.c to use syscon interface for reading and writing to registers in that memory range of the control module (TRM chapter 9).

Jun 7 2020, 9:55 PM · ARM
oskar.holmlund_ohdata.se requested review of D25175: Add functions to sys/dev/extres/clk.
Jun 7 2020, 10:56 AM · ARM
oskar.holmlund_ohdata.se updated the diff for D25118: Ti AM335x move to dev/extres/clk framework.
  • Move clock related files to subfolder /sys/arm/ti/clk
  • extract sys/dev/extres/clk to another review
  • due to recent update of devicetree @ head the dts are removed
Jun 7 2020, 10:29 AM · ARM

Jun 5 2020

oskar.holmlund_ohdata.se added a comment to D25118: Ti AM335x move to dev/extres/clk framework.
In D25118#554295, @manu wrote:

I've just commited the DTS changes (after updating to 5.7).

Jun 5 2020, 8:47 PM · ARM

Jun 3 2020

oskar.holmlund_ohdata.se added a comment to D25118: Ti AM335x move to dev/extres/clk framework.
In D25118#553391, @imp wrote:

OMAP4 will probably not work at current state.

So is the breakage big or small? I ask because I have a pandaboard which is omap4 iirc.

Jun 3 2020, 10:22 PM · ARM
oskar.holmlund_ohdata.se added a comment to D25118: Ti AM335x move to dev/extres/clk framework.
In D25118#553388, @manu wrote:

Only had a quick look.
Could you put the dev/extres/clk changes in another review and add me and mmel@ please ?

I fix it tomorrow.

Jun 3 2020, 10:14 PM · ARM
oskar.holmlund_ohdata.se requested review of D25118: Ti AM335x move to dev/extres/clk framework.
Jun 3 2020, 4:06 PM · ARM

May 31 2020

oskar.holmlund_ohdata.se updated the diff for D25080: Rename DEBUG to DPRINTF.

Change to #if 0 instead of #ifdef DEBUG as suggested from EmmanuelVadot

May 31 2020, 3:51 PM

May 30 2020

oskar.holmlund_ohdata.se requested review of D25080: Rename DEBUG to DPRINTF.
May 30 2020, 10:38 PM
oskar.holmlund_ohdata.se added a member for arm64: oskar.holmlund_ohdata.se.
May 30 2020, 10:00 PM
oskar.holmlund_ohdata.se added a member for ARM: oskar.holmlund_ohdata.se.
May 30 2020, 9:58 PM