Sat, Jan 20
Dec 4 2017
Again better; at this point, I'm mainly concerned about:
- Handling of the timeout provided in mmc_switch_fill_mmcio(); partly this needs to happen in sdhci(4), i. e. SDHCI_TIMEOUT_CONTROL needs to be set accordingly, but a counterpart to mmc_switch() of mmc_subr.c should live in CAM.
- Handling of suspend/resume in sdda(4) but also already starting in sdhci(4) in the MMCCAM case.
- Usage of cpi.maxio for disk->d_maxsize with the former set to an incorrect value by sdhci(4) (which obviously is an sdhci(4) bug, though).
Nov 26 2017
Don't allow PSR_AARCH32 to be set in sigreturn().
Considering that there is no need to split up this into two code paths for 32-bit/64-bit at least for what I'm trying to achieve, would you mind if I went ahead, committing this change as is? Once this change and D13148 land, I can work towards getting the sysent for cloudabi32 committed.
Nov 24 2017
Nov 19 2017
Announce armv7 instead of armv6.
Are we expecting to run armv6 code, or should we just support armv7?
This will allow userspace to switch between AArch64 and AArch32 via sigreturn. sys_sigreturn has checks on the PSR bits to ensure they are safe to install that this will break.
I split the syncronous exception out into a new handler in my compat32 patch as it allows further sanity checks, e.g. that the kernel thinks the current process should be in 32-bit mode.
Nov 18 2017
Nov 14 2017
Address review comments
This looks OK-ish. There's still a fair amount of cut and paste going on, but that's no different than other drivers. There's a few things we can cleanup, but maybe in a separate commit.
After the updates for Marius' suggestions, we're close enough to style(9) to be ready to go.
I'm clicking Accept, but will feel better of Marius double checks my belief.
Nov 12 2017
Hi Marius, thank you very much for such a verbose review!
I have addressed most of your comments. As for the remaining ones -- they require some more work which I'd like to do in the upcoming changes. As all my work should be reviewed by Warner before committing, I'd like to try to keep the diff sizes under certain limit.
Address review comments
Oct 30 2017
Generally better, but still quite a few TODOs.
My CAM knowledge is rusty and I've also mainly worked on SIM drivers before so someone vivid in CAM needs to review the CAM-specific parts. The way the commands for switching partitions are inserted/handled may be correct, but at least seems somewhat fishy to me.
Oct 28 2017
void function shouldn'r return a value, remove sdda_hook_into_geom()
Actually implement partitions support
Oct 22 2017
Well, IMO committing the partition identification code only with all the glory details yet to be done is premature, even for head.
Generally: Please adhere to style(9).