Fri, Mar 8
Thu, Mar 7
It looks ok for me now but could you please separate the change for drivers and GENERIC kernel config ?
Tue, Mar 5
Latest code review comments. Added a newline before a return, and removed the extra boot verbose output.
Thanks for the changes - I had two minor comments to the latest version. Once applied, I will check on the clearfog - if it continues to work, I will approve and commit the change.
Mon, Mar 4
Updated the diff to correctly set the cpu mask if the port is connected to an ethernet device.
I can confirm that the changes made to if_mvneta.c for doing switch detection work, and it correctly detects the switch. The switch ports and fixed-link speeds are also configured correctly. I missed part of the changes I need to make though, and that is if there is an ethernet device on the port, then we need to set the CPUPORT flag.
Sun, Mar 3
Removed the ESPRESSO kernel config and placed the appropriate devices in the arm64 GENERIC config.
I have not yet had a chance to verify this all works on my ESPRESSObin.
Thu, Feb 21
Thanks for the feedback! Will work on this shortly, travel and work have kept me busy.
Feb 13 2019
Thanks for the patch. After you resubmit, I'd like to try it on the Clearfog board as well.
Feb 8 2019
Added some comments.
Keep up the good work :)
Feb 7 2019
I also have these changes up on Github at: https://github.com/freebsd/freebsd/compare/master...theasylum:fix/e6000sw-fdt if it is easier to review there due to more context. I did re-create the diff as requested by @manu with -U999, so hopefully that helps.
Updated to match style(9) thanks to @dteske's comment.
Try to get ahold of mw@ and loos@ to review
Feb 6 2019
Will rebase and submit a new rev addressing the comment.
Feb 4 2019
I think this needs to be rebased too
Jan 30 2019
Dec 12 2018
Nov 23 2018
Nov 19 2018
Nov 16 2018
Nov 14 2018
looks good to me. thanks.
Need to take another look at this after handling IORT table parsing.
I have submitted another patch for doing NUMA for CPUs similar to x86. This can be dropped.
Nov 1 2018
Oct 31 2018
Had to redo link interrupts - dropping this rev. Will post a commit to fixup link interrupts and a new version of this change to use the new interrupt routing.