ARMUmbrella
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Sat, Jan 20

kevans added a member for ARM: kevans.
Sat, Jan 20, 3:00 AM

Dec 4 2017

marius added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Again better; at this point, I'm mainly concerned about:

  • Handling of the timeout provided in mmc_switch_fill_mmcio(); partly this needs to happen in sdhci(4), i. e. SDHCI_TIMEOUT_CONTROL needs to be set accordingly, but a counterpart to mmc_switch() of mmc_subr.c should live in CAM.
  • Handling of suspend/resume in sdda(4) but also already starting in sdhci(4) in the MMCCAM case.
  • Usage of cpi.maxio for disk->d_maxsize with the former set to an incorrect value by sdhci(4) (which obviously is an sdhci(4) bug, though).
Dec 4 2017, 10:47 PM · ARM

Nov 26 2017

ed closed D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
Nov 26 2017, 2:56 PM · arm64, ARM
andrew accepted D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
Nov 26 2017, 2:55 PM · arm64, ARM
ed updated the diff for D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Rebase.

Nov 26 2017, 2:55 PM · arm64, ARM
andrew added inline comments to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
Nov 26 2017, 2:53 PM · arm64, ARM
ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Maybe you're referring to switching between 64-bit and 32-bit code without going through EL1 first. This is explicitly documented as unsupported.

No, from memory it was an incorrect check the value passed to the kernel from userspace was wrong. I did make sure we have a check on signal return, however for it to work we need to check M[4] is set correctly. With this change the user could change this bit.

Nov 26 2017, 2:36 PM · arm64, ARM
ed updated the diff for D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Don't allow PSR_AARCH32 to be set in sigreturn().

Nov 26 2017, 2:35 PM · arm64, ARM
ed closed D13146: Make 32-bit system calls end up in svc_handler()..
Nov 26 2017, 2:28 PM · arm64, ARM
andrew added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
In D13148#273977, @ed wrote:
In D13148#273913, @ed wrote:

This would be benign, right? For the kernel, it is irrelevant whether user space sets or clears this flag. Just like NZCV, etc.

I'm not sure how the kernel would handle userspace changing between 64 and 32 bit code.

It's pretty straight-forward how that's handled, right? The only way this can take effect is by going through EL1, the kernel, first. For the CPU, it would just be an ordinary context switch like any other.

Nov 26 2017, 1:24 PM · arm64, ARM
andrew accepted D13146: Make 32-bit system calls end up in svc_handler()..
Nov 26 2017, 1:00 PM · arm64, ARM
ed added a comment to D13146: Make 32-bit system calls end up in svc_handler()..

Considering that there is no need to split up this into two code paths for 32-bit/64-bit at least for what I'm trying to achieve, would you mind if I went ahead, committing this change as is? Once this change and D13148 land, I can work towards getting the sysent for cloudabi32 committed.

Nov 26 2017, 12:44 PM · arm64, ARM

Nov 24 2017

ed closed D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..
Nov 24 2017, 1:52 PM · arm64, ARM
ed closed D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 24 2017, 1:51 PM · arm64, ARM
andrew accepted D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..
Nov 24 2017, 1:49 PM · arm64, ARM
andrew accepted D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 24 2017, 1:45 PM · arm64, ARM

Nov 19 2017

ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
In D13148#273913, @ed wrote:

This would be benign, right? For the kernel, it is irrelevant whether user space sets or clears this flag. Just like NZCV, etc.

I'm not sure how the kernel would handle userspace changing between 64 and 32 bit code.

Nov 19 2017, 7:45 PM · arm64, ARM
andrew added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
In D13148#273913, @ed wrote:

This would be benign, right? For the kernel, it is irrelevant whether user space sets or clears this flag. Just like NZCV, etc.

Nov 19 2017, 3:19 PM · arm64, ARM
ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

This will allow userspace to switch between AArch64 and AArch32 via sigreturn. sys_sigreturn has checks on the PSR bits to ensure they are safe to install that this will break.

Nov 19 2017, 12:49 PM · arm64, ARM
ed added a comment to D13146: Make 32-bit system calls end up in svc_handler()..

I split the syncronous exception out into a new handler in my compat32 patch as it allows further sanity checks, e.g. that the kernel thinks the current process should be in 32-bit mode.

Nov 19 2017, 12:45 PM · arm64, ARM
ed added a comment to D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..

Are we expecting to run armv6 code, or should we just support armv7?

Nov 19 2017, 12:40 PM · arm64, ARM
ed added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 19 2017, 12:40 PM · arm64, ARM
ed updated the summary of D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 19 2017, 12:39 PM · arm64, ARM
ed updated the diff for D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..

Announce armv7 instead of armv6.

Nov 19 2017, 12:39 PM · arm64, ARM
andrew added a comment to D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..

Are we expecting to run armv6 code, or should we just support armv7?

Nov 19 2017, 11:34 AM · arm64, ARM
andrew requested changes to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

This will allow userspace to switch between AArch64 and AArch32 via sigreturn. sys_sigreturn has checks on the PSR bits to ensure they are safe to install that this will break.

Nov 19 2017, 11:33 AM · arm64, ARM
andrew added a comment to D13146: Make 32-bit system calls end up in svc_handler()..

I split the syncronous exception out into a new handler in my compat32 patch as it allows further sanity checks, e.g. that the kernel thinks the current process should be in 32-bit mode.

Nov 19 2017, 11:30 AM · arm64, ARM
andrew added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 19 2017, 10:51 AM · arm64, ARM

Nov 18 2017

ed added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 18 2017, 7:35 PM · arm64, ARM
ed added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 18 2017, 7:34 PM · arm64, ARM
ed added projects to D13148: Add a Saved Process Status Register bit for AArch32 execution mode.: ARM, arm64.
Nov 18 2017, 7:29 PM · arm64, ARM
ed added projects to D13146: Make 32-bit system calls end up in svc_handler().: ARM, arm64.
Nov 18 2017, 6:51 PM · arm64, ARM
ed added projects to D13143: Make rtld use read(2) instead of mmap(2) for ELF headers: ARM, arm64.
Nov 18 2017, 6:51 PM
manu added projects to D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode.: ARM, arm64.
Nov 18 2017, 6:38 PM · arm64, ARM
manu added projects to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32.: ARM, arm64.
Nov 18 2017, 6:36 PM · arm64, ARM

Nov 14 2017

kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

Address review comments

Nov 14 2017, 9:48 PM · ARM
kibab added inline comments to D12762: Implement initial MMC partitions support for MMCCAM.
Nov 14 2017, 9:48 PM · ARM
imp accepted D12762: Implement initial MMC partitions support for MMCCAM.

This looks OK-ish. There's still a fair amount of cut and paste going on, but that's no different than other drivers. There's a few things we can cleanup, but maybe in a separate commit.
After the updates for Marius' suggestions, we're close enough to style(9) to be ready to go.
I'm clicking Accept, but will feel better of Marius double checks my belief.

Nov 14 2017, 8:08 PM · ARM

Nov 12 2017

kibab added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Hi Marius, thank you very much for such a verbose review!
I have addressed most of your comments. As for the remaining ones -- they require some more work which I'd like to do in the upcoming changes. As all my work should be reviewed by Warner before committing, I'd like to try to keep the diff sizes under certain limit.

Nov 12 2017, 7:52 PM · ARM
kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

Address review comments

Nov 12 2017, 7:50 PM · ARM

Oct 30 2017

marius added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Generally better, but still quite a few TODOs.
My CAM knowledge is rusty and I've also mainly worked on SIM drivers before so someone vivid in CAM needs to review the CAM-specific parts. The way the commands for switching partitions are inserted/handled may be correct, but at least seems somewhat fishy to me.

Oct 30 2017, 3:23 AM · ARM

Oct 28 2017

kibab added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Well, IMO committing the partition identification code only with all the glory details yet to be done is premature, even for head.
Generally: Please adhere to style(9).

Oct 28 2017, 12:44 PM · ARM
kibab updated the summary of D12762: Implement initial MMC partitions support for MMCCAM.
Oct 28 2017, 12:42 PM · ARM
kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

void function shouldn'r return a value, remove sdda_hook_into_geom()

Oct 28 2017, 12:32 PM · ARM
kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

Actually implement partitions support

Oct 28 2017, 12:27 PM · ARM

Oct 22 2017

marius added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Well, IMO committing the partition identification code only with all the glory details yet to be done is premature, even for head.
Generally: Please adhere to style(9).

Oct 22 2017, 11:02 PM · ARM
kibab created D12762: Implement initial MMC partitions support for MMCCAM.
Oct 22 2017, 9:48 PM · ARM

Oct 12 2017

bz closed D12566: arm: add virtio_pci support for other virtualization environments to GENERIC.
Oct 12 2017, 2:32 PM · ARM

Oct 3 2017

andrew accepted D12566: arm: add virtio_pci support for other virtualization environments to GENERIC.
Oct 3 2017, 4:00 PM · ARM

Oct 2 2017

bz created D12566: arm: add virtio_pci support for other virtualization environments to GENERIC.
Oct 2 2017, 12:55 PM · ARM