Sat, Oct 13
Sep 15 2018
Sep 11 2018
Happy to help :)
Sep 10 2018
Looks fine when it comes to mdoc syntax.
Sep 9 2018
Sep 6 2018
re-did diff to include all lines
applied diff to most recently obtained revision (r338415), added as-is. No build nor startup problems noted.
Aug 26 2018
Change driver declaration to fix a bug that caused the wrong kind of spibus to attach. Thanks, Ian Lepore.
Aug 24 2018
I've made suggested changes but the driver has regressed: the flash device doesn't get recognized. I'm looking into it.
Add sys/dev/flash/mx25lreg.h which has two new flash commands added.
Take driver out of GENERIC kerne. Make other minor fix-ups.
Aug 23 2018
The main style issue I can see is the indentation of lines that have been split. They should be tabbed to the same level, then add 4 spaces.
Any chance of getting this committed before code freeze? I think it's ready. I'm not comfortable making the changes to mx25l.c to support dual stacked memories (I have no hardware to test that) but I've left in the hooks needed in this driver.
Aug 8 2018
Add compatible string for Zynq Ultrascale which uses same qspi device.
Aug 2 2018
Jul 26 2018
Jul 2 2018
Jun 25 2018
My problem was clock related (which I've fixed this weekend) and using latest u-boot which have usb problem ...
You probably didn't have the error as u-boot setup the clocks for you, now that we correctly set the clocks it's working.
Jun 15 2018
gonzo - I added you as a reviewer since you apparently did the last commit to the driver, and because it's related to the RPi audio.
Jun 12 2018
Jun 5 2018
Jun 4 2018
other than the minor style nits, this looks good.
May 25 2018
May 22 2018
I agree. Comment says this was from nvme_scan_lun, and it uses path here not periph->path.
May 8 2018
We tried to do this before, but we analyzed the interfaces, we saw that they are x86 dependent (memseg set, etc). We would end up with a common interface only for starting/stopping/running.
@mihai Before this can proceed this review needs to be broken up in to at _least_ 3 pieces
Apr 26 2018
Fix support for dual parallel and stacked memories (changes provided by John Sears). Change config option from zy7_qspi to just qspi.