- User Since
- Feb 28 2016, 8:41 PM (325 w, 1 d)
Mar 6 2020
Dec 1 2019
I am ok too. I can probably manage to get this committed within next week if there are no objections.
Mar 22 2019
Mar 21 2019
Please remove the dts file from this review. Let's import it with the rest of the dts/dtsi files in https://reviews.freebsd.org/D17955
Why was MZK-W04N-XX.dts moved to sys/dts instead of sys/gnu/dts ?
Feb 22 2019
Nov 19 2018
Nov 16 2018
! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.
Please split Mediatek and Atheros in separate reviews.
Dec 8 2017
Oct 17 2017
as far as if_rt changes and dts additions go, I am ok with this.
Jul 31 2017
Feb 20 2017
Feb 16 2017
OK, v2 patch is here:
Feb 15 2017
Can you please test with the patch found at:
OK, one issue exists with the existing code:
- if more ports are configured as "untagged" than are configured as "untagged members" for the given VLAN the check would fail.
Can you explain the problem in a bit more detail?
The code you're suggesting to change (from memory) is intended to do the following:
- check which ports are configured to untag VLANs
- get the subset of VLAN member ports that are also untagged.
- compare the 2 values and if they match - go ahead; if they don't match - error out.
Feb 9 2017
Feb 6 2017
Jan 23 2017
I would like to eventually get rid of all the ifdef's (where possible, of course) related to SoC type (e.g., if defined MT7620, etc).. unfortunately at the moment I have absolutely no bandwidth to start doing that, so I am ok with this for now.
Nov 7 2016
Any other comments on this? If it's ok with everyone I'd like to commit it...
Hmm, this is weird, it still fails the same way for me, although I am using the default gcc:
gcc version 4.2.1 20070831 patched [FreeBSD]
Actual build failure message is:
/src/current.git/sys/sys/boot.h:40: warning: 'howto_names' defined but not used
All files, which report an issue of __ARM_ARCH not being defined (and include machine/armreg.h):
Sep 7 2016
Sep 5 2016
Yes, I was planning to commit it on Wednesday if I get a chance, but wouldn't mind if someone else does it in the meantime...
Sep 1 2016
The updated diff also fixes additional problems seen on Broadcom MIPS (INTRNG without FDT) as a result of the r304459 changes. The new diff was boot tested by mizhka.
Aug 31 2016
Provide more diff context
Aug 30 2016
Previous diff was not compiling for BCM kernel config, as BCM only uses INTRNG but not FDT.
Rework the fix, so that cpu_establish_[hard|soft]intr uses a different intr mapping strategy, which doesn't require FDT-specific data to be exposed to non-FDT kernels.
Aug 29 2016
Jun 6 2016
May 25 2016
May 19 2016
May 18 2016
May 17 2016
May 16 2016
May 14 2016
Add MT7620/MT7621 first pass driver as well.
May 13 2016
add copyright to *.h files.
May 6 2016
May 5 2016
Apr 23 2016
Apr 21 2016
Update diffs to remove MT7621 GIC stuff as it will be unneeded after D6045.
Update diffs so MT7621 can be built