Page MenuHomeFreeBSD

sgalabov (Stanislav Galabov)
User

Projects

User Details

User Since
Feb 28 2016, 8:41 PM (189 w, 5 d)

Recent Activity

Mar 22 2019

sgalabov added a comment to D17955: mips dts modify.

My understand is sys/gnu/dts have only openwrt(opneled) dts files. And sys/dts have freebsd original dts files. MZK-W04N-XX.dts is my missing add dts file then move to freebsd dts directory. Do you think how to sync openwrt(opneled) dts files ?

Mar 22 2019, 8:00 AM

Mar 21 2019

sgalabov requested changes to D16757: RTL8366 support on RT3052.

Please remove the dts file from this review. Let's import it with the rest of the dts/dtsi files in https://reviews.freebsd.org/D17955

Mar 21 2019, 10:07 AM
sgalabov requested changes to D17955: mips dts modify.

Why was MZK-W04N-XX.dts moved to sys/dts instead of sys/gnu/dts ?

Mar 21 2019, 9:54 AM

Feb 22 2019

sgalabov committed rD52826: Update my PGP key.
Update my PGP key
Feb 22 2019, 3:24 PM

Nov 19 2018

sgalabov committed rS340613: Fix access to cpu_model[] in mtk_soc_set_cpu_model().
Fix access to cpu_model[] in mtk_soc_set_cpu_model()
Nov 19 2018, 6:49 AM

Nov 16 2018

sgalabov committed rS340476: Implement support for sysctl hw.model for Mediatek/Ralink SoCs.
Implement support for sysctl hw.model for Mediatek/Ralink SoCs
Nov 16 2018, 11:17 AM
sgalabov added a comment to D18001: cpu model display on dmesg.

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
OK I will delete Mediatek in this review.

Nov 16 2018, 11:16 AM
sgalabov added a comment to D18001: cpu model display on dmesg.

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

Nov 16 2018, 9:51 AM
sgalabov requested changes to D18001: cpu model display on dmesg.

Please split Mediatek and Atheros in separate reviews.

Nov 16 2018, 7:13 AM

Dec 8 2017

sgalabov requested changes to D12736: i2c support for mediatek soc.
Dec 8 2017, 8:48 AM

Oct 17 2017

sgalabov accepted D12649: FDT support for RTL8366 on etherswitch framework.

as far as if_rt changes and dts additions go, I am ok with this.

Oct 17 2017, 9:51 AM
sgalabov accepted D12648: RT2880 pin control fix.
Oct 17 2017, 9:48 AM

Jul 31 2017

sgalabov committed rS321776: Add myself to calendar.
Add myself to calendar
Jul 31 2017, 9:47 AM

Feb 20 2017

sgalabov closed D9607: fixed vlangroup opration at RT3050. by committing rS313988: etherswitch: Fix RT305x vlan group operation.
Feb 20 2017, 8:10 AM
sgalabov committed rS313988: etherswitch: Fix RT305x vlan group operation.
etherswitch: Fix RT305x vlan group operation
Feb 20 2017, 8:10 AM

Feb 16 2017

sgalabov added a comment to D9607: fixed vlangroup opration at RT3050..

OK, v2 patch is here:
https://people.freebsd.org/~sgalabov/mtkswitch_v2.patch

Feb 16 2017, 7:40 AM
sgalabov added a comment to D9607: fixed vlangroup opration at RT3050..

This is always false in patch.

tmp = v->es_untagged_ports & v->es_member_ports;
/* fail if untagged members are not a subset of all members */
if (tmp != v->es_untagged_ports) {

Because of all v->es_untagged_ports bits contain in v->es_member_ports.

Feb 16 2017, 3:51 AM

Feb 15 2017

sgalabov added a comment to D9607: fixed vlangroup opration at RT3050..

Can you please test with the patch found at:
https://people.freebsd.org/~sgalabov/mtkswitch.patch

Feb 15 2017, 11:32 AM
sgalabov added a comment to D9607: fixed vlangroup opration at RT3050..

OK, one issue exists with the existing code:

  • if more ports are configured as "untagged" than are configured as "untagged members" for the given VLAN the check would fail.
Feb 15 2017, 9:24 AM
sgalabov added a comment to D9607: fixed vlangroup opration at RT3050..

Can you explain the problem in a bit more detail?
The code you're suggesting to change (from memory) is intended to do the following:

  1. check which ports are configured to untag VLANs
  2. get the subset of VLAN member ports that are also untagged.
  3. compare the 2 values and if they match - go ahead; if they don't match - error out.
Feb 15 2017, 9:17 AM

Feb 9 2017

sgalabov committed rS313465: Set GDMA1 Frames Destination Port to Port 0 (CPU).
Set GDMA1 Frames Destination Port to Port 0 (CPU)
Feb 9 2017, 7:29 AM
sgalabov closed D9301: add GDMA1 Frames Destination Port to Port 0 CPU setting by committing rS313465: Set GDMA1 Frames Destination Port to Port 0 (CPU).
Feb 9 2017, 7:29 AM

Feb 6 2017

sgalabov committed rS313343: sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu().
sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu()
Feb 6 2017, 2:58 PM
sgalabov closed D9460: ARM: Use a 32-bit variable for control register instead of 8-bit by committing rS313343: sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu().
Feb 6 2017, 2:58 PM
sgalabov retitled D9460: ARM: Use a 32-bit variable for control register instead of 8-bit from to ARM: Use a 32-bit variable for control register instead of 8-bit.
Feb 6 2017, 12:48 PM

Jan 23 2017

sgalabov accepted D9301: add GDMA1 Frames Destination Port to Port 0 CPU setting.

I would like to eventually get rid of all the ifdef's (where possible, of course) related to SoC type (e.g., if defined MT7620, etc).. unfortunately at the moment I have absolutely no bandwidth to start doing that, so I am ok with this for now.

Jan 23 2017, 7:05 AM

Nov 7 2016

sgalabov closed D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined by committing rS308415: Generate an error if machine/armreg.h is included without sys/cdefs.h.
Nov 7 2016, 11:35 AM · ARM
sgalabov committed rS308415: Generate an error if machine/armreg.h is included without sys/cdefs.h.
Generate an error if machine/armreg.h is included without sys/cdefs.h
Nov 7 2016, 11:35 AM
sgalabov updated the diff for D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.

Can you try with rS308408. It might pay to add an error if this file is included but _MACHINE_ASM_H_ is undefined.

Even better would be _SYS_CDEFS_H_.

Nov 7 2016, 11:14 AM · ARM
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.

Any other comments on this? If it's ok with everyone I'd like to commit it...

Nov 7 2016, 10:58 AM · ARM
sgalabov closed D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly by committing rS308406: Only include sys/boot.h if LINUX_BOOT_ABI is defined.
Nov 7 2016, 10:55 AM · ARM
sgalabov committed rS308406: Only include sys/boot.h if LINUX_BOOT_ABI is defined.
Only include sys/boot.h if LINUX_BOOT_ABI is defined
Nov 7 2016, 10:55 AM
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.

Hmm, this is weird, it still fails the same way for me, although I am using the default gcc:
gcc version 4.2.1 20070831 patched [FreeBSD]

Nov 7 2016, 10:37 AM · ARM
sgalabov added a comment to D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly.
In D8459#175948, @meloun-miracle-cz wrote:

Hmm, right.
Btw, which compiler you use? It seems that clang doesn't generate error for unused external variables...

Nov 7 2016, 10:34 AM · ARM
sgalabov added a comment to D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly.

Actual build failure message is:
/src/current.git/sys/sys/boot.h:40: warning: 'howto_names' defined but not used

Nov 7 2016, 10:20 AM · ARM
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.

All files, which report an issue of __ARM_ARCH not being defined (and include machine/armreg.h):
sys/arm/arm/cpufunc_asm_sheeva.S
sys/arm/arm/fiq_subr.S
sys/arm/arm/setstack.s

Nov 7 2016, 10:17 AM · ARM
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
In D8460#175937, @meloun-miracle-cz wrote:

Are you sure? Also for D8459? I'm able to compile actual SHEEVAPLUG kernel without any issue.

Nov 7 2016, 10:13 AM · ARM
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.

When is it the case that __ARM_ARCH is undefined? machine/acle-compat.h is included from sys/cdefs.h so this should have already been included.

Nov 7 2016, 10:11 AM · ARM
sgalabov retitled D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined from to ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
Nov 7 2016, 9:50 AM · ARM
sgalabov retitled D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly from to ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly.
Nov 7 2016, 9:46 AM · ARM

Sep 7 2016

sgalabov committed rS305527: Fix MIPS INTRNG (both FDT and non-FDT) behaviour broken by r304459.
Fix MIPS INTRNG (both FDT and non-FDT) behaviour broken by r304459
Sep 7 2016, 9:31 AM
sgalabov closed D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459 by committing rS305527: Fix MIPS INTRNG (both FDT and non-FDT) behaviour broken by r304459.
Sep 7 2016, 9:31 AM · MIPS

Sep 5 2016

sgalabov added a comment to D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.

Yes, I was planning to commit it on Wednesday if I get a chance, but wouldn't mind if someone else does it in the meantime...

Sep 5 2016, 7:16 PM · MIPS

Sep 1 2016

sgalabov added a comment to D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.

(Eg, it needs a bunch more testing on non-FDT, non-INTRNG platforms, but I bet that's going to be easy..)

Sep 1 2016, 3:32 PM · MIPS
sgalabov updated the diff for D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.

The updated diff also fixes additional problems seen on Broadcom MIPS (INTRNG without FDT) as a result of the r304459 changes. The new diff was boot tested by mizhka.

Sep 1 2016, 8:53 AM · MIPS

Aug 31 2016

sgalabov updated the diff for D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.

Provide more diff context

Aug 31 2016, 6:36 AM · MIPS
sgalabov added a comment to D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.

Hm, can you get someone who does FDT stuff on #bsdmips to look at this?

Aug 31 2016, 5:57 AM · MIPS

Aug 30 2016

sgalabov updated the diff for D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.

Previous diff was not compiling for BCM kernel config, as BCM only uses INTRNG but not FDT.
Rework the fix, so that cpu_establish_[hard|soft]intr uses a different intr mapping strategy, which doesn't require FDT-specific data to be exposed to non-FDT kernels.

Aug 30 2016, 6:45 AM · MIPS

Aug 29 2016

sgalabov retitled D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459 from to MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.
Aug 29 2016, 9:05 AM · MIPS

Jun 6 2016

sgalabov committed rS301497: Remove erroneous lock assertions.
Remove erroneous lock assertions
Jun 6 2016, 10:08 AM

May 25 2016

sgalabov committed rS300659: Build etherswitch support for appropriate Ralink/Mediatek SoCs.
Build etherswitch support for appropriate Ralink/Mediatek SoCs
May 25 2016, 6:47 AM
sgalabov committed rS300658: Bring ralink/mediatek DTS files in sync with LEDE.
Bring ralink/mediatek DTS files in sync with LEDE
May 25 2016, 6:40 AM
sgalabov committed rS300657: Align radiotap structures in ral(4).
Align radiotap structures in ral(4)
May 25 2016, 6:29 AM

May 19 2016

sgalabov closed D6432: Ralink: Add more SoC compatible strings by committing rS300196: Ralink: Add more SoC compatible strings.
May 19 2016, 6:29 AM
sgalabov committed rS300196: Ralink: Add more SoC compatible strings.
Ralink: Add more SoC compatible strings
May 19 2016, 6:29 AM

May 18 2016

sgalabov retitled D6432: Ralink: Add more SoC compatible strings from to Ralink: Add more SoC compatible strings.
May 18 2016, 6:54 AM

May 17 2016

sgalabov committed rS300014: Add proper PCIe init for MT7628/MT7688 SoCs.
Add proper PCIe init for MT7628/MT7688 SoCs
May 17 2016, 6:45 AM
sgalabov closed D6395: Add proper PCIe init for MT7628/MT7688 SoCs by committing rS300014: Add proper PCIe init for MT7628/MT7688 SoCs.
May 17 2016, 6:45 AM
sgalabov committed rS300013: Import LEDE dts files for Ralink/Mediatek.
Import LEDE dts files for Ralink/Mediatek
May 17 2016, 6:42 AM
sgalabov closed D6394: Import LEDE dts files for Ralink/Mediatek by committing rS300013: Import LEDE dts files for Ralink/Mediatek.
May 17 2016, 6:42 AM
sgalabov committed rS300012: Fix issues with mt762x etherswitch driver.
Fix issues with mt762x etherswitch driver
May 17 2016, 6:30 AM
sgalabov closed D6393: Fix issues with mt762x etherswitch driver by committing rS300012: Fix issues with mt762x etherswitch driver.
May 17 2016, 6:30 AM

May 16 2016

sgalabov updated the diff for D6393: Fix issues with mt762x etherswitch driver.

update diff

May 16 2016, 2:28 PM
sgalabov updated the diff for D6394: Import LEDE dts files for Ralink/Mediatek.

update diffs

May 16 2016, 1:58 PM
sgalabov updated the diff for D6394: Import LEDE dts files for Ralink/Mediatek.

update diffs

May 16 2016, 12:34 PM
sgalabov retitled D6395: Add proper PCIe init for MT7628/MT7688 SoCs from to Add proper PCIe init for MT7628/MT7688 SoCs.
May 16 2016, 12:28 PM
sgalabov retitled D6394: Import LEDE dts files for Ralink/Mediatek from to Import LEDE dts files for Ralink/Mediatek.
May 16 2016, 12:15 PM
sgalabov retitled D6393: Fix issues with mt762x etherswitch driver from to Fix issues with mt762x etherswitch driver.
May 16 2016, 11:58 AM
sgalabov committed rS299910: Introduce basic etherswitch support for Ralink SoCs.
Introduce basic etherswitch support for Ralink SoCs
May 16 2016, 7:01 AM
sgalabov closed D6348: Introduce basic etherswitch support for Ralink SoCs by committing rS299910: Introduce basic etherswitch support for Ralink SoCs.
May 16 2016, 7:01 AM
sgalabov updated D6348: Introduce basic etherswitch support for Ralink SoCs.
May 16 2016, 6:58 AM

May 14 2016

sgalabov updated the diff for D6348: Introduce basic etherswitch support for Ralink SoCs.

Add MT7620/MT7621 first pass driver as well.

May 14 2016, 8:51 AM

May 13 2016

sgalabov updated the diff for D6348: Introduce basic etherswitch support for Ralink SoCs.

add copyright to *.h files.

May 13 2016, 3:46 PM
sgalabov retitled D6348: Introduce basic etherswitch support for Ralink SoCs from to Introduce basic etherswitch support for Ralink SoCs.
May 13 2016, 3:33 PM

May 6 2016

sgalabov committed rS299155: mtk_spi cleanup commented printfs.
mtk_spi cleanup commented printfs
May 6 2016, 5:24 AM
sgalabov closed D6223: mtk_spi cleanup commented printfs by committing rS299155: mtk_spi cleanup commented printfs.
May 6 2016, 5:24 AM · MIPS
sgalabov committed rS299154: mtk_gpio fixes.
mtk_gpio fixes
May 6 2016, 5:22 AM
sgalabov closed D6222: mtk_gpio fixes by committing rS299154: mtk_gpio fixes.
May 6 2016, 5:22 AM · MIPS

May 5 2016

sgalabov updated the diff for D6222: mtk_gpio fixes.

Update diff

May 5 2016, 12:35 PM · MIPS
sgalabov retitled D6223: mtk_spi cleanup commented printfs from to mtk_spi cleanup commented printfs.
May 5 2016, 12:29 PM · MIPS
sgalabov retitled D6222: mtk_gpio fixes from to mtk_gpio fixes.
May 5 2016, 12:28 PM · MIPS

Apr 23 2016

sgalabov committed rS298501: Remove uart_dev_mtk_ns8250.
Remove uart_dev_mtk_ns8250
Apr 23 2016, 4:27 AM
sgalabov closed D6044: Remove uart_dev_mtk_ns8250 by committing rS298501: Remove uart_dev_mtk_ns8250.
Apr 23 2016, 4:27 AM
sgalabov closed D6043: Reduce the FreeBSD specific DTS files for Mediatek/Ralink by committing rS298500: Reduce the FreeBSD specific DTS files for Mediatek/Ralink.
Apr 23 2016, 4:24 AM
sgalabov committed rS298500: Reduce the FreeBSD specific DTS files for Mediatek/Ralink.
Reduce the FreeBSD specific DTS files for Mediatek/Ralink
Apr 23 2016, 4:24 AM
sgalabov committed rS298499: Use cpu_establish_hardintr in mtk_intr_gic.
Use cpu_establish_hardintr in mtk_intr_gic
Apr 23 2016, 4:23 AM
sgalabov closed D6045: Use cpu_establish_hardintr in mtk_intr_gic by committing rS298499: Use cpu_establish_hardintr in mtk_intr_gic.
Apr 23 2016, 4:23 AM
sgalabov closed D6042: Introduce palmbus for Mediatek/Ralink SoCs by committing rS298498: Introduce palmbus for Mediatek/Ralink SoCs.
Apr 23 2016, 4:21 AM
sgalabov committed rS298498: Introduce palmbus for Mediatek/Ralink SoCs.
Introduce palmbus for Mediatek/Ralink SoCs
Apr 23 2016, 4:21 AM
sgalabov closed D6041: Minor pinctrl fixes for Mediatek/Ralink by committing rS298497: Minor pinctrl fixes for Mediatek/Ralink.
Apr 23 2016, 4:19 AM · MIPS
sgalabov committed rS298497: Minor pinctrl fixes for Mediatek/Ralink.
Minor pinctrl fixes for Mediatek/Ralink
Apr 23 2016, 4:19 AM

Apr 21 2016

sgalabov updated the diff for D6043: Reduce the FreeBSD specific DTS files for Mediatek/Ralink.

Update diffs to remove MT7621 GIC stuff as it will be unneeded after D6045.

Apr 21 2016, 9:02 AM
sgalabov retitled D6045: Use cpu_establish_hardintr in mtk_intr_gic from to Use cpu_establish_hardintr in mtk_intr_gic.
Apr 21 2016, 9:01 AM
sgalabov updated the diff for D6043: Reduce the FreeBSD specific DTS files for Mediatek/Ralink.

Update diffs so MT7621 can be built

Apr 21 2016, 8:45 AM
sgalabov retitled D6044: Remove uart_dev_mtk_ns8250 from to Remove uart_dev_mtk_ns8250.
Apr 21 2016, 8:01 AM
sgalabov retitled D6043: Reduce the FreeBSD specific DTS files for Mediatek/Ralink from to Reduce the FreeBSD specific DTS files for Mediatek/Ralink.
Apr 21 2016, 7:53 AM
sgalabov retitled D6042: Introduce palmbus for Mediatek/Ralink SoCs from to Introduce palmbus for Mediatek/Ralink SoCs.
Apr 21 2016, 7:51 AM
sgalabov retitled D6041: Minor pinctrl fixes for Mediatek/Ralink from to Minor pinctrl fixes for Mediatek/Ralink.
Apr 21 2016, 7:48 AM · MIPS
sgalabov committed rS298397: Rework Mediatek/Ralink configuration files.
Rework Mediatek/Ralink configuration files
Apr 21 2016, 7:40 AM
sgalabov closed D5996: Rework Mediatek/Ralink configuration files by committing rS298397: Rework Mediatek/Ralink configuration files.
Apr 21 2016, 7:40 AM · MIPS