Page MenuHomeFreeBSD

Remove uart_dev_mtk_ns8250
ClosedPublic

Authored by sgalabov on Apr 21 2016, 8:01 AM.

Details

Summary

The purpose of this file was to simply detect the UART speed before attaching the actual ns8250 driver so that we don't have to specify the UART speed in DTS files.

However, OpenWRT DTS files specify ns16550a as a compatible string in their DTS files and this makes the original ns8250 driver attach to the device. So we would have to edit the DTS files anyway and since this is only the case for MT7621 and MT7628/MT7688 for now, it's better to just add the clock-frequency property to those (UART is always clocked by the same clock in both these SoCs, so that's fine) instead of having a separate driver and still having to change the DTS files.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sgalabov updated this revision to Diff 15432.Apr 21 2016, 8:01 AM
sgalabov retitled this revision from to Remove uart_dev_mtk_ns8250.
sgalabov updated this object.
sgalabov edited the test plan for this revision. (Show Details)
sgalabov added a reviewer: adrian.
sgalabov set the repository for this revision to rS FreeBSD src repository.
adrian accepted this revision.Apr 22 2016, 7:12 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2016, 7:12 PM
This revision was automatically updated to reflect the committed changes.