cpu model display on dmesg

[yamori813_yahoo.co.jp]

Summary

cpu model display on dmesg

Test Plan

Mediatek and Atheros

[yamori813_yahoo.co.jp]

Broadcom soc support is D12737.

[yamori813_yahoo.co.jp]

This is dmesg on MT7620.

https://dmesgd.nycbug.org/index.cgi?do=view&id=4582

[sgalabov]

Please split Mediatek and Atheros in separate reviews.

In terms of Mediatek, it looks like there's a bit of code duplication. Why don't we just implement the CPU ID detection within mtk_soc_try_early_detect() instead? We already have the correct FDT mappings there, so all we have to do is fill in the cpu_model in there.

[yamori813_yahoo.co.jp]

In D18001#384902, @sgalabov wrote:

Please split Mediatek and Atheros in separate reviews.

In terms of Mediatek, it looks like there's a bit of code duplication. Why don't we just implement the CPU ID detection within mtk_soc_try_early_detect() instead? We already have the correct FDT mappings there, so all we have to do is fill in the cpu_model in there.

OK I will delete Mediatek in this review.

Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

[sgalabov]

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

Can you please share a dmesg output from the case where CPU is printed as RT3050F but CHIPID is RT3350 actually?

[sgalabov]

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
OK I will delete Mediatek in this review.

I will commit the Mediatek changes shortly.
Done in https://svnweb.freebsd.org/base?view=revision&revision=340476

[yamori813_yahoo.co.jp]

In D18001#384941, @sgalabov wrote:

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

Can you please share a dmesg output from the case where CPU is printed as RT3050F but CHIPID is RT3350 actually?

This is dmesg.

http://dmesgd.nycbug.org/index.cgi?do=view&id=4583

And picture.

[yamori813_yahoo.co.jp]

I can't update this review by arc command. I will put new review.