Page MenuHomeFreeBSD

cpu model display on dmesg
AbandonedPublic

Authored by yamori813_yahoo.co.jp on Nov 16 2018, 5:20 AM.

Details

Summary

cpu model display on dmesg

Test Plan

Mediatek and Atheros

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 20829
Build 20216: arc lint + arc unit

Event Timeline

Broadcom soc support is D12737.

mizhka accepted this revision.Nov 16 2018, 6:34 AM
This revision is now accepted and ready to land.Nov 16 2018, 6:34 AM
sgalabov requested changes to this revision.Nov 16 2018, 7:13 AM

Please split Mediatek and Atheros in separate reviews.

In terms of Mediatek, it looks like there's a bit of code duplication. Why don't we just implement the CPU ID detection within mtk_soc_try_early_detect() instead? We already have the correct FDT mappings there, so all we have to do is fill in the cpu_model in there.

This revision now requires changes to proceed.Nov 16 2018, 7:13 AM

Please split Mediatek and Atheros in separate reviews.
In terms of Mediatek, it looks like there's a bit of code duplication. Why don't we just implement the CPU ID detection within mtk_soc_try_early_detect() instead? We already have the correct FDT mappings there, so all we have to do is fill in the cpu_model in there.

OK I will delete Mediatek in this review.

Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

Can you please share a dmesg output from the case where CPU is printed as RT3050F but CHIPID is RT3350 actually?

sgalabov added a comment.EditedNov 16 2018, 11:16 AM

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
OK I will delete Mediatek in this review.

I will commit the Mediatek changes shortly.
Done in https://svnweb.freebsd.org/base?view=revision&revision=340476

! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.

Can you please share a dmesg output from the case where CPU is printed as RT3050F but CHIPID is RT3350 actually?

This is dmesg.

http://dmesgd.nycbug.org/index.cgi?do=view&id=4583

And picture.

I can't update this review by arc command. I will put new review.