User Details
- User Since
- May 21 2014, 7:59 PM (247 w, 3 d)
Sep 23 2018
Sep 22 2018
Aug 29 2018
I would suggest the following changes using getaddrinfo() instead of inet_aton() to avoid address-family dependency. Is cap_getaddrinfo() allowed by capdns?
@@ -147,8 +163,9 @@ const char *typelimit = "ADDR"; int familylimit; const char *ipstr = "127.0.0.1"; -struct in_addr ip; -struct hostent *hp; +char hname[NI_MAXHOST]; +struct addrinfo hints, *res; +int error;
Looks good to me.
Aug 10 2018
Jul 11 2018
This is my submission, so I will leave someone else to do further review of this change. Please do not count my "accept revision" as an immediate approval.
Jul 10 2018
IMHO strvisx(3) in machine.c should have a VIS_OCTAL flag as in my original submission because meta char encoding of strvisx(3), which uses iscntrl(3), does not make sense for most of multibyte encodings. Displaying characters not for the current locale in octal (or hexadecimal) number looks more intuitive to me.
Reverting a change does not need any approval or review. Please document the reason in the commit log instead of just saying "rollback".
Please split this changes into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. A single commit including the both is confusing.
Jul 4 2018
Jul 3 2018
May 15 2018
May 13 2018
Apr 4 2018
Mar 30 2018
Mar 22 2018
Mar 19 2018
Mar 15 2018
Mar 6 2018
Mar 5 2018
Mar 2 2018
Mar 1 2018
Feb 28 2018
Feb 26 2018
Looks good to me. Thank you for taking care of it!
Jan 23 2018
Jan 15 2018
Sep 14 2017
Jul 11 2017
Jun 10 2017
Apr 20 2017
Apr 1 2017
Mar 31 2017
Mar 30 2017
Mar 22 2017
The 64-bit default prefixlen was removed at rev.277241. I did not notice it but I do not think it is a correct change because it has several bad side-effects. I will take a look at route.c by this weekend.
Mar 21 2017
Mar 20 2017
Mar 10 2017
If I understand this correctly, when a 0xffff checksum comes in via wire and the receiving NIC has no RXCSUM offloading, dhclient with this patch does not check the checksum. Is this a correct behavior? I think the conditional (usum != 0xffff) should be added only when the NIC has IFCAP_RXCSUM and it is enabled. Whether this flag is activated or not can be obtained by SIOSGIFCAP ioctl (ifr->ifr_curcap).
Mar 2 2017
Mar 1 2017
Feb 6 2017
Jan 28 2017
Jan 14 2017
Looks good to me, but you need to remove the names in contrib.committers.xml.
Jan 13 2017
Jan 12 2017
Jan 11 2017
Jan 10 2017
I think you need to add CFLAGS+=-DLIBWRAP in Makefile. The others look fine to me.