@melifaro Could you explain the motivation for excluding manually-added prefixes from ICMPV6CTL_ND6_PRLIST? I could not find the reason in the review comments for the original change. As I wrote in the description, this sysctl is to list all prefixes in kernel. If a use case needs to pick up a subset of prefixes, it should be handled after getting the whole list.

Looks good to me.

Update the diff to use dnvlist_get_number().

Removing the NI_NUMERICHOST flag except for multicast addresses looks good to me.

The change basically looks good to me, but I added some comments.

I did not test the functionality yet, but I will give it a try with IPv4 and IPv6 configurations.

In D37930#861889, @jlduran_gmail.com wrote:

Also failing this test:

% ping -c1 192.0.2.1
PING 192.0.2.1 (192.0.2.1): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 0

--- 192.0.2.1 ping statistics ---
1 packets transmitted, 0 packets received, 100.0% packet loss

• sbin/ping: Do not show "Request timeout" when -q is specified
• sbin/ping: Fix the timeout message when -c or -l are specified

In D37493#856006, @t_uemura_macome.co.jp wrote:

• Many changes pointed to by hrs.
• Style(9) changes, some pointed to by takawata.

I put my comments inline. Many of them are style-related, but please fix the memory leak of the sc->res and sc->action queue, at least.

Looks good to me. Thanks for your hard work!

• Please update stf(4) manual page, too.
• I would suggest disabling 6to4 functionality when a braddr is configured. A mixed configuration of 6to4 and 6rd is quite confusing when seeing a result of ifconfig(8) command-line output because the braddr is a parameter for the interface, not a single 6rd domain configuration. I believe no one (except for me) uses the both at the same time.

If you need a second pair of eyes, I say this change looks good.