Page MenuHomeFreeBSD

hrs (Hiroki Sato)
User

Projects

User Details

User Since
May 21 2014, 7:59 PM (238 w, 2 d)

Recent Activity

Sep 23 2018

hrs requested changes to D16957: Use getaddrinfo and getaddrinfo instead of gethostbyname2 in ping(8)..
Sep 23 2018, 1:53 PM

Sep 22 2018

hrs accepted D16931: Update example in man page to use cap_getnameinfo function..
Sep 22 2018, 1:46 PM

Aug 29 2018

hrs requested changes to D16931: Update example in man page to use cap_getnameinfo function..

I would suggest the following changes using getaddrinfo() instead of inet_aton() to avoid address-family dependency. Is cap_getaddrinfo() allowed by capdns?

@@ -147,8 +163,9 @@
 const char *typelimit = "ADDR";
 int familylimit;
 const char *ipstr = "127.0.0.1";
-struct in_addr ip;
-struct hostent *hp;
+char hname[NI_MAXHOST];
+struct addrinfo hints, *res;
+int error;
Aug 29 2018, 4:12 AM
hrs accepted D16933: devel/lazygit: Update to 0.2.1.
Aug 29 2018, 4:04 AM
hrs accepted D16929: Document missing cap_getaddrinfo(3) function..

Looks good to me.

Aug 29 2018, 4:03 AM

Aug 10 2018

hrs accepted D16601: x11-drivers/xorgxrdp: update 0.2.6 -> 0.2.7 and backport some patches.
Aug 10 2018, 6:59 AM
hrs accepted D16621: New port: audio/pulseaudio-module-xrdp: separate PulseAudio modules from net/xrdp.
Aug 10 2018, 6:58 AM

Jul 11 2018

hrs accepted D16204: top(1): support multibyte characters in ARGV array depending on LC_CTYPE, not limited to UTF-8.

This is my submission, so I will leave someone else to do further review of this change. Please do not count my "accept revision" as an immediate approval.

Jul 11 2018, 11:14 AM
hrs added inline comments to D16202: libradius(3) IPv6 support.
Jul 11 2018, 11:01 AM
This is a test notification, sent at Wed, Jul 11, 5:07 PM.
Jul 11 2018, 8:07 AM
This is a test notification, sent at Wed, Jul 11, 5:07 PM.
Jul 11 2018, 8:07 AM
This is a test notification, sent at Wed, Jul 11, 5:07 PM.
Jul 11 2018, 8:07 AM
This is a test notification, sent at Wed, Jul 11, 5:07 PM.
Jul 11 2018, 8:07 AM
This is a test notification, sent at Wed, Jul 11, 5:07 PM.
Jul 11 2018, 8:07 AM

Jul 10 2018

hrs requested changes to D16204: top(1): support multibyte characters in ARGV array depending on LC_CTYPE, not limited to UTF-8.

IMHO strvisx(3) in machine.c should have a VIS_OCTAL flag as in my original submission because meta char encoding of strvisx(3), which uses iscntrl(3), does not make sense for most of multibyte encodings. Displaying characters not for the current locale in octal (or hexadecimal) number looks more intuitive to me.

Jul 10 2018, 8:54 AM
hrs accepted D16203: top(1): rollback r335836.

Reverting a change does not need any approval or review. Please document the reason in the commit log instead of just saying "rollback".

Jul 10 2018, 3:32 AM
hrs requested changes to D16203: top(1): rollback r335836.

Please split this changes into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. A single commit including the both is confusing.

Jul 10 2018, 1:16 AM

Jul 4 2018

hrs committed rS335932: - Fix a double unlock in inp_block_unblock_source() and.
- Fix a double unlock in inp_block_unblock_source() and
Jul 4 2018, 6:47 AM

Jul 3 2018

hrs accepted D16109: New port: mail/roundcube-identity_smtp.
Jul 3 2018, 8:15 AM

May 15 2018

hrs accepted D15441: net-im/rubygem-earthquake: Remove port.
May 15 2018, 6:24 AM
hrs added inline comments to D15441: net-im/rubygem-earthquake: Remove port.
May 15 2018, 3:01 AM

May 13 2018

hrs committed rP469771: Update to 2.1.0.0..
Update to 2.1.0.0.
May 13 2018, 4:19 AM

Apr 4 2018

hrs committed rS331980: Remove myself because import of Heimdal 7.5.0 completed..
Remove myself because import of Heimdal 7.5.0 completed.
Apr 4 2018, 4:26 AM
hrs committed rS331979: Tag Heimdal 7.5.0..
Tag Heimdal 7.5.0.
Apr 4 2018, 4:25 AM
hrs committed rS331978: Import Heimdal 7.5.0..
Import Heimdal 7.5.0.
Apr 4 2018, 4:22 AM
hrs committed rS331977: Add myself temporarily to import Heimdal 7.5.0..
Add myself temporarily to import Heimdal 7.5.0.
Apr 4 2018, 4:20 AM

Mar 30 2018

hrs accepted D14904: Remove a comment that suggests checking a non-pointer is non-NULL..
Mar 30 2018, 9:20 AM

Mar 22 2018

hrs accepted D10943: Static analysis: Improve DAD deletion code.
Mar 22 2018, 3:35 PM

Mar 19 2018

hrs committed rS331200: Please welcome Vincenzo Maffione (vmaffione) as a new src.
Please welcome Vincenzo Maffione (vmaffione) as a new src
Mar 19 2018, 8:28 AM
hrs committed rP464988: Please welcome Koichiro IWAO (meta) as a new ports committer..
Please welcome Koichiro IWAO (meta) as a new ports committer.
Mar 19 2018, 6:47 AM

Mar 15 2018

hrs closed D14585: Make getnameinfo(3) salen requirement less strict.
Mar 15 2018, 1:47 PM
hrs committed rS331000: Make getnameinfo(3) salen requirement less strict and.
Make getnameinfo(3) salen requirement less strict and
Mar 15 2018, 1:47 PM

Mar 6 2018

hrs added inline comments to D14585: Make getnameinfo(3) salen requirement less strict.
Mar 6 2018, 7:29 AM
hrs committed rP463684: Fix build on 10.X. mail/mu4e requires no C++ compiler..
Fix build on 10.X. mail/mu4e requires no C++ compiler.
Mar 6 2018, 1:45 AM

Mar 5 2018

hrs created D14585: Make getnameinfo(3) salen requirement less strict.
Mar 5 2018, 3:20 PM
hrs committed rS330442: - Remove extra NULL check before free()..
- Remove extra NULL check before free().
Mar 5 2018, 3:38 AM
hrs committed rS330441: Partially back out changes in r327464. stdlib.h is used when.
Partially back out changes in r327464. stdlib.h is used when
Mar 5 2018, 3:34 AM
hrs committed rP463617: Fix build on 10.X. mail/mu requires C++14 compiler..
Fix build on 10.X. mail/mu requires C++14 compiler.
Mar 5 2018, 3:33 AM

Mar 2 2018

hrs committed rP463371: Fix build..
Fix build.
Mar 2 2018, 5:27 AM

Mar 1 2018

hrs committed rP463345: Update to 2.1.4..
Update to 2.1.4.
Mar 1 2018, 5:19 PM

Feb 28 2018

hrs committed rP463190: Take maintainership..
Take maintainership.
Feb 28 2018, 8:48 AM
hrs committed rP463189: Update to 0.8.3..
Update to 0.8.3.
Feb 28 2018, 8:46 AM
hrs committed rP463188: Update to v15.1..
Update to v15.1.
Feb 28 2018, 8:43 AM
hrs committed rP463180: Update to 2.1.4..
Update to 2.1.4.
Feb 28 2018, 6:27 AM
hrs committed rP463179: Update to 1.0..
Update to 1.0.
Feb 28 2018, 6:10 AM
hrs committed rP463178: Update to 0.9.18..
Update to 0.9.18.
Feb 28 2018, 5:57 AM
hrs committed rP463177: Update libwraster to 0.95.8 and make x11-wm/windowmaker.
Update libwraster to 0.95.8 and make x11-wm/windowmaker
Feb 28 2018, 4:58 AM
hrs committed rP463175: Update to 1.3.0..
Update to 1.3.0.
Feb 28 2018, 4:28 AM

Feb 26 2018

hrs accepted D14510: Fix two memory leaks in syslogd.

Looks good to me. Thank you for taking care of it!

Feb 26 2018, 1:20 AM

Jan 23 2018

hrs committed rP459739: Update to 7.5.0:.
Update to 7.5.0:
Jan 23 2018, 10:35 AM

Jan 15 2018

hrs committed rD51386: Disable generating status.png temporarily..
Disable generating status.png temporarily.
Jan 15 2018, 3:45 AM

Sep 14 2017

hrs accepted D12354: Silently handle freeaddrinfo(NULL) for compatibility with code which works on other OSes..
Sep 14 2017, 6:00 PM

Jul 11 2017

hrs committed rP445539: Update to 7.4.0. This release fixes a critical vulnerability named.
Update to 7.4.0. This release fixes a critical vulnerability named
Jul 11 2017, 5:57 PM

Jun 10 2017

hrs committed rP443115: Update to 7.3.0..
Update to 7.3.0.
Jun 10 2017, 7:33 PM

Apr 20 2017

hrs committed rP438928: Add --without-x unconditionally to CONFIGURE_ARGS because a build.
Add --without-x unconditionally to CONFIGURE_ARGS because a build
Apr 20 2017, 7:38 AM

Apr 1 2017

hrs committed rP437402: Update to a snapshot as of 2017/04/01..
Update to a snapshot as of 2017/04/01.
Apr 1 2017, 9:13 AM
hrs committed rP437401: Add textproc/sdif, a post-processor of diff(1) output for pretty-printing..
Add textproc/sdif, a post-processor of diff(1) output for pretty-printing.
Apr 1 2017, 9:10 AM
hrs committed rP437399: Update to a snapshot as of 2017/04/01..
Update to a snapshot as of 2017/04/01.
Apr 1 2017, 8:55 AM

Mar 31 2017

hrs committed rP437343: Add textproc/greple and devel/p5-Getopt-EX, which greple depends on..
Add textproc/greple and devel/p5-Getopt-EX, which greple depends on.
Mar 31 2017, 9:13 AM

Mar 30 2017

hrs committed rP437337: - Fix bugs which could cause SIGSEGV..
- Fix bugs which could cause SIGSEGV.
Mar 30 2017, 11:54 PM

Mar 22 2017

hrs added a comment to D10087: route(8): clarify -prefixlen description.

The 64-bit default prefixlen was removed at rev.277241. I did not notice it but I do not think it is a correct change because it has several bad side-effects. I will take a look at route.c by this weekend.

Mar 22 2017, 5:45 AM

Mar 21 2017

hrs committed rP436566: Update to 1.1.2..
Update to 1.1.2.
Mar 21 2017, 7:22 AM

Mar 20 2017

hrs committed rS315644: Simplify a pipe for signal handling..
Simplify a pipe for signal handling.
Mar 20 2017, 5:57 PM
hrs closed D10064: syslogd: fix -b use with IPv6 literal addresses after ^/head@r309933 by committing rS315643: Fix a regression which prevented an IPv6 address in a -b option from.
Mar 20 2017, 5:46 PM
hrs committed rS315643: Fix a regression which prevented an IPv6 address in a -b option from.
Fix a regression which prevented an IPv6 address in a -b option from
Mar 20 2017, 5:46 PM

Mar 10 2017

hrs added a comment to D9832: dhclient: skip UDP checksum validation if Rx checksum offload is in effect.

If I understand this correctly, when a 0xffff checksum comes in via wire and the receiving NIC has no RXCSUM offloading, dhclient with this patch does not check the checksum. Is this a correct behavior? I think the conditional (usum != 0xffff) should be added only when the NIC has IFCAP_RXCSUM and it is enabled. Whether this flag is activated or not can be obtained by SIOSGIFCAP ioctl (ifr->ifr_curcap).

Mar 10 2017, 4:08 AM

Mar 2 2017

hrs accepted D9855: Wordsmith syslogd(8).

Looks good to me.

Mar 2 2017, 4:51 AM

Mar 1 2017

hrs committed rP435121: Update to 20080615.2. Changes include:.
Update to 20080615.2. Changes include:
Mar 1 2017, 6:12 AM

Feb 6 2017

hrs committed rD49939: Fix build..
Fix build.
Feb 6 2017, 12:16 PM

Jan 28 2017

hrs committed rS312921: Fix a bug which caused not to create AF_LOCAL sockets when family.
Fix a bug which caused not to create AF_LOCAL sockets when family
Jan 28 2017, 1:09 PM

Jan 14 2017

hrs committed rP431491: - Strip installed binaries..
- Strip installed binaries.
Jan 14 2017, 7:36 PM
hrs committed rP431490: - Add LICENSE..
- Add LICENSE.
Jan 14 2017, 7:30 PM
hrs accepted D9182: Update Development Team Alumni.

Looks good to me, but you need to remove the names in contrib.committers.xml.

Jan 14 2017, 6:31 PM
hrs committed rP431473: Update to 1.7.1..
Update to 1.7.1.
Jan 14 2017, 3:56 PM
hrs committed rP431469: - Remove extra PATCH_SITES..
- Remove extra PATCH_SITES.
Jan 14 2017, 3:27 PM

Jan 13 2017

hrs committed rS312018: Purge varargs.h in favor of stdarg.h..
Purge varargs.h in favor of stdarg.h.
Jan 13 2017, 8:01 AM
hrs committed rS312013: - Add static for functions and variables with internal linkage..
- Add static for functions and variables with internal linkage.
Jan 13 2017, 6:23 AM

Jan 12 2017

hrs committed rS311994: - Fix dereference of NULL pointer which could cause a crash [1].
- Fix dereference of NULL pointer which could cause a crash [1]
Jan 12 2017, 6:45 PM

Jan 11 2017

hrs committed rP431166: Update to 11.90..
Update to 11.90.
Jan 11 2017, 9:13 AM
hrs committed rP431160: Fix build when !BDB and db5 is installed at the same time..
Fix build when !BDB and db5 is installed at the same time.
Jan 11 2017, 7:50 AM
hrs committed rS311918: Add more #ifdef INET and INET6..
Add more #ifdef INET and INET6.
Jan 11 2017, 7:22 AM

Jan 10 2017

hrs added a comment to D9056: Conditionalize libwrap support into inetd based on MK_TCP_WRAPPERS.

I think you need to add CFLAGS+=-DLIBWRAP in Makefile. The others look fine to me.

Jan 10 2017, 8:49 PM

Jan 6 2017

hrs committed rP430705: - Remove stale REINPLACE_CMD lines..
- Remove stale REINPLACE_CMD lines.
Jan 6 2017, 1:12 PM

Jan 5 2017

hrs committed rS311354: Fix build when WITHOUT_INET6 is defined..
Fix build when WITHOUT_INET6 is defined.
Jan 5 2017, 3:25 AM

Jan 4 2017

hrs committed rP430529: - Fix krb5-config --libs to provide a list of libraries including.
- Fix krb5-config --libs to provide a list of libraries including
Jan 4 2017, 2:09 AM

Jan 3 2017

hrs committed rP430517: - Enable dbopen() in DB 1.85 even if !BDB because libhdb with.
- Enable dbopen() in DB 1.85 even if !BDB because libhdb with
Jan 3 2017, 8:00 PM
hrs committed rP430468: Update to 7.1.0. Changes include:.
Update to 7.1.0. Changes include:
Jan 3 2017, 1:52 PM

Jan 2 2017

hrs committed rP430412: Add LICENSE_FILE..
Add LICENSE_FILE.
Jan 2 2017, 9:11 PM
hrs committed rP430410: - Add LICENSE..
- Add LICENSE.
Jan 2 2017, 9:07 PM
hrs committed rP430409: - Add LICENSE..
- Add LICENSE.
Jan 2 2017, 9:00 PM
hrs committed rP430407: Add LICENSE..
Add LICENSE.
Jan 2 2017, 8:52 PM
hrs committed rP430358: Update to 3.9.8..
Update to 3.9.8.
Jan 2 2017, 2:53 PM
hrs committed rP430352: Fix build of japanese/mozc-tool..
Fix build of japanese/mozc-tool.
Jan 2 2017, 12:10 PM

Jan 1 2017

hrs committed rP430281: Update to 2.20.2677.102.02..
Update to 2.20.2677.102.02.
Jan 1 2017, 7:54 PM
hrs committed rP430263: Fix build..
Fix build.
Jan 1 2017, 5:20 PM
hrs committed rP430244: Add a patch to enable verbose build logging..
Add a patch to enable verbose build logging.
Jan 1 2017, 6:49 AM
hrs committed rP430243: Update to 2.20.2677.102..
Update to 2.20.2677.102.
Jan 1 2017, 6:47 AM
hrs committed rP430242: Use USES=python instead of LIB_DEPEDNS + python:build..
Use USES=python instead of LIB_DEPEDNS + python:build.
Jan 1 2017, 5:12 AM
hrs committed rP430239: Update to 0.24.9..
Update to 0.24.9.
Jan 1 2017, 4:28 AM
hrs committed rP430236: - Add LICENSE..
- Add LICENSE.
Jan 1 2017, 3:52 AM