Page MenuHomeFreeBSD

hrs (Hiroki Sato)
User

Projects

User Details

User Since
May 21 2014, 7:59 PM (295 w, 2 d)

Recent Activity

Sun, Jan 12

hrs committed rP522790: Update to 12.2..
Update to 12.2.
Sun, Jan 12, 3:01 PM

Thu, Jan 9

hrs committed rP522544: - Use FONTPATHSPEC..
- Use FONTPATHSPEC.
Thu, Jan 9, 10:42 PM

Mon, Dec 30

hrs committed rP521518: Fixup patches by makepatch. No functional change..
Fixup patches by makepatch. No functional change.
Mon, Dec 30, 4:58 PM
hrs committed rP521478: - Use ${RLN} to create a symlink of a relative path..
- Use ${RLN} to create a symlink of a relative path.
Mon, Dec 30, 10:10 AM
hrs committed rP521464: - Resurrect japanese/cannadic..
- Resurrect japanese/cannadic.
Mon, Dec 30, 5:31 AM
hrs committed rP521463: - Use FONTPATHSPEC..
- Use FONTPATHSPEC.
Mon, Dec 30, 5:04 AM
hrs committed rP521462: - Update to 0.0.670..
- Update to 0.0.670.
Mon, Dec 30, 5:03 AM
hrs committed rP521461: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 5:02 AM
hrs committed rP521460: Update dependencies..
Update dependencies.
Mon, Dec 30, 5:02 AM
hrs committed rP521459: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 5:01 AM
hrs committed rP521458: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:59 AM
hrs committed rP521457: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:58 AM
hrs committed rP521455: - Update to 0.6.3...
- Update to 0.6.3..
Mon, Dec 30, 4:58 AM
hrs committed rP521454: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:54 AM
hrs committed rP521453: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:53 AM
hrs committed rP521452: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:52 AM
hrs committed rP521451: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:51 AM
hrs committed rP521450: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:49 AM
hrs committed rP521449: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:48 AM
hrs committed rP521448: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:47 AM
hrs committed rP521447: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:46 AM
hrs committed rP521446: Use FONTPATHSPEC..
Use FONTPATHSPEC.
Mon, Dec 30, 4:44 AM
hrs committed rP521445: - Add LICENSE..
- Add LICENSE.
Mon, Dec 30, 4:43 AM
hrs committed rP521444: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:42 AM
hrs committed rP521443: Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:41 AM
hrs committed rP521442: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:39 AM
hrs committed rP521441: - Use FONTPATHSPEC..
- Use FONTPATHSPEC.
Mon, Dec 30, 4:38 AM
hrs committed rP521440: - Update to 00601..
- Update to 00601.
Mon, Dec 30, 4:37 AM
hrs committed rP521439: - Update to 00401..
- Update to 00401.
Mon, Dec 30, 4:35 AM
hrs committed rP521438: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:34 AM
hrs committed rP521437: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:32 AM
hrs committed rP521436: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:28 AM
hrs committed rP521435: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:22 AM
hrs committed rP521434: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:20 AM
hrs committed rP521433: - Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually..
- Use FONTPATHSPEC and nuke pkg-message for adding FontPath manually.
Mon, Dec 30, 4:19 AM
hrs committed rP521430: Add etc/X11/fontpath.d as a catalogue fontpath by default..
Add etc/X11/fontpath.d as a catalogue fontpath by default.
Mon, Dec 30, 12:11 AM

Sun, Dec 29

hrs committed rP521362: - Update to 1.5.1..
- Update to 1.5.1.
Sun, Dec 29, 3:26 PM

Thu, Dec 26

hrs committed rP520920: Update to 1.82..
Update to 1.82.
Thu, Dec 26, 2:55 PM

Wed, Dec 25

hrs committed rP520886: Update to 1.2..
Update to 1.2.
Wed, Dec 25, 10:00 PM
hrs committed rP520885: - Update to 1.81..
- Update to 1.81.
Wed, Dec 25, 9:17 PM

Tue, Dec 24

hrs committed rP520789: Update MASTER_SITES and update to 4.02..
Update MASTER_SITES and update to 4.02.
Tue, Dec 24, 9:02 AM

Oct 31 2019

hrs accepted D22146: add valectl to the system commands.

Looks good to me.

Oct 31 2019, 4:59 AM

Oct 29 2019

hrs added a comment to D22146: add valectl to the system commands.

Could you please fix the following nits? Sorry for sending comments so many times separately.

Oct 29 2019, 3:33 AM

Oct 28 2019

hrs requested changes to D22146: add valectl to the system commands.
Oct 28 2019, 6:32 PM

Oct 16 2019

hrs updated the diff for D22003: Add lle_event handler to ARP.

Update patch:

Oct 16 2019, 7:11 AM
hrs added a comment to D21589: arp.c: use getaddrinfo(3) instead of gethostbyname(3).

@hrs do you realize that the submitter is not a committer? Can you commit this change for him?

Oct 16 2019, 5:55 AM

Oct 13 2019

hrs added inline comments to D22003: Add lle_event handler to ARP.
Oct 13 2019, 6:22 PM

Oct 12 2019

hrs created D22003: Add lle_event handler to ARP.
Oct 12 2019, 8:03 PM
hrs requested changes to D21826: Proceeding to make rwhod ipv6 clean..

Your change looks to me trying to add IPv6 support by a copy-and-paste of the logic used in IPv4. I do not think it is a good idea in general or even for rwhod. At the time when rwhod utility was written there was an IPv4-specific API only, but nowadays we have a lot of address family independent APIs. For multicast membership management, an API defined in RFC 3678 is the standard way to support IPv4 and IPv6 in a AF-agnostic manner. Therefore, multicast support of rwhod needs a major rewrite by using this new API to support both IPv4 and non-IPv4 protocols at least. While we welcome converting an IPv4-only program to support IPv6 in an AF-independent API such as getaddrinfo(3), we do not want to add another IPv6-only code path to every single IPv4-only utility unless it is the only way to do so.

Oct 12 2019, 2:14 AM

Sep 22 2019

hrs added a comment to D21752: Add STANDARDS section to the gre(4) manual page.
  • We do not have MPLS as described in RFC 4023 or NVGRE in RFC 7637 as a kernel feature.
  • RFC 8086 (GRE-in-UDP) is supported.
  • I am not sure why WCCP I-Ds should be listed here. They use GRE but it is usually implemented by a userland daemon, not by kernel.
Sep 22 2019, 2:34 PM

Sep 21 2019

hrs committed rS352576: MFC r352567:.
MFC r352567:
Sep 21 2019, 2:06 PM
hrs committed rS352575: MFC r352567:.
MFC r352567:
Sep 21 2019, 2:03 PM
hrs accepted D21589: arp.c: use getaddrinfo(3) instead of gethostbyname(3).

Looks good to me.

Sep 21 2019, 1:54 PM
hrs committed rS352574: - Revert WARNS to 2 because of mismatch between (xdrproc_t) and xdr_void()..
- Revert WARNS to 2 because of mismatch between (xdrproc_t) and xdr_void().
Sep 21 2019, 1:34 PM
hrs committed rS352572: Fix warnings and set WARNS=6..
Fix warnings and set WARNS=6.
Sep 21 2019, 12:34 PM
hrs committed rS352570: Fix build errors of test.c, which had been broken for a long time..
Fix build errors of test.c, which had been broken for a long time.
Sep 21 2019, 1:30 AM
hrs committed rS352568: Impove wording and move descriptions about.
Impove wording and move descriptions about
Sep 21 2019, 12:44 AM
hrs committed rS352567: Add a workaround for servers which respond RPC_PROGNOTREGISTERED.
Add a workaround for servers which respond RPC_PROGNOTREGISTERED
Sep 21 2019, 12:18 AM

Sep 15 2019

hrs added inline comments to D21589: arp.c: use getaddrinfo(3) instead of gethostbyname(3).
Sep 15 2019, 12:55 AM

Sep 12 2019

hrs requested changes to D21589: arp.c: use getaddrinfo(3) instead of gethostbyname(3).
Sep 12 2019, 3:48 AM

Aug 29 2019

hrs committed rD53338: Update my PGP key..
Update my PGP key.
Aug 29 2019, 7:06 PM

Aug 27 2019

hrs added inline comments to D21443: S"timefmt" flag to newsyslog(8).
Aug 27 2019, 11:32 PM
D21443: S"timefmt" flag to newsyslog(8) now requires review to proceed.

Update based on jilles's comments:

Aug 27 2019, 11:24 PM
hrs committed rS351554: MFV r351553:.
MFV r351553:
Aug 27 2019, 8:12 PM
hrs committed rS351553: Fix a problem which prevented -OServerSSLOptions or -OClientSSLOptions.
Fix a problem which prevented -OServerSSLOptions or -OClientSSLOptions
Aug 27 2019, 7:37 PM
hrs added a comment to D21443: S"timefmt" flag to newsyslog(8).

Updated to include bcr's suggestions and fix a missing length check.

Aug 27 2019, 7:19 PM
hrs created D21443: S"timefmt" flag to newsyslog(8).
Aug 27 2019, 6:34 PM

Aug 25 2019

hrs committed rS351484: Fix build (r351481)..
Fix build (r351481).
Aug 25 2019, 7:27 PM
hrs added a comment to D21182: Add MODULE_PNP_INFO() to vmci.
In D21182#461094, @mp wrote:

Thanks! Useful and looks good to me.

Aug 25 2019, 6:56 PM
hrs committed rS351483: Document soft updates journaling and GEOM-based UFS journaling..
Document soft updates journaling and GEOM-based UFS journaling.
Aug 25 2019, 6:52 PM
hrs committed rS351482: Add MODULE_PNP_INFO() to vmci(4). This allows devd(8) to load the.
Add MODULE_PNP_INFO() to vmci(4). This allows devd(8) to load the
Aug 25 2019, 6:46 PM
hrs closed D21182: Add MODULE_PNP_INFO() to vmci.
Aug 25 2019, 6:46 PM

Aug 10 2019

hrs added a reviewer for D21182: Add MODULE_PNP_INFO() to vmci: vdasahar_gmail.com.
Aug 10 2019, 6:16 AM

Aug 7 2019

hrs created D21182: Add MODULE_PNP_INFO() to vmci.
Aug 7 2019, 8:10 PM

Jul 10 2019

hrs committed rS349875: Add support for RTL8156, 2.5GbE USB network controller, to if_cdce(4)..
Add support for RTL8156, 2.5GbE USB network controller, to if_cdce(4).
Jul 10 2019, 5:46 AM

May 19 2019

hrs added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 9:27 PM
hrs added a comment to D19902: bsearc.3: Add EXAMPLES section.

Perhaps it is cleaner to pass the int age to be searched for by reference. However, the asymmetry in the compare function is intentional as this allows finding an object with more data given the key, while having only one storage array.

May 19 2019, 9:26 PM
hrs added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 8:37 PM
hrs added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 8:36 PM
hrs added a comment to D19902: bsearc.3: Add EXAMPLES section.

As already pointed out on the mailing list, this example has a lot of problems which are not only style bugs. Ones I think as critical except for the style issues are the following:

  • The function to compare two elements should accept the same type, not using an "age" field value by using a pointer type. It is a function to compare, not look up a matched element in the definition of bsearch(3). Passing a raw value as (void *) type is not impossible, but it is not suitable for a "textbook" example.
  • Using assert() looks strange to me. Instead, this program should accept a value of "key" from the command line argument and show the results of bsearch(3) depending on the specified key, and this manual page should describe what results are expected.
May 19 2019, 7:55 PM

May 16 2019

hrs committed rS347887: Fix hostname to be returned in an ICMPv6 NI Reply message defined.
Fix hostname to be returned in an ICMPv6 NI Reply message defined
May 16 2019, 7:10 PM
hrs closed D20207: Fix hostname to be returned in an ICMPv6 NI Reply message.
May 16 2019, 7:09 PM

May 9 2019

hrs created D20207: Fix hostname to be returned in an ICMPv6 NI Reply message.
May 9 2019, 12:19 AM

Mar 19 2019

hrs committed rP496255: Resurrect cad/klayout and update to 0.25.8..
Resurrect cad/klayout and update to 0.25.8.
Mar 19 2019, 10:44 AM

Mar 18 2019

hrs committed rP496141: Add a workaround for shlib name depending on OpenSSL's version..
Add a workaround for shlib name depending on OpenSSL's version.
Mar 18 2019, 12:42 PM

Mar 17 2019

hrs committed rP496079: Add japanese/cp5022x-el, an elisp to add CP5022x coding-system support.
Add japanese/cp5022x-el, an elisp to add CP5022x coding-system support
Mar 17 2019, 5:48 PM
hrs committed rP496047: Remove a redundant line..
Remove a redundant line.
Mar 17 2019, 11:35 AM
hrs committed rP496045: Fix build with OpenSSL 1.1.x..
Fix build with OpenSSL 1.1.x.
Mar 17 2019, 11:28 AM
hrs committed rP496010: Add a new OpenSSL 1.1.x patchset and revert broken one imported.
Add a new OpenSSL 1.1.x patchset and revert broken one imported
Mar 17 2019, 12:54 AM

Mar 15 2019

hrs committed rP495832: Update to 4.2.0..
Update to 4.2.0.
Mar 15 2019, 10:04 PM
hrs committed rP495790: Add cad/py-phidl, a GDS-based CAD tool for photonic and superconducting.
Add cad/py-phidl, a GDS-based CAD tool for photonic and superconducting
Mar 15 2019, 1:58 PM
hrs committed rP495787: Update to 1.3.2..
Update to 1.3.2.
Mar 15 2019, 1:25 PM

Mar 12 2019

hrs added a comment to D19422: if_vxlan(4) Allow set MTU more than 1500 bytes..

Adding jumbo frame support looks good to me. However, is it better to support this in ether_ioctl() instead of a driver-specific ioctl handler? Check of (ifr->ifr_mtu > ETHERMTU) in ether_ioctl() can be changed to check if the interface has IFCAP_JUMBO_MTU or not.

Mar 12 2019, 7:33 AM
hrs abandoned D1858: Improvement for MAC address uniqueness of if_epair(4).

Fixed in a different way in r334094.

Mar 12 2019, 5:50 AM
hrs accepted D19488: Enhance IPv6 autoconf startup scripts.
Mar 12 2019, 5:47 AM

Mar 7 2019

hrs added a comment to D19488: Enhance IPv6 autoconf startup scripts.
In D19488#417207, @bz wrote:
In D19488#417164, @hrs wrote:

For (2), I think the old version unconditionally runs rtsol (w/o "d") when rtsold_enable="NO", and does not when rtsold_enable="YES" because rtsold (w/ "d") will be invoked later by rc.d/rtsold should handle it. In short, the condition which determines if rtsol is invoked or not depends only on "accept_rtadv" flag. Isn't it enough?

Hmm, are you sure? Looking at the logic I changed above we invoked rtsol only if rtsold was disabled and otherwise rtsold was started later and done it (so far we agree); I think that again meant that dhcp was run before the first RS/RA cycle happened hence me needing a way to trigger that early. Hence adding the extra interface flag. I think my description above was a cache miss and is wrong (I did this change months ago). I am almost tempted to remove the extra logic and run rtsol (no d) unconditionally if "accept_rtadv" and then start rtsold later or not depending on whether the user wants long-term stability and DNS options from RAs or not.
What do you think?

Mar 7 2019, 6:44 PM
hrs added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.
In D19487#417206, @bz wrote:
In D19487#417158, @hrs wrote:

Looks good to me. We might want to put an INFO log line when ND6_IFF_IPV6_ONLY flag is changed by receiving RA or link-down event so that the sysadmin can know what is going on.

Ifconfig will show the flag in the ndoptions line, in my case currently the manual one.

nd6 options=423<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL,IPV6_ONLY_MANUAL>

Logging each time we receive an RA is not a good idea as the IPv4 exemption logic logging has shown me (need to fix that). Logging on every "state toggle" would be good, I agree. I'll prepare that.

Mar 7 2019, 6:23 PM
hrs committed rP494875: Update to 1.1. Changes include:.
Update to 1.1. Changes include:
Mar 7 2019, 4:06 AM
hrs added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.

One more comment: immediate change of the flag just after a link-down event may be problematic when the link is unstable. In such a situation, IPv4 packets can be allowed after a link-up and before another RA arrives even if the all of advertising routers keep sending ipv6only flag. We can assume that the interface should be configured to accept RA when the machine moves from a network to another, so sending a RS after a link-up then clearing ND6_IFF_IPV6_ONLY only when no RA arrives in a few seconds looks a more reasonable behavior. If at least one RA arrives after the RS, the normal handling of ipv6only flag works.

Mar 7 2019, 1:25 AM
hrs added a comment to D19488: Enhance IPv6 autoconf startup scripts.

(1) looks good to me. For (2), I think the old version unconditionally runs rtsol (w/o "d") when rtsold_enable="NO", and does not when rtsold_enable="YES" because rtsold (w/ "d") will be invoked later by rc.d/rtsold should handle it. In short, the condition which determines if rtsol is invoked or not depends only on "accept_rtadv" flag. Isn't it enough?

Mar 7 2019, 1:08 AM