Page MenuHomeFreeBSD

hrs (Hiroki Sato)
User

Projects

User Details

User Since
May 21 2014, 7:59 PM (273 w, 4 d)

Recent Activity

Sat, Aug 10

hrs added a reviewer for D21182: Add MODULE_PNP_INFO() to vmci: vdasahar_gmail.com.
Sat, Aug 10, 6:16 AM

Wed, Aug 7

hrs created D21182: Add MODULE_PNP_INFO() to vmci.
Wed, Aug 7, 8:10 PM

Jul 10 2019

hrs committed rS349875: Add support for RTL8156, 2.5GbE USB network controller, to if_cdce(4)..
Add support for RTL8156, 2.5GbE USB network controller, to if_cdce(4).
Jul 10 2019, 5:46 AM

May 19 2019

hrs added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 9:27 PM
hrs added a comment to D19902: bsearc.3: Add EXAMPLES section.

Perhaps it is cleaner to pass the int age to be searched for by reference. However, the asymmetry in the compare function is intentional as this allows finding an object with more data given the key, while having only one storage array.

May 19 2019, 9:26 PM
hrs added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 8:37 PM
hrs added inline comments to D19902: bsearc.3: Add EXAMPLES section.
May 19 2019, 8:36 PM
hrs added a comment to D19902: bsearc.3: Add EXAMPLES section.

As already pointed out on the mailing list, this example has a lot of problems which are not only style bugs. Ones I think as critical except for the style issues are the following:

  • The function to compare two elements should accept the same type, not using an "age" field value by using a pointer type. It is a function to compare, not look up a matched element in the definition of bsearch(3). Passing a raw value as (void *) type is not impossible, but it is not suitable for a "textbook" example.
  • Using assert() looks strange to me. Instead, this program should accept a value of "key" from the command line argument and show the results of bsearch(3) depending on the specified key, and this manual page should describe what results are expected.
May 19 2019, 7:55 PM

May 16 2019

hrs committed rS347887: Fix hostname to be returned in an ICMPv6 NI Reply message defined.
Fix hostname to be returned in an ICMPv6 NI Reply message defined
May 16 2019, 7:10 PM
hrs closed D20207: Fix hostname to be returned in an ICMPv6 NI Reply message.
May 16 2019, 7:09 PM

May 9 2019

hrs created D20207: Fix hostname to be returned in an ICMPv6 NI Reply message.
May 9 2019, 12:19 AM

Mar 19 2019

hrs committed rP496255: Resurrect cad/klayout and update to 0.25.8..
Resurrect cad/klayout and update to 0.25.8.
Mar 19 2019, 10:44 AM

Mar 18 2019

hrs committed rP496141: Add a workaround for shlib name depending on OpenSSL's version..
Add a workaround for shlib name depending on OpenSSL's version.
Mar 18 2019, 12:42 PM

Mar 17 2019

hrs committed rP496079: Add japanese/cp5022x-el, an elisp to add CP5022x coding-system support.
Add japanese/cp5022x-el, an elisp to add CP5022x coding-system support
Mar 17 2019, 5:48 PM
hrs committed rP496047: Remove a redundant line..
Remove a redundant line.
Mar 17 2019, 11:35 AM
hrs committed rP496045: Fix build with OpenSSL 1.1.x..
Fix build with OpenSSL 1.1.x.
Mar 17 2019, 11:28 AM
hrs committed rP496010: Add a new OpenSSL 1.1.x patchset and revert broken one imported.
Add a new OpenSSL 1.1.x patchset and revert broken one imported
Mar 17 2019, 12:54 AM

Mar 15 2019

hrs committed rP495832: Update to 4.2.0..
Update to 4.2.0.
Mar 15 2019, 10:04 PM
hrs committed rP495790: Add cad/py-phidl, a GDS-based CAD tool for photonic and superconducting.
Add cad/py-phidl, a GDS-based CAD tool for photonic and superconducting
Mar 15 2019, 1:58 PM
hrs committed rP495787: Update to 1.3.2..
Update to 1.3.2.
Mar 15 2019, 1:25 PM

Mar 12 2019

hrs added a comment to D19422: if_vxlan(4) Allow set MTU more than 1500 bytes..

Adding jumbo frame support looks good to me. However, is it better to support this in ether_ioctl() instead of a driver-specific ioctl handler? Check of (ifr->ifr_mtu > ETHERMTU) in ether_ioctl() can be changed to check if the interface has IFCAP_JUMBO_MTU or not.

Mar 12 2019, 7:33 AM
hrs abandoned D1858: Improvement for MAC address uniqueness of if_epair(4).

Fixed in a different way in r334094.

Mar 12 2019, 5:50 AM
hrs accepted D19488: Enhance IPv6 autoconf startup scripts.
Mar 12 2019, 5:47 AM

Mar 7 2019

hrs added a comment to D19488: Enhance IPv6 autoconf startup scripts.
In D19488#417207, @bz wrote:
In D19488#417164, @hrs wrote:

For (2), I think the old version unconditionally runs rtsol (w/o "d") when rtsold_enable="NO", and does not when rtsold_enable="YES" because rtsold (w/ "d") will be invoked later by rc.d/rtsold should handle it. In short, the condition which determines if rtsol is invoked or not depends only on "accept_rtadv" flag. Isn't it enough?

Hmm, are you sure? Looking at the logic I changed above we invoked rtsol only if rtsold was disabled and otherwise rtsold was started later and done it (so far we agree); I think that again meant that dhcp was run before the first RS/RA cycle happened hence me needing a way to trigger that early. Hence adding the extra interface flag. I think my description above was a cache miss and is wrong (I did this change months ago). I am almost tempted to remove the extra logic and run rtsol (no d) unconditionally if "accept_rtadv" and then start rtsold later or not depending on whether the user wants long-term stability and DNS options from RAs or not.
What do you think?

Mar 7 2019, 6:44 PM
hrs added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.
In D19487#417206, @bz wrote:
In D19487#417158, @hrs wrote:

Looks good to me. We might want to put an INFO log line when ND6_IFF_IPV6_ONLY flag is changed by receiving RA or link-down event so that the sysadmin can know what is going on.

Ifconfig will show the flag in the ndoptions line, in my case currently the manual one.

nd6 options=423<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL,IPV6_ONLY_MANUAL>

Logging each time we receive an RA is not a good idea as the IPv4 exemption logic logging has shown me (need to fix that). Logging on every "state toggle" would be good, I agree. I'll prepare that.

Mar 7 2019, 6:23 PM
hrs committed rP494875: Update to 1.1. Changes include:.
Update to 1.1. Changes include:
Mar 7 2019, 4:06 AM
hrs added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.

One more comment: immediate change of the flag just after a link-down event may be problematic when the link is unstable. In such a situation, IPv4 packets can be allowed after a link-up and before another RA arrives even if the all of advertising routers keep sending ipv6only flag. We can assume that the interface should be configured to accept RA when the machine moves from a network to another, so sending a RS after a link-up then clearing ND6_IFF_IPV6_ONLY only when no RA arrives in a few seconds looks a more reasonable behavior. If at least one RA arrives after the RS, the normal handling of ipv6only flag works.

Mar 7 2019, 1:25 AM
hrs added a comment to D19488: Enhance IPv6 autoconf startup scripts.

(1) looks good to me. For (2), I think the old version unconditionally runs rtsol (w/o "d") when rtsold_enable="NO", and does not when rtsold_enable="YES" because rtsold (w/ "d") will be invoked later by rc.d/rtsold should handle it. In short, the condition which determines if rtsol is invoked or not depends only on "accept_rtadv" flag. Isn't it enough?

Mar 7 2019, 1:08 AM
hrs accepted D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.

Looks good to me. We might want to put an INFO log line when ND6_IFF_IPV6_ONLY flag is changed by receiving RA or link-down event so that the sysadmin can know what is going on.

Mar 7 2019, 12:53 AM

Mar 5 2019

hrs committed rP494682: Update to 2.23.2815.102.00..
Update to 2.23.2815.102.00.
Mar 5 2019, 7:06 AM
hrs committed rS344788: Fix grammar..
Fix grammar.
Mar 5 2019, 2:53 AM
hrs committed rD52842: Use freebsd-xhtml-release.xsl to render relnotes.xml..
Use freebsd-xhtml-release.xsl to render relnotes.xml.
Mar 5 2019, 2:46 AM
hrs committed rP494670: Add missing dependency..
Add missing dependency.
Mar 5 2019, 2:12 AM

Mar 4 2019

hrs committed rP494659: Update devel/p5-Getopt-EX to 1.15 and textproc/greple to 8.3304..
Update devel/p5-Getopt-EX to 1.15 and textproc/greple to 8.3304.
Mar 4 2019, 10:33 PM
hrs accepted D19248: tun: VIMAGE fix for if_tun cloner.

Looks good to me.

Mar 4 2019, 6:46 PM
hrs committed rP494567: Update to 0.9.24..
Update to 0.9.24.
Mar 4 2019, 9:11 AM
hrs committed rP494560: Add USES=gnome..
Add USES=gnome.
Mar 4 2019, 7:38 AM
hrs committed rP494559: Add a workaround for poudriere build error during byte-compilation..
Add a workaround for poudriere build error during byte-compilation.
Mar 4 2019, 7:32 AM
hrs committed rP494550: Update to 20180606 snapshot..
Update to 20180606 snapshot.
Mar 4 2019, 5:38 AM
hrs committed rP494549: Update MASTER_SITES..
Update MASTER_SITES.
Mar 4 2019, 5:15 AM

Mar 3 2019

hrs committed rP494516: Fix build on 11.x..
Fix build on 11.x.
Mar 3 2019, 9:38 PM
hrs committed rS344739: Use struct addrinfo instead of struct sockaddr_storage.
Use struct addrinfo instead of struct sockaddr_storage
Mar 3 2019, 5:30 AM
hrs committed rP494476: Update to 2.2.0..
Update to 2.2.0.
Mar 3 2019, 5:03 AM
hrs committed rP494475: Update to 1.3.9.1 and add patches to support OpenSSL 1.0.x and.
Update to 1.3.9.1 and add patches to support OpenSSL 1.0.x and
Mar 3 2019, 4:18 AM
hrs committed rP494474: Update to 3.11.0, which supports OpenSSL 1.0.x and 1.1.x..
Update to 3.11.0, which supports OpenSSL 1.0.x and 1.1.x.
Mar 3 2019, 3:47 AM
hrs accepted D19418: Fix compilation WITHOUT_{INET,INET6}_SUPPORT or both..
Mar 3 2019, 3:13 AM
hrs committed rP494473: Fix build on 32-bit arch..
Fix build on 32-bit arch.
Mar 3 2019, 1:19 AM

Mar 2 2019

hrs committed rP494466: Update to v0.5.0 which supports OpenSSL 1.0.x/1.1.x..
Update to v0.5.0 which supports OpenSSL 1.0.x/1.1.x.
Mar 2 2019, 11:48 PM

Feb 28 2019

hrs added a comment to D19318: lang/ocaml: Update to 4.07.1..

I've updated the revision summary to include the GitHub address I will be working with the OCaml ports[1].
I will keep updating OCaml itself in here from time-to-time since this is the main thing, and for better internal visibility.
Thank you.
[1] currently it was no changes over the FreeBSD official ports tree but I will move the present changes to there ASAP.

Feb 28 2019, 3:53 AM
hrs added a comment to D19318: lang/ocaml: Update to 4.07.1..

-nox11 should be removed and converted by using FLAVOR.

Feb 28 2019, 12:23 AM

Feb 27 2019

hrs committed rP494063: Exclude devel_nox due to build failure..
Exclude devel_nox due to build failure.
Feb 27 2019, 3:58 PM
hrs added inline comments to D19248: tun: VIMAGE fix for if_tun cloner.
Feb 27 2019, 2:37 PM

Feb 19 2019

hrs committed rP493345: Add temporary workaround for poudriere build breakage..
Add temporary workaround for poudriere build breakage.
Feb 19 2019, 12:41 AM

Sep 23 2018

hrs requested changes to D16957: Use getaddrinfo and getaddrinfo instead of gethostbyname2 in ping(8)..
Sep 23 2018, 1:53 PM

Sep 22 2018

hrs accepted D16931: Update example in man page to use cap_getnameinfo function..
Sep 22 2018, 1:46 PM

Aug 29 2018

hrs requested changes to D16931: Update example in man page to use cap_getnameinfo function..

I would suggest the following changes using getaddrinfo() instead of inet_aton() to avoid address-family dependency. Is cap_getaddrinfo() allowed by capdns?

@@ -147,8 +163,9 @@
 const char *typelimit = "ADDR";
 int familylimit;
 const char *ipstr = "127.0.0.1";
-struct in_addr ip;
-struct hostent *hp;
+char hname[NI_MAXHOST];
+struct addrinfo hints, *res;
+int error;
Aug 29 2018, 4:12 AM
hrs accepted D16933: devel/lazygit: Update to 0.2.1.
Aug 29 2018, 4:04 AM
hrs accepted D16929: Document missing cap_getaddrinfo(3) function..

Looks good to me.

Aug 29 2018, 4:03 AM

Aug 10 2018

hrs accepted D16601: x11-drivers/xorgxrdp: update 0.2.6 -> 0.2.7 and backport some patches.
Aug 10 2018, 6:59 AM
hrs accepted D16621: New port: audio/pulseaudio-module-xrdp: separate PulseAudio modules from net/xrdp.
Aug 10 2018, 6:58 AM

Jul 11 2018

hrs accepted D16204: top(1): support multibyte characters in ARGV array depending on LC_CTYPE, not limited to UTF-8.

This is my submission, so I will leave someone else to do further review of this change. Please do not count my "accept revision" as an immediate approval.

Jul 11 2018, 11:14 AM
hrs added inline comments to D16202: libradius(3) IPv6 support.
Jul 11 2018, 11:01 AM

Jul 10 2018

hrs requested changes to D16204: top(1): support multibyte characters in ARGV array depending on LC_CTYPE, not limited to UTF-8.

IMHO strvisx(3) in machine.c should have a VIS_OCTAL flag as in my original submission because meta char encoding of strvisx(3), which uses iscntrl(3), does not make sense for most of multibyte encodings. Displaying characters not for the current locale in octal (or hexadecimal) number looks more intuitive to me.

Jul 10 2018, 8:54 AM
hrs accepted D16203: top(1): rollback r335836.

Reverting a change does not need any approval or review. Please document the reason in the commit log instead of just saying "rollback".

Jul 10 2018, 3:32 AM
hrs requested changes to D16203: top(1): rollback r335836.

Please split this changes into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. A single commit including the both is confusing.

Jul 10 2018, 1:16 AM

Jul 4 2018

hrs committed rS335932: - Fix a double unlock in inp_block_unblock_source() and.
- Fix a double unlock in inp_block_unblock_source() and
Jul 4 2018, 6:47 AM

Jul 3 2018

hrs accepted D16109: New port: mail/roundcube-identity_smtp.
Jul 3 2018, 8:15 AM

May 15 2018

hrs accepted D15441: net-im/rubygem-earthquake: Remove port.
May 15 2018, 6:24 AM
hrs added inline comments to D15441: net-im/rubygem-earthquake: Remove port.
May 15 2018, 3:01 AM

May 13 2018

hrs committed rP469771: Update to 2.1.0.0..
Update to 2.1.0.0.
May 13 2018, 4:19 AM

Apr 4 2018

hrs committed rS331980: Remove myself because import of Heimdal 7.5.0 completed..
Remove myself because import of Heimdal 7.5.0 completed.
Apr 4 2018, 4:26 AM
hrs committed rS331979: Tag Heimdal 7.5.0..
Tag Heimdal 7.5.0.
Apr 4 2018, 4:25 AM
hrs committed rS331978: Import Heimdal 7.5.0..
Import Heimdal 7.5.0.
Apr 4 2018, 4:22 AM
hrs committed rS331977: Add myself temporarily to import Heimdal 7.5.0..
Add myself temporarily to import Heimdal 7.5.0.
Apr 4 2018, 4:20 AM

Mar 30 2018

hrs accepted D14904: Remove a comment that suggests checking a non-pointer is non-NULL..
Mar 30 2018, 9:20 AM

Mar 22 2018

hrs accepted D10943: Static analysis: Improve DAD deletion code.
Mar 22 2018, 3:35 PM

Mar 19 2018

hrs committed rS331200: Please welcome Vincenzo Maffione (vmaffione) as a new src.
Please welcome Vincenzo Maffione (vmaffione) as a new src
Mar 19 2018, 8:28 AM
hrs committed rP464988: Please welcome Koichiro IWAO (meta) as a new ports committer..
Please welcome Koichiro IWAO (meta) as a new ports committer.
Mar 19 2018, 6:47 AM

Mar 15 2018

hrs closed D14585: Make getnameinfo(3) salen requirement less strict.
Mar 15 2018, 1:47 PM
hrs committed rS331000: Make getnameinfo(3) salen requirement less strict and.
Make getnameinfo(3) salen requirement less strict and
Mar 15 2018, 1:47 PM

Mar 6 2018

hrs added inline comments to D14585: Make getnameinfo(3) salen requirement less strict.
Mar 6 2018, 7:29 AM
hrs committed rP463684: Fix build on 10.X. mail/mu4e requires no C++ compiler..
Fix build on 10.X. mail/mu4e requires no C++ compiler.
Mar 6 2018, 1:45 AM

Mar 5 2018

hrs created D14585: Make getnameinfo(3) salen requirement less strict.
Mar 5 2018, 3:20 PM
hrs committed rS330442: - Remove extra NULL check before free()..
- Remove extra NULL check before free().
Mar 5 2018, 3:38 AM
hrs committed rS330441: Partially back out changes in r327464. stdlib.h is used when.
Partially back out changes in r327464. stdlib.h is used when
Mar 5 2018, 3:34 AM
hrs committed rP463617: Fix build on 10.X. mail/mu requires C++14 compiler..
Fix build on 10.X. mail/mu requires C++14 compiler.
Mar 5 2018, 3:33 AM

Mar 2 2018

hrs committed rP463371: Fix build..
Fix build.
Mar 2 2018, 5:27 AM

Mar 1 2018

hrs committed rP463345: Update to 2.1.4..
Update to 2.1.4.
Mar 1 2018, 5:19 PM

Feb 28 2018

hrs committed rP463190: Take maintainership..
Take maintainership.
Feb 28 2018, 8:48 AM
hrs committed rP463189: Update to 0.8.3..
Update to 0.8.3.
Feb 28 2018, 8:46 AM
hrs committed rP463188: Update to v15.1..
Update to v15.1.
Feb 28 2018, 8:43 AM
hrs committed rP463180: Update to 2.1.4..
Update to 2.1.4.
Feb 28 2018, 6:27 AM
hrs committed rP463179: Update to 1.0..
Update to 1.0.
Feb 28 2018, 6:10 AM
hrs committed rP463178: Update to 0.9.18..
Update to 0.9.18.
Feb 28 2018, 5:57 AM
hrs committed rP463177: Update libwraster to 0.95.8 and make x11-wm/windowmaker.
Update libwraster to 0.95.8 and make x11-wm/windowmaker
Feb 28 2018, 4:58 AM
hrs committed rP463175: Update to 1.3.0..
Update to 1.3.0.
Feb 28 2018, 4:28 AM

Feb 26 2018

hrs accepted D14510: Fix two memory leaks in syslogd.

Looks good to me. Thank you for taking care of it!

Feb 26 2018, 1:20 AM

Jan 23 2018

hrs committed rP459739: Update to 7.5.0:.
Update to 7.5.0:
Jan 23 2018, 10:35 AM

Jan 15 2018

hrs committed rD51386: Disable generating status.png temporarily..
Disable generating status.png temporarily.
Jan 15 2018, 3:45 AM

Sep 14 2017

hrs accepted D12354: Silently handle freeaddrinfo(NULL) for compatibility with code which works on other OSes..
Sep 14 2017, 6:00 PM