Page MenuHomeFreeBSD

hrs (Hiroki Sato)
User

Projects

User Details

User Since
May 21 2014, 7:59 PM (331 w, 5 d)

Recent Activity

Today

hrs added a comment to D24359: Add Farsi/Persian locales.

Any blocker for this change? Just wondering.

Mon, Sep 28, 7:30 PM

Thu, Sep 10

hrs committed rP548225: Update to 1.0.7. This also fixes the -fno-common issue..
Update to 1.0.7. This also fixes the -fno-common issue.
Thu, Sep 10, 10:34 PM

Wed, Sep 9

hrs added a comment to D24590: WWW: fix search.

Any comments from reviewers of this change? The current search box is still broken as far as I can check. Does it work for you?

Wed, Sep 9, 7:43 PM

Fri, Sep 4

hrs committed rD54464: Disable hyphenate.verbatim. This does not work for very long verbatim.
Disable hyphenate.verbatim. This does not work for very long verbatim
Fri, Sep 4, 4:21 AM

Thu, Sep 3

hrs committed rD54463: Forced commit to rebuild the document..
Forced commit to rebuild the document.
Thu, Sep 3, 9:36 PM
hrs reopened D24590: WWW: fix search.

Changes in rD54076 were wrong because listing the domain names with "site:" does not work correctly. I think the correct fix is removing the whitespaces between "site:" and the domain names and using OR keyword to group the domain names like this:

Thu, Sep 3, 6:09 PM
hrs committed rD54461: Do not add dependency to .txt format because it uses .html rendering.
Do not add dependency to .txt format because it uses .html rendering
Thu, Sep 3, 4:36 AM

Wed, Sep 2

hrs committed rD54457: Add dependency on share/pgpkeys/*.key. This is a temporary measure.
Add dependency on share/pgpkeys/*.key. This is a temporary measure
Wed, Sep 2, 10:03 PM
hrs requested changes to D26137: Wireguard merge.
Wed, Sep 2, 6:05 PM

Tue, Sep 1

hrs accepted D26273: inet6_option_space is deprecated, refer directly to inet6_opt_init.

Looks good to me.

Tue, Sep 1, 9:50 PM

Mon, Aug 31

hrs closed D25503: Update tools/tools/locale.
Mon, Aug 31, 10:57 PM
hrs committed rP547200: Update to 1.16..
Update to 1.16.
Mon, Aug 31, 5:59 PM
hrs accepted D26210: ls(1): Update all POSIX references and correct the STANDARDS sections.

Sorry for the delay. Looks good to me.

Mon, Aug 31, 1:47 AM

Aug 27 2020

hrs accepted D26171: add libnetmap.

Looks good to me. Thanks!

Aug 27 2020, 7:48 PM

Aug 26 2020

hrs requested changes to D26171: add libnetmap.
  • You have to add libnetmap to lib/Makefile, too.
  • nmreq.c does not build on 32-bit platforms because nr_options is uint64_t and uintptr_t is not uint64_t in that case. I think the following casting is required at least:
@@ -587,11 +587,11 @@ nmreq_remove_option(struct nmreq_header *h, struct nmr
 {
        uintptr_t *scan;
Aug 26 2020, 8:03 AM

Aug 25 2020

hrs committed rP546185: Fix distinfo forgotten after re-rolling out the distfile..
Fix distinfo forgotten after re-rolling out the distfile.
Aug 25 2020, 3:02 PM
hrs accepted D26099: rtsol(d): add script for "M bit".

Sorry for the delay. Looks good to me.

Aug 25 2020, 1:34 PM

Aug 23 2020

hrs added a comment to D26099: rtsol(d): add script for "M bit".
In D26099#581086, @bz wrote:

Anyone else comments? Otherwise I'll get it in no later than Tuesday.

Aug 23 2020, 10:29 PM
hrs committed rP545978: - Fix a build breakage when -fno-common is specified..
- Fix a build breakage when -fno-common is specified.
Aug 23 2020, 7:47 PM
hrs added a comment to D26161: valectl(8) patch to use the new netmap API.

Thanks a lot @hrs !
However, there is still a pending change in the upstream netmap repository:

https://github.com/luigirizzo/netmap/blob/master/apps/vale-ctl/vale-ctl.c

Aug 23 2020, 6:12 PM
hrs committed rP545828: - Fix dependency..
- Fix dependency.
Aug 23 2020, 4:08 PM
hrs committed rP545825: - Fix a build breakage when -fno-common is specified..
- Fix a build breakage when -fno-common is specified.
Aug 23 2020, 3:36 PM
hrs requested review of D26161: valectl(8) patch to use the new netmap API.
Aug 23 2020, 9:00 AM

Aug 15 2020

hrs committed rP545076: Update to 1.6 and add test target..
Update to 1.6 and add test target.
Aug 15 2020, 10:36 PM
hrs committed rS364246: Revert r364244 since commit of r364245 completed..
Revert r364244 since commit of r364245 completed.
Aug 15 2020, 7:23 AM
hrs committed rS364245: - Update to Unicode CLDR v35 (Unicode 12.0)..
- Update to Unicode CLDR v35 (Unicode 12.0).
Aug 15 2020, 7:19 AM
hrs committed rS364244: Disable the size limitation temporarily to commit changes.
Disable the size limitation temporarily to commit changes
Aug 15 2020, 7:16 AM
hrs committed rP544907: Fix a memory corruption issue which can allow overriding of file.
Fix a memory corruption issue which can allow overriding of file
Aug 15 2020, 2:35 AM
hrs committed rP544906: Update japanese/mozc-{server,el,tool} and japanese/{fcitx,ibus,uim}-mozc.
Update japanese/mozc-{server,el,tool} and japanese/{fcitx,ibus,uim}-mozc
Aug 15 2020, 1:21 AM

Aug 13 2020

hrs committed rP544815: Update to 0.95.9 and make it depend on ImageMagick7..
Update to 0.95.9 and make it depend on ImageMagick7.
Aug 13 2020, 3:54 PM

Jul 4 2020

hrs committed rS362925: MFC r362770:.
MFC r362770:
Jul 4 2020, 7:05 AM

Jul 3 2020

hrs requested changes to D25551: Optimize "install -s" and installworld.

I like the idea for optimization. Several comments are added in-line.

Jul 3 2020, 12:04 AM

Jun 29 2020

hrs requested changes to D25492: [linux-emulation and nanobsd] some hugo/asciidoctor changes.

Please use … instead of three periods. It is the correct way to show a horizontal ellipsis.

Jun 29 2020, 6:17 PM
hrs updated the summary of D25503: Update tools/tools/locale.
Jun 29 2020, 5:38 AM
hrs requested review of D25503: Update tools/tools/locale.
Jun 29 2020, 5:37 AM
hrs committed rS362770: Fix CTYPE for ja_JP.eucJP and ja_JP.SJIS..
Fix CTYPE for ja_JP.eucJP and ja_JP.SJIS.
Jun 29 2020, 3:23 AM

Jun 23 2020

hrs requested changes to D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.

Adding the following two lines between the invocation of ni6_input() and the "nroff =" line is simpler. This noff line was added to suppress a "uninitialized variable" warning a long time ago, and the proposed change reverts it effectively while the code paths have no problem.

Jun 23 2020, 12:05 PM · network
hrs closed D25112: Add FreeBSD 2020 Community Survey to news.
Jun 23 2020, 3:26 AM
hrs closed D25388: net/nfsshell: update WWW.
Jun 23 2020, 3:22 AM

Jun 22 2020

hrs committed rS362512: Fix a build error due to removal of hardware section in umass(4)..
Fix a build error due to removal of hardware section in umass(4).
Jun 22 2020, 9:42 PM
hrs added a comment to D25388: net/nfsshell: update WWW.

Committed. Thanks for the patch.

Jun 22 2020, 8:51 PM
hrs committed rP539945: Add WWW line..
Add WWW line.
Jun 22 2020, 8:51 PM

Jun 3 2020

hrs committed rD54196: Add announcement of 2020 Community Survey..
Add announcement of 2020 Community Survey.
Jun 3 2020, 6:24 AM
hrs accepted D25112: Add FreeBSD 2020 Community Survey to news.

Looks good to me while I agree with a blank line between <name> and <day> as already pointed out.

Jun 3 2020, 5:53 AM

Mar 20 2020

hrs committed rP528783: Update to 9.52..
Update to 9.52.
Mar 20 2020, 3:18 PM

Mar 18 2020

hrs committed rS359081: MFC of r358404, r358410, r358412, and r358413:.
MFC of r358404, r358410, r358412, and r358413:
Mar 18 2020, 6:22 PM
hrs committed rS359078: MFC of r358402:.
MFC of r358402:
Mar 18 2020, 6:16 PM
hrs committed rS359077: MFC of r358152 and r328235:.
MFC of r358152 and r328235:
Mar 18 2020, 6:11 PM
hrs committed rS359076: MFC of r355574, r358095, and r358395:.
MFC of r355574, r358095, and r358395:
Mar 18 2020, 6:03 PM
hrs committed rS359075: MFC of r358061:.
MFC of r358061:
Mar 18 2020, 5:42 PM
hrs committed rS359074: MFC from r347887:.
MFC from r347887:
Mar 18 2020, 5:36 PM
hrs committed rS359068: Remove /etc/host.conf, which was automatically generated from.
Remove /etc/host.conf, which was automatically generated from
Mar 18 2020, 8:17 AM
hrs committed rS359067: -F is GNU diff specific, not implemented in BSD diff..
-F is GNU diff specific, not implemented in BSD diff.
Mar 18 2020, 8:01 AM

Mar 16 2020

hrs committed rP528536: Update to 1.0.6..
Update to 1.0.6.
Mar 16 2020, 7:09 PM

Mar 14 2020

hrs committed rP528410: - Update to 9.51..
- Update to 9.51.
Mar 14 2020, 1:33 PM

Mar 13 2020

hrs committed rP528366: Regen patches..
Regen patches.
Mar 13 2020, 5:19 PM
hrs committed rP528365: Fix build breakage when PKINIT and/or KX509 disabled..
Fix build breakage when PKINIT and/or KX509 disabled.
Mar 13 2020, 5:12 PM

Mar 7 2020

hrs committed rS358730: Fix an issue of net.inet.igmp.stats handler..
Fix an issue of net.inet.igmp.stats handler.
Mar 7 2020, 8:41 AM
hrs committed rP527917: - Update MASTER_SITES and WWW: in pkg-descr..
- Update MASTER_SITES and WWW: in pkg-descr.
Mar 7 2020, 3:05 AM

Feb 27 2020

hrs committed rS358405: Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF..
Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.
Feb 27 2020, 7:50 PM
hrs closed D23732: Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.
Feb 27 2020, 7:50 PM
hrs added a comment to D22003: Add lle_event handler to ARP.

Ping? I will commit the revised patch if there is no objection.

Feb 27 2020, 7:42 PM
hrs committed rS358404: Fix broken STARTTLS when SharedMemoryKey is enabled..
Fix broken STARTTLS when SharedMemoryKey is enabled.
Feb 27 2020, 7:40 PM
hrs closed D23734: Fix broken STARTTLS when SharedMemoryKey is enabled.
Feb 27 2020, 7:40 PM
hrs committed rS358402: Add MODULE_PNP_INFO() to autoload the rtwn_pci(4) kernel module..
Add MODULE_PNP_INFO() to autoload the rtwn_pci(4) kernel module.
Feb 27 2020, 7:35 PM
hrs closed D23807: Add MODULE_PNP_INFO() to PCI-based rtwn(4) device drivers.
Feb 27 2020, 7:35 PM
hrs committed rS358395: Add workaround for models which do not follow the ACPI specification strictly..
Add workaround for models which do not follow the ACPI specification strictly.
Feb 27 2020, 5:14 PM

Feb 26 2020

hrs added inline comments to D23329: Make ICMP redirect processing depend on routing daemon.
Feb 26 2020, 8:39 PM

Feb 25 2020

hrs added inline comments to D23329: Make ICMP redirect processing depend on routing daemon.
Feb 25 2020, 10:52 PM

Feb 23 2020

hrs requested changes to D23329: Make ICMP redirect processing depend on routing daemon.
Feb 23 2020, 10:22 PM
hrs updated the diff for D23732: Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.

Fix the lines pointed out in the review.

Feb 23 2020, 9:34 PM
hrs committed rP526944: - Fix build on -current..
- Fix build on -current.
Feb 23 2020, 8:46 PM
hrs requested changes to D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.
Feb 23 2020, 5:24 PM · network
hrs created D23807: Add MODULE_PNP_INFO() to PCI-based rtwn(4) device drivers.
Feb 23 2020, 4:53 PM
hrs committed rP526922: - Fix build when !BDB..
- Fix build when !BDB.
Feb 23 2020, 2:57 PM

Feb 22 2020

hrs committed rP526858: Unbreak build:.
Unbreak build:
Feb 22 2020, 9:00 PM
hrs committed rP526857: Unbreak the build:.
Unbreak the build:
Feb 22 2020, 8:44 PM

Feb 20 2020

hrs added inline comments to D23732: Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.
Feb 20 2020, 11:55 PM
hrs committed rP526597: - Add dynamicrouting keyword..
- Add dynamicrouting keyword.
Feb 20 2020, 11:41 PM
hrs committed rS358152: Improve performance of "read" built-in command when using a seekable.
Improve performance of "read" built-in command when using a seekable
Feb 20 2020, 3:01 AM
hrs closed D23747: Improve sh(1) built-in read command performance when using a seekable fd.
Feb 20 2020, 3:01 AM

Feb 19 2020

hrs committed rS358095: Add _BIX (Battery Information Extended) object support..
Add _BIX (Battery Information Extended) object support.
Feb 19 2020, 6:29 AM
hrs closed D23728: Add _BIX (Battery Information Extended) object support to acpi_cmbat.
Feb 19 2020, 6:29 AM
hrs committed rP526484: Update to 7.7.0..
Update to 7.7.0.
Feb 19 2020, 6:20 AM
hrs committed rP526482: Fix build..
Fix build.
Feb 19 2020, 4:25 AM
hrs added a comment to D23695: Allow ND entries creation for all routes without gateway..
In D23695#521458, @hrs wrote:

I have no strong objection to allow a prefix route with no gateway, but I think the case pointed out in Bug 194485 can be solved by just adding an address with the delegated prefix on the interface (EUI-64 always works as the interface id). Is there any specific reason for DHCP-PD (or another use case) to have an interface route?

Thank you for looking into this!

Indeed, I should have provided a more accurate description. The problem is a bit bigger than just DHCPv6.

In general, RFC 5942 advocates for the explicit split between address management and prefix assignment:

Feb 19 2020, 12:34 AM

Feb 18 2020

hrs created D23747: Improve sh(1) built-in read command performance when using a seekable fd.
Feb 18 2020, 8:50 PM
hrs committed rP526438: Update to 1.2.29..
Update to 1.2.29.
Feb 18 2020, 4:27 AM
hrs updated the diff for D23728: Add _BIX (Battery Information Extended) object support to acpi_cmbat.

Remove irrelevant references to smbus(4).

Feb 18 2020, 3:56 AM
hrs added a comment to D23695: Allow ND entries creation for all routes without gateway..

I have no strong objection to allow a prefix route with no gateway, but I think the case pointed out in Bug 194485 can be solved by just adding an address with the delegated prefix on the interface (EUI-64 always works as the interface id). Is there any specific reason for DHCP-PD (or another use case) to have an interface route?

Feb 18 2020, 2:06 AM
hrs committed rS358061: Use 0x5c for the scan code 0x7d..
Use 0x5c for the scan code 0x7d.
Feb 18 2020, 1:50 AM

Feb 17 2020

hrs updated the diff for D23728: Add _BIX (Battery Information Extended) object support to acpi_cmbat.

Remove device_printf()s just for debugging.

Feb 17 2020, 7:56 PM
hrs created D23734: Fix broken STARTTLS when SharedMemoryKey is enabled.
Feb 17 2020, 7:33 PM
hrs created D23732: Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.
Feb 17 2020, 7:07 PM
hrs updated the diff for D22003: Add lle_event handler to ARP.

Updated the patch based on feedback from bz@:

Feb 17 2020, 6:37 PM
hrs created D23728: Add _BIX (Battery Information Extended) object support to acpi_cmbat.
Feb 17 2020, 5:57 PM

Jan 21 2020

hrs accepted D22992: Adds a news entry regarding the adoption of Weblate as a translation tool for official documentation..

Looks good to me.

Jan 21 2020, 5:26 PM

Jan 12 2020

hrs committed rP522790: Update to 12.2..
Update to 12.2.
Jan 12 2020, 3:01 PM

Jan 9 2020

hrs committed rP522544: - Use FONTPATHSPEC..
- Use FONTPATHSPEC.
Jan 9 2020, 10:42 PM

Dec 30 2019

hrs committed rP521518: Fixup patches by makepatch. No functional change..
Fixup patches by makepatch. No functional change.
Dec 30 2019, 4:58 PM