sbin/ping: Show the timeout message when echo reply is missing

[hrs]

Summary

This change makes ping(8) show the timeout message when it does not receive an echo reply in time like this:

% ping 192.0.2.1
PING 192.0.2.1 (192.0.2.1): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 1
Request timeout for icmp_seq 2
Request timeout for icmp_seq 3
^C
--- 192.0.2.1 ping statistics ---
5 packets transmitted, 0 packets received, 100.0% packet loss

This is useful for diagnostics because the sequence number shows which packet was lost. The same behavior can be found ping(8) on macOS.

[jlduran]

I like this addition.

There is one thing, in my opinion, that needs to be fixed:

% ping -q 192.0.2.1

Should not produce that output.
Any reason why not to use the patch straight from Darwin?:
https://github.com/apple-oss-distributions/network_cmds/blob/6ccdc225ad5aa0d23ea5e7d374956245d2462427/ping.tproj/ping.c#L1071-L1076

[zlei]

+1 on this feature

[jlduran]

Also failing this test:

% ping -c1 192.0.2.1
PING 192.0.2.1 (192.0.2.1): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 0

--- 192.0.2.1 ping statistics ---
1 packets transmitted, 0 packets received, 100.0% packet loss

[cy]

sbin/ping/ping.c

990

Should we add a test for (options & F_QUIET) == 0 too? I think the timeout message is counter to the -q option.

sbin/ping/ping6.c

1257

Same as previously:

Should we add a test for (options & F_QUIET) == 0 too? I think the timeout message is counter to the -q option.

[hrs]

• sbin/ping: Do not show "Request timeout" when -q is specified
• sbin/ping: Fix the timeout message when -c or -l are specified

The -l option will send the specified number of packets quickly. The current implementation will display the message only when all of them are lost.

A bug when the -c option is specified and no reply packet arrives that caused an extra timeout message has been fixed.

[hrs]

In D37930#861889, @jlduran_gmail.com wrote:

Also failing this test:

% ping -c1 192.0.2.1
PING 192.0.2.1 (192.0.2.1): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 0

--- 192.0.2.1 ping statistics ---
1 packets transmitted, 0 packets received, 100.0% packet loss

Thanks. This should be fixed in the updated patch.

sbin/ping/ping.c

990

Thanks for the feedback. Yes, no message should be displayed when F_QUIET is true. Fixed.

[cy]

LGTM

[jlduran]

Thank you!
I am sorry to insist on the same issue, but I believe the message "Request timeout for icmp_seq..." should appear when -A beeps.
This seems to be the case for Darwin/macOS.
As stated in my first comment, I don't see any reason why not to use the code from Apple, it is simpler and achieves the desired functionality (without the case for -l). Or maybe I am missing something?

[jlduran]

In D37930#861990, @jlduran_gmail.com wrote:

I believe the message "Request timeout for icmp_seq..." should appear when -A beeps.
Or maybe I am missing something?

😞 I believe ping -Ac1 192.0.2.1 should beep once, so there's a bug in -A?
Regardless, it would be tangential to this differential.