User Details
- User Since
- May 30 2017, 11:42 AM (493 w, 6 d)
Today
Reproducible on macOS as well. Thank you!
Fri, Nov 13
Thu, Nov 12
Wed, Nov 11
This patch is going to be submitted upstream first.
@emaste In case I'm AFK, would you mind including this commit in your MFC batch later today? Thank you!
Tue, Nov 10
Wed, Oct 21
Yes, i think this is ok. Although, I am not sure why this should not be moved to sshd-session.c (maybe the fact that nobody has complained is already a telltale sign that it is no longer needed)?
Seems ok to me, but I'll totally defer to @des, as the author of the original patch (I believe at that time there was no ProxyJump, etc.).
In the meantime, however, I may ask why not use option_clear_or_none() which seems specifically created for this purpose, i.e., when ProxyJump is set to none. (See inline reference direct).
Oct 8 2026
Thank you!
I remember mentioning this to the GSoC 2026 participant. All vmimages should do this as well IMO.
Currently only Azure images do it (by setting VM_BOOTPARTSOFFSET).
Oct 7 2026
Looks good!
I prefer to remove DSA, if possible (as stated in my email), given that stable/14 EoL is almost 2 years away. I can totally understand if this is not possible though.
Sep 12 2026
Sep 11 2026
Please see the suggested test (D59582). Ideally it should be squashed with this change. Thank you!
Sep 7 2026
I'm OK with "promoting" these example scripts into actual commands. However, since this is a user-facing change for Jails, I would suggest setting Relnotes: yes, as some users already install jib,jng into /usr/local/sbin.
I would also like to get some feedback from people using jails to do some interesting things, rather than just isolating/forwarding a few services (like I do).
Sep 4 2026
Sep 3 2026
Amazing!
Briefly tested:
# ifconfig vtnet0.20 create vlan 20 vlandev vtnet0 # sh ./jib addm test vtnet0.20 vtnet0.20bridge e0a_test e0b_test
I was not able to test it with jng:
# kldload ng_ether # ifconfig vtnet0.20 create vlan 20 vlandev vtnet0 # jail -c name=test host.hostname=test.home.arpa vnet persist # sh ./jng bridge test vtnet0.20 ngctl: send msg: Invalid argument # ngctl list There are 3 total nodes: Name: vtnet0 Type: ether ID: 00000001 Num hooks: 0 Name: vtnet0_20 Type: ether ID: 00000002 Num hooks: 0 Name: ngctl3288 Type: socket ID: 00000005 Num hooks: 0 # sh ./jng bridge test vtnet0 # The parent works as expected ng0_test
Sep 2 2026
Thank you!
This landed as 533918ced28ccd3b6ce22c93e0b64deac40377a1. The revision was not automatically closed because the commit message is slightly different (uppercase "R" in remove).
Let's examine release's functions one by one:
- arm_create_user is handled by another function in NanoBSD.
- arm_setup_usb_otg is somewhat handled by another function, but it is missing a few things.
- arm64_setup_multicons is handled by another function in NanoBSD.
- arm_setup_fdt_overlays is OK.
- arm_setup_minimal_loader I think we can ignore this customization?
- arm_do_quirk is achieved using nanobsd_loader_conf_extra (only used by PINEBOOK).
Sep 1 2026
Aug 31 2026
This change should ideally be done with D58964.
This is a followup of 62d028dcac1a ("Switch BEAGLEBONE, CUBIEBOARD, and PANDABOARD to use the GENERIC kernel configuration.")
If there are no objections, I will commit this revision over the weekend.
Aug 29 2026
Aug 28 2026
I believe we got the acronym wrong, shouldn't the directory name be sbc (Single-Board Computer)?
create_esp_partition() and create_cidata_partition() share a lot of common code. I wonder if they can be abstracted out?
Please squash with D58964.
This revision should be squashed with D59041.
Aug 27 2026
Aug 26 2026
Since this is a legacy-breaking change (perhaps the most significant one), we should provide an easy migration path. For example, in the commit message, we can explain that users who want to keep using sector sizes could add an s (for sector) suffix to its current values when migrating to the default plan, this is a deliberate change from strsuftoll, which uses b (for block) for that same purpose.
Please see: https://github.com/Coderangshu/freebsd-src/pull/60, which contains a WIP of NanoBSD using ZFS (the ZFS part is not really relevant at the moment, it was just an experiment). It illustrates that the file gpt.sh should actually be named ufs.sh and that common functions inherent to a GPT partitioning scheme belong in defaults.sh, leaving filesystem-specific functions inside their respective files (ufs.sh, zfs.sh, cd9660.sh, msdos.sh, i.e., anything that makefs(8) supports).
Maybe something closer to:
nanobsd: Disable dumpdev
I don't think we should touch anything legacy, or at least avoid it as much as possible. In this context embedded can be considered legacy.
I think _xxx_pkg_db_dump_or_vacuum should be added sooner. In fact, I think this function should not be a _xxx_ function, as we will always want to verify the integrity of the pkg database before shipping our NanoBSD image, so I suggest "promoting" it to a regular pkg function (pkg_db_vacuum since it no longer dumps.) and including it in D58951.
I think the commit message in this revision also needs updating.
While I do agree with the change, I do not fully agree with the commit message.
For me, the reason we want to remove this step is because we want to ship a NanoBSD image with the flags set just like a normal FreeBSD installation (/var/empty for instance).
I think this commit can be squashed with D58951, I see no reason to keep this in a separate commit.
Aug 25 2026
This revision is just a placeholder for D54187?
Do you think I can commit D52203 after you commit this update, or maybe incorporate those changes here?
The changes from freebsd-configure.sh (config.h) and freebsd-namespace.sh (ssh_namespace.h) are in a separate commit as usual?
I have this change in libssh's Makefile:
--- a/secure/lib/libssh/Makefile +++ b/secure/lib/libssh/Makefile @@ -35,7 +35,7 @@ SRCS= ${LIBOPENSSH_SRCS} \ libcrux-mlkem-mldsa.c ssh-mldsa-eddsa.c \ hmac.c ed25519.c ed25519-openssl.c \ kex.c kex-names.c kexdh.c kexgex.c kexecdh.c kexc25519.c \ - kexgexc.c kexgexs.c \ + kexgexc.c kexgexs.c kexmlkem768ecdh.c \ kexsntrup761x25519.c kexmlkem768x25519.c sntrup761.c kexgen.c \ sftp-realpath.c platform-pledge.c platform-tracing.c platform-misc.c \ sshbuf-io.c misc-agent.c ssherr-libcrypto.c
Aug 24 2026
Fix the output in the README file as well.
It seems that this should be squashed into D58964.
Is this commit fixing something already in base?
If the answer is yes, then the commit message should carry the trailer:
Fixes: <git log -n1 --format:'%h ("%s")' GIT-COMMIT-HASH>If the answer is no, the it should be squashed with the commit that introduced this change in you revision stack, glancing over it, it looks like it should be D58964.
Please provide the full URL: https://github.com/freebsd/pkg/issues/2672 in the commit log.
Aug 23 2026
At this point, I think this can be squashed into D58951.
The comment is somewhat strange (I understand: Uplink sets learnMac=0, which prevents both learning new MAC addresses and moving existing hosts).
