Page MenuHomeFreeBSD
Differential D56596

release: Explicitly enable lib32 in make-manifest.sh
Needs ReviewPublic
Actions

Authored by jlduran on Thu, Apr 23, 5:37 AM.
Tags
None
Referenced Files
F153980867: D56596.diff
Sat, Apr 25, 6:03 AM
Unknown Object (File)
Fri, Apr 24, 8:33 AM
Unknown Object (File)
Fri, Apr 24, 8:33 AM
Subscribers
imp
ivy
jrtc27
senguptaangshuman17_gmail.com

Details

Reviewers
None
Group Reviewers
releng
Summary

Explicitly set the lib32 distribution set (32-bit compatibility
libraries) to be selected by default during bsdinstall(8).

While lib32 is currently selected by default, it occurs implicitly
because default_lib32 is unset, falling into a catch-all that defaults
to "on".

The lib32 is selected by default because it is needed by some popular
ports, such as wine and steam.

Test Plan

As described in comment D56528#1294613, at the end of this revision stack, it should match the following:

% sh release/scripts/make-manifest.sh base-dbg.txz base.txz kernel-dbg.txz kernel.txz lib32-dbg.txz lib32.txz ports.txz src.txz tests.txz
base-dbg.txz	0123456789abcdef...	0	base_dbg	"Base system debug info"	off
base.txz	0123456789abcdef...	0	base	"Base system (MANDATORY)"	on
kernel-dbg.txz	0123456789abcdef...	0	kernel_dbg	"Kernel debug info"	off
kernel.txz	0123456789abcdef...	0	kernel	"Kernel (MANDATORY)"	on
lib32-dbg.txz	0123456789abcdef...	0	lib32_dbg	"32-bit compatibility libraries (Debugging)"	off
lib32.txz	0123456789abcdef...	0	lib32	"32-bit compatibility libraries"	on
ports.txz	0123456789abcdef...	0	ports	"Ports tree"	off
src.txz	0123456789abcdef...	0	src	"System source tree"	off
tests.txz	0123456789abcdef...	0	tests	"Test suite"	off

cc/ @senguptaangshuman17_gmail.com

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72493
Build 69376: arc lint + arc unit

Event Timeline

jlduran created this revision.Thu, Apr 23, 5:37 AM
Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptThu, Apr 23, 5:37 AM
jlduran requested review of this revision.Thu, Apr 23, 5:37 AM
Harbormaster completed remote builds in B72462: Diff 176236.Thu, Apr 23, 5:37 AM
jlduran added a parent revision: D56595: release: Do not select kernel-dbg.txz by default.Thu, Apr 23, 5:37 AM
jlduran edited the test plan for this revision. (Show Details)Thu, Apr 23, 5:46 AM
jlduran added a reviewer: releng.
jlduran added a subscriber: senguptaangshuman17_gmail.com.
jrtc27 added a comment.Thu, Apr 23, 5:12 PM

What's the justification for changing this long-standing default? I don't see one in the summary. I'm not saying it's the wrong thing to do, but it needs to be clearly stated.

jlduran added a comment.Thu, Apr 23, 5:59 PM

Yes, I agree. My original plan was to only select the MANDATORY options by default.
But giving it a second thought, maybe I should change it to explicitly set default_lib32 to on (it is currently set to on because there is no default_lib32), and clearly state in the commit that this is to have 32-bit support for some popular ports by default (wine, steam, etc.)?

jlduran retitled this revision from release: Do not select lib32.txz by default to release: Explicitly enable lib32 in make-manifest.sh.Thu, Apr 23, 6:19 PM
jlduran edited the summary of this revision. (Show Details)
jlduran edited the test plan for this revision. (Show Details)
jlduran updated this revision to Diff 176280.Thu, Apr 23, 6:21 PM

Address suggestions:

  • Add more context in the commit message
  • Leave this setting as is, just change the script to explicilty set it
Harbormaster completed remote builds in B72493: Diff 176280.Thu, Apr 23, 6:21 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
1 line

Diff 176280

View Options

release/scripts/make-manifest.sh

Loading...