@adrian any feedback on this commit? thank's in advance :)

@adrian could you please review the commit when you have time? Thanks :)

@melifaro Could I get your feedback on this commit ? Thanks!

@adrian Hi, any feedback or concerns about this commit ? :)

@emaste the commit has been approved. Can it be submitted ? :) Thanks!

@dteske Hi, this is accepted — could it be committed? Thanks!

@kib Hi, could you commit this when you time? Thanks!

@glebius Hi, could you land this at your convenience? Thanks!

@jlduran Hi, this has been accepted — could you commit it? Thanks!

@imp Hi, could this be landed when you get a chance? Thanks!

In D56345#1289609, @wulf wrote:

Looks mostly good.
There are some missing parts. TODO:

1. Add manpage. You may take share/man/man4/ps4dshock.4 as starting point. Do not forget to add missing touchpad and accelerometer support to BUGS section.
2. Add ps5dualsense.c to sys/conf/files and sys/conf/NOTES
3. Add ps5dualsense subdir to sys/modules/hid/Makefile

Added TEST_DEPENDS (covr, httr2, knitr, magrittr, rmarkdown, RSQLite, testthat, tibble, withr). Poudriere testport passes. make test: 101 pass, 89 skip, 1 fail in test-driver-redshift.R (requires paws.common for AWS Redshift auth — not ported).

Added complete TEST_DEPENDS (all ported Suggests: R6, data.table, devtools, ggplot2, knitr, magrittr, microbenchmark, rmarkdown, testthat, tinytest, tibble). Poudriere testport passes.

Added complete TEST_DEPENDS (all ported Suggests: Rcpp, RUnit, knitr, rmarkdown). make test passes.

Added TEST_DEPENDS (R6, data.table, testthat, tinytest, tibble) per uzsolt's suggestion. Poudriere testport and make test both pass.

Added TEST_DEPENDS (RUnit, Rcpp). make test passes (doRUnit.R runs, all checks OK).

In D56195#1289665, @eduardo wrote:

This changes must be accepted by maintainer. Is he been contacted?

Is there an PR (bugzilla) created? Bugzilla PRs are more suitable for simple updates.

Remove tikv-jemallocator dev-dependency. Tested with poudriere testport on FreeBSD 16.0-CURRENT amd64. Build, stage, package, and deinstall all clean.

Tested with poudriere testport on FreeBSD 16.0-CURRENT amd64 (QEMU). Build, stage, package, and deinstall all clean.

Tested with poudriere testport on FreeBSD 16.0-CURRENT amd64 (QEMU). Build, stage, package, and deinstall all clean.

Tested with poudriere testport on FreeBSD 16.0-CURRENT amd64 (QEMU). Build, stage, package, and deinstall all clean.

Drop the watchdog timer change.

Updated per reviewer feedback: moved hardware WOL configuration into rge_wol_config() in if_rge_hw.c. Tested on bare metal.

Reframe as UEFI spec compliance fix: remove unproven firmware hang claims, cite UEFI spec s7.4.6 requirements.

In D56233#1286789, @glebius wrote:

Thanks for the change!

I'm leaving for a short offline vacation and I prefer not to push changes before that. If you find an src committer who can push - welcome. Otherwise I will be back in about a week.

Tested with poudriere testport and portlint on FreeBSD 16.0-CURRENT amd64. Build, stage, package, and deinstall all clean.

Tested with poudriere testport and portlint on FreeBSD 16.0-CURRENT amd64. Build, stage, package, and deinstall all clean.

Tested with poudriere testport and portlint on FreeBSD 16.0-CURRENT amd64. Build, stage, package, and deinstall all clean.

Tested with poudriere testport and portlint on FreeBSD 16.0-CURRENT amd64. Build, stage, package, and deinstall all clean.

In D56180#1285548, @yuri wrote:

Build fails:
error: failed to run custom build command for `tikv-jemalloc-sys ...

jemalloc can't be used on FreeBSD because of conflicts. FreeBSD's memory allocator is based on jemalloc.

jemalloc should be patched out.

Additionally:

• please create all patches with git.
• always make sure the poudriere build succeeds before you submit a patch.

Fix tar flags: add missing dash before xJf and --no-xattrs for FreeBSD tar compatibility

In D56048#1284212, @yuri wrote:

It fails to build:

+ cp include/to-tar.mk Makevars.duckdb
+ [ -f duckdb.tar.xz ]
+ tar --no-xattrs xJf duckdb.tar.xz
tar: Must specify one of -c, -r, -t, -u, -x
ERROR: configuration failed for package 'duckdb'
* removing '/usr/ports/databases/R-cran-duckdb/work/stage/usr/local/lib/R/library/duckdb'
*** Error code 1