Page MenuHomeFreeBSD

usr.sbin/blacklist{d,ctl}: Use libblacklist
AbandonedPublic

Authored by ivy on Fri, Mar 27, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 2, 2:27 PM
Unknown Object (File)
Thu, Apr 2, 1:25 PM
Unknown Object (File)
Thu, Apr 2, 11:46 AM
Unknown Object (File)
Wed, Apr 1, 5:16 AM
Unknown Object (File)
Mon, Mar 30, 8:02 PM
Unknown Object (File)
Mon, Mar 30, 1:52 PM
Unknown Object (File)
Sat, Mar 28, 3:39 PM
Unknown Object (File)
Sat, Mar 28, 2:55 PM
Subscribers

Details

Reviewers
jlduran
Summary

This fixes the build when WITHOUT_BLOCKLIST=yes is set.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71753
Build 68636: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Fri, Mar 27, 10:34 PM

Give me some time to test it, but I think it is better if we just update share/mk/src.opts.mk (and regenerate the manual page afterwards):

.if ${MK_BLOCKLIST} == "no"
MK_BLACKLIST:=	no
.endif

.if ${MK_BLOCKLIST_SUPPORT} == "no"
MK_BLACKLIST_SUPPORT:=	no
.endif

The problem is that libblacklist should not be used by anything in base, not even blacklistd/blacklistctl. It is only there for some of the ports that still use it (which reminds me I should start submitting the patches). there are some incompatibilities between the two besides just the name.

Thank you for the heads up!

that sounds reasonable. note this blocks D56087, so i'm interested in the result.

In D56117#1283524, @ivy wrote:

that sounds reasonable. note this blocks D56087, so i'm interested in the result.

Also note that anything *blacklist*-related should be gone in 16.0. I'll work on updating the ports ASAP.

closing in favour of the other diff