• Removed gpiobus_attach_bus as per D51578 .

Thanks. I will test the change on Monday and update the patch.

• Reorganized rpi_virt_gpio_pin_set() by removed unnecessary variables.
• Replaced immediate values with macros defined in bcm2835_vcbus.h.
• Fixed indentation.

In D51456#1179348, @mhorne wrote:

I note however that I could not find the brcm,bcm2835-virtgpio compatible string in any official device tree sources. What is meant to provide it?

• Reorganized rpi_virt_gpio_pin_set() by removing unnecessary variables.
• Replaced immediate values with macros defined in bcm2835_vcbus.h.
• Fixed indentation.

• Make my memory region uncacheable by pmap_change_attr(... VM_MEMATTR_UNCACHEABLE).
• Use spin mutex rather than sx lock.

I tested the updated code and found it works as expected, so I will submit the patch shortly.

Added pmap_change_attr(... VM_MEMATTR_UNCACHEABLE) to ensure cache coherence. I will test it on Monday and upload the new patch.

• Use contigmalloc() rather than busdma to allocate memory region.

I will update the diff shortly, resolving all comments by mhorne. Thanks.

• Fixed a bug in wdat_merge_region(), that there were a couple of missing assignments. Also added some more comments.

Will upload the new revision shortly, fixing missing assignments bugs.

Fixed a bug in wdat_merge_region(), inifinite loop might occur if res1 and res2
had different types.

Much appreciated for finding out bugs and missing bits. I will upload a new revision shortly.

• Many changes pointed to by hrs.
• Style(9) changes, some pointed to by takawata.

I will update the new revision shortly.

In D37493#852643, @takawata wrote:

Add comment only man style for now. You may want to take a read style(9).