Page MenuHomeFreeBSD

takawata (Takanori Watanabe)
User

Projects

User Details

User Since
Mar 3 2015, 2:44 PM (290 w, 6 d)

Recent Activity

Tue, Sep 1

takawata committed rS365050: Add Cannon Point PCH Thermal Controller Device ID..
Add Cannon Point PCH Thermal Controller Device ID.
Tue, Sep 1, 3:34 PM

Aug 4 2020

takawata added a comment to D25908: Add _BTP method to control method batteries.

Looks good. I have one comment inline.

Aug 4 2020, 9:26 AM

Jul 17 2020

takawata committed rS363276: Fix L2CAP ACL packet PB(Packet Boundary) flag for LE PDU..
Fix L2CAP ACL packet PB(Packet Boundary) flag for LE PDU.
Jul 17 2020, 3:50 PM
takawata closed D25704: Fix L2CAP ACL packet Packet Boundary flag for LE packet..
Jul 17 2020, 3:50 PM
takawata requested review of D25704: Fix L2CAP ACL packet Packet Boundary flag for LE packet..
Jul 17 2020, 10:41 AM

Jul 8 2020

takawata committed rS363003: Add support for [read|write] supported data length commands..
Add support for [read|write] supported data length commands.
Jul 8 2020, 6:33 AM
takawata committed rS363002: Add le_rand command..
Add le_rand command.
Jul 8 2020, 3:58 AM

Jul 1 2020

takawata committed rS362825: Allow some Bluetooth LE related HCI request to non-root user..
Allow some Bluetooth LE related HCI request to non-root user.
Jul 1 2020, 4:01 AM
takawata closed D25516: Allow some Bluetooth LE related HCI request by non-root user..
Jul 1 2020, 4:01 AM

Jun 30 2020

takawata added a reviewer for D25516: Allow some Bluetooth LE related HCI request by non-root user.: emax.
Jun 30 2020, 8:33 AM
takawata requested review of D25516: Allow some Bluetooth LE related HCI request by non-root user..
Jun 30 2020, 4:24 AM

Jun 15 2020

takawata committed rS362199: Update event masks constant to Bluetooth core spec V5.2.
Update event masks constant to Bluetooth core spec V5.2
Jun 15 2020, 2:58 PM

Jun 10 2020

takawata committed rS362005: Add le_read_channel_map and le_read_remote_features command.
Add le_read_channel_map and le_read_remote_features command
Jun 10 2020, 5:01 AM
takawata committed rS362004: Add LE events:.
Add LE events:
Jun 10 2020, 4:54 AM

May 28 2020

takawata committed rS361586: Fix connection event message string (n->\n).
Fix connection event message string (n->\n)
May 28 2020, 1:49 PM

May 26 2020

takawata committed rS361520: Add le_connect command to connect to an LE device..
Add le_connect command to connect to an LE device.
May 26 2020, 3:46 PM

May 19 2020

takawata committed rS361254: Fix Typo in ng_hci_le_connection_complete_ep struct..
Fix Typo in ng_hci_le_connection_complete_ep struct.
May 19 2020, 1:59 PM
takawata committed rS361251: Add LE Whitelist commands to hccontrol.
Add LE Whitelist commands to hccontrol
May 19 2020, 1:44 PM

May 13 2020

takawata committed rP535083: Update to 7f47b07.
Update to 7f47b07
May 13 2020, 6:34 AM
takawata closed D24823: converters/bmfdec: Update to 7f47b07.
May 13 2020, 6:34 AM

May 12 2020

takawata requested review of D24823: converters/bmfdec: Update to 7f47b07.
May 12 2020, 3:48 PM

May 11 2020

takawata committed rS360899: Add le_scan subcommand to hccontrol..
Add le_scan subcommand to hccontrol.
May 11 2020, 3:32 PM

May 9 2020

takawata committed rS360846: Add space for RSSI in data member..
Add space for RSSI in data member.
May 9 2020, 2:16 PM

May 8 2020

takawata committed rS360806: Document le_enable subcommand.
Document le_enable subcommand
May 8 2020, 1:19 AM

Apr 28 2020

takawata committed rS360440: Add le_read_buffer_size command and manpage..
Add le_read_buffer_size command and manpage.
Apr 28 2020, 4:00 PM
takawata committed rS360435: Improve error handling.
Improve error handling
Apr 28 2020, 1:29 PM

Apr 27 2020

takawata committed rS360369: Resolve vendor id to string..
Resolve vendor id to string.
Apr 27 2020, 9:13 AM
takawata closed D21779: Fix Bluetooth LE related information parsing..
Apr 27 2020, 2:49 AM
takawata committed rS360360: Fix advertise packet parsing..
Fix advertise packet parsing.
Apr 27 2020, 2:49 AM

Apr 8 2020

takawata closed D22217: Fix iterating over BT LE responses.
Apr 8 2020, 10:17 AM
takawata accepted D22217: Fix iterating over BT LE responses.

This change is already done in CURRENT.

Apr 8 2020, 10:16 AM

Apr 2 2020

takawata committed rS359560: Fix mbuf handling in le advertize packet processing..
Fix mbuf handling in le advertize packet processing.
Apr 2 2020, 9:15 AM

Mar 31 2020

takawata committed rS359479: Add Platform Controller Hub built-in thermal management device driver..
Add Platform Controller Hub built-in thermal management device driver.
Mar 31 2020, 6:26 AM
takawata closed D24077: New driver pchtherm(4), PCH installed thermal sensor..
Mar 31 2020, 6:25 AM

Mar 19 2020

takawata updated the diff for D24077: New driver pchtherm(4), PCH installed thermal sensor..

Fix man pages wording.
Source coude style fix.

Mar 19 2020, 3:10 PM
takawata updated the diff for D24077: New driver pchtherm(4), PCH installed thermal sensor..

Fix typo.
Hide normal informational message under bootverbose.
Add comment on alert register handling.

Mar 19 2020, 2:56 AM

Mar 18 2020

takawata updated the diff for D24077: New driver pchtherm(4), PCH installed thermal sensor..

fix man page.
Add files.x86 entry to static configuration.

Mar 18 2020, 2:52 PM

Mar 17 2020

takawata updated the diff for D24077: New driver pchtherm(4), PCH installed thermal sensor..

Support autoload
Change driver source path.

Mar 17 2020, 1:19 PM

Mar 15 2020

takawata created D24077: New driver pchtherm(4), PCH installed thermal sensor..
Mar 15 2020, 7:40 AM

Feb 18 2020

takawata accepted D23728: Add _BIX (Battery Information Extended) object support to acpi_cmbat.
Feb 18 2020, 4:27 AM
takawata requested changes to D23728: Add _BIX (Battery Information Extended) object support to acpi_cmbat.

Almost all comments I had been made prior to this submit in other channel.
A few comment is inline.

Feb 18 2020, 3:44 AM

Dec 10 2019

takawata committed rS355574: Add ACPI battery subsystem man page..
Add ACPI battery subsystem man page.
Dec 10 2019, 2:19 AM
takawata closed D22556: Manual for ACPI battery subsystm.
Dec 10 2019, 2:19 AM

Dec 6 2019

takawata updated the diff for D22556: Manual for ACPI battery subsystm.

Update to reflect comments.

Dec 6 2019, 4:48 AM

Dec 3 2019

takawata updated the diff for D22556: Manual for ACPI battery subsystm.

Thanks. corrected.

Dec 3 2019, 10:28 AM

Nov 28 2019

takawata updated the diff for D22556: Manual for ACPI battery subsystm.

Thank you for your comment. I've updated it following your advice.

Nov 28 2019, 10:43 AM

Nov 26 2019

takawata updated the diff for D22556: Manual for ACPI battery subsystm.

Forget to change description from acpi_thermal.4, which was based.

Nov 26 2019, 10:17 AM
takawata updated the diff for D22556: Manual for ACPI battery subsystm.

Fix errors: typo and mandoc -Tlint.

Nov 26 2019, 10:14 AM
takawata created D22556: Manual for ACPI battery subsystm.
Nov 26 2019, 8:42 AM

Sep 24 2019

takawata created D21779: Fix Bluetooth LE related information parsing..
Sep 24 2019, 2:14 PM

Sep 6 2019

takawata accepted D21545: New port: converters/bmfdec: Decompile binary MOF file (BMF) from WMI buffer.

LGTM

Sep 6 2019, 12:12 PM
takawata committed rS351930: Add embedded Managed Object Format blob access to acpi_wmi(4)..
Add embedded Managed Object Format blob access to acpi_wmi(4).
Sep 6 2019, 10:12 AM
takawata closed D21529: Adding WMI embedded Binary MOF object interface driver..
Sep 6 2019, 10:12 AM
takawata updated the diff for D21529: Adding WMI embedded Binary MOF object interface driver..

style nit.

Sep 6 2019, 8:41 AM
takawata updated the diff for D21529: Adding WMI embedded Binary MOF object interface driver..

Style nit.

Sep 6 2019, 7:57 AM
takawata added a reviewer for D21529: Adding WMI embedded Binary MOF object interface driver.: hrs.

No features other than obtaining MOF is expected, so I add the feature in parent driver, instead of having new driver.

Sep 6 2019, 5:24 AM

Sep 5 2019

takawata updated the diff for D21529: Adding WMI embedded Binary MOF object interface driver..

Some nit, pointed out by hrs@

Sep 5 2019, 3:37 PM
takawata updated the diff for D21529: Adding WMI embedded Binary MOF object interface driver..

Free MOF buf only when successfilly detach.

Sep 5 2019, 9:10 AM
takawata updated the diff for D21529: Adding WMI embedded Binary MOF object interface driver..

Add the feature to acpi_wmi driver, instead of creating new driver.

Sep 5 2019, 9:00 AM
takawata created D21529: Adding WMI embedded Binary MOF object interface driver..
Sep 5 2019, 3:45 AM

Aug 3 2019

takawata committed rS350558: Add per hub sysctl to expose port information for phyisical form etc..
Add per hub sysctl to expose port information for phyisical form etc.
Aug 3 2019, 4:14 PM
takawata closed D20865: Expose USB port physical information in ACPI by sysctl..
Aug 3 2019, 4:14 PM

Aug 2 2019

takawata added a comment to D20865: Expose USB port physical information in ACPI by sysctl..

fix style .

Aug 2 2019, 7:34 AM

Jul 31 2019

takawata added a comment to D20865: Expose USB port physical information in ACPI by sysctl..

Run detach routine on fail.

Jul 31 2019, 2:44 PM

Jul 9 2019

D20865: Expose USB port physical information in ACPI by sysctl. now requires review to proceed.

Merge the head version.

Jul 9 2019, 3:47 PM

Jul 6 2019

takawata created D20865: Expose USB port physical information in ACPI by sysctl..
Jul 6 2019, 3:07 PM

Jun 20 2019

takawata committed rS349251: Fix the case where no root hub object while host controller object exist in….
Fix the case where no root hub object while host controller object exist in…
Jun 20 2019, 11:52 PM

Jun 17 2019

takawata committed rS349161: Add ACPI support for USB driver..
Add ACPI support for USB driver.
Jun 17 2019, 11:03 PM
takawata closed D20630: ACPI support for USB , mainly hub..
Jun 17 2019, 11:03 PM

Jun 15 2019

takawata updated the diff for D20630: ACPI support for USB , mainly hub..

Resolve comments.
Fix off-by-one error in acpi_usb_hub_port_probe_cb
Hide verbose outputs under debug flag.

Jun 15 2019, 4:20 PM

Jun 14 2019

takawata updated the diff for D20630: ACPI support for USB , mainly hub..

Resolve comments.

Jun 14 2019, 3:35 AM

Jun 13 2019

takawata created D20630: ACPI support for USB , mainly hub..
Jun 13 2019, 3:41 PM

Jan 25 2019

takawata committed rS343438: Use ACPI TPM2 table to probe tpmtis and tpmcrb device..
Use ACPI TPM2 table to probe tpmtis and tpmcrb device.
Jan 25 2019, 4:16 PM
takawata closed D18937: Use TPM2 ACPI table to distinguish CRB and TIS..
Jan 25 2019, 4:16 PM
takawata added a comment to D18937: Use TPM2 ACPI table to distinguish CRB and TIS..

The dmesg is as follows:
tpmcrb0: <Trusted Platform Module 2.0, CRB mode> iomem 0xfed40000-0xfed44fff on acpi0
device_attach: tpmcrb0 attach returned 6
tpmtis0: <Trusted Platform Module 2.0, FIFO mode> iomem 0xfed40000-0xfed44fff on acpi0

Jan 25 2019, 4:03 PM

Jan 24 2019

takawata updated the diff for D18937: Use TPM2 ACPI table to distinguish CRB and TIS..

Oops,I have mistake to remove device_set_desc() call.

Jan 24 2019, 8:25 AM
takawata added a reviewer for D18937: Use TPM2 ACPI table to distinguish CRB and TIS.: mw.
Jan 24 2019, 2:43 AM
takawata created D18937: Use TPM2 ACPI table to distinguish CRB and TIS..
Jan 24 2019, 2:42 AM

Oct 26 2018

takawata committed rS339754: Distinguish _CID match and _HID match and make lower priority probe.
Distinguish _CID match and _HID match and make lower priority probe
Oct 26 2018, 12:06 AM
takawata closed D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..
Oct 26 2018, 12:06 AM

Oct 25 2018

takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

reduce diff.

Oct 25 2018, 12:37 AM
takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

Reduce diff.

Oct 25 2018, 12:35 AM
takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

Remove unrerlated diff.

Oct 25 2018, 12:34 AM
takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

acpi_cpu nit.

Oct 25 2018, 12:27 AM
takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

Update acpi_ec , button style nit.

Oct 25 2018, 12:16 AM

Oct 24 2018

takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

Remove unrelated diff.

Oct 24 2018, 4:41 PM
takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

After freeze I update this patch.
Style nit, amdgpio rewrite is added.

Oct 24 2018, 4:39 PM

Jul 28 2018

takawata updated the diff for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

updated:
Thank you for your comments.
Style nits.
Remove non-related change.
Compare with 0 to check ACPI_ID_PROBE
add comment on acpi_MatchHID

Jul 28 2018, 3:11 AM

Jul 27 2018

takawata added a reviewer for D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match.: sepherosa_gmail.com.
Jul 27 2018, 1:05 PM
takawata created D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..
Jul 27 2018, 12:35 PM

Apr 25 2018

takawata added reviewers for D15198: Make acpi_wmi module attached without single Embedded Controller.: avg, rpaulo.
Apr 25 2018, 2:21 PM
takawata created D15198: Make acpi_wmi module attached without single Embedded Controller..
Apr 25 2018, 2:18 PM

Apr 27 2017

takawata committed rS317506: Make cached Bluetooth LE host advertise information visible from userland..
Make cached Bluetooth LE host advertise information visible from userland.
Apr 27 2017, 3:03 PM
takawata closed D10362: Make cached Bluetooth LE host advertise information visible from userland. by committing rS317506: Make cached Bluetooth LE host advertise information visible from userland..
Apr 27 2017, 3:03 PM

Apr 20 2017

takawata updated the diff for D10362: Make cached Bluetooth LE host advertise information visible from userland. .

Use m_pullup instead of NG_HCI_M_PULLUP, if mbuf has enough space, m_pullup will return NULL.

Apr 20 2017, 3:06 PM
takawata planned changes to D10362: Make cached Bluetooth LE host advertise information visible from userland. .
Apr 20 2017, 2:43 PM

Apr 15 2017

takawata updated the diff for D10362: Make cached Bluetooth LE host advertise information visible from userland. .

add NULL pointer checks pointed out.

Apr 15 2017, 3:32 PM

Apr 11 2017

takawata created D10362: Make cached Bluetooth LE host advertise information visible from userland. .
Apr 11 2017, 5:13 PM

Mar 5 2017

takawata added a reviewer for D9878: Fix a memory leak in bluetooth/hccontrol: emax.
Mar 5 2017, 6:31 PM

Jun 7 2016

takawata committed rS301558: Disconnect LE socket when the HCI connection associated is disconnected..
Disconnect LE socket when the HCI connection associated is disconnected.
Jun 7 2016, 4:57 PM