Oh my, I just noticed that I already have the same fix in https://reviews.freebsd.org/D30146.

changed test case name to newlocale_cu8

Adding np@ as it's somewhat "external" man page, want to be sure it won't break the process for vendor.

In D37868#894488, @jon_xyinn.org wrote:

Just got a notice on my original bug report for this. Thanks for taking this on @yuri_aetern.org.

Minor question, what does the U stand for in ${PORTSDIR:U/usr/ports, I'm familiar with the other parts of shell variable substitution / replacement, but I haven't seen the U before haha.

In D38140#869500, @wulf wrote:

{F55560085}
It resolves all my comments and converts hv_hid to kernel module auto-loaded by devmatch

(hopefully the last nit fix from me) set name for the device to make device description from hms look a bit more sane

make use of hid_intr_start/hid_intr_stop

diff with full context

As it now works, update the summary/test plan, and rename the driver to hv_hid.

style this a bit

In D38135#866420, @wulf wrote:

LGTM

Thanks! What string I should place in to commit's "Author" git tag?

In D37696#857437, @imp wrote:

Can I get a Signed-off-by: line or an email address with your full name so I can commit?

use CAM_STATUS_MASK, status is not really a bitmap

My bad, thanks for fixing this.

What's interesting, if I "insert" the media after the system is booted, which makes the umass device to "connect", the quirks do NOT seem to be applied, and the device is unusable.

rebase

In D35612#809596, @philip wrote:

Tested on a DL380 and seems to work.

removed the ifdef 0'ed code

In D35600#807470, @hselasky wrote:

Can you dump the usb configuration descriptor using "usbdump dump_curr_config_desc" for your device?

Sounds strange that ATAPI is not selected by default when CD-ROMs are used!

--HPS

Also set UQ_MSC_NO_GETMAXLUN as it's auto-added anyway.