Page MenuHomeFreeBSD

mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (415 w, 2 d)

Recent Activity

Mon, May 16

mav committed R10:718cb64a1f7b: mpsutil: Fix device speed reporting. (authored by mav).
mpsutil: Fix device speed reporting.
Mon, May 16, 2:27 PM
mav committed R10:9d0620722654: mpsutil: fix set but not used warning (authored by mav).
mpsutil: fix set but not used warning
Mon, May 16, 2:26 PM
mav committed R10:ef303790efb6: Fix formatting of the usage() output (authored by scottl).
Fix formatting of the usage() output
Mon, May 16, 2:26 PM

Sun, May 15

mav committed R10:c16cbd2e9162: Default to always accepting the PHY that's present. Linux did (authored by scottl).
Default to always accepting the PHY that's present. Linux did
Sun, May 15, 4:34 PM
mav committed R10:15adc3b3b4ab: Default to always accepting the PHY that's present. Linux did (authored by scottl).
Default to always accepting the PHY that's present. Linux did
Sun, May 15, 4:34 PM

Sat, May 14

mav accepted D35206: kqueue: Fix kqueue(2) man page..

I don't remember it already, but you seem to be right, I see the 24 hours limit removed in 40e794ab19fb 9 years ago.

Sat, May 14, 12:29 AM

Wed, May 11

mav committed R10:217a0796fb0b: GEOM: Fix regression after 7f16b501e25. (authored by mav).
GEOM: Fix regression after 7f16b501e25.
Wed, May 11, 1:45 AM
mav committed R10:5f6a3a81f63c: GEOM: Introduce partial confxml API (authored by mav).
GEOM: Introduce partial confxml API
Wed, May 11, 1:44 AM
mav committed R10:d6a32773ea4b: rtsx: Number of tweaks for RTS5260. (authored by hlh_restart.be).
rtsx: Number of tweaks for RTS5260.
Wed, May 11, 1:18 AM

Mon, May 9

mav committed R10:bce02a0ea43a: mpsutil: Fix device speed reporting. (authored by mav).
mpsutil: Fix device speed reporting.
Mon, May 9, 10:04 PM
mav committed R10:53c184cf0605: mpsutil: fix set but not used warning (authored by mav).
mpsutil: fix set but not used warning
Mon, May 9, 10:04 PM
mav committed R10:356155fe0237: Fix bd82711aff98 serial number trailing spaces removal. (authored by mav).
Fix bd82711aff98 serial number trailing spaces removal.
Mon, May 9, 2:31 PM

Wed, May 4

mav committed R10:8dab6aba5f6e: CAM: Keep periph_links when restoring CCB in camperiphdone(). (authored by mav).
CAM: Keep periph_links when restoring CCB in camperiphdone().
Wed, May 4, 1:03 AM

Tue, May 3

mav committed R10:84849cfd1dc0: CAM: Keep periph_links when restoring CCB in camperiphdone(). (authored by mav).
CAM: Keep periph_links when restoring CCB in camperiphdone().
Tue, May 3, 8:51 PM

Mon, May 2

mav added a comment to D34977: ada: Retry commands with retries left on CAM_SEL_TIMEOUT.

The only case I see AHCI to return CAM_SEL_TIMEOUT is:

 if (ch->devices == 0 ||
    (ch->pm_present == 0 &&
     ccb->ccb_h.target_id > 0 && ccb->ccb_h.target_id < 15)) {
        ccb->ccb_h.status = CAM_SEL_TIMEOUT;
        break;
}

, which means device is not detected. I don't see how it can be transient and why it should be retried.

Mon, May 2, 2:13 PM

Sun, May 1

mav committed R10:3529ddcfbe09: CAM: Replicate e0ceec676dc8 from da to ada and nda. (authored by mav).
CAM: Replicate e0ceec676dc8 from da to ada and nda.
Sun, May 1, 2:55 AM

Thu, Apr 28

mav accepted D35092: mpr/mps: when sending reset on removal, include target in message.
Thu, Apr 28, 8:38 PM
mav accepted D35093: cam_periph: Return ENXIO when peripheral is invalidated.

I think both error codes are correct there, but ENXIO indeed should be more informative here.

Thu, Apr 28, 8:33 PM
mav committed R10:404f001161b9: CAM: Keep periph_links when restoring CCB in camperiphdone(). (authored by mav).
CAM: Keep periph_links when restoring CCB in camperiphdone().
Thu, Apr 28, 1:53 AM

Wed, Apr 27

mav added inline comments to D35074: Add MODULE_PNP_INFO() to rtsx.
Wed, Apr 27, 5:26 PM
mav committed R10:8290c1442018: rtsx: Number of tweaks for RTS5260. (authored by hlh_restart.be).
rtsx: Number of tweaks for RTS5260.
Wed, Apr 27, 1:45 AM

Tue, Apr 26

mav accepted D35059: ndaasync: sync to SCSI's daasyncs cam_periph_async() calls.
Tue, Apr 26, 12:14 AM
mav accepted D35057: adaasync: Harmonize with daasync.
Tue, Apr 26, 12:12 AM
mav added a comment to D35057: adaasync: Harmonize with daasync.
In D35057#794539, @imp wrote:

So should I add AC_LOST_DEVICE as an explicit case here? I'm sorry, but I'm having trouble understanding your point...

Tue, Apr 26, 12:10 AM

Mon, Apr 25

mav added a comment to D35057: adaasync: Harmonize with daasync.

async handlers are called only for the events explicitly specified to xpt_register_async(). As such, every periph driver specifies there AC_LOST_DEVICE, handled by cam_periph_async(). It means every driver has to know what cam_periph_async() can actually handle and how better call it. In such situation "default" case (calling always) can be useful only to not explicitly list new event types sometimes in the future, that may actually be more confusing.

Mon, Apr 25, 9:24 PM
mav added a comment to D35038: cam: Small reorg of ata xpt async code.

Are you going to do the same for SCSI to not diverge them?

Mon, Apr 25, 9:10 PM
mav added a comment to D35040: ada: create ada_reprobe for common probe starting logic.

While I see no problem with this patch, I am not sure it is not an obfuscation. The same checks are done (or should be done) at every probe stage. The check seems to be missing on transition from ADA_CCB_RAHEAD to ADA_STATE_WCACHE. I think "goto skipstate" logic of dastart() could be more universal.

Mon, Apr 25, 3:14 PM
mav accepted D35038: cam: Small reorg of ata xpt async code.
Mon, Apr 25, 3:01 PM
mav accepted D35039: ada: Eliminate dead code.
Mon, Apr 25, 2:55 PM

Sun, Apr 24

mav committed R10:38f8addaab1a: CAM: Replicate e0ceec676dc8 from da to ada and nda. (authored by mav).
CAM: Replicate e0ceec676dc8 from da to ada and nda.
Sun, Apr 24, 12:16 AM

Sat, Apr 23

mav committed R10:15e0215800fb: cam: don't send scsi commands on shutdown when reboot method RB_NOSYNC (authored by wma).
cam: don't send scsi commands on shutdown when reboot method RB_NOSYNC
Sat, Apr 23, 11:04 PM

Thu, Apr 21

mav accepted D34987: acpi_apei: Use devclass_find to find devclass in identify..

I'm just thinking why not to remove apei_devclass same time. Unless you wish this to be mergeable separately.

Thu, Apr 21, 4:19 PM
mav accepted D34981: sigtimedwait: Prevent timeout math overflows..
Thu, Apr 21, 12:56 AM
mav added inline comments to D34981: sigtimedwait: Prevent timeout math overflows..
Thu, Apr 21, 12:54 AM

Apr 20 2022

mav added inline comments to D34981: sigtimedwait: Prevent timeout math overflows..
Apr 20 2022, 4:11 PM
mav added inline comments to D34981: sigtimedwait: Prevent timeout math overflows..
Apr 20 2022, 4:02 PM
mav added a comment to D33693: Run softclock threads at a hardware ithread priority..

@mav : This is not about sbt vs HZ.

When multiple programs run at the same priority, I think they shifted around every system tick ???

Apr 20 2022, 2:32 PM
mav accepted D33693: Run softclock threads at a hardware ithread priority..
Apr 20 2022, 1:29 PM
mav added a comment to D33693: Run softclock threads at a hardware ithread priority..

@hselasky Do you know some time-critical places that still depending on HZ, not rewritten to use _sbt() variants?

Apr 20 2022, 1:28 PM

Apr 19 2022

mav added a comment to D34940: geom: consistently strip /dev/ prefix at input.

I've just noticed this touches only kernel. It would probably be good for consistency do the same in user-space (lib/geom), like gpart_backup()/gpart_restore()/gpart_bootcode()/etc.

Apr 19 2022, 4:49 PM

Apr 18 2022

mav added inline comments to D34929: cxgbei: Return limits for the specific adapter the socket is on..
Apr 18 2022, 8:22 PM
mav accepted D34940: geom: consistently strip /dev/ prefix at input.

I have no objections except some thoughts on function names.

Apr 18 2022, 5:43 PM
mav accepted D34928: iscsi: Fetch limits based on a socket rather than assuming global limits..

I have no objections. Only wonder what is the mentioned relations to MTU and what happen if MTU change live?

Apr 18 2022, 1:48 AM
mav accepted D34929: cxgbei: Return limits for the specific adapter the socket is on..
Apr 18 2022, 1:43 AM
mav accepted D34927: iscsid: Push #ifdef ICL_KERNEL_PROXY into cap_ioctl_limits list..
Apr 18 2022, 1:20 AM

Apr 7 2022

mav resigned from D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.

I am not really familiar with this hardware to review this. Only fixed couple mechanical issues.

Apr 7 2022, 5:15 PM

Apr 6 2022

mav committed R10:e3b3dfa77964: gpart: Avoid geom_gettree() call in "bootcode -b". (authored by mav).
gpart: Avoid geom_gettree() call in "bootcode -b".
Apr 6 2022, 2:46 AM
mav committed R10:59c15b83be87: geom: Allow "load" command for already loaded modules. (authored by mav).
geom: Allow "load" command for already loaded modules.
Apr 6 2022, 2:46 AM
mav committed R10:aacc15792681: GEOM: Make G_F_CTLDUMP also dump result. (authored by mav).
GEOM: Make G_F_CTLDUMP also dump result.
Apr 6 2022, 2:46 AM
mav committed R10:43405337215b: GEOM: Introduce gctl_add_param() API. (authored by mav).
GEOM: Introduce gctl_add_param() API.
Apr 6 2022, 2:45 AM
mav committed R10:be6abdb25956: GEOM: Skip copyin() for GCTL_PARAM_WR parameters. (authored by mav).
GEOM: Skip copyin() for GCTL_PARAM_WR parameters.
Apr 6 2022, 2:45 AM

Mar 31 2022

mav committed R10:ee772cbdc4e2: rtsx: Remove update of softc during probe and some var rename. (authored by hlh_restart.be).
rtsx: Remove update of softc during probe and some var rename.
Mar 31 2022, 1:51 AM
mav committed R10:c1a9422b9962: rtsx: Display error if rtsx_read()/rtsx_write() fail. (authored by hlh_restart.be).
rtsx: Display error if rtsx_read()/rtsx_write() fail.
Mar 31 2022, 1:50 AM
mav committed R10:cd89969685a4: rtsx: Don't detach during shutdown (authored by hlh_restart.be).
rtsx: Don't detach during shutdown
Mar 31 2022, 1:50 AM

Mar 29 2022

mav accepted D34707: nvme: MPS is a power of two.

I'm OK on the main topic, but have comment on another one touched.

Mar 29 2022, 4:14 PM
mav committed R10:a7318b86e4ff: CTL: Rework 05c3e8e87142 using %zu format. (authored by mav).
CTL: Rework 05c3e8e87142 using %zu format.
Mar 29 2022, 1:51 AM
mav committed R10:2f363712480e: CTL: Add length validation for incoming HA messages. (authored by mav).
CTL: Add length validation for incoming HA messages.
Mar 29 2022, 1:51 AM
mav committed R10:b6a744133340: Fix 32-bit build after 530d274c15e5. (authored by mav).
Fix 32-bit build after 530d274c15e5.
Mar 29 2022, 1:51 AM

Mar 26 2022

mav accepted D34671: Retire ISA sound card drivers.
Mar 26 2022, 1:52 AM
mav added inline comments to D34671: Retire ISA sound card drivers.
Mar 26 2022, 1:31 AM

Mar 25 2022

mav committed R10:2e8830678637: rtsx: Remove update of softc during probe and some var rename. (authored by hlh_restart.be).
rtsx: Remove update of softc during probe and some var rename.
Mar 25 2022, 7:26 PM

Mar 24 2022

mav committed R10:bbf3b7bdf876: rtsx: Call rtsx_init() on resume. (authored by hlh_restart.be).
rtsx: Call rtsx_init() on resume.
Mar 24 2022, 5:31 PM
mav committed R10:9b261d2e0a44: rtsx: Display error if rtsx_read()/rtsx_write() fail. (authored by hlh_restart.be).
rtsx: Display error if rtsx_read()/rtsx_write() fail.
Mar 24 2022, 1:18 AM
mav committed R10:6b7718377b8a: rtsx: Don't detach during shutdown (authored by hlh_restart.be).
rtsx: Don't detach during shutdown
Mar 24 2022, 1:18 AM
mav committed R10:c79ba1401252: ipmi: Make all sysctls also tunables. (authored by mav).
ipmi: Make all sysctls also tunables.
Mar 24 2022, 12:51 AM

Mar 23 2022

mav resigned from D34639: bsdinstall/partedit: Replace libdialog with libbsddialog.

I am not familiar with dialogs or this code. I've tried to look for GEOM-related changes, but haven't found any.

Mar 23 2022, 3:57 PM
mav committed R10:5f81a4619dcf: Remove "/dev/" from geom name in `gpart add` command. (authored by mav).
Remove "/dev/" from geom name in `gpart add` command.
Mar 23 2022, 1:31 AM
mav committed R10:09d62b4382ef: Remove "/dev/" from geom name in `gpart add` command. (authored by mav).
Remove "/dev/" from geom name in `gpart add` command.
Mar 23 2022, 1:29 AM

Mar 22 2022

mav committed R9:0b462a53e8b7: Add back my (mav) PGP key. (authored by mav).
Add back my (mav) PGP key.
Mar 22 2022, 9:21 PM
mav committed R10:205fa5f0a5cb: rtsx: Call rtsx_init() on resume. (authored by hlh_restart.be).
rtsx: Call rtsx_init() on resume.
Mar 22 2022, 12:30 AM

Mar 21 2022

mav committed R10:fd6ca665d206: Fix umtxq_sleep() regression caused by 56070dd2e4d. (authored by mav).
Fix umtxq_sleep() regression caused by 56070dd2e4d.
Mar 21 2022, 11:57 PM

Mar 19 2022

mav committed R10:1b1bab0078a7: rtsx: Call rtsx_init() on resume. (authored by hlh_restart.be).
rtsx: Call rtsx_init() on resume.
Mar 19 2022, 4:40 PM

Mar 18 2022

mav accepted D34604: Add deprecation notices to ISA sound cards.

I don't have specific objections except nostalgic. I was thinking about it from perspective of Giant lock many of them use. There are few Giant-locked PCI sound drivers too, but that may go separately: either fix or also remove.

Mar 18 2022, 4:27 PM

Mar 17 2022

mav committed R10:016d18229c6b: ipmi: Make all sysctls also tunables. (authored by mav).
ipmi: Make all sysctls also tunables.
Mar 17 2022, 5:35 PM

Mar 16 2022

mav added a comment to D34117: hdac: Handle interrupts racing with device suspend.

I've somehow missed intsts != 0xffffffff part when I looked on this patch, I though it is about locking. Is definitely explains why it helps. On downside I can only think that in theory there can be a controller with all 30 streams supported and all requiring attention same time. Though that may be quite unrealistic.

Mar 16 2022, 6:24 PM
mav committed R10:ed5d6089113c: Remove "/dev/" from geom name in `gpart add` command. (authored by mav).
Remove "/dev/" from geom name in `gpart add` command.
Mar 16 2022, 4:11 AM
mav committed R10:bd0f3d34fa20: GEOM: Fix regression after 7f16b501e25. (authored by mav).
GEOM: Fix regression after 7f16b501e25.
Mar 16 2022, 4:07 AM

Mar 15 2022

mav accepted D34117: hdac: Handle interrupts racing with device suspend.

I don't see a problem from this patch, if it helps (assuming HDAC_INTSTS still returns sane zero when HDAC_RIRBSTS turns mentioned 0xff, otherwise I am not sure what it fixes). May be I am missing some other motivation Andriy had when written this part, but if we assume that all/most modern hardware use non-shared MSI interrupts, there should be almost no cases when interrupt got delivered but HDAC_INTSTS is still zero, and so taking lock before the read should only slightly increase lock hold time for two register reads. We pay that price in much more busy drivers than sound.

Mar 15 2022, 8:21 PM

Mar 12 2022

mav closed D34529: GEOM: Introduce partial confxml API.
Mar 12 2022, 4:56 PM
mav committed R10:7f16b501e25b: GEOM: Introduce partial confxml API (authored by mav).
GEOM: Introduce partial confxml API
Mar 12 2022, 4:56 PM

Mar 11 2022

mav added inline comments to D34529: GEOM: Introduce partial confxml API.
Mar 11 2022, 4:13 AM
mav requested review of D34529: GEOM: Introduce partial confxml API.
Mar 11 2022, 2:24 AM

Mar 8 2022

mav accepted D34406: iscsi: Support unmapped I/O requests in the default initiator..
Mar 8 2022, 11:33 PM
mav accepted D34382: iscsi: Handle unmapped I/O requests..
Mar 8 2022, 11:25 PM
mav accepted D34487: iser: Fix check for opcodes in iser_conn_pdu_append_data..
Mar 8 2022, 11:23 PM
mav committed R10:5c20bfc78706: gpart: Avoid geom_gettree() call in "bootcode -b". (authored by mav).
gpart: Avoid geom_gettree() call in "bootcode -b".
Mar 8 2022, 7:01 PM
mav committed R10:5678114cd8b3: geom: Allow "load" command for already loaded modules. (authored by mav).
geom: Allow "load" command for already loaded modules.
Mar 8 2022, 5:14 PM
mav added a reviewer for D34477: iscsi: Add support for booting without iscsid(8): jhb.
Mar 8 2022, 4:48 AM
mav added a reviewer for D34476: cxgbe: add handoff_sock method to the ICL proxy: jhb.
Mar 8 2022, 4:47 AM
mav added a reviewer for D34475: iscsi: Add handoff_sock method to icl_conn: jhb.
Mar 8 2022, 4:47 AM

Mar 7 2022

mav committed R10:dd7a5bc1e6d9: GEOM: Make G_F_CTLDUMP also dump result. (authored by mav).
GEOM: Make G_F_CTLDUMP also dump result.
Mar 7 2022, 7:42 PM
mav added inline comments to D34382: iscsi: Handle unmapped I/O requests..
Mar 7 2022, 6:51 PM
mav committed R10:2117cdd4b4eb: GEOM: Introduce gctl_add_param() API. (authored by mav).
GEOM: Introduce gctl_add_param() API.
Mar 7 2022, 4:13 PM
mav committed R10:01b9c48b5dec: GEOM: Skip copyin() for GCTL_PARAM_WR parameters. (authored by mav).
GEOM: Skip copyin() for GCTL_PARAM_WR parameters.
Mar 7 2022, 4:13 PM

Mar 5 2022

mav committed R10:25375b1415f8: ahci/siis/mvs: Fix panics after 3394d4239b. (authored by mav).
ahci/siis/mvs: Fix panics after 3394d4239b.
Mar 5 2022, 1:56 AM

Mar 4 2022

mav committed R10:56070dd2e4df: Improve timeout precision of pthread_cond_timedwait(). (authored by mav).
Improve timeout precision of pthread_cond_timedwait().
Mar 4 2022, 3:13 AM
mav closed D34163: Improve timeout precision of pthread_cond_timedwait().
Mar 4 2022, 3:13 AM

Mar 3 2022

mav accepted D34425: ocs_fc: Support persistent topology feature.

I have no objections. Just few thoughts inline. It would help if you describe it a bit more in description, so we would not have to guess what it should do.

Mar 3 2022, 7:02 PM
mav accepted D34423: ocs_fc: Do not respond to unsolicited NOP BLS command..

It makes some sense to me. I suppose other cases could be NOP and BA_ACC/BA_REJ, which do not require action if unsolicited. I just guess incoming BA_* for outgoing ABTS are handled somewhere else, if they reach the driver at all.

Mar 3 2022, 4:01 PM
mav added a comment to D34422: ocs_fc: Ignore flogi failure when the discovery is already done..

I don't think I can properly review this change without diving in deeply. It just looks weird to me first print "shutting down sport" but then "p2p winner, domain already attached\n" and post OCS_EVT_DOMAIN_ATTACH_OK.

Mar 3 2022, 3:16 PM