mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (171 w, 6 d)

Recent Activity

Yesterday

mav accepted D11779: Use nstosbt() instead of multiplying by SBT_1NS to avoid roundoff errors..

Looks good to me.

Mon, Sep 18, 2:00 AM
mav added a comment to D12396: Default ABD chunk size.

I'll second @mahrens worry about possible memory fragmentation. Plus FreeBSD kernel memory allocator does not even have the mentioned hooks to reallocate memory fighting it. Plus I still hope we can make GEOM vdev to use unmapped I/O to avoid extra buffer copying, which depends on blocks to be >= 4KB. I am not against making it loader tunable, but not ready to change the default or promote the tunable.

Mon, Sep 18, 1:46 AM · ZFS

Thu, Sep 14

mav committed rS323575: Add second entry to LUT on a link side in B2B mode..
Add second entry to LUT on a link side in B2B mode.
Thu, Sep 14, 4:51 AM

Wed, Sep 13

mav added a comment to D12355: MFV r323535: 8585 improve batching done in zil_commit().

I red it quite briefly, but I suspect that use of cv_timedwait_sbt() together gethrtime() may not work right due to rounding issues. As is was already mentioned by others, in most cases use of SBT_1NS is a direct request for troubles. My fault.

Wed, Sep 13, 4:58 PM

Mon, Sep 11

mav committed rS323456: MFC r323128: Increase negotiation polling period from 10ms to 100ms..
MFC r323128: Increase negotiation polling period from 10ms to 100ms.
Mon, Sep 11, 6:51 PM
mav committed rS323455: MFC r323126: Make NTB drivers report more info via NewBus methods..
MFC r323126: Make NTB drivers report more info via NewBus methods.
Mon, Sep 11, 6:51 PM
mav committed rS323454: MFC r323074: Clear doorbell bits after masking them before processing..
MFC r323074: Clear doorbell bits after masking them before processing.
Mon, Sep 11, 6:50 PM
mav committed rS323453: MFC r323032, r323053, r323058, r323059, r323084, r323114, r323127:.
MFC r323032, r323053, r323058, r323059, r323084, r323114, r323127:
Mon, Sep 11, 6:48 PM
mav committed rS323452: MFC r322981: Mask doorbells while processing them..
MFC r322981: Mask doorbells while processing them.
Mon, Sep 11, 6:32 PM
mav committed rS323451: MFC r322980: Fix fake interrupt when set doorbell is unmasked..
MFC r322980: Fix fake interrupt when set doorbell is unmasked.
Mon, Sep 11, 6:31 PM

Fri, Sep 8

mav accepted D12263: Remove spaces from CTL devices' default serial numbers.

I have no objections against the change. Though the whole concept of using so simple and repeatable LUN IDs is a request for troubles caused by conflicts.

Fri, Sep 8, 2:33 PM

Thu, Sep 7

mav added a comment to D12230: Make md(4) support GEOM::ident..

I don't see a point in reporting random ident strings. Those are normally useful to make things persistent, but random is not a way for that. May be I'd see it more useful to have it user-configurable.

Thu, Sep 7, 3:57 PM
mav added a comment to D12130: Greatly reduce interrupt latency caused by steal_idle.

At high context switching rates on systems with many cores stealing code does create significant CPU load. So I can believe that the critical section can indeed be an issue, so this way may be good to go. I personally thought about limiting maximal stealing distance based on some statistic factors, such as context switch rates, etc, since we shouldn't probably touch every CPU caches on every context switch -- its a dead end with growing number of CPUs, but haven't got far on it.

Thu, Sep 7, 3:50 PM
mav committed rS323265: MFC r323046: Make ntb_transport(4) ready receive early link events..
MFC r323046: Make ntb_transport(4) ready receive early link events.
Thu, Sep 7, 12:51 PM
mav committed rS323264: MFC r323047: Make ntb_set_ctx() always generate fake link event..
MFC r323047: Make ntb_set_ctx() always generate fake link event.
Thu, Sep 7, 12:50 PM

Sun, Sep 3

mav committed rS323137: MFC r323045: Fix flags field decoding in ACPI_NFIT_CONTROL_REGION..
MFC r323045: Fix flags field decoding in ACPI_NFIT_CONTROL_REGION.
Sun, Sep 3, 6:43 AM

Sat, Sep 2

mav committed rS323128: Increase negotiation polling period from 10ms to 100ms..
Increase negotiation polling period from 10ms to 100ms.
Sat, Sep 2, 1:29 PM
mav committed rS323127: Some NTB man pages polishing..
Some NTB man pages polishing.
Sat, Sep 2, 11:57 AM
mav committed rS323126: Make NTB drivers report more info via NewBus methods..
Make NTB drivers report more info via NewBus methods.
Sat, Sep 2, 11:56 AM

Fri, Sep 1

mav committed rS323114: Sync NTB options between amd64 and i386..
Sync NTB options between amd64 and i386.
Fri, Sep 1, 7:16 PM
mav committed rS323084: Link Interface has no Link Error registers..
Link Interface has no Link Error registers.
Fri, Sep 1, 9:48 AM

Thu, Aug 31

mav committed rS323074: Clear doorbell bits after masking them before processing..
Clear doorbell bits after masking them before processing.
Thu, Aug 31, 9:37 PM
mav committed rS323059: Remove unneeded pmap_change_attr() calls..
Remove unneeded pmap_change_attr() calls.
Thu, Aug 31, 5:02 PM
mav committed rS323058: Add/polish some defines..
Add/polish some defines.
Thu, Aug 31, 4:32 PM
mav committed rS323053: Fix port control for PEX 8749..
Fix port control for PEX 8749.
Thu, Aug 31, 1:41 PM
mav accepted D12144: add sysctls for arc shrinking and growing values.

I have no objections. I suppose that code came from Illumos, and there it is usual to modify kernel variables with debugger without sysctls. Adding sysctl would be a good FreeBSD alternative. If somebody wish to shoot his foot -- he should be able to do it.

Thu, Aug 31, 11:38 AM
mav added a comment to D12163: [RFC]: decrement needfree by the amount of evicted cache.

On quick look I do see valid point in this patch: needfree in Illumos indeed reduced back as soon as allocation that increased it succeeds, but it doesn't happen in our case. But I am quite busy now to look deeper from all possible sides.

Thu, Aug 31, 11:28 AM
mav committed rS323047: Make ntb_set_ctx() always generate fake link event..
Make ntb_set_ctx() always generate fake link event.
Thu, Aug 31, 10:59 AM
mav committed rS323046: Make ntb_transport(4) ready receive early link events..
Make ntb_transport(4) ready receive early link events.
Thu, Aug 31, 10:53 AM
mav committed rS323045: Fix flags field decoding in ACPI_NFIT_CONTROL_REGION..
Fix flags field decoding in ACPI_NFIT_CONTROL_REGION.
Thu, Aug 31, 9:08 AM

Wed, Aug 30

mav committed rS323032: Add NTB driver for PLX/Avago/Broadcom PCIe switches..
Add NTB driver for PLX/Avago/Broadcom PCIe switches.
Wed, Aug 30, 9:16 PM
mav committed rS323013: MFC r322821: Add missing restart_queue initialization..
MFC r322821: Add missing restart_queue initialization.
Wed, Aug 30, 6:28 AM

Tue, Aug 29

mav committed rS322996: MFC r322802: Fix off-by-one error when parsing SRAT table..
MFC r322802: Fix off-by-one error when parsing SRAT table.
Tue, Aug 29, 7:01 AM

Mon, Aug 28

mav committed rS322981: Mask doorbells while processing them..
Mask doorbells while processing them.
Mon, Aug 28, 8:00 PM
mav committed rS322980: Fix fake interrupt when set doorbell is unmasked..
Fix fake interrupt when set doorbell is unmasked.
Mon, Aug 28, 7:53 PM

Wed, Aug 23

mav committed rS322821: Add missing restart_queue initialization..
Add missing restart_queue initialization.
Wed, Aug 23, 7:00 PM

Tue, Aug 22

mav committed rS322802: Fix off-by-one error when parsing SRAT table..
Fix off-by-one error when parsing SRAT table.
Tue, Aug 22, 7:56 PM

Aug 16 2017

mav committed rS322573: MFC r322309, r322316:.
MFC r322309, r322316:
Aug 16 2017, 10:30 AM
mav committed rS322572: MFC r322308: Add new Intel Lewisburg and Union Point chipset PCI IDs..
MFC r322308: Add new Intel Lewisburg and Union Point chipset PCI IDs.
Aug 16 2017, 10:28 AM

Aug 14 2017

mav added inline comments to D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 7:05 PM
mav added inline comments to D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 6:51 PM
mav added inline comments to D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 6:36 PM
mav added a comment to D12020: LibAliasSetMode error was not detected correctly.
In D12020#249291, @mav wrote:

I have another idea. Since this function returns resulted flags, it may be possible to make it return as disabled function which has failed to enable. In such case it would both stay compatible with old code and fixed the compilation errors like that, but slightly complicated check for enable error (if somebody really want it).

Ah, you mean to indicate error by returning with the flag not set in the return flags? Yeah, the error check is a little ugly, but I think that works.

Aug 14 2017, 5:45 PM
mav added a comment to D12020: LibAliasSetMode error was not detected correctly.

Hmm. This procedure is exported in userspace libalias, is it okay to change its signature like that?

Aug 14 2017, 5:07 PM
mav added a comment to D12020: LibAliasSetMode error was not detected correctly.

I don't think this is a correct solution. It looks more like a workaround. Correct IMHO would be to make LibAliasSetMode() return int instead of unsigned it.

Aug 14 2017, 12:35 PM

Aug 12 2017

mav committed rS322423: MFC r322302: Do not loose CCB flags after r320493..
MFC r322302: Do not loose CCB flags after r320493.
Aug 12 2017, 10:22 AM

Aug 10 2017

mav committed rS322351: Add two NFIT fields missed in r321298..
Add two NFIT fields missed in r321298.
Aug 10 2017, 10:59 AM

Aug 9 2017

mav committed rS322316: Missing remanant of 322309..
Missing remanant of 322309.
Aug 9 2017, 1:46 PM
mav committed rS322309: Use "Ibex Peak" codename for "5 Series/3400 Series" chipsets..
Use "Ibex Peak" codename for "5 Series/3400 Series" chipsets.
Aug 9 2017, 12:21 PM
mav committed rS322308: Add new Intel Lewisburg and Union Point chipset PCI IDs..
Add new Intel Lewisburg and Union Point chipset PCI IDs.
Aug 9 2017, 12:03 PM
mav committed rS322302: Do not loose CCB flags after r320493..
Do not loose CCB flags after r320493.
Aug 9 2017, 9:13 AM

Aug 8 2017

mav closed D11904: Fix few issues of LinuxKPI workqueue by committing rS322272: Fix few issues of LinuxKPI workqueue..
Aug 8 2017, 7:36 PM
mav committed rS322272: Fix few issues of LinuxKPI workqueue..
Fix few issues of LinuxKPI workqueue.
Aug 8 2017, 7:36 PM
mav added a comment to D11920: zfsd(8): Close a race condition when onlining a disk paritition.

You haven't included zpool_read_all_labels method into the patch.

Aug 8 2017, 6:05 PM

Aug 7 2017

mav added inline comments to D11904: Fix few issues of LinuxKPI workqueue.
Aug 7 2017, 3:25 PM
mav added inline comments to D11904: Fix few issues of LinuxKPI workqueue.
Aug 7 2017, 2:40 PM
mav committed rS322169: Fix hrtimer_active() in case of cancellation..
Fix hrtimer_active() in case of cancellation.
Aug 7 2017, 2:34 PM
mav closed D11900: Fix hrtimer_active() in case of cancelllation. by committing rS322169: Fix hrtimer_active() in case of cancellation..
Aug 7 2017, 2:34 PM
mav committed rS322138: MFC r321794: Improve FHA locality control for NFS read/write requests..
MFC r321794: Improve FHA locality control for NFS read/write requests.
Aug 7 2017, 7:40 AM
mav committed rS322137: MFC r321794: Improve FHA locality control for NFS read/write requests..
MFC r321794: Improve FHA locality control for NFS read/write requests.
Aug 7 2017, 7:03 AM

Aug 6 2017

mav created D11904: Fix few issues of LinuxKPI workqueue.
Aug 6 2017, 11:11 PM
mav added inline comments to D11900: Fix hrtimer_active() in case of cancelllation..
Aug 6 2017, 12:15 PM
mav updated the diff for D11900: Fix hrtimer_active() in case of cancelllation..
Aug 6 2017, 12:12 PM
mav created D11900: Fix hrtimer_active() in case of cancelllation..
Aug 6 2017, 11:06 AM
mav committed rS322116: MFC r321720, r321856: Attach ichwd(4) only to ISA bus of the LPC bridge..
MFC r321720, r321856: Attach ichwd(4) only to ISA bus of the LPC bridge.
Aug 6 2017, 8:15 AM
mav committed rS322115: MFC r321720, r321856: Attach ichwd(4) only to ISA bus of the LPC bridge..
MFC r321720, r321856: Attach ichwd(4) only to ISA bus of the LPC bridge.
Aug 6 2017, 8:15 AM

Aug 5 2017

mav committed rS322081: MFC r321685: Fix IORDY bits definition..
MFC r321685: Fix IORDY bits definition.
Aug 5 2017, 8:38 AM
mav committed rS322080: MFC r321685: Fix IORDY bits definition..
MFC r321685: Fix IORDY bits definition.
Aug 5 2017, 8:37 AM
mav committed rS322079: MFC r321921: Add compat shim part missed at r305197..
MFC r321921: Add compat shim part missed at r305197.
Aug 5 2017, 8:36 AM
mav committed rS322078: MFC r321921: Add compat shim part missed at r305197..
MFC r321921: Add compat shim part missed at r305197.
Aug 5 2017, 8:35 AM

Aug 3 2017

mav added a comment to D11620: XPT_TIMEOUT for CAM framework for scheduling CCB completion entirely in XPT layer.

I think this functionality may be redundant. There is already support for freeze release timeout, which allows to execute some CCBs after specified amount of time.

Aug 3 2017, 7:27 AM
mav committed rS321976: MFC r321606: adaasync(): Set ADA_STATE_WCACHE based on ADA_FLAG_CAN_WCACHE.
MFC r321606: adaasync(): Set ADA_STATE_WCACHE based on ADA_FLAG_CAN_WCACHE
Aug 3 2017, 7:20 AM
mav committed rS321975: MFC r321620: Fix singular/plural "users" output..
MFC r321620: Fix singular/plural "users" output.
Aug 3 2017, 7:17 AM

Aug 2 2017

mav committed rS321929: MFC r320730: Report device descr in addition to ident..
MFC r320730: Report device descr in addition to ident.
Aug 2 2017, 2:46 PM
mav committed rS321928: MFC r320683: Add naive benchmark for SSDs in ZFS SLOG role..
MFC r320683: Add naive benchmark for SSDs in ZFS SLOG role.
Aug 2 2017, 2:45 PM
mav committed rS321927: MFC r320555, r320576 (by allanjude):.
MFC r320555, r320576 (by allanjude):
Aug 2 2017, 2:43 PM
mav committed rS321921: Add compat shim part missed at r305197..
Add compat shim part missed at r305197.
Aug 2 2017, 10:33 AM

Aug 1 2017

mav committed rS321872: MFC r320495: Allow status aggregation for ramdisk reads..
MFC r320495: Allow status aggregation for ramdisk reads.
Aug 1 2017, 1:08 PM
mav committed rS321871: MFC r320493: Unify INOT/ATIO setup..
MFC r320493: Unify INOT/ATIO setup.
Aug 1 2017, 1:07 PM
mav committed rS321870: MFC r320604, r320865:.
MFC r320604, r320865:
Aug 1 2017, 1:03 PM
mav committed rS321869: MFC r320575: Move comment respecting previous commit..
MFC r320575: Move comment respecting previous commit.
Aug 1 2017, 1:00 PM
mav committed rS321868: MFC r320574: Slightly unify SNS requests for post- and pre-24xx..
MFC r320574: Slightly unify SNS requests for post- and pre-24xx.
Aug 1 2017, 12:59 PM
mav committed rS321867: MFC r320492: Polish target_id/target_lun setting for ATIOs/INOTs..
MFC r320492: Polish target_id/target_lun setting for ATIOs/INOTs.
Aug 1 2017, 12:58 PM
mav committed rS321856: Add explicit check for PCI bus to r321720..
Add explicit check for PCI bus to r321720.
Aug 1 2017, 9:22 AM

Jul 31 2017

mav committed rS321794: Improve FHA locality control for NFS read/write requests..
Improve FHA locality control for NFS read/write requests.
Jul 31 2017, 3:23 PM

Jul 30 2017

mav committed rS321720: Attach ichwd(4) only to ISA bus of the LPC bridge..
Attach ichwd(4) only to ISA bus of the LPC bridge.
Jul 30 2017, 3:19 PM

Jul 29 2017

mav committed rS321685: Fix IORDY bits definition..
Fix IORDY bits definition.
Jul 29 2017, 1:54 PM
mav added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..
In D11423#243919, @mav wrote:

As of now, we are not supporting live role change.

It should better be supported. I've tried to enable target mode, but found expected problems: If target mode enabled via device hints, it won't be able to reply to initiators until target mode is enabled in CTL, leading to command timeouts on initiators. Enabling target in CTL after makes it work, but it seems CTL doesn't receive or drops AC_CONTRACT notifications, as result of what ctladm portlist -i does not report connected initiators until they disconnect and reconnect.

I think if we support the live role change also this issue will happen. As enabling target mode in CTL should be done in any case. So, I think we need to debug why CTL doesn't receive or drops AC_CONTRACT notifications.
Please correct me if I am missing any thing.

Jul 29 2017, 12:40 PM
mav committed rS321683: MFC r314504 (by tsoome):.
MFC r314504 (by tsoome):
Jul 29 2017, 11:28 AM
mav committed rS321680: MFC r307865 (by tsoome): loader should boot pre-feature flags pools..
MFC r307865 (by tsoome): loader should boot pre-feature flags pools.
Jul 29 2017, 9:56 AM

Jul 28 2017

mav added inline comments to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..
Jul 28 2017, 9:49 AM
mav added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

As of now, we are not supporting live role change.

Jul 28 2017, 8:51 AM

Jul 27 2017

mav committed rS321620: Fix singular/plural "users" output..
Fix singular/plural "users" output.
Jul 27 2017, 2:35 PM
mav committed rS321615: MFC r320152 (by avg): fstyp: move sys/ include path after zfs include paths.
MFC r320152 (by avg): fstyp: move sys/ include path after zfs include paths
Jul 27 2017, 10:52 AM
mav committed rS321614: MFC r320352: zfs: port vdev_file part of illumos change 3306.
MFC r320352: zfs: port vdev_file part of illumos change 3306
Jul 27 2017, 10:31 AM
mav committed rS321613: MFC r320239: MFV r319950:.
MFC r320239: MFV r319950:
Jul 27 2017, 10:29 AM
mav committed rS321612: MFC r320238: MFV r319742: 8056 zfs send size estimate is inaccurate for some….
MFC r320238: MFV r319742: 8056 zfs send size estimate is inaccurate for some…
Jul 27 2017, 10:28 AM
mav committed rS321611: MFC r320237: MFV r318947: 7578 Fix/improve some aspects of ZIL writing..
MFC r320237: MFV r318947: 7578 Fix/improve some aspects of ZIL writing.
Jul 27 2017, 10:27 AM
mav committed rS321610: MFC r320156, r320185, r320186, r320262, r320452, r321111:.
MFC r320156, r320185, r320186, r320262, r320452, r321111:
Jul 27 2017, 10:25 AM
mav committed rS321609: MFC r320153: revert r315852 which introduced zio_buf_alloc_nowait for use.
MFC r320153: revert r315852 which introduced zio_buf_alloc_nowait for use
Jul 27 2017, 10:19 AM