mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (215 w, 4 d)

Recent Activity

Tue, Jul 17

mav added a comment to D16196: OCS_FC: Wait for a specific period of time prior to telling the OS about lost device..

The general motivation is good for me. Very alike approach is used in isp(4) driver, may be just for some additional reasons. But unless I missed something, I think this patch of yours is incomplete -- it implements the translation table for initiator role, but not for target. If the HBA is capable of playing both roles same time, there will be a mess in CAM and CTL. isp(4) driver originally also had the same issue, but I fixed it there few years ago, and now target and initiator roles may successfully coexist.

Tue, Jul 17, 4:27 PM

Mon, Jul 16

mav committed rS336327: MFC r335874: Cut currdev dev and path fields for ZFS on the last colon..
MFC r335874: Cut currdev dev and path fields for ZFS on the last colon.
Mon, Jul 16, 2:49 AM

Mon, Jul 9

mav accepted D16060: Maintenance's commit of Microsemi smartpqi driver.

I have no objections.

Mon, Jul 9, 8:18 PM · Src Committers

Fri, Jul 6

mav added a comment to D16161: Improve bhyve exit(3) error code..

Thank you! Looks good to me, aside of mentioned by Rod err()/errx() issues. All perror()'s should probably turn into err() instead of errx().

Fri, Jul 6, 5:28 PM

Tue, Jul 3

mav accepted D15886: Expose ZFS quotas over nfs.

Looks good to me.

Tue, Jul 3, 7:52 PM
mav added a comment to D16060: Maintenance's commit of Microsemi smartpqi driver.

On a quick look I spotted number of style issues you may fix.

Tue, Jul 3, 5:03 PM · Src Committers

Mon, Jul 2

mav committed rS335874: Cut currdev dev and path fields for ZFS on the last colon..
Cut currdev dev and path fields for ZFS on the last colon.
Mon, Jul 2, 8:56 PM
mav closed D16068: Colons in boot environment name.
Mon, Jul 2, 8:56 PM
mav accepted D16087: fix a case where the kernel nfsd threads do not terminate.
Mon, Jul 2, 2:29 PM

Fri, Jun 29

mav created D16068: Colons in boot environment name.
Fri, Jun 29, 7:08 PM

Jun 14 2018

mav committed rS335167: Record MFC r331046 mergeinfo, missed in r335150..
Record MFC r331046 mergeinfo, missed in r335150.
Jun 14 2018, 6:33 PM
mav committed rS335166: MFC r325794, r325838 (by imp):.
MFC r325794, r325838 (by imp):
Jun 14 2018, 6:19 PM
mav committed rS335155: MFC r333180: Fix LOR between controller and queue locks..
MFC r333180: Fix LOR between controller and queue locks.
Jun 14 2018, 5:09 PM
mav committed rS335153: MFC r333130: Improve nvme(4) attach/detach sequences..
MFC r333130: Improve nvme(4) attach/detach sequences.
Jun 14 2018, 5:06 PM
mav committed rS335152: MFC r333127: Fix use-after-free in nvme_qpair_destroy()..
MFC r333127: Fix use-after-free in nvme_qpair_destroy().
Jun 14 2018, 5:03 PM
mav committed rS335151: MFC r332897 (by imp), r333123:.
MFC r332897 (by imp), r333123:
Jun 14 2018, 4:58 PM
mav committed rS335150: MFC r331046 (by imp): Try polling the qpairs on timeout..
MFC r331046 (by imp): Try polling the qpairs on timeout.
Jun 14 2018, 4:51 PM
mav committed rS335149: MFC r330954, r330955 (by imp):.
MFC r330954, r330955 (by imp):
Jun 14 2018, 4:19 PM
mav committed rS335143: MFC r330953 (by imp): Don't make the namespace devices eternal..
MFC r330953 (by imp): Don't make the namespace devices eternal.
Jun 14 2018, 3:02 PM
mav committed rS335142: MFC r328089 (by imp):.
MFC r328089 (by imp):
Jun 14 2018, 2:59 PM
mav committed rS335139: MFC r313954 (by imp): Remove obsolete comment after prior rev..
MFC r313954 (by imp): Remove obsolete comment after prior rev.
Jun 14 2018, 2:50 PM
mav committed rS335138: MFC r311351 (by rpokala):.
MFC r311351 (by rpokala):
Jun 14 2018, 2:46 PM
mav committed rS335137: MFC r311350 (by rpokala):.
MFC r311350 (by rpokala):
Jun 14 2018, 2:45 PM

Jun 12 2018

mav added a comment to D15768: Cosmetic style(9) fixes space vs tab..

I like the space cleanup, thanks, and SPDX part is also fine. But I also agree that mixing together unrelated changes is not a very good idea. While in this particular case I would personally not create much churn about it (much worse when formatting changes are mixed with code changes, which is not really a case here), once other people complained, I think Marcelo you could faster do the requested separation rather then argue indefinitely from weak position.

Jun 12 2018, 2:20 PM

Jun 8 2018

mav accepted D15562: ZFS sorted scans.
Jun 8 2018, 7:59 PM · ZFS

Jun 6 2018

mav accepted D15342: Break recursion involving getnewvnode and zfs_rmnode.

Looks good to me. Thanks you. I agree with avg@ that forward declaration of the function of few lines is not very useful.

Jun 6 2018, 4:01 PM

May 31 2018

mav added a comment to D15592: Avoid completing non-dump I/O requests after a panic..

Ah, sorry, I've mixed biodone() with bufdone(). Then it is less bad idea.

May 31 2018, 3:02 AM
mav added a comment to D15592: Avoid completing non-dump I/O requests after a panic..

I can't say that I like it, but it makes sense to me.

May 31 2018, 2:33 AM

May 29 2018

mav added a comment to D15446: AES CCM-CBC cryptography code.
In D15446#329261, @jmg wrote:

Even if I review it, a professional cryptographer needs to be paid to review the code before it is committed/enabled for general use.

May 29 2018, 3:13 PM

May 26 2018

mav added a comment to D15562: ZFS sorted scans.

I don't think it is a very good idea to merge two pretty much independent ZoL commits into one FreeBSD commit. It could have sense if the first one would be significantly broken and second fixed the issue, but priority upgrade implemented in second commit is only a performance optimization, mostly unrelated to scrub even, in which case having it separate would make commit history cleaner for later comparison.

May 26 2018, 3:03 AM · ZFS

May 25 2018

mav accepted D15552: add support for console resuming, implement it for uart, use on x86.

Makes sense to me.

May 25 2018, 3:30 PM
mav committed rS334200: Refactor NVMe CAM integration..
Refactor NVMe CAM integration.
May 25 2018, 3:34 AM

May 24 2018

mav added a comment to D15517: We can't release the refcount outside of the periph lock..

As I have told, I have no objections. I still don't like the global counters, since they mean we can never remove respective lock or at least atomics, but for now I can live with that. It is better then broken code.

May 24 2018, 2:01 PM

May 23 2018

mav committed rS334099: Add ready polling after PHY reset on VIA SATA controllers..
Add ready polling after PHY reset on VIA SATA controllers.
May 23 2018, 3:23 PM

May 22 2018

mav accepted D15517: We can't release the refcount outside of the periph lock..

Looks good to me. The only rough edge I see is that outstanding_cmds is used only for the newly added assertion, that is why it was so broken before this and nobody cared.

May 22 2018, 6:11 PM

May 21 2018

mav added a comment to D15446: AES CCM-CBC cryptography code.

Great to see it! I did only first on-surface look so far, so comments are mostly cosmetic.

May 21 2018, 4:39 PM

May 17 2018

mav accepted D15456: change ffs_blkfree() trim to not bypass geom_vfs, avoids panics.

Good catch.

May 17 2018, 12:33 AM
mav accepted D15453: Make reference counting more robust.

It is OK to me. I still don't think protection against GEOM bugs belongs here, but so be it, since we any way have and acquire lock to protect that.

May 17 2018, 12:31 AM

May 16 2018

mav added a comment to D15413: stop and restart kernel event timers in the suspend / resume cycle.

I agree with John that this is better then nothing, but the proper way I think would be: first suspend third-party devices, then stop clock, and then suspend timer devices, resume -- in opposite order.

May 16 2018, 12:11 AM

May 14 2018

mav accepted D15422: calibrate lapic timer in native_lapic_setup.

The motivation for postponing the calibration was to not spend whole second on boot in cases when LAPIC timer is not used. Though that should be much less frequent lately.

May 14 2018, 3:33 PM

May 9 2018

mav committed rS333415: MFC r333158:.
MFC r333158:
May 9 2018, 3:22 PM

May 7 2018

mav committed rS333322: Keep CARP state as INIT when net.inet.carp.allow=0..
Keep CARP state as INIT when net.inet.carp.allow=0.
May 7 2018, 2:45 PM
mav closed D14477: Keep CARP state as INIT when net.inet.carp.allow=0.
May 7 2018, 2:45 PM
mav added a comment to D15305: hpet_suspend: reset configuration of all timers.

Something made me to comment out hpet_disable() call on suspend 8 years ago. Wish I remember what was that.

May 7 2018, 1:45 PM

May 5 2018

mav committed rS333275: Add NVMe Namespace Management support to nvmecontrol(8)..
Add NVMe Namespace Management support to nvmecontrol(8).
May 5 2018, 8:08 PM
mav closed D11399: nvme: Add namespace mgmt and attachment support..
May 5 2018, 8:08 PM

May 4 2018

mav accepted D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Some more man/help tunings and so be it.

May 4 2018, 6:19 PM
mav accepted D15276: Add virtio-scsi block storage backend support.

It looks good enough for me. I see some rough edges in details of SCSI interface implementation (for example, there seem to be a race window between regular and task management requests processing, submitted via different queues), but those may be addressed/improved later.

May 4 2018, 3:48 PM
mav accepted D15291: for (generic) bus suspend, detach and shutdown iterate children in reverse order.

This looks like a hack, but I have no real objections.

May 4 2018, 2:20 PM

May 2 2018

mav committed rS333180: Fix LOR between controller and queue locks..
Fix LOR between controller and queue locks.
May 2 2018, 8:13 PM
mav committed rS333158: Clean enclosure_table when resetting num_enc_table_entries to zero..
Clean enclosure_table when resetting num_enc_table_entries to zero.
May 2 2018, 2:41 AM

Apr 30 2018

mav committed rS333130: Improve nvme(4) attach/detach sequences..
Improve nvme(4) attach/detach sequences.
Apr 30 2018, 11:06 PM
mav committed rS333127: Fix use-after-free in nvme_qpair_destroy()..
Fix use-after-free in nvme_qpair_destroy().
Apr 30 2018, 9:28 PM
mav committed rS333123: Set si_drv1 for nvmeXnsY in a new race-free way..
Set si_drv1 for nvmeXnsY in a new race-free way.
Apr 30 2018, 7:21 PM

Apr 25 2018

mav requested changes to D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Looks mostly fine aside of commented places.

Apr 25 2018, 12:40 AM

Apr 19 2018

mav committed rS332785: MFC r332523: 9433 Fix ARC hit rate.
MFC r332523: 9433 Fix ARC hit rate
Apr 19 2018, 5:56 PM
mav committed rS332779: Release memory resource on cuda driver attach failure..
Release memory resource on cuda driver attach failure.
Apr 19 2018, 3:29 PM

Apr 18 2018

mav committed rS332739: MFC r332641: MFV man pages update from r329502:.
MFC r332641: MFV man pages update from r329502:
Apr 18 2018, 8:32 PM

Apr 17 2018

mav committed rS332641: MFV man pages update from r329502: 7614 zfs device evacuation/removal..
MFV man pages update from r329502: 7614 zfs device evacuation/removal.
Apr 17 2018, 2:34 AM

Apr 16 2018

mav committed rS332554: MFC r331950: 9434 Speculative prefetch is blocked by device removal code..
MFC r331950: 9434 Speculative prefetch is blocked by device removal code.
Apr 16 2018, 4:17 AM
mav committed rS332553: MFC r331713: MFV r331712:.
MFC r331713: MFV r331712:
Apr 16 2018, 4:16 AM
mav committed rS332552: MFC r331711: MFV 331710:.
MFC r331711: MFV 331710:
Apr 16 2018, 4:15 AM
mav committed rS332551: MFC r331709: MFV r331708:.
MFC r331709: MFV r331708:
Apr 16 2018, 4:15 AM
mav committed rS332550: MFC r331707: MFV r331706:.
MFC r331707: MFV r331706:
Apr 16 2018, 4:14 AM
mav committed rS332549: MFC r331705: MFV 331704:.
MFC r331705: MFV 331704:
Apr 16 2018, 4:13 AM
mav committed rS332548: MFC r331703: MFV 331702:.
MFC r331703: MFV 331702:
Apr 16 2018, 4:12 AM
mav committed rS332547: MFC r331701: MFV r331695, 331700: 9166 zfs storage pool checkpoint.
MFC r331701: MFV r331695, 331700: 9166 zfs storage pool checkpoint
Apr 16 2018, 4:11 AM
mav committed rS332545: MFC r331699: Partial MFV r329753:.
MFC r331699: Partial MFV r329753:
Apr 16 2018, 3:58 AM
mav committed rS332544: MFC r331420 (by avg): zfs: fix mismatch between format specifier and type.
MFC r331420 (by avg): zfs: fix mismatch between format specifier and type
Apr 16 2018, 3:56 AM
mav committed rS332543: MFC r331414: Reduce struct aggsum_bucket padding to fit into one cache line..
MFC r331414: Reduce struct aggsum_bucket padding to fit into one cache line.
Apr 16 2018, 3:55 AM
mav committed rS332542: MFC r331408: MFV r331407: 9213 zfs: sytem typo.
MFC r331408: MFV r331407: 9213 zfs: sytem typo
Apr 16 2018, 3:54 AM
mav committed rS332541: MFC r331406: MFV r331405: 9084 spa_*_ashift must ignore spare devices.
MFC r331406: MFV r331405: 9084 spa_*_ashift must ignore spare devices
Apr 16 2018, 3:53 AM
mav committed rS332540: MFC r331404: MFV r331400:.
MFC r331404: MFV r331400:
Apr 16 2018, 3:53 AM
mav committed rS332539: MFC r329808: MFV r329807:.
MFC r329808: MFV r329807:
Apr 16 2018, 3:49 AM
mav committed rS332538: MFC r329805: MFV r329803:.
MFC r329805: MFV r329803:
Apr 16 2018, 3:48 AM
mav committed rS332537: MFC r329802: MFV r329799, r329800:.
MFC r329802: MFV r329799, r329800:
Apr 16 2018, 3:48 AM
mav committed rS332536: MFC r329798: MFV r329793, r329795:.
MFC r329798: MFV r329793, r329795:
Apr 16 2018, 3:45 AM
mav committed rS332535: MFC r329783: 8942 zfs promote .../%recv should be an error.
MFC r329783: 8942 zfs promote .../%recv should be an error
Apr 16 2018, 3:44 AM
mav committed rS332534: MFC r329777: MFV r329776:.
MFC r329777: MFV r329776:
Apr 16 2018, 3:43 AM
mav committed rS332533: MFC r329775: MFV r329774:.
MFC r329775: MFV r329774:
Apr 16 2018, 3:43 AM
mav committed rS332532: MFC r329771: MFV r329770: 9035 zfs: this statement may fall through.
MFC r329771: MFV r329770: 9035 zfs: this statement may fall through
Apr 16 2018, 3:42 AM
mav committed rS332531: MFC r329769: MFV r329766: 8962 zdb should work on non-idle pools.
MFC r329769: MFV r329766: 8962 zdb should work on non-idle pools
Apr 16 2018, 3:41 AM
mav committed rS332530: MFC r329765: MFV r329762: 8961 SPA load/import should tell us why it failed.
MFC r329765: MFV r329762: 8961 SPA load/import should tell us why it failed
Apr 16 2018, 3:40 AM
mav committed rS332529: MFC r329761: MFV r329760: 7638 Refactor spa_load_impl into several functions.
MFC r329761: MFV r329760: 7638 Refactor spa_load_impl into several functions
Apr 16 2018, 3:39 AM
mav committed rS332528: MFC r329759:.
MFC r329759:
Apr 16 2018, 3:39 AM
mav committed rS332526: MFC r329755: MFV r329753:.
MFC r329755: MFV r329753:
Apr 16 2018, 3:35 AM
mav committed rS332525: MFC r329732: MFV r329502: 7614 zfs device evacuation/removal.
MFC r329732: MFV r329502: 7614 zfs device evacuation/removal
Apr 16 2018, 3:33 AM
mav committed rS332524: MFC r307317: MFV r307313:.
MFC r307317: MFV r307313:
Apr 16 2018, 3:15 AM
mav committed rS332523: 9433 Fix ARC hit rate.
9433 Fix ARC hit rate
Apr 16 2018, 12:55 AM

Apr 13 2018

mav committed rS332461: MFC r332145: Do not fail devices just for errors in descriptor format..
MFC r332145: Do not fail devices just for errors in descriptor format.
Apr 13 2018, 12:30 AM

Apr 11 2018

mav added a comment to D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.

Is this API and device classification exist somewhere else, or being just designed? Differentiation between STRIPE, MIRROR and RAID sound somewhat odd to me, same as between SPINNING and CDROM. Besides it duplicates "GEOM::rotation_rate" attribute, we already have and use in some places (though obviously it is not passed through UFS).

Apr 11 2018, 7:20 PM

Apr 9 2018

mav added a comment to D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

I am not closely familiar with WITNESS, so just a feeling: the long lists of blessed locks and their combinations promises high chances for them to be forgotten on following ZFS updates. At very list it would be good to document how those new mechanisms should be used.

Apr 9 2018, 5:07 PM

Apr 6 2018

mav committed rS332145: Do not fail devices just for errors in descriptor format..
Do not fail devices just for errors in descriptor format.
Apr 6 2018, 7:48 PM

Apr 4 2018

mav committed rS332041: Restore Sean Eric Fagan (sef) src commit bit..
Restore Sean Eric Fagan (sef) src commit bit.
Apr 4 2018, 6:27 PM

Apr 3 2018

mav committed rS331950: 9434 Speculative prefetch is blocked by device removal code..
9434 Speculative prefetch is blocked by device removal code.
Apr 3 2018, 9:16 PM
mav committed rS331903: MFC r331228: Update mpr(4) driver from v15 to v18 from Broadcom site..
MFC r331228: Update mpr(4) driver from v15 to v18 from Broadcom site.
Apr 3 2018, 2:29 AM

Apr 1 2018

mav committed rS331870: MFC r330292: Update QLogic ISP 24xx/25xx chips firmware to 8.07.00..
MFC r330292: Update QLogic ISP 24xx/25xx chips firmware to 8.07.00.
Apr 1 2018, 11:00 PM

Mar 31 2018

mav accepted D14913: Switch to NetBSD's implementation of El Torito EFI handling.
Mar 31 2018, 2:19 PM

Mar 29 2018

mav committed rS331721: MFC r329738: MFV r329736: 8969 Cannot boot from RAIDZ with parity > 1.
MFC r329738: MFV r329736: 8969 Cannot boot from RAIDZ with parity > 1
Mar 29 2018, 2:25 AM

Mar 28 2018

mav committed rS331713: MFV r331712:.
MFV r331712:
Mar 28 2018, 11:17 PM