mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (194 w, 2 d)

Recent Activity

Today

mav committed rS329847: MFC r329091: Add sysctls for dnode block and indirect block shifts..
MFC r329091: Add sysctls for dnode block and indirect block shifts.
Fri, Feb 23, 12:38 AM

Yesterday

mav committed rS329808: MFV r329807:.
MFV r329807:
Thu, Feb 22, 4:02 AM
mav committed rS329807: 8940 Sending an intra-pool resumable send stream may result in EXDEV.
8940 Sending an intra-pool resumable send stream may result in EXDEV
Thu, Feb 22, 4:01 AM
mav committed rS329805: MFV r329803:.
MFV r329803:
Thu, Feb 22, 3:55 AM
mav committed rS329803: 9080 recursive enter of vdev_indirect_rwlock from vdev_indirect_remap().
9080 recursive enter of vdev_indirect_rwlock from vdev_indirect_remap()
Thu, Feb 22, 3:52 AM
mav committed rS329802: MFV r329799, r329800:.
MFV r329799, r329800:
Thu, Feb 22, 3:49 AM
mav committed rS329800: Missed pieces of r329799..
Missed pieces of r329799.
Thu, Feb 22, 3:23 AM
mav committed rS329799: 9079 race condition in starting and ending condesing thread for indirect vdevs.
9079 race condition in starting and ending condesing thread for indirect vdevs
Thu, Feb 22, 3:22 AM
mav committed rS329798: MFV r329793, r329795:.
MFV r329793, r329795:
Thu, Feb 22, 3:15 AM
mav committed rS329795: r329793 | mav | 2018-02-22 04:21:03 +0200 (чт, 22 февр. 2018) | 58 lines.
r329793 | mav | 2018-02-22 04:21:03 +0200 (чт, 22 февр. 2018) | 58 lines
Thu, Feb 22, 2:25 AM
mav committed rS329793: 9075 Improve ZFS pool import/load process and corrupted pool recovery.
9075 Improve ZFS pool import/load process and corrupted pool recovery
Thu, Feb 22, 2:21 AM
mav committed rS329783: 8942 zfs promote .../%recv should be an error.
8942 zfs promote .../%recv should be an error
Thu, Feb 22, 1:42 AM
mav committed rS329781: 8942 zfs promote .../%recv should be an error.
8942 zfs promote .../%recv should be an error
Thu, Feb 22, 1:30 AM
mav committed rS329778: 8941 zpool add: assertion failed in get_replication() with nested interior VDEVs.
8941 zpool add: assertion failed in get_replication() with nested interior VDEVs
Thu, Feb 22, 1:17 AM
mav committed rS329777: MFV r329776: 8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa).
MFV r329776: 8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa)
Thu, Feb 22, 1:01 AM
mav committed rS329776: 8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa).
8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa)
Thu, Feb 22, 1:00 AM
mav committed rS329775: MFV r329774:.
MFV r329774:
Thu, Feb 22, 12:55 AM
mav committed rS329774: 8408 dsl_props_set_sync_impl() does not handle nested nvlists correctly.
8408 dsl_props_set_sync_impl() does not handle nested nvlists correctly
Thu, Feb 22, 12:54 AM
mav committed rS329772: 9036 zfs: duplicate 'const' declaration specifier.
9036 zfs: duplicate 'const' declaration specifier
Thu, Feb 22, 12:49 AM
mav committed rS329771: MFV r329770: 9035 zfs: this statement may fall through.
MFV r329770: 9035 zfs: this statement may fall through
Thu, Feb 22, 12:47 AM
mav committed rS329770: 9035 zfs: this statement may fall through.
9035 zfs: this statement may fall through
Thu, Feb 22, 12:46 AM
mav committed rS329769: MFV r329766: 8962 zdb should work on non-idle pools.
MFV r329766: 8962 zdb should work on non-idle pools
Thu, Feb 22, 12:42 AM
mav committed rS329766: 8962 zdb should work on non-idle pools.
8962 zdb should work on non-idle pools
Thu, Feb 22, 12:09 AM
mav committed rS329765: MFV r329762: 8961 SPA load/import should tell us why it failed.
MFV r329762: 8961 SPA load/import should tell us why it failed
Thu, Feb 22, 12:03 AM

Wed, Feb 21

mav committed rS329762: 8961 SPA load/import should tell us why it failed.
8961 SPA load/import should tell us why it failed
Wed, Feb 21, 11:42 PM
mav committed rS329761: MFV r329760: 7638 Refactor spa_load_impl into several functions.
MFV r329760: 7638 Refactor spa_load_impl into several functions
Wed, Feb 21, 11:38 PM
mav committed rS329760: 7638 Refactor spa_load_impl into several functions.
7638 Refactor spa_load_impl into several functions
Wed, Feb 21, 11:25 PM
mav committed rS329759: 9018 Replace kmem_cache_reap_now() with kmem_cache_reap_soon().
9018 Replace kmem_cache_reap_now() with kmem_cache_reap_soon()
Wed, Feb 21, 11:15 PM
mav committed rS329757: 9018 Replace kmem_cache_reap_now() with kmem_cache_reap_soon().
9018 Replace kmem_cache_reap_now() with kmem_cache_reap_soon()
Wed, Feb 21, 10:14 PM
mav committed rS329755: MFV r329753: 8809 libzpool should leverage work done in libfakekernel.
MFV r329753: 8809 libzpool should leverage work done in libfakekernel
Wed, Feb 21, 9:18 PM
mav committed rS329753: 8809 libzpool should leverage work done in libfakekernel.
8809 libzpool should leverage work done in libfakekernel
Wed, Feb 21, 9:05 PM
mav committed rS329738: MFV r329736: 8969 Cannot boot from RAIDZ with parity > 1.
MFV r329736: 8969 Cannot boot from RAIDZ with parity > 1
Wed, Feb 21, 6:12 PM
mav committed rS329736: 8969 Cannot boot from RAIDZ with parity > 1.
8969 Cannot boot from RAIDZ with parity > 1
Wed, Feb 21, 6:09 PM
mav committed rS329732: MFV r329502: 7614 zfs device evacuation/removal.
MFV r329502: 7614 zfs device evacuation/removal
Wed, Feb 21, 4:51 PM
mav committed rS329694: MFV r324198: 8081 Compiler warnings in zdb.
MFV r324198: 8081 Compiler warnings in zdb
Wed, Feb 21, 3:09 AM
mav committed rS329691: MFV r322231:.
MFV r322231:
Wed, Feb 21, 2:21 AM
mav committed rS329690: MFV r319737: 6939 add sysevents to zfs core for commands.
MFV r319737: 6939 add sysevents to zfs core for commands
Wed, Feb 21, 2:20 AM
mav committed rS329683: MFV r319736: 6396 remove SVM.
MFV r319736: 6396 remove SVM
Wed, Feb 21, 12:25 AM
mav committed rS329681: MFV r318941: 7446 zpool create should support efi system partition.
MFV r318941: 7446 zpool create should support efi system partition
Wed, Feb 21, 12:19 AM

Tue, Feb 20

mav committed rS329668: MFV r316918: 7990 libzfs: snapspec_cb() does not need to call zfs_strdup().
MFV r316918: 7990 libzfs: snapspec_cb() does not need to call zfs_strdup()
Tue, Feb 20, 8:46 PM
mav committed rS329667: MFV r316902: 7745 print error if lzc_* is called before libzfs_core_init.
MFV r316902: 7745 print error if lzc_* is called before libzfs_core_init
Tue, Feb 20, 8:41 PM
mav committed rS329665: MFV r316901:.
MFV r316901:
Tue, Feb 20, 8:37 PM
mav committed rS329664: MFV r316893:.
MFV r316893:
Tue, Feb 20, 8:34 PM
mav committed rS329663: MFV r316876: 7542 zfs_unmount failed with EZFS_UNSHARENFSFAILED.
MFV r316876: 7542 zfs_unmount failed with EZFS_UNSHARENFSFAILED
Tue, Feb 20, 8:31 PM
mav committed rS329661: MFV r316875: 7336 vfork and O_CLOEXEC causes zfs_mount EBUSY.
MFV r316875: 7336 vfork and O_CLOEXEC causes zfs_mount EBUSY
Tue, Feb 20, 8:27 PM
mav committed rS329659: MFV r316873: 7233 dir_is_empty should open directory with CLOEXEC.
MFV r316873: 7233 dir_is_empty should open directory with CLOEXEC
Tue, Feb 20, 8:17 PM
mav committed rS329658: MFV r316872: 7502 ztest should run zdb with -G (debug mode).
MFV r316872: 7502 ztest should run zdb with -G (debug mode)
Tue, Feb 20, 8:14 PM
mav committed rS329628: MFC r316910: 7812 Remove gender specific language.
MFC r316910: 7812 Remove gender specific language
Tue, Feb 20, 5:07 AM
mav committed rS329625: MFV r307315:.
MFV r307315:
Tue, Feb 20, 4:37 AM
mav committed rS329623: MFV r302649: 7016 arc_available_memory is not 32-bit safe.
MFV r302649: 7016 arc_available_memory is not 32-bit safe
Tue, Feb 20, 4:14 AM

Sun, Feb 18

mav committed rS329508: MFV r324198: 8081 Compiler warnings in zdb.
MFV r324198: 8081 Compiler warnings in zdb
Sun, Feb 18, 4:00 AM
mav committed rS329505: MFV r323911:.
MFV r323911:
Sun, Feb 18, 1:42 AM
mav committed rS329502: 7614 zfs device evacuation/removal.
7614 zfs device evacuation/removal
Sun, Feb 18, 1:22 AM
mav committed rS329495: MFC r328256:.
MFC r328256:
Sun, Feb 18, 12:27 AM
mav committed rS329494: MFC r328254:.
MFC r328254:
Sun, Feb 18, 12:26 AM
mav committed rS329493: MFC r328252: MFV r328251: 8652 Tautological comparisons with ZPROP_INVAL.
MFC r328252: MFV r328251: 8652 Tautological comparisons with ZPROP_INVAL
Sun, Feb 18, 12:26 AM
mav committed rS329492: MFC r328250: MFV r328249:.
MFC r328250: MFV r328249:
Sun, Feb 18, 12:25 AM
mav committed rS329491: MFC r328248: MFV r328247:.
MFC r328248: MFV r328247:
Sun, Feb 18, 12:24 AM
mav committed rS329490: MFC r328246:.
MFC r328246:
Sun, Feb 18, 12:24 AM
mav committed rS329489: MFC r328234: MFV r328233:.
MFC r328234: MFV r328233:
Sun, Feb 18, 12:23 AM
mav committed rS329488: MFC r328232:.
MFC r328232:
Sun, Feb 18, 12:22 AM
mav committed rS329487: MFC r328230: MFV r328229:.
MFC r328230: MFV r328229:
Sun, Feb 18, 12:21 AM
mav committed rS329486: MFC r328228: MFV r328227: 8909 8585 can cause a use-after-free kernel panic.
MFC r328228: MFV r328227: 8909 8585 can cause a use-after-free kernel panic
Sun, Feb 18, 12:20 AM
mav committed rS329485: MFC r328226: MFV r328225:.
MFC r328226: MFV r328225:
Sun, Feb 18, 12:19 AM
mav committed rS329484: MFC r328224: MFV r328220: 8677 Open-Context Channel Programs.
MFC r328224: MFV r328220: 8677 Open-Context Channel Programs
Sun, Feb 18, 12:18 AM

Sat, Feb 17

mav committed rS329482: MFC r323002 (by emaste): zfs: do not advertise edonr which is not yet supported.
MFC r323002 (by emaste): zfs: do not advertise edonr which is not yet supported
Sat, Feb 17, 11:55 PM
mav committed rS329481: MFC r321104 (by jhibbits): Make ZFS not crash on mount on 32-bit systems.
MFC r321104 (by jhibbits): Make ZFS not crash on mount on 32-bit systems
Sat, Feb 17, 11:51 PM
mav committed rS329478: MFC r319671:.
MFC r319671:
Sat, Feb 17, 11:05 PM
mav created D14420: Make chain frames memory allocation in mps(4)/mpr(4) physically non-contiguous.
Sat, Feb 17, 10:34 PM

Tue, Feb 13

mav committed rS329189: MFC r328937: Fix queue length reporting in mps(4) and mpr(4)..
MFC r328937: Fix queue length reporting in mps(4) and mpr(4).
Tue, Feb 13, 2:12 AM

Sat, Feb 10

This revision was not accepted when it landed; it landed in state Needs Revision.
Sat, Feb 10, 12:56 AM
mav committed rS329096: Teach mps(4) and mpr(4) drivers to autotune chain frames..
Teach mps(4) and mpr(4) drivers to autotune chain frames.
Sat, Feb 10, 12:56 AM
mav committed rS329095: MFC r325795 (by imp):.
MFC r325795 (by imp):
Sat, Feb 10, 12:39 AM

Fri, Feb 9

mav committed rS329091: Add sysctls for dnode block and indirect block shifts..
Add sysctls for dnode block and indirect block shifts.
Fri, Feb 9, 11:30 PM
mav committed rS329057: MFC r328611: Try to preallocate receive memory early..
MFC r328611: Try to preallocate receive memory early.
Fri, Feb 9, 3:07 AM
mav committed rS329056: MFC r328450: Use bus_dmamem_alloc(9) KPI instead of contigmalloc(9)..
MFC r328450: Use bus_dmamem_alloc(9) KPI instead of contigmalloc(9).
Fri, Feb 9, 3:07 AM

Thu, Feb 8

mav added a comment to D14261: Allocate sufficient number of chain frames in mps(4) and mpr(4)..
In D14261#299113, @imp wrote:

Netflix runs with a 8MB MAXPHYS, so we'd need something from the get go...

Thu, Feb 8, 6:29 PM
mav added a comment to D14261: Allocate sufficient number of chain frames in mps(4) and mpr(4)..

Yes, I had that concern about memory allocation too. I agree that allocation code should be rewritten to not require more continuous pages then required by hardware. But actually present setting of the MAXPHYS and MPR_REQ_FRAMES easily fit into your proposed 2MB/16384 threshold. What would you say about committing this patch with MPR_CHAIN_FRAMES set to some limit sufficient for default configuration like 16384, just to protect against somebody who may have increased MAXPHYS until the allocation is fixed?

Thu, Feb 8, 6:20 PM
mav updated the diff for D14261: Allocate sufficient number of chain frames in mps(4) and mpr(4)..

Makes sense. I have an idea for that. This new patch uses MAXPHYS as an optimization hint, while reporting real hardware limitation to CAM. It should allow bigger I/Os, just without resources guaranteed.

Thu, Feb 8, 4:59 PM
mav added a comment to D14263: read-behind / read-ahead support for zfs_getpages().

I haven't looked deep, but the general direction makes sense to me. Since ABD introduction sub-block reads become more expensive even for uncompressed data, since dmu_buf_hold_array() copies whole block from scatter/gather to flat buffers. For compressed difference should be even bigger, but there it at least compensated by increased ARC capacity. We noticed it just few days ago as a cause of significant performance drop in some of benchmarks.

Thu, Feb 8, 4:25 PM
mav created D14261: Allocate sufficient number of chain frames in mps(4) and mpr(4)..
Thu, Feb 8, 4:29 AM

Tue, Feb 6

mav committed rS328937: Fix queue length reporting in mps(4) and mpr(4)..
Fix queue length reporting in mps(4) and mpr(4).
Tue, Feb 6, 4:02 PM
mav closed D14215: LSI HBA drivers report incorrect queue depth to CAM.
Tue, Feb 6, 4:02 PM

Mon, Feb 5

mav added a comment to D14063: Use C errno as return value for cam_periph_acquire().

I neither have major objections aside of one inline, nor too happy. From one side I agree that there is no any/much sense to return cam_status from functions like that, which do not work with command statuses. From the other side it is a) an API change, which may lead to difficult to find errors, but b) there are many other functions suffering the same problem (but which may be more invasive to fix though).

Mon, Feb 5, 10:18 PM
mav created D14215: LSI HBA drivers report incorrect queue depth to CAM.
Mon, Feb 5, 9:36 PM

Fri, Feb 2

mav committed rS328820: MFC r303468 (by imp):.
MFC r303468 (by imp):
Fri, Feb 2, 11:23 PM
mav committed rS328819: MFC r303467 (by imp):.
MFC r303467 (by imp):
Fri, Feb 2, 11:19 PM
mav committed rS328805: MFC r312293,312305,312434,312698,312759,312760,312814,312815,322672:.
MFC r312293,312305,312434,312698,312759,312760,312814,312815,322672:
Fri, Feb 2, 6:38 PM
mav committed rS328804: Partial MFC of r312205 (by sbruno): Skip smp check if we're running UP.
Partial MFC of r312205 (by sbruno): Skip smp check if we're running UP
Fri, Feb 2, 6:12 PM
mav committed rS328802: Partial MFC of r311039 (by sbruno):.
Partial MFC of r311039 (by sbruno):
Fri, Feb 2, 6:11 PM
mav committed rS328801: MFC r307657 (by sbruno): Resolve whitespace diff to NextBSD..
MFC r307657 (by sbruno): Resolve whitespace diff to NextBSD.
Fri, Feb 2, 6:05 PM
mav committed rS328800: MFC r307567 (by sbruno): Assert that we're assigning a non-null taskqueue..
MFC r307567 (by sbruno): Assert that we're assigning a non-null taskqueue.
Fri, Feb 2, 6:03 PM
mav committed rS328798: MFC r307566 (by sbruno):.
MFC r307566 (by sbruno):
Fri, Feb 2, 6:02 PM
mav committed rS328797: MFC r307561 (by sbruno): Tell gtask to what we've been bound..
MFC r307561 (by sbruno): Tell gtask to what we've been bound.
Fri, Feb 2, 6:00 PM
mav committed rS328796: MFC r307041 (by sbruno):.
MFC r307041 (by sbruno):
Fri, Feb 2, 5:57 PM

Thu, Feb 1

mav committed rS328751: MFC small part of r325794 to fix the build..
MFC small part of r325794 to fix the build.
Thu, Feb 1, 9:35 PM
mav committed rS328750: MFC r327034 (by imp):.
MFC r327034 (by imp):
Thu, Feb 1, 9:26 PM
mav committed rS328749: MFC r326937, r326940 (by imp):.
MFC r326937, r326940 (by imp):
Thu, Feb 1, 9:24 PM
mav committed rS328748: MFC r324978: Report only the valid slots in the firmware log page..
MFC r324978: Report only the valid slots in the firmware log page.
Thu, Feb 1, 9:17 PM
mav committed rS328741: MFC r324977 (by imp):.
MFC r324977 (by imp):
Thu, Feb 1, 9:16 PM