Page MenuHomeFreeBSD

mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (241 w, 1 d)

Recent Activity

Mon, Jan 7

mav accepted D18772: Add NVMe drive to NOIOB quirk list.

I have no objections, if its true.

Mon, Jan 7, 3:50 PM
mav accepted D18741: Fix use of busdma(9) KPI in ahci(4)..
Mon, Jan 7, 2:12 AM

Sat, Jan 5

mav requested changes to D18741: Fix use of busdma(9) KPI in ahci(4)..

I don't think this change fix anything. As I see, this code path is called without the lock held, so locking callback is pointless. What should be added instead is BUS_DMA_NOWAIT flag to the bus_dmamap_load() calls, since the code there really expects synchronous completion. Or it require some more complicated rework to make it asynchronous.

Sat, Jan 5, 1:46 AM

Thu, Dec 27

mav committed rS342559: Fix incorrectly inserted copyright in r342557..
Fix incorrectly inserted copyright in r342557.
Thu, Dec 27, 10:44 PM
mav committed rS342558: Switch from mutexes to atomics in GEOM_DEV I/O path..
Switch from mutexes to atomics in GEOM_DEV I/O path.
Thu, Dec 27, 7:15 PM
mav committed rS342557: Reimplement nvd(4) detach handling..
Reimplement nvd(4) detach handling.
Thu, Dec 27, 6:28 PM

Wed, Dec 26

mav committed rS342546: Add descriptions to NVMe interrupts..
Add descriptions to NVMe interrupts.
Wed, Dec 26, 11:42 PM
mav committed rS342467: MFC r342349: Fix passing wrong variables to nvlist_destroy() after r333446..
MFC r342349: Fix passing wrong variables to nvlist_destroy() after r333446.
Wed, Dec 26, 2:35 AM

Mon, Dec 24

mav committed rS342400: Increase MTX_POOL_SLEEP_SIZE from 128 to 1024..
Increase MTX_POOL_SLEEP_SIZE from 128 to 1024.
Mon, Dec 24, 11:52 PM
mav committed rS342399: Remove CAM SIM lock from NVMe SIM..
Remove CAM SIM lock from NVMe SIM.
Mon, Dec 24, 11:28 PM

Fri, Dec 21

mav committed rS342349: Fix passing wrong variables to nvlist_destroy() after r333446..
Fix passing wrong variables to nvlist_destroy() after r333446.
Fri, Dec 21, 5:22 PM

Tue, Dec 18

mav committed rS342206: MFC r339909: Allow changing lagg(4) MTU..
MFC r339909: Allow changing lagg(4) MTU.
Tue, Dec 18, 11:23 PM
mav committed rS342205: MFC r339909: Allow changing lagg(4) MTU..
MFC r339909: Allow changing lagg(4) MTU.
Tue, Dec 18, 10:56 PM

Dec 14 2018

mav committed rS342083: MFC r341829: Allow CTL device specification in bhyve virtio-scsi..
MFC r341829: Allow CTL device specification in bhyve virtio-scsi.
Dec 14 2018, 2:49 PM
mav committed rS342082: MFC r341706: Make virtio-scsi pass SCSI Task Attributes to CTL..
MFC r341706: Make virtio-scsi pass SCSI Task Attributes to CTL.
Dec 14 2018, 2:46 PM
mav committed rS342081: MFC r341704: Fill initid explicitly on requests..
MFC r341704: Fill initid explicitly on requests.
Dec 14 2018, 2:46 PM
mav committed rS342080: MFC r341705: Fix several iov handling bugs in bhyve virtio-scsi backend..
MFC r341705: Fix several iov handling bugs in bhyve virtio-scsi backend.
Dec 14 2018, 2:44 PM

Dec 11 2018

mav closed D18504: Allow CTL device specification in bhyve virtio-scsi.
Dec 11 2018, 8:47 PM · bhyve
mav committed rS341829: Allow CTL device specification in bhyve virtio-scsi..
Allow CTL device specification in bhyve virtio-scsi.
Dec 11 2018, 8:47 PM
mav accepted D18493: Check if NVMe Controller supports Dataset Management in nda(4).
Dec 11 2018, 3:04 PM

Dec 10 2018

mav added a reviewer for D18504: Allow CTL device specification in bhyve virtio-scsi: araujo.
Dec 10 2018, 9:52 PM · bhyve
mav created D18504: Allow CTL device specification in bhyve virtio-scsi.
Dec 10 2018, 9:51 PM · bhyve
mav accepted D18300: Remove special initialization for ICH8M.
Dec 10 2018, 6:56 PM

Dec 7 2018

mav committed rS341706: Make virtio-scsi pass SCSI Task Attributes to CTL..
Make virtio-scsi pass SCSI Task Attributes to CTL.
Dec 7 2018, 8:55 PM
mav committed rS341705: Fix several iov handling bugs in bhyve virtio-scsi backend..
Fix several iov handling bugs in bhyve virtio-scsi backend.
Dec 7 2018, 8:31 PM
mav closed D18465: Several iov handling bugs in bhyve virtio-scsi backend.
Dec 7 2018, 8:31 PM
mav committed rS341704: Fill initid explicitly on requests..
Fill initid explicitly on requests.
Dec 7 2018, 7:11 PM
mav updated the summary of D18465: Several iov handling bugs in bhyve virtio-scsi backend.
Dec 7 2018, 2:50 PM

Dec 6 2018

mav created D18465: Several iov handling bugs in bhyve virtio-scsi backend.
Dec 6 2018, 10:24 PM
mav accepted D18430: Reduce mountd DNS queries.
Dec 6 2018, 5:03 AM

Dec 5 2018

mav added a comment to D18430: Reduce mountd DNS queries.

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

Dec 5 2018, 8:07 PM

Nov 29 2018

mav accepted D18374: Adjust v_freecnt when blacklisting pages..

Looks good to me. I applied the version for 11 you've proposed on IRC and so far the benchmark runs for about 20 minutes, while previously crashed after about 5. I'll let you know if it ever happen again.

Nov 29 2018, 4:14 PM

Nov 26 2018

mav added a comment to D18300: Remove special initialization for ICH8M.

I generally believe that we should let BIOS do its job. The chipset specification explicitly tells that OS doesn't need to know about this register. I can't recall why that code exist there and what was the problem, but since it touches only ancient ICH8M chipset, unless there is some other newer cases to have it, I'd remove it completely instead.

Nov 26 2018, 7:00 PM

Nov 21 2018

mav committed rS340737: Revert r340096: 9952 Block size change during zfs receive drops spill block.
Revert r340096: 9952 Block size change during zfs receive drops spill block
Nov 21 2018, 6:19 PM

Nov 14 2018

mav added a comment to D17860: <<Two NVMe Bootup hang>.

I have feeling it is a workaround of some other problem. Shouldn't we have fully operational scheduler at that point when EARLY_AP_STARTUP is enabled? This change may open the races this code intended to handle.

Nov 14 2018, 3:59 PM
mav added reviewers for D17860: <<Two NVMe Bootup hang>: kib, jhb.
Nov 14 2018, 3:56 PM

Nov 10 2018

mav committed rS340311: Do not ignore arc_adjust() return value..
Do not ignore arc_adjust() return value.
Nov 10 2018, 1:58 AM
mav closed D17927: Do not ignore arc_adjust() return value.
Nov 10 2018, 1:58 AM
mav added inline comments to D17927: Do not ignore arc_adjust() return value.
Nov 10 2018, 1:42 AM

Nov 9 2018

mav created D17927: Do not ignore arc_adjust() return value.
Nov 9 2018, 6:02 PM
mav added a member for ZFS: mav.
Nov 9 2018, 5:59 PM

Nov 3 2018

mav committed rS340096: 9952 Block size change during zfs receive drops spill block.
9952 Block size change during zfs receive drops spill block
Nov 3 2018, 5:18 AM
mav committed rS340096: 9952 Block size change during zfs receive drops spill block.
9952 Block size change during zfs receive drops spill block
Nov 3 2018, 5:15 AM

Nov 2 2018

mav committed rS340071: Adjust SiS 966/968 HDA controller naming..
Adjust SiS 966/968 HDA controller naming.
Nov 2 2018, 5:02 PM

Oct 31 2018

mav added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

Have you tried to investigate whether keeping only VREF_ENABLE_MASK would be enough? It could have some more sense in general, since the driver has no way to know what VREF is needed in specific case. Same time other bits there are pretty logical.

Oct 31 2018, 2:28 PM

Oct 24 2018

mav accepted D17576: Allow changing lagg(4) MTU.

I have no specific objections. Looks good to me. It just looks slightly odd, that MTU is handled different from other properties -- set before interface addition to LAGG, while multicast filters set after just before protocol initialization, and capabilities are set after the protocol initialization. As one of downsides this different order required addition of duplicate checks for LAGG nesting.

Oct 24 2018, 4:02 PM · network

Oct 23 2018

mav resigned from D17644: Add support for AMD eMMC controller HS400 mode.

Unfortunately I haven't touched this area for several years and don't know details of modern transfer modes.

Oct 23 2018, 2:49 PM

Oct 19 2018

mav committed rS339441: MFC r339372: Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE..
MFC r339372: Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE.
Oct 19 2018, 4:37 AM
mav committed rS339440: MFC r339329: Add ZIO_TYPE_FREE support for indirect vdevs..
MFC r339329: Add ZIO_TYPE_FREE support for indirect vdevs.
Oct 19 2018, 4:30 AM
mav committed rS339439: MFC r339335: Avoid zero-sized kmem_alloc() in vdev_compact_children()..
MFC r339335: Avoid zero-sized kmem_alloc() in vdev_compact_children().
Oct 19 2018, 4:28 AM

Oct 16 2018

mav accepted D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).

I have no particular objections, just quietly sighing that this area remains so tangled. I haven't investigated the area much recently, but it seems like WDAT-based attach could be cleaner, if it is a widespread standard and does not conflict too badly with existing drivers. Having watchdog drivers enabled in FreeNAS for years we had huge number of complains, caused by random platform specifics, and obtaining some valid configuration directly from platform in face of this table could be priceless.

Oct 16 2018, 3:06 PM

Oct 15 2018

mav committed rS339372: Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE..
Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE.
Oct 15 2018, 9:59 PM

Oct 13 2018

mav committed rS339345: MFC r339288: Remove extra thread_exit() call left after r329802..
MFC r339288: Remove extra thread_exit() call left after r329802.
Oct 13 2018, 3:13 AM

Oct 12 2018

mav accepted D17513: Add missing performance optimization of AVL tree comparator functions.
Oct 12 2018, 5:26 PM
mav committed rS339335: Avoid zero-sized kmem_alloc() in vdev_compact_children()..
Avoid zero-sized kmem_alloc() in vdev_compact_children().
Oct 12 2018, 4:55 PM
mav committed rS339329: Add ZIO_TYPE_FREE support for indirect vdevs..
Add ZIO_TYPE_FREE support for indirect vdevs.
Oct 12 2018, 3:14 PM
mav closed D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 12 2018, 3:14 PM · ZFS
mav committed rS339324: MFC r339197: Add sysctls for dbuf metadata cache variables added in r336959..
MFC r339197: Add sysctls for dbuf metadata cache variables added in r336959.
Oct 12 2018, 1:11 AM

Oct 11 2018

mav added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:16 PM · ZFS
mav created D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:06 PM · ZFS
mav committed rS339306: MFC r339237: Fix r336951 mismerge -- use of uninitialized variable..
MFC r339237: Fix r336951 mismerge -- use of uninitialized variable.
Oct 11 2018, 3:12 PM

Oct 10 2018

mav committed rS339288: Remove extra thread_exit() call left after r329802..
Remove extra thread_exit() call left after r329802.
Oct 10 2018, 4:35 PM
mav added inline comments to rS329802: MFV r329799, r329800:.
Oct 10 2018, 3:34 PM
mav accepted D17495: Fix deadlock in IO pipeline.

Dropping locks inside the function is a mess, but I don't see specific problems.

Oct 10 2018, 3:10 PM
mav accepted D17494: Add missing ZFS sysctls.
Oct 10 2018, 2:37 PM

Oct 8 2018

mav committed rS339237: Fix r336951 mismerge -- use of uninitialized variable..
Fix r336951 mismerge -- use of uninitialized variable.
Oct 8 2018, 3:19 PM

Oct 5 2018

mav committed rS339197: Add sysctls for dbuf metadata cache variables added in r336959..
Add sysctls for dbuf metadata cache variables added in r336959.
Oct 5 2018, 4:06 PM

Oct 3 2018

mav committed rS339158: MFC r337567 (by mmacy):.
MFC r337567 (by mmacy):
Oct 3 2018, 5:10 PM
mav committed rS339153: MFC r338869: MFV r338866: 9700 ZFS resilvered mirror does not balance reads.
MFC r338869: MFV r338866: 9700 ZFS resilvered mirror does not balance reads
Oct 3 2018, 3:36 PM
mav committed rS339152: MFC r337972: 9751 Allocation throttling misplacing ditto blocks.
MFC r337972: 9751 Allocation throttling misplacing ditto blocks
Oct 3 2018, 3:35 PM
mav committed rS339151: MFC r337970: 9738 Fix third block copy allocations, broken at 9112..
MFC r337970: 9738 Fix third block copy allocations, broken at 9112.
Oct 3 2018, 3:35 PM
mav committed rS339150: MFC r337923: Make vfs.zfs.zio.dva_throttle_enabled sysctl writable..
MFC r337923: Make vfs.zfs.zio.dva_throttle_enabled sysctl writable.
Oct 3 2018, 3:33 PM
mav committed rS339149: MFC r337883: Add couple tunables/sysctl, missed in r336949..
MFC r337883: Add couple tunables/sysctl, missed in r336949.
Oct 3 2018, 3:33 PM
mav committed rS339148: MFC r337870: Fix mismerge in r337196..
MFC r337870: Fix mismerge in r337196.
Oct 3 2018, 3:31 PM
mav committed rS339147: MFC r337229: Reduce taskq and context-switch cost of zio pipe.
MFC r337229: Reduce taskq and context-switch cost of zio pipe
Oct 3 2018, 2:59 PM
mav committed rS339146: MFC r337227: MFV r337223:.
MFC r337227: MFV r337223:
Oct 3 2018, 2:59 PM
mav committed rS339145: MFC r337221: MFV r337220: 8375 Kernel memory leak in nvpair code.
MFC r337221: MFV r337220: 8375 Kernel memory leak in nvpair code
Oct 3 2018, 2:58 PM
mav committed rS339144: MFC r337219: MFV r337218: 7261 nvlist code should enforce name length limit.
MFC r337219: MFV r337218: 7261 nvlist code should enforce name length limit
Oct 3 2018, 2:58 PM
mav committed rS339143: MFC r337217: MFV r337216: 7263 deeply nested nvlist can overflow stack.
MFC r337217: MFV r337216: 7263 deeply nested nvlist can overflow stack
Oct 3 2018, 2:57 PM
mav committed rS339142: MFC r337215: MFV 337214:.
MFC r337215: MFV 337214:
Oct 3 2018, 2:56 PM
mav committed rS339141: MFC r337213: MFV r337212:.
MFC r337213: MFV r337212:
Oct 3 2018, 2:55 PM
mav committed rS339140: MFC r337211: MFV r337210: 9577 remove zfs_dbuf_evict_key tsd.
MFC r337211: MFV r337210: 9577 remove zfs_dbuf_evict_key tsd
Oct 3 2018, 2:55 PM
mav committed rS339139: MFC r337209:.
MFC r337209:
Oct 3 2018, 2:54 PM
mav committed rS339138: MFC r337207: MFV r337206: 9338 moved dnode has incorrect dn_next_type.
MFC r337207: MFV r337206: 9338 moved dnode has incorrect dn_next_type
Oct 3 2018, 2:53 PM
mav committed rS339137: MFC r337205:.
MFC r337205:
Oct 3 2018, 2:52 PM
mav committed rS339136: MFC r337202: MFV r337200:.
MFC r337202: MFV r337200:
Oct 3 2018, 2:52 PM
mav committed rS339135: MFC r337201: Fix build after r337196 mismerge..
MFC r337201: Fix build after r337196 mismerge.
Oct 3 2018, 2:51 PM
mav committed rS339134: MFC r337198: MFV r337197: 9456 ztest failure in zil_commit_waiter_timeout.
MFC r337198: MFV r337197: 9456 ztest failure in zil_commit_waiter_timeout
Oct 3 2018, 2:50 PM
mav committed rS339133: MFC r337196: MFV r337195: 9454 ::zfs_blkstats should count embedded blocks.
MFC r337196: MFV r337195: 9454 ::zfs_blkstats should count embedded blocks
Oct 3 2018, 2:50 PM
mav committed rS339132: MFC r337194: MFV r337193:.
MFC r337194: MFV r337193:
Oct 3 2018, 2:49 PM
mav committed rS339131: MFC r337191:.
MFC r337191:
Oct 3 2018, 2:49 PM
mav committed rS339130: MFC r337185:.
MFC r337185:
Oct 3 2018, 2:48 PM
mav committed rS339129: MFC r337183:.
MFC r337183:
Oct 3 2018, 2:47 PM
mav committed rS339128: MFC r337181: 9539 Make zvol operations use _by_dnode routines.
MFC r337181: 9539 Make zvol operations use _by_dnode routines
Oct 3 2018, 2:46 PM
mav committed rS339127: MFC r337179: 9523 Large alloc in zdb can cause trouble.
MFC r337179: 9523 Large alloc in zdb can cause trouble
Oct 3 2018, 2:46 PM
mav committed rS339126: MFC r337177:.
MFC r337177:
Oct 3 2018, 2:44 PM
mav committed rS339125: MFC r337172, MFV r337171:.
MFC r337172, MFV r337171:
Oct 3 2018, 2:43 PM
mav committed rS339120: MFC r337169: MFV r337167: 9442 decrease indirect block size of spacemaps.
MFC r337169: MFV r337167: 9442 decrease indirect block size of spacemaps
Oct 3 2018, 3:14 AM
mav committed rS339119: MFC r337163: MFV r337161: 9512 zfs remap poolname@snapname coredumps.
MFC r337163: MFV r337161: 9512 zfs remap poolname@snapname coredumps
Oct 3 2018, 3:14 AM
mav committed rS339118: MFC r337160:.
MFC r337160:
Oct 3 2018, 2:52 AM