Page MenuHomeFreeBSD

mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (276 w, 8 h)

Recent Activity

Yesterday

mav requested changes to D20677: Introduce quirks tunable for da driver.

Generally I think it is good, but I think it should be set higher, after the "softc->quirks |= DA_Q_NO_6_BYTE;" line.

Tue, Sep 17, 10:04 PM

Sun, Sep 15

mav committed rS352369: Relax TX draining in ns8250_bus_transmit()..
Relax TX draining in ns8250_bus_transmit().
Sun, Sep 15, 11:57 PM
mav committed rS352360: MFC r352258: Remove Tagged Command Queuing feature reporting..
MFC r352258: Remove Tagged Command Queuing feature reporting.
Sun, Sep 15, 5:59 PM
mav committed rS352359: MFC r352258: Remove Tagged Command Queuing feature reporting..
MFC r352258: Remove Tagged Command Queuing feature reporting.
Sun, Sep 15, 5:58 PM

Fri, Sep 13

mav added inline comments to D21638: Add kqueue support for ZFS..
Fri, Sep 13, 5:30 PM
mav committed rS352299: MFC r352201: Fix assumptions of only one device per SES slot..
MFC r352201: Fix assumptions of only one device per SES slot.
Fri, Sep 13, 3:49 PM
mav committed rS352298: MFC r352201: Fix assumptions of only one device per SES slot..
MFC r352201: Fix assumptions of only one device per SES slot.
Fri, Sep 13, 3:48 PM
mav committed rS352297: MFC r352257: Report Trusted Computing feature set support..
MFC r352257: Report Trusted Computing feature set support.
Fri, Sep 13, 3:21 PM
mav committed rS352296: MFC r352257: Report Trusted Computing feature set support..
MFC r352257: Report Trusted Computing feature set support.
Fri, Sep 13, 3:21 PM
mav committed rS352295: MFC r352200: Remove struct ata_res_pass16, unneeded after r352082..
MFC r352200: Remove struct ata_res_pass16, unneeded after r352082.
Fri, Sep 13, 3:20 PM
mav committed rS352294: MFC r352200: Remove struct ata_res_pass16, unneeded after r352082..
MFC r352200: Remove struct ata_res_pass16, unneeded after r352082.
Fri, Sep 13, 3:20 PM
mav committed rS352293: MFC r352111: Initialize page/subpage in case of `modepage -d`..
MFC r352111: Initialize page/subpage in case of `modepage -d`.
Fri, Sep 13, 3:19 PM
mav committed rS352292: MFC r352111: Initialize page/subpage in case of `modepage -d`..
MFC r352111: Initialize page/subpage in case of `modepage -d`.
Fri, Sep 13, 3:19 PM
mav committed rS352291: MFC r352082, r352103: Fix number of problems found while testing on SAT devices..
MFC r352082, r352103: Fix number of problems found while testing on SAT devices.
Fri, Sep 13, 3:19 PM
mav committed rS352290: MFC r352082, r352103: Fix number of problems found while testing on SAT devices..
MFC r352082, r352103: Fix number of problems found while testing on SAT devices.
Fri, Sep 13, 3:16 PM
mav committed rS352289: MFC r352018: Unify cam_send_ccb() error reporting..
MFC r352018: Unify cam_send_ccb() error reporting.
Fri, Sep 13, 3:13 PM
mav committed rS352287: MFC r352018: Unify cam_send_ccb() error reporting..
MFC r352018: Unify cam_send_ccb() error reporting.
Fri, Sep 13, 2:44 PM
mav committed rS352286: Supply SAT layer with valid transfer sizes..
Supply SAT layer with valid transfer sizes.
Fri, Sep 13, 2:43 PM
mav committed rS352285: MFC r352011: Supply SAT layer with valid transfer sizes..
MFC r352011: Supply SAT layer with valid transfer sizes.
Fri, Sep 13, 2:43 PM

Thu, Sep 12

mav committed rS352258: Remove Tagged Command Queuing feature reporting..
Remove Tagged Command Queuing feature reporting.
Thu, Sep 12, 5:42 PM
mav committed rS352257: Report Trusted Computing feature set support..
Report Trusted Computing feature set support.
Thu, Sep 12, 5:21 PM

Wed, Sep 11

mav committed rS352235: MFC r348268 (by sef), r348293 (by cem):.
MFC r348268 (by sef), r348293 (by cem):
Wed, Sep 11, 11:46 PM
mav committed rS352234: MFC r342024 (by mmacy): Generalize AES iov optimization.
MFC r342024 (by mmacy): Generalize AES iov optimization
Wed, Sep 11, 11:41 PM
mav committed rS352201: Fix assumptions of only one device per SES slot..
Fix assumptions of only one device per SES slot.
Wed, Sep 11, 3:25 AM

Tue, Sep 10

mav committed rS352200: Remove struct ata_res_pass16, unneeded after r352082..
Remove struct ata_res_pass16, unneeded after r352082.
Tue, Sep 10, 11:51 PM

Mon, Sep 9

mav committed rS352111: Initialize page/subpage in case of `modepage -d`..
Initialize page/subpage in case of `modepage -d`.
Mon, Sep 9, 10:08 PM
mav committed rS352103: Add one more error message to r352082..
Add one more error message to r352082.
Mon, Sep 9, 7:00 PM
mav committed rS352082: Fix number of problems found while testing on SAT devices..
Fix number of problems found while testing on SAT devices.
Mon, Sep 9, 5:36 PM

Sat, Sep 7

mav committed rS352018: Unify cam_send_ccb() error reporting..
Unify cam_send_ccb() error reporting.
Sat, Sep 7, 4:52 PM
mav committed rS352011: Supply SAT layer with valid transfer sizes..
Supply SAT layer with valid transfer sizes.
Sat, Sep 7, 3:56 PM

Tue, Sep 3

mav committed rS351760: MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf()..
MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf().
Tue, Sep 3, 4:39 PM
mav committed rS351759: MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf()..
MFC r351134: Add support for 'j', 't' and 'z' flags to kernel sscanf().
Tue, Sep 3, 4:38 PM
mav committed rS351754: MFC r351606: Take proper lock in ses_setphyspath_callback()..
MFC r351606: Take proper lock in ses_setphyspath_callback().
Tue, Sep 3, 4:25 PM
mav committed rS351752: MFC r351606: Take proper lock in ses_setphyspath_callback()..
MFC r351606: Take proper lock in ses_setphyspath_callback().
Tue, Sep 3, 4:20 PM
mav committed rS351746: MFC r351550: Always check cam_periph_error() status for ERESTART..
MFC r351550: Always check cam_periph_error() status for ERESTART.
Tue, Sep 3, 2:55 PM
mav committed rS351745: MFC r351550: Always check cam_periph_error() status for ERESTART..
MFC r351550: Always check cam_periph_error() status for ERESTART.
Tue, Sep 3, 2:52 PM

Thu, Aug 29

mav committed rS351606: Take proper lock in ses_setphyspath_callback()..
Take proper lock in ses_setphyspath_callback().
Thu, Aug 29, 5:02 PM
mav added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

I have submitted the manpage for Review (https://reviews.freebsd.org/D21462). Please have a look and let me know your comments.

Thu, Aug 29, 1:51 PM
mav committed rS351605: Man page for AMD Non-Transparent Bridge (ntb_hw_amd) driver..
Man page for AMD Non-Transparent Bridge (ntb_hw_amd) driver.
Thu, Aug 29, 1:47 PM
Herald added a reviewer for D21462: Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver: manpages.
Thu, Aug 29, 1:47 PM
mav added a comment to D21462: Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver.

I'll tune few minor things, like copyright year in the future, but otherwise it looks good.

Thu, Aug 29, 1:43 PM

Wed, Aug 28

mav committed rS351589: Fix AHCI Enclosure Management, broken by r351356..
Fix AHCI Enclosure Management, broken by r351356.
Wed, Aug 28, 10:04 PM
mav committed rS351588: MFC r351352: Improve NVMe hot unplug handling..
MFC r351352: Improve NVMe hot unplug handling.
Wed, Aug 28, 9:13 PM
mav committed rS351586: MFC r351320: Formalize NVMe controller consumer life cycle..
MFC r351320: Formalize NVMe controller consumer life cycle.
Wed, Aug 28, 8:58 PM
mav committed rS351583: MFC r350677: Make GCC happy about math in r350676..
MFC r350677: Make GCC happy about math in r350676.
Wed, Aug 28, 8:24 PM
mav committed rS351582: MFC r350676: Make `camcontrol modepage` support block descriptors..
MFC r350676: Make `camcontrol modepage` support block descriptors.
Wed, Aug 28, 8:23 PM
mav committed rS351581: MFC r350457: Make `camcontrol modepage` to use 10 byte commands..
MFC r350457: Make `camcontrol modepage` to use 10 byte commands.
Wed, Aug 28, 8:22 PM
mav committed rS351580: MFC r350424: Use present now scsi_mode_sense_subpage()..
MFC r350424: Use present now scsi_mode_sense_subpage().
Wed, Aug 28, 8:21 PM
mav committed rS351579: MFC r350393: Decode some more IDENTIFY DEVICE bits..
MFC r350393: Decode some more IDENTIFY DEVICE bits.
Wed, Aug 28, 8:20 PM
mav committed rS351574: MFV/ZoL: Fix wrong assertion in libzfs diff error handling.
MFV/ZoL: Fix wrong assertion in libzfs diff error handling
Wed, Aug 28, 5:40 PM
mav closed D20118: Fix erroneous assert in libzfs diff.
Wed, Aug 28, 5:39 PM
D20118: Fix erroneous assert in libzfs diff is now accepted and ready to land.
Wed, Aug 28, 4:57 PM

Tue, Aug 27

mav committed rS351550: Always check cam_periph_error() status for ERESTART..
Always check cam_periph_error() status for ERESTART.
Tue, Aug 27, 4:41 PM
mav added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

Theoretically, I don't see any trouble in retaining the db_count in case of MSI and INTx fallback. But, how will it be helpful to have multiple doorbell with single interrupt? Can you give an idea please? Also, When you say,

You just need to provide valid amd_ntb_db_vector_mask() for that case.

db_valid_mask will be set as (db_count - 1 ) always (I assume, this should not be changed). So, if we don't reduce the db_count, how amd_ntb_db_vector_mask will create an impact?

Tue, Aug 27, 2:21 PM
mav committed rS351539: MFC r351105, r351107: Limit memory window usage in ntb_transport to 256MB..
MFC r351105, r351107: Limit memory window usage in ntb_transport to 256MB.
Tue, Aug 27, 4:16 AM
mav committed rS351538: MFC r351072: Implement new methods for Intel and PLX NTB..
MFC r351072: Implement new methods for Intel and PLX NTB.
Tue, Aug 27, 4:15 AM
mav committed rS351537: MFC r351056, r351083: Add support for PCI Device ID 0x148B in ntb_hw_amd driver..
MFC r351056, r351083: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.
Tue, Aug 27, 4:14 AM
mav committed rS351536: MFC r349594, r349595, r349601: Add driver for NTB in AMD SoC..
MFC r349594, r349595, r349601: Add driver for NTB in AMD SoC.
Tue, Aug 27, 4:13 AM
mav committed rS351535: MFC r351352: Improve NVMe hot unplug handling..
MFC r351352: Improve NVMe hot unplug handling.
Tue, Aug 27, 4:04 AM
mav committed rS351534: MFC r351320: Formalize NVMe controller consumer life cycle..
MFC r351320: Formalize NVMe controller consumer life cycle.
Tue, Aug 27, 4:04 AM
mav committed rS351533: MFC r351038: Print few more useful identify fields..
MFC r351038: Print few more useful identify fields.
Tue, Aug 27, 4:02 AM
mav committed rS351532: MFC r351028: Report NOIOB and NPWG fields as stripe size..
MFC r351028: Report NOIOB and NPWG fields as stripe size.
Tue, Aug 27, 4:02 AM
mav committed rS351531: MFC r351004, r351006: Make nvd(4) report NGUID or EUI64 as GEOM::lunid..
MFC r351004, r351006: Make nvd(4) report NGUID or EUI64 as GEOM::lunid.
Tue, Aug 27, 4:01 AM
mav committed rS351530: MFC r350676, r350677: Make `camcontrol modepage` support block descriptors..
MFC r350676, r350677: Make `camcontrol modepage` support block descriptors.
Tue, Aug 27, 3:55 AM
mav committed rS351529: MFC r350457: Make `camcontrol modepage` to use 10 byte commands..
MFC r350457: Make `camcontrol modepage` to use 10 byte commands.
Tue, Aug 27, 3:54 AM
mav committed rS351528: MFC r350424: Use present now scsi_mode_sense_subpage()..
MFC r350424: Use present now scsi_mode_sense_subpage().
Tue, Aug 27, 3:53 AM
mav committed rS351527: MFC r350393: Decode some more IDENTIFY DEVICE bits..
MFC r350393: Decode some more IDENTIFY DEVICE bits.
Tue, Aug 27, 3:52 AM
mav committed rS351526: MFC r351348 (by markj):.
MFC r351348 (by markj):
Tue, Aug 27, 3:06 AM

Mon, Aug 26

mav committed rS351516: Announce PCI Segment Groups supported to PCI host _OSC..
Announce PCI Segment Groups supported to PCI host _OSC.
Mon, Aug 26, 5:54 PM
mav committed rS351514: Don't consider PCIe hot-plug command timeout fatal..
Don't consider PCIe hot-plug command timeout fatal.
Mon, Aug 26, 5:27 PM

Sun, Aug 25

mav added a comment to D21409: mixer(8): Report an error if passed value is an empty string.
In D21409#465864, @0mp wrote:

Also, do we want to MFC this change?

Sun, Aug 25, 3:11 PM
D21409: mixer(8): Report an error if passed value is an empty string is now accepted and ready to land.

Looks good to me. Just thinking whether -1 or EOF is more appropriate.

Sun, Aug 25, 1:37 AM

Fri, Aug 23

mav committed rS351422: Report Clock Power Management support and status..
Report Clock Power Management support and status.
Fri, Aug 23, 3:17 PM

Wed, Aug 21

mav committed rS351352: Improve NVMe hot unplug handling..
Improve NVMe hot unplug handling.
Wed, Aug 21, 8:17 PM
mav committed rS351320: Formalize NVMe controller consumer life cycle..
Formalize NVMe controller consumer life cycle.
Wed, Aug 21, 2:17 AM

Aug 16 2019

mav committed rS351138: Forgotten part of r351137..
Forgotten part of r351137.
Aug 16 2019, 8:30 PM
mav added a comment to D18819: NTB Tool: Test driver for NTB hardware drivers..

Looking through the code (sorry for enormous delay), I found significant number of random issues. That is why I made some efforts to clean up the code as I see fit, not rewriting it too much, but making it build on amd64 and i386 and quickly testing functionality. If you have any objections or improvements, I'll happily discuss them.

Aug 16 2019, 8:18 PM
mav committed rS351137: NTB Tool: Test driver for NTB hardware drivers..
NTB Tool: Test driver for NTB hardware drivers.
Aug 16 2019, 8:14 PM
mav closed D18819: NTB Tool: Test driver for NTB hardware drivers..
Aug 16 2019, 8:14 PM
mav committed rS351134: Add support for 'j', 't' and 'z' flags to kernel sscanf()..
Add support for 'j', 't' and 'z' flags to kernel sscanf().
Aug 16 2019, 7:46 PM

Aug 15 2019

mav committed rS351107: Fix i386 build..
Fix i386 build.
Aug 15 2019, 11:56 PM
mav committed rS351105: Limit memory window usage in ntb_transport to 256MB..
Limit memory window usage in ntb_transport to 256MB.
Aug 15 2019, 10:56 PM
mav added a comment to D18832: NTB Perf: Tool to measure performance of NTB hw drivers.

The code also seems to not build on i386. I haven't looked close, but when I tried to build other thing, it failed.

Aug 15 2019, 5:22 PM
mav committed rS351084: Add NTB modules to i386 build..
Add NTB modules to i386 build.
Aug 15 2019, 4:27 PM
mav committed rS351083: Fix i386 LINT build after r351056..
Fix i386 LINT build after r351056.
Aug 15 2019, 4:22 PM
mav added a comment to D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.

And could you also write small man page so that people would know about the driver and to which hardware it applies.

Aug 15 2019, 2:15 PM
mav committed rS351072: Implement new methods for Intel and PLX NTB..
Implement new methods for Intel and PLX NTB.
Aug 15 2019, 2:11 PM
mav added a comment to D18832: NTB Perf: Tool to measure performance of NTB hw drivers.

Have you tried to run this code on debug kernel? On fresh head with INVARIANTS, WITNESS, etc. it complains and crashes immediately on attempt to sleep under mutex in many places (sysctl, memory allocations, etc).

Aug 15 2019, 1:59 AM

Aug 14 2019

mav committed rS351056: Add support for PCI Device ID 0x148B in ntb_hw_amd driver..
Add support for PCI Device ID 0x148B in ntb_hw_amd driver.
Aug 14 2019, 10:35 PM
mav closed D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver.
Aug 14 2019, 10:35 PM
D20892: Add support for PCI Device ID 0x148B in ntb_hw_amd driver is now accepted and ready to land.

Looks good to me. I'll commit it as soon as test build completes.

Aug 14 2019, 8:52 PM
mav committed rS351038: Print few more useful identify fields..
Print few more useful identify fields.
Aug 14 2019, 5:36 PM
mav committed rS351028: Report NOIOB and NPWG fields as stripe size..
Report NOIOB and NPWG fields as stripe size.
Aug 14 2019, 4:12 PM
mav committed rS351006: Add missing break statements in r351004..
Add missing break statements in r351004.
Aug 14 2019, 2:02 AM

Aug 13 2019

mav committed rS351004: Make nvd(4) report NGUID or EUI64 as GEOM::lunid..
Make nvd(4) report NGUID or EUI64 as GEOM::lunid.
Aug 13 2019, 9:49 PM
mav committed rS350999: MFC r350961: Missed part of r350523..
MFC r350961: Missed part of r350523.
Aug 13 2019, 7:29 PM
mav committed rS350996: MFC kernel part of r350523, r350524, r350961:.
MFC kernel part of r350523, r350524, r350961:
Aug 13 2019, 7:23 PM
mav committed rS350995: MFC r350961: Missed part of r350523..
MFC r350961: Missed part of r350523.
Aug 13 2019, 7:18 PM

Aug 12 2019

mav committed rS350961: Missed part of r350523..
Missed part of r350523.
Aug 12 2019, 9:52 PM
mav committed rS350960: MFC r342358 (by imp): Try the first 256 units with nvmecontrol devlist..
MFC r342358 (by imp): Try the first 256 units with nvmecontrol devlist.
Aug 12 2019, 8:35 PM