Page MenuHomeFreeBSD

mav (Alexander Motin)
User

Projects

User Details

User Since
Jun 3 2014, 6:27 PM (232 w, 4 d)

Recent Activity

Wed, Nov 14

mav added a comment to D17860: <<Two NVMe Bootup hang>.

I have feeling it is a workaround of some other problem. Shouldn't we have fully operational scheduler at that point when EARLY_AP_STARTUP is enabled? This change may open the races this code intended to handle.

Wed, Nov 14, 3:59 PM
mav added reviewers for D17860: <<Two NVMe Bootup hang>: kib, jhb.
Wed, Nov 14, 3:56 PM

Sat, Nov 10

mav committed rS340311: Do not ignore arc_adjust() return value..
Do not ignore arc_adjust() return value.
Sat, Nov 10, 1:58 AM
mav closed D17927: Do not ignore arc_adjust() return value.
Sat, Nov 10, 1:58 AM
mav added inline comments to D17927: Do not ignore arc_adjust() return value.
Sat, Nov 10, 1:42 AM

Fri, Nov 9

mav created D17927: Do not ignore arc_adjust() return value.
Fri, Nov 9, 6:02 PM
mav added a member for ZFS: mav.
Fri, Nov 9, 5:59 PM

Sat, Nov 3

mav committed rS340096: 9952 Block size change during zfs receive drops spill block.
9952 Block size change during zfs receive drops spill block
Sat, Nov 3, 5:18 AM
mav committed rS340096: 9952 Block size change during zfs receive drops spill block.
9952 Block size change during zfs receive drops spill block
Sat, Nov 3, 5:15 AM

Fri, Nov 2

mav committed rS340071: Adjust SiS 966/968 HDA controller naming..
Adjust SiS 966/968 HDA controller naming.
Fri, Nov 2, 5:02 PM

Wed, Oct 31

mav added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

Have you tried to investigate whether keeping only VREF_ENABLE_MASK would be enough? I could have some more sense in general, since the driver has no way to know what VREF is needed in specific case. Same time other bits there are pretty logical.

Wed, Oct 31, 2:28 PM

Wed, Oct 24

mav accepted D17576: Allow changing lagg(4) MTU.

I have no specific objections. Looks good to me. It just looks slightly odd, that MTU is handled different from other properties -- set before interface addition to LAGG, while multicast filters set after just before protocol initialization, and capabilities are set after the protocol initialization. As one of downsides this different order required addition of duplicate checks for LAGG nesting.

Wed, Oct 24, 4:02 PM · network

Tue, Oct 23

mav resigned from D17644: Add support for AMD eMMC controller HS400 mode.

Unfortunately I haven't touched this area for several years and don't know details of modern transfer modes.

Tue, Oct 23, 2:49 PM

Oct 19 2018

mav committed rS339441: MFC r339372: Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE..
MFC r339372: Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE.
Oct 19 2018, 4:37 AM
mav committed rS339440: MFC r339329: Add ZIO_TYPE_FREE support for indirect vdevs..
MFC r339329: Add ZIO_TYPE_FREE support for indirect vdevs.
Oct 19 2018, 4:30 AM
mav committed rS339439: MFC r339335: Avoid zero-sized kmem_alloc() in vdev_compact_children()..
MFC r339335: Avoid zero-sized kmem_alloc() in vdev_compact_children().
Oct 19 2018, 4:28 AM

Oct 16 2018

mav accepted D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).

I have no particular objections, just quietly sighing that this area remains so tangled. I haven't investigated the area much recently, but it seems like WDAT-based attach could be cleaner, if it is a widespread standard and does not conflict too badly with existing drivers. Having watchdog drivers enabled in FreeNAS for years we had huge number of complains, caused by random platform specifics, and obtaining some valid configuration directly from platform in face of this table could be priceless.

Oct 16 2018, 3:06 PM

Oct 15 2018

mav committed rS339372: Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE..
Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE.
Oct 15 2018, 9:59 PM

Oct 13 2018

mav committed rS339345: MFC r339288: Remove extra thread_exit() call left after r329802..
MFC r339288: Remove extra thread_exit() call left after r329802.
Oct 13 2018, 3:13 AM

Oct 12 2018

mav accepted D17513: Add missing performance optimization of AVL tree comparator functions.
Oct 12 2018, 5:26 PM
mav committed rS339335: Avoid zero-sized kmem_alloc() in vdev_compact_children()..
Avoid zero-sized kmem_alloc() in vdev_compact_children().
Oct 12 2018, 4:55 PM
mav committed rS339329: Add ZIO_TYPE_FREE support for indirect vdevs..
Add ZIO_TYPE_FREE support for indirect vdevs.
Oct 12 2018, 3:14 PM
mav closed D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 12 2018, 3:14 PM · ZFS
mav committed rS339324: MFC r339197: Add sysctls for dbuf metadata cache variables added in r336959..
MFC r339197: Add sysctls for dbuf metadata cache variables added in r336959.
Oct 12 2018, 1:11 AM

Oct 11 2018

mav added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:16 PM · ZFS
mav created D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:06 PM · ZFS
mav committed rS339306: MFC r339237: Fix r336951 mismerge -- use of uninitialized variable..
MFC r339237: Fix r336951 mismerge -- use of uninitialized variable.
Oct 11 2018, 3:12 PM

Oct 10 2018

mav committed rS339288: Remove extra thread_exit() call left after r329802..
Remove extra thread_exit() call left after r329802.
Oct 10 2018, 4:35 PM
mav added inline comments to rS329802: MFV r329799, r329800:.
Oct 10 2018, 3:34 PM
mav accepted D17495: Fix deadlock in IO pipeline.

Dropping locks inside the function is a mess, but I don't see specific problems.

Oct 10 2018, 3:10 PM
mav accepted D17494: Add missing ZFS sysctls.
Oct 10 2018, 2:37 PM

Oct 8 2018

mav committed rS339237: Fix r336951 mismerge -- use of uninitialized variable..
Fix r336951 mismerge -- use of uninitialized variable.
Oct 8 2018, 3:19 PM

Oct 5 2018

mav committed rS339197: Add sysctls for dbuf metadata cache variables added in r336959..
Add sysctls for dbuf metadata cache variables added in r336959.
Oct 5 2018, 4:06 PM

Oct 3 2018

mav committed rS339158: MFC r337567 (by mmacy):.
MFC r337567 (by mmacy):
Oct 3 2018, 5:10 PM
mav committed rS339153: MFC r338869: MFV r338866: 9700 ZFS resilvered mirror does not balance reads.
MFC r338869: MFV r338866: 9700 ZFS resilvered mirror does not balance reads
Oct 3 2018, 3:36 PM
mav committed rS339152: MFC r337972: 9751 Allocation throttling misplacing ditto blocks.
MFC r337972: 9751 Allocation throttling misplacing ditto blocks
Oct 3 2018, 3:35 PM
mav committed rS339151: MFC r337970: 9738 Fix third block copy allocations, broken at 9112..
MFC r337970: 9738 Fix third block copy allocations, broken at 9112.
Oct 3 2018, 3:35 PM
mav committed rS339150: MFC r337923: Make vfs.zfs.zio.dva_throttle_enabled sysctl writable..
MFC r337923: Make vfs.zfs.zio.dva_throttle_enabled sysctl writable.
Oct 3 2018, 3:33 PM
mav committed rS339149: MFC r337883: Add couple tunables/sysctl, missed in r336949..
MFC r337883: Add couple tunables/sysctl, missed in r336949.
Oct 3 2018, 3:33 PM
mav committed rS339148: MFC r337870: Fix mismerge in r337196..
MFC r337870: Fix mismerge in r337196.
Oct 3 2018, 3:31 PM
mav committed rS339147: MFC r337229: Reduce taskq and context-switch cost of zio pipe.
MFC r337229: Reduce taskq and context-switch cost of zio pipe
Oct 3 2018, 2:59 PM
mav committed rS339146: MFC r337227: MFV r337223:.
MFC r337227: MFV r337223:
Oct 3 2018, 2:59 PM
mav committed rS339145: MFC r337221: MFV r337220: 8375 Kernel memory leak in nvpair code.
MFC r337221: MFV r337220: 8375 Kernel memory leak in nvpair code
Oct 3 2018, 2:58 PM
mav committed rS339144: MFC r337219: MFV r337218: 7261 nvlist code should enforce name length limit.
MFC r337219: MFV r337218: 7261 nvlist code should enforce name length limit
Oct 3 2018, 2:58 PM
mav committed rS339143: MFC r337217: MFV r337216: 7263 deeply nested nvlist can overflow stack.
MFC r337217: MFV r337216: 7263 deeply nested nvlist can overflow stack
Oct 3 2018, 2:57 PM
mav committed rS339142: MFC r337215: MFV 337214:.
MFC r337215: MFV 337214:
Oct 3 2018, 2:56 PM
mav committed rS339141: MFC r337213: MFV r337212:.
MFC r337213: MFV r337212:
Oct 3 2018, 2:55 PM
mav committed rS339140: MFC r337211: MFV r337210: 9577 remove zfs_dbuf_evict_key tsd.
MFC r337211: MFV r337210: 9577 remove zfs_dbuf_evict_key tsd
Oct 3 2018, 2:55 PM
mav committed rS339139: MFC r337209:.
MFC r337209:
Oct 3 2018, 2:54 PM
mav committed rS339138: MFC r337207: MFV r337206: 9338 moved dnode has incorrect dn_next_type.
MFC r337207: MFV r337206: 9338 moved dnode has incorrect dn_next_type
Oct 3 2018, 2:53 PM
mav committed rS339137: MFC r337205:.
MFC r337205:
Oct 3 2018, 2:52 PM
mav committed rS339136: MFC r337202: MFV r337200:.
MFC r337202: MFV r337200:
Oct 3 2018, 2:52 PM
mav committed rS339135: MFC r337201: Fix build after r337196 mismerge..
MFC r337201: Fix build after r337196 mismerge.
Oct 3 2018, 2:51 PM
mav committed rS339134: MFC r337198: MFV r337197: 9456 ztest failure in zil_commit_waiter_timeout.
MFC r337198: MFV r337197: 9456 ztest failure in zil_commit_waiter_timeout
Oct 3 2018, 2:50 PM
mav committed rS339133: MFC r337196: MFV r337195: 9454 ::zfs_blkstats should count embedded blocks.
MFC r337196: MFV r337195: 9454 ::zfs_blkstats should count embedded blocks
Oct 3 2018, 2:50 PM
mav committed rS339132: MFC r337194: MFV r337193:.
MFC r337194: MFV r337193:
Oct 3 2018, 2:49 PM
mav committed rS339131: MFC r337191:.
MFC r337191:
Oct 3 2018, 2:49 PM
mav committed rS339130: MFC r337185:.
MFC r337185:
Oct 3 2018, 2:48 PM
mav committed rS339129: MFC r337183:.
MFC r337183:
Oct 3 2018, 2:47 PM
mav committed rS339128: MFC r337181: 9539 Make zvol operations use _by_dnode routines.
MFC r337181: 9539 Make zvol operations use _by_dnode routines
Oct 3 2018, 2:46 PM
mav committed rS339127: MFC r337179: 9523 Large alloc in zdb can cause trouble.
MFC r337179: 9523 Large alloc in zdb can cause trouble
Oct 3 2018, 2:46 PM
mav committed rS339126: MFC r337177:.
MFC r337177:
Oct 3 2018, 2:44 PM
mav committed rS339125: MFC r337172, MFV r337171:.
MFC r337172, MFV r337171:
Oct 3 2018, 2:43 PM
mav committed rS339120: MFC r337169: MFV r337167: 9442 decrease indirect block size of spacemaps.
MFC r337169: MFV r337167: 9442 decrease indirect block size of spacemaps
Oct 3 2018, 3:14 AM
mav committed rS339119: MFC r337163: MFV r337161: 9512 zfs remap poolname@snapname coredumps.
MFC r337163: MFV r337161: 9512 zfs remap poolname@snapname coredumps
Oct 3 2018, 3:14 AM
mav committed rS339118: MFC r337160:.
MFC r337160:
Oct 3 2018, 2:52 AM
mav committed rS339117: MFC r337063: MFV r316926:.
MFC r337063: MFV r316926:
Oct 3 2018, 2:51 AM
mav committed rS339116: MFC r337030: MFV r337029:.
MFC r337030: MFV r337029:
Oct 3 2018, 2:50 AM
mav committed rS339115: MFC r337028: MFV r337027:.
MFC r337028: MFV r337027:
Oct 3 2018, 2:49 AM
mav committed rS339114: MFC r337025: MFV r337022:.
MFC r337025: MFV r337022:
Oct 3 2018, 2:48 AM
mav committed rS339113: MFC r337021: MFV r337020:9443 panic when scrub a v10 pool.
MFC r337021: MFV r337020:9443 panic when scrub a v10 pool
Oct 3 2018, 2:19 AM
mav committed rS339112: MFC r337017: MFV r337014:.
MFC r337017: MFV r337014:
Oct 3 2018, 2:18 AM
mav committed rS339111: MFC r337007: MFV r336991, r337001:.
MFC r337007: MFV r336991, r337001:
Oct 3 2018, 2:16 AM
mav committed rS339110: MFC r336961:.
MFC r336961:
Oct 3 2018, 2:14 AM
mav committed rS339109: MFC r336959: MFV r336958: 9337 zfs get all is slow due to uncached metadata.
MFC r336959: MFV r336958: 9337 zfs get all is slow due to uncached metadata
Oct 3 2018, 2:14 AM
mav committed rS339108: MFC r336956: MFV r336955: 9236 nuke spa_dbgmsg.
MFC r336956: MFV r336955: 9236 nuke spa_dbgmsg
Oct 3 2018, 2:13 AM
mav committed rS339107: MFC r336954:.
MFC r336954:
Oct 3 2018, 2:12 AM
mav committed rS339106: MFC r336951: MFV r336950: 9290 device removal reduces redundancy of mirrors.
MFC r336951: MFV r336950: 9290 device removal reduces redundancy of mirrors
Oct 3 2018, 2:11 AM
mav committed rS339105: MFC r336949:.
MFC r336949:
Oct 3 2018, 2:10 AM
mav committed rS339104: MFC r336947: MFV r336946: 9238 ZFS Spacemap Encoding V2.
MFC r336947: MFV r336946: 9238 ZFS Spacemap Encoding V2
Oct 3 2018, 2:09 AM
mav committed rS339103: MFC r336945: MFV r336944: 9286 want refreservation=auto.
MFC r336945: MFV r336944: 9286 want refreservation=auto
Oct 3 2018, 2:08 AM
mav committed rS339102: MFC r336943:.
MFC r336943:
Oct 3 2018, 2:07 AM

Oct 1 2018

mav committed rS339033: MFC r338913: Fix use-after-free in RAID0 error reporting of GEOM_RAID..
MFC r338913: Fix use-after-free in RAID0 error reporting of GEOM_RAID.
Oct 1 2018, 4:02 AM

Sep 27 2018

mav committed rS338975: MFC r334810 (by benno), r338205, r338206:.
MFC r334810 (by benno), r338205, r338206:
Sep 27 2018, 5:22 PM
mav committed rS338974: MFC r333307 (by sbruno):.
MFC r333307 (by sbruno):
Sep 27 2018, 5:11 PM
mav committed rS338966: MFC r333081 (by eadler):.
MFC r333081 (by eadler):
Sep 27 2018, 2:57 PM

Sep 25 2018

mav accepted D17307: Per-session locking for cryptosoft.
Sep 25 2018, 5:10 PM
mav added inline comments to D17307: Per-session locking for cryptosoft.
Sep 25 2018, 4:49 PM

Sep 24 2018

mav committed rS338913: Fix use-after-free in RAID0 error reporting of GEOM_RAID..
Fix use-after-free in RAID0 error reporting of GEOM_RAID.
Sep 24 2018, 4:59 PM

Sep 21 2018

mav committed rS338869: MFV r338866: 9700 ZFS resilvered mirror does not balance reads.
MFV r338866: 9700 ZFS resilvered mirror does not balance reads
Sep 21 2018, 9:56 PM
mav committed rS338866: 9700 ZFS resilvered mirror does not balance reads.
9700 ZFS resilvered mirror does not balance reads
Sep 21 2018, 8:38 PM
mav committed rS338865: 9626 move 'static xuio_stats_t xuio_stats' to file where it use.
9626 move 'static xuio_stats_t xuio_stats' to file where it use
Sep 21 2018, 8:36 PM
mav committed rS338864: 9672 Reserve a ZFS replication stream feature flag for ZSTD compression.
9672 Reserve a ZFS replication stream feature flag for ZSTD compression
Sep 21 2018, 8:34 PM

Sep 19 2018

mav committed rS338809: MFC r317659, r317752:.
MFC r317659, r317752:
Sep 19 2018, 7:54 PM
mav committed rS338808: MFC r308750:.
MFC r308750:
Sep 19 2018, 7:53 PM
mav accepted D17233: zfs: depessimize zfs_root with rmlocks.

Looks good to me, but VFS and ZPL are not my favorite areas to know all details.

Sep 19 2018, 5:18 PM

Sep 6 2018

mav committed rS338494: Add missing copyin() to access LUN and port ioctl arguments..
Add missing copyin() to access LUN and port ioctl arguments.
Sep 6 2018, 2:03 PM

Aug 31 2018

mav committed rS338403: MFV r338288: Unblock speculative prefetcher also on pool creation..
MFV r338288: Unblock speculative prefetcher also on pool creation.
Aug 31 2018, 1:50 AM

Aug 27 2018

mav committed rS338333: MFC r338105: Remove extra M_ZERO from NG_MKRESPONSE() argument..
MFC r338105: Remove extra M_ZERO from NG_MKRESPONSE() argument.
Aug 27 2018, 3:42 AM

Aug 24 2018

mav committed rS338288: Unblock speculative prefetcher also on pool creation..
Unblock speculative prefetcher also on pool creation.
Aug 24 2018, 1:59 AM