iscsi: Move valid_iscsi_name to libiscsiutil
ClosedPublic
Actions

Authored by jhb on Jan 22 2025, 7:52 PM.

Details

Reviewers

trasz
asomers
mav

Commits

rG944493636924: iscsi: Move valid_iscsi_name to libiscsiutil
rGdd3603749cb7: iscsi: Move valid_iscsi_name to libiscsiutil

Summary

While here, use isxdigit(3) instead of a home-rolled version.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 22 2025, 7:52 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2025, 7:52 PM

jhb requested review of this revision.Jan 22 2025, 7:52 PM

jhb added a child revision: D48594: ctld: Use bool in uclparse.c.

Harbormaster completed remote builds in B61886: Diff 149717.Jan 22 2025, 7:53 PM

This LGTM. But now libiscsiutil is just begging for some ATF tests.

This revision is now accepted and ready to land.Jan 22 2025, 8:00 PM

I have some WIP to add nvme support to ctld and this series of commits are some cleanups before the meatier changes. To date libiscsiutil has just been a place to reduce code duplication between iscsiutil and ctld. Some bits like the log_* wrapper functions aren't iscsi specific and probably don't belong there but would be duplicated otherwise. :(

mav accepted this revision.Jan 23 2025, 4:22 PM

Closed by commit rGdd3603749cb7: iscsi: Move valid_iscsi_name to libiscsiutil (authored by jhb). · Explain WhyJan 24 2025, 2:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGdd3603749cb7: iscsi: Move valid_iscsi_name to libiscsiutil.

jhb added a commit: rG944493636924: iscsi: Move valid_iscsi_name to libiscsiutil.Jan 27 2026, 6:44 PM