Differential D48596

ctld: Factor our code to setup a listening socket into a separate function
ClosedPublic
Actions

Authored by jhb on Jan 22 2025, 7:53 PM.

Tags

None

Referenced Files

	F132983596: D48596.diff
	Tue, Oct 21, 7:56 PM

	Unknown Object (File)
	Thu, Oct 9, 2:22 AM

	Unknown Object (File)
	Wed, Oct 1, 6:11 PM

	Unknown Object (File)
	Aug 31 2025, 1:14 AM

	Unknown Object (File)
	Aug 28 2025, 4:24 PM

	Unknown Object (File)
	Aug 26 2025, 9:49 PM

	Unknown Object (File)
	Aug 14 2025, 11:23 PM

	Unknown Object (File)
	Aug 14 2025, 10:36 PM

View All 48 Files

Subscribers

Details

Reviewers

trasz
asomers
mav

Commits

rGb4a5ab97c810: ctld: Factor out code to setup a listening socket into a separate function

Summary

While here:

Reuse the address family from the addrinfo structure instead of calling getsockname(2) on the socket.

Remove a bogus comment about the PCP option.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 22 2025, 7:53 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2025, 7:53 PM

jhb requested review of this revision.Jan 22 2025, 7:53 PM

jhb added a parent revision: D48595: ctld: Use nvlist instead of home-rolled name-value lists.

jhb added a child revision: D48597: ctld: Use kevent(2) for socket events rather than select(2).

Harbormaster completed remote builds in B61889: Diff 149720.Jan 22 2025, 7:53 PM

asomers accepted this revision.Jan 22 2025, 10:26 PM

This revision is now accepted and ready to land.Jan 22 2025, 10:26 PM

mav accepted this revision.Jan 23 2025, 4:48 PM

Closed by commit rGb4a5ab97c810: ctld: Factor out code to setup a listening socket into a separate function (authored by jhb). · Explain WhyJan 24 2025, 2:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb4a5ab97c810: ctld: Factor out code to setup a listening socket into a separate function.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

199 lines

Diff 149885

usr.sbin/ctld/ctld.c

Loading...