asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (192 w, 6 d)

Recent Activity

Today

asomers created D13979: geli: append "/eli" to the underlying provider's physical path.
Fri, Jan 19, 2:26 AM

Yesterday

asomers committed rS328108: gnop(8): add the ability to set a nop provider's physical path.
gnop(8): add the ability to set a nop provider's physical path
Thu, Jan 18, 5:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Jan 18, 5:57 AM

Mon, Jan 15

asomers added a comment to D13801: Reject the absurd user and group names "." and ".."..

What makes . and .. more bogus that ...? The PR says, bug the comment does not. The comment should say something about preventing unintended default home directories that are too encompassing. But . and .. aren't the only special directories. What about .zfs, .snap, and .sujournal? And if /home is mounted over NFS, then there may be other special files as well. For example, Netapp creates a .snapshot directory.

Mon, Jan 15, 5:53 PM

Fri, Jan 12

asomers committed rS327863: MFC r327862.
MFC r327862
Fri, Jan 12, 4:32 AM
asomers committed rS327862: dhclient(8): add missing include.
dhclient(8): add missing include
Fri, Jan 12, 4:26 AM
asomers committed rS327861: MFC r315292.
MFC r315292
Fri, Jan 12, 4:25 AM
asomers committed rS327856: MFC r313962, r313972-r313973, r315230.
MFC r313962, r313972-r313973, r315230
Fri, Jan 12, 12:31 AM
asomers committed rS327855: MFC r309373 (by bdrewery).
MFC r309373 (by bdrewery)
Fri, Jan 12, 12:26 AM
asomers committed rS327854: MFC r326834, r326853.
MFC r326834, r326853
Fri, Jan 12, 12:01 AM
asomers committed rS327853: MFC r326799:.
MFC r326799:
Fri, Jan 12, 12:00 AM

Thu, Jan 11

asomers committed rS327852: MFC r326698:.
MFC r326698:
Thu, Jan 11, 11:59 PM
asomers committed rS327851: MFC r326646:.
MFC r326646:
Thu, Jan 11, 11:59 PM
asomers committed rS327850: MFC r326640:.
MFC r326640:
Thu, Jan 11, 11:58 PM
asomers committed rS327849: MFC r326624:.
MFC r326624:
Thu, Jan 11, 11:57 PM
asomers committed rS327848: MFC r326455:.
MFC r326455:
Thu, Jan 11, 11:56 PM

Wed, Jan 10

asomers accepted D13819: Don't store shadow copies of per-process AIO limits..
Wed, Jan 10, 9:12 PM
asomers created D13826: mlock(2): correct documentation for error conditions..
Wed, Jan 10, 5:44 PM
asomers added a comment to D13179: Add "Pull Request" to the devel/subversion commit template.

In that case, @mat, would you like me to commit the part to devel/subversion (so it can be used with base), but not the part to svnadmin?

Wed, Jan 10, 3:15 PM
asomers accepted D13819: Don't store shadow copies of per-process AIO limits..

Other than the descriptions, it all LGTM.

Wed, Jan 10, 3:17 AM

Tue, Jan 9

asomers added a comment to D13179: Add "Pull Request" to the devel/subversion commit template.

@mat is this fine by you?

Tue, Jan 9, 9:25 PM
asomers committed rS327739: Add Pull Request to the Subversion commit template.
Add Pull Request to the Subversion commit template
Tue, Jan 9, 9:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jan 9, 9:02 PM

Mon, Jan 8

asomers added a comment to D13579: gnop(8): add the ability to set a nop provider's physical path.

I don't understand the G_NOP_PHYSPATH_PASSTHROUGH stuff. Can't you just check for non-NULL or non-empty 'physpath' being passed in?

Mon, Jan 8, 7:02 PM
asomers committed rS327685: geli: optimize tests.
geli: optimize tests
Mon, Jan 8, 12:11 AM

Sun, Jan 7

asomers committed rS327683: geli: convert remaining TAP tests to ATF.
geli: convert remaining TAP tests to ATF
Sun, Jan 7, 10:21 PM
asomers committed rS327682: Fix typo from r327666.
Fix typo from r327666
Sun, Jan 7, 9:58 PM
asomers added a reviewer for D13579: gnop(8): add the ability to set a nop provider's physical path: mav.

@mav this is the first GEOM class that needs to be changed in order to fix physpath handling, as we discussed. The tests for every other GEOM class will depend on this.

Sun, Jan 7, 2:59 AM
asomers committed rS327666: geli: fix parallel execution of tests.
geli: fix parallel execution of tests
Sun, Jan 7, 2:30 AM
asomers committed rS327662: geli: convert most tests from TAP to ATF.
geli: convert most tests from TAP to ATF
Sun, Jan 7, 12:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Jan 7, 12:44 AM
asomers added a comment to D13717: geli: convert most tests from TAP to ATF.

@ngie provided feedback outside of Phabricator.

Sun, Jan 7, 12:40 AM

Sun, Dec 31

asomers created D13717: geli: convert most tests from TAP to ATF.
Sun, Dec 31, 7:22 PM

Fri, Dec 29

asomers committed rS327353: geli: fix the resize test on arm64.
geli: fix the resize test on arm64
Fri, Dec 29, 6:43 PM
asomers committed rS327352: Fix a harmless typo from r310786.
Fix a harmless typo from r310786
Fri, Dec 29, 6:09 PM
asomers committed rS327347: geli: factor out some common code in the geli tests.
geli: factor out some common code in the geli tests
Fri, Dec 29, 4:13 PM
asomers committed rS327346: Fix potential TOCTTOU bug in the geli tests.
Fix potential TOCTTOU bug in the geli tests
Fri, Dec 29, 4:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Dec 29, 4:06 PM

Thu, Dec 28

asomers updated the diff for D13666: Fix potential TOCTTOU bug in the geli tests.

Add missing cleanup step

Thu, Dec 28, 7:03 PM
asomers created D13666: Fix potential TOCTTOU bug in the geli tests.
Thu, Dec 28, 6:05 PM

Tue, Dec 26

asomers committed rS327188: MFC r326401:.
MFC r326401:
Tue, Dec 26, 4:02 AM
asomers committed rS327187: MFC r326290:.
MFC r326290:
Tue, Dec 26, 4:00 AM
asomers committed rS327186: MFC r326289:.
MFC r326289:
Tue, Dec 26, 4:00 AM

Fri, Dec 22

asomers planned changes to D13465: man(1): change default pager to "less -s".

Someone pointed out on the mailing list that if I modify man(1), I should also modify every other command with a builtin pager. I'll do that.

Fri, Dec 22, 3:56 AM

Thu, Dec 21

asomers added a comment to D13579: gnop(8): add the ability to set a nop provider's physical path.

@brd this enhancement should allow us to replace all of the SAS phy stuff in the ZFS test suite. After that, the test suite won't require a SAS expander, or even physical hardware. It should be able to run in a VM.

Thu, Dec 21, 11:04 PM
asomers created D13579: gnop(8): add the ability to set a nop provider's physical path.
Thu, Dec 21, 10:58 PM

Dec 20 2017

asomers abandoned D12587: Document __FreeBSD_version 1200049.

Closing this revision because @jhb committed the same information in r51149.

Dec 20 2017, 12:21 AM
asomers added a comment to D12587: Document __FreeBSD_version 1200049.

Then should we remove the extraneous (<revnumber>rXXXXXX</revnumber>) bits from versions 1200039, 1200040, 1200041, 1200042, 1200043, 1200044, 1200046, 1200048, 1200049, 1200052, 1200053, and 1200054? All of those revisions put the same renumber in both the Revision and Release fields.

Dec 20 2017, 12:20 AM

Dec 19 2017

asomers added inline comments to D13427: Add basic tests for chio(1), cp(1), domainname(1), rm(1) and sync(8).
Dec 19 2017, 5:31 PM
asomers added a comment to D12587: Document __FreeBSD_version 1200049.

Are there any changes you want, @mat ?

Dec 19 2017, 12:03 AM

Dec 18 2017

asomers committed rP456676: Add vuxml entry for CVE-2017-16355 to rubygem-passenger.
Add vuxml entry for CVE-2017-16355 to rubygem-passenger
Dec 18 2017, 11:39 PM
asomers closed D13482: Add vuxml entry for CVE-2017-16355 to rubygem-passenger.
Dec 18 2017, 11:39 PM

Dec 15 2017

asomers accepted D13500: Skip gnop tests if the module isn't available.

LGTM. Note that @ngie wrote a macro to do just this for ATF C tests. It's in tests/freebsd_test_suite/macros.h. But I don't think she ever wrote an sh version.

Dec 15 2017, 4:58 PM

Dec 14 2017

asomers added a comment to V7: Should man(1)'s default pager change to "less -s"?.

@deischen less doesn't colorize by default, and it doesn't clear the screen when you're done. I believe that Linux's screen-clearing behavior is due to the terminal, not the pager.

Dec 14 2017, 7:34 PM · manpages
asomers committed rS326853: dhclient(8): raise WARNS to 3.
dhclient(8): raise WARNS to 3
Dec 14 2017, 3:41 PM
asomers accepted D13471: Fix and enable SysV IPC tests..

It's really weird that POSIX requires applications themselves to define mymsg and semun. But I guess that's the way it is...

Dec 14 2017, 1:24 AM
asomers created D13482: Add vuxml entry for CVE-2017-16355 to rubygem-passenger.
Dec 14 2017, 12:24 AM

Dec 13 2017

asomers committed rS326834: dhclient(8): Don't shift through the sign bit of a signed int.
dhclient(8): Don't shift through the sign bit of a signed int
Dec 13 2017, 8:48 PM
asomers committed rS326827: MFC r326101:.
MFC r326101:
Dec 13 2017, 4:22 PM
asomers committed rS326826: MFC r326100:.
MFC r326100:
Dec 13 2017, 4:21 PM
asomers committed rS326825: MFC r326040:.
MFC r326040:
Dec 13 2017, 4:17 PM
asomers added a comment to V7: Should man(1)'s default pager change to "less -s"?.

Good point, @theraven . Which other programs' default pagers should match man's? I count apropos, ftp, mail, makewhatis, mandoc, msgs, ntpq, ntp-keygen, ntpd, ntpdc, sntp, freebsd-update, and mergemaster . Am I leaving any out?

Dec 13 2017, 3:41 PM · manpages

Dec 12 2017

asomers added a comment to V7: Should man(1)'s default pager change to "less -s"?.

Yes, I'll put an entry in UPDATING and in the release notes, too.

Dec 12 2017, 7:53 PM · manpages
asomers added a comment to V7: Should man(1)'s default pager change to "less -s"?.

From a quick test with BHyve's virtual serial port, less and more seem pretty much the same. The usual differences apply of course, but scrolling up and down and searching work the same with both pagers.

Dec 12 2017, 7:42 PM · manpages
asomers committed rP456179: shells/fish: fix 2.7.0 build for arm and arm64.
shells/fish: fix 2.7.0 build for arm and arm64
Dec 12 2017, 6:17 PM
asomers added a comment to V7: Should man(1)'s default pager change to "less -s"?.

Good question, @theraven . I'm not aware of any comprehensive list of differences. The only way to know for sure is grep less_is_more contrib/less/*

Dec 12 2017, 6:12 PM · manpages
asomers created V7: Should man(1)'s default pager change to "less -s"?.
Dec 12 2017, 6:02 PM · manpages
asomers created D13465: man(1): change default pager to "less -s".
Dec 12 2017, 5:58 PM
asomers committed rS326799: less(1): diff reduction vs upstream.
less(1): diff reduction vs upstream
Dec 12 2017, 5:34 PM

Dec 11 2017

asomers requested changes to D13427: Add basic tests for chio(1), cp(1), domainname(1), rm(1) and sync(8).
Dec 11 2017, 10:22 PM
asomers committed rS326782: MFC r304443, r326034, r326065.
MFC r304443, r326034, r326065
Dec 11 2017, 8:47 PM
asomers committed rS326781: MFC r326041:.
MFC r326041:
Dec 11 2017, 8:36 PM
asomers committed rS326780: MFC r326039:.
MFC r326039:
Dec 11 2017, 8:33 PM
asomers committed rS326779: MFC r326036:.
MFC r326036:
Dec 11 2017, 8:31 PM
asomers committed rS326778: MFC r326032:.
MFC r326032:
Dec 11 2017, 8:24 PM
asomers committed rS326777: MFC r325959:.
MFC r325959:
Dec 11 2017, 8:21 PM
asomers committed rP456053: shells/fish: Upgrade to 2.7.0.
shells/fish: Upgrade to 2.7.0
Dec 11 2017, 5:39 PM

Dec 8 2017

asomers added inline comments to D13427: Add basic tests for chio(1), cp(1), domainname(1), rm(1) and sync(8).
Dec 8 2017, 11:30 PM
asomers committed rS326698: at(1): annotate some intended switch-case fallthroughs.
at(1): annotate some intended switch-case fallthroughs
Dec 8 2017, 5:15 PM
asomers committed rS326680: MFC r325947:.
MFC r325947:
Dec 8 2017, 5:32 AM
asomers committed rS326679: MFC r325946:.
MFC r325946:
Dec 8 2017, 5:26 AM
asomers committed rS326678: MFC r325857:.
MFC r325857:
Dec 8 2017, 5:25 AM
asomers committed rS326677: MFC r325817, r325827.
MFC r325817, r325827
Dec 8 2017, 5:21 AM
asomers committed rS326676: MFC r325812:.
MFC r325812:
Dec 8 2017, 4:21 AM

Dec 7 2017

asomers committed rS326652: dc(1): fix modulo operations with fractional inputs.
dc(1): fix modulo operations with fractional inputs
Dec 7 2017, 2:09 AM
asomers closed D13390: dc(1): fix modulo operations with fractional inputs.
Dec 7 2017, 2:09 AM

Dec 6 2017

asomers committed rS326646: Fix a null-pointer dereference and a tautological check in cam_get_device.
Fix a null-pointer dereference and a tautological check in cam_get_device
Dec 6 2017, 11:24 PM
asomers closed D13184: Fix a null-pointer dereference and a tautological check in cam_get_device.
Dec 6 2017, 11:24 PM
asomers committed rS326640: Optimize telldir(3).
Optimize telldir(3)
Dec 6 2017, 10:06 PM
asomers closed D13385: Optimize telldir(3).
Dec 6 2017, 10:06 PM
asomers added a comment to D13385: Optimize telldir(3).
In D13385#279917, @mav wrote:
In D13385#279912, @mav wrote:

Looks good to me, at least until we implement original offset reporting.

What's original offset reporting?

64-bit inode project commit r318736 introduced new field d_off into struct dirent. If supported by all file systems, it would obsolete all this code.

Dec 6 2017, 8:53 PM
asomers added a comment to D13385: Optimize telldir(3).
In D13385#279912, @mav wrote:

Looks good to me, at least until we implement original offset reporting.

Dec 6 2017, 8:38 PM
asomers added inline comments to D13385: Optimize telldir(3).
Dec 6 2017, 5:28 PM
asomers closed D13198: Fix sign-extension error in adagetparams.
Dec 6 2017, 5:01 PM
asomers committed rS326624: cam: fix sign-extension error in adagetparams.
cam: fix sign-extension error in adagetparams
Dec 6 2017, 5:01 PM
asomers added a comment to D13385: Optimize telldir(3).

@mckusick what do you think I should do on 32-bit architectures for directories with > 2 billion files? telldir(3) can't return an error, so my choices are basically to assert() or to return a bogus value that won't work with seekdir().

Dec 6 2017, 5:00 PM
asomers created D13390: dc(1): fix modulo operations with fractional inputs.
Dec 6 2017, 4:08 AM
asomers added inline comments to D13387: Define xpt_path_inq..
Dec 6 2017, 3:13 AM
asomers added a comment to D13179: Add "Pull Request" to the devel/subversion commit template.

@emaste, did you mean to approve D13178 instead? That's the review for the src repo. This review is for ports.

Dec 6 2017, 1:58 AM

Dec 5 2017

asomers created D13385: Optimize telldir(3).
Dec 5 2017, 10:39 PM