- User Since
- May 9 2014, 11:04 PM (279 w, 4 d)
My experience is not directly applicable. All I did was add kqueue support for /dev/fuse, not for files stored on fusefs, and I was only concerned with EVFILT_(READ|WRITE), not EVFILT_VNODE. I would suggest that before you continue working on this patch, you write a test case.
Mon, Sep 16
Sun, Sep 15
Fri, Sep 13
Thu, Sep 12
Wed, Sep 11
Explicitly state that a timestamp may not be returned
Mon, Sep 9
Sat, Sep 7
Fri, Sep 6
Wed, Sep 4
Tue, Sep 3
Add one more change that I forgot to save before starting the review
Since only a few options have changed, what about defining constants like #DEFINE ADDRTYPE_OPT 'k' before including options.h, and composing the getopt string like we already do with ADDOPTS. Then in options.c, for those options whose flags differ between the two programs, compose the error message at runtime.
So what's the plan for ping -6 vs ping? Are you going to have two different copies of options_parse?
Sun, Sep 1
Yes, that's about what I had in mind. But did you intend to set f_sock_buff_size in the getopt loop?
Sat, Aug 31
Thu, Aug 29
Good catch. Looks like those have been dead code ever since r292373.
Wed, Aug 28
Tue, Aug 27
Accomodate buggy or malicious fuse servers that always return ERANGE for
FUSE_LISTXATTR. Instead of restarting within the VOP; return ERESTART.
That way the blocked process will be killable.
Mon, Aug 26
Sat, Aug 24
Well, it fixes the build. But now the program segfaults.
The build fails on sparc64 and powerpcspe with this error. Weirdly, it passed on powerpc and powerpc64; I don't know why:
/home/asomers/freebsd/base/head/sbin/ping/ping.c: In function 'main': /home/asomers/freebsd/base/head/sbin/ping/ping.c:923: warning: cast increases required alignment of target type
You still need to add entries to UPDATING and ObsoleteFiles.inc. Other than that, it looks good.
Fri, Aug 23
This revision needs to be rebased since the changes to -n and -H.
Now it doesn't even build:
/usr/home/somers/freebsd/base/head/sbin/ping/main.c:249:1: error: redefinition of 'main' main(int argc, char *argv) ^ /usr/home/somers/freebsd/base/head/sbin/ping/main.c:59:1: note: previous definition is here main(int argc, char *argv) ^ /usr/home/somers/freebsd/base/head/sbin/ping/main.c:331:1: error: redefinition of 'usage' usage(void) ^ /usr/home/somers/freebsd/base/head/sbin/ping/main.c:141:1: note: previous definition is here usage(void) ^ 2 errors generated.
Oh, and you need to update rescue/rescue/Makefile, too.
Don't forget to add an entry to UPDATING and to ObsoleteFiles.inc
One more thing: you should normally add an entry in UPDATING letting people know that the options have changed so they can update their scripts. I'll go ahead and write it this time.