Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (227 w, 4 d)

Recent Activity

Mon, Sep 17

asomers accepted D17202: Fix the nvpair leak in vdev_geom_read_config()..

Oops, looks like this one's my fault. Thanks for fixing it, Mark!

Mon, Sep 17, 3:55 PM

Tue, Sep 11

asomers accepted D17110: Add simple tests for SO_REUSEPORT_LB sockets..

Do the tests still pass for you? After your latest change, I get the "connection wasn't accepted" error every time.

Yes, I just noticed that. (I rebuilt and ran the tests on two different machines by accident.) It seems like the polling loop is needed after all, which is somewhat surprising to me given that we're using a blocking connect().

I guess this is expected behaviour for TCP. connect(2) returns once the SYN|ACK reply is received, but the child socket isn't complete until the final ACK is received, so there's a window that we have to account for.

Tue, Sep 11, 4:16 PM
asomers added a comment to D17110: Add simple tests for SO_REUSEPORT_LB sockets..

Do the tests still pass for you? After your latest change, I get the "connection wasn't accepted" error every time.

Tue, Sep 11, 3:20 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Tue, Sep 11, 3:16 PM
asomers added inline comments to D17110: Add simple tests for SO_REUSEPORT_LB sockets..
Tue, Sep 11, 2:49 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Tue, Sep 11, 2:42 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Tue, Sep 11, 3:13 AM
asomers added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

  1. The Wayback machine shows me that IANA sometimes removes a port assignment. Sadly, I haven't been able to find any official historical information. What will FreeBSD's policy regarding removing assignments be?

I doubt there has ever been such a policy. By default, we will remove it on the next update. I think this de facto policy will be sufficient. Administrators who need to keep the assignment can simply add it to this file on their systems.

Tue, Sep 11, 3:10 AM
asomers accepted D17110: Add simple tests for SO_REUSEPORT_LB sockets..

All good here.

Tue, Sep 11, 3:07 AM

Mon, Sep 10

asomers added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

Mon, Sep 10, 11:22 PM
asomers added a comment to D17110: Add simple tests for SO_REUSEPORT_LB sockets..

In fact, you don't even need the second process for this test. It's possible to do this entirely with one single-threaded process. See the "accept_success" test in tests/sys/audit/network.c for an example. Basically it goes like this:

for (i=0; i<sdcnt; i++)
    listen(server_fd[i]);
while (true) {
    client_fd = socket();
    client_fd.connect(server_addr);  //blocking, but returns immediately
    for ((i=0; i<sdcnt; i++) {
        if (accept(server_fd[i]) == 0) {    // non-blocking
            acceptcnt[i]++;
            break;
        }
    }
}

What do you think of the single-threaded approach?

Mon, Sep 10, 7:26 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Mon, Sep 10, 6:45 PM
asomers added inline comments to D17110: Add simple tests for SO_REUSEPORT_LB sockets..
Mon, Sep 10, 6:42 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Mon, Sep 10, 6:20 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Mon, Sep 10, 5:41 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Mon, Sep 10, 5:28 PM
asomers accepted D17096: geli init with multiple providers - fix init and fix -B "none".
Mon, Sep 10, 2:40 PM
asomers added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Mon, Sep 10, 2:27 PM
asomers added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Mon, Sep 10, 1:55 PM
asomers accepted D17096: geli init with multiple providers - fix init and fix -B "none".
Mon, Sep 10, 1:13 AM

Thu, Aug 30

asomers committed rS336914: Make timespecadd(3) and friends public.
Make timespecadd(3) and friends public
Thu, Aug 30, 2:56 AM

Fri, Aug 24

asomers committed rP477975: devel/kcov: upgrade to v36.
devel/kcov: upgrade to v36
Fri, Aug 24, 6:29 PM

Thu, Aug 23

asomers committed rS338258: tftp(1): switch default transfer mode to binary.
tftp(1): switch default transfer mode to binary
Thu, Aug 23, 5:00 PM
asomers closed D16869: tftp(1): switch default transfer mode to binary.
Thu, Aug 23, 5:00 PM
asomers created D16869: tftp(1): switch default transfer mode to binary.
Thu, Aug 23, 3:33 PM

Wed, Aug 22

asomers committed rS338216: tftpd: Fix data corruption bug with netascii.
tftpd: Fix data corruption bug with netascii
Wed, Aug 22, 11:31 PM
asomers closed D16853: tftpd: Fix data corruption bug with netascii.
Wed, Aug 22, 11:31 PM
asomers added a comment to D16853: tftpd: Fix data corruption bug with netascii.

Thanks @cem. I know I can always count on you for a good review.

Wed, Aug 22, 11:28 PM
asomers updated the diff for D16853: tftpd: Fix data corruption bug with netascii.

Fix an old typo in a comment

Wed, Aug 22, 11:04 PM
asomers added inline comments to D16853: tftpd: Fix data corruption bug with netascii.
Wed, Aug 22, 11:04 PM
asomers created D16853: tftpd: Fix data corruption bug with netascii.
Wed, Aug 22, 10:30 PM

Aug 17 2018

asomers committed rS337984: Fix sys/netipsec/tunnel tests after r337736.
Fix sys/netipsec/tunnel tests after r337736
Aug 17 2018, 6:37 PM
asomers committed rS337973: Add Modbus Application Protocol to /etc/services.
Add Modbus Application Protocol to /etc/services
Aug 17 2018, 3:19 PM

Aug 16 2018

asomers committed rS337933: Fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0
Aug 16 2018, 11:50 PM
asomers closed D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 11:50 PM
asomers added inline comments to D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 11:47 PM
asomers added inline comments to D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 11:36 PM
asomers updated the diff for D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.

create a common ATF_REQUIRE_SYSCTL_INT macro

Aug 16 2018, 10:41 PM
asomers committed rS337930: Revert r337929.
Revert r337929
Aug 16 2018, 10:04 PM
asomers committed rS337929: Fix Coverity warnings about mkstemp in tests.
Fix Coverity warnings about mkstemp in tests
Aug 16 2018, 9:36 PM
asomers created D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 8:44 PM
asomers committed rS337911: Fix the sys/opencrypto/runtests test when aesni(4) is already loaded.
Fix the sys/opencrypto/runtests test when aesni(4) is already loaded
Aug 16 2018, 3:45 PM

Aug 14 2018

asomers committed rS337779: tftp: Close a resource leak when putting files.
tftp: Close a resource leak when putting files
Aug 14 2018, 5:20 PM
asomers accepted D16709: mergemaster: better defaults for SOURCEDIR.
Aug 14 2018, 3:48 PM
asomers accepted D16709: mergemaster: better defaults for SOURCEDIR.

I use mergemaster the same way. Apart from the "default" word choice, this revision LGTM.

Aug 14 2018, 3:25 PM

Aug 8 2018

asomers committed rS337497: Switch the default pager for most commands to less.
Switch the default pager for most commands to less
Aug 8 2018, 7:24 PM
asomers closed D13465: man(1): change default pager to "less -s".
Aug 8 2018, 7:24 PM
asomers committed rS337482: Bring VOP_LOOKUP(9) up to date.
Bring VOP_LOOKUP(9) up to date
Aug 8 2018, 6:50 PM
asomers closed D16629: Bring VOP_LOOKUP(9) up to date.
Aug 8 2018, 6:50 PM
asomers created D16629: Bring VOP_LOOKUP(9) up to date.
Aug 8 2018, 4:53 PM

Aug 4 2018

asomers added a member for Audit: asomers.
Aug 4 2018, 2:06 PM
asomers accepted D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

I don't see anything wrong with this review. However, since you're modifying the boot loader you should check with @imp.

Aug 4 2018, 2:05 PM
asomers added a comment to D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

What's anonymous tracing?

Aug 4 2018, 1:24 PM
asomers added a comment to D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

What's anonymous tracing?

Aug 4 2018, 1:19 PM

Aug 3 2018

asomers committed rS337259: MFC r336319:.
MFC r336319:
Aug 3 2018, 2:48 PM
asomers committed rS337258: MFC r336205:.
MFC r336205:
Aug 3 2018, 2:46 PM
asomers committed rS337257: MFC r335899:.
MFC r335899:
Aug 3 2018, 2:37 PM
asomers committed rS337256: MFC r335287, r335290.
MFC r335287, r335290
Aug 3 2018, 2:36 PM
asomers committed rS337254: MFC r334547:.
MFC r334547:
Aug 3 2018, 2:25 PM
asomers committed rS337253: MFC r334394:.
MFC r334394:
Aug 3 2018, 2:24 PM
asomers committed rS337252: MFC r334390:.
MFC r334390:
Aug 3 2018, 2:23 PM
asomers committed rS337251: MFC r334296:.
MFC r334296:
Aug 3 2018, 2:22 PM
asomers committed rS337250: MFC r330720:.
MFC r330720:
Aug 3 2018, 2:20 PM
asomers committed rS337249: MFC r330719:.
MFC r330719:
Aug 3 2018, 2:19 PM
asomers committed rS337248: MFC r330718:.
MFC r330718:
Aug 3 2018, 2:18 PM
asomers committed rS337247: MFC r330710:.
MFC r330710:
Aug 3 2018, 2:17 PM
asomers committed rS337246: MFC r330696, r330709, r330742, r331358.
MFC r330696, r330709, r330742, r331358
Aug 3 2018, 2:13 PM
asomers committed rS337244: MFC r328266:.
MFC r328266:
Aug 3 2018, 2:08 PM
asomers committed rS337243: MFC r336319:.
MFC r336319:
Aug 3 2018, 2:06 PM
asomers committed rS337242: MFC r336205:.
MFC r336205:
Aug 3 2018, 2:05 PM
asomers committed rS337241: MFC r335899:.
MFC r335899:
Aug 3 2018, 2:03 PM
asomers committed rS337239: MFC r332631:.
MFC r332631:
Aug 3 2018, 2:01 PM
asomers committed rS337222: Fix LOCAL_PEERCRED with socketpair(2).
Fix LOCAL_PEERCRED with socketpair(2)
Aug 3 2018, 1:37 AM
asomers closed D16350: Fix LOCAL_PEERCRED with socketpair(2).
Aug 3 2018, 1:37 AM

Jul 31 2018

asomers added a comment to D16525: Some fixes for compat32..

Updating a Phabricator revision without including all of the files that have ever been part of that revision makes the history confusing, because Phabricator thinks you want to revert your changes to the files that you didn't include. You can't fix it now, but please try not to do it again.

Jul 31 2018, 6:04 PM
asomers accepted D16525: Some fixes for compat32..

LGTM. Don't forget to reference both PR 230175 and PR 230162 in your commit message. And don't forget to commit the autogenerated files too.

Jul 31 2018, 4:07 PM
asomers added a comment to D16525: Some fixes for compat32..
In D16525#350848, @kib wrote:

The mprotect_err test is now failing on amd64. The assertion at line 167 fails. I haven't tried it in 32-bit mode yet; I need to rebuild my 32-bit world first.

I see what is going on, finally. Can you explain to me how to rebuild mprotect_test without rebuilding the whole world, even with -DNO_CLEAN ? For normal components, I can make buildenv, then cd <dir> && make.

Jul 31 2018, 3:47 PM
asomers added a comment to D16525: Some fixes for compat32..

The mprotect_err test is now failing on amd64. The assertion at line 167 fails. I haven't tried it in 32-bit mode yet; I need to rebuild my 32-bit world first.

Jul 31 2018, 1:13 PM
asomers added a comment to D16525: Some fixes for compat32..

Also, I notice three other syscalls in compat/freebsd32 that use plain timespec instead of timespec32. Do they need fixing too? I haven't tested them. They are freebsd32_sigtimedwait, freebsd32_futimens, and freebsd32_utimensat.

Jul 31 2018, 12:59 PM
asomers added a comment to D16525: Some fixes for compat32..

Are you going to regenerate sys/compat/freebsd32 stuff too?

Jul 31 2018, 12:49 PM

Jul 30 2018

asomers requested changes to D4254: Mark tests that cannot run in parallel as is_exclusive.
Jul 30 2018, 9:37 PM
asomers abandoned D6682: Fix some sanity checks so they honor CLEAN_FETCH_ENV.

Abandoning revision because I didn't get approval before I lost access to the test environment.

Jul 30 2018, 9:30 PM
asomers abandoned D14725: Make timespecadd(3) and friends public.

Committed by r336914. I don't know why Phabricator didn't close it automatically.

Jul 30 2018, 9:27 PM
asomers abandoned D14403: Fix mpr device mapper fallback logic for busses with multiple expanders..

Abandoning the revision because I no longer have relevant hardware to develop on. @slm can commandeer the revision if he wants to.

Jul 30 2018, 9:26 PM
asomers closed V7: Should man(1)'s default pager change to "less -s"?.
Jul 30 2018, 9:24 PM · manpages
asomers added a comment to V7: Should man(1)'s default pager change to "less -s"?.

The poll passed by 82%, so I'm going to commit it. I've updated the diff at https://reviews.freebsd.org/D13465 and I'll commit in a few days if nobody finds any problems. As well as man, this version of the diff updates other utilities, too.

Jul 30 2018, 9:23 PM · manpages
asomers updated the diff for D13465: man(1): change default pager to "less -s".

Additionally change the defaults for mandoc, apropos, ftp, mail, msgs,
mergemaster, and freebsd-update. And change the default PAGER variable in
/usr/share/skel, /root, and tools/tools/nanobsd.

Jul 30 2018, 9:19 PM
asomers committed rP475899: archivers/c-blosc: update to 1.14.4.
archivers/c-blosc: update to 1.14.4
Jul 30 2018, 4:52 PM
asomers added a comment to D16500: getrusage(2): fix return value under 32-bit emulation.
In D16500#350454, @jhb wrote:

I'm confused by this change. Why did it not work before? Did the != NULL check not work so that it was never calling copyout? Otherwise, it was calling copyout correctly I don't see how EFAULT would not have been returned.

Jul 30 2018, 3:48 PM

Jul 29 2018

asomers committed rS336875: audit(4): add tests for sysctl(3) and sysarch(2).
audit(4): add tests for sysctl(3) and sysarch(2)
Jul 29 2018, 8:35 PM
asomers closed D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Jul 29 2018, 8:35 PM
asomers committed rS336874: freebsd32_getrusage(2): skip freebsd32_rusage_out on error.
freebsd32_getrusage(2): skip freebsd32_rusage_out on error
Jul 29 2018, 7:20 PM
asomers added inline comments to D16500: getrusage(2): fix return value under 32-bit emulation.
Jul 29 2018, 6:33 PM
asomers closed D16500: getrusage(2): fix return value under 32-bit emulation.
Jul 29 2018, 6:22 PM
asomers committed rS336871: getrusage(2): fix return value under 32-bit emulation.
getrusage(2): fix return value under 32-bit emulation
Jul 29 2018, 6:22 PM
asomers created D16500: getrusage(2): fix return value under 32-bit emulation.
Jul 29 2018, 5:47 PM
asomers added inline comments to D16448: Add tests for various other ioctls for auditpipe(4).
Jul 29 2018, 3:01 PM

Jul 28 2018

asomers committed rS336838: Disable -Wcast-align in libbsm and libauditd.
Disable -Wcast-align in libbsm and libauditd
Jul 28 2018, 8:04 PM
asomers closed D16486: Disable -Wcast-align in libbsm and libauditd.
Jul 28 2018, 8:04 PM
asomers updated the diff for D16486: Disable -Wcast-align in libbsm and libauditd.

Respond to comments

Jul 28 2018, 7:33 PM