Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (253 w, 3 d)

Recent Activity

Today

asomers committed rS345290: fuse(4): build the tests with the new googletest in base.
fuse(4): build the tests with the new googletest in base
Tue, Mar 19, 3:10 AM

Yesterday

asomers committed rS345279: MFHead@r345275.
MFHead@r345275
Mon, Mar 18, 7:28 PM
asomers committed rS345277: fuse(4): add tests for some mount options..
fuse(4): add tests for some mount options.
Mon, Mar 18, 6:05 PM

Fri, Mar 15

asomers accepted D19603: Remove duplicate `${PACKAGE}FILES+= cleanup.ksh` line.
Fri, Mar 15, 11:57 PM
asomers committed rS345207: fuse(4): add tests for the FOPEN_KEEP_CACHE option.
fuse(4): add tests for the FOPEN_KEEP_CACHE option
Fri, Mar 15, 10:47 PM
asomers committed rS345202: VOP_INACTIVE(9): clarify wording.
VOP_INACTIVE(9): clarify wording
Fri, Mar 15, 9:12 PM
asomers committed rS345201: fuse(4): add tests for the FUSE_ASYNC_READ option.
fuse(4): add tests for the FUSE_ASYNC_READ option
Fri, Mar 15, 8:16 PM
asomers committed rS345198: VOP_INACTIVE(9): clarify wording.
VOP_INACTIVE(9): clarify wording
Fri, Mar 15, 6:51 PM
asomers closed D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 6:51 PM
asomers updated the diff for D19596: VOP_INACTIVE(9): clarify wording.

Use kib's preferred wording.

Fri, Mar 15, 6:08 PM
asomers committed rS345195: fuse(4): add tests for ENOSYS special cases.
fuse(4): add tests for ENOSYS special cases
Fri, Mar 15, 6:07 PM
asomers added inline comments to D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 5:45 PM
asomers updated the diff for D19596: VOP_INACTIVE(9): clarify wording.

Respond to kib's criticism

Fri, Mar 15, 5:40 PM
asomers committed rS345191: fuse(4): combine common code in the tests.
fuse(4): combine common code in the tests
Fri, Mar 15, 5:04 PM
asomers updated subscribers of D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 5:02 PM
asomers updated the diff for D19596: VOP_INACTIVE(9): clarify wording.

Add note that there is no guarantee that VOP_INACTIVE will be called

Fri, Mar 15, 4:38 PM
asomers created D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 4:27 PM
asomers committed rS345188: fuse(4): add some miscellaneous test cases that I had overlooked.
fuse(4): add some miscellaneous test cases that I had overlooked
Fri, Mar 15, 4:17 PM
asomers committed rS345185: fuse(4): add tests for FUSE_DESTROY, FUSE_FORGET, and unlinking open files.
fuse(4): add tests for FUSE_DESTROY, FUSE_FORGET, and unlinking open files
Fri, Mar 15, 2:49 PM

Thu, Mar 14

asomers committed rS345167: fuse(4): add tests for extended attributes.
fuse(4): add tests for extended attributes
Thu, Mar 14, 11:06 PM
asomers committed rS345140: fuse(4): add tests for FUSE_INTERRUPT.
fuse(4): add tests for FUSE_INTERRUPT
Thu, Mar 14, 5:20 PM
asomers committed rS345134: fuse(4) tests: minor tweaks.
fuse(4) tests: minor tweaks
Thu, Mar 14, 3:07 PM
asomers committed rS345133: fuse(4): skip the Write.append test unless vfs.fuse.sync_resize==0.
fuse(4): skip the Write.append test unless vfs.fuse.sync_resize==0
Thu, Mar 14, 3:00 PM
asomers committed rS345119: fuse(4): combine common code in the tests.
fuse(4): combine common code in the tests
Thu, Mar 14, 12:13 AM

Wed, Mar 13

asomers committed rS345118: fuse(4): add tests for POSIX file locking operations.
fuse(4): add tests for POSIX file locking operations
Wed, Mar 13, 10:16 PM
asomers committed rS345086: fues(4): add tests for FUSE_RELEASEDIR.
fues(4): add tests for FUSE_RELEASEDIR
Wed, Mar 13, 1:41 PM

Tue, Mar 12

asomers committed rS345082: fuse(4): add tests for opendir and readdir.
fuse(4): add tests for opendir and readdir
Tue, Mar 12, 10:26 PM
asomers committed rP495523: shells/fish: fix the build when fish is already installed.
shells/fish: fix the build when fish is already installed
Tue, Mar 12, 8:52 PM
asomers accepted D19551: Do initial googlemock/googletest integration into the build/FreeBSD test suite.
Tue, Mar 12, 3:28 PM
asomers added inline comments to D19551: Do initial googlemock/googletest integration into the build/FreeBSD test suite.
Tue, Mar 12, 3:08 PM
asomers accepted D19552: Integrate cddl/usr.sbin/zfds/tests into the FreeBSD test suite.
Tue, Mar 12, 2:59 PM
asomers added inline comments to D19551: Do initial googlemock/googletest integration into the build/FreeBSD test suite.
Tue, Mar 12, 2:53 PM
asomers added inline comments to D19551: Do initial googlemock/googletest integration into the build/FreeBSD test suite.
Tue, Mar 12, 12:43 AM

Mon, Mar 11

asomers committed rS345035: fuse(4): add tests for FUSE_OPENDIR, FUSE_FSYNC, and FUSE_FSYNCDIR.
fuse(4): add tests for FUSE_OPENDIR, FUSE_FSYNC, and FUSE_FSYNCDIR
Mon, Mar 11, 10:30 PM
asomers committed rS345034: Drop "All rights reserved" from the files I own.
Drop "All rights reserved" from the files I own
Mon, Mar 11, 10:24 PM
asomers committed rS345020: Update copyright info in fuse tests.
Update copyright info in fuse tests
Mon, Mar 11, 7:11 PM
asomers committed rS345017: fuse(4): add tests for FUSE_READ.
fuse(4): add tests for FUSE_READ
Mon, Mar 11, 6:28 PM

Sat, Mar 9

asomers added a comment to D19523: MFC r343362,r343365,r343367,r343368,r343461,r343751,r344310:.

What's the difference between this review and D19524 ? And why are you asking for review on an MFC?

Sat, Mar 9, 7:53 PM

Fri, Mar 8

asomers committed rS344950: fuse(4): Add some tests for FUSE_FLUSH.
fuse(4): Add some tests for FUSE_FLUSH
Fri, Mar 8, 11:08 PM
asomers committed rS344930: fuse(4): add tests for FUSE_WRITE and FUSE_RELEASE.
fuse(4): add tests for FUSE_WRITE and FUSE_RELEASE
Fri, Mar 8, 7:01 PM
asomers committed rS344914: fuse(4): add dtrace probe for illegal short writes.
fuse(4): add dtrace probe for illegal short writes
Fri, Mar 8, 2:01 AM

Thu, Mar 7

asomers committed rS344890: fuse(4): add tests relating to open(2) flags.
fuse(4): add tests relating to open(2) flags
Thu, Mar 7, 6:12 PM

Wed, Mar 6

asomers committed rS344831: fuse(4): add tests for unlink, rmdir, and statfs.
fuse(4): add tests for unlink, rmdir, and statfs
Wed, Mar 6, 12:38 AM

Tue, Mar 5

asomers committed rS344824: fuse(4): add test cases for FUSE_LINK and FUSE_RENAME.
fuse(4): add test cases for FUSE_LINK and FUSE_RENAME
Tue, Mar 5, 9:40 PM
asomers committed rS344812: fuse(4): add tests for FUSE_MKDIR and FUSE_ACCESS.
fuse(4): add tests for FUSE_MKDIR and FUSE_ACCESS
Tue, Mar 5, 6:53 PM
asomers committed rS344789: fuse(4): combine some common code in the tests.
fuse(4): combine some common code in the tests
Tue, Mar 5, 3:27 AM
asomers committed rS344786: fuse(4): add tests related to FUSE_MKNOD.
fuse(4): add tests related to FUSE_MKNOD
Tue, Mar 5, 12:28 AM

Mon, Mar 4

asomers committed rS344785: fuse(4): add tests for CREATE, OPEN, READLINK, SETATTR and SYMLINK.
fuse(4): add tests for CREATE, OPEN, READLINK, SETATTR and SYMLINK
Mon, Mar 4, 10:07 PM
asomers committed rS344783: fuse(4): fix the entry_cache_negative_timeout test.
fuse(4): fix the entry_cache_negative_timeout test
Mon, Mar 4, 10:03 PM
asomers committed rS344775: fuse(4): add tests for negative lookups.
fuse(4): add tests for negative lookups
Mon, Mar 4, 7:10 PM

Sun, Mar 3

asomers added inline comments to D19430: devel/googletest: build from cmake instead of autotools build infra.
Sun, Mar 3, 5:57 PM
asomers added a comment to D19430: devel/googletest: build from cmake instead of autotools build infra.
In D19430#416155, @mat wrote:

I am not sure /usr/local/tests is the right place to put these files, it should probably more be something like /usr/local/share/tests.

Sun, Mar 3, 2:58 PM

Sat, Mar 2

asomers committed rS344727: fuse(4) use a global environment check..
fuse(4) use a global environment check.
Sat, Mar 2, 4:28 PM
asomers committed rS344725: Add some fuse(4) tests for FUSE_SETATTR.
Add some fuse(4) tests for FUSE_SETATTR
Sat, Mar 2, 3:32 PM

Fri, Mar 1

asomers committed rS344715: Begin a fuse(4) test suite.
Begin a fuse(4) test suite
Fri, Mar 1, 11:53 PM
asomers committed rS344703: Fix typos from r344664.
Fix typos from r344664
Fri, Mar 1, 3:49 PM

Thu, Feb 28

asomers committed rS344664: fuse(4): convert debug printfs into dtrace probes.
fuse(4): convert debug printfs into dtrace probes
Thu, Feb 28, 7:28 PM

Tue, Feb 26

asomers committed rS344558: Create a project branch for fuse(4) work..
Create a project branch for fuse(4) work.
Tue, Feb 26, 3:59 AM
asomers committed rS344559: ifconfig: eliminate trailing whitespace.
ifconfig: eliminate trailing whitespace
Tue, Feb 26, 3:35 AM
asomers closed D19004: ifconfig: eliminate trailing whitespace.
Tue, Feb 26, 3:35 AM

Sun, Feb 24

asomers committed rP493822: shells/fish: upgrade to 3.0.2.
shells/fish: upgrade to 3.0.2
Sun, Feb 24, 10:51 PM

Wed, Feb 20

asomers committed rP493425: shells/fish: upgrade to 3.0.1.
shells/fish: upgrade to 3.0.1
Wed, Feb 20, 3:32 PM

Tue, Feb 19

asomers accepted D19249: Limit the number of REPORT_ZONES entries allocated in the kernel..

Sorry, I missed that. I was searching for the wrong thing. In that, case, this change LGTM. I can't test it, though.

Tue, Feb 19, 7:40 PM
asomers added a comment to D19249: Limit the number of REPORT_ZONES entries allocated in the kernel..

This change looks good. However, zonectl(8) currently hard-codes the entries_allocated field and doesn't check for a short return. If the kernel truncates the zone list, the user will have no obvious way of knowing. I think zonectl(8) should be modified to either loop until all zones have been reported, or at least tell the user that not all zones were reported.

Tue, Feb 19, 7:30 PM
asomers accepted D19188: Make `server_cat(..)` handle short receives.

LGTM!

Tue, Feb 19, 7:23 PM

Feb 14 2019

asomers committed rS344138: MFC r343530:.
MFC r343530:
Feb 14 2019, 8:33 PM
asomers committed rS344137: MFC r300938, r342154.
MFC r300938, r342154
Feb 14 2019, 8:31 PM
asomers committed rS344136: MFC r342153, r342172-r342173.
MFC r342153, r342172-r342173
Feb 14 2019, 8:29 PM
asomers committed rS344135: MFC r341390, r341392, r341667.
MFC r341390, r341392, r341667
Feb 14 2019, 8:27 PM
asomers committed rS344134: MFC r341598:.
MFC r341598:
Feb 14 2019, 8:24 PM
asomers committed rS344131: MFC r340988:.
MFC r340988:
Feb 14 2019, 6:01 PM
asomers committed rS344130: MFC r340525 again.
MFC r340525 again
Feb 14 2019, 5:40 PM

Jan 29 2019

asomers accepted D19026: Avoid the DNS lookup for "localhost".
Jan 29 2019, 11:21 PM

Jan 28 2019

asomers committed rS343530: ifconfig: fix endianness bug displaying pfsync interfaces.
ifconfig: fix endianness bug displaying pfsync interfaces
Jan 28 2019, 6:34 PM
asomers closed D19005: ifconfig: fix endianness bug displaying pfsync interfaces.
Jan 28 2019, 6:34 PM
asomers updated the diff for D19005: ifconfig: fix endianness bug displaying pfsync interfaces.

s/ntohl/htonl

Jan 28 2019, 5:24 PM
asomers added inline comments to D19005: ifconfig: fix endianness bug displaying pfsync interfaces.
Jan 28 2019, 5:23 PM
asomers created D19005: ifconfig: fix endianness bug displaying pfsync interfaces.
Jan 28 2019, 4:48 PM
asomers created D19004: ifconfig: eliminate trailing whitespace.
Jan 28 2019, 4:36 PM

Jan 25 2019

asomers accepted D18969: Fix reporting errors with `gai_strerror(..)`.
Jan 25 2019, 8:07 PM

Jan 23 2019

asomers accepted D18935: Unbreak the build on 32-bit architectures.

Approved. Just make sure the commit message matches the code.

Jan 23 2019, 11:27 PM
asomers added a comment to D18935: Unbreak the build on 32-bit architectures.

Instead of casting the argument to a larger size, can you just use %zu instead?

Jan 23 2019, 11:21 PM
asomers added a comment to D18934: Unbreak the gcc build with sendfile_test after r343362.
In D18934#404425, @ngie wrote:

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

It should work. The Committer's Guide was updated to use MFC with instead of X-MFC-With (the old form): https://www.freebsd.org/doc/en/articles/committers-guide/article.html#commit-log-message back almost 2 years ago by @emaste: https://svnweb.freebsd.org/doc?view=revision&revision=50227 ;).

Jan 23 2019, 11:11 PM
asomers accepted D18934: Unbreak the gcc build with sendfile_test after r343362.

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

Jan 23 2019, 10:56 PM
asomers accepted D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Jan 23 2019, 9:30 PM

Jan 17 2019

asomers accepted D14567: Introduce funlinkat..

LGTM. But you should still probably get a final review from the likes of @jilles or @kib .

Jan 17 2019, 9:44 PM
asomers requested changes to D14567: Introduce funlinkat..
Jan 17 2019, 9:28 PM
asomers committed rP490604: shells/fish: patch upstream issue #5453.
shells/fish: patch upstream issue #5453
Jan 17 2019, 8:41 PM

Jan 12 2019

asomers added a comment to D18622: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.

FWIW our tree already has some tests that require C++-11. See lib/libc/tests/stdlib/Makefile. So importing an old version of googletest may not be worthwhile if it means forfeiting important features. Also, you may not have noticed, but there's already one googletest program in base, in cddl/usr.sbin/zfsd/tests. It's been there for years, but never hooked up to the build.

Jan 12 2019, 4:44 PM
asomers accepted D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Jan 12 2019, 4:28 PM

Jan 7 2019

asomers added inline comments to D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Jan 7 2019, 5:44 PM

Dec 31 2018

asomers committed rP488840: shells/fish: upgrade to 3.0.0.
shells/fish: upgrade to 3.0.0
Dec 31 2018, 9:39 PM
asomers added inline comments to D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Dec 31 2018, 4:48 PM

Dec 27 2018

asomers requested changes to D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Dec 27 2018, 11:01 PM

Dec 17 2018

asomers added inline comments to D18585: Eliminate sleeps in the geom ATF tests.
Dec 17 2018, 10:40 PM
asomers added inline comments to D18585: Eliminate sleeps in the geom ATF tests.
Dec 17 2018, 9:20 PM
asomers committed rS342173: Conditionalize installtion audit(4) tests on MK_AUDIT.
Conditionalize installtion audit(4) tests on MK_AUDIT
Dec 17 2018, 6:35 PM
asomers committed rS342172: audit(4) tests: require /etc/rc.d/auditd.
audit(4) tests: require /etc/rc.d/auditd
Dec 17 2018, 6:11 PM
asomers abandoned D18583: Eliminate sleeps in the geom ATF tests.

Sorry for the duplicate revision. I'm having curl problems.

Dec 17 2018, 4:53 PM · tests
asomers created D18585: Eliminate sleeps in the geom ATF tests.
Dec 17 2018, 4:51 PM