User Details
- User Since
- May 9 2014, 11:04 PM (514 w, 3 d)
Tue, Mar 12
An exp-run is what you suggested when I first raised the issue on freebsd-hackers last September. However, I don't know how to do an exp-run. Are you volunteering?
Thu, Mar 7
Tue, Mar 5
Fri, Feb 23
Feb 12 2024
Feb 9 2024
Feb 8 2024
This looks good. BTW, you don't have to wait until the cleanup phase to print the seed. It's OK to print it at the beginning of the test phase. In the event of a failure, Kyua will report everything that the test printed.
Feb 7 2024
This looks good. But I have a few thoughts:
Feb 6 2024
So in the future it will be possible to send a single record with multiple send syscalls? In that case we can certainly remove these tests. However, in the future it will be important to ensure that we can send messages larger than the socket buffer size, right? In that case, I think we should leave these tests here for now, and update them atomically when the new behavior is committed. That way we won't forget.
Feb 4 2024
@imp here's a test case that depends on Rust. Not exactly what you meant, perhaps, but I think it would be a valuable addition. If you like this, we can add versions for other builtin file systems, too.
Feb 3 2024
@emaste what about something like this?
#define VA_NOTIME(ts) { \ ts->tv_sec = -1; \ ts->tv_nsec = 0; \ }
Feb 2 2024
Jan 25 2024
Jan 20 2024
Jan 19 2024
Jan 17 2024
- Replaces memsets by default initializers. Delete allocations using
Jan 16 2024
Jan 15 2024
- Use vnode_pager_clean_sync
Jan 13 2024
Will an operation with LIO_FOFFSET update the current file offset? What happens if two or more operations both specify LIO_FOFFSET? lio_listio does not specify the order in which the operations will be evaluated. Given that, this flag can't be used if two or more operations affect the same file. And IMHO lio_listio isn't very useful with such a restriction.
Jan 11 2024
Jan 9 2024
It LGTM, but let's get some outside review, too. @des what do you think?
Jan 8 2024
I don't grok this page cache stuff. But your patch works for me. BTW, fspacectl was a red herring. I can actually reproduce the panic with just a single mapwrite, as long as the size and offset are suitable.
Dec 31 2023
This looks correct to me, but I haven't tested it in any way. I think it's a good candidate to add to pjdfstest.
Dec 30 2023
This is the same as the 2nd patch you posted to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276002, right? That one does not fix the test case.
Dec 28 2023
Dec 27 2023
Dec 26 2023
Oops. I accidentally included way too many commits. I'll close this review and start over.
Dec 25 2023
Dec 22 2023
Dec 20 2023
@markj All tests pass on my admittedly somewhat trailing edge hardware.
LGTM. Do you need help testing it? I can test it for you, if you lack appropriate hardware.