Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (235 w, 5 d)

Recent Activity

Tue, Nov 13

asomers committed rP484879: devel/p4: fix build with OpenSSL 1.1.
devel/p4: fix build with OpenSSL 1.1
Tue, Nov 13, 5:15 PM
asomers committed rP484878: emulators/qemu-utils: fix build after r484653.
emulators/qemu-utils: fix build after r484653
Tue, Nov 13, 4:28 PM

Mon, Nov 12

asomers added a comment to D14567: Introduce fdunlinkat..

@cem, @kib, @emaste, @jilles I would like to commit it as-it-is but pjd suggested to change the name to funlinkat? After some thoughts I also think that funlinkat is a bether name 'fd' suggests that it's working on 'FILE *'. Do you agree?

Mon, Nov 12, 6:16 PM

Sat, Nov 10

asomers committed rS340314: libjail: fix handling of allow.mount.fusefs in jailparam_init.
libjail: fix handling of allow.mount.fusefs in jailparam_init
Sat, Nov 10, 3:10 AM
asomers closed D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.
Sat, Nov 10, 3:10 AM
asomers updated the diff for D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.

Handle allow.mount.nofusefs too

Sat, Nov 10, 2:38 AM
asomers added a comment to D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.

Of course, stupid me. But I'm having trouble testing it. What's the proper way to pass the "nofuse" option on the jail(8) command line? Neither allow.mount.nofusefs nor allow.mount.nofusefs=1 work.

Sat, Nov 10, 1:17 AM

Fri, Nov 9

asomers created D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.
Fri, Nov 9, 7:01 PM

Oct 2 2018

asomers committed rS339095: MFC r336875:.
MFC r336875:
Oct 2 2018, 6:12 PM
asomers committed rS339094: MFC r336728:.
MFC r336728:
Oct 2 2018, 5:57 PM
asomers committed rS339093: MFC r336613:.
MFC r336613:
Oct 2 2018, 5:43 PM
asomers committed rS339092: MFC r335792, r336564, r336579.
MFC r335792, r336564, r336579
Oct 2 2018, 5:39 PM
asomers committed rS339090: MFC r335319, r335354, r335374.
MFC r335319, r335354, r335374
Oct 2 2018, 5:27 PM
asomers committed rS339089: MFC r335261, r335275, r335284-r335285, r335294, r335318, r335320, r335703.
MFC r335261, r335275, r335284-r335285, r335294, r335318, r335320, r335703
Oct 2 2018, 5:07 PM
asomers committed rS339087: MFC many audit(4) tests..
MFC many audit(4) tests.
Oct 2 2018, 4:23 PM
asomers committed rS339084: MFC r334360, r334362, r334388, r334395.
MFC r334360, r334362, r334388, r334395
Oct 2 2018, 3:19 PM

Oct 1 2018

asomers committed rS339068: MFC r337222:.
MFC r337222:
Oct 1 2018, 6:01 PM
asomers committed rS339067: MFC r337222:.
MFC r337222:
Oct 1 2018, 5:37 PM
asomers requested changes to D17376: IPv6 Fragmentation Regression Tests from OpenBSD.

Wow, nice contribution! But a few things need to be fixed:

  1. When we import foreign code, if there's any possibility at all that we might sync it again in the future, then we import it to the vendor directory before merging it to the contrib directory. See contrib/netbsd-tests for an example.
  2. Other concerns inline.
  3. I haven't fully reviewed the Python code. I'll do that after you fix the sh and make problems.
  4. Any files that come from OpenBSD should be committed verbatim to the vendor directory, then copied to the contrib directory. Then they can be modified in contrib.
Oct 1 2018, 5:09 PM
asomers committed rS339065: MFC r336871, r336874.
MFC r336871, r336874
Oct 1 2018, 4:23 PM
asomers committed rS339063: MFC r337973:.
MFC r337973:
Oct 1 2018, 4:15 PM
asomers committed rS339062: MFC r338216:.
MFC r338216:
Oct 1 2018, 4:11 PM
asomers committed rS339061: MFC r337779:.
MFC r337779:
Oct 1 2018, 4:10 PM
asomers committed rS339060: MFC r336609:.
MFC r336609:
Oct 1 2018, 4:09 PM
asomers committed rS339059: MFC r336605:.
MFC r336605:
Oct 1 2018, 4:08 PM
asomers committed rS339058: MFC r336587:.
MFC r336587:
Oct 1 2018, 4:07 PM
asomers committed rS339057: MFC r338216:.
MFC r338216:
Oct 1 2018, 4:04 PM
asomers committed rS339056: MFC r337973:.
MFC r337973:
Oct 1 2018, 4:01 PM
asomers committed rS339055: MFC r337911:.
MFC r337911:
Oct 1 2018, 3:59 PM
asomers committed rS339054: MFC r337779:.
MFC r337779:
Oct 1 2018, 3:58 PM
asomers committed rS339053: MFC r337482:.
MFC r337482:
Oct 1 2018, 3:56 PM
asomers committed rS339052: MFC r336871, r336874.
MFC r336871, r336874
Oct 1 2018, 3:50 PM
asomers committed rS339051: MFC r336605:.
MFC r336605:
Oct 1 2018, 3:47 PM
asomers committed rS339050: MFC r336594:.
MFC r336594:
Oct 1 2018, 3:45 PM
asomers committed rS339049: MFC r336587:.
MFC r336587:
Oct 1 2018, 3:44 PM
asomers committed rS339048: MFC r336582:.
MFC r336582:
Oct 1 2018, 3:40 PM

Sep 30 2018

asomers added inline comments to D17348: Allow DTrace audit provider probes to fire even if auditd(8) isn't running..
Sep 30 2018, 12:01 AM

Sep 17 2018

asomers accepted D17202: Fix the nvpair leak in vdev_geom_read_config()..

Oops, looks like this one's my fault. Thanks for fixing it, Mark!

Sep 17 2018, 3:55 PM

Sep 11 2018

asomers accepted D17110: Add simple tests for SO_REUSEPORT_LB sockets..

Do the tests still pass for you? After your latest change, I get the "connection wasn't accepted" error every time.

Yes, I just noticed that. (I rebuilt and ran the tests on two different machines by accident.) It seems like the polling loop is needed after all, which is somewhat surprising to me given that we're using a blocking connect().

I guess this is expected behaviour for TCP. connect(2) returns once the SYN|ACK reply is received, but the child socket isn't complete until the final ACK is received, so there's a window that we have to account for.

Sep 11 2018, 4:16 PM
asomers added a comment to D17110: Add simple tests for SO_REUSEPORT_LB sockets..

Do the tests still pass for you? After your latest change, I get the "connection wasn't accepted" error every time.

Sep 11 2018, 3:20 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 3:16 PM
asomers added inline comments to D17110: Add simple tests for SO_REUSEPORT_LB sockets..
Sep 11 2018, 2:49 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 2:42 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 3:13 AM
asomers added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

  1. The Wayback machine shows me that IANA sometimes removes a port assignment. Sadly, I haven't been able to find any official historical information. What will FreeBSD's policy regarding removing assignments be?

I doubt there has ever been such a policy. By default, we will remove it on the next update. I think this de facto policy will be sufficient. Administrators who need to keep the assignment can simply add it to this file on their systems.

Sep 11 2018, 3:10 AM
asomers accepted D17110: Add simple tests for SO_REUSEPORT_LB sockets..

All good here.

Sep 11 2018, 3:07 AM

Sep 10 2018

asomers added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

Sep 10 2018, 11:22 PM
asomers added a comment to D17110: Add simple tests for SO_REUSEPORT_LB sockets..

In fact, you don't even need the second process for this test. It's possible to do this entirely with one single-threaded process. See the "accept_success" test in tests/sys/audit/network.c for an example. Basically it goes like this:

for (i=0; i<sdcnt; i++)
    listen(server_fd[i]);
while (true) {
    client_fd = socket();
    client_fd.connect(server_addr);  //blocking, but returns immediately
    for ((i=0; i<sdcnt; i++) {
        if (accept(server_fd[i]) == 0) {    // non-blocking
            acceptcnt[i]++;
            break;
        }
    }
}

What do you think of the single-threaded approach?

Sep 10 2018, 7:26 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 6:45 PM
asomers added inline comments to D17110: Add simple tests for SO_REUSEPORT_LB sockets..
Sep 10 2018, 6:42 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 6:20 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 5:41 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 5:28 PM
asomers accepted D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 2:40 PM
asomers added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 2:27 PM
asomers added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 1:55 PM
asomers accepted D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 1:13 AM

Aug 30 2018

asomers committed rS336914: Make timespecadd(3) and friends public.
Make timespecadd(3) and friends public
Aug 30 2018, 2:56 AM

Aug 24 2018

asomers committed rP477975: devel/kcov: upgrade to v36.
devel/kcov: upgrade to v36
Aug 24 2018, 6:29 PM

Aug 23 2018

asomers committed rS338258: tftp(1): switch default transfer mode to binary.
tftp(1): switch default transfer mode to binary
Aug 23 2018, 5:00 PM
asomers closed D16869: tftp(1): switch default transfer mode to binary.
Aug 23 2018, 5:00 PM
asomers created D16869: tftp(1): switch default transfer mode to binary.
Aug 23 2018, 3:33 PM

Aug 22 2018

asomers committed rS338216: tftpd: Fix data corruption bug with netascii.
tftpd: Fix data corruption bug with netascii
Aug 22 2018, 11:31 PM
asomers closed D16853: tftpd: Fix data corruption bug with netascii.
Aug 22 2018, 11:31 PM
asomers added a comment to D16853: tftpd: Fix data corruption bug with netascii.

Thanks @cem. I know I can always count on you for a good review.

Aug 22 2018, 11:28 PM
asomers updated the diff for D16853: tftpd: Fix data corruption bug with netascii.

Fix an old typo in a comment

Aug 22 2018, 11:04 PM
asomers added inline comments to D16853: tftpd: Fix data corruption bug with netascii.
Aug 22 2018, 11:04 PM
asomers created D16853: tftpd: Fix data corruption bug with netascii.
Aug 22 2018, 10:30 PM

Aug 17 2018

asomers committed rS337984: Fix sys/netipsec/tunnel tests after r337736.
Fix sys/netipsec/tunnel tests after r337736
Aug 17 2018, 6:37 PM
asomers committed rS337973: Add Modbus Application Protocol to /etc/services.
Add Modbus Application Protocol to /etc/services
Aug 17 2018, 3:19 PM

Aug 16 2018

asomers committed rS337933: Fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0
Aug 16 2018, 11:50 PM
asomers closed D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 11:50 PM
asomers added inline comments to D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 11:47 PM
asomers added inline comments to D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 11:36 PM
asomers updated the diff for D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.

create a common ATF_REQUIRE_SYSCTL_INT macro

Aug 16 2018, 10:41 PM
asomers committed rS337930: Revert r337929.
Revert r337929
Aug 16 2018, 10:04 PM
asomers committed rS337929: Fix Coverity warnings about mkstemp in tests.
Fix Coverity warnings about mkstemp in tests
Aug 16 2018, 9:36 PM
asomers created D16755: fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0.
Aug 16 2018, 8:44 PM
asomers committed rS337911: Fix the sys/opencrypto/runtests test when aesni(4) is already loaded.
Fix the sys/opencrypto/runtests test when aesni(4) is already loaded
Aug 16 2018, 3:45 PM

Aug 14 2018

asomers committed rS337779: tftp: Close a resource leak when putting files.
tftp: Close a resource leak when putting files
Aug 14 2018, 5:20 PM
asomers accepted D16709: mergemaster: better defaults for SOURCEDIR.
Aug 14 2018, 3:48 PM
asomers accepted D16709: mergemaster: better defaults for SOURCEDIR.

I use mergemaster the same way. Apart from the "default" word choice, this revision LGTM.

Aug 14 2018, 3:25 PM

Aug 8 2018

asomers committed rS337497: Switch the default pager for most commands to less.
Switch the default pager for most commands to less
Aug 8 2018, 7:24 PM
asomers closed D13465: man(1): change default pager to "less -s".
Aug 8 2018, 7:24 PM
asomers committed rS337482: Bring VOP_LOOKUP(9) up to date.
Bring VOP_LOOKUP(9) up to date
Aug 8 2018, 6:50 PM
asomers closed D16629: Bring VOP_LOOKUP(9) up to date.
Aug 8 2018, 6:50 PM
asomers created D16629: Bring VOP_LOOKUP(9) up to date.
Aug 8 2018, 4:53 PM

Aug 4 2018

asomers added a member for Audit: asomers.
Aug 4 2018, 2:06 PM
asomers accepted D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

I don't see anything wrong with this review. However, since you're modifying the boot loader you should check with @imp.

Aug 4 2018, 2:05 PM
asomers added a comment to D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

What's anonymous tracing?

Aug 4 2018, 1:24 PM
asomers added a comment to D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

What's anonymous tracing?

Aug 4 2018, 1:19 PM

Aug 3 2018

asomers committed rS337259: MFC r336319:.
MFC r336319:
Aug 3 2018, 2:48 PM
asomers committed rS337258: MFC r336205:.
MFC r336205:
Aug 3 2018, 2:46 PM
asomers committed rS337257: MFC r335899:.
MFC r335899:
Aug 3 2018, 2:37 PM
asomers committed rS337256: MFC r335287, r335290.
MFC r335287, r335290
Aug 3 2018, 2:36 PM
asomers committed rS337254: MFC r334547:.
MFC r334547:
Aug 3 2018, 2:25 PM
asomers committed rS337253: MFC r334394:.
MFC r334394:
Aug 3 2018, 2:24 PM
asomers committed rS337252: MFC r334390:.
MFC r334390:
Aug 3 2018, 2:23 PM
asomers committed rS337251: MFC r334296:.
MFC r334296:
Aug 3 2018, 2:22 PM
asomers committed rS337250: MFC r330720:.
MFC r330720:
Aug 3 2018, 2:20 PM