Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (307 w, 3 d)

Recent Activity

Yesterday

asomers committed rS359435: fusefs: add a dtrace probe that fires after mounting is complete.
fusefs: add a dtrace probe that fires after mounting is complete
Mon, Mar 30, 2:04 PM

Wed, Mar 25

asomers created D24191: sysutils/smartmontools: skip virtio disk devices during periodic scan.
Wed, Mar 25, 10:43 PM

Tue, Mar 24

asomers accepted D23193: ICMP checksum test: Fix for big endian.

I agree with Renato. There's no way to test in_cksum on both endiannesses without using something complicated like qemu. The right approach is to checksum the same input on different platforms, and assert that the result is identical on all. That's what Renato's change does. @renato.riolino_eldorado.org.br I don't think you have a commit bit, right? If not, I can commit the change for you. But I don't have any BE hardware. Can you first confirm that with your change the tests pass on BE hardware on a newish build?

Tue, Mar 24, 3:31 AM · tests
asomers added a comment to D21638: Add kqueue support for ZFS..

Can we close this review now?

Tue, Mar 24, 3:17 AM

Sun, Mar 22

asomers accepted D24157: Use -F instead of -f in tail(1) examples.

LGTM, but since the reader already has the man page open, you probably don't need to explain the`-F` flag again.

Sun, Mar 22, 8:56 PM
asomers committed rS359214: MFC r358867:.
MFC r358867:
Sun, Mar 22, 3:24 PM
asomers committed rS359213: MFC r358798:.
MFC r358798:
Sun, Mar 22, 3:17 PM
asomers committed rS359212: MFC r358089, r358797.
MFC r358089, r358797
Sun, Mar 22, 3:03 PM
asomers committed rS359211: MFC r357835:.
MFC r357835:
Sun, Mar 22, 3:01 PM
asomers committed rS359207: MFC r356809:.
MFC r356809:
Sun, Mar 22, 2:56 AM
asomers committed rS359206: MFC r355488-r355489.
MFC r355488-r355489
Sun, Mar 22, 2:55 AM
asomers committed rS359205: MFC r355430:.
MFC r355430:
Sun, Mar 22, 2:54 AM
asomers committed rS359204: MFC r354812:.
MFC r354812:
Sun, Mar 22, 2:27 AM
asomers committed rS359203: MFC r354779:.
MFC r354779:
Sun, Mar 22, 2:26 AM
asomers committed rS359198: MFC r354664-r354666.
MFC r354664-r354666
Sun, Mar 22, 1:02 AM

Sat, Mar 21

asomers committed rS359196: MFC r352231:.
MFC r352231:
Sat, Mar 21, 6:24 PM

Wed, Mar 11

asomers committed rS358867: fusefs: avoid cache corruption with buggy fuse servers.
fusefs: avoid cache corruption with buggy fuse servers
Wed, Mar 11, 4:30 AM
asomers closed D24012: fusefs: avoid cache corruption with buggy fuse servers.
Wed, Mar 11, 4:30 AM
asomers added a comment to D24012: fusefs: avoid cache corruption with buggy fuse servers.

Thanks for such a speedy review!

Wed, Mar 11, 4:29 AM
asomers updated the diff for D24012: fusefs: avoid cache corruption with buggy fuse servers.

Make a warning message scarier, and fix a style nit

Wed, Mar 11, 4:17 AM

Tue, Mar 10

asomers created D24012: fusefs: avoid cache corruption with buggy fuse servers.
Tue, Mar 10, 4:00 AM

Mon, Mar 9

asomers committed rS358798: fusefs: fix fsync for files with multiple open handles.
fusefs: fix fsync for files with multiple open handles
Mon, Mar 9, 1:57 AM
asomers committed rS358797: [skip ci] fix typo in comment in the fusefs tests.
[skip ci] fix typo in comment in the fusefs tests
Mon, Mar 9, 12:14 AM

Feb 26 2020

asomers committed rP527149: shells/fish: upgrade to 3.1.0.
shells/fish: upgrade to 3.1.0
Feb 26 2020, 4:26 AM
asomers accepted D23836: Add support for the TFTP windowsize option described in RFC 7440..
Feb 26 2020, 3:30 AM

Feb 25 2020

asomers requested changes to D23836: Add support for the TFTP windowsize option described in RFC 7440..

I didn't closely review tftp-transfer.c, but everything else looks good, especially the tests! Thanks for implementing tests for option processing; I never got around to that.

Feb 25 2020, 6:38 PM

Feb 23 2020

asomers committed rP526945: shells/fish: needs groff at runtime.
shells/fish: needs groff at runtime
Feb 23 2020, 9:12 PM

Feb 19 2020

asomers committed rS358089: [skip ci] delete obsolete comment in fusefs tests.
[skip ci] delete obsolete comment in fusefs tests
Feb 19 2020, 1:51 AM

Feb 13 2020

asomers committed rS357881: MFC r357235:.
MFC r357235:
Feb 13 2020, 8:49 PM
asomers committed rS357880: MFC r357211:.
MFC r357211:
Feb 13 2020, 8:46 PM
asomers committed rS357879: MFC r356809:.
MFC r356809:
Feb 13 2020, 8:45 PM
asomers committed rS357878: MFC r355488-r355489.
MFC r355488-r355489
Feb 13 2020, 8:41 PM
asomers committed rS357877: MFC r355430:.
MFC r355430:
Feb 13 2020, 8:40 PM
asomers committed rS357876: MFC r355431:.
MFC r355431:
Feb 13 2020, 8:32 PM
asomers committed rS357863: MFC r354234:.
MFC r354234:
Feb 13 2020, 6:26 PM
asomers closed D23651: sesutil: fix Coverity CIDs.
Feb 13 2020, 3:29 PM
asomers committed rS357859: sesutil: fix Coverity CIDs.
sesutil: fix Coverity CIDs
Feb 13 2020, 3:29 PM

Feb 12 2020

asomers committed rS357835: fusefs: fix some memory leaks in the tests..
fusefs: fix some memory leaks in the tests.
Feb 12 2020, 6:11 PM
asomers created D23651: sesutil: fix Coverity CIDs.
Feb 12 2020, 5:07 PM

Feb 4 2020

asomers accepted D23223: auditd_stop: wait_for_pids instead of sleeping.

Good catch! I don't see any reason not to do it your way. In fact, @rwatson anticipated that in his original commit message.

Feb 4 2020, 11:55 PM

Jan 28 2020

asomers added a comment to D22077: Speed up "zpool import" in the presence of many zvols.

Committed with that last style comment from @mav.

Jan 28 2020, 11:09 PM
asomers closed D22077: Speed up "zpool import" in the presence of many zvols.
Jan 28 2020, 11:07 PM
asomers committed rS357235: Speed up "zpool import" in the presence of many zvols.
Speed up "zpool import" in the presence of many zvols
Jan 28 2020, 11:07 PM
asomers committed rS357211: geli: add a test case for attaching multiple providers with 1 command.
geli: add a test case for attaching multiple providers with 1 command
Jan 28 2020, 6:32 PM
asomers closed D23400: geli: add a test case for attaching multiple providers with 1 command.
Jan 28 2020, 6:32 PM
asomers updated the diff for D22077: Speed up "zpool import" in the presence of many zvols.

Style changes suggested by Ryan

Jan 28 2020, 5:33 PM
asomers created D23400: geli: add a test case for attaching multiple providers with 1 command.
Jan 28 2020, 5:06 PM

Jan 16 2020

asomers added a comment to D23211: setextattr: Increase stdin buffer size to 4096.

Done!

Jan 16 2020, 9:32 PM
asomers committed rS356809: setextattr: Increase stdin buffer size to 4096.
setextattr: Increase stdin buffer size to 4096
Jan 16 2020, 9:32 PM
asomers closed D23211: setextattr: Increase stdin buffer size to 4096.
Jan 16 2020, 9:32 PM
asomers accepted D23211: setextattr: Increase stdin buffer size to 4096.
Jan 16 2020, 9:01 PM

Jan 13 2020

asomers committed rP522895: devel/py-libzfs: fix build with nonstandard SRC_BASE after r520716.
devel/py-libzfs: fix build with nonstandard SRC_BASE after r520716
Jan 13 2020, 2:34 PM
asomers closed D23126: devel/py-libzfs: fix build with nonstandard SRC_BASE after r520716.
Jan 13 2020, 2:34 PM

Jan 10 2020

asomers accepted D23127: tests: fusefs: silence remaining unsigned/signed comparison warnings.
Jan 10 2020, 9:28 PM
asomers requested changes to D23127: tests: fusefs: silence remaining unsigned/signed comparison warnings.

timespec.tv_nsec is defined as long, not time_t. So you should be casting to long.

Jan 10 2020, 9:19 PM
asomers created D23126: devel/py-libzfs: fix build with nonstandard SRC_BASE after r520716.
Jan 10 2020, 9:05 PM

Dec 20 2019

asomers accepted D22887: libdevdctl: g++9 avoid Wdeprecated-copy.
Dec 20 2019, 3:46 PM

Dec 7 2019

asomers committed rS355489: clock_gettime(2): add a HISTORY section.
clock_gettime(2): add a HISTORY section
Dec 7 2019, 4:45 PM
asomers committed rS355488: lio_listio(2): add a HISTORY section.
lio_listio(2): add a HISTORY section
Dec 7 2019, 4:30 PM

Dec 6 2019

asomers committed rS355434: MFC r354779:.
MFC r354779:
Dec 6 2019, 12:29 AM
asomers committed rS355433: MFC r354812:.
MFC r354812:
Dec 6 2019, 12:27 AM
asomers committed rS355432: MFC r354664-r354666.
MFC r354664-r354666
Dec 6 2019, 12:24 AM
asomers committed rS355431: gmultipath: add ATF tests.
gmultipath: add ATF tests
Dec 6 2019, 12:12 AM
asomers closed D22235: gmultipath: add ATF tests.
Dec 6 2019, 12:12 AM
asomers committed rS355430: ses: sanitize illegal strings in SES element descriptors.
ses: sanitize illegal strings in SES element descriptors
Dec 6 2019, 12:06 AM

Dec 1 2019

asomers committed rP518782: emulators/qemu-utils: switch maintainer to Ken.
emulators/qemu-utils: switch maintainer to Ken
Dec 1 2019, 3:52 PM
asomers committed rP518780: emulators/qemu-utils: fix build after r518397.
emulators/qemu-utils: fix build after r518397
Dec 1 2019, 3:50 PM

Nov 26 2019

asomers committed rS355106: ping, ping6: Use setitimer(2) instead of obsolete alarm(3).
ping, ping6: Use setitimer(2) instead of obsolete alarm(3)
Nov 26 2019, 5:06 AM
asomers closed D22103: ping: Use setitimer(2) instead of obsoleted alarm(3).
Nov 26 2019, 5:06 AM
asomers accepted D22103: ping: Use setitimer(2) instead of obsoleted alarm(3).

LGTM. The extra braces you added in order to create scope for the itv variable are stylistically contentious. Some people would disagree with that, because it's not commonly done. But I happen to like that technique myself; no reason for itv to have more scope than necessary.

Nov 26 2019, 5:02 AM

Nov 25 2019

asomers committed rP518435: security/gnupg: add the --shared-access option to scdaemon.
security/gnupg: add the --shared-access option to scdaemon
Nov 25 2019, 11:49 PM
asomers closed D22473: security/gnupg: add the --shared-access option to scdaemon.
Nov 25 2019, 11:49 PM
asomers added a comment to D22473: security/gnupg: add the --shared-access option to scdaemon.

It's ready to go, but I had one more question at https://reviews.freebsd.org/D22492 . I was waiting for your answer, not because it's strictly required but just in case you had something surprising to say.

Nov 25 2019, 10:16 PM

Nov 23 2019

asomers accepted D22519: Correct test error messages in bitstring_test.
Nov 23 2019, 5:16 PM

Nov 22 2019

asomers added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

Sorry Alan, this was breaking the build on 11 so I committed it.

Nov 22 2019, 3:54 AM
asomers updated the diff for D22492: security/gnupg: don't install man pages when DOCS is off.

Always install man pages, but use USE=makeinfo

Nov 22 2019, 3:09 AM

Nov 21 2019

asomers added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

This isn't the right approach. Manpages aren't docs like FAQ and HACKING and DETAILS; they're manpages and their existence shouldn't be controlled by the DOCS option.
There are a couple options we could do:

  1. Only touch *.texi and patch the texi sources if DOCS is enabled
  2. Add a MANPAGES option
  3. Continue touching *.texi and patching the texi sources regardless, but delete the makeinfo line from docs/Makefile.am if DOCS is off
  4. Everybody gets texinfo
Nov 21 2019, 11:18 PM
asomers created D22492: security/gnupg: don't install man pages when DOCS is off.
Nov 21 2019, 10:52 PM
asomers created D22473: security/gnupg: add the --shared-access option to scdaemon.
Nov 21 2019, 2:10 AM
asomers committed rP518074: security/gnupg: rebuild man pages on every build.
security/gnupg: rebuild man pages on every build
Nov 21 2019, 1:49 AM
asomers closed D22471: security/gnupg: rebuild man pages.
Nov 21 2019, 1:49 AM
asomers added a comment to D22471: security/gnupg: rebuild man pages.

FYI, the DR already contained a PORTREVISION bump. You were probably just looking at the second item in the history, instead of the whole diff.

Nov 21 2019, 1:43 AM
asomers updated the diff for D22471: security/gnupg: rebuild man pages.

Rebuild man pages on every build, rather than try to patch them.

Nov 21 2019, 12:33 AM

Nov 20 2019

asomers added a comment to D22471: security/gnupg: rebuild man pages.

This seems tremendously fragile. Unless I'm misunderstanding, these massive patches would have to be regenerated for every update (assuming changes), which---while I appreciate the patch coming down the pipeline---I don't relish the thought of being responsible for.

Nov 20 2019, 11:58 PM
asomers created D22471: security/gnupg: rebuild man pages.
Nov 20 2019, 11:26 PM
asomers accepted D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Nov 20 2019, 11:01 PM
asomers requested changes to D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Nov 20 2019, 2:02 AM
asomers accepted D22398: bitstring: exit early if _start is past size of the bitstring.
Nov 20 2019, 1:51 AM

Nov 18 2019

asomers requested changes to D22400: bitstring: add functions to find contiguous set/unset bit sequences.

It should be fine to add new tests cases that depend on a specific nbits. Just add them normally instead of using the BITSTRING_TC_DEFINE macro.

Nov 18 2019, 9:39 PM
asomers requested changes to D22398: bitstring: exit early if _start is past size of the bitstring.

Would you mind adding tests to tests/sys/sys/bitstring_test.c?

Nov 18 2019, 9:27 PM
asomers closed D22339: Update the ses(4) man page.
Nov 18 2019, 2:12 PM
asomers committed rS354812: Update the ses(4) man page.
Update the ses(4) man page
Nov 18 2019, 2:12 PM

Nov 16 2019

asomers committed rS354779: Actually hook CAM_IO_STATS up to the build.
Actually hook CAM_IO_STATS up to the build
Nov 16 2019, 7:12 PM
asomers closed D22383: Actually hook CAM_IO_STATS up to the build.
Nov 16 2019, 7:12 PM

Nov 15 2019

asomers added a reviewer for D22339: Update the ses(4) man page: trasz.
Nov 15 2019, 7:38 PM
asomers created D22383: Actually hook CAM_IO_STATS up to the build.
Nov 15 2019, 4:20 PM

Nov 13 2019

asomers closed D22111: devel/py-libzfs: fix build with nonstandard FreeBSD src dir.

Committed in r515201 .

Nov 13 2019, 3:34 PM
asomers requested changes to D22103: ping: Use setitimer(2) instead of obsoleted alarm(3).

What about ping6.c? It has a similar invocation of alarm.

Nov 13 2019, 3:32 PM
asomers created D22339: Update the ses(4) man page.
Nov 13 2019, 12:22 AM

Nov 12 2019

asomers committed rS354666: sesutil: fix another memory leak.
sesutil: fix another memory leak
Nov 12 2019, 11:58 PM