Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (289 w, 27 m)

Recent Activity

Today

asomers added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

Sorry Alan, this was breaking the build on 11 so I committed it.

Fri, Nov 22, 3:54 AM
asomers updated the diff for D22492: security/gnupg: don't install man pages when DOCS is off.

Always install man pages, but use USE=makeinfo

Fri, Nov 22, 3:09 AM

Yesterday

asomers added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

This isn't the right approach. Manpages aren't docs like FAQ and HACKING and DETAILS; they're manpages and their existence shouldn't be controlled by the DOCS option.
There are a couple options we could do:

  1. Only touch *.texi and patch the texi sources if DOCS is enabled
  2. Add a MANPAGES option
  3. Continue touching *.texi and patching the texi sources regardless, but delete the makeinfo line from docs/Makefile.am if DOCS is off
  4. Everybody gets texinfo
Thu, Nov 21, 11:18 PM
asomers created D22492: security/gnupg: don't install man pages when DOCS is off.
Thu, Nov 21, 10:52 PM
asomers created D22473: security/gnupg: add the --shared-access option to scdaemon.
Thu, Nov 21, 2:10 AM
asomers committed rP518074: security/gnupg: rebuild man pages on every build.
security/gnupg: rebuild man pages on every build
Thu, Nov 21, 1:49 AM
asomers closed D22471: security/gnupg: rebuild man pages.
Thu, Nov 21, 1:49 AM
asomers added a comment to D22471: security/gnupg: rebuild man pages.

FYI, the DR already contained a PORTREVISION bump. You were probably just looking at the second item in the history, instead of the whole diff.

Thu, Nov 21, 1:43 AM
asomers updated the diff for D22471: security/gnupg: rebuild man pages.

Rebuild man pages on every build, rather than try to patch them.

Thu, Nov 21, 12:33 AM

Wed, Nov 20

asomers added a comment to D22471: security/gnupg: rebuild man pages.

This seems tremendously fragile. Unless I'm misunderstanding, these massive patches would have to be regenerated for every update (assuming changes), which---while I appreciate the patch coming down the pipeline---I don't relish the thought of being responsible for.

Wed, Nov 20, 11:58 PM
asomers created D22471: security/gnupg: rebuild man pages.
Wed, Nov 20, 11:26 PM
asomers accepted D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Wed, Nov 20, 11:01 PM
asomers requested changes to D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Wed, Nov 20, 2:02 AM
asomers accepted D22398: bitstring: exit early if _start is past size of the bitstring.
Wed, Nov 20, 1:51 AM

Mon, Nov 18

asomers requested changes to D22400: bitstring: add functions to find contiguous set/unset bit sequences.

It should be fine to add new tests cases that depend on a specific nbits. Just add them normally instead of using the BITSTRING_TC_DEFINE macro.

Mon, Nov 18, 9:39 PM
asomers requested changes to D22398: bitstring: exit early if _start is past size of the bitstring.

Would you mind adding tests to tests/sys/sys/bitstring_test.c?

Mon, Nov 18, 9:27 PM
asomers closed D22339: Update the ses(4) man page.
Mon, Nov 18, 2:12 PM
asomers committed rS354812: Update the ses(4) man page.
Update the ses(4) man page
Mon, Nov 18, 2:12 PM

Sat, Nov 16

asomers committed rS354779: Actually hook CAM_IO_STATS up to the build.
Actually hook CAM_IO_STATS up to the build
Sat, Nov 16, 7:12 PM
asomers closed D22383: Actually hook CAM_IO_STATS up to the build.
Sat, Nov 16, 7:12 PM

Fri, Nov 15

asomers added a reviewer for D22339: Update the ses(4) man page: trasz.
Fri, Nov 15, 7:38 PM
asomers created D22383: Actually hook CAM_IO_STATS up to the build.
Fri, Nov 15, 4:20 PM

Wed, Nov 13

asomers closed D22111: devel/py-libzfs: fix build with nonstandard FreeBSD src dir.

Committed in r515201 .

Wed, Nov 13, 3:34 PM
asomers requested changes to D22103: ping: Use setitimer(2) instead of obsoleted alarm(3).

What about ping6.c? It has a similar invocation of alarm.

Wed, Nov 13, 3:32 PM
asomers created D22339: Update the ses(4) man page.
Wed, Nov 13, 12:22 AM

Tue, Nov 12

asomers committed rS354666: sesutil: fix another memory leak.
sesutil: fix another memory leak
Tue, Nov 12, 11:58 PM
asomers committed rS354665: sesutil: fix some memory leaks.
sesutil: fix some memory leaks
Tue, Nov 12, 11:10 PM
asomers committed rS354664: sesutil: fix an out-of-bounds array access.
sesutil: fix an out-of-bounds array access
Tue, Nov 12, 11:03 PM

Sat, Nov 9

asomers committed rS354568: MFC r354116, r354120.
MFC r354116, r354120
Sat, Nov 9, 2:26 AM

Mon, Nov 4

asomers updated the diff for D22235: gmultipath: add ATF tests.

Fix the failloop test.

Mon, Nov 4, 9:09 PM
asomers planned changes to D22235: gmultipath: add ATF tests.
Mon, Nov 4, 7:57 PM
asomers created D22235: gmultipath: add ATF tests.
Mon, Nov 4, 6:01 PM

Fri, Nov 1

asomers committed rS354234: geli: raise WARNS to 6.
geli: raise WARNS to 6
Fri, Nov 1, 2:48 AM

Wed, Oct 30

asomers committed rS354166: MFC r353439:.
MFC r353439:
Wed, Oct 30, 2:34 AM
asomers committed rS354165: MFC r353117-r353118, r353281-r353282, r353284-r353289, r353309-r353310, r353360….
MFC r353117-r353118, r353281-r353282, r353284-r353289, r353309-r353310, r353360…
Wed, Oct 30, 2:03 AM
asomers committed rS354163: MFC r353068:.
MFC r353068:
Wed, Oct 30, 1:42 AM
asomers committed rS354161: MFC r352404, r352413-r352414.
MFC r352404, r352413-r352414
Wed, Oct 30, 1:35 AM

Sat, Oct 26

asomers committed rS354120: Commit missing file from r354116.
Commit missing file from r354116
Sat, Oct 26, 7:21 PM
asomers committed rS354116: MFZoL: Avoid retrieving unused snapshot props.
MFZoL: Avoid retrieving unused snapshot props
Sat, Oct 26, 5:11 PM

Oct 22 2019

asomers committed rP515201: devel/py-libzfs: fix build with nonstandard FreeBSD src dir.
devel/py-libzfs: fix build with nonstandard FreeBSD src dir
Oct 22 2019, 3:40 PM
asomers created D22111: devel/py-libzfs: fix build with nonstandard FreeBSD src dir.
Oct 22 2019, 3:31 PM

Oct 20 2019

asomers committed rP515068: devel/kcov: update to version 37.
devel/kcov: update to version 37
Oct 20 2019, 9:12 PM
asomers committed rS353779: Fix option names in the Examples section of the manual page.
Fix option names in the Examples section of the manual page
Oct 20 2019, 8:29 PM
asomers closed D22093: ping6: Fix option names in the Examples section of the manual page.
Oct 20 2019, 8:29 PM
asomers accepted D22093: ping6: Fix option names in the Examples section of the manual page.
Oct 20 2019, 8:26 PM

Oct 18 2019

asomers created D22077: Speed up "zpool import" in the presence of many zvols.
Oct 18 2019, 3:11 PM

Oct 15 2019

asomers added a comment to D21589: arp.c: use getaddrinfo(3) instead of gethostbyname(3).

@hrs do you realize that the submitter is not a committer? Can you commit this change for him?

Oct 15 2019, 12:12 AM

Oct 11 2019

asomers committed rS353439: MFZol: Fix performance of "zfs recv" with many deletions.
MFZol: Fix performance of "zfs recv" with many deletions
Oct 11 2019, 2:59 PM
asomers closed D21895: MFZol: Fix performance of "zfs recv" with many deletions.
Oct 11 2019, 2:59 PM
asomers added a comment to D21895: MFZol: Fix performance of "zfs recv" with many deletions.

Thanks Allan!

Oct 11 2019, 2:56 PM

Oct 10 2019

asomers committed rS353379: zfs: multiple improvements to the zpool_add tests.
zfs: multiple improvements to the zpool_add tests
Oct 10 2019, 2:18 AM

Oct 9 2019

asomers committed rS353366: ZFS: fix the zpool_add_010_pos test.
ZFS: fix the zpool_add_010_pos test
Oct 9 2019, 8:16 PM
asomers committed rS353361: ZFS: in the tests, don't override PWD.
ZFS: in the tests, don't override PWD
Oct 9 2019, 5:37 PM
asomers committed rS353360: ZFS: multiple fixes to the zpool_import tests.
ZFS: multiple fixes to the zpool_import tests
Oct 9 2019, 5:24 PM

Oct 8 2019

asomers committed rS353310: zfs: fix the zfsd_hotspare_007_pos test.
zfs: fix the zfsd_hotspare_007_pos test
Oct 8 2019, 3:48 PM
asomers committed rS353309: zfs: fix the zfsd_autoreplace_003_pos test.
zfs: fix the zfsd_autoreplace_003_pos test
Oct 8 2019, 3:33 PM

Oct 7 2019

asomers committed rS353289: ZFS: fix the redundancy tests.
ZFS: fix the redundancy tests
Oct 7 2019, 8:21 PM
asomers closed D21901: ZFS: fix the redundancy tests.
Oct 7 2019, 8:21 PM
asomers committed rS353288: ZFS: mark hotspare_scrub_002_pos as an expected failure.
ZFS: mark hotspare_scrub_002_pos as an expected failure
Oct 7 2019, 8:19 PM
asomers closed D21898: ZFS: fix the delegate tests.
Oct 7 2019, 8:14 PM
asomers committed rS353287: ZFS: fix the delegate tests.
ZFS: fix the delegate tests
Oct 7 2019, 8:14 PM
asomers closed D21878: zfs tests: skip the zfsd tests if zfsd is not already running.
Oct 7 2019, 7:50 PM
asomers committed rS353286: zfs: skip the zfsd tests if zfsd is not running.
zfs: skip the zfsd tests if zfsd is not running
Oct 7 2019, 7:50 PM
asomers committed rS353285: zfs: fix the zdb_001_neg test.
zfs: fix the zdb_001_neg test
Oct 7 2019, 7:48 PM
asomers committed rS353284: ZFS: fix the zpool_get_002_pos test.
ZFS: fix the zpool_get_002_pos test
Oct 7 2019, 7:24 PM
asomers committed rS353282: zfs: fix the slog_012_neg test.
zfs: fix the slog_012_neg test
Oct 7 2019, 6:56 PM
asomers committed rS353281: ZFS: fix several zvol_misc tests.
ZFS: fix several zvol_misc tests
Oct 7 2019, 6:21 PM

Oct 5 2019

asomers added inline comments to D21900: Fix problems in the kern_maxfiles__increase test.
Oct 5 2019, 10:56 PM
asomers committed rS353118: ZFS: fix several of the "zpool create" tests.
ZFS: fix several of the "zpool create" tests
Oct 5 2019, 3:20 AM
asomers committed rS353117: ZFS: the hotspare_add_004_neg test needs at least two disks.
ZFS: the hotspare_add_004_neg test needs at least two disks
Oct 5 2019, 1:35 AM

Oct 4 2019

asomers created D21901: ZFS: fix the redundancy tests.
Oct 4 2019, 10:28 PM
asomers updated subscribers of D21900: Fix problems in the kern_maxfiles__increase test.

That's not much of a test plan. Perhaps try sudo?

Oct 4 2019, 9:57 PM
asomers created D21898: ZFS: fix the delegate tests.
Oct 4 2019, 5:58 PM
asomers updated the diff for D21895: MFZol: Fix performance of "zfs recv" with many deletions.

Update tunable description, too.

Oct 4 2019, 4:55 PM
asomers created D21895: MFZol: Fix performance of "zfs recv" with many deletions.
Oct 4 2019, 3:20 PM

Oct 3 2019

asomers updated subscribers of D21878: zfs tests: skip the zfsd tests if zfsd is not already running.

cc @pinchuk.alek_gmail.com

Oct 3 2019, 8:23 PM
asomers added a comment to D21164: libefivar: remove bogus WARNS assignment.

ping @imp does this look correct to you?

Oct 3 2019, 8:22 PM
asomers committed rS353068: tftp: fix two minor Coverity CIDs.
tftp: fix two minor Coverity CIDs
Oct 3 2019, 8:22 PM
asomers closed D21695: tftp: fix two minor Coverity CIDs.
Oct 3 2019, 8:22 PM

Oct 2 2019

asomers created D21878: zfs tests: skip the zfsd tests if zfsd is not already running.
Oct 2 2019, 2:41 PM
asomers added a comment to D21876: simplify path handling in sysctl_try_reclaim_vnode.

If PATH_MAX + 1 is a problem here, then it's also a problem at fs/nfsserver/nfs_nfsdport.c:{3520, 3527, 3534, 3542}.

Oct 2 2019, 1:47 PM
asomers added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Oct 2 2019, 1:08 PM

Sep 22 2019

asomers committed rS352588: MF stable/12 r352489.
MF stable/12 r352489
Sep 22 2019, 12:13 AM

Sep 21 2019

asomers committed rS352573: MF stable/12 r352534:.
MF stable/12 r352534:
Sep 21 2019, 1:00 PM

Sep 19 2019

asomers committed rS352534: MFC r352417:.
MFC r352417:
Sep 19 2019, 5:42 PM

Sep 18 2019

asomers committed rS352490: MFC r351192, r351203.
MFC r351192, r351203
Sep 18 2019, 5:21 PM
asomers committed rS352489: MFC r351192, r351203.
MFC r351192, r351203
Sep 18 2019, 5:18 PM

Sep 17 2019

asomers created D21695: tftp: fix two minor Coverity CIDs.
Sep 17 2019, 11:18 PM
asomers added a comment to D21638: Add kqueue support for ZFS..

My experience is not directly applicable. All I did was add kqueue support for /dev/fuse, not for files stored on fusefs, and I was only concerned with EVFILT_(READ|WRITE), not EVFILT_VNODE. I would suggest that before you continue working on this patch, you write a test case.

Sep 17 2019, 3:43 AM

Sep 16 2019

asomers committed rS352417: Fix an off-by-one error from r351961.
Fix an off-by-one error from r351961
Sep 16 2019, 4:41 PM
asomers committed rS352414: fusefs: initialize C++ classes the Coverity way.
fusefs: initialize C++ classes the Coverity way
Sep 16 2019, 3:56 PM
asomers committed rS352413: fusefs: fix some minor Coverity CIDs in the tests.
fusefs: fix some minor Coverity CIDs in the tests
Sep 16 2019, 3:45 PM
asomers committed rS352404: fusefs: fix some minor issues with fuse_vnode_setparent.
fusefs: fix some minor issues with fuse_vnode_setparent
Sep 16 2019, 2:52 PM
asomers closed D21630: fusefs: fix some minor issues with fuse_vnode_setparent.
Sep 16 2019, 2:52 PM
asomers committed rS352372: MFC r352231:.
MFC r352231:
Sep 16 2019, 12:59 AM
asomers committed rS352371: MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226….
MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226…
Sep 16 2019, 12:57 AM

Sep 15 2019

asomers committed rS352357: MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424.
MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424
Sep 15 2019, 4:53 PM
asomers committed rP512089: sysutils/fusefs-libs: don't install irrelevant man pages.
sysutils/fusefs-libs: don't install irrelevant man pages
Sep 15 2019, 4:46 AM
asomers committed rS352351: MFC the new fusefs driver.
MFC the new fusefs driver
Sep 15 2019, 4:15 AM

Sep 13 2019

asomers created D21630: fusefs: fix some minor issues with fuse_vnode_setparent.
Sep 13 2019, 1:54 AM