asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (218 w, 2 d)

Recent Activity

Yesterday

asomers committed rS336319: auditon(2): fix A_SETPOLICY with 64-bit values.
auditon(2): fix A_SETPOLICY with 64-bit values
Sun, Jul 15, 9:10 PM
asomers closed D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.
Sun, Jul 15, 9:10 PM
asomers added inline comments to D16255: Separate the tests for auditon(2) based on individual commands.
Sun, Jul 15, 9:02 PM
asomers requested changes to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Sun, Jul 15, 8:57 PM
asomers requested changes to D16255: Separate the tests for auditon(2) based on individual commands.

administrative:auditon_setcond_success fails for me every time, probably because you haven't yet fixed the problem with unbuffered I/O in au_read_rec. How's that coming?

Sun, Jul 15, 8:53 PM

Sat, Jul 14

asomers added inline comments to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Sat, Jul 14, 3:40 PM
asomers added inline comments to D16255: Separate the tests for auditon(2) based on individual commands.
Sat, Jul 14, 3:01 PM
asomers accepted D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Sat, Jul 14, 2:58 PM

Fri, Jul 13

asomers requested changes to D16255: Separate the tests for auditon(2) based on individual commands.
Fri, Jul 13, 2:34 PM
asomers accepted D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.
Fri, Jul 13, 2:17 PM

Wed, Jul 11

asomers committed rS336212: MFC r335287, r335290.
MFC r335287, r335290
Wed, Jul 11, 8:11 PM
asomers committed rS336211: MFC r334547:.
MFC r334547:
Wed, Jul 11, 7:48 PM
asomers committed rS336210: MFC r334403:.
MFC r334403:
Wed, Jul 11, 7:47 PM
asomers committed rS336209: MFC r334394:.
MFC r334394:
Wed, Jul 11, 7:43 PM
asomers committed rS336208: MFC r334390:.
MFC r334390:
Wed, Jul 11, 7:41 PM
asomers committed rS336207: MFC r334296:.
MFC r334296:
Wed, Jul 11, 7:40 PM
asomers committed rS336205: Don't acquire evclass_lock with a spinlock held.
Don't acquire evclass_lock with a spinlock held
Wed, Jul 11, 7:38 PM
asomers closed D16210: Don't acquire evclass_lock with a spinlock held.
Wed, Jul 11, 7:38 PM
asomers requested changes to D16099: Introduce tests for Capability mode System calls and _exit(2).

using AUDITPIPE_FLUSH doesn't work. You should remove that part and fix the bug in utils.c instead.

Wed, Jul 11, 2:58 PM
asomers requested changes to D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.

This looks like a real bug, but your reproduction code is wrong. You're passing as the third argument sizeof(&auditpolicy), which is the size of a pointer to the policy variable, not the size of the policy variable itself. To correctly reproduce this, you'll have to fix the sizeof and use a uint64_t argument instead of an int.

Wed, Jul 11, 2:44 PM
asomers updated the diff for D16210: Don't acquire evclass_lock with a spinlock held.

Remove errant newline

Wed, Jul 11, 2:31 PM
asomers updated the diff for D16210: Don't acquire evclass_lock with a spinlock held.

Don't duplicate AUDIT_SYSCALL_EXIT in exit1

Wed, Jul 11, 1:15 PM
asomers added a comment to D16210: Don't acquire evclass_lock with a spinlock held.

Other than the (possible?) repetition of AUDIT_SYSCALL_EXIT in kern_exit.c. The issue with exa(1) seems to have gone away. Also, the regression tests for audit of _exit(2) in D16099 don't fail on introducing this change.

Wed, Jul 11, 1:14 PM

Tue, Jul 10

asomers added a comment to D16210: Don't acquire evclass_lock with a spinlock held.

@aniketp are there any exit-related audit events that you haven't tested yet? It would be good to check that this change doesn't break them.

Tue, Jul 10, 11:07 PM
asomers created D16210: Don't acquire evclass_lock with a spinlock held.
Tue, Jul 10, 11:05 PM
asomers added inline comments to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Tue, Jul 10, 2:59 PM

Fri, Jul 6

asomers added a comment to D16151: Add CSV output to gstat via -C flag.

This change looks good. But I have a few overall concerns:

  • ISO-8601 allows fractional seconds, at least according to Wikipedia. That would improve -C's accuracy and usefulness.

Sure. I have no problem with that. How would you feel if I omit factional seconds if -I is >=1s, though?

Fri, Jul 6, 4:59 PM

Thu, Jul 5

asomers added a comment to D16151: Add CSV output to gstat via -C flag.

This change looks good. But I have a few overall concerns:

  • ISO-8601 allows fractional seconds, at least according to Wikipedia. That would improve -C's accuracy and usefulness.
  • The existing logic is fairly ugly. It would be great to do a clean up pass. In particular I think all of the PRINTMSGs could be reduced to a few loops, if you define a format string array and an enabled array.
  • What happens if a new device arrives or one goes away while gstat -C is running?
Thu, Jul 5, 11:35 PM
asomers added a comment to D16151: Add CSV output to gstat via -C flag.

I don't know what you did, but somehow you created this review as a bare diff without any context information. Did you upload the raw diff into reviews.freebsd.org or something? If you use the php5-arcanist command line tool instead, the review will include unchanged portions of the file. It's much easier to review that way.

Thu, Jul 5, 9:15 PM

Wed, Jul 4

asomers added a comment to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.

The failure test case looks ok, but I think we should wait for the success test case before committing.

Wed, Jul 4, 6:33 PM

Tue, Jul 3

asomers added a comment to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.

How about audit(2)?

Tue, Jul 3, 7:29 PM
asomers committed rS335899: auditd(8): register signal handlers interrutibly.
auditd(8): register signal handlers interrutibly
Tue, Jul 3, 5:37 PM

Mon, Jul 2

asomers added a comment to D16099: Introduce tests for Capability mode System calls and _exit(2).

For me cap_enter_success passes intermittently. On a case when it failed, the global audit trail showed the cap_enter call we were looking for (as well as the child's exit(2), which is also in class "pc"). But the auditpipe showed nothing after fork. I think we're looking at a buffering issue. When I run "./process_control cap_enter_success" the last thing I see is the fork record. Then the process pauses for 10 seconds. But while it's paused, if I run any command at all in another terminal, then the test immediately passes. So I think that the auditpipe(4) device is buffering up some amount of data before its read(2) returns.

Mon, Jul 2, 6:43 PM

Sun, Jul 1

asomers committed rS335842: audit(4): add tests for procctl(2).
audit(4): add tests for procctl(2)
Sun, Jul 1, 4:06 PM
asomers closed D16086: Add tests for procctl(2): process-control audit class.
Sun, Jul 1, 4:06 PM
asomers accepted D16086: Add tests for procctl(2): process-control audit class.
Sun, Jul 1, 4:05 PM

Fri, Jun 29

asomers committed rS335792: audit(4): add tests for several more administrative syscalls.
audit(4): add tests for several more administrative syscalls
Fri, Jun 29, 4:52 AM
asomers closed D15898: Add tests for miscellaneous administrative system calls.
Fri, Jun 29, 4:52 AM
asomers committed rS335791: audit(4): add tests for setsid, wait4, wait6, and kill.
audit(4): add tests for setsid, wait4, wait6, and kill
Fri, Jun 29, 4:46 AM
asomers closed D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
Fri, Jun 29, 4:46 AM
asomers accepted D15898: Add tests for miscellaneous administrative system calls.
Fri, Jun 29, 4:40 AM
asomers accepted D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
Fri, Jun 29, 4:37 AM

Wed, Jun 27

asomers requested changes to D15898: Add tests for miscellaneous administrative system calls.
Wed, Jun 27, 5:21 PM
asomers requested changes to D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
Wed, Jun 27, 5:00 PM
asomers requested changes to D15898: Add tests for miscellaneous administrative system calls.
Wed, Jun 27, 4:44 PM
asomers requested changes to D15898: Add tests for miscellaneous administrative system calls.

If you intend to add successful test cases for mount, swapon, etc later, then you shouldn't indicate them as TODOs in the comments. Remove the text about how mount can't be tested in success mode.

Wed, Jun 27, 3:39 PM
asomers requested changes to D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
Wed, Jun 27, 3:38 PM
asomers committed rS335703: audit(4): fix Coverity issues.
audit(4): fix Coverity issues
Wed, Jun 27, 3:28 PM
asomers closed D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.
Wed, Jun 27, 3:28 PM
asomers accepted D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.
Wed, Jun 27, 2:56 PM

Tue, Jun 26

asomers requested changes to D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.

This is still incorrect. sizeof(buff) returns 80. That means that extattr_set_file is going to set the attribute's value to ezio\0 followed by 75 bytes of stack garbage. You might try leaving buff's length unspecified, by declaring it like static char buff[] = "ezio";. Whatever you do, ensure that the nbytes argument is either 4 (if you don't desire NULL termination) or 5 (if you do).

Tue, Jun 26, 8:37 PM
asomers committed rS335679: audit(4): add tests for the process-control audit class.
audit(4): add tests for the process-control audit class
Tue, Jun 26, 8:27 PM
asomers closed D15966: Introduce test-program for process-control group of system calls.
Tue, Jun 26, 8:27 PM
asomers committed rS335677: audit(4): add tests for pipe, posix_openpt, shm_open, and shm_unlink.
audit(4): add tests for pipe, posix_openpt, shm_open, and shm_unlink
Tue, Jun 26, 7:26 PM
asomers closed D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.
Tue, Jun 26, 7:26 PM

Mon, Jun 25

asomers accepted D15966: Introduce test-program for process-control group of system calls.
Mon, Jun 25, 12:42 AM
asomers requested changes to D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.
Mon, Jun 25, 12:39 AM

Sat, Jun 23

asomers accepted D15966: Introduce test-program for process-control group of system calls.
Sat, Jun 23, 7:57 PM
asomers added inline comments to D15966: Introduce test-program for process-control group of system calls.
Sat, Jun 23, 6:48 PM
asomers accepted D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.
Sat, Jun 23, 6:38 PM

Fri, Jun 22

asomers requested changes to D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.
Fri, Jun 22, 10:29 PM
asomers requested changes to D15966: Introduce test-program for process-control group of system calls.
Fri, Jun 22, 5:40 PM
asomers added a comment to D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.

Do these complete the IPC set?

Fri, Jun 22, 3:55 PM
asomers added inline comments to D15898: Add tests for miscellaneous administrative system calls.
Fri, Jun 22, 2:58 AM
asomers committed rS335528: audit(4): add tests for Sys V semaphore operations.
audit(4): add tests for Sys V semaphore operations
Fri, Jun 22, 2:56 AM
asomers closed D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Fri, Jun 22, 2:56 AM
asomers accepted D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Fri, Jun 22, 12:54 AM

Thu, Jun 21

asomers requested changes to D15898: Add tests for miscellaneous administrative system calls.
Thu, Jun 21, 7:21 PM
asomers requested changes to D15898: Add tests for miscellaneous administrative system calls.
Thu, Jun 21, 2:47 PM

Wed, Jun 20

asomers added a comment to D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.

Don't forget the _WANT_SEMUN change.

Wed, Jun 20, 4:15 PM
asomers added inline comments to D15898: Add tests for miscellaneous administrative system calls.
Wed, Jun 20, 3:20 PM
asomers requested changes to D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Wed, Jun 20, 2:59 PM

Tue, Jun 19

asomers committed rS335381: top(1): Fix Coverity warning.
top(1): Fix Coverity warning
Tue, Jun 19, 6:32 PM
asomers closed D15909: top(1): Fix Coverity warning.
Tue, Jun 19, 6:32 PM
asomers created D15909: top(1): Fix Coverity warning.
Tue, Jun 19, 5:52 PM
asomers closed D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).
Tue, Jun 19, 5:41 PM
asomers committed rS335378: audit(4): add tests for sendmsg, recvmsg, shutdown, and sendfile.
audit(4): add tests for sendmsg, recvmsg, shutdown, and sendfile
Tue, Jun 19, 5:41 PM
asomers accepted D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).

LGTM. sendmsg(2), by the way, is my least favorite system call of all time.

Tue, Jun 19, 5:39 PM
asomers requested changes to D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).
Tue, Jun 19, 4:58 PM
asomers committed rS335374: audit(4): add tests for utimes(2) and friends, mprotect, and undelete.
audit(4): add tests for utimes(2) and friends, mprotect, and undelete
Tue, Jun 19, 4:55 PM
asomers closed D15893: Add tests for utimes(2), futimes(2), lutimes(2), futimesat(2), mprotect(2) and undelete(2).
Tue, Jun 19, 4:55 PM
asomers accepted D15893: Add tests for utimes(2), futimes(2), lutimes(2), futimesat(2), mprotect(2) and undelete(2).
Tue, Jun 19, 4:55 PM
asomers requested changes to D15898: Add tests for miscellaneous administrative system calls.
Tue, Jun 19, 4:42 PM
asomers requested changes to D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Tue, Jun 19, 4:14 PM
asomers requested changes to D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).
Tue, Jun 19, 3:25 PM
asomers requested changes to D15893: Add tests for utimes(2), futimes(2), lutimes(2), futimesat(2), mprotect(2) and undelete(2).
Tue, Jun 19, 3:00 AM
asomers committed rS335354: audit(4): add tests for ioctl(2).
audit(4): add tests for ioctl(2)
Tue, Jun 19, 1:32 AM
asomers closed D15872: Introduce test-program for ioctl(2) syscall.
Tue, Jun 19, 1:32 AM
asomers accepted D15872: Introduce test-program for ioctl(2) syscall.
Tue, Jun 19, 12:47 AM

Mon, Jun 18

asomers added inline comments to D15872: Introduce test-program for ioctl(2) syscall.
Mon, Jun 18, 3:43 PM
asomers committed rS335320: audit(4): Add tests for {get/set}auid, {get/set}audit, {get/set}audit_addr.
audit(4): Add tests for {get/set}auid, {get/set}audit, {get/set}audit_addr
Mon, Jun 18, 3:38 PM
asomers closed D15871: Add tests for {get/set}auid, {get/set}audit, {get/set}audit_addr.
Mon, Jun 18, 3:38 PM
asomers accepted D15871: Add tests for {get/set}auid, {get/set}audit, {get/set}audit_addr.
Mon, Jun 18, 3:33 PM
asomers added a comment to D15871: Add tests for {get/set}auid, {get/set}audit, {get/set}audit_addr.

Instead of passing allocated and unitialized memory as the length for {get/set}audit_addr, simply pass the sizeof(auditinfo) as it is supposed to be used.

Thanks to @asomers for suggesting. Although I wish the man-page was a bit more clear on
this regard (about what exactly is length).

Mon, Jun 18, 3:30 PM
asomers committed rS335319: audit(4): add tests for send, recv, sendto, and recvfrom.
audit(4): add tests for send, recv, sendto, and recvfrom
Mon, Jun 18, 3:27 PM
asomers closed D15869: Syscalls concerned with sending/receiving message via sockets.
Mon, Jun 18, 3:27 PM
asomers accepted D15869: Syscalls concerned with sending/receiving message via sockets.
Mon, Jun 18, 3:17 PM
asomers committed rS335318: audit(4): add tests for extattr_set_file and friends.
audit(4): add tests for extattr_set_file and friends
Mon, Jun 18, 3:07 PM
asomers closed D15867: Syscalls concerned with modifying/deleting the extended attributes of a file.
Mon, Jun 18, 3:07 PM
asomers accepted D15867: Syscalls concerned with modifying/deleting the extended attributes of a file.
Mon, Jun 18, 2:59 PM