- User Since
- May 9 2014, 11:04 PM (370 w, 6 d)
Wed, Jun 16
Tue, Jun 15
Fri, Jun 11
Fri, Jun 4
Thu, Jun 3
Wed, Jun 2
Tue, Jun 1
The fstype is fuse.scribus-22.214.171.124-linux-x86_64.AppImage; options are fd=5,rootmode=40000,user_id=0,group_id=0.
The code looks good to me. Was the problem that a Linux command like "mount -t fuse.ntfs ..." wouldn't work?
Sun, May 30
Works for me. You should also reenable the test in tests/sys/fs/fusefs/write.cc.
Mon, May 24
Fri, May 21
This has now passed a make tinderbox.
Thu, May 20
There are also some header files in cddl/compat/opensolaris/include/ . Some of those are definitely needed, but I'm not sure about all of them.
May 18 2021
May 6 2021
Yep. That's wrong. In 14.0-CURRENT, the function that sets physpath is ses_set_physpath, in cam/scsi/scsi_enc_ses.c.
May 3 2021
May 2 2021
Apr 22 2021
- Respond to 0mp's man page review
Apr 21 2021
Apr 9 2021
Well, I don't see anything wrong with the code, @rmacklem . But I'm so ignorant of the protocol that I'm afraid I'm not able to give it a very good review.
Apr 8 2021
Mar 25 2021
Mar 22 2021
Sorry I'm late to the party, but I have a few questions:
Mar 21 2021
Mar 20 2021
Mar 18 2021
Mar 17 2021
Mar 16 2021
It doesn't matter, because Kyua executes the tests in separate temporary directories.
It shouldn't matter that they're using the same file name, because Kyua runs each test case in a separate temporary directory. Also, when you use Phabricator please include full context . The best way to do that is to create your revisions using arcanist (available in ports as devel/arcanist-php*. Or if you're uploading diffs through the web interface, generate them using the -u 9999 option.
Mar 13 2021
- Remove redundant variable assignment
Mar 7 2021
Mar 6 2021
Mar 4 2021
I didn't look at every file, but the overall pattern looks good. However, the fact that require.progs in a test file overrides the setting in the Kyua file, rather than adding to it, is arguably a bug. Maybe you should open a bug report upstream.
Your assertion that these are all POSIX sh scripts with ksh93 helpers is not correct. For example, hotspare/hotspare_test.sh sources hotspare/hotspare.kshlib, and that file makes use of ksh arrays. You therefore can't invoke hotspare_test.ksh with sh.
I think the current version is better than always using the fallback. Just fix the lint issue and I'll accept it.
Mar 3 2021
There's no way that EINVAL and ENOSYS are more common than errors like ENOSPC, EROFS, and EACCES. The latter three can happen in regular production environments, but the first two can only happen when building new releases like you found, or after an upgrade gone wrong.
We probably don't want to try the fallback path for cases like ENOSPC and EACCES. I think the original code, explicitly checking for ENOSYS and EINVAL, is better. BTW, I successfully built 13.0-BETA3 on 12.2-RELEASE yesterday. However, I did not use release.sh just buildworld and buildkernel. Is that your experience too, that release.sh is necessary to trigger the bug?
Um, what do you mean by that, @cem ?