Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (514 w, 3 d)

Recent Activity

Tue, Mar 12

asomers added a comment to D44320: Allow the bundled zstd to use utimensat.

An exp-run is what you suggested when I first raised the issue on freebsd-hackers last September. However, I don't know how to do an exp-run. Are you volunteering?

Tue, Mar 12, 8:09 PM
asomers requested review of D44320: Allow the bundled zstd to use utimensat.
Tue, Mar 12, 7:31 PM

Thu, Mar 7

asomers committed R11:4fd03fa24576: misc/buffer: deprecate (authored by asomers).
misc/buffer: deprecate
Thu, Mar 7, 10:57 PM

Tue, Mar 5

asomers committed rG89f4f91dbfdc: zfsd: Use vdev prop values for fault/degrade thresholds (authored by asomers).
zfsd: Use vdev prop values for fault/degrade thresholds
Tue, Mar 5, 7:29 PM
asomers closed D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Tue, Mar 5, 7:29 PM · ZFS

Fri, Feb 23

asomers accepted D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Fri, Feb 23, 5:12 PM · ZFS

Feb 12 2024

asomers committed rGf2c72486da30: fusefs: fix invalid value for st_birthtime.tv_nsec (authored by asomers).
fusefs: fix invalid value for st_birthtime.tv_nsec
Feb 12 2024, 8:18 PM
asomers committed rG65e25e4a614a: fusefs: fix invalid value for st_birthtime.tv_nsec (authored by asomers).
fusefs: fix invalid value for st_birthtime.tv_nsec
Feb 12 2024, 6:03 PM
asomers committed rGf3d5f910d53d: fusefs: more consistent operand ordering in io.cc (authored by asomers).
fusefs: more consistent operand ordering in io.cc
Feb 12 2024, 6:03 PM
asomers committed rG739488cc21b1: fusefs: fix invalid value for st_birthtime.tv_nsec (authored by asomers).
fusefs: fix invalid value for st_birthtime.tv_nsec
Feb 12 2024, 5:45 PM
asomers committed rG314a881fce0c: fusefs: fix some memory leaks in the tests (authored by asomers).
fusefs: fix some memory leaks in the tests
Feb 12 2024, 5:45 PM
asomers committed rG8510b8fe2abc: fusefs: prefer new/delete over malloc/free (authored by asomers).
fusefs: prefer new/delete over malloc/free
Feb 12 2024, 5:45 PM
asomers committed rG31c31be71624: fusefs: more consistent operand ordering in io.cc (authored by asomers).
fusefs: more consistent operand ordering in io.cc
Feb 12 2024, 5:44 PM
asomers committed rG9826f8eb0cca: fusefs: fix an interaction between copy_file_range and mmap (authored by asomers).
fusefs: fix an interaction between copy_file_range and mmap
Feb 12 2024, 5:44 PM

Feb 9 2024

asomers committed rG8758bf0aaec1: fusefs: only test for incoherency if FN_SIZECHANGE is set (authored by Emil Tsalapatis <emil@etsalapatis.com>).
fusefs: only test for incoherency if FN_SIZECHANGE is set
Feb 9 2024, 3:14 AM

Feb 8 2024

asomers accepted D43775: tests/unix_seqpacket: provide random data pumping test with MSG_EOR.

This looks good. BTW, you don't have to wait until the cleanup phase to print the seed. It's OK to print it at the beginning of the test phase. In the event of a failure, Kyua will report everything that the test printed.

Feb 8 2024, 2:29 PM

Feb 7 2024

asomers added a comment to D43775: tests/unix_seqpacket: provide random data pumping test with MSG_EOR.

I'll make resources reclaim patch, thanks!

But I don't agree with going for deterministic random. That will reduce test coverage. For such kind of tests to get coverage tending to 100% you need either go with deterministic random and volume of data to pump needs to tend to infinity. Or you can go true random and then make number of runs tend to infinity. The CI itself gives us the latter for free.

Of course failures reported by CI (if any) won't be reproducible immediately. But they will be a red flag. Once I got a failure, I will run the test in a loop until reproduction.

Feb 7 2024, 8:00 PM
asomers requested changes to D43775: tests/unix_seqpacket: provide random data pumping test with MSG_EOR.

This looks good. But I have a few thoughts:

Feb 7 2024, 3:23 PM

Feb 6 2024

asomers committed R11:25d6c9ed5201: sysutils/gstat-rs: update to 0.1.6 (authored by asomers).
sysutils/gstat-rs: update to 0.1.6
Feb 6 2024, 1:54 PM
asomers accepted D43756: tests/unix_seqpacket: remove EMSGSIZE tests.

So in the future it will be possible to send a single record with multiple send syscalls? In that case we can certainly remove these tests. However, in the future it will be important to ensure that we can send messages larger than the socket buffer size, right? In that case, I think we should leave these tests here for now, and update them atomically when the new behavior is committed. That way we won't forget.

Feb 6 2024, 1:23 AM

Feb 4 2024

asomers requested review of D43744: Provide a macro to initialize a vnode timestamp to "invalid".
Feb 4 2024, 10:09 PM
asomers committed rG55b80e2ca52c: fusefs: fix invalid value for st_birthtime.tv_nsec (authored by asomers).
fusefs: fix invalid value for st_birthtime.tv_nsec
Feb 4 2024, 9:04 PM
asomers closed D43590: fusefs: fix invalid value for st_birthtime.tv_nsec.
Feb 4 2024, 9:03 PM
asomers added inline comments to D43590: fusefs: fix invalid value for st_birthtime.tv_nsec.
Feb 4 2024, 8:58 PM
asomers added a comment to D43739: tmpfs: add a test case based on devel/fsx.

@imp here's a test case that depends on Rust. Not exactly what you meant, perhaps, but I think it would be a valuable addition. If you like this, we can add versions for other builtin file systems, too.

Feb 4 2024, 6:01 PM
asomers requested review of D43739: tmpfs: add a test case based on devel/fsx.
Feb 4 2024, 6:00 PM

Feb 3 2024

asomers added a comment to D43590: fusefs: fix invalid value for st_birthtime.tv_nsec.

@emaste what about something like this?

#define VA_NOTIME(ts) { \
    ts->tv_sec = -1; \
    ts->tv_nsec = 0; \
}
Feb 3 2024, 3:25 PM

Feb 2 2024

asomers committed rG49e8190c76c1: fusefs: fix an interaction between copy_file_range and mmap (authored by asomers).
fusefs: fix an interaction between copy_file_range and mmap
Feb 2 2024, 9:31 PM
asomers requested changes to D43448: lio_listio(2): add LIO_FOFFSET flag to ignore aiocb aio_offset.
Feb 2 2024, 9:17 PM

Jan 25 2024

asomers added a comment to D43590: fusefs: fix invalid value for st_birthtime.tv_nsec.

I think this is good but I wonder if we should have a trivial macro/inline for recording an unset/invalid va_birthtime?

Jan 25 2024, 4:24 PM
asomers requested review of D43590: fusefs: fix invalid value for st_birthtime.tv_nsec.
Jan 25 2024, 3:24 PM

Jan 20 2024

asomers committed rG62f890cfbc35: Add a regression test for PR 276191. (authored by asomers).
Add a regression test for PR 276191.
Jan 20 2024, 2:02 AM
asomers committed rGd741d23133be: nfsstat: make -q work without -e/-E (authored by lexi_le-fay.org).
nfsstat: make -q work without -e/-E
Jan 20 2024, 1:56 AM
asomers committed rGbe908114fd62: nfsstat: update option strings in docs (authored by lexi_le-fay.org).
nfsstat: update option strings in docs
Jan 20 2024, 1:55 AM
asomers committed rG5a2767d20325: Fix multiple bugs with ctld's UCL parsing (authored by asomers).
Fix multiple bugs with ctld's UCL parsing
Jan 20 2024, 1:54 AM
asomers committed rG5b4873c5b861: Remove _POSIX_PRIORITIZED_IO references from man pages (authored by asomers).
Remove _POSIX_PRIORITIZED_IO references from man pages
Jan 20 2024, 1:53 AM
asomers committed rG0125d6a23ba9: libcasper: document that most libcasper functions are not thread-safe (authored by asomers).
libcasper: document that most libcasper functions are not thread-safe
Jan 20 2024, 1:52 AM
asomers committed rGe016face1e26: cap_net.3: remove a copypasta (authored by asomers).
cap_net.3: remove a copypasta
Jan 20 2024, 1:52 AM
asomers committed rGf9f7404cd5c7: sigaction.2: clarify that fork isn't async-signal-safe, but _Fork is (authored by asomers).
sigaction.2: clarify that fork isn't async-signal-safe, but _Fork is
Jan 20 2024, 1:52 AM
asomers committed rG946afb62aba5: zfsd: fault disks that generate too many I/O delay events (authored by asomers).
zfsd: fault disks that generate too many I/O delay events
Jan 20 2024, 1:51 AM

Jan 19 2024

asomers committed rGd89317a66ff7: Add a regression test for PR 276191. (authored by asomers).
Add a regression test for PR 276191.
Jan 19 2024, 8:28 PM
asomers committed rG1726e4ced900: nfsstat: make -q work without -e/-E (authored by lexi_le-fay.org).
nfsstat: make -q work without -e/-E
Jan 19 2024, 8:25 PM
asomers committed rG266c79883a7e: nfsstat: update option strings in docs (authored by lexi_le-fay.org).
nfsstat: update option strings in docs
Jan 19 2024, 8:24 PM
asomers committed rGc2ec8038a7f1: Fix multiple bugs with ctld's UCL parsing (authored by asomers).
Fix multiple bugs with ctld's UCL parsing
Jan 19 2024, 8:22 PM
asomers committed rG08ac19609ca0: Remove _POSIX_PRIORITIZED_IO references from man pages (authored by asomers).
Remove _POSIX_PRIORITIZED_IO references from man pages
Jan 19 2024, 8:21 PM
asomers committed rGb4caacbef0a4: cap_net.3: remove a copypasta (authored by asomers).
cap_net.3: remove a copypasta
Jan 19 2024, 8:20 PM
asomers committed rG6328c1449502: sigaction.2: clarify that fork isn't async-signal-safe, but _Fork is (authored by asomers).
sigaction.2: clarify that fork isn't async-signal-safe, but _Fork is
Jan 19 2024, 8:19 PM
asomers committed rGe2ce586899ff: zfsd: fault disks that generate too many I/O delay events (authored by asomers).
zfsd: fault disks that generate too many I/O delay events
Jan 19 2024, 8:17 PM
asomers committed rG39f5d8dd1b2f: fusefs: fix some memory leaks in the tests (authored by asomers).
fusefs: fix some memory leaks in the tests
Jan 19 2024, 5:51 PM

Jan 17 2024

asomers committed rG8bae22bbbe65: fusefs: prefer new/delete over malloc/free (authored by asomers).
fusefs: prefer new/delete over malloc/free
Jan 17 2024, 10:50 PM
asomers closed D43464: fusefs: prefer new/delete over malloc/free.
Jan 17 2024, 10:50 PM
asomers updated the diff for D43464: fusefs: prefer new/delete over malloc/free.
  • Replaces memsets by default initializers. Delete allocations using
Jan 17 2024, 9:19 PM
asomers added inline comments to D43464: fusefs: prefer new/delete over malloc/free.
Jan 17 2024, 9:18 PM

Jan 16 2024

asomers added inline comments to D43464: fusefs: prefer new/delete over malloc/free.
Jan 16 2024, 2:54 AM

Jan 15 2024

asomers requested review of D43464: fusefs: prefer new/delete over malloc/free.
Jan 15 2024, 11:50 PM
asomers committed rGdaf26f9350cf: fusefs: more consistent operand ordering in io.cc (authored by asomers).
fusefs: more consistent operand ordering in io.cc
Jan 15 2024, 11:18 PM
asomers committed rG1c909c300b92: fusefs: fix an interaction between copy_file_range and mmap (authored by asomers).
fusefs: fix an interaction between copy_file_range and mmap
Jan 15 2024, 9:59 PM
asomers closed D43451: fusefs: fix an interaction between copy_file_range and mmap.
Jan 15 2024, 9:59 PM
asomers updated the diff for D43451: fusefs: fix an interaction between copy_file_range and mmap.
  • Use vnode_pager_clean_sync
Jan 15 2024, 8:41 PM

Jan 13 2024

asomers committed rG6b1c534927ad: Add a regression test for PR 276191. (authored by asomers).
Add a regression test for PR 276191.
Jan 13 2024, 10:48 PM
asomers closed D43446: Add a regression test for PR 276191..
Jan 13 2024, 10:48 PM
asomers requested review of D43451: fusefs: fix an interaction between copy_file_range and mmap.
Jan 13 2024, 10:43 PM
asomers added a comment to D43448: lio_listio(2): add LIO_FOFFSET flag to ignore aiocb aio_offset.
In D43448#990336, @kib wrote:
In D43448#990316, @kib wrote:

Will an operation with LIO_FOFFSET update the current file offset?

Yes.

What happens if two or more operations both specify LIO_FOFFSET? lio_listio does not specify the order in which the operations will be evaluated. Given that, this flag can't be used if two or more operations affect the same file. And IMHO lio_listio isn't very useful with such a restriction.

One of them would do the update first, and another one follows. It is up to caller to care.

I used lio_listio(2) to add the flag because it is extensible, unlike aio_read*(), and I do not want to add yet another syscall variant. I do think that typical use would be with nelem = 1.

Why would you use lio_listio with nelem == 1 ?

Because you can specify op with modifiers. This is impossible with current syscalls like aio_read(2).

Jan 13 2024, 9:37 PM
asomers added a comment to D43448: lio_listio(2): add LIO_FOFFSET flag to ignore aiocb aio_offset.
In D43448#990316, @kib wrote:

Will an operation with LIO_FOFFSET update the current file offset?

Yes.

What happens if two or more operations both specify LIO_FOFFSET? lio_listio does not specify the order in which the operations will be evaluated. Given that, this flag can't be used if two or more operations affect the same file. And IMHO lio_listio isn't very useful with such a restriction.

One of them would do the update first, and another one follows. It is up to caller to care.

I used lio_listio(2) to add the flag because it is extensible, unlike aio_read*(), and I do not want to add yet another syscall variant. I do think that typical use would be with nelem = 1.

Jan 13 2024, 8:54 PM
asomers added a comment to D43448: lio_listio(2): add LIO_FOFFSET flag to ignore aiocb aio_offset.

Will an operation with LIO_FOFFSET update the current file offset? What happens if two or more operations both specify LIO_FOFFSET? lio_listio does not specify the order in which the operations will be evaluated. Given that, this flag can't be used if two or more operations affect the same file. And IMHO lio_listio isn't very useful with such a restriction.

Jan 13 2024, 8:27 PM
asomers added inline comments to D43446: Add a regression test for PR 276191..
Jan 13 2024, 5:01 PM
asomers requested review of D43446: Add a regression test for PR 276191..
Jan 13 2024, 3:38 PM

Jan 11 2024

asomers committed rGd06a00963b7f: find: add SIGINFO handler (authored by meka_tilda.center).
find: add SIGINFO handler
Jan 11 2024, 11:39 PM
asomers closed D43380: find: add SIGINFO handler.
Jan 11 2024, 11:38 PM
asomers accepted D43380: find: add SIGINFO handler.
Jan 11 2024, 10:22 PM

Jan 9 2024

asomers added a reviewer for D43380: find: add SIGINFO handler: des.

It LGTM, but let's get some outside review, too. @des what do you think?

Jan 9 2024, 9:10 PM

Jan 8 2024

asomers added a comment to D43358: vnode_pager_generic_putpages(): correctly handle clean block at EOF.

Does this all happen sequentially, e.g., from a single thread? I'm a bit confused specifically by how we end up in putpages. Do you have a stack trace handy?

Jan 8 2024, 5:41 PM
asomers added a comment to D43358: vnode_pager_generic_putpages(): correctly handle clean block at EOF.

In the problematic scenario, we are writing pages starting at EOF. (How exactly does that happen?)

Jan 8 2024, 5:35 PM
asomers accepted D43358: vnode_pager_generic_putpages(): correctly handle clean block at EOF.

I don't grok this page cache stuff. But your patch works for me. BTW, fspacectl was a red herring. I can actually reproduce the panic with just a single mapwrite, as long as the size and offset are suitable.

Jan 8 2024, 3:57 PM
asomers added inline comments to D43356: Add vnode_pager_clean(9).
Jan 8 2024, 2:03 PM

Dec 31 2023

asomers accepted D43258: Fix copy_file_range(2) so that it does not truncate the output file erroneously.

This looks correct to me, but I haven't tested it in any way. I think it's a good candidate to add to pjdfstest.

Dec 31 2023, 5:53 PM

Dec 30 2023

asomers added a comment to D43250: nfsclient: handle page and buffer cache consistency().

This is the same as the 2nd patch you posted to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276002, right? That one does not fix the test case.

Dec 30 2023, 7:08 PM

Dec 28 2023

asomers committed rGf79b200b6aef: nfsstat: make -q work without -e/-E (authored by Lexi Winter <lexi@le-fay.org>).
nfsstat: make -q work without -e/-E
Dec 28 2023, 8:28 PM

Dec 27 2023

asomers committed R11:fefa21bc7fe2: sysutils/openzfs, sysutils/openzfs-kmod: update to ZFS 2.2.2 (authored by asomers).
sysutils/openzfs, sysutils/openzfs-kmod: update to ZFS 2.2.2
Dec 27 2023, 10:55 PM
asomers committed R11:21ef50a5d82d: net/nss_ldap: fix the build on both 13.2 and 14.0+ (authored by asomers).
net/nss_ldap: fix the build on both 13.2 and 14.0+
Dec 27 2023, 10:42 PM
asomers committed rG30ce26cacfd6: nfsstat: update option strings in docs (authored by Lexi Winter <lexi@le-fay.org>).
nfsstat: update option strings in docs
Dec 27 2023, 6:00 PM
asomers committed rG2391e536c01c: Fix multiple bugs with ctld's UCL parsing (authored by asomers).
Fix multiple bugs with ctld's UCL parsing
Dec 27 2023, 5:50 PM
asomers closed D43198: Fix multiple bugs with ctld's UCL parsing.
Dec 27 2023, 5:50 PM

Dec 26 2023

asomers added inline comments to D43198: Fix multiple bugs with ctld's UCL parsing.
Dec 26 2023, 7:39 PM
asomers requested review of D43198: Fix multiple bugs with ctld's UCL parsing.
Dec 26 2023, 7:08 PM
asomers abandoned D43197: Fix multiple bugs with ctld's UCL parsing.

Oops. I accidentally included way too many commits. I'll close this review and start over.

Dec 26 2023, 7:07 PM
asomers requested review of D43197: Fix multiple bugs with ctld's UCL parsing.
Dec 26 2023, 7:07 PM

Dec 25 2023

asomers accepted D43176: mps: Handle errors from copyout() in ioctl handlers.
Dec 25 2023, 6:19 PM
asomers accepted D43177: mpr: Handle errors from copyout() in ioctl handlers.
Dec 25 2023, 6:18 PM

Dec 22 2023

asomers committed R11:0a16af556dd1: net-mgmt/py-gstat_exporter: update to latest (authored by asomers).
net-mgmt/py-gstat_exporter: update to latest
Dec 22 2023, 3:17 PM

Dec 20 2023

asomers added a comment to D43130: ses: Add error checking for copyout() calls.

@markj All tests pass on my admittedly somewhat trailing edge hardware.

Dec 20 2023, 5:45 PM
asomers committed R11:12a4d6ea50d9: sysutils/ztop: upgrade to 0.2.3 (authored by asomers).
sysutils/ztop: upgrade to 0.2.3
Dec 20 2023, 3:45 PM
asomers committed R11:72cdec82a414: sysutils/gstat-rs: update to 0.1.5 (authored by asomers).
sysutils/gstat-rs: update to 0.1.5
Dec 20 2023, 3:44 PM
asomers added a comment to D43130: ses: Add error checking for copyout() calls.

LGTM. Do you need help testing it? I can test it for you, if you lack appropriate hardware.

Yes please!

Dec 20 2023, 1:31 AM
asomers accepted D43130: ses: Add error checking for copyout() calls.

LGTM. Do you need help testing it? I can test it for you, if you lack appropriate hardware.

Dec 20 2023, 1:22 AM

Dec 18 2023

asomers accepted D43087: renice: Clean up the tests a bit..
Dec 18 2023, 11:08 PM
asomers closed D42622: Remove _POSIX_PRIORITIZED_IO references from man pages.
Dec 18 2023, 3:08 PM
asomers committed rG18e2c4175f78: Remove _POSIX_PRIORITIZED_IO references from man pages (authored by asomers).
Remove _POSIX_PRIORITIZED_IO references from man pages
Dec 18 2023, 3:08 PM

Dec 8 2023

asomers committed rGcf037972ea88: libcasper: document that most libcasper functions are not thread-safe (authored by asomers).
libcasper: document that most libcasper functions are not thread-safe
Dec 8 2023, 4:23 PM
asomers closed D42928: casper: document that most libcasper and cap_net functions are not thread-safe.
Dec 8 2023, 4:23 PM