- User Since
- May 9 2014, 11:04 PM (307 w, 3 d)
Wed, Mar 25
Tue, Mar 24
I agree with Renato. There's no way to test in_cksum on both endiannesses without using something complicated like qemu. The right approach is to checksum the same input on different platforms, and assert that the result is identical on all. That's what Renato's change does. @renato.riolino_eldorado.org.br I don't think you have a commit bit, right? If not, I can commit the change for you. But I don't have any BE hardware. Can you first confirm that with your change the tests pass on BE hardware on a newish build?
Can we close this review now?
Sun, Mar 22
LGTM, but since the reader already has the man page open, you probably don't need to explain the`-F` flag again.
Sat, Mar 21
Wed, Mar 11
Thanks for such a speedy review!
Make a warning message scarier, and fix a style nit
Tue, Mar 10
Mon, Mar 9
Feb 26 2020
Feb 25 2020
I didn't closely review tftp-transfer.c, but everything else looks good, especially the tests! Thanks for implementing tests for option processing; I never got around to that.
Feb 23 2020
Feb 19 2020
Feb 13 2020
Feb 12 2020
Feb 4 2020
Good catch! I don't see any reason not to do it your way. In fact, @rwatson anticipated that in his original commit message.
Jan 28 2020
Committed with that last style comment from @mav.
Style changes suggested by Ryan
Jan 16 2020
Jan 13 2020
Jan 10 2020
timespec.tv_nsec is defined as long, not time_t. So you should be casting to long.
Dec 20 2019
Dec 7 2019
Dec 6 2019
Dec 1 2019
Nov 26 2019
LGTM. The extra braces you added in order to create scope for the itv variable are stylistically contentious. Some people would disagree with that, because it's not commonly done. But I happen to like that technique myself; no reason for itv to have more scope than necessary.
Nov 25 2019
It's ready to go, but I had one more question at https://reviews.freebsd.org/D22492 . I was waiting for your answer, not because it's strictly required but just in case you had something surprising to say.
Nov 23 2019
Nov 22 2019
Always install man pages, but use USE=makeinfo
Nov 21 2019
FYI, the DR already contained a PORTREVISION bump. You were probably just looking at the second item in the history, instead of the whole diff.
Rebuild man pages on every build, rather than try to patch them.
Nov 20 2019
Nov 18 2019
It should be fine to add new tests cases that depend on a specific nbits. Just add them normally instead of using the BITSTRING_TC_DEFINE macro.
Would you mind adding tests to tests/sys/sys/bitstring_test.c?
Nov 16 2019
Nov 15 2019
Nov 13 2019
Committed in r515201 .
What about ping6.c? It has a similar invocation of alarm.