Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (370 w, 6 d)

Recent Activity

Today

asomers committed R10:fcf2227a5575: periodic: by default, skip 221.backup-gpart in jails (authored by asomers).
periodic: by default, skip 221.backup-gpart in jails
Fri, Jun 18, 2:36 PM
asomers retitled D30810: fusefs: ensure that FUSE ops' headers' unique values are actually unique from fusefs: delete dead code to fusefs: ensure that FUSE ops' headers' unique values are actually unique.
Fri, Jun 18, 2:35 AM
asomers requested review of D30810: fusefs: ensure that FUSE ops' headers' unique values are actually unique.
Fri, Jun 18, 12:18 AM

Yesterday

asomers committed R10:b6de677b705d: fusefs: reenable the WriteCluster.cluster_write_err test (authored by asomers).
fusefs: reenable the WriteCluster.cluster_write_err test
Thu, Jun 17, 8:10 PM
asomers committed R10:c0e72b2bc081: Delete obsolete Solaris compat files (authored by asomers).
Delete obsolete Solaris compat files
Thu, Jun 17, 7:27 PM
asomers committed R10:ee3a7246c65c: gmultipath: make physpath distinct from the underlying providers' (authored by asomers).
gmultipath: make physpath distinct from the underlying providers'
Thu, Jun 17, 6:40 PM

Wed, Jun 16

asomers committed R10:9b876fbd504e: Simplify fuse_device_filt_write (authored by gAlfonso-bit <83477269+gAlfonso-bit@users.noreply.github.com>).
Simplify fuse_device_filt_write
Wed, Jun 16, 9:57 PM
asomers committed R10:7b8622fa220b: fusefs: support EVFILT_WRITE on /dev/fuse (authored by asomers).
fusefs: support EVFILT_WRITE on /dev/fuse
Wed, Jun 16, 7:35 PM
asomers closed D30784: fusefs: support EVFILT_WRITE on /dev/fuse.
Wed, Jun 16, 7:35 PM
asomers closed D30780: fusefs: improve warnings about buggy FUSE servers.
Wed, Jun 16, 7:32 PM
asomers committed R10:0b9a5c6fa173: fusefs: improve warnings about buggy FUSE servers (authored by asomers).
fusefs: improve warnings about buggy FUSE servers
Wed, Jun 16, 7:32 PM
asomers added inline comments to D30780: fusefs: improve warnings about buggy FUSE servers.
Wed, Jun 16, 6:37 PM
asomers added inline comments to D30784: fusefs: support EVFILT_WRITE on /dev/fuse.
Wed, Jun 16, 4:58 PM
asomers requested review of D30784: fusefs: support EVFILT_WRITE on /dev/fuse.
Wed, Jun 16, 1:00 AM

Tue, Jun 15

asomers committed R10:fcb5a0a2add1: vn_fullpath.9: update args after rev 364633 (authored by asomers).
vn_fullpath.9: update args after rev 364633
Tue, Jun 15, 9:44 PM
asomers closed D30779: vn_fullpath.9: update args after rev 364633.
Tue, Jun 15, 9:43 PM
asomers requested review of D30780: fusefs: improve warnings about buggy FUSE servers.
Tue, Jun 15, 9:41 PM
asomers requested review of D30779: vn_fullpath.9: update args after rev 364633.
Tue, Jun 15, 8:25 PM
asomers committed R10:d63e6bc25601: fusefs: delete dead code (authored by asomers).
fusefs: delete dead code
Tue, Jun 15, 7:36 PM
asomers committed R10:4a06e9377398: id: sanitize arguments better (authored by asomers).
id: sanitize arguments better
Tue, Jun 15, 12:52 PM
asomers closed D30734: id: sanitize arguments better.
Tue, Jun 15, 12:52 PM

Fri, Jun 11

asomers requested review of D30734: id: sanitize arguments better.
Fri, Jun 11, 4:40 PM

Fri, Jun 4

asomers committed R10:d94aa742b581: daemon: add some basic tests (authored by asomers).
daemon: add some basic tests
Fri, Jun 4, 2:49 AM

Thu, Jun 3

asomers committed R11:77e8418d5acd: shells/fish: fix the build with the DEBUG option (authored by asomers).
shells/fish: fix the build with the DEBUG option
Thu, Jun 3, 9:40 PM

Wed, Jun 2

asomers requested review of D30622: fusefs: correctly set lock owner during FUSE_SETLK.
Wed, Jun 2, 9:44 PM

Tue, Jun 1

asomers added a comment to D30606: linux: improve FUSE support.

The fstype is fuse.scribus-1.5.6.1-linux-x86_64.AppImage; options are fd=5,rootmode=40000,user_id=0,group_id=0.

Tue, Jun 1, 9:02 PM
asomers accepted D30606: linux: improve FUSE support.

The code looks good to me. Was the problem that a Linux command like "mount -t fuse.ntfs ..." wouldn't work?

Tue, Jun 1, 7:44 PM

Sun, May 30

asomers committed R10:f0d577fd2d41: [skip ci] volunteer to maintain POSIX AIO (authored by asomers).
[skip ci] volunteer to maintain POSIX AIO
Sun, May 30, 11:22 PM
asomers committed R10:425bbe9e64f7: fusefs: reenable the WriteCluster.cluster_write_err test (authored by asomers).
fusefs: reenable the WriteCluster.cluster_write_err test
Sun, May 30, 10:54 PM
asomers committed R10:5a20c351ea45: [skip ci] add a CODEOWNERS file (authored by asomers).
[skip ci] add a CODEOWNERS file
Sun, May 30, 10:50 PM
asomers closed D30559: [skip ci] add a CODEOWNERS file.
Sun, May 30, 10:49 PM
asomers added a comment to D30559: [skip ci] add a CODEOWNERS file.
In D30559#686263, @imp wrote:

I love this, though in time we may need to change the usernames a little depending on where we land.

For now, this is great, since we don't have pull requests turned on in gitlab that I can see.

Sun, May 30, 10:48 PM
asomers requested review of D30559: [skip ci] add a CODEOWNERS file.
Sun, May 30, 9:57 PM
asomers accepted D30555: vinvalbuf: do not panic if we were unable to flush dirty buffers.

Works for me. You should also reenable the test in tests/sys/fs/fusefs/write.cc.

Sun, May 30, 6:35 PM

Mon, May 24

asomers committed R10:fc3ba3e9fac0: Delete obsolete Solaris compat files (authored by asomers).
Delete obsolete Solaris compat files
Mon, May 24, 2:50 PM
asomers closed D30371: Delete obsolete Solaris compat files.
Mon, May 24, 2:49 PM

Fri, May 21

asomers added a comment to D30371: Delete obsolete Solaris compat files.

This has now passed a make tinderbox.

Fri, May 21, 3:25 PM

Thu, May 20

asomers added a comment to D30371: Delete obsolete Solaris compat files.

There are also some header files in cddl/compat/opensolaris/include/ . Some of those are definitely needed, but I'm not sure about all of them.

Thu, May 20, 9:46 PM
asomers requested review of D30371: Delete obsolete Solaris compat files.
Thu, May 20, 9:45 PM

May 18 2021

asomers accepted D30339: Retry OCF ENOMEM errors in ZFS.
May 18 2021, 8:28 PM · ZFS
asomers added inline comments to D30339: Retry OCF ENOMEM errors in ZFS.
May 18 2021, 7:56 PM · ZFS

May 6 2021

asomers added a comment to D29941: gmultipath: make physpath distinct from the underlying providers'.

Yep. That's wrong. In 14.0-CURRENT, the function that sets physpath is ses_set_physpath, in cam/scsi/scsi_enc_ses.c.

May 6 2021, 9:22 PM
asomers added a comment to D29941: gmultipath: make physpath distinct from the underlying providers'.
In D29941#676901, @mav wrote:

Excuse me if I am wrong, I don't have any multipath environment now to make sure, but I remember that SES on different expanders of dual-port backplane report different IDs.

May 6 2021, 8:41 PM
asomers added a comment to D29941: gmultipath: make physpath distinct from the underlying providers'.
In D29941#676861, @mav wrote:

I'm sorry for missing it earlier, but if there are actually several paths through the different HBAs and enclosures, what of the paths do you report? Random currently active one? Wouldn't it be better to not pass it through at all, unless we can somehow map all paths into something shared?

May 6 2021, 8:03 PM
asomers committed R10:420dbe763f15: gmultipath: make physpath distinct from the underlying providers' (authored by asomers).
gmultipath: make physpath distinct from the underlying providers'
May 6 2021, 6:33 PM
asomers closed D29941: gmultipath: make physpath distinct from the underlying providers'.
May 6 2021, 6:33 PM
asomers committed R11:05789f0b3773: www/py-treq: transfer maintainership to Evilham (authored by asomers).
www/py-treq: transfer maintainership to Evilham
May 6 2021, 1:05 AM
asomers committed R11:cd62f0886c18: www/py-treq: Update to 20.9.0 (authored by asomers).
www/py-treq: Update to 20.9.0
May 6 2021, 1:00 AM

May 3 2021

asomers committed R10:3b57d80c7aa9: daemon: add some basic tests (authored by asomers).
daemon: add some basic tests
May 3 2021, 3:56 PM
asomers closed D29316: daemon: add some basic tests.
May 3 2021, 3:56 PM

May 2 2021

asomers accepted D30076: make vn_generic_copy_file_range() run efficiently when the input file has a large hole to EOF.
May 2 2021, 2:20 AM

Apr 22 2021

asomers requested review of D29941: gmultipath: make physpath distinct from the underlying providers'.
Apr 22 2021, 10:38 PM
asomers added a comment to D29901: ctlstat: add prometheus output.
In D29901#671164, @0mp wrote:

I've got some minor fixes for the manual page.

Also, just an idea: shouldn't we extend libxo with Prometheus support? This way we would have a consistent way of printing this format across various utilities without having to introduce a different flag for each one.

Apr 22 2021, 8:02 PM
asomers updated the diff for D29901: ctlstat: add prometheus output.
  • Respond to 0mp's man page review
Apr 22 2021, 7:53 PM

Apr 21 2021

asomers requested review of D29901: ctlstat: add prometheus output.
Apr 21 2021, 11:00 PM

Apr 9 2021

asomers added a comment to D29475: add support for BindConnectionToSession to the NFSv4.1/4.2 client.

Well, I don't see anything wrong with the code, @rmacklem . But I'm so ignorant of the protocol that I'm afraid I'm not able to give it a very good review.

Apr 9 2021, 12:28 AM

Apr 8 2021

asomers committed R10:4934396cd3e6: Fix the build after 5061d5a0cfaf68a6891db82f6bd26ad3e72e87b1 (authored by asomers).
Fix the build after 5061d5a0cfaf68a6891db82f6bd26ad3e72e87b1
Apr 8 2021, 11:13 PM
asomers committed R10:ebe13089b5fa: mpsutil.8: fix typos in the man page (authored by asomers).
mpsutil.8: fix typos in the man page
Apr 8 2021, 9:37 PM
asomers committed R10:9a9c9e744b51: fusefs: fix two bugs regarding fcntl file locks (authored by asomers).
fusefs: fix two bugs regarding fcntl file locks
Apr 8 2021, 9:37 PM
asomers committed R10:e0c4ed73f3a6: Modernize geom_stats_snapshot_get (authored by asomers).
Modernize geom_stats_snapshot_get
Apr 8 2021, 9:37 PM
asomers committed R10:dee863a2b5a5: [skip ci] fix a typo in a comment in mdconfig.c (authored by asomers).
[skip ci] fix a typo in a comment in mdconfig.c
Apr 8 2021, 9:36 PM
asomers committed R10:8cfe6a4729f5: Speed up geom_stats_resync in the presence of many devices (authored by asomers).
Speed up geom_stats_resync in the presence of many devices
Apr 8 2021, 9:36 PM
asomers committed R10:9e9ef41bec1f: fortune: add a tip about gstat (authored by asomers).
fortune: add a tip about gstat
Apr 8 2021, 9:36 PM
asomers committed R10:e02c4d8d9bc7: fusefs: set d_off during VOP_READDIR (authored by asomers).
fusefs: set d_off during VOP_READDIR
Apr 8 2021, 9:35 PM
asomers committed R10:5061d5a0cfaf: mount_nullfs: rename a local variable (authored by asomers).
mount_nullfs: rename a local variable
Apr 8 2021, 9:35 PM
asomers committed R10:c835e54fdcb8: mpsutil.8: fix typos in the man page (authored by asomers).
mpsutil.8: fix typos in the man page
Apr 8 2021, 2:18 AM
asomers committed R10:802271fddbf4: fusefs: fix a dead store in fuse_vnop_advlock (authored by asomers).
fusefs: fix a dead store in fuse_vnop_advlock
Apr 8 2021, 2:18 AM
asomers committed R10:32be2332d10f: fusefs: fix two bugs regarding fcntl file locks (authored by asomers).
fusefs: fix two bugs regarding fcntl file locks
Apr 8 2021, 2:18 AM
asomers committed R10:774abe650b84: Modernize geom_stats_snapshot_get (authored by asomers).
Modernize geom_stats_snapshot_get
Apr 8 2021, 2:18 AM
asomers committed R10:438e52f814f6: [skip ci] fix a typo in a comment in mdconfig.c (authored by asomers).
[skip ci] fix a typo in a comment in mdconfig.c
Apr 8 2021, 2:18 AM
asomers committed R10:94db41ccdb93: mount_nullfs: rename a local variable (authored by asomers).
mount_nullfs: rename a local variable
Apr 8 2021, 2:18 AM

Mar 25 2021

asomers committed R10:f073ab8712a0: mpsutil.8: fix typos in the man page (authored by asomers).
mpsutil.8: fix typos in the man page
Mar 25 2021, 2:44 PM

Mar 22 2021

asomers added a comment to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

Sorry I'm late to the party, but I have a few questions:

Mar 22 2021, 7:19 PM

Mar 21 2021

asomers committed R10:2d1c164591ff: Speed up geom_stats_resync in the presence of many devices (authored by asomers).
Speed up geom_stats_resync in the presence of many devices
Mar 21 2021, 4:14 AM
asomers committed R10:aa9ff8f76041: fortune: add a tip about gstat (authored by asomers).
fortune: add a tip about gstat
Mar 21 2021, 2:21 AM
asomers committed R10:dc559c846d05: fusefs: set d_off during VOP_READDIR (authored by asomers).
fusefs: set d_off during VOP_READDIR
Mar 21 2021, 2:14 AM

Mar 20 2021

asomers committed R10:9c5aac8f2e84: fusefs: fix a dead store in fuse_vnop_advlock (authored by asomers).
fusefs: fix a dead store in fuse_vnop_advlock
Mar 20 2021, 1:42 AM
asomers closed D29031: fusefs: fix two bugs regarding fcntl file locks.
Mar 20 2021, 1:42 AM

Mar 18 2021

asomers committed R10:929acdb19acb: fusefs: fix two bugs regarding fcntl file locks (authored by asomers).
fusefs: fix two bugs regarding fcntl file locks
Mar 18 2021, 11:10 PM

Mar 17 2021

asomers requested review of D29316: daemon: add some basic tests.
Mar 17 2021, 4:38 PM

Mar 16 2021

asomers requested changes to D29290: Fix usr.bin/procstat/tests to be executed in parallel mode.

It doesn't matter, because Kyua executes the tests in separate temporary directories.

Mar 16 2021, 6:13 PM
asomers requested changes to D29289: Fix sbin/ping/ping_test to be executed in parallel mode.

It shouldn't matter that they're using the same file name, because Kyua runs each test case in a separate temporary directory. Also, when you use Phabricator please include full context . The best way to do that is to create your revisions using arcanist (available in ports as devel/arcanist-php*. Or if you're uploading diffs through the web interface, generate them using the -u 9999 option.

Mar 16 2021, 5:38 PM

Mar 13 2021

asomers updated the diff for D29031: fusefs: fix two bugs regarding fcntl file locks.
  • Remove redundant variable assignment
Mar 13 2021, 10:11 PM
asomers added inline comments to D29031: fusefs: fix two bugs regarding fcntl file locks.
Mar 13 2021, 10:10 PM

Mar 7 2021

asomers committed R10:abbf5f02fa1a: [skip ci] Add RELNOTES entries for aio_writev and fusefs (authored by asomers).
[skip ci] Add RELNOTES entries for aio_writev and fusefs
Mar 7 2021, 4:19 PM

Mar 6 2021

asomers abandoned D29032: net/nbdkit: fix the build on i386.

Superseded by https://svnweb.freebsd.org/changeset/ports/567499 by @kai

Mar 6 2021, 5:23 PM

Mar 4 2021

asomers added a comment to D29065: Fix `kyua list` for ATF_TESTS_KSH93 tests.

Your assertion that these are all POSIX sh scripts with ksh93 helpers is not correct. For example, hotspare/hotspare_test.sh sources hotspare/hotspare.kshlib, and that file makes use of ksh arrays. You therefore can't invoke hotspare_test.ksh with sh.

Do you happen to know how many of the ATF scripts need to be executed as ksh93? Would it be feasible to change them to run the actual tests in a new ksh93 shell? Or maybe re-exec if $0 == sh?

Mar 4 2021, 8:13 PM
asomers added a comment to D29065: Fix `kyua list` for ATF_TESTS_KSH93 tests.

I guess the real fix would be for kyua to not bother running $test -l if required_programs is missing...

Mar 4 2021, 7:08 PM
asomers accepted D29066: tests/sys/cddl: correctly quote atf_set "require.progs".

I didn't look at every file, but the overall pattern looks good. However, the fact that require.progs in a test file overrides the setting in the Kyua file, rather than adding to it, is arguably a bug. Maybe you should open a bug report upstream.

Mar 4 2021, 7:04 PM
asomers requested changes to D29065: Fix `kyua list` for ATF_TESTS_KSH93 tests.

Your assertion that these are all POSIX sh scripts with ksh93 helpers is not correct. For example, hotspare/hotspare_test.sh sources hotspare/hotspare.kshlib, and that file makes use of ksh arrays. You therefore can't invoke hotspare_test.ksh with sh.

Mar 4 2021, 6:57 PM
asomers closed D29047: Modernize geom_stats_snapshot_get.
Mar 4 2021, 2:47 PM
asomers committed R10:f05b724ecb31: Modernize geom_stats_snapshot_get (authored by asomers).
Modernize geom_stats_snapshot_get
Mar 4 2021, 2:47 PM
asomers added a comment to D28959: cp: fix operation on non-bleeding edge.

I think the current version is better than always using the fallback. Just fix the lint issue and I'll accept it.

Mar 4 2021, 2:02 AM

Mar 3 2021

asomers added a comment to D28959: cp: fix operation on non-bleeding edge.

There's no way that EINVAL and ENOSYS are more common than errors like ENOSPC, EROFS, and EACCES. The latter three can happen in regular production environments, but the first two can only happen when building new releases like you found, or after an upgrade gone wrong.

Mar 3 2021, 10:43 PM
asomers requested review of D29047: Modernize geom_stats_snapshot_get.
Mar 3 2021, 8:09 PM
asomers added a comment to D28959: cp: fix operation on non-bleeding edge.

We probably don't want to try the fallback path for cases like ENOSPC and EACCES. I think the original code, explicitly checking for ENOSYS and EINVAL, is better. BTW, I successfully built 13.0-BETA3 on 12.2-RELEASE yesterday. However, I did not use release.sh just buildworld and buildkernel. Is that your experience too, that release.sh is necessary to trigger the bug?

Mar 3 2021, 7:12 PM
asomers updated subscribers of D29031: fusefs: fix two bugs regarding fcntl file locks.

Um, what do you mean by that, @cem ?

Mar 3 2021, 3:04 PM
asomers requested review of D29032: net/nbdkit: fix the build on i386.
Mar 3 2021, 4:50 AM
asomers requested review of D29031: fusefs: fix two bugs regarding fcntl file locks.
Mar 3 2021, 3:31 AM
asomers updated the diff for D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
  • style(9)
Mar 3 2021, 3:29 AM