Use kib's preferred wording.

Respond to kib's criticism

Add note that there is no guarantee that VOP_INACTIVE will be called

What's the difference between this review and D19524 ? And why are you asking for review on an MFC?

In D19430#416155, @mat wrote:

I am not sure /usr/local/tests is the right place to put these files, it should probably more be something like /usr/local/share/tests.

Sorry, I missed that. I was searching for the wrong thing. In that, case, this change LGTM. I can't test it, though.

This change looks good. However, zonectl(8) currently hard-codes the entries_allocated field and doesn't check for a short return. If the kernel truncates the zone list, the user will have no obvious way of knowing. I think zonectl(8) should be modified to either loop until all zones have been reported, or at least tell the user that not all zones were reported.

LGTM!

s/ntohl/htonl

Approved. Just make sure the commit message matches the code.

Instead of casting the argument to a larger size, can you just use %zu instead?

In D18934#404425, @ngie wrote:

In D18934#404418, @asomers wrote:

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

It should work. The Committer's Guide was updated to use MFC with instead of X-MFC-With (the old form): https://www.freebsd.org/doc/en/articles/committers-guide/article.html#commit-log-message back almost 2 years ago by @emaste: https://svnweb.freebsd.org/doc?view=revision&revision=50227 ;).

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

LGTM. But you should still probably get a final review from the likes of @jilles or @kib .

FWIW our tree already has some tests that require C++-11. See lib/libc/tests/stdlib/Makefile. So importing an old version of googletest may not be worthwhile if it means forfeiting important features. Also, you may not have noticed, but there's already one googletest program in base, in cddl/usr.sbin/zfsd/tests. It's been there for years, but never hooked up to the build.

Sorry for the duplicate revision. I'm having curl problems.