Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (279 w, 4 d)

Recent Activity

Yesterday

asomers created D21695: tftp: fix two minor Coverity CIDs.
Tue, Sep 17, 11:18 PM
asomers added a comment to D21638: Add kqueue support for ZFS..

My experience is not directly applicable. All I did was add kqueue support for /dev/fuse, not for files stored on fusefs, and I was only concerned with EVFILT_(READ|WRITE), not EVFILT_VNODE. I would suggest that before you continue working on this patch, you write a test case.

Tue, Sep 17, 3:43 AM

Mon, Sep 16

asomers committed rS352417: Fix an off-by-one error from r351961.
Fix an off-by-one error from r351961
Mon, Sep 16, 4:41 PM
asomers committed rS352414: fusefs: initialize C++ classes the Coverity way.
fusefs: initialize C++ classes the Coverity way
Mon, Sep 16, 3:56 PM
asomers committed rS352413: fusefs: fix some minor Coverity CIDs in the tests.
fusefs: fix some minor Coverity CIDs in the tests
Mon, Sep 16, 3:45 PM
asomers committed rS352404: fusefs: fix some minor issues with fuse_vnode_setparent.
fusefs: fix some minor issues with fuse_vnode_setparent
Mon, Sep 16, 2:52 PM
asomers closed D21630: fusefs: fix some minor issues with fuse_vnode_setparent.
Mon, Sep 16, 2:52 PM
asomers committed rS352372: MFC r352231:.
MFC r352231:
Mon, Sep 16, 12:59 AM
asomers committed rS352371: MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226….
MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226…
Mon, Sep 16, 12:57 AM

Sun, Sep 15

asomers committed rS352357: MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424.
MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424
Sun, Sep 15, 4:53 PM
asomers committed rP512089: sysutils/fusefs-libs: don't install irrelevant man pages.
sysutils/fusefs-libs: don't install irrelevant man pages
Sun, Sep 15, 4:46 AM
asomers committed rS352351: MFC the new fusefs driver.
MFC the new fusefs driver
Sun, Sep 15, 4:15 AM

Fri, Sep 13

asomers created D21630: fusefs: fix some minor issues with fuse_vnode_setparent.
Fri, Sep 13, 1:54 AM

Thu, Sep 12

asomers committed rS352254: Record mergeinfo for r352232.
Record mergeinfo for r352232
Thu, Sep 12, 4:28 PM
asomers committed rS352252: MFC r351172:.
MFC r351172:
Thu, Sep 12, 4:23 PM

Wed, Sep 11

asomers committed rS352232: MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102.
MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102
Wed, Sep 11, 8:13 PM
asomers committed rS352231: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable
Wed, Sep 11, 7:48 PM
asomers closed D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
Wed, Sep 11, 7:48 PM
asomers updated the diff for D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.

Fix typo

Wed, Sep 11, 7:37 PM
asomers committed rS352230: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.
fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode
Wed, Sep 11, 7:29 PM
asomers closed D21557: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.
Wed, Sep 11, 7:29 PM
asomers updated the diff for D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.

Explicitly state that a timestamp may not be returned

Wed, Sep 11, 7:26 PM
asomers created D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
Wed, Sep 11, 6:59 PM
asomers committed rS352229: ping: Verify whether a datagram timestamp was actually received..
ping: Verify whether a datagram timestamp was actually received.
Wed, Sep 11, 6:55 PM
asomers committed rS352226: ping: fix a string in an error message.
ping: fix a string in an error message
Wed, Sep 11, 6:08 PM

Mon, Sep 9

asomers committed rP511693: security/py-certbot: Add periodic script for renewing certificates.
security/py-certbot: Add periodic script for renewing certificates
Mon, Sep 9, 7:51 PM

Sat, Sep 7

asomers committed rS352025: mount_fusefs: fix a segfault on memory allocation failure.
mount_fusefs: fix a segfault on memory allocation failure
Sat, Sep 7, 9:49 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Aha, to me it's similar to C++ templates. So there would be only one getopt loop at a source level, and two getopt loops at an object level. The two getopt loops (for the ping6's new option set and for the old one) would be called from a single source file like this:

if (strcmp(argv[0], "ping6") == 0)
    parse_old_options();
else
    parse_new_options();

so the name of the parse function would also need to be parametrized to avoid conflicts of symbols at the object level.

Sat, Sep 7, 7:27 PM
asomers committed rS352021: fusefs: suppress some Coverity resource leak CIDs in the tests.
fusefs: suppress some Coverity resource leak CIDs in the tests
Sat, Sep 7, 7:26 PM

Fri, Sep 6

asomers created D21557: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.
Fri, Sep 6, 10:39 PM
asomers committed rS351964: MFC r350858-r350859, r350987, r351170.
MFC r350858-r350859, r350987, r351170
Fri, Sep 6, 8:16 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

The single getopt loop would have to be parametrized at runtime. How do the preprocessor directives fit into this?

Fri, Sep 6, 8:08 PM
asomers committed rS351963: fusefs: coverity cleanup in the tests.
fusefs: coverity cleanup in the tests
Fri, Sep 6, 7:50 PM
asomers closed D21457: fusefs: coverity cleanup in the tests.
Fri, Sep 6, 7:50 PM
asomers added inline comments to D21457: fusefs: coverity cleanup in the tests.
Fri, Sep 6, 7:47 PM
asomers committed rS351962: MFC r350556:.
MFC r350556:
Fri, Sep 6, 7:46 PM
asomers committed rS351961: Coverity fixes in fusefs(5).
Coverity fixes in fusefs(5)
Fri, Sep 6, 7:40 PM
asomers closed D21466: Coverity fixes in fusefs(5).
Fri, Sep 6, 7:40 PM
asomers committed rS351960: MFC r350453:.
MFC r350453:
Fri, Sep 6, 7:37 PM
asomers committed rS351958: MFC r350426:.
MFC r350426:
Fri, Sep 6, 7:29 PM
asomers committed rS351957: MFC r350386, r350390.
MFC r350386, r350390
Fri, Sep 6, 7:22 PM
asomers committed rS351955: MFC r350314:.
MFC r350314:
Fri, Sep 6, 7:07 PM
asomers committed rS351949: MFC r350291:.
MFC r350291:
Fri, Sep 6, 6:23 PM
asomers committed rS351948: MFC r350268:.
MFC r350268:
Fri, Sep 6, 6:14 PM
asomers committed rS351947: MFC r350227:.
MFC r350227:
Fri, Sep 6, 6:11 PM
asomers committed rS351946: MFC r346186:.
MFC r346186:
Fri, Sep 6, 6:10 PM
asomers committed rS351945: MFC r345986:.
MFC r345986:
Fri, Sep 6, 6:08 PM
asomers committed rS351944: MFC r345675, r345689.
MFC r345675, r345689
Fri, Sep 6, 6:03 PM
asomers committed rS351943: MFC r344183-r344187, r344333-r344334, r344407, r344857, r344865 (by cem).
MFC r344183-r344187, r344333-r344334, r344407, r344857, r344865 (by cem)
Fri, Sep 6, 5:56 PM
asomers committed rS351941: MFC r350225:.
MFC r350225:
Fri, Sep 6, 5:43 PM
asomers committed rS351940: MFC r345350, r346441, r346765.
MFC r345350, r346441, r346765
Fri, Sep 6, 5:21 PM

Wed, Sep 4

asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Does it mean that there could be only one getopt loop with a variable getopt string for solving the compatibility problem?

Yes, exactly.

In this case there would have to be some syntactic check duplication in the getopt's switch-case. Some options were renamed according to the pattern (A ->B, B->C) so one case would contain syntactic check for option A and the other for both B and A. If only the case labels could have been non-constant.

Wed, Sep 4, 8:01 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

I need to be sure I understand you correctly.

Since only a few options have changed, what about defining constants like #DEFINE ADDRTYPE_OPT 'k' before including options.h, and composing the getopt string like we already do with ADDOPTS.

Does it mean that there could be only one getopt loop with a variable getopt string for solving the compatibility problem?

Wed, Sep 4, 3:01 PM

Tue, Sep 3

asomers updated the diff for D21457: fusefs: coverity cleanup in the tests.

Add one more change that I forgot to save before starting the review

Tue, Sep 3, 10:30 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Since only a few options have changed, what about defining constants like #DEFINE ADDRTYPE_OPT 'k' before including options.h, and composing the getopt string like we already do with ADDOPTS. Then in options.c, for those options whose flags differ between the two programs, compose the error message at runtime.

Tue, Sep 3, 8:41 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

So what's the plan for ping -6 vs ping? Are you going to have two different copies of options_parse?

Tue, Sep 3, 6:46 PM
asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Tue, Sep 3, 3:22 PM

Sun, Sep 1

asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Yes, that's about what I had in mind. But did you intend to set f_sock_buff_size in the getopt loop?

Sun, Sep 1, 2:06 AM

Sat, Aug 31

asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Sat, Aug 31, 4:29 AM

Thu, Aug 29

D21469: Remove some unused VM locking macros from fusefs. is now accepted and ready to land.

Good catch. Looks like those have been dead code ever since r292373.

Thu, Aug 29, 9:08 PM
asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Thu, Aug 29, 7:11 PM
asomers created D21466: Coverity fixes in fusefs(5).
Thu, Aug 29, 5:06 PM
asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Thu, Aug 29, 3:49 PM
asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Thu, Aug 29, 2:44 PM

Wed, Aug 28

asomers created D21457: fusefs: coverity cleanup in the tests.
Wed, Aug 28, 5:24 PM
asomers added inline comments to D21442: Fix qmath(3) with new GCC.
Wed, Aug 28, 2:54 PM
asomers committed rS351560: fusefs: Fix some bugs regarding the size of the LISTXATTR list.
fusefs: Fix some bugs regarding the size of the LISTXATTR list
Wed, Aug 28, 4:19 AM
asomers closed D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr.
Wed, Aug 28, 4:19 AM
asomers added a comment to D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr.
In D21287#466723, @cem wrote:

This approach looks technically correct to me, and it simplifies the logic, but there is definitely some microbenchmark cost to exiting to userspace every retry instead of doing so "a few times" in the kernel (with some algorithm). But this is maybe just premature optimization on my part.

Wed, Aug 28, 4:11 AM

Tue, Aug 27

asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Tue, Aug 27, 9:12 PM
asomers added a comment to D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr.

Accomodate buggy or malicious fuse servers that always return ERANGE for
FUSE_LISTXATTR. Instead of restarting within the VOP; return ERESTART.
That way the blocked process will be killable.

Tue, Aug 27, 9:02 PM
asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Tue, Aug 27, 3:50 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

I would also like to ask for help with copyright. What should I use if some code is not mine (mainly the #define directives) and some is?

Tue, Aug 27, 3:40 PM
asomers closed D21405: ping: raise WARNS level to 6.
Tue, Aug 27, 3:35 PM
asomers committed rS351548: ping: raise WARNS level to 6.
ping: raise WARNS level to 6
Tue, Aug 27, 3:34 PM
D21405: ping: raise WARNS level to 6 is now accepted and ready to land.
Tue, Aug 27, 3:33 PM

Mon, Aug 26

asomers added inline comments to D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr.
Mon, Aug 26, 9:16 PM

Sat, Aug 24

asomers closed D21406: ping: use CMSG_FIRSTHDR() for accessing ancillary data.
Sat, Aug 24, 6:00 PM
asomers committed rS351461: ping: fix unaligned access to ancillary data.
ping: fix unaligned access to ancillary data
Sat, Aug 24, 6:00 PM
D21406: ping: use CMSG_FIRSTHDR() for accessing ancillary data is now accepted and ready to land.
Sat, Aug 24, 5:57 PM
asomers added a comment to D21406: ping: use CMSG_FIRSTHDR() for accessing ancillary data.

Well, it fixes the build. But now the program segfaults.

Sat, Aug 24, 5:13 PM
asomers added a comment to D21405: ping: raise WARNS level to 6.

The build fails on sparc64 and powerpcspe with this error. Weirdly, it passed on powerpc and powerpc64; I don't know why:

/home/asomers/freebsd/base/head/sbin/ping/ping.c: In function 'main':
/home/asomers/freebsd/base/head/sbin/ping/ping.c:923: warning: cast increases required alignment of target type
Sat, Aug 24, 3:16 PM
D21377: ping: merge ping6 to ping now requires changes to proceed.

You still need to add entries to UPDATING and ObsoleteFiles.inc. Other than that, it looks good.

Sat, Aug 24, 3:13 PM

Fri, Aug 23

asomers committed rS351440: ping: Fix alignment errors.
ping: Fix alignment errors
Fri, Aug 23, 10:04 PM
asomers closed D21327: ping: fix alignment errors.
Fri, Aug 23, 10:04 PM
D21327: ping: fix alignment errors is now accepted and ready to land.
Fri, Aug 23, 10:02 PM
asomers added inline comments to D21377: ping: merge ping6 to ping.
Fri, Aug 23, 8:42 PM
asomers added a comment to D21327: ping: fix alignment errors.

This revision needs to be rebased since the changes to -n and -H.

Fri, Aug 23, 8:28 PM
asomers added a comment to D21377: ping: merge ping6 to ping.

It will take me some time to find out why. On my system it builds. Could you please send me your main.c? It's interesting that there are double definitions of the functions.

Fri, Aug 23, 7:44 PM
asomers added a comment to D21377: ping: merge ping6 to ping.

Now it doesn't even build:

/usr/home/somers/freebsd/base/head/sbin/ping/main.c:249:1: error: redefinition
      of 'main'
main(int argc, char *argv[])
^
/usr/home/somers/freebsd/base/head/sbin/ping/main.c:59:1: note: previous
      definition is here
main(int argc, char *argv[])
^
/usr/home/somers/freebsd/base/head/sbin/ping/main.c:331:1: error: redefinition
      of 'usage'
usage(void)
^
/usr/home/somers/freebsd/base/head/sbin/ping/main.c:141:1: note: previous
      definition is here
usage(void)
^
2 errors generated.
Fri, Aug 23, 7:11 PM
asomers added inline comments to D21377: ping: merge ping6 to ping.
Fri, Aug 23, 5:46 PM
asomers added a comment to D21377: ping: merge ping6 to ping.

Oh, and you need to update rescue/rescue/Makefile, too.

Fri, Aug 23, 4:35 PM
D21327: ping: fix alignment errors now requires changes to proceed.
Fri, Aug 23, 4:27 PM
D21377: ping: merge ping6 to ping now requires changes to proceed.

Don't forget to add an entry to UPDATING and to ObsoleteFiles.inc

Fri, Aug 23, 4:25 PM
asomers committed rS351424: ping: fix include guard symbol name to reflect the header file name.
ping: fix include guard symbol name to reflect the header file name
Fri, Aug 23, 3:24 PM
asomers closed D21374: ping: fix include guard symbol name to reflect the header file name.
Fri, Aug 23, 3:24 PM
D21374: ping: fix include guard symbol name to reflect the header file name is now accepted and ready to land.
Fri, Aug 23, 3:23 PM
asomers committed rS351423: ping6: Rename options for better consistency with ping.
ping6: Rename options for better consistency with ping
Fri, Aug 23, 3:22 PM
Herald added a reviewer for D21345: ping6: Rename options for unifying option parsing with ping: manpages.
Fri, Aug 23, 3:22 PM
asomers added a comment to D21345: ping6: Rename options for unifying option parsing with ping.

One more thing: you should normally add an entry in UPDATING letting people know that the options have changed so they can update their scripts. I'll go ahead and write it this time.

Fri, Aug 23, 3:20 PM