Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (350 w, 26 m)

Recent Activity

Wed, Jan 20

asomers committed R10:2247f4894174: aio: micro-optimize the lio_opcode assignments (authored by asomers).
aio: micro-optimize the lio_opcode assignments
Wed, Jan 20, 4:04 PM
asomers closed D27942: aio: micro-optimize the lio_opcode assignments.
Wed, Jan 20, 4:03 PM
asomers requested review of D28256: ZFS: fix assertions with INVARIANTS.
Wed, Jan 20, 3:56 PM

Thu, Jan 14

asomers updated the diff for D27942: aio: micro-optimize the lio_opcode assignments.
  • aio: micro-optimize the lio_opcode assignments
  • Rebase to include LIO_DSYNC
Thu, Jan 14, 4:02 AM
asomers added a comment to D27942: aio: micro-optimize the lio_opcode assignments.

Rebased to include lio_listio opcode validation.

Thu, Jan 14, 4:02 AM
asomers closed D28078: lio_listio: validate aio_lio_opcode.

Closed by https://cgit.freebsd.org/src/commit/?id=ff1a307801994e18a87929898225f09d31f3e1fa .

Thu, Jan 14, 3:33 AM

Tue, Jan 12

asomers committed R10:ff1a30780199: lio_listio: validate aio_lio_opcode (authored by asomers).
lio_listio: validate aio_lio_opcode
Tue, Jan 12, 2:54 AM
asomers committed R10:292808246db7: ICMP checksum test: Fix for big endian (authored by renato.riolino_eldorado.org.br).
ICMP checksum test: Fix for big endian
Tue, Jan 12, 2:11 AM
asomers closed D23193: ICMP checksum test: Fix for big endian.
Tue, Jan 12, 2:10 AM · tests
asomers committed R10:58a08f9e9910: [skip ci] Delete an accidentally-committed comment (authored by asomers).
[skip ci] Delete an accidentally-committed comment
Tue, Jan 12, 12:03 AM

Mon, Jan 11

asomers added a comment to D23193: ICMP checksum test: Fix for big endian.

This review was approved in March last year. It seems all issues have been solved. Could anyone commit this?

Mon, Jan 11, 7:05 PM · tests

Sun, Jan 10

asomers requested review of D28078: lio_listio: validate aio_lio_opcode.
Sun, Jan 10, 5:33 AM
asomers added a comment to D27942: aio: micro-optimize the lio_opcode assignments.

I rebased. I'll open a separate review to validate lio_listio opcodes.

Sun, Jan 10, 1:11 AM
asomers updated the diff for D27942: aio: micro-optimize the lio_opcode assignments.
  • aio: micro-optimize the lio_opcode assignments
  • Rebase to include LIO_DSYNC
Sun, Jan 10, 1:11 AM
asomers committed R10:19cca0b9613d: aio: fix the tests when ZFS is not available (authored by asomers).
aio: fix the tests when ZFS is not available
Sun, Jan 10, 12:18 AM

Sat, Jan 9

asomers closed D27997: Reallocate syscall numbers for aio_writev and aio_readv.

Fixed by https://cgit.freebsd.org/src/commit/?id=b3286afae364c065183da3a910a33db3032529d4 .

Sat, Jan 9, 6:58 PM

Fri, Jan 8

asomers committed R10:20321e622515: Regenerate syscall files after reallocation of aio_writev/aio_readv (authored by asomers).
Regenerate syscall files after reallocation of aio_writev/aio_readv
Fri, Jan 8, 2:51 AM
asomers committed R10:b3286afae364: Reallocate syscall numbers for aio_writev and aio_readv (authored by asomers).
Reallocate syscall numbers for aio_writev and aio_readv
Fri, Jan 8, 2:51 AM

Thu, Jan 7

asomers added a comment to D27997: Reallocate syscall numbers for aio_writev and aio_readv.

@jrtc27 @brooks the FreeBSD 13 KBI freeze is tomorrow. If you want these syscall numbers to get changed, please review ASAP!

Thu, Jan 7, 9:47 PM

Wed, Jan 6

asomers accepted D25071: aio_fsync(O_DSYNC).

LGTM!

Wed, Jan 6, 3:21 PM
asomers requested review of D27997: Reallocate syscall numbers for aio_writev and aio_readv.
Wed, Jan 6, 5:28 AM

Mon, Jan 4

asomers added a comment to D27947: Fix LK_TRYUPGRADE.

Sounds good. Are you going to commit, @mjg ?

Mon, Jan 4, 10:30 PM
asomers added a comment to D27947: Fix LK_TRYUPGRADE.

The effect of the bug is that the upgrade always fails. And all consumers are required to deal with both failure and success of a lock upgrade. So we might not see any obvious effects. Performance could be affect, though. But I'm not failure enough with the consuming code to know what kind of benchmark might be expected to show a difference.

Mon, Jan 4, 8:18 PM
asomers requested review of D27947: Fix LK_TRYUPGRADE.
Mon, Jan 4, 4:05 AM
asomers added inline comments to D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
Mon, Jan 4, 4:00 AM

Sun, Jan 3

asomers requested review of D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
Sun, Jan 3, 11:20 PM
asomers closed D27938: Fix vnode locking bug in fuse_vnop_copy_file_range.
Sun, Jan 3, 6:20 PM
asomers committed R10:17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range (authored by asomers).
Fix vnode locking bug in fuse_vnop_copy_file_range
Sun, Jan 3, 6:20 PM
asomers updated the diff for D27938: Fix vnode locking bug in fuse_vnop_copy_file_range.
  • Don't leak locks on fufh lookup failure
Sun, Jan 3, 4:34 PM
asomers committed R10:34477e25c1d4: fusefs: only check vnode locks with DEBUG_VFS_LOCKS (authored by asomers).
fusefs: only check vnode locks with DEBUG_VFS_LOCKS
Sun, Jan 3, 4:20 PM
asomers closed D27939: fusefs: only check vnode locks with DEBUG_VFS_LOCKS.
Sun, Jan 3, 4:20 PM
asomers committed R10:542711e52079: Fix a vnode locking bug in fuse_vnop_advlock. (authored by asomers).
Fix a vnode locking bug in fuse_vnop_advlock.
Sun, Jan 3, 4:17 PM
asomers closed D27936: Fix a vnode locking bug in fuse_vnop_advlock..
Sun, Jan 3, 4:17 PM
asomers added inline comments to D27936: Fix a vnode locking bug in fuse_vnop_advlock..
Sun, Jan 3, 4:00 PM
asomers requested review of D27942: aio: micro-optimize the lio_opcode assignments.
Sun, Jan 3, 3:46 PM
asomers requested review of D27939: fusefs: only check vnode locks with DEBUG_VFS_LOCKS.
Sun, Jan 3, 3:34 AM
asomers requested review of D27938: Fix vnode locking bug in fuse_vnop_copy_file_range.
Sun, Jan 3, 3:32 AM
asomers committed R10:1868a91fac5e: Regenerate syscall files after addition of aio_writev/aio_readv (authored by asomers).
Regenerate syscall files after addition of aio_writev/aio_readv
Sun, Jan 3, 3:00 AM
asomers closed D27743: Add aio_writev and aio_readv.
Sun, Jan 3, 2:59 AM
asomers committed R10:022ca2fc7fe0: Add aio_writev and aio_readv (authored by asomers).
Add aio_writev and aio_readv
Sun, Jan 3, 2:59 AM
asomers accepted D27935: add recommendation for using a large "len" argument.
Sun, Jan 3, 12:30 AM
asomers accepted D27937: fix the performance of cp(1) when copying large non-sparse files.
Sun, Jan 3, 12:02 AM

Sat, Jan 2

asomers requested changes to D27935: add recommendation for using a large "len" argument.
Sat, Jan 2, 11:18 PM
asomers requested review of D27936: Fix a vnode locking bug in fuse_vnop_advlock..
Sat, Jan 2, 11:13 PM
asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • Don't use union types in struct aiocb
  • Add notes about sys/uio.h to the man pages
Sat, Jan 2, 10:41 PM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Sat, Jan 2, 10:27 PM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Sat, Jan 2, 3:35 PM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Sat, Jan 2, 4:57 AM
asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • style fix
  • Restore C99 compliance to aio.h
Sat, Jan 2, 4:52 AM

Fri, Jan 1

asomers committed R10:b586c66baf48: ping: fix ping when the kernel was built without INET6 (authored by asomers).
ping: fix ping when the kernel was built without INET6
Fri, Jan 1, 5:28 PM
asomers committed R10:92bbfe1f0d1f: fusefs: implement FUSE_COPY_FILE_RANGE. (authored by asomers).
fusefs: implement FUSE_COPY_FILE_RANGE.
Fri, Jan 1, 5:20 PM
asomers committed R10:ae39db74066a: fusefs: fix an expectation in one of the tests (authored by asomers).
fusefs: fix an expectation in one of the tests
Fri, Jan 1, 5:20 PM
asomers closed D27818: fusefs: implement FUSE_COPY_FILE_RANGE..
Fri, Jan 1, 5:20 PM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Fri, Jan 1, 4:49 PM
asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • fix typo in comment
  • Fix an atomic access
  • Make the aio zvol tests parallelizable.
  • fixup to "Fix 32-bit build of one test"
  • style changes requested by jhb
Fri, Jan 1, 3:09 AM

Thu, Dec 31

asomers added a comment to D27818: fusefs: implement FUSE_COPY_FILE_RANGE..

I'm planning to commit this (with a couple of changes from your final comments) if it completes a make tinderbox.

Thu, Dec 31, 6:11 PM
asomers added inline comments to D27818: fusefs: implement FUSE_COPY_FILE_RANGE..
Thu, Dec 31, 6:07 PM
asomers abandoned D13179: Add "Pull Request" to the devel/subversion commit template.

Overcome by events. RIP SVN.

Thu, Dec 31, 4:01 PM
asomers closed D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.
Thu, Dec 31, 3:53 PM
asomers committed R10:37df9d3bba85: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK (authored by asomers).
fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK
Thu, Dec 31, 3:53 PM
asomers added a comment to D27842: VOP_PATHCONF.9: add a LOCKS section.

Fixed by https://cgit.freebsd.org/src/commit/?id=68de3bb59f64a37f3473517a56c2767e652c36b8

Thu, Dec 31, 3:42 PM
asomers closed D27842: VOP_PATHCONF.9: add a LOCKS section.
Thu, Dec 31, 3:41 PM
asomers committed R10:68de3bb59f64: VOP_PATHCONF.9: add a LOCKS section (authored by asomers).
VOP_PATHCONF.9: add a LOCKS section
Thu, Dec 31, 3:41 PM
asomers added a comment to D27842: VOP_PATHCONF.9: add a LOCKS section.
In D27842#622376, @jhb wrote:

I echo pretty much all that Benjamin said. It would be nice if there was some way to auto-generate VOP locking documentation requirements from vnode_if.src in some way.

Thu, Dec 31, 3:37 PM
asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • Add notes about EFAULT to the man pages
  • Fix 32-bit build of one test, and improve an error message
  • Make freebsd32_copyinuio a public function
  • Fix vectored aio in 32-bit emulation
Thu, Dec 31, 5:54 AM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Thu, Dec 31, 5:52 AM

Wed, Dec 30

asomers updated the diff for D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.
  • Respond to cem's comments, and fix a vnode locking inconsistency
Wed, Dec 30, 5:02 AM
asomers added inline comments to D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.
Wed, Dec 30, 5:02 AM
asomers requested review of D27842: VOP_PATHCONF.9: add a LOCKS section.
Wed, Dec 30, 5:01 AM
asomers committed R10:0efb22eebbbb: MFC r356352, r368272 (authored by asomers).
MFC r356352, r368272
Wed, Dec 30, 3:03 AM

Tue, Dec 29

asomers updated the diff for D27818: fusefs: implement FUSE_COPY_FILE_RANGE..
Add missing file
Tue, Dec 29, 8:18 PM
asomers requested review of D27818: fusefs: implement FUSE_COPY_FILE_RANGE..
Tue, Dec 29, 8:16 PM

Mon, Dec 28

asomers requested review of D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.
Mon, Dec 28, 11:37 PM
asomers closed D27770: fusefs: delete some dead code.
Mon, Dec 28, 7:06 PM
asomers committed R10:4f4111d2c5ab: fusefs: delete some dead code (authored by asomers).
fusefs: delete some dead code
Mon, Dec 28, 7:06 PM
asomers committed R10:f928dbcb167c: fusefs: fix the tests for a wider range of maxphys (authored by asomers).
fusefs: fix the tests for a wider range of maxphys
Mon, Dec 28, 6:58 PM
asomers closed D27769: fusefs: fix the tests for a wider range of maxphys.
Mon, Dec 28, 6:57 PM

Sun, Dec 27

asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • Completely cleanup bios after EFAULT
Sun, Dec 27, 2:24 AM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Sun, Dec 27, 2:21 AM

Sat, Dec 26

asomers updated the diff for D27769: fusefs: fix the tests for a wider range of maxphys.
  • Add comments
Sat, Dec 26, 11:30 PM
asomers added a comment to D27769: fusefs: fix the tests for a wider range of maxphys.

@cem thanks for reviewing D27770 during the holiday week. Could you also review this one too, please?

Sat, Dec 26, 5:34 PM

Thu, Dec 24

asomers updated the diff for D27770: fusefs: delete some dead code.

Remove files that shouldn't have been part of this review

Thu, Dec 24, 9:38 PM
asomers updated the diff for D27770: fusefs: delete some dead code.
  • Delete more dead code
Thu, Dec 24, 9:37 PM
asomers added inline comments to D27770: fusefs: delete some dead code.
Thu, Dec 24, 9:37 PM
asomers updated the diff for D27769: fusefs: fix the tests for a wider range of maxphys.
  • Delete debugging code
Thu, Dec 24, 8:28 PM
asomers requested review of D27770: fusefs: delete some dead code.
Thu, Dec 24, 8:26 PM
asomers requested review of D27769: fusefs: fix the tests for a wider range of maxphys.
Thu, Dec 24, 7:57 PM
asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • aio_qbio: fail vectored requests faster if they're going to be retried
  • aio: better handling for EFAULT during vectored operations
Thu, Dec 24, 2:59 AM

Dec 23 2020

asomers added inline comments to D27743: Add aio_writev and aio_readv.
Dec 23 2020, 8:24 PM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Dec 23 2020, 7:53 PM
asomers updated the diff for D27743: Add aio_writev and aio_readv.
  • fixup
Dec 23 2020, 7:53 PM
asomers added inline comments to D27743: Add aio_writev and aio_readv.
Dec 23 2020, 7:41 PM
asomers abandoned D27624: Add aio_writev and aio_readv.

Replaced by D27743

Dec 23 2020, 7:05 PM
asomers added a comment to D27743: Add aio_writev and aio_readv.

This is the same as D27624, but rebased onto git, and after D27682.

Dec 23 2020, 7:04 PM
asomers requested review of D27743: Add aio_writev and aio_readv.
Dec 23 2020, 6:59 PM
asomers closed D27682: AIO: remove the kaiocb->bio linkage.

Committed in https://cgit.freebsd.org/src/commit/?id=0120603891ec0d082c41e1f8d2b83e71429aea8c

Dec 23 2020, 4:09 PM

Dec 21 2020

asomers added inline comments to D27682: AIO: remove the kaiocb->bio linkage.
Dec 21 2020, 11:53 PM
asomers updated the diff for D27682: AIO: remove the kaiocb->bio linkage.

Don't override bp->bio_ma and bp->bio_ma_n

Dec 21 2020, 8:48 PM
asomers added inline comments to D27682: AIO: remove the kaiocb->bio linkage.
Dec 21 2020, 5:26 PM

Dec 19 2020

asomers requested review of D27682: AIO: remove the kaiocb->bio linkage.
Dec 19 2020, 5:21 PM