Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (244 w, 4 d)

Recent Activity

Sat, Jan 12

asomers added a comment to D18622: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.

FWIW our tree already has some tests that require C++-11. See lib/libc/tests/stdlib/Makefile. So importing an old version of googletest may not be worthwhile if it means forfeiting important features. Also, you may not have noticed, but there's already one googletest program in base, in cddl/usr.sbin/zfsd/tests. It's been there for years, but never hooked up to the build.

Sat, Jan 12, 4:44 PM
asomers accepted D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Sat, Jan 12, 4:28 PM

Mon, Jan 7

asomers added inline comments to D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Mon, Jan 7, 5:44 PM

Mon, Dec 31

asomers committed rP488840: shells/fish: upgrade to 3.0.0.
shells/fish: upgrade to 3.0.0
Mon, Dec 31, 9:39 PM
asomers added inline comments to D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Mon, Dec 31, 4:48 PM

Thu, Dec 27

asomers requested changes to D18625: Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfile.
Thu, Dec 27, 11:01 PM

Mon, Dec 17

asomers added inline comments to D18585: Eliminate sleeps in the geom ATF tests.
Mon, Dec 17, 10:40 PM
asomers added inline comments to D18585: Eliminate sleeps in the geom ATF tests.
Mon, Dec 17, 9:20 PM

Dec 17 2018

asomers committed rS342173: Conditionalize installtion audit(4) tests on MK_AUDIT.
Conditionalize installtion audit(4) tests on MK_AUDIT
Dec 17 2018, 6:35 PM
asomers committed rS342172: audit(4) tests: require /etc/rc.d/auditd.
audit(4) tests: require /etc/rc.d/auditd
Dec 17 2018, 6:11 PM
asomers abandoned D18583: Eliminate sleeps in the geom ATF tests.

Sorry for the duplicate revision. I'm having curl problems.

Dec 17 2018, 4:53 PM · tests
asomers created D18585: Eliminate sleeps in the geom ATF tests.
Dec 17 2018, 4:51 PM
asomers created D18583: Eliminate sleeps in the geom ATF tests.
Dec 17 2018, 4:42 PM · tests

Dec 16 2018

asomers committed rS342154: OptionalObsoleteFiles: Fix deleting usr/tests/usr.sbin/sa.
OptionalObsoleteFiles: Fix deleting usr/tests/usr.sbin/sa
Dec 16 2018, 11:45 PM
asomers committed rS342153: Conditionally install /etc/rc.d/audit* based on ${MK_AUDIT}.
Conditionally install /etc/rc.d/audit* based on ${MK_AUDIT}
Dec 16 2018, 11:39 PM
asomers added a comment to D18578: OpenRC for FreeBSD.

This review is enormous. Might I suggest that you cancel it, and then create two smaller reviews? The first would cover adding openrc to contrib, and the second would cover everything else.

Dec 16 2018, 3:03 PM

Dec 9 2018

asomers added a comment to D18490: netmap: add suite of unit tests.

I haven't read all 1710 lines of netmap code, but here are a few basic ATF questions. The test looks like it requires root. If so, the Makefile should have TEST_METADATA+=required_user="root". Secondly, would anything bad happen if two of these processes were running simultaneously? If so, then the Makefile should have TEST_METADATA+=is_exclusive=true.

Dec 9 2018, 4:49 PM

Dec 7 2018

asomers committed rS341667: geom tests: Fix cleanup of ATF tests since r341392.
geom tests: Fix cleanup of ATF tests since r341392
Dec 7 2018, 12:27 AM

Dec 6 2018

asomers added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Dec 6 2018, 10:08 PM
asomers added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Dec 6 2018, 9:28 PM
asomers accepted D18334: syslog(3): stdarg.h is needed only for vsyslog().

LGTM. Do you you need someone to commit this for you?

Dec 6 2018, 4:51 PM
asomers committed rS341613: MFC r340525:.
MFC r340525:
Dec 6 2018, 2:38 AM
asomers committed rS341612: MFC r340455:.
MFC r340455:
Dec 6 2018, 2:37 AM
asomers added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Dec 6 2018, 2:25 AM

Dec 5 2018

asomers closed D18410: stat(2): expand list of syscalls that modify st_mtim.
Dec 5 2018, 5:30 PM
asomers committed rS341598: stat(2): clarify which syscalls modify file timestamps.
stat(2): clarify which syscalls modify file timestamps
Dec 5 2018, 5:30 PM
asomers updated the diff for D18410: stat(2): expand list of syscalls that modify st_mtim.

Clarify why write(2) updates st_ctim

Dec 5 2018, 4:27 PM
asomers added inline comments to D17376: IPv6 Fragmentation Regression Tests from OpenBSD.
Dec 5 2018, 4:24 PM

Dec 3 2018

asomers updated the diff for D18410: stat(2): expand list of syscalls that modify st_mtim.

Use kib's preferred wording for directory-updating syscalls.

Dec 3 2018, 4:42 PM
asomers added inline comments to D18410: stat(2): expand list of syscalls that modify st_mtim.
Dec 3 2018, 4:35 PM
asomers added a comment to D18410: stat(2): expand list of syscalls that modify st_mtim.

Also, for ordinary file accesses, the page fails to mention modifications of the writeable memory mappings of the files.

Dec 3 2018, 4:06 PM
asomers updated the diff for D18410: stat(2): expand list of syscalls that modify st_mtim.

Leave syscall list open-ended.

Dec 3 2018, 4:06 PM
asomers updated the diff for D18410: stat(2): expand list of syscalls that modify st_mtim.

Also note that mknod does not update atime

Dec 3 2018, 2:25 PM
asomers added a comment to D18410: stat(2): expand list of syscalls that modify st_mtim.
In D18410#391986, @kib wrote:

I do not understand this change. Are you claiming that link(2) modifies mtim ? If yes, for which vnode ?

Dec 3 2018, 2:25 PM

Dec 2 2018

asomers created D18410: stat(2): expand list of syscalls that modify st_mtim.
Dec 2 2018, 11:35 PM
asomers committed rS341392: Unbreak geli/gmirror testcases if their geom classes cannot be loaded.
Unbreak geli/gmirror testcases if their geom classes cannot be loaded
Dec 2 2018, 5:08 AM
asomers committed rS341390: Remove some dead code from the geli tests.
Remove some dead code from the geli tests
Dec 2 2018, 12:42 AM

Nov 26 2018

asomers committed rS340988: vfs_aio.c: rename "physio" symbols to "bio"..
vfs_aio.c: rename "physio" symbols to "bio".
Nov 26 2018, 6:32 PM

Nov 18 2018

asomers committed rP485231: MFH r484879.
MFH r484879
Nov 18 2018, 4:06 PM

Nov 17 2018

asomers committed rS340525: mount_fusefs.8: expand HISTORY section.
mount_fusefs.8: expand HISTORY section
Nov 17 2018, 9:35 PM

Nov 15 2018

asomers committed rS340462: MFC r340314:.
MFC r340314:
Nov 15 2018, 7:06 PM
asomers committed rS340455: fcntl.2: document an additional error condition.
fcntl.2: document an additional error condition
Nov 15 2018, 4:13 PM

Nov 13 2018

asomers committed rP484879: devel/p4: fix build with OpenSSL 1.1.
devel/p4: fix build with OpenSSL 1.1
Nov 13 2018, 5:15 PM
asomers committed rP484878: emulators/qemu-utils: fix build after r484653.
emulators/qemu-utils: fix build after r484653
Nov 13 2018, 4:28 PM

Nov 12 2018

asomers added a comment to D14567: Introduce fdunlinkat..

@cem, @kib, @emaste, @jilles I would like to commit it as-it-is but pjd suggested to change the name to funlinkat? After some thoughts I also think that funlinkat is a bether name 'fd' suggests that it's working on 'FILE *'. Do you agree?

Nov 12 2018, 6:16 PM

Nov 10 2018

asomers committed rS340314: libjail: fix handling of allow.mount.fusefs in jailparam_init.
libjail: fix handling of allow.mount.fusefs in jailparam_init
Nov 10 2018, 3:10 AM
asomers closed D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.
Nov 10 2018, 3:10 AM
asomers updated the diff for D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.

Handle allow.mount.nofusefs too

Nov 10 2018, 2:38 AM
asomers added a comment to D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.

Of course, stupid me. But I'm having trouble testing it. What's the proper way to pass the "nofuse" option on the jail(8) command line? Neither allow.mount.nofusefs nor allow.mount.nofusefs=1 work.

Nov 10 2018, 1:17 AM

Nov 9 2018

asomers created D17929: libjail: fix handling of allow.mount.fusefs in jailparam_init.
Nov 9 2018, 7:01 PM

Oct 2 2018

asomers committed rS339095: MFC r336875:.
MFC r336875:
Oct 2 2018, 6:12 PM
asomers committed rS339094: MFC r336728:.
MFC r336728:
Oct 2 2018, 5:57 PM
asomers committed rS339093: MFC r336613:.
MFC r336613:
Oct 2 2018, 5:43 PM
asomers committed rS339092: MFC r335792, r336564, r336579.
MFC r335792, r336564, r336579
Oct 2 2018, 5:39 PM
asomers committed rS339090: MFC r335319, r335354, r335374.
MFC r335319, r335354, r335374
Oct 2 2018, 5:27 PM
asomers committed rS339089: MFC r335261, r335275, r335284-r335285, r335294, r335318, r335320, r335703.
MFC r335261, r335275, r335284-r335285, r335294, r335318, r335320, r335703
Oct 2 2018, 5:07 PM
asomers committed rS339087: MFC many audit(4) tests..
MFC many audit(4) tests.
Oct 2 2018, 4:23 PM
asomers committed rS339084: MFC r334360, r334362, r334388, r334395.
MFC r334360, r334362, r334388, r334395
Oct 2 2018, 3:19 PM

Oct 1 2018

asomers committed rS339068: MFC r337222:.
MFC r337222:
Oct 1 2018, 6:01 PM
asomers committed rS339067: MFC r337222:.
MFC r337222:
Oct 1 2018, 5:37 PM
asomers requested changes to D17376: IPv6 Fragmentation Regression Tests from OpenBSD.

Wow, nice contribution! But a few things need to be fixed:

  1. When we import foreign code, if there's any possibility at all that we might sync it again in the future, then we import it to the vendor directory before merging it to the contrib directory. See contrib/netbsd-tests for an example.
  2. Other concerns inline.
  3. I haven't fully reviewed the Python code. I'll do that after you fix the sh and make problems.
  4. Any files that come from OpenBSD should be committed verbatim to the vendor directory, then copied to the contrib directory. Then they can be modified in contrib.
Oct 1 2018, 5:09 PM
asomers committed rS339065: MFC r336871, r336874.
MFC r336871, r336874
Oct 1 2018, 4:23 PM
asomers committed rS339063: MFC r337973:.
MFC r337973:
Oct 1 2018, 4:15 PM
asomers committed rS339062: MFC r338216:.
MFC r338216:
Oct 1 2018, 4:11 PM
asomers committed rS339061: MFC r337779:.
MFC r337779:
Oct 1 2018, 4:10 PM
asomers committed rS339060: MFC r336609:.
MFC r336609:
Oct 1 2018, 4:09 PM
asomers committed rS339059: MFC r336605:.
MFC r336605:
Oct 1 2018, 4:08 PM
asomers committed rS339058: MFC r336587:.
MFC r336587:
Oct 1 2018, 4:07 PM
asomers committed rS339057: MFC r338216:.
MFC r338216:
Oct 1 2018, 4:04 PM
asomers committed rS339056: MFC r337973:.
MFC r337973:
Oct 1 2018, 4:01 PM
asomers committed rS339055: MFC r337911:.
MFC r337911:
Oct 1 2018, 3:59 PM
asomers committed rS339054: MFC r337779:.
MFC r337779:
Oct 1 2018, 3:58 PM
asomers committed rS339053: MFC r337482:.
MFC r337482:
Oct 1 2018, 3:56 PM
asomers committed rS339052: MFC r336871, r336874.
MFC r336871, r336874
Oct 1 2018, 3:50 PM
asomers committed rS339051: MFC r336605:.
MFC r336605:
Oct 1 2018, 3:47 PM
asomers committed rS339050: MFC r336594:.
MFC r336594:
Oct 1 2018, 3:45 PM
asomers committed rS339049: MFC r336587:.
MFC r336587:
Oct 1 2018, 3:44 PM
asomers committed rS339048: MFC r336582:.
MFC r336582:
Oct 1 2018, 3:40 PM

Sep 30 2018

asomers added inline comments to D17348: Allow DTrace audit provider probes to fire even if auditd(8) isn't running..
Sep 30 2018, 12:01 AM

Sep 17 2018

asomers accepted D17202: Fix the nvpair leak in vdev_geom_read_config()..

Oops, looks like this one's my fault. Thanks for fixing it, Mark!

Sep 17 2018, 3:55 PM

Sep 11 2018

asomers accepted D17110: Add simple tests for SO_REUSEPORT_LB sockets..

Do the tests still pass for you? After your latest change, I get the "connection wasn't accepted" error every time.

Yes, I just noticed that. (I rebuilt and ran the tests on two different machines by accident.) It seems like the polling loop is needed after all, which is somewhat surprising to me given that we're using a blocking connect().

I guess this is expected behaviour for TCP. connect(2) returns once the SYN|ACK reply is received, but the child socket isn't complete until the final ACK is received, so there's a window that we have to account for.

Sep 11 2018, 4:16 PM
asomers added a comment to D17110: Add simple tests for SO_REUSEPORT_LB sockets..

Do the tests still pass for you? After your latest change, I get the "connection wasn't accepted" error every time.

Sep 11 2018, 3:20 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 3:16 PM
asomers added inline comments to D17110: Add simple tests for SO_REUSEPORT_LB sockets..
Sep 11 2018, 2:49 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 2:42 PM
asomers added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 3:13 AM
asomers added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

  1. The Wayback machine shows me that IANA sometimes removes a port assignment. Sadly, I haven't been able to find any official historical information. What will FreeBSD's policy regarding removing assignments be?

I doubt there has ever been such a policy. By default, we will remove it on the next update. I think this de facto policy will be sufficient. Administrators who need to keep the assignment can simply add it to this file on their systems.

Sep 11 2018, 3:10 AM
asomers accepted D17110: Add simple tests for SO_REUSEPORT_LB sockets..

All good here.

Sep 11 2018, 3:07 AM

Sep 10 2018

asomers added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

Sep 10 2018, 11:22 PM
asomers added a comment to D17110: Add simple tests for SO_REUSEPORT_LB sockets..

In fact, you don't even need the second process for this test. It's possible to do this entirely with one single-threaded process. See the "accept_success" test in tests/sys/audit/network.c for an example. Basically it goes like this:

for (i=0; i<sdcnt; i++)
    listen(server_fd[i]);
while (true) {
    client_fd = socket();
    client_fd.connect(server_addr);  //blocking, but returns immediately
    for ((i=0; i<sdcnt; i++) {
        if (accept(server_fd[i]) == 0) {    // non-blocking
            acceptcnt[i]++;
            break;
        }
    }
}

What do you think of the single-threaded approach?

Sep 10 2018, 7:26 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 6:45 PM
asomers added inline comments to D17110: Add simple tests for SO_REUSEPORT_LB sockets..
Sep 10 2018, 6:42 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 6:20 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 5:41 PM
asomers added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 5:28 PM
asomers accepted D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 2:40 PM
asomers added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 2:27 PM
asomers added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 1:55 PM
asomers accepted D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 1:13 AM

Aug 30 2018

asomers committed rS336914: Make timespecadd(3) and friends public.
Make timespecadd(3) and friends public
Aug 30 2018, 2:56 AM