asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (206 w, 4 d)

Recent Activity

Sat, Apr 21

asomers committed rD51580: Update my PGP key with its new expiration date..
Update my PGP key with its new expiration date.
Sat, Apr 21, 1:48 PM

Mon, Apr 16

asomers committed rS332631: lio_listio: return EAGAIN instead of EIO when out of resources.
lio_listio: return EAGAIN instead of EIO when out of resources
Mon, Apr 16, 6:12 PM
asomers closed D15099: aio: return EAGAIN instead of EIO when out of resources.
Mon, Apr 16, 6:12 PM
asomers committed rS332610: MFC r329606:.
MFC r329606:
Mon, Apr 16, 4:42 PM
asomers committed rS332609: MFC r330710, r330718-r330720.
MFC r330710, r330718-r330720
Mon, Apr 16, 4:33 PM
asomers committed rS332608: MFC r330696, r330709, r330742, r331358.
MFC r330696, r330709, r330742, r331358
Mon, Apr 16, 4:32 PM
asomers committed rS332607: MFC r330627:.
MFC r330627:
Mon, Apr 16, 4:30 PM
asomers committed rS332606: MFC r330515:.
MFC r330515:
Mon, Apr 16, 4:28 PM
asomers committed rS332605: MFC r330514:.
MFC r330514:
Mon, Apr 16, 4:27 PM
asomers committed rS332604: MFC r329874:.
MFC r329874:
Mon, Apr 16, 4:26 PM
asomers committed rS332603: MFC r329845, r329872.
MFC r329845, r329872
Mon, Apr 16, 4:25 PM
asomers committed rS332602: MFC r329754:.
MFC r329754:
Mon, Apr 16, 4:23 PM
asomers committed rS332600: MFC r329606:.
MFC r329606:
Mon, Apr 16, 4:20 PM
asomers created D15099: aio: return EAGAIN instead of EIO when out of resources.
Mon, Apr 16, 4:04 PM
asomers added a comment to D14725: Make timespecadd(3) and friends public.

So it sounds like this is not a good candidate for _GENERIC. Shall I commit it as-is then? I've already updated all clients of the 2-argument versions to use the 3-argument versions.

Mon, Apr 16, 3:07 PM
asomers added a comment to D14403: Fix mpr device mapper fallback logic for busses with multiple expanders..

I no longer have access to any hardware that can exercise this change. @slm do you want to commandeer the revision? Otherwise I'll abandon it.

Mon, Apr 16, 3:03 PM

Mar 22 2018

asomers committed rS331358: tftpd: misc Coverity cleanup in the tests.
tftpd: misc Coverity cleanup in the tests
Mar 22 2018, 2:51 PM

Mar 19 2018

asomers accepted D14742: Revert r318180 and re-enable AIO tests on md(4) by default. The 'physio' fast-path used by AIO requests on md(4) devices, is not gated on the unsafe_aio knob. Prior to r327755, some AIO requests could fail the fast-path and fall back to the slow....
Mar 19 2018, 6:08 PM

Mar 18 2018

asomers added a comment to D14725: Make timespecadd(3) and friends public.

I think this kind of compatibility should be provided only if necessary for old code that cannot be changed (such as third party code). If it is just to avoid churn, we should keep using the old timespecadd and timespecsub (that is, abandon this change).

Completely agree.

Mar 18 2018, 6:18 PM

Mar 17 2018

asomers created D14725: Make timespecadd(3) and friends public.
Mar 17 2018, 11:20 PM
asomers committed rS331105: audit(4): fix a typo in a comment.
audit(4): fix a typo in a comment
Mar 17 2018, 5:56 PM
asomers committed rS331104: aio_kqueue_test: fix the build when DEBUG=1.
aio_kqueue_test: fix the build when DEBUG=1
Mar 17 2018, 5:53 PM
asomers committed rS331103: aio: add an ATF test case for aio_fsync error conditions.
aio: add an ATF test case for aio_fsync error conditions
Mar 17 2018, 5:48 PM

Mar 14 2018

asomers added a comment to D14559: Add test for regression fixed in r329743.

Why don't you just combine this review with that one? It would be easier to review that way.

Mar 14 2018, 8:17 PM
asomers added a comment to D14559: Add test for regression fixed in r329743.

Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.

Mar 14 2018, 7:32 PM

Mar 10 2018

asomers committed rS330742: tftpd: fix the build of tests on i386 after 330696.
tftpd: fix the build of tests on i386 after 330696
Mar 10 2018, 6:07 PM
asomers committed rS330737: MFC r323314, r323338, r328849.
MFC r323314, r323338, r328849
Mar 10 2018, 4:17 AM
asomers committed rS330736: MFC r329265, r329384.
MFC r329265, r329384
Mar 10 2018, 4:11 AM
asomers committed rS330735: MFC r329067:.
MFC r329067:
Mar 10 2018, 4:03 AM
asomers committed rS330734: MFC r329412:.
MFC r329412:
Mar 10 2018, 3:40 AM
asomers committed rS330733: MFC r329273, r329275, r329277, r329284, r329344.
MFC r329273, r329275, r329277, r329284, r329344
Mar 10 2018, 3:34 AM
asomers committed rS330732: MFC r329265, r329384.
MFC r329265, r329384
Mar 10 2018, 3:25 AM
asomers committed rS330731: MFC r328896, r329236.
MFC r328896, r329236
Mar 10 2018, 3:16 AM
asomers committed rS330730: MFC r329174:.
MFC r329174:
Mar 10 2018, 3:08 AM
asomers committed rS330729: MFC r329108:.
MFC r329108:
Mar 10 2018, 3:07 AM
asomers committed rS330728: MFC r329067:.
MFC r329067:
Mar 10 2018, 3:04 AM
asomers committed rS330726: MFC r323314, r323338, r328849.
MFC r323314, r323338, r328849
Mar 10 2018, 2:16 AM
asomers committed rS330720: tftpd: reject unknown opcodes.
tftpd: reject unknown opcodes
Mar 10 2018, 1:51 AM
asomers committed rS330719: tftpd: Abort on an WRQ access violation.
tftpd: Abort on an WRQ access violation
Mar 10 2018, 1:44 AM
asomers committed rS330718: tftpd: Verify world-writability for WRQ when using relative paths.
tftpd: Verify world-writability for WRQ when using relative paths
Mar 10 2018, 1:35 AM

Mar 9 2018

asomers committed rS330710: tftpd: Flush files as soon as they are fully received.
tftpd: Flush files as soon as they are fully received
Mar 9 2018, 11:25 PM
asomers committed rS330709: Commit missing file from r330696.
Commit missing file from r330696
Mar 9 2018, 11:17 PM
asomers committed rS330696: Add some functional tests for tftpd(8).
Add some functional tests for tftpd(8)
Mar 9 2018, 3:30 PM
asomers closed D14310: Add some functional tests for tftpd(8).
Mar 9 2018, 3:30 PM

Mar 8 2018

asomers committed rS330627: g_bio(9): fix a documentation oversight from r163870.
g_bio(9): fix a documentation oversight from r163870
Mar 8 2018, 3:19 AM

Mar 7 2018

asomers added a comment to D6682: Fix some sanity checks so they honor CLEAN_FETCH_ENV.

@mat do you approve this revision. I'll be forced to abandon it in two days if I don't get approval.

Mar 7 2018, 4:47 PM

Mar 6 2018

asomers committed rP463769: devel/py-p4python: build with SSL support.
devel/py-p4python: build with SSL support
Mar 6 2018, 9:59 PM
asomers added a comment to D14310: Add some functional tests for tftpd(8).

Are you satisfied, @cem ?

Mar 6 2018, 4:15 AM

Mar 5 2018

asomers committed rS330524: MFC r324940:.
MFC r324940:
Mar 5 2018, 8:43 PM
asomers committed rS330523: MFC r326400.
MFC r326400
Mar 5 2018, 8:38 PM
asomers committed rS330522: MFC r326401:.
MFC r326401:
Mar 5 2018, 8:29 PM
asomers committed rS330520: MFC r320726, r320727.
MFC r320726, r320727
Mar 5 2018, 7:02 PM
asomers committed rS330519: MFC r320726, r320727.
MFC r320726, r320727
Mar 5 2018, 6:37 PM
asomers committed rP463653: devel/p4: build with SSL support.
devel/p4: build with SSL support
Mar 5 2018, 5:08 PM
asomers committed rS330515: spray: fix the spelling in an output string.
spray: fix the spelling in an output string
Mar 5 2018, 4:13 PM
asomers committed rS330514: rpc.sprayd: raise WARNS to 6.
rpc.sprayd: raise WARNS to 6
Mar 5 2018, 4:11 PM
asomers added a comment to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.
In D13088#306143, @avg wrote:

Alan, by the way, do you plan to open an upstream issue and a PR to upstream this change?

Mar 5 2018, 3:16 PM
asomers added a comment to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

I can do it. I don't have the ability to run a full regression test on it. But this change is small enough that I think the risk is minimal.

I get a panic on boot after this commit.

panic: solaris assert: refcount_count(&spa->spa_refcount) > spa->spa_minref || MUTEX_HELD(&spa_namespace_lock), file: /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c, line: 952
cpuid = 10
time = 1520207367
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe23f57a2420
vpanic() at vpanic+0x18d/frame 0xfffffe23f57a2480
panic() at panic+0x43/frame 0xfffffe23f57a24e0
assfail() at assfail+0x1a/frame 0xfffffe23f57a24f0
spa_close() at spa_close+0x5d/frame 0xfffffe23f57a2520
spa_get_stats() at spa_get_stats+0x481/frame 0xfffffe23f57a2700
zfs_ioc_pool_stats() at zfs_ioc_pool_stats+0x25/frame 0xfffffe23f57a2740
zfsdev_ioctl() at zfsdev_ioctl+0x76b/frame 0xfffffe23f57a27e0
devfs_ioctl() at devfs_ioctl+0xcb/frame 0xfffffe23f57a2830
VOP_IOCTL_APV() at VOP_IOCTL_APV+0x102/frame 0xfffffe23f57a2860
vn_ioctl() at vn_ioctl+0x124/frame 0xfffffe23f57a2970
devfs_ioctl_f() at devfs_ioctl_f+0x1f/frame 0xfffffe23f57a2990
kern_ioctl() at kern_ioctl+0x2c2/frame 0xfffffe23f57a29f0
sys_ioctl() at sys_ioctl+0x15c/frame 0xfffffe23f57a2ac0
amd64_syscall() at amd64_syscall+0x786/frame 0xfffffe23f57a2bf0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe23f57a2bf0
--- syscall (54, FreeBSD ELF64, sys_ioctl), rip = 0x80049afda, rsp = 0x7fffffffbd18, rbp = 0x7fffffffbd90 ---
KDB: enter: panic
[ thread pid 56 tid 100606 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db>

Not sure if related but I only updated like 1-2 days ago and then today and hit this, nothing else seems to have touched ZFS code.

Mar 5 2018, 12:04 AM

Mar 2 2018

asomers committed rS330295: ZFS: fix adding vdevs to very large pools.
ZFS: fix adding vdevs to very large pools
Mar 2 2018, 9:27 PM
asomers closed D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.
Mar 2 2018, 9:27 PM
asomers added a comment to D14567: Introduce unlinkfd..

Needs a man page. Also, how is path interpreted? Is it the usual absolute or relative to PWD? To work with cloudabi, you may need another argument, ala unlinkfdat(int fd_for_path, const char *path, int fd_to_remove, int flag)

Mar 2 2018, 6:47 PM
asomers commandeered D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

I can do it. I don't have the ability to run a full regression test on it. But this change is small enough that I think the risk is minimal.

Mar 2 2018, 4:48 PM
asomers requested changes to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

I agree with @avg. Better to set ENOENT in this case. If the function is going to set errnos sometimes, then it should set them on every abnormal return.

Mar 2 2018, 3:20 PM

Mar 1 2018

asomers requested changes to D14559: Add test for regression fixed in r329743.

Most of the other tests in this file relate specifically to multifib functionality. I think your test should go into a new file. You can pull the helper routines out into a .subr file.

Mar 1 2018, 10:01 PM
asomers added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

The fibs must actually exist. Set net.fibs=6 in /boot/loader.conf and reboot. Also, are you sure you need so many? I don't think there are any tests there that require more than two.

I have done that. The problem is in kyua somewhere:

:
# sysctl net.fibs
net.fibs: 6
# kyua -c /usr/local/etc/kyua/kyua.conf test
fibs_test:arpresolve_checks_interface_fib -> skipped: Required configuration property 'fibs' not defined [0.002s]
fibs_test:default_route_with_multiple_fibs_on_same_subnet -> skipped: Required configuration property 'fibs' not defined [0.002s]
(and so on)
# cat /usr/local/etc/kyua/kyua.conf
-- $FreeBSD: head/devel/kyua/files/kyua.conf.in 364865 2014-08-14 20:21:56Z jmmv $
--
-- System-wide configuration file for kyua(1). See kyua.conf(5) for details
-- on the syntax.
--

syntax(2)


-- User to drop privileges to when invoking kyua(1) as root and a test case
-- requests to be run with non-root permissions.
unprivileged_user = 'tests'

-- An example to set a configuration property specific to FreeBSD.
--test_suites.FreeBSD.fstype = 'ffs'

test_suites.fibs_test.fibs = '1 2 3 4 5'

Mar 1 2018, 7:26 PM
asomers added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.

How do I run the tests? Setting this in /usr/local/etc/kyua/kyua.conf doesn't seem to work:

test_suites.fibs_test.fibs = '1 2 3 4 5'

Mar 1 2018, 6:53 PM
asomers added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.

Mar 1 2018, 3:14 PM

Feb 27 2018

asomers committed rS330076: fix typo in ipfw(8). No functional change..
fix typo in ipfw(8). No functional change.
Feb 27 2018, 5:12 PM

Feb 26 2018

asomers accepted D14527: dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain old IP.
Feb 26 2018, 8:51 PM

Feb 25 2018

asomers committed rS329984: Don't declare __assfail as static.
Don't declare __assfail as static
Feb 25 2018, 2:30 PM
asomers updated the diff for D14310: Add some functional tests for tftpd(8).

Fix the build with GCC6

Feb 25 2018, 5:08 AM

Feb 24 2018

asomers committed rS329910: Implement CTASSERT using _Static_assert.
Implement CTASSERT using _Static_assert
Feb 24 2018, 4:01 PM
asomers committed rS329909: tests: require ksh93 in the Kyuafiles for all atf-ksh93 test programs.
tests: require ksh93 in the Kyuafiles for all atf-ksh93 test programs
Feb 24 2018, 3:13 PM

Feb 23 2018

asomers added a comment to D14463: libifconfig: multiple feature additions.

For the record, this PR is based on the content at https://github.com/Savagedlight/libifconfig/pull/46 . IMHO, all new libifconfig development should continue in SVN in the FreeBSD tree.

Feb 23 2018, 8:53 PM
asomers committed rS329874: Add tests for lagg(4) and other cloned network interfaces.
Add tests for lagg(4) and other cloned network interfaces
Feb 23 2018, 6:19 PM
asomers committed rS329872: Delete copypasta.
Delete copypasta
Feb 23 2018, 5:21 PM
asomers committed rS329868: Drop privileges taken in r329865.
Drop privileges taken in r329865
Feb 23 2018, 4:37 PM
asomers committed rS329867: Add the ZFS test suite.
Add the ZFS test suite
Feb 23 2018, 4:32 PM
asomers committed rS329865: Add myself to sizelimits, for the ZFS test suite import.
Add myself to sizelimits, for the ZFS test suite import
Feb 23 2018, 4:05 PM
asomers committed rS329853: libifconfig: multiple feature additions.
libifconfig: multiple feature additions
Feb 23 2018, 3:12 AM
asomers closed D14463: libifconfig: multiple feature additions.
Feb 23 2018, 3:11 AM
asomers closed D11013: Fix numerous Coverity issues in mptutil.
Feb 23 2018, 12:18 AM
asomers committed rS329845: Fix numerous Coverity issues in mptutil.
Fix numerous Coverity issues in mptutil
Feb 23 2018, 12:18 AM

Feb 22 2018

asomers committed rS329840: apply PEP8 style to a python helper script.
apply PEP8 style to a python helper script
Feb 22 2018, 10:24 PM
asomers committed rS329839: Fix an mtree error from r329291.
Fix an mtree error from r329291
Feb 22 2018, 9:42 PM
asomers committed rS329830: nvmecontrol: fix build on amd64/clang.
nvmecontrol: fix build on amd64/clang
Feb 22 2018, 5:47 PM
asomers committed rS329828: Fix and reenable clone_001_pos.
Fix and reenable clone_001_pos
Feb 22 2018, 5:00 PM
asomers committed rS329792: MFC r328605:.
MFC r328605:
Feb 22 2018, 2:17 AM
asomers committed rS329791: MFC r328296:.
MFC r328296:
Feb 22 2018, 2:15 AM
asomers committed rS329790: MFC r328266:.
MFC r328266:
Feb 22 2018, 2:15 AM
asomers committed rS329789: MFC r328108:.
MFC r328108:
Feb 22 2018, 2:13 AM
asomers committed rS329780: MFC r326399:.
MFC r326399:
Feb 22 2018, 1:25 AM

Feb 21 2018

asomers added a reviewer for D14032: time(1): add an option to use the monotonic clock: imp.
Feb 21 2018, 11:18 PM
asomers updated the diff for D14032: time(1): add an option to use the monotonic clock.

Remove the -m option and use the monontonic clock unconditionaly

Feb 21 2018, 11:18 PM
asomers added a comment to D11013: Fix numerous Coverity issues in mptutil.

@scottl @imp can either of you test this change? If not, I'll abandon it.

Feb 21 2018, 9:23 PM
asomers abandoned D4806: Refactor ada and da quirks to support larger physical sector sizes.

@imp doesn't like this revision, and I feel like his suggested changes would more or less nullify the whole thing. Plus, there are very few drives that actually have a physical sector size other than 512B or 4096B, and we never found any drives that require the lalba field. So I'm abandoning the revision.

Feb 21 2018, 9:20 PM
asomers abandoned D7207: Use BIO_VLISTS to aggregate ZFS I/O.

This revision requires substantial rework as a result of r320156 (MFV r318946: 8021 ARC buf data scatter-ization). I don't have the time to do it, so I'm going to abandon the review.

Feb 21 2018, 9:17 PM
asomers committed rS329754: dhclient: raise WARNS to 4.
dhclient: raise WARNS to 4
Feb 21 2018, 9:13 PM
asomers closed D14460: dhclient: raise WARNS to 4.
Feb 21 2018, 9:13 PM
asomers added inline comments to D14460: dhclient: raise WARNS to 4.
Feb 21 2018, 9:09 PM