- User Since
- May 9 2014, 11:04 PM (206 w, 4 d)
Sat, Apr 21
Mon, Apr 16
So it sounds like this is not a good candidate for _GENERIC. Shall I commit it as-is then? I've already updated all clients of the 2-argument versions to use the 3-argument versions.
I no longer have access to any hardware that can exercise this change. @slm do you want to commandeer the revision? Otherwise I'll abandon it.
Mar 22 2018
Mar 19 2018
Mar 18 2018
Mar 17 2018
Mar 14 2018
Why don't you just combine this review with that one? It would be easier to review that way.
Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.
Mar 10 2018
Mar 9 2018
Mar 8 2018
Mar 7 2018
@mat do you approve this revision. I'll be forced to abandon it in two days if I don't get approval.
Mar 6 2018
Are you satisfied, @cem ?
Mar 5 2018
Mar 2 2018
Needs a man page. Also, how is path interpreted? Is it the usual absolute or relative to PWD? To work with cloudabi, you may need another argument, ala unlinkfdat(int fd_for_path, const char *path, int fd_to_remove, int flag)
I can do it. I don't have the ability to run a full regression test on it. But this change is small enough that I think the risk is minimal.
I agree with @avg. Better to set ENOENT in this case. If the function is going to set errnos sometimes, then it should set them on every abnormal return.
Mar 1 2018
Most of the other tests in this file relate specifically to multifib functionality. I think your test should go into a new file. You can pull the helper routines out into a .subr file.
In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.
Feb 27 2018
Feb 26 2018
Feb 25 2018
Fix the build with GCC6
Feb 24 2018
Feb 23 2018
For the record, this PR is based on the content at https://github.com/Savagedlight/libifconfig/pull/46 . IMHO, all new libifconfig development should continue in SVN in the FreeBSD tree.
Feb 22 2018
Feb 21 2018
Remove the -m option and use the monontonic clock unconditionaly
@imp doesn't like this revision, and I feel like his suggested changes would more or less nullify the whole thing. Plus, there are very few drives that actually have a physical sector size other than 512B or 4096B, and we never found any drives that require the lalba field. So I'm abandoning the revision.
This revision requires substantial rework as a result of r320156 (MFV r318946: 8021 ARC buf data scatter-ization). I don't have the time to do it, so I'm going to abandon the review.