Page MenuHomeFreeBSD

asomers (Alan Somers)
User

Projects

User Details

User Since
May 9 2014, 11:04 PM (446 w, 4 d)

Recent Activity

Today

asomers requested review of D37575: [skip ci] document first appearance of fhlink et al.
Wed, Nov 30, 5:26 PM
asomers added inline comments to D37210: Add test cases for ping with IP options in the response.
Wed, Nov 30, 4:35 PM
asomers added inline comments to D37210: Add test cases for ping with IP options in the response.
Wed, Nov 30, 4:25 PM
asomers updated the diff for D37210: Add test cases for ping with IP options in the response.
  • Add missing file
  • Match ping's stdout in the injection tests.
  • Python style
  • More specific output checking for inject_pip
  • fixup:
Wed, Nov 30, 4:24 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

One problem I noticed is that the tests can spuriously fail with some error messages from scapy:

markj@nuc> sudo kyua debug ping_test:inject_opts
Executing command [ python3 /usr/tests/sbin/ping/injection.py opts ]
Fail: stderr not empty
--- /dev/null   2022-11-30 14:43:29.782039000 +0000
+++ /tmp/kyua.FOws6H/2/work/check.VgUqKM/stderr 2022-11-30 14:43:27.574257000 +0000
@@ -0,0 +1,5 @@
+
+(injection.py:37468): dbind-WARNING **: 14:43:27.258: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/kyua.y0IpE0/7/work/.cache/at-spi/bus_0: No such file or directory
+WARNING: No IPv4 address found on bridge0 !
+WARNING: No IPv4 address found on epair0a !
+WARNING: more No IPv4 address found on epair0b !
Files left in work directory after failure: .cache, .config, tun.txt
ping_test:inject_opts  ->  failed: atf-check failed; see the output of the test for details
Wed, Nov 30, 3:32 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

@thj the fix is in main now. Could you please review again?

Wed, Nov 30, 2:01 AM
asomers changed the visibility for D37210: Add test cases for ping with IP options in the response.
Wed, Nov 30, 2:00 AM
asomers added a comment to D37519: modify the nfsd so that it can be run in a vnet prison.
  • The sysctl falls out of the krpc code. I don't know why dfr@ provided it. Maybe for old NFS code or some other protocol that uses the krpc. --> If you set it after starting the nfsd, it would override the command line setting, I think. Basically the sysctls are useless for the new nfsd code, but to get rid of them, the krpc would need to be changed to never generate them.
Wed, Nov 30, 12:01 AM

Yesterday

asomers added a comment to D37519: modify the nfsd so that it can be run in a vnet prison.

I don't know much about the NFS server code, but I've got a few questions:

Tue, Nov 29, 8:45 PM

Wed, Nov 23

asomers committed rG0e86854450b4: Don't panic when tasting a disk with sectorsize=0 (authored by asomers).
Don't panic when tasting a disk with sectorsize=0
Wed, Nov 23, 9:04 PM
asomers committed rG896282a37f5a: ctld: if adding a target fails, retry it on the next reload (authored by asomers).
ctld: if adding a target fails, retry it on the next reload
Wed, Nov 23, 8:57 PM
asomers committed rG4a0c5d391f8a: fusefs: fix VOP_ADVLOCK with SEEK_END (authored by asomers).
fusefs: fix VOP_ADVLOCK with SEEK_END
Wed, Nov 23, 8:55 PM

Sun, Nov 20

asomers added a comment to D37210: Add test cases for ping with IP options in the response.

@jlduran_gmail.com don't get too invested; @thj already has a fix prepared.

Sun, Nov 20, 9:45 PM

Fri, Nov 11

asomers accepted D37257: zfs tests: stop writing to arbitrary devices.

Well, it isn't ideal. But it's certainly much better than it used to be, and the ZFS tests are much too big to shoot for "ideal".

Fri, Nov 11, 5:35 PM

Wed, Nov 9

asomers closed D37313: Don't panic when tasting a disk with sectorsize=0.
Wed, Nov 9, 5:23 PM
asomers committed rG05d0f4308caa: Don't panic when tasting a disk with sectorsize=0 (authored by asomers).
Don't panic when tasting a disk with sectorsize=0
Wed, Nov 9, 5:23 PM
asomers updated the diff for D37313: Don't panic when tasting a disk with sectorsize=0.
  • Perform the check earlier
Wed, Nov 9, 4:55 PM
asomers added a comment to D37313: Don't panic when tasting a disk with sectorsize=0.

Seems ok, but why not handle it in g_label_taste(), or even at some higher level in GEOM (maybe g_disk_create())? I can't think of any classes that will do something sane with a provider with sectorsize 0...

Wed, Nov 9, 4:36 PM
asomers requested review of D37313: Don't panic when tasting a disk with sectorsize=0.
Wed, Nov 9, 3:22 AM

Tue, Nov 8

asomers added a comment to D37309: gmultipath: new command "gmultipath which".
In D37309#847728, @mav wrote:

Not that I have specific objections against this, but I think it would be much better to implement a generic way to print all consumers connected to specified GEOM provider. This code does not look anyhow specific to gmultipath.

Tue, Nov 8, 10:14 PM

Thu, Nov 3

asomers added inline comments to D37257: zfs tests: stop writing to arbitrary devices.
Thu, Nov 3, 8:36 PM

Wed, Nov 2

asomers committed rG002c47badee5: [skip ci] Remove obsolete references in crypto_request(9) (authored by asomers).
[skip ci] Remove obsolete references in crypto_request(9)
Wed, Nov 2, 5:10 PM
asomers closed D37239: [skip ci] Remove obsolete references in crypto_request(9).
Wed, Nov 2, 5:10 PM
asomers added inline comments to D37239: [skip ci] Remove obsolete references in crypto_request(9).
Wed, Nov 2, 5:08 PM
asomers requested review of D37239: [skip ci] Remove obsolete references in crypto_request(9).
Wed, Nov 2, 4:46 PM

Oct 31 2022

asomers updated subscribers of D37210: Add test cases for ping with IP options in the response.

BTW, these tests are for the code change in D37195

Oct 31 2022, 4:33 PM
asomers changed the visibility for D37210: Add test cases for ping with IP options in the response.
Oct 31 2022, 4:32 PM
asomers changed the visibility for D37210: Add test cases for ping with IP options in the response.
Oct 31 2022, 4:32 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

I may also have a slight suspicion you applied your diff to a different ping.c base. After all, the idea was just to add test cases.

Yes I did. But I can't figure out how to make the ping.c changes go away from phabricator. Can we just pretend, for the sake of review, that they aren't there?

😂 that changes everything!
But in all seriousness, we may have hit a bug? in the opts case.

Oct 31 2022, 4:25 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

I may also have a slight suspicion you applied your diff to a different ping.c base. After all, the idea was just to add test cases.

Oct 31 2022, 1:51 PM
asomers committed rGfaea785d3053: fusefs: After successful F_GETLK, l_whence should be SEEK_SET (authored by asomers).
fusefs: After successful F_GETLK, l_whence should be SEEK_SET
Oct 31 2022, 1:51 AM
asomers committed rGab7955aec728: fusefs: during F_GETLK, don't change l_pid if no lock is found (authored by asomers).
fusefs: during F_GETLK, don't change l_pid if no lock is found
Oct 31 2022, 1:51 AM

Oct 30 2022

asomers updated the diff for D37210: Add test cases for ping with IP options in the response.
  • More specific output checking for inject_pip
Oct 30 2022, 8:37 PM
asomers updated the diff for D37210: Add test cases for ping with IP options in the response.
  • Match ping's stdout in the injection tests.
  • Python style
Oct 30 2022, 7:48 PM
asomers added inline comments to D37210: Add test cases for ping with IP options in the response.
Oct 30 2022, 7:43 PM
asomers updated the diff for D37210: Add test cases for ping with IP options in the response.
  • Add missing file
Oct 30 2022, 5:14 AM

Oct 29 2022

asomers requested review of D37210: Add test cases for ping with IP options in the response.
Oct 29 2022, 10:07 PM

Oct 25 2022

asomers accepted D37076: Fix blksize selection in vn_generic_copy_file_range() for ZFS.

Ok, this LGTM if you fix the comment typo. And I think I like the reasoning here better than in the other PR.

Oct 25 2022, 2:57 PM

Oct 24 2022

asomers added inline comments to D37076: Fix blksize selection in vn_generic_copy_file_range() for ZFS.
Oct 24 2022, 10:47 PM

Oct 22 2022

asomers committed rG15b3e3bb7efc: ctld: if adding a target fails, retry it on the next reload (authored by asomers).
ctld: if adding a target fails, retry it on the next reload
Oct 22 2022, 12:31 AM
asomers closed D36974: ctld: if adding a target fails, retry it on the next reload.
Oct 22 2022, 12:30 AM

Oct 20 2022

asomers committed rG311f68079ff2: fusefs: After successful F_GETLK, l_whence should be SEEK_SET (authored by asomers).
fusefs: After successful F_GETLK, l_whence should be SEEK_SET
Oct 20 2022, 4:26 PM

Oct 19 2022

asomers updated the diff for D36974: ctld: if adding a target fails, retry it on the next reload.
  • Also delete newport if old port is a dummy
Oct 19 2022, 8:43 PM
asomers added inline comments to D36974: ctld: if adding a target fails, retry it on the next reload.
Oct 19 2022, 8:20 PM
asomers committed rG57d42454e143: fusefs: better debugging for FUSE_RENAME in the tests (authored by asomers).
fusefs: better debugging for FUSE_RENAME in the tests
Oct 19 2022, 3:22 AM
asomers committed rG4dd575e7d54d: fusefs: update atime on reads when using cached attributes (authored by asomers).
fusefs: update atime on reads when using cached attributes
Oct 19 2022, 3:20 AM
asomers committed rG91a60385457a: Add missing change from c76461e064b675c8edd3b1d9bb917905a885a860 (authored by asomers).
Add missing change from c76461e064b675c8edd3b1d9bb917905a885a860
Oct 19 2022, 3:08 AM
asomers committed rGc76461e064b6: Fix a vnode locking bug in fuse_vnop_advlock. (authored by asomers).
Fix a vnode locking bug in fuse_vnop_advlock.
Oct 19 2022, 3:05 AM
asomers committed rG274f5099706f: fusefs: during F_GETLK, don't change l_pid if no lock is found (authored by asomers).
fusefs: during F_GETLK, don't change l_pid if no lock is found
Oct 19 2022, 2:42 AM
asomers committed rGf6e5319550f6: fusefs: fix VOP_ADVLOCK with SEEK_END (authored by asomers).
fusefs: fix VOP_ADVLOCK with SEEK_END
Oct 19 2022, 1:13 AM
asomers closed D37040: fusefs: fix VOP_ADVLOCK with SEEK_END.
Oct 19 2022, 1:12 AM
asomers added inline comments to D36974: ctld: if adding a target fails, retry it on the next reload.
Oct 19 2022, 1:11 AM

Oct 18 2022

asomers requested review of D37040: fusefs: fix VOP_ADVLOCK with SEEK_END.
Oct 18 2022, 11:21 PM
asomers updated the diff for D37030: Validate time when setting RTC.
  • Respond to @imp's comments
Oct 18 2022, 9:38 PM
asomers added inline comments to D37030: Validate time when setting RTC.
Oct 18 2022, 9:35 PM
asomers added inline comments to D37030: Validate time when setting RTC.
Oct 18 2022, 3:33 PM
asomers updated the diff for D37030: Validate time when setting RTC.
  • Fix an assertion spotted by Corvin Köhne
Oct 18 2022, 1:30 PM
asomers added inline comments to D37030: Validate time when setting RTC.
Oct 18 2022, 1:28 PM
asomers requested review of D37030: Validate time when setting RTC.
Oct 18 2022, 3:01 AM

Oct 17 2022

asomers closed D37014: fusefs: After successful F_GETLK, l_whence should be SEEK_SET.
Oct 17 2022, 1:11 PM
asomers committed rG3c3b906b5423: fusefs: After successful F_GETLK, l_whence should be SEEK_SET (authored by asomers).
fusefs: After successful F_GETLK, l_whence should be SEEK_SET
Oct 17 2022, 1:11 PM
asomers requested review of D37014: fusefs: After successful F_GETLK, l_whence should be SEEK_SET.
Oct 17 2022, 3:59 AM

Oct 12 2022

asomers requested review of D36974: ctld: if adding a target fails, retry it on the next reload.
Oct 12 2022, 10:51 PM
asomers committed rG0733dd8a9353: copy_file_range: truncate write if it would exceed RLIMIT_FSIZE (authored by asomers).
copy_file_range: truncate write if it would exceed RLIMIT_FSIZE
Oct 12 2022, 4:50 AM
asomers committed rG0f0a0bdff052: fusefs: truncate write if it would exceed RLIMIT_FSIZE (authored by asomers).
fusefs: truncate write if it would exceed RLIMIT_FSIZE
Oct 12 2022, 4:50 AM
asomers committed rGb9f82f035af4: fusefs: respect RLIMIT_FSIZE during truncate (authored by asomers).
fusefs: respect RLIMIT_FSIZE during truncate
Oct 12 2022, 4:50 AM

Oct 11 2022

asomers committed R11:fe4dc1fd7105: net/nss-pam-ldapd: use closefrom in nslcd (authored by asomers).
net/nss-pam-ldapd: use closefrom in nslcd
Oct 11 2022, 6:49 PM

Oct 7 2022

asomers accepted D36908: Split netinet shell tests into one per line..
Oct 7 2022, 10:13 PM
asomers closed D36905: fusefs: during F_GETLK, don't change l_pid if no lock is found.
Oct 7 2022, 3:10 PM
asomers committed rG46fcf947c6c8: fusefs: during F_GETLK, don't change l_pid if no lock is found (authored by asomers).
fusefs: during F_GETLK, don't change l_pid if no lock is found
Oct 7 2022, 3:10 PM
asomers requested review of D36905: fusefs: during F_GETLK, don't change l_pid if no lock is found.
Oct 7 2022, 2:56 PM

Sep 28 2022

asomers committed R11:dacca3015a05: sysutils/ztop: upgrade to 0.2.1 (authored by asomers).
sysutils/ztop: upgrade to 0.2.1
Sep 28 2022, 3:36 PM
asomers accepted D36720: tests/usr.bin/renice: Prevent running them in parallel.

Sadly, I think there's no way to set that property for an individual test case. I think it's ok to set it for the entire program, since these tests run pretty fast anyway.

Sep 28 2022, 3:32 PM

Sep 27 2022

asomers accepted D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.

Approved. And even though I probably won't MFC the original, please be sure to add an "MFC With" to your commit message, just in case.

Sep 27 2022, 5:08 PM
asomers added a comment to D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.

It looks like your version will result in more sequential oid numbers. But I don't see how the old version could create a duplicate. Could you please explain?

After your change, when the first oid_number tried is found to be in use, you usually increment the oid_number and use it, assuming that it is not also in use. Before your change, when the first oid-number tried is found to be in use, the code usually incremented the old number and iterated, to check whether that number was in use, and kept doing so until it found a number not in use. So, you have introduced a bug, which I am trying to address, by making sure that the oid_number is not in use.

Sep 27 2022, 4:41 PM
asomers accepted D36748: sysctl(3): Implement SYSCTL_FOREACH() to iterate all OIDs in a sysctl list..

If this makes external kernel modules easier, than go for it.

Sep 27 2022, 4:24 PM
asomers added a comment to D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.

It looks like your version will result in more sequential oid numbers. But I don't see how the old version could create a duplicate. Could you please explain?

Sep 27 2022, 4:20 PM
asomers committed rG6622e299ac73: Fix the build with SCHED_STATS after d3f96f661050 (authored by asomers).
Fix the build with SCHED_STATS after d3f96f661050
Sep 27 2022, 2:22 AM
asomers committed rGd3f96f661050: Fix O(n^2) behavior in sysctl (authored by asomers).
Fix O(n^2) behavior in sysctl
Sep 27 2022, 12:04 AM
asomers closed D36500: Fix O(n^2) behavior in sysctl.
Sep 27 2022, 12:04 AM

Sep 26 2022

asomers closed D36706: copy_file_range: truncate write if it would exceed RLIMIT_FSIZE.
Sep 26 2022, 9:23 PM
asomers committed rG52360ca32ff9: copy_file_range: truncate write if it would exceed RLIMIT_FSIZE (authored by asomers).
copy_file_range: truncate write if it would exceed RLIMIT_FSIZE
Sep 26 2022, 9:23 PM
asomers updated the diff for D36500: Fix O(n^2) behavior in sysctl.
  • Rename a function
Sep 26 2022, 9:17 PM
asomers added a comment to D36500: Fix O(n^2) behavior in sysctl.

@mjg are you ok with the current version of this review, using RB trees? I don't want to make the other changes because:

  • Using sorted arrays with dynamic reallocation would be a lot more work than the RB trees.
  • Adding a second tree to speed up name2oid would be possible, but it really doesn't depend on anything else in this change. It could be done independently.
  • AFAIK name2oid's current performance is good enough for current users. It doesn't blow up quadratically like sysctl_sysctl_next_action does.
Sep 26 2022, 8:58 PM
asomers updated the diff for D36706: copy_file_range: truncate write if it would exceed RLIMIT_FSIZE.
  • Add comments about vn_rlimit_fsizex_res
Sep 26 2022, 2:30 AM

Sep 25 2022

asomers added a comment to D36706: copy_file_range: truncate write if it would exceed RLIMIT_FSIZE.
In D36706#833361, @kib wrote:

Use of vn_rlimit_fsizex() requires finishing VOP with vn_rlimit_fsizex_res().

Sep 25 2022, 11:59 PM
asomers requested review of D36706: copy_file_range: truncate write if it would exceed RLIMIT_FSIZE.
Sep 25 2022, 11:17 PM
asomers committed rGbe280f60dd8e: fusefs: truncate write if it would exceed RLIMIT_FSIZE (authored by asomers).
fusefs: truncate write if it would exceed RLIMIT_FSIZE
Sep 25 2022, 9:05 PM
asomers closed D36703: fusefs: better handling of RLIMIT_FSIZE.
Sep 25 2022, 9:04 PM
asomers committed rG0a192b3abab1: fusefs: respect RLIMIT_FSIZE during truncate (authored by asomers).
fusefs: respect RLIMIT_FSIZE during truncate
Sep 25 2022, 9:04 PM
asomers requested review of D36703: fusefs: better handling of RLIMIT_FSIZE.
Sep 25 2022, 7:09 PM

Sep 18 2022

asomers accepted D36625: Improve POSIX compliance for RLIMIT_FSIZE.

Thanks for fixing this. As for what the correct behavior should be when the file doesn't yet exceed the limit but a write would cross that threshold, I'm agnostic. I think the old behavior of aborting the write entirely was fine. But the new behavior is fine too. I can fix truncate with fusefs after you merge this change.

Sep 18 2022, 8:42 PM

Sep 14 2022

asomers added inline comments to D36500: Fix O(n^2) behavior in sysctl.
Sep 14 2022, 8:14 PM
asomers accepted D36566: tests/sys/fs: remove mips workaround.
Sep 14 2022, 3:12 PM

Sep 13 2022

asomers added inline comments to D36500: Fix O(n^2) behavior in sysctl.
Sep 13 2022, 12:23 AM

Sep 12 2022

asomers added inline comments to D36500: Fix O(n^2) behavior in sysctl.
Sep 12 2022, 11:29 PM
asomers updated the diff for D36500: Fix O(n^2) behavior in sysctl.
  • Switch to rb trees instead of splay trees
  • Bump __FreeBSD_version due to the KPI change
Sep 12 2022, 9:00 PM
asomers added a comment to D36540: Pass stack size, limit, and (no)overcommit flag to image using auxv, to avoid syscalls on jemalloc and libthr startup..

This is outside of my areas of expertise. I'm afraid I won't be able to help with the review.

Sep 12 2022, 8:05 PM

Sep 9 2022

asomers added a comment to D36500: Fix O(n^2) behavior in sysctl.

I don't think arrays are a practical solution, because the key range is too large. oid_number can be as high as INT_MAX, so the arrays would have to be dynamically allocated, and they may have to resize on insertion.

It can't, I noted this is already clamped:

/*
 * The starting number for dynamically-assigned entries.  WARNING!
 * ALL static sysctl entries should have numbers LESS than this!
 */
#define CTL_AUTO_START  0x100

So worst case for static entries is not particularly bad. Resizing on insertion may still be sensible to do, but it wont affect lookups.

Sep 9 2022, 9:01 PM
asomers added a comment to D36500: Fix O(n^2) behavior in sysctl.

Hi, thank you for the review. I like the lock update.

Could it impact <sysutils/sysctlinfo-kmod>? After this kernel update, is it still possible to compile and to use the sysctlinfo-kmod port and its "clients"? (deskutils/sysctlview, sysutils/nsysctl, audio/mixertui, sysutils/sysctlbyname-improved-kmod,...)

(I ask because unfortunately now I'm in a busy period and cannot test and give this review the attention it deserves.)

Sep 9 2022, 8:58 PM