Page MenuHomeFreeBSD

ctld: Fail for missing or invalid CHAP secrets in UCL config
ClosedPublic

Authored by jhb on Feb 11 2025, 1:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 3:31 AM
Unknown Object (File)
Sat, Oct 4, 8:25 AM
Unknown Object (File)
Thu, Sep 18, 2:11 PM
Unknown Object (File)
Mon, Sep 15, 6:18 AM
Unknown Object (File)
Sep 13 2025, 9:31 AM
Unknown Object (File)
Sep 12 2025, 10:32 PM
Unknown Object (File)
Sep 7 2025, 2:21 PM
Unknown Object (File)
Sep 4 2025, 1:12 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 11 2025, 1:20 AM
asomers requested changes to this revision.Feb 11 2025, 6:23 PM
asomers added inline comments.
usr.sbin/ctld/uclparse.c
74

If this error is going to be fatal, then I suggest you increase the priority of the log message.

This revision now requires changes to proceed.Feb 11 2025, 6:23 PM
usr.sbin/ctld/uclparse.c
74

The warn vs err is not a severity. log_warnx() is like warnx() in that it just warns, log_errx() is like errx() in that the process exits after logging the warning. In general we don't want to exit for any parse errors.

Ahh, sorry for the noise.

This revision is now accepted and ready to land.Feb 11 2025, 9:31 PM