Differential D48930

ctld: Fix the isns-period and isns-timeout keywords in the UCL parser
ClosedPublic
Actions

Authored by jhb on Feb 11 2025, 1:20 AM.

Tags

None

Referenced Files

	F174186266: D48930.diff
	Thu, Oct 1, 5:41 AM

	Unknown Object (File)
	Thu, Sep 17, 9:29 AM

	Unknown Object (File)
	Wed, Sep 16, 1:13 AM

	Unknown Object (File)
	Aug 30 2026, 4:53 PM

	Unknown Object (File)
	Aug 22 2026, 11:29 AM

	Unknown Object (File)
	Aug 21 2026, 11:07 PM

	Unknown Object (File)
	Aug 12 2026, 11:07 AM

	Unknown Object (File)
	Aug 12 2026, 6:42 AM

View All 96 Files

Subscribers

Details

Reviewers

Commits

rG67f12d18252a: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser
rG64905b38b1ae: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser

Summary

These keywords were setting the wrong configuration value (connection
timeout).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 11 2025, 1:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 1:20 AM

jhb requested review of this revision.Feb 11 2025, 1:20 AM

Harbormaster completed remote builds in B62357: Diff 150819.Feb 11 2025, 1:20 AM

jhb added a parent revision: D48929: ctld: Consistently free temporary strings during yacc parsing.Feb 11 2025, 1:20 AM

jhb added a child revision: D48931: ctld: Fail for missing or invalid CHAP secrets in UCL config.

Yikes. I guess nobody was using those.

This revision is now accepted and ready to land.Feb 11 2025, 6:20 PM

Closed by commit rG64905b38b1ae: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser (authored by jhb). · Explain WhyFeb 12 2025, 7:35 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG64905b38b1ae: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser.

jhb added a commit: rG67f12d18252a: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser.Jan 27 2026, 6:44 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

4 lines

Diff 150922

usr.sbin/ctld/uclparse.c

Loading...