Page MenuHomeFreeBSD
Differential D48933

ctld: Fix parsing of text values for DSCP in UCL parser
ClosedPublic
Actions

Authored by jhb on Feb 11 2025, 1:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 11:21 AM
Unknown Object (File)
Sat, Apr 18, 10:13 AM
Unknown Object (File)
Fri, Apr 17, 11:28 PM
Unknown Object (File)
Fri, Apr 17, 7:17 AM
Unknown Object (File)
Fri, Apr 17, 7:12 AM
Unknown Object (File)
Wed, Apr 15, 10:39 PM
Unknown Object (File)
Tue, Apr 14, 12:23 PM
Unknown Object (File)
Mon, Apr 13, 6:20 PM
View All 94 Files
Subscribers
imp

Details

Reviewers
asomers
Commits
rG1b4e894eaeb1: ctld: Fix parsing of text values for DSCP in UCL parser
rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Feb 11 2025, 1:20 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 1:20 AM
Harbormaster completed remote builds in B62360: Diff 150822.Feb 11 2025, 1:20 AM
jhb requested review of this revision.Feb 11 2025, 1:20 AM
jhb added a parent revision: D48932: ctld: Use preferred style for evaluating result of strcmp.
jhb added a child revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.
asomers accepted this revision.Feb 11 2025, 6:35 PM

The old code certainly looks broken. I guess nobody was using it?

This revision is now accepted and ready to land.Feb 11 2025, 6:35 PM
jhb added a comment.Feb 11 2025, 7:19 PM
In D48933#1116308, @asomers wrote:

The old code certainly looks broken. I guess nobody was using it?

Yes, my guess is that the UCL paths weren't well tested.

Closed by commit rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser (authored by jhb). · Explain WhyFeb 12 2025, 7:35 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser.
jhb added a commit: rG1b4e894eaeb1: ctld: Fix parsing of text values for DSCP in UCL parser.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
44 lines

Diff 150925

View Options

usr.sbin/ctld/uclparse.c

Loading...