Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 25, 2:54 PM

	Unknown Object (File)
	Tue, Aug 25, 10:59 AM

	Unknown Object (File)
	Tue, Aug 25, 10:51 AM

	Unknown Object (File)
	Fri, Aug 21, 7:48 AM

	Unknown Object (File)
	Thu, Aug 20, 11:17 PM

	Unknown Object (File)
	Thu, Aug 13, 1:31 AM

	Unknown Object (File)
	Thu, Aug 13, 12:35 AM

	Unknown Object (File)
	Thu, Aug 13, 12:33 AM

View All Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rGc3688679ded5: ctld: Fail UCL configurations with a nested error
rGf3a43b3db881: ctld: Fail UCL configurations with a nested error

Summary

Errors from auth groups, portal groups, global luns, and targets were
not propagated out of the main loop.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 19 2025, 11:05 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2025, 11:05 PM

jhb requested review of this revision.Feb 19 2025, 11:05 PM

jhb added a parent revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.

Harbormaster completed remote builds in B62531: Diff 151225.Feb 19 2025, 11:05 PM

jhb added a child revision: D48935: ctld: Be more consistent for auth parameters in the UCL config.Feb 19 2025, 11:06 PM

Fix a few nits missed in last rebase

Harbormaster completed remote builds in B62568: Diff 151306.Feb 21 2025, 7:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 3:16 PM

Closed by commit rGf3a43b3db881: ctld: Fail UCL configurations with a nested error (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf3a43b3db881: ctld: Fail UCL configurations with a nested error.

jhb added a commit: rGc3688679ded5: ctld: Fail UCL configurations with a nested error.Jan 27 2026, 6:45 PM

ctld: Fail UCL configurations with a nested error
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 151497

usr.sbin/ctld/uclparse.c

ctld: Fail UCL configurations with a nested errorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 151497

usr.sbin/ctld/uclparse.c

ctld: Fail UCL configurations with a nested error
ClosedPublic
Actions

Revision Contents
Changeset List