User Details
- User Since
- Oct 23 2016, 10:57 AM (344 w, 3 d)
Yesterday
Sun, May 28
Sat, May 27
Thu, May 25
Wed, May 24
What's the rationale for patches? They look strange.
Tue, May 23
Mon, May 22
Awesome, thanks!
Sun, May 21
Are you sure this patch doesn't break anything for PHP < 8?
Sat, May 20
@rene what do you think about this?
What's the point in fixing unsupported versions of 13 and 14?
Fri, May 19
Thu, May 18
Great job!
Ideally, we'd want to use %%LOCALBASE%% substitution there, but meh. I think this is fine as it is.
LGTM given that you did the build and then make check-plist.
Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?
Wed, May 17
Tue, May 16
Mon, May 15
It builds for me on 14-CURRENT, but doesn't work: I'm getting INTERNAL_ERROR 3 on a VM start. Does it work for you on 13?
Sat, May 13
Fri, May 12
Thu, May 11
Address another my comment and it should be fine.
LGTM. @mfechner what do you think?
Sun, May 7
Sat, May 6
This diff doesn't apply with arc too. Can you please re-generate it using Arcanist?
Can you please refresh the patch?
Thu, May 4
Wed, May 3
Tue, May 2
I'd remove an elaborate changelog from the commit message, the URL would suffice.
May 1 2023
No need to add the comment with a commit hash. Phabricator adds it automatically based on Differential Revision: https://... tag in the commit message.
Apr 30 2023
Apr 29 2023
Yes, it is in the "accepted" state.