netlink: Do not cast to int in NLMSG_HDRLEN and _NLMSG_LEN

[arrowd]

Test Plan

make buildkernel passes

[jhb]

Some other cleanups to consider as separate commits: Just use the userspace version of NLMSG_ALIGNTO and NLMSG_ALIGN always (so move them above the #ifndef _KERNEL). Also, replace roundup2() with just using __align_up() from <sys/cdefs.h> unconditionally.

I'm also not convinced that NLMSG_HDRLEN isn't in practice the same for both userspace and the kernel.

sys/netlink/netlink.h

213–214

sizeof() already returns a size_t, so you can just remove this cast instead

225

I'm not sure you need this cast either

[arrowd]

Address comments

[jhb]

I'm fine with doing all this at once, though you might want to update the log to mention using __align_up and reducing duplication, etc.

sys/netlink/netlink.h

225

You can use tabs to align the macro value now while you are here.

[arrowd]

In D47333#1080149, @jhb wrote:

I'm fine with doing all this at once, though you might want to update the log to mention using __align_up and reducing duplication, etc.

I did it as three commits, see the "Commits" tab.

[arrowd]

• Align with tabs

[jhb]

Ah, ok. I tend to upload individual commits as a stack. Still LGTM, thanks!

[melifaro]

Let’s make sure that the constants /macro still has the same type as in Linux and check that, for example, net/bird2 compiles without additional warnings after this change

[arrowd]

In D47333#1081023, @melifaro wrote:

net/bird2 compiles without additional warnings after this change

Check that, it builds with no new warnings.