D57838 committed instead

apply ziaee@'s suggestions

In D57520#1325996, @zishun.yi.dev_gmail.com wrote:

Include this in the revision where I add this flag.

In D57807#1326440, @glebius wrote:

Returning ENOBUFS on recv(2) when we actually have data that can be successfully given to the application doesn't look correct at all. I know that Linux likes to return error from one syscall as a return to an other syscall, this was "a feature" since Linux 2.2 and UDP socket. While netlink is originally Linux idea, but it still is a socket(2), and it should behave as a normal socket and recv(2) shall return error from a receive operation, not status of a past send(2). We may want to emulate this bug on sockets opened by processes with Linux ABI, but I definitely don't want to be the behavior of the native socket.

And that's why I asked. If I press the button on my non-framework laptop, the BT USB device just vanishes (you can see on console) and wifi stops transmitting as it's firmware/hardware doing that (and the wifi driver getting an interrupt I believe even on that one too).

But what triggers the actual RFKILL hardware level disconnect? The same button press?

I forgot to include the Differential Revision: tag 😭

could also be interesting to add a test to check whether data is copied into receive buffer or not and that ENOBUFS is returned correctly, but this can be done separately

sorry for being a little late to the party here - looks pretty good overall!

rebase

rebase

rebase

update manpage date

consistent naming + more stuff in manpage

improve accessibility of HARDWARE section

move CAVEATS to end, add blank comment before SPDX

Some of the description really belongs in CAVEATS, but that's okay.

thanks!

tested on my fw13!

In D57366#1318931, @ziaee wrote:

Does this mean that we have suspend support now for these platforms?

my only concern with making S4 BIOS its own ACPI sleep state is that we won't really have a way of making the fw_hibernate sleep type map to it, and we might have to re-add a similar sysctl to s4bios

happy with this :) just maybe the consts added around the place should be committed separately

suggestion committed in ee13bfb694844df90b06c7246781212d3133e81c

not just in libraries

respond to ziaee@'s comments

Update note to specify multithreaded programs.

That's fair. I didn't really know of the other reasons specific to darwin, but I guess I can at least reword this to explain the issue on FreeBSD for multithreaded programs.

Committed in 0b2df683672e3b5792aa552a3700da86617f9d90, but forgot to add the "Differential Revision" tag

@olce last point done by 7a11a6c64d4f52f41e63e535605d4187650c3651. Also updated sysctl descriptions in the acpi.4 manpage in 071d82d9973660742e771b23365a82eb8dd2dd0f

squashed into aba599a6cc550bf209b42a81a3cdb3f6e94d0613 at ziaee@'s request