Page MenuHomeFreeBSD

obiwac (Aymeric Wibo)
Fan-bearer on the Right Side of the King

Projects

User Details

User Since
Jul 12 2022, 11:32 AM (220 w, 1 d)

Recent Activity

Tue, Sep 22

obiwac accepted D59911: misc: Avoid use of Unicode closing single quote.
Tue, Sep 22, 5:07 PM

Fri, Sep 18

obiwac added a comment to D59788: amdsmu: Fix model-specific matching.

ok, that works for me!

Fri, Sep 18, 12:51 PM
obiwac committed rG758578370f6b: amdsmu: Hints on what to do if IP block blocking S0i3 (authored by obiwac).
amdsmu: Hints on what to do if IP block blocking S0i3
Fri, Sep 18, 11:00 AM
obiwac committed rGa23fa3fe1c0a: amdsmu: Diagnose S0i3 entry after resume (authored by obiwac).
amdsmu: Diagnose S0i3 entry after resume
Fri, Sep 18, 11:00 AM
obiwac committed rG7ff26d59e738: acpi: Invoke power_resume_check eventhandler (authored by obiwac).
acpi: Invoke power_resume_check eventhandler
Fri, Sep 18, 11:00 AM
obiwac committed rG4afc2d5ac333: power: Move power-related eventhandler decls to sys/power.h (authored by obiwac).
power: Move power-related eventhandler decls to sys/power.h
Fri, Sep 18, 11:00 AM
obiwac committed rG708dde6988b0: power: Add power_resume_check eventhandler (authored by obiwac).
power: Add power_resume_check eventhandler
Fri, Sep 18, 11:00 AM
obiwac committed rGc9bfc37b61d2: acpi: Don't check suspend-to-idle if suspend failed (authored by obiwac).
acpi: Don't check suspend-to-idle if suspend failed
Fri, Sep 18, 11:00 AM
obiwac closed D59674: amdsmu: Hints on what to do if IP block blocking S0i3.
Fri, Sep 18, 11:00 AM
obiwac closed D59673: amdsmu: Diagnose S0i3 entry after resume.
Fri, Sep 18, 11:00 AM
obiwac closed D59741: acpi: Invoke power_resume_check eventhandler.
Fri, Sep 18, 10:59 AM
obiwac closed D59740: power: Add power_resume_check eventhandler.
Fri, Sep 18, 10:59 AM
obiwac closed D59739: power: Move power-related eventhandler decls to sys/power.h.
Fri, Sep 18, 10:59 AM
obiwac closed D59731: acpi: Don't check suspend-to-idle if suspend failed.
Fri, Sep 18, 10:59 AM
obiwac accepted D59788: amdsmu: Fix model-specific matching.

does it not make more sense to go through amdsmu_products forwards and just reverse the list? then the list can read more naturally as "the product will be the first one that matches an element in this list"

Fri, Sep 18, 10:58 AM

Thu, Sep 17

obiwac committed rG2c59dd4cfdd6: acpi: Set status to AE_ERROR if device suspend failed (authored by obiwac).
acpi: Set status to AE_ERROR if device suspend failed
Thu, Sep 17, 3:50 PM
obiwac closed D59735: acpi: Set status to AE_ERROR if device suspend failed.
Thu, Sep 17, 3:50 PM
obiwac updated the diff for D59674: amdsmu: Hints on what to do if IP block blocking S0i3.

more help for CPU and MPM IP blocks

Thu, Sep 17, 12:20 AM
obiwac committed rGf74d7fc4131d: thunderbolt: Account for CRC in router config write message size (authored by obiwac).
thunderbolt: Account for CRC in router config write message size
Thu, Sep 17, 12:19 AM

Wed, Sep 16

obiwac added a comment to D59738: amdsmu.4: Canonicalize SYNOPSIS and HARDWARE.

style.9 and the license guide show it backwards from what you have, like this:

Wed, Sep 16, 8:51 PM
obiwac committed rG39b8430d25a1: acpi: Fix unused variable error (authored by obiwac).
acpi: Fix unused variable error
Wed, Sep 16, 7:28 PM
obiwac accepted D59738: amdsmu.4: Canonicalize SYNOPSIS and HARDWARE.

Also, you have your license format all mixed up :P

Wed, Sep 16, 6:59 PM
obiwac updated the diff for D59674: amdsmu: Hints on what to do if IP block blocking S0i3.

better hints & truly ignore IP blocks meant to be ignored

Wed, Sep 16, 6:54 PM
obiwac updated the diff for D59673: amdsmu: Diagnose S0i3 entry after resume.

rebase & use new power_resume_check eventhandler

Wed, Sep 16, 6:53 PM
obiwac requested review of D59741: acpi: Invoke power_resume_check eventhandler.
Wed, Sep 16, 6:51 PM
obiwac requested review of D59740: power: Add power_resume_check eventhandler.
Wed, Sep 16, 6:50 PM
obiwac requested review of D59739: power: Move power-related eventhandler decls to sys/power.h.
Wed, Sep 16, 6:50 PM
obiwac committed rG3820d1e1a7e0: amdsmu: Add clarifying comment for the *sw_drips metrics (authored by obiwac).
amdsmu: Add clarifying comment for the *sw_drips metrics
Wed, Sep 16, 6:49 PM
obiwac updated the test plan for D59674: amdsmu: Hints on what to do if IP block blocking S0i3.
Wed, Sep 16, 6:37 PM
obiwac committed rG9b4caca81de2: acpi: Don't compile CPU_VENDOR_{AMD,HYGON} cases on non-x86_64 (authored by obiwac).
acpi: Don't compile CPU_VENDOR_{AMD,HYGON} cases on non-x86_64
Wed, Sep 16, 6:30 PM
obiwac requested review of D59735: acpi: Set status to AE_ERROR if device suspend failed.
Wed, Sep 16, 5:46 PM
obiwac requested review of D59731: acpi: Don't check suspend-to-idle if suspend failed.
Wed, Sep 16, 5:10 PM
obiwac accepted D59621: virtual_oss(8): Fix cuse.ko check.
Wed, Sep 16, 4:33 PM
obiwac committed rG5f68acc931a4: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume (authored by obiwac).
acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume
Wed, Sep 16, 4:23 PM
obiwac closed D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.
Wed, Sep 16, 4:23 PM
obiwac added a comment to D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.

Always printing a warning is fine for the time being. Having a separate function for the check is neat.

Still, that does not compile because cpu_vendor_id is only declared (and defined) for amd64/i386.

Wed, Sep 16, 2:58 PM
obiwac updated the diff for D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.

only use cpu_vendor_id on x64

Wed, Sep 16, 2:57 PM
obiwac updated the diff for D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.
  • factor out into check_post_suspend_to_idle()
  • different messages on AMD/Hygon than for other CPU vendors
Wed, Sep 16, 12:52 PM
obiwac committed rGd2ad1c3ffe67: acpi: Increase length of time (1s -> 5s) for quirk (authored by dteske).
acpi: Increase length of time (1s -> 5s) for quirk
Wed, Sep 16, 12:42 PM
obiwac closed D59583: acpi: Increase length of time (1s -> 5s) for quirk.
Wed, Sep 16, 12:42 PM
obiwac added a comment to D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.

I do want this warning to be emitted on other platforms though, because without specific support they are likely not entering deep sleep either. The message itself is supposed to imply that only platforms with amdsmu are currently supported, but maybe I can make this a little more explicit.

Wed, Sep 16, 12:40 PM

Tue, Sep 15

obiwac added inline comments to D59621: virtual_oss(8): Fix cuse.ko check.
Tue, Sep 15, 10:29 AM
obiwac requested review of D59686: iichid: Consume GPIO interrupts via cousin interrupt mechanism.
Tue, Sep 15, 12:56 AM
obiwac requested review of D59685: gpio: Add GPIO_INTR_MODE_MASK.
Tue, Sep 15, 12:54 AM
obiwac planned changes to D59684: acpi_gpiobus: Enumerate GPIO interrupt pins and wire up cousin interrupts.

this is very not done!

Tue, Sep 15, 12:52 AM
obiwac requested review of D59684: acpi_gpiobus: Enumerate GPIO interrupt pins and wire up cousin interrupts.
Tue, Sep 15, 12:51 AM
obiwac added a reviewer for D59683: acpi_cousin_intr: Add cousin interrupt mechanism for x86: aokblast.
Tue, Sep 15, 12:50 AM
obiwac requested review of D59683: acpi_cousin_intr: Add cousin interrupt mechanism for x86.
Tue, Sep 15, 12:46 AM
obiwac requested review of D59682: gpiobus: Support non-child interrupt resource consumers.
Tue, Sep 15, 12:36 AM

Mon, Sep 14

obiwac requested review of D59674: amdsmu: Hints on what to do if IP block blocking S0i3.
Mon, Sep 14, 6:56 PM
obiwac updated the diff for D59673: amdsmu: Diagnose S0i3 entry after resume.

IP block can have active time but not be blocking, actually

Mon, Sep 14, 6:53 PM
obiwac updated the summary of D59673: amdsmu: Diagnose S0i3 entry after resume.
Mon, Sep 14, 6:45 PM
obiwac updated the diff for D59673: amdsmu: Diagnose S0i3 entry after resume.

only give IP block detail for Phoenix

Mon, Sep 14, 6:44 PM
obiwac requested review of D59673: amdsmu: Diagnose S0i3 entry after resume.
Mon, Sep 14, 6:31 PM
obiwac requested review of D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.
Mon, Sep 14, 6:19 PM
obiwac added inline comments to D49453: USB4 initial work on suspend routine.
Mon, Sep 14, 4:24 PM · USB
obiwac updated the diff for D49453: USB4 initial work on suspend routine.

rebase + respond to comments

Mon, Sep 14, 4:24 PM · USB
obiwac closed D58209: thunderbolt: Support writing to router config space.
Mon, Sep 14, 3:49 PM
obiwac committed rG44b73821d1c0: thunderbolt: Change len from int to size_t in router_prepare_{read,write}() (authored by obiwac).
thunderbolt: Change len from int to size_t in router_prepare_{read,write}()
Mon, Sep 14, 3:49 PM
obiwac committed rG808c82daab85: thunderbolt: Factor out router_prepare_cmd() (authored by obiwac).
thunderbolt: Factor out router_prepare_cmd()
Mon, Sep 14, 3:49 PM
obiwac committed rG9c6e9bfb3474: thunderbolt: Support writing to router config space (authored by obiwac).
thunderbolt: Support writing to router config space
Mon, Sep 14, 3:49 PM
obiwac closed D59668: thunderbolt: Factor out router_prepare_cmd().
Mon, Sep 14, 3:49 PM
obiwac requested review of D59668: thunderbolt: Factor out router_prepare_cmd().
Mon, Sep 14, 2:23 PM
obiwac updated the diff for D58209: thunderbolt: Support writing to router config space.

style(9)

Mon, Sep 14, 2:09 PM
obiwac added inline comments to D58209: thunderbolt: Support writing to router config space.
Mon, Sep 14, 2:07 PM
obiwac added inline comments to D58209: thunderbolt: Support writing to router config space.
Mon, Sep 14, 2:04 PM

Sun, Sep 13

obiwac accepted D59505: website: Revive donations page.
Sun, Sep 13, 3:57 PM
obiwac added inline comments to D58209: thunderbolt: Support writing to router config space.
Sun, Sep 13, 3:48 PM
obiwac updated the diff for D58209: thunderbolt: Support writing to router config space.

add back 60 dword limit comment

Sun, Sep 13, 3:48 PM
obiwac accepted D59589: website: Restore "The Power to Serve" on homepage.
Sun, Sep 13, 12:41 AM

Sat, Sep 12

obiwac accepted D59583: acpi: Increase length of time (1s -> 5s) for quirk.
Sat, Sep 12, 11:41 AM
obiwac committed rG508efe35e577: acpi_spmc: Check Intel constraint packages (authored by obiwac).
acpi_spmc: Check Intel constraint packages
Sat, Sep 12, 11:35 AM
obiwac committed rGa1e236e9d610: acpi_spmc: Check AMD constraint packages (authored by obiwac).
acpi_spmc: Check AMD constraint packages
Sat, Sep 12, 11:35 AM
obiwac closed D59568: acpi_spmc: Check AMD constraint packages.
Sat, Sep 12, 11:35 AM
obiwac closed D59566: acpi_spmc: Check Intel constraint packages.
Sat, Sep 12, 11:35 AM

Thu, Sep 10

obiwac closed D59562: acpi_spmc: Make sure constraints array doesn't end up sparse.
Thu, Sep 10, 8:58 PM
obiwac committed rG542df51903ae: acpi_spmc: Make sure constraints array doesn't end up sparse (authored by obiwac).
acpi_spmc: Make sure constraints array doesn't end up sparse
Thu, Sep 10, 8:58 PM
obiwac updated the summary of D59568: acpi_spmc: Check AMD constraint packages.
Thu, Sep 10, 12:12 PM
obiwac requested review of D59568: acpi_spmc: Check AMD constraint packages.
Thu, Sep 10, 12:10 PM
obiwac updated the diff for D59566: acpi_spmc: Check Intel constraint packages.

Move name dup later so no leak if skipped constraint

Thu, Sep 10, 12:07 PM
obiwac updated the diff for D59566: acpi_spmc: Check Intel constraint packages.

oops forgot continue

Thu, Sep 10, 9:54 AM
obiwac requested review of D59566: acpi_spmc: Check Intel constraint packages.
Thu, Sep 10, 9:47 AM
obiwac requested review of D59562: acpi_spmc: Make sure constraints array doesn't end up sparse.
Thu, Sep 10, 9:37 AM

Aug 13 2026

obiwac added a reviewer for D49453: USB4 initial work on suspend routine: ngie.
Aug 13 2026, 6:22 AM · USB
obiwac updated the diff for D49453: USB4 initial work on suspend routine.

Rebase

Aug 13 2026, 6:20 AM · USB
obiwac committed rG7858a57baa2f: thunderbolt: Explicitly read NHI ISR0 register to clear it (authored by obiwac).
thunderbolt: Explicitly read NHI ISR0 register to clear it
Aug 13 2026, 5:51 AM
obiwac closed D52862: thunderbolt: Pink Sardine support.
Aug 13 2026, 5:51 AM

Aug 12 2026

obiwac committed rGefdb82413963: thunderbolt: Reset controllers (authored by obiwac).
thunderbolt: Reset controllers
Aug 12 2026, 9:54 PM
obiwac committed rG529177b332dc: thunderbolt: Get NHI version number from caps (authored by obiwac).
thunderbolt: Get NHI version number from caps
Aug 12 2026, 9:54 PM
obiwac closed D49452: USB4 host reset (& writing to router config space).
Aug 12 2026, 9:53 PM · drivers, USB

Aug 9 2026

obiwac closed D58727: freebsd-tips: Tip about drivers licenses.
Aug 9 2026, 8:44 AM
obiwac committed rG776ba7badef0: freebsd-tips: Tip about drivers licenses (authored by obiwac).
freebsd-tips: Tip about drivers licenses
Aug 9 2026, 8:44 AM

Aug 8 2026

obiwac requested review of D58727: freebsd-tips: Tip about drivers licenses.
Aug 8 2026, 3:34 PM

Jul 13 2026

obiwac requested review of D58209: thunderbolt: Support writing to router config space.
Jul 13 2026, 8:47 AM

Jul 9 2026

obiwac closed D56026: hid/hsctrl: Add support for Wireless Radio Button.

D57838 committed instead

Jul 9 2026, 7:29 AM
obiwac committed rGe2d56447b3a9: hrfkill: Add driver to report RFKILL button press (authored by obiwac).
hrfkill: Add driver to report RFKILL button press
Jul 9 2026, 7:29 AM
obiwac closed D57838: hradio: Add driver to report RFKILL button press.
Jul 9 2026, 7:28 AM

Jun 27 2026

obiwac committed rGa380d07f4739: virtual_oss.8: Document `/dev/bluetooth/` prefix magic (authored by obiwac).
virtual_oss.8: Document `/dev/bluetooth/` prefix magic
Jun 27 2026, 1:12 AM
obiwac committed rGa6d7347f3042: virtual_oss.8: Use `.Pa` macro to refer to devices (authored by obiwac).
virtual_oss.8: Use `.Pa` macro to refer to devices
Jun 27 2026, 1:12 AM
obiwac committed rG0d4b73a3ced9: ctermid(3): Fix return (authored by obiwac).
ctermid(3): Fix return
Jun 27 2026, 1:12 AM