fix markj comment & ziaee

Fix suggestions by ziaee@

Replace ENAN and ENUMNEG errors with existing EINVAL

Move setprint_delay to console.c

I think this is unlikely to land - I suggest you attempt to get this included into POSIX first.

Update manpage date

Closing this in favour of the following: https://reviews.freebsd.org/D50498

Add missing router defines.

Don't touch router defines; this should be done in D49452.

Fix path.

In D49450#1128475, @imp wrote:

This will take me a while to slog through.
Do you have pointers to online references to USB4 / TB standards you're emplementing?

Thanks for your review, Mark! I'll get to fixing the issues you highlighted soon.

I want to factor out a notify function first.

Fix parens in KASSERTs, add comment for entry/exit notif functions.

Fix shared lock being acquired twice by pulling out acpi_pwr_get_state_locked.

Awesome! I'll start work on reading residency counters on Intel (though the LPIT) soon, so we can check if the CPU is actually entering S0i3 on Intel :)

Split out into D48732, D48734, and D48735.

Thanks for trying this out @jkim & @shuriku_shurik.kiev.ua :)

Print out message when all device power constraints are respected

• Use Intel GET_DEVICE_CONSTRAINTS DSM by default (Microsoft doesn't have this)
• Comment for entry/exit notification functions

In D48387#1111188, @shuriku_shurik.kiev.ua wrote:

On my laptop with Intel i7-1355U CPU I see this while device attached:

Jan 29 15:19:07 thinkpad kernel: acpi_spmc0: <Low Power S0 Idle (DSM sets 0x3)> on acpi0
Jan 29 15:19:07 thinkpad kernel: ACPI Error: Incorrect return type from \_SB_.PEPD._DSM - received [Buffer], requested [Package] (20241212/nsxfeval-274)
Jan 29 15:19:07 thinkpad kernel: acpi_spmc0: failed to call DSM 1 (acpi_spmc_get_constraints)

Based on the discussion on github, it looks like the unqualified D3 state likely should correspond to D3hot?

more style(9) closening

bring closer to style(9)

Add PCI_POWERSTATE_D3_COLD to pci(9) manpage

Respond to style comments

Add missing section header in libusb.3 manpage

This has been split out into revisions D48384, D48385, and D48386.

Explicit check for reslist_name to set reslist_handle. Was previously relying on hidden check in AcpiGetHandle.

Address review comments by @emaste and @imp.

Also, we'll likely want to split this up since it looks like several different changes combined. Though we can split once we're happy with the changes if you have them all combined at the moment.

• libusb.3: add libusb_get_parent

• libusb.3: add libusb_get_parent

This will end up being a port.

In D41679#949804, @imp wrote:

sys/contrib is good for this, but sys/gnu might be even better since it is GPL'd.

Ah yes I forgot to specify sorry, "Aymeric Wibo" :)

ls: Remove Tn macros from manpage