Move comment.

Fix more issues pointed out by olce@.

style(9)

style(9)

Tested on my machine (only S5, S4, and S0) and all works

Should we even allow hw.acpi.s4bios to be set if not supported? feels like it could be confusing to users not super familiar with power management that hw.acpi.s4bios is set but the system is not entering S4BIOS.

Accepting assuming no one has objections about changing the size of the sysctl

relevant commit in acpica, for reference: https://github.com/acpica/acpica/commit/79cd933e7b370e8d3fb490bf36ca5d111a12f96a

Reorder includes.

In D54556#1246429, @markj wrote:

That is a possibility, most other fo_stats seem to follow the bzero before setting fields pattern already.

Including vn_statfile(). I think I agree that for now we should patch dma-buf instead, but in the longer term we perhaps should consolidate the zeroing here.

In D54556#1246415, @kib wrote:

stat(2) was micro-optimized to the death. Do not introduce second write to the same memory (not to mention that the next two lines write to some fields third time).

Simplify cpuset initialization.

Remove rev_for_uuid for now and just use revision 0 everywhere.

Finally got around to updating this diff @olce :)

Fix issues pointed out by olce@.

In D54158#1237352, @jhb wrote:

I think we just need some sort of IVAR we can test for and this is just as easy as any other. Can you test this to make sure it works? I have only compile tested it as my only FreeBSD box with TB has the older chipsets that don't work.

looks good, though I wonder if there is a point in actually passing down tb_gen, considering I don't think we'll be supporting non-TB_GEN_USB4 in a while (and I was gonna remove the existing tb_pcib_identifiers after D52861)

ack your review comments, I have a couple changes I need to bring out of a stash commit before I address your comments. My local commit log is getting pretty messy from all the suspend debugging stuff I'm trying ;)

Fix DSM call ordering

thanks for taking a look at this!

Remove previous IDs.

In D53201#1215648, @jhb wrote:

This fixes a panic when devmatch autoloads on my laptop.

tested it out on my machine and all is good

In D51591#1208761, @bz wrote:

I might go as far as splitting this into (a) the general event handler update and (b) improving linuxkpi?

Superseded by D52861 and D52862

thanks for doing this work!

rebase

More typo fixes and drop __FBSDID tags

Roll typo fixes into this revision

rebase

rebase

thanks for your review!

Remove nhi_compat.h, typo

rebase