Page MenuHomeFreeBSD

aokblast (SHENG-YI HONG)
AoK_Blast

Projects

User does not belong to any projects.

User Details

User Since
Jun 21 2022, 7:17 PM (128 w, 4 d)

Recent Activity

Today

aokblast added a reviewer for D47985: sys/x86/cpufreq/hwpstate_amd.c: add amd pstate for zen5: lwhsu.
Sun, Dec 8, 9:00 AM
aokblast requested review of D47985: sys/x86/cpufreq/hwpstate_amd.c: add amd pstate for zen5.
Sun, Dec 8, 8:55 AM

Thu, Dec 5

aokblast added reviewers for D47930: contrib/libxo/libxo/*.h fix libxo header include when the source is C++: lwhsu, phil.
Thu, Dec 5, 2:11 PM
aokblast requested review of D47930: contrib/libxo/libxo/*.h fix libxo header include when the source is C++.
Thu, Dec 5, 2:09 PM

Thu, Nov 28

aokblast added a reviewer for D47830: Fix various opt_kbd.h related built error in hid module: kib.
Thu, Nov 28, 5:48 PM
aokblast added reviewers for D47830: Fix various opt_kbd.h related built error in hid module: lwhsu, git_danielschaefer.me.
Thu, Nov 28, 5:45 PM
aokblast updated the diff for D47830: Fix various opt_kbd.h related built error in hid module.

Add co-author

Thu, Nov 28, 5:45 PM
aokblast requested review of D47830: Fix various opt_kbd.h related built error in hid module.
Thu, Nov 28, 5:38 PM

Oct 21 2024

aokblast updated the diff for D47153: Fix ncurses codegen from awk that needs to gen keycode for keyname.

Amend commit message

Oct 21 2024, 3:37 PM
aokblast updated the diff for D47153: Fix ncurses codegen from awk that needs to gen keycode for keyname.

Fix indent

Oct 21 2024, 12:25 PM

Oct 16 2024

aokblast updated the summary of D47153: Fix ncurses codegen from awk that needs to gen keycode for keyname.
Oct 16 2024, 2:12 PM
aokblast requested review of D47153: Fix ncurses codegen from awk that needs to gen keycode for keyname.
Oct 16 2024, 2:05 PM

Sep 30 2024

aokblast updated the diff for D46831: sccache: bump version to 0.8.2.

Use Makefile.crates

Sep 30 2024, 2:00 AM

Sep 28 2024

aokblast added reviewers for D46831: sccache: bump version to 0.8.2: pizzamig, lwhsu.
Sep 28 2024, 11:50 AM
aokblast requested review of D46831: sccache: bump version to 0.8.2.
Sep 28 2024, 11:50 AM

Sep 18 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Elaborate commit message and manual

Sep 18 2024, 1:54 PM
aokblast added a comment to D45120: Add bhyve uart raw tcp backend.

Sorry I cannot find other use case. Do you have any idea on the use case of raw tcp? Due to the unsafeness of raw TCP. We should use this feature in localhost. And because of the lack of terminal command in raw TCP support. It is much better to use modem device rather than raw tcp in localhost. So this feature actually is for proxy only (like OpenStack) because most of these applications implement raw tcp connection rather than modem device. But if we support telnet it will be useful because it is much simpler than modem device on configuration. I am planning to do so but we need this feature first because telnet is built upon tcp.

Sep 18 2024, 1:30 PM
aokblast added a comment to D45120: Add bhyve uart raw tcp backend.

Hello, is there any update about this? Anyone want to merge this can use this to have direct patch.

Sep 18 2024, 11:51 AM

Sep 11 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Use ::1 for safe ipv6 address

Sep 11 2024, 12:52 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

User 127.0.0.1 instead of 0.0.0.0 in manual

Sep 11 2024, 12:48 PM

Sep 10 2024

aokblast added a comment to D45120: Add bhyve uart raw tcp backend.

For the 0.0.0.0 problem. I think we should fix it in the separated patch as we should also modify the VNC part.
Here is the branch that follows up the upstream modification of this patch:

Sep 10 2024, 2:35 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Elaborate manual over TCP raw socket

Sep 10 2024, 2:29 PM
aokblast attached a referenced file: F93565464: 0001-bhyve-Add-raw-tcp-to-uart-backend.patch.
Sep 10 2024, 2:24 PM
aokblast added a comment to D45120: Add bhyve uart raw tcp backend.

Thanks for your feedback and here is the patch

Sep 10 2024, 2:19 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Use warn instead of warnx on system call

Sep 10 2024, 2:15 PM

Sep 9 2024

aokblast added inline comments to D45120: Add bhyve uart raw tcp backend.
Sep 9 2024, 2:45 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Fix some typo and double close

Sep 9 2024, 2:44 PM

Sep 8 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Rebase and refactor comment

Sep 8 2024, 11:24 AM

Sep 3 2024

aokblast added inline comments to D45120: Add bhyve uart raw tcp backend.
Sep 3 2024, 9:15 AM

Aug 22 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.

Prevent race condition in is_socket

Aug 22 2024, 12:28 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Aug 22 2024, 12:25 PM

Aug 21 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Aug 21 2024, 2:15 PM

Aug 13 2024

aokblast added a comment to D46231: Add autoscale for gstat.

@imp Hello, I found this needed feature in your idea list. Do you have any problem or feedback?

Aug 13 2024, 1:57 PM

Aug 12 2024

aokblast added a comment to D46249: Add smbus and i2c device id for Meteor Lake.

Fix it

Aug 12 2024, 2:25 PM
aokblast updated the diff for D46249: Add smbus and i2c device id for Meteor Lake.

Comply with space style

Aug 12 2024, 2:25 PM

Aug 9 2024

aokblast added reviewers for D46249: Add smbus and i2c device id for Meteor Lake: jhb, emaste.
Aug 9 2024, 8:38 AM
aokblast updated the summary of D46249: Add smbus and i2c device id for Meteor Lake.
Aug 9 2024, 8:35 AM
aokblast updated the diff for D46249: Add smbus and i2c device id for Meteor Lake.

Add extra id for smbus

Aug 9 2024, 8:34 AM
aokblast requested review of D46249: Add smbus and i2c device id for Meteor Lake.
Aug 9 2024, 8:09 AM

Aug 7 2024

aokblast updated the diff for D46231: Add autoscale for gstat.

Remove useless newline

Aug 7 2024, 2:04 PM
aokblast updated the diff for D46231: Add autoscale for gstat.

Move SCALE outside

Aug 7 2024, 2:01 PM
aokblast updated the diff for D46231: Add autoscale for gstat.

Bump gstat manual

Aug 7 2024, 1:54 PM
aokblast updated the diff for D46231: Add autoscale for gstat.

Reduce double outside scale

Aug 7 2024, 1:32 PM

Aug 6 2024

aokblast updated the diff for D46231: Add autoscale for gstat.

Apply clang-format

Aug 6 2024, 11:36 AM
aokblast updated the diff for D46231: Add autoscale for gstat.

Rebase to main and make scale more obvious

Aug 6 2024, 11:33 AM
aokblast added a reviewer for D46231: Add autoscale for gstat: imp.
Aug 6 2024, 1:11 AM

Aug 5 2024

aokblast updated the summary of D46231: Add autoscale for gstat.
Aug 5 2024, 4:51 PM
aokblast updated the diff for D46231: Add autoscale for gstat.

Backward competible implementation

Aug 5 2024, 4:48 PM
aokblast updated the summary of D46231: Add autoscale for gstat.
Aug 5 2024, 4:34 PM
aokblast requested review of D46231: Add autoscale for gstat.
Aug 5 2024, 4:28 PM

Jul 31 2024

aokblast updated the summary of D46193: WIP: add all KCFI modification and wait for discuss.
Jul 31 2024, 4:18 PM
aokblast updated subscribers of D46193: WIP: add all KCFI modification and wait for discuss.
Jul 31 2024, 4:02 PM
aokblast updated subscribers of D46193: WIP: add all KCFI modification and wait for discuss.
Jul 31 2024, 3:59 PM
aokblast updated the summary of D46193: WIP: add all KCFI modification and wait for discuss.
Jul 31 2024, 3:57 PM
aokblast updated the summary of D46193: WIP: add all KCFI modification and wait for discuss.
Jul 31 2024, 3:52 PM
aokblast requested review of D46193: WIP: add all KCFI modification and wait for discuss.
Jul 31 2024, 3:10 PM

Jun 7 2024

aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

So do you means we only aware of the incompatible kernel and don't implement similar check for kernel module?

Jun 7 2024, 9:07 PM
aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

I think you are right, I don't think about kernel problem. And in my opinion, it is the chicken-and-egg conundrum if we implemented it in a normal ELF way (rely on VMA of section) for kernel. But it is still a mitigation for driver developer when developing kernel module. Besides, we still need uuid_addr for relocatable kernel module. I have extract my patch to contain relocatable file handling only. So I think we should preserve this patch not merge it until finding a way to verify who is the correct kernel? (by extended the kernel dump header as you mentioned or something else?)

Jun 7 2024, 7:34 PM

Jun 6 2024

aokblast updated the diff for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

Expose uuid for kernel module in kernel to prevent incompetable coredump loaded by debugger for relocatable file

Jun 6 2024, 7:04 PM
aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

But we cannot just rely on the file to tell use where the memory is because it maybe wrong after you compile the module. For relocatable file, you don't even have VMA to tell you where is the memory. We should use uuid_addr from kernel memory. This is why I think we should have build-id feature (The file loaded is different from the one statically resides in your file system)

Jun 6 2024, 6:58 PM
aokblast added a comment to D43251: Update riscv-isa-sim to 2024-05-31 snapshot.

Got it. Thanks for your response!

Jun 6 2024, 3:15 PM
aokblast added a comment to D43251: Update riscv-isa-sim to 2024-05-31 snapshot.

Just a question, how you test on kernel, I use spike --kernel /path/to/kernel /path/to/sbi. It give me invalid address error even after I add -m0x1000000,0x2000.

Jun 6 2024, 3:06 PM
aokblast retitled D43251: Update riscv-isa-sim to 2024-05-31 snapshot from Update riscv-isa-sim to 2023-12-23 snapshot to Update riscv-isa-sim to 2024-05-31 snapshot.
Jun 6 2024, 2:24 PM
aokblast updated the diff for D43251: Update riscv-isa-sim to 2024-05-31 snapshot.

Update to 2024-05-31

Jun 6 2024, 2:23 PM

Jun 5 2024

aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

So should we divided our patch into amd64/arm64 for further discussion about two cases. Or divided the patch into kernel/loader?

Jun 5 2024, 9:13 PM

Jun 3 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Jun 3 2024, 6:23 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Jun 3 2024, 6:14 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Jun 3 2024, 5:43 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Jun 3 2024, 4:40 PM
aokblast added a comment to D45120: Add bhyve uart raw tcp backend.

Fix it!!

Jun 3 2024, 4:30 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
Jun 3 2024, 4:30 PM

May 25 2024

aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
May 25 2024, 2:08 PM
aokblast added a comment to D45120: Add bhyve uart raw tcp backend.

I fix the previous error previously mentioned, and because uart_tcp_disconnect is a helper function and it parent has already lock it. I add comment to let everyone use this function in the future know this.

May 25 2024, 1:54 PM
aokblast updated the diff for D45120: Add bhyve uart raw tcp backend.
  • Add bhyve uart tcp backend
  • Add manual page
May 25 2024, 1:52 PM
aokblast updated the diff for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

Reset commit because I use wrong ID

May 25 2024, 1:51 PM
aokblast updated the diff for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.
  • Add bhyve uart tcp backend
  • Add manual page
May 25 2024, 1:49 PM

May 20 2024

aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

Sorry about my late reply. The patch Ed commit is the pre-request to ensure my patch work. The logic of my patch is the loader would load the build-id from elf file in .gnu.note.build-id section into memory. When kernel crashed, it generate coredump and the build-id loaded from the loader will dump into the coredump file at the same time. After that, when debugger load kernel and it's coredump, the debugger will try to find the elf file of module and its debug file. We can compare the build-id from memory with elf file. If they are different, we shouldn't load the debug file (because they are incompatible).

May 20 2024, 12:28 AM

May 11 2024

aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

LLDB refer build-id as UUID. Sorry about the imprecise word.

May 11 2024, 10:33 PM
aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

After my investigation, I discover that shstrtab section is not loaded into memory (because no SHF_ALLOC). Thus I cannot compare the section name with ".note.gnu.build-id". Besides, in link_elf_link_preload, the function don't open the file as link_elf_load_file but use all of the memory and preload information from boot1. Thus if I want to compare the section name, I should load the file, create temp memory space for it, and read file. Does it worth to a file in kernel just for compare a section name?

May 11 2024, 12:50 PM
aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

I understand your point, I will try not to modify the loader.

May 11 2024, 10:28 AM
aokblast updated the diff for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

Seperate to two patches

May 11 2024, 10:25 AM
aokblast updated the diff for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.
May 11 2024, 10:23 AM
aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.

For preloaded relocatable kernel module, I think the modification of loader is necessary as I discover SHT_NOTE section was not loaded by boot1 originally when the kernel module is preloaded.
For shared object, actually we can get the address of uuid when kernel is loaded. I modify the loader because I discover that CTORS pass the information from loader and I think I should follow it?

May 11 2024, 10:12 AM
aokblast added a comment to D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.
In D45161#1030112, @kib wrote:

It probably makes sense to split the change into two: one for loader, one for kernel.

Don't we need to ensure that notes are preserved, in the modules linker scripts? (sys/conf/ldscript.kmod.ARCH)

I assume that the debugger changes as well as adding UUIDS to the built modules would happen somewhere else?

May 11 2024, 9:56 AM
aokblast updated the diff for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.
  • Add uuid for module to prevent incompetable coredump loaded by debugger
  • Expose offset of uuid_addr and uuid_size in linker_file for debugger
May 11 2024, 7:20 AM
aokblast added a reviewer for D45161: Add uuid for module to prevent incompetable coredump loaded by debugger: lwhsu.
May 11 2024, 7:13 AM
aokblast updated the summary of D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.
May 11 2024, 7:13 AM
aokblast requested review of D45161: Add uuid for module to prevent incompetable coredump loaded by debugger.
May 11 2024, 7:09 AM

May 8 2024

aokblast abandoned D43514: Add Bhyve TCP raw socket on console.

Abandon because I submit the new one.

May 8 2024, 1:37 PM
aokblast updated the summary of D45120: Add bhyve uart raw tcp backend.
May 8 2024, 12:31 PM
aokblast retitled D45120: Add bhyve uart raw tcp backend from Add bhyve uart tcp backend to Add bhyve uart raw tcp backend.
May 8 2024, 12:28 PM
aokblast updated the summary of D45120: Add bhyve uart raw tcp backend.
May 8 2024, 12:28 PM
aokblast requested review of D45120: Add bhyve uart raw tcp backend.
May 8 2024, 12:26 PM

Apr 26 2024

aokblast added a comment to D44947: Move lock of uart frontend to uart backend in bhyve.

Fix it!

Apr 26 2024, 7:09 AM
aokblast updated the diff for D44947: Move lock of uart frontend to uart backend in bhyve.

Check the result of calloc

Apr 26 2024, 7:08 AM
aokblast abandoned D44966: Move lock of uart frontend to uart backend in bhyve.

Sorry I falsely create a duplicate patch...

Apr 26 2024, 7:05 AM
aokblast requested review of D44966: Move lock of uart frontend to uart backend in bhyve.
Apr 26 2024, 7:04 AM

Apr 25 2024

aokblast added reviewers for D44947: Move lock of uart frontend to uart backend in bhyve: markj, lwhsu.
Apr 25 2024, 4:14 PM
aokblast retitled D44947: Move lock of uart frontend to uart backend in bhyve from Move lock of uart frontend to uartbackend to Move lock of uart frontend to uart backend in bhyve.
Apr 25 2024, 4:12 PM
aokblast requested review of D44947: Move lock of uart frontend to uart backend in bhyve.
Apr 25 2024, 4:05 PM