Page MenuHomeFreeBSD

draft: add configuration base
Needs ReviewPublic

Authored by aokblast on Mar 1 2023, 1:08 PM.
Tags
None
Referenced Files
F82009229: D38838.id118124.diff
Wed, Apr 24, 11:49 AM
Unknown Object (File)
Tue, Apr 23, 3:37 PM
Unknown Object (File)
Feb 27 2024, 1:53 AM
Unknown Object (File)
Jan 10 2024, 8:36 AM
Unknown Object (File)
Dec 20 2023, 6:20 AM
Unknown Object (File)
Dec 10 2023, 7:26 PM
Unknown Object (File)
Nov 14 2023, 10:32 AM
Unknown Object (File)
Nov 11 2023, 9:56 AM
Subscribers

Details

Reviewers
lwhsu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50079
Build 46971: arc lint + arc unit

Event Timeline

This comment was removed by aokblast.

fix: recover shebang in make-memstick.sh

jrtc27 added inline comments.
etc/bsdinstall.example
1

Do we normally put examples in etc (that aren't comments in the actual file)? I would expect them to be in usr/share.

8

Fix

release/Makefile
193

METALOG must be kept in sync so -DNO_ROOT builds keep working fully

193

Don't add trailing whitespace

194

Don't add trailing whitespace

release/amd64/make-memstick.sh
70

Does -B little make sense for FAT? I thought it had a fixed endianness?

70

Why force it to FAT16?

70

-D isn't needed when you have no METALOG

78

Space before \

usr.sbin/bsdinstall/startbsdinstall
47

Use a loop, don't copy paste big chunks of code unnecessarily

Comment from @hrs: how about just using ESP partition?