Page MenuHomeFreeBSD

draft: add configuration base
Needs ReviewPublic

Authored by aokblast on Mar 1 2023, 1:08 PM.
Tags
None
Referenced Files
F109764927: D38838.diff
Sun, Feb 9, 6:01 AM
Unknown Object (File)
Thu, Feb 6, 6:54 AM
Unknown Object (File)
Mon, Jan 13, 12:11 AM
Unknown Object (File)
Jan 8 2025, 10:39 AM
Unknown Object (File)
Nov 21 2024, 7:04 AM
Unknown Object (File)
Nov 8 2024, 5:10 AM
Unknown Object (File)
Nov 5 2024, 6:44 AM
Unknown Object (File)
Oct 17 2024, 12:32 PM

Details

Reviewers
lwhsu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningrelease/amd64/make-memstick.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 50078
Build 46970: arc lint + arc unit

Event Timeline

This comment was removed by aokblast.

fix: recover shebang in make-memstick.sh

jrtc27 added inline comments.
etc/bsdinstall.example
2

Do we normally put examples in etc (that aren't comments in the actual file)? I would expect them to be in usr/share.

8

Fix

release/Makefile
193

METALOG must be kept in sync so -DNO_ROOT builds keep working fully

193

Don't add trailing whitespace

194

Don't add trailing whitespace

release/amd64/make-memstick.sh
71

Does -B little make sense for FAT? I thought it had a fixed endianness?

71

Why force it to FAT16?

71

-D isn't needed when you have no METALOG

79

Space before \

usr.sbin/bsdinstall/startbsdinstall
47

Use a loop, don't copy paste big chunks of code unnecessarily

Comment from @hrs: how about just using ESP partition?