Page MenuHomeFreeBSD

Add tests for wc(1)
AbandonedPublic

Authored by lwhsu on Jul 22 2022, 7:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 4:24 AM
Unknown Object (File)
Fri, Apr 26, 9:59 PM
Unknown Object (File)
Fri, Apr 26, 8:16 PM
Unknown Object (File)
Fri, Apr 26, 8:12 PM
Unknown Object (File)
Fri, Apr 26, 6:29 PM
Unknown Object (File)
Dec 20 2023, 6:03 AM
Unknown Object (File)
Sep 27 2023, 7:34 PM
Unknown Object (File)
Aug 14 2023, 10:05 AM

Details

Reviewers
ngie
aokblast
Group Reviewers
tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46540
Build 43429: arc lint + arc unit

Event Timeline

lwhsu retitled this revision from Add tests for wc to Add tests for wc(1).Jul 22 2022, 7:13 AM
ngie requested changes to this revision.Jul 22 2022, 2:01 PM
ngie added a subscriber: ngie.
ngie added inline comments.
usr.bin/wc/tests/04_zh-TW.in
2

Does this require libiconv or any special build options to test?

usr.bin/wc/tests/wc_test.sh
2

Please omit -- it gets added by the build.

The copyright header is missing BTW (it doesn't matter a ton -- just a minor inconsistency).

3–84
  • Please don't use camelCase names.
  • Please avoid line continuations like this -- it makes the descriptions more difficult to grep for.
27

I might name this "total_bytes_ascii"

46

I might name this "total_bytes_utf8" (it matters more that non-ASCII is used than the specific locale that's used).

This revision now requires changes to proceed.Jul 22 2022, 2:01 PM
  • Fix naming convension for wc test case
lwhsu abandoned this revision.
lwhsu edited reviewers, added: aokblast; removed: lwhsu.
lwhsu marked 3 inline comments as done.