acpi_cpu: Bring back setting BM_RLD on resume
ClosedPublic
Actions

Authored by obiwac on Wed, Nov 11, 11:11 AM.

Project Tags

None

Referenced Files

	F177464957: D61431.1794486482.diff
	Wed, Nov 11, 12:28 PM

	F177464935: D61431.1794486251.diff
	Wed, Nov 11, 12:24 PM

	F177464802: D61431.1794485713.diff
	Wed, Nov 11, 12:15 PM

	F177464766: D61431.1794485534.diff
	Wed, Nov 11, 12:12 PM

	F177464659: D61431.1794485171.diff
	Wed, Nov 11, 12:06 PM

	F177464068: D61431.1794482189.diff
	Wed, Nov 11, 11:16 AM

	F177464066: D61431.1794482183.diff
	Wed, Nov 11, 11:16 AM

	F177464064: D61431.1794482176.diff
	Wed, Nov 11, 11:16 AM

Subscribers

imp

Details

Reviewers

olce

Commits

rGff3f704d922a: acpi_cpu: Bring back setting BM_RLD on resume

Summary

enable_idle(), which was called on resume before 427747fc16c9
("acpi_cpu: No longer disable idle during suspend"), also set BM_RLD.

This commit brings back just setting BM_RLD on resume because some
firmware might not be doing this itself on some machines.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

obiwac created this revision.Wed, Nov 11, 11:11 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 11, 11:11 AM

obiwac requested review of this revision.Wed, Nov 11, 11:11 AM

Harbormaster completed remote builds in B78975: Diff 192213.Wed, Nov 11, 11:11 AM

Oh, sorry to have missed that too. :-)

This revision is now accepted and ready to land.Wed, Nov 11, 11:22 AM

I will say it may make more sense to do this in the S3 path in sys/dev/acpica/acpi.c, because this is only relevant for S3 and we only need to do this once, not for every acpi_cpu that resumes. I will commit this as is because it restores the previous behaviour, but I'll add a comment mentioning this.