Page MenuHomeFreeBSD

Src CommittersOrganization
ActivePublic

Recent Activity

Yesterday

se closed D17935: Remove CTM from 13-CURRENT.
Sat, Dec 15, 4:53 PM · Src Committers

Mon, Dec 3

avg added a member for Src Committers: avg.
Mon, Dec 3, 1:24 PM

Nov 12 2018

se added a parent revision for D17935: Remove CTM from 13-CURRENT: D17969: Prepare for removal of CTM from FreeBSD-13.
Nov 12 2018, 11:03 PM · Src Committers
se added a comment to D17935: Remove CTM from 13-CURRENT.

Am 12.11.18 um 19:29 schrieb rgrimes:

rgrimes added a comment.

In D17935#383667 <https://reviews.freebsd.org/D17935#383667>, @imp wrote:

> I'd do a separate commit that just says 'CTM will move to ports in
> FreeBSD 13' in the ctm man page and get that merged before 12.0R (so
> ASAP).

Please do both the man page, and actually more importantly make the binary
spit out a warning that it is going away in 13, this to be merged to
stable/12 asap.  Man pages simply do not get peoples attention.  Also make
sure to mark this commits as relnotes: y.

Since I am involved now I can not approve it as re@, but it should see no
resistance.
Nov 12 2018, 9:53 PM · Src Committers
rgrimes added a comment to D17935: Remove CTM from 13-CURRENT.
In D17935#383667, @imp wrote:

I'd do a separate commit that just says 'CTM will move to ports in FreeBSD 13' in the ctm man page and get that merged before 12.0R (so ASAP).

Nov 12 2018, 6:29 PM · Src Committers
imp accepted D17935: Remove CTM from 13-CURRENT.

Looks good to me. I'd do a separate commit that just says 'CTM will move to ports in FreeBSD 13' in the ctm man page and get that merged before 12.0R (so ASAP).
I agree with Rob we should have an updating entry, and a line in the release notes (relnotes: yes should do that).
I don't think we need to do anything more other than commit this review after a few month (there's no rush, and safely after the turbulence 12.0R is mildly better), but I'll give that feedback and leave the timing to your discretion.

Nov 12 2018, 6:12 PM · Src Committers
bcr accepted D17935: Remove CTM from 13-CURRENT.

OK from manpages.

Nov 12 2018, 3:22 PM · Src Committers

Nov 11 2018

rgrimes added a reviewer for D17935: Remove CTM from 13-CURRENT: rgrimes.

There should be an UPDATING entry to tell people to go get the port.. This has a 0 length deprecation notice if we just go rip it out now. I would support first adding a gonein(13) and merging that to release 12 or 12.1. That should be done first, before this. Have the ports builders made a pkg avaliable for ^/head yet, I see that you can build it, but can pkg get one yet? I would not want to remove it until a binary can be fetched via pkg.

Nov 11 2018, 3:53 PM · Src Committers

Nov 10 2018

se created D17935: Remove CTM from 13-CURRENT.
Nov 10 2018, 12:24 PM · Src Committers

Jul 23 2018

khanzf_gmail.com updated the diff for D15692: Adding rtl8188ee driver to rtwn(4).

Fixed a bug in the SRCTOP variable, for some reason it was .SRCTOP with a preceding period character.

Jul 23 2018, 1:24 AM · Src Committers

Jul 13 2018

cem added a comment to D16060: Maintenance's commit of Microsemi smartpqi driver.

Please stop adding redundant prototypes for the same function — it breaks the GCC build. The tagged lines below are not exhaustive.

Jul 13 2018, 10:40 PM · Src Committers

Jul 11 2018

sbruno closed D16060: Maintenance's commit of Microsemi smartpqi driver.
Jul 11 2018, 4:44 PM · Src Committers
sbruno accepted D16060: Maintenance's commit of Microsemi smartpqi driver.
Jul 11 2018, 4:42 PM · Src Committers

Jul 9 2018

mav accepted D16060: Maintenance's commit of Microsemi smartpqi driver.

I have no objections.

Jul 9 2018, 8:18 PM · Src Committers
deepak.ukey_microsemi.com updated the diff for D16060: Maintenance's commit of Microsemi smartpqi driver.

Incorporated the changes according to review comments.

Jul 9 2018, 7:33 AM · Src Committers

Jul 5 2018

khanzf_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

Hi all,
Has anyone had a chance to review this?

Jul 5 2018, 10:09 PM · Src Committers

Jul 3 2018

mav added a comment to D16060: Maintenance's commit of Microsemi smartpqi driver.

On a quick look I spotted number of style issues you may fix.

Jul 3 2018, 5:03 PM · Src Committers
sbruno added reviewers for D16060: Maintenance's commit of Microsemi smartpqi driver: scottl, mav.
Jul 3 2018, 3:57 PM · Src Committers

Jul 1 2018

khanzf_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

Hi all, any views done on this? Its been a little less than a month :)

Jul 1 2018, 10:14 PM · Src Committers

Jun 29 2018

deepak.ukey_microsemi.com created D16060: Maintenance's commit of Microsemi smartpqi driver.
Jun 29 2018, 11:38 AM · Src Committers

Jun 25 2018

khanzf_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

Hey @s3erios_gmail.com, have you had a chance to poke at this again?

Jun 25 2018, 9:45 PM · Src Committers

Jun 21 2018

khanzf_gmail.com retitled D15692: Adding rtl8188ee driver to rtwn(4) from Updated per guidance from Andriy Voskoboinyk from D15692 to Adding rtl8188ee driver to rtwn(4).
Jun 21 2018, 7:39 PM · Src Committers

Jun 18 2018

khanzf_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

The previous commit was a diff from the previous diff.
That was a mistake, I am still getting used to the tooling.
This is a diff from HEAD.

Jun 18 2018, 9:34 PM · Src Committers
khanzf_gmail.com updated the diff for D15692: Adding rtl8188ee driver to rtwn(4).

Attached Tx methods from rtl8192ce

Jun 18 2018, 9:33 PM · Src Committers
khanzf_gmail.com retitled D15692: Adding rtl8188ee driver to rtwn(4) from Adding rtl8188ee for rtwn(4) adding rtl8188ee to Adding rtl8188ee support for rtwn(4).
Jun 18 2018, 8:42 AM · Src Committers
khanzf_gmail.com updated the diff for D15692: Adding rtl8188ee driver to rtwn(4).

Attached Tx methods from rtl8192ce

Jun 18 2018, 4:55 AM · Src Committers

Jun 12 2018

s3erios_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

Can you attach next patches with context (like it is described in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview )

Jun 12 2018, 10:33 AM · Src Committers

Jun 8 2018

thj added a reviewer for D15692: Adding rtl8188ee driver to rtwn(4): thj.
Jun 8 2018, 7:45 AM · Src Committers
kevans added a reviewer for D15692: Adding rtl8188ee driver to rtwn(4): s3erios_gmail.com.
Jun 8 2018, 5:08 AM · Src Committers

Jun 7 2018

khanzf_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

I retrieved the rtl8188efw.bin firmware from here: https://github.com/lwfinger/rtlwifi_new/tree/master/firmware/rtlwifi
I uuencoded it with the following command:
uuencode rtl8188efw.bin rtwn-rtl8188eefw.fw.uu > rtwn-rtl8188eefw.fw.uu

Jun 7 2018, 4:58 PM · Src Committers
khanzf_gmail.com created D15692: Adding rtl8188ee driver to rtwn(4).
Jun 7 2018, 4:38 PM · Src Committers

May 6 2018

pfg closed D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 6 2018, 9:29 PM · Src Committers
pfg removed a reviewer for D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime(): emaste.

For the record, his patch first appeared in PR 217560, it's unrelated to the Bug, so I asked for an independent CR.
I will take care of it.

May 6 2018, 9:22 PM · Src Committers

May 4 2018

pfg accepted D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().

Approved.
Hoping someone else can do the honors though .. I did somethig dumb with my partition table.

May 4 2018, 6:08 PM · Src Committers
damjan.jov_gmail.com created D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 4 2018, 5:53 PM · Src Committers

Mar 12 2018

lattera-gmail.com added a watcher for Src Committers: lattera-gmail.com.
Mar 12 2018, 7:06 PM

Jul 22 2017

kuankuan.y_gmail.com added a watcher for Src Committers: kuankuan.y_gmail.com.
Jul 22 2017, 9:18 AM

Jan 16 2017

sevan added a comment to D9095: Switch ppp(8) to use the "modern" DES_ functions.

I have a cardbus 3G modem which I can try it with. If only I could find it. :)

Jan 16 2017, 12:50 AM · Src Committers

Jan 15 2017

jilles added a comment to D9095: Switch ppp(8) to use the "modern" DES_ functions.

Apart from the one minor issue I do not see problems (which does not mean there aren't any).

Jan 15 2017, 7:10 PM · Src Committers

Jan 8 2017

sevan retitled D9095: Switch ppp(8) to use the "modern" DES_ functions from to Switch ppp(8) to use the "modern" DES_ functions.
Jan 8 2017, 11:26 PM · Src Committers

Feb 27 2016

jhibbits abandoned D5384: Add an RF_CACHEABLE flag for rman activations.

Abandoning in favor of D5471

Feb 27 2016, 4:31 PM · Src Committers

Feb 23 2016

jhb added a comment to D5384: Add an RF_CACHEABLE flag for rman activations.

I've thought about having a RF_WC for WC mappings as well, but I'd really rather finish bus_map_resource() and use that for handling non-default memory attributes instead.

Feb 23 2016, 7:02 PM · Src Committers

Feb 22 2016

jhibbits retitled D5384: Add an RF_CACHEABLE flag for rman activations from to Add an RF_CACHEABLE flag for rman activations.
Feb 22 2016, 1:38 AM · Src Committers

Feb 11 2016

jhibbits added a member for Src Committers: jhibbits.
Feb 11 2016, 4:56 PM

Oct 6 2015

bdrewery edited P78 truss linux.
Oct 6 2015, 10:28 PM · Src Committers

May 16 2015

eadler added members for Src Committers: jhb, dim, gleb, glebius, garga.
May 16 2015, 10:57 PM
eadler added members for Src Committers: bapt, bdrewery.
May 16 2015, 10:56 PM
eadler added a member for Src Committers: hselasky.
May 16 2015, 10:54 PM