Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (231 w, 3 h)

Recent Activity

Fri, Oct 12

delphij added inline comments to D17541: update ZFS to note support of extended attributes.
Fri, Oct 12, 10:55 PM

Wed, Sep 26

delphij added inline comments to D15119: Handle overflow of uid or gid in arguments for chown.
Wed, Sep 26, 6:33 PM · Contributor Reviews (base)

Tue, Sep 25

delphij committed rS338923: Partial MFC of r338542:.
Partial MFC of r338542:
Tue, Sep 25, 5:18 AM

Sep 14 2018

delphij accepted D17047: Fortuna: Add failpoints to simulate initial seeding conditions.
Sep 14 2018, 5:03 PM
delphij added reviewers for D17047: Fortuna: Add failpoints to simulate initial seeding conditions: O3: Kernel Random Numbers Generator, secteam.
Sep 14 2018, 5:03 PM

Sep 11 2018

delphij accepted D17118: Add OPIE deprecation notice.

I think you might want to bump the date (currently read as "January 10, 1995") when committing but it looks otherwise fine to me.

Sep 11 2018, 4:48 PM

Sep 10 2018

delphij added a comment to D16857: Introduce certctl(8).

Minor nit: could you please quote variables with {} (e.g. $VAR -> ${VAR})?

Sep 10 2018, 5:58 PM

Sep 9 2018

delphij committed rS338542: random(4): Squash non-error timeout codes from tsleep(9)..
random(4): Squash non-error timeout codes from tsleep(9).
Sep 9 2018, 5:12 PM
delphij closed D17049: random(4): Squash non-error timeout codes from tsleep(9).
Sep 9 2018, 5:12 PM

Sep 8 2018

delphij committed rS338531: MFC r338126: MFV r338092: ntp 4.2.8p12..
MFC r338126: MFV r338092: ntp 4.2.8p12.
Sep 8 2018, 4:10 AM
delphij committed rS338530: MFC r338126: MFV r338092: ntp 4.2.8p12..
MFC r338126: MFV r338092: ntp 4.2.8p12.
Sep 8 2018, 4:10 AM

Sep 7 2018

delphij committed rD52232: Update my key..
Update my key.
Sep 7 2018, 10:37 AM

Sep 6 2018

delphij accepted D17050: getentropy(3): Trap non-API errnos from getrandom(2) and abort.

LGTM

Sep 6 2018, 8:38 PM
delphij accepted D16986: fortuna: Drop global lock to zero stack variables.

LGTM.

Sep 6 2018, 8:10 PM
delphij added a comment to D17049: random(4): Squash non-error timeout codes from tsleep(9).

LGTM, thanks!

Sep 6 2018, 12:24 PM
delphij accepted D17049: random(4): Squash non-error timeout codes from tsleep(9).
Sep 6 2018, 12:24 PM
delphij added a reviewer for D17049: random(4): Squash non-error timeout codes from tsleep(9): secteam.
Sep 6 2018, 12:24 PM

Sep 3 2018

delphij committed rS338441: MFC r337522:.
MFC r337522:
Sep 3 2018, 6:57 AM
delphij committed rS338440: MFC r337522:.
MFC r337522:
Sep 3 2018, 6:55 AM
delphij committed rS338439: MFC r336754: Improve --strip-trailing-cr handling..
MFC r336754: Improve --strip-trailing-cr handling.
Sep 3 2018, 6:36 AM

Sep 1 2018

delphij accepted D16983: random(4): Correct a bare zero to the appropriate enum.

Looks reasonable.

Sep 1 2018, 5:54 AM
delphij accepted D16982: random(4): Translate a comment requirement into a compile-time invariant.

LGTM.

Sep 1 2018, 5:44 AM
delphij accepted D16984: Fortuna: Fix a race to prevent reseed spamming.

This is reasonable.

Sep 1 2018, 5:42 AM

Aug 29 2018

delphij accepted D16937: Fortuna: trivial static variable cleanup.
Aug 29 2018, 8:55 PM
delphij accepted D16937: Fortuna: trivial static variable cleanup.
Aug 29 2018, 8:55 PM
delphij accepted D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Aug 29 2018, 8:54 PM
delphij accepted D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Aug 29 2018, 8:54 PM
delphij added a comment to D16943: Re-add the kstat.zfs.misc.arcstats.other_size sysctl..

LGTM (but are we expecting COMPAT_FREEBSD11 defined in places where FreeBSD is not defined?)

Aug 29 2018, 7:03 PM
delphij added a comment to D16935: rijndael (AES): Avoid leaking sensitive data on kernel stack.

Mostly LGTM.

Aug 29 2018, 6:22 PM
delphij accepted D16936: Fortuna: Add trivial assert to match FS&K definition.
Aug 29 2018, 5:49 PM
delphij added a comment to D16937: Fortuna: trivial static variable cleanup.

This would increase stack usage for /dev/random read by 32 bytes, but I think it's small enough and make the code easier to reason for MP safety (the buffer is not meant to be shared by two different threads), so consider this a LGTM from secteam@ as long as there is no objection raised by September 1st.

Aug 29 2018, 5:47 PM

Aug 26 2018

delphij committed rS338331: Remove arc4random_stir and arc4random_addrandom from stdlib.h..
Remove arc4random_stir and arc4random_addrandom from stdlib.h.
Aug 26 2018, 6:05 PM
delphij committed rP478110: dns/samba-nsupdate: Stop using arc4random_addrandom..
dns/samba-nsupdate: Stop using arc4random_addrandom.
Aug 26 2018, 8:51 AM
delphij committed rP478109: net/samba48: Do not use arc4random_stir..
net/samba48: Do not use arc4random_stir.
Aug 26 2018, 8:46 AM
delphij committed rP478108: security/heimdal: Don't call arc4random_stir..
security/heimdal: Don't call arc4random_stir.
Aug 26 2018, 8:36 AM
delphij committed rP478107: textproc/htmldoc: Do not use arc4random_stir..
textproc/htmldoc: Do not use arc4random_stir.
Aug 26 2018, 8:26 AM
delphij committed rP478106: net/relayd: Stop using arc4random_stir.
net/relayd: Stop using arc4random_stir
Aug 26 2018, 8:17 AM
delphij committed rP478105: net-p2p/gtk-gnutella: Do not call arc4random_stir or arc4random_addrandom..
net-p2p/gtk-gnutella: Do not call arc4random_stir or arc4random_addrandom.
Aug 26 2018, 8:07 AM
delphij committed rP478104: devel/libevent: Don't use arc4random_addrandom..
devel/libevent: Don't use arc4random_addrandom.
Aug 26 2018, 7:57 AM
delphij committed rP478103: mail/exim: Stop using arc4random_stir..
mail/exim: Stop using arc4random_stir.
Aug 26 2018, 7:46 AM

Aug 23 2018

delphij accepted D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..

Looks good to me. @jmg do you have any concerns if this is landed as-is?

Aug 23 2018, 6:12 PM
delphij accepted D16872: Fix excessive reseed rate in random(4)..

LGTM from an earlier review.

Aug 23 2018, 5:08 PM
delphij added inline comments to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Aug 23 2018, 5:07 PM
delphij accepted D16860: Use arc4rand() instead of read_random().

It seems that the other read_random instances in network stack should do the same as well (probably beyond scope of this changeset though).

Aug 23 2018, 4:52 PM
delphij accepted D16866: Fix excessive reseeding in random(4)..

LGTM. cem@ or markm@, could you please commit this before code freeze?

Aug 23 2018, 4:38 PM
delphij committed rS338231: Diff reduction with production version, no functional change..
Diff reduction with production version, no functional change.
Aug 23 2018, 2:22 AM
delphij committed rS338230: Pass UNAME_r to describes-run.sh..
Pass UNAME_r to describes-run.sh.
Aug 23 2018, 2:22 AM
delphij committed rS338228: Diff reduction with production configuration (update build release list)..
Diff reduction with production configuration (update build release list).
Aug 23 2018, 2:20 AM
delphij committed rS338226: Use noexec when mounting memory disk..
Use noexec when mounting memory disk.
Aug 23 2018, 2:17 AM
delphij committed rS338225: Support multiple recipients..
Support multiple recipients.
Aug 23 2018, 2:15 AM
delphij committed rS338224: join(1) at r320210 changed -v's behavior to output the join field as first.
join(1) at r320210 changed -v's behavior to output the join field as first
Aug 23 2018, 2:15 AM

Aug 21 2018

delphij accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

LGTM.

Aug 21 2018, 10:31 PM
delphij accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

LGTM as-is, but with some minor suggestions inline.

Aug 21 2018, 8:26 PM
delphij requested changes to D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

I think the direction is good and the changeset looks good to me in principal. Could you please make a change so it would print errline, which would make it easier for administrators to find out where the issue is?

Aug 21 2018, 6:42 PM
delphij committed rS338126: MFV r338092: ntp 4.2.8p12..
MFV r338092: ntp 4.2.8p12.
Aug 21 2018, 2:38 AM

Aug 20 2018

delphij committed rS338093: Tag ntp 4.2.8p12..
Tag ntp 4.2.8p12.
Aug 20 2018, 6:10 AM
delphij committed rS338092: Vendor import of ntp-4.2.8p12..
Vendor import of ntp-4.2.8p12.
Aug 20 2018, 6:08 AM
delphij committed rS338084: In r331279 the code used ENOSYS to check the existence of getrandom(2)..
In r331279 the code used ENOSYS to check the existence of getrandom(2).
Aug 20 2018, 2:18 AM
delphij closed D16807: Use osreldate to check the existence of getrandom(2)..
Aug 20 2018, 2:18 AM
delphij updated the diff for D16807: Use osreldate to check the existence of getrandom(2)..

Oops, omit change in stdlib.h.

Aug 20 2018, 2:02 AM
delphij updated the diff for D16807: Use osreldate to check the existence of getrandom(2)..

Update comment, no functional change.

Aug 20 2018, 2:02 AM
delphij added inline comments to D16807: Use osreldate to check the existence of getrandom(2)..
Aug 20 2018, 1:56 AM
delphij created D16807: Use osreldate to check the existence of getrandom(2)..
Aug 20 2018, 12:44 AM

Aug 19 2018

delphij committed rS338061: Bump __FreeBSD_version after r338059 (Chacha20 based arc4random(3).
Bump __FreeBSD_version after r338059 (Chacha20 based arc4random(3)
Aug 19 2018, 5:47 PM
delphij committed rS338059: Update userland arc4random() with OpenBSD's Chacha20 based arc4random()..
Update userland arc4random() with OpenBSD's Chacha20 based arc4random().
Aug 19 2018, 5:41 PM
delphij closed D16760: Use Chacha20 for userland arc4random() and friends.
Aug 19 2018, 5:41 PM
delphij added a comment to D16760: Use Chacha20 for userland arc4random() and friends.

Addressed contrib/ntp/lib/isc/random.c issue; heimdal part would be left as-is for now (I think we can use HAVE_RAND but let's do it in a follow up commit).

Aug 19 2018, 5:17 PM
delphij updated the diff for D16760: Use Chacha20 for userland arc4random() and friends.

Remove #else in contrib/ntp/lib/isc/random.c.

Aug 19 2018, 5:16 PM
delphij updated the diff for D16760: Use Chacha20 for userland arc4random() and friends.

Remove manual page for arc4random_stir and arc4random_addrandom.

Aug 19 2018, 9:29 AM
delphij updated the summary of D16760: Use Chacha20 for userland arc4random() and friends.
Aug 19 2018, 9:03 AM
delphij updated the diff for D16760: Use Chacha20 for userland arc4random() and friends.

Drop chacha_private.h and address various reviewer comments.

Aug 19 2018, 8:53 AM
delphij requested review of D16760: Use Chacha20 for userland arc4random() and friends.
Aug 19 2018, 8:53 AM

Aug 18 2018

delphij committed rS338011: Workaround ECAPMODE for kernels between revision [331280, 337999).
Workaround ECAPMODE for kernels between revision [331280, 337999)
Aug 18 2018, 8:37 AM
delphij committed rS338011: Workaround ECAPMODE for kernels between revision [331280, 337999).
Workaround ECAPMODE for kernels between revision [331280, 337999)
Aug 18 2018, 8:32 AM
delphij committed rS337999: Regen after r337998..
Regen after r337998.
Aug 18 2018, 6:34 AM
delphij committed rS337998: getrandom(2) should not be restricted in capability mode..
getrandom(2) should not be restricted in capability mode.
Aug 18 2018, 6:32 AM
delphij committed rS337997: Split arc4random_uniform into it's own file and sync with OpenBSD..
Split arc4random_uniform into it's own file and sync with OpenBSD.
Aug 18 2018, 6:20 AM

Aug 17 2018

delphij planned changes to D16760: Use Chacha20 for userland arc4random() and friends.

Will commit the arc4random_uniform portion of change (which contained some trivial changes to type to make the code C99 compliant) to reduce the size of this changeset and revise to address some comments with plan outlined inline.

Aug 17 2018, 10:26 PM
delphij added reviewers for D16760: Use Chacha20 for userland arc4random() and friends: emaste, devnexen_gmail.com, op, naddy, holger_gh_freyther.de, lwhsu.
Aug 17 2018, 8:30 AM
delphij created D16760: Use Chacha20 for userland arc4random() and friends.
Aug 17 2018, 8:27 AM

Aug 15 2018

delphij committed rD52127: Add SA-18:09-SA-18:11, refresh SA-18:08..
Add SA-18:09-SA-18:11, refresh SA-18:08.
Aug 15 2018, 5:18 AM
delphij committed rS337832: Fix unauthenticated EAPOL-Key decryption vulnerability. [SA-18:11.hostapd].
Fix unauthenticated EAPOL-Key decryption vulnerability. [SA-18:11.hostapd]
Aug 15 2018, 5:05 AM
delphij committed rS337831: MFC r337819 (cy@): MFV r337818: WPA: Ignore unauthenticated encrypted EAPOL-Key.
MFC r337819 (cy@): MFV r337818: WPA: Ignore unauthenticated encrypted EAPOL-Key
Aug 15 2018, 5:04 AM
delphij committed rS337829: Revis manual pages. [SA-18:08.tcp].
Revis manual pages. [SA-18:08.tcp]
Aug 15 2018, 2:31 AM
delphij committed rS337828: Revis manual pages. [SA-18:08.tcp].
Revis manual pages. [SA-18:08.tcp]
Aug 15 2018, 2:30 AM

Aug 14 2018

delphij added a comment to D16706: Replace userspace arc4random(3) implementation with Chacha20.
In D16706#355122, @cem wrote:

Hi,

Thanks for the quick feedback!

for example the use of MAP_INHERIT_ZERO or FreeBSD's INHERIT_ZERO to detect fork

That would be an additional enhancement, no? I don't think this change introduces a regression there.

Aug 14 2018, 6:23 AM
delphij added a comment to D16706: Replace userspace arc4random(3) implementation with Chacha20.

I think we should come up with a design first, it's important not to repeat other's errors. (I have a version based on earlier OpenBSD arc4random() [1] that was used in a disk wiper which still suffers from a few issues that OpenBSD have fixed in their later versions, for example the use of MAP_INHERIT_ZERO or FreeBSD's INHERIT_ZERO to detect fork.). My recommendation is to start over from a more recent OpenBSD version.

Aug 14 2018, 5:42 AM

Aug 12 2018

delphij committed rS337692: Remove mention of FreeBSD 9.x which is EoL'ed now..
Remove mention of FreeBSD 9.x which is EoL'ed now.
Aug 12 2018, 9:44 PM
delphij committed rS337691: Remove mention of FreeBSD 9.x which is EoL'ed now..
Remove mention of FreeBSD 9.x which is EoL'ed now.
Aug 12 2018, 9:42 PM

Aug 9 2018

delphij accepted D16552: random: Add PowerPC 'darn' instruction entropy source.

LGTM'ing so we don't become a blocker (the code construction is similar to ivy.c). Please go ahead with commit after 14th August if nobody raises problems that they thinks should block the commit.

Aug 9 2018, 7:12 AM
delphij accepted D16602: net/openldap24-server: Fix PR/229939 - Start slapd before kdc.

LGTM, thanks!

Aug 9 2018, 5:12 AM
delphij committed rS337522: In read_zones(), check if the file name actually fit in the buffer.
In read_zones(), check if the file name actually fit in the buffer
Aug 9 2018, 2:47 AM
delphij closed D16595: Always terminate string with nul..
Aug 9 2018, 2:47 AM
delphij committed rS337521: MFC r336121+r336127(cem): Don't delete outfile unconditionally..
MFC r336121+r336127(cem): Don't delete outfile unconditionally.
Aug 9 2018, 2:27 AM

Aug 8 2018

delphij accepted D16615: msdosfs: fixes for Undefined Behavior..

LGTM. Thanks!

Aug 8 2018, 5:00 AM

Aug 7 2018

delphij requested changes to D16602: net/openldap24-server: Fix PR/229939 - Start slapd before kdc.
Aug 7 2018, 5:45 PM

Aug 6 2018

delphij committed rD52082: Add SA-18:08.tcp..
Add SA-18:08.tcp.
Aug 6 2018, 8:45 PM
delphij committed rS337395: Bump patch level and document them..
Bump patch level and document them.
Aug 6 2018, 8:39 PM
delphij accepted D16602: net/openldap24-server: Fix PR/229939 - Start slapd before kdc.

LGTM (please verify that rcorder /usr/local/etc/rc.d/* /etc/rc.d/* > /dev/null won't give cycles before committing).

Aug 6 2018, 4:07 PM

Aug 5 2018

delphij added a comment to D16595: Always terminate string with nul..
In D16595#352569, @imp wrote:

Normally, these files aren't in the control of users...

Aug 5 2018, 5:15 PM