Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (282 w, 5 d)

Recent Activity

Sat, Oct 12

delphij committed rP514353: Return this to pool. I no longer use this port anymore..
Return this to pool. I no longer use this port anymore.
Sat, Oct 12, 8:29 PM

Fri, Oct 11

delphij accepted D21979: wbwd: move to superio(4) bus.

Looks fine to me, but I no longer have the hardware to actually test the changes, iXsystems may be able to help with that.

Fri, Oct 11, 10:03 PM

Wed, Oct 2

delphij committed rP513545: x11/slim: Permit setting a default xsession from .xinitrc..
x11/slim: Permit setting a default xsession from .xinitrc.
Wed, Oct 2, 5:04 AM

Tue, Oct 1

delphij added a reviewer for D21865: avoid compiling in hpt* drivers containing binary blobs: releng.

I'm mostly in favor of the change (smaller kernel size, etc.), but since we are removing driver from GENERIC, it's better if we can provide a mechanism to load the driver on demand, or a binary update can easily brick the system...

Tue, Oct 1, 9:55 PM
delphij added a comment to D21855: OpenLDAP refreshment.

Why are we making this change? It was somewhat intentional to not enable SASL by default (to reduce attack surface, e.g. CVE-2019-13565), is this functionality being used by a lot of consumers?

Tue, Oct 1, 8:40 PM

Mon, Sep 30

delphij committed rS352902: MFS r352872: MFC r351802:.
MFS r352872: MFC r351802:
Mon, Sep 30, 2:32 PM
delphij committed rS352891: MFC r351325:.
MFC r351325:
Mon, Sep 30, 7:27 AM
delphij committed rS352890: MFC r351417: r351417: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED.
MFC r351417: r351417: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED
Mon, Sep 30, 6:38 AM
delphij committed rS352888: MFC r351501: MFV r351500: Fix CLEAR_HASH macro to be usable as a single.
MFC r351501: MFV r351500: Fix CLEAR_HASH macro to be usable as a single
Mon, Sep 30, 6:04 AM
delphij committed rS352887: MFC r351382:.
MFC r351382:
Mon, Sep 30, 5:44 AM

Sun, Sep 29

delphij committed rS352873: MFC r351802:.
MFC r351802:
Sun, Sep 29, 8:08 PM
delphij committed rS352872: MFC r351802:.
MFC r351802:
Sun, Sep 29, 8:06 PM

Thu, Sep 26

delphij added inline comments to D21805: freebsd-update: rehash certs as needed.
Thu, Sep 26, 9:02 PM

Wed, Sep 25

delphij committed rP512800: MFH: r512162, r512335.
MFH: r512162, r512335
Wed, Sep 25, 5:45 PM

Wed, Sep 18

delphij accepted D21531: Use zlib's uncompress function for simpler code..

LGTM.

Wed, Sep 18, 4:38 AM

Sun, Sep 15

delphij committed rS352364: Avoid mixing cluster numbers and sector numbers. Makes code more readable..
Avoid mixing cluster numbers and sector numbers. Makes code more readable.
Sun, Sep 15, 7:42 PM
delphij closed D21375: Remove zlib 1.0.4 from kernel..

Landed as rS351480.

Sun, Sep 15, 5:37 PM

Sep 5 2019

delphij accepted D21523: Test for ns_parserr() and got a heap-buffer-overflow.
Sep 5 2019, 5:56 AM

Sep 4 2019

delphij committed rS351802: Correct overflow logic in fullpath()..
Correct overflow logic in fullpath().
Sep 4 2019, 4:44 AM

Sep 3 2019

delphij accepted D21496: pkgbase: Move the bootloader related files to a new FreeBSD-bootloader package.

Would like a different @releng member to take a look if possible, but the change looks reasonable to me.

Sep 3 2019, 4:10 PM
delphij committed rS351737: MFC r351205: Use calloc()..
MFC r351205: Use calloc().
Sep 3 2019, 7:02 AM
delphij committed rS351735: MFC r351204:.
MFC r351204:
Sep 3 2019, 6:52 AM

Aug 31 2019

delphij added a comment to D21479: WIP: Make fsck_msdosfs use less memory..

Remove unused field.

Aug 31 2019, 10:01 AM
delphij added a comment to D21479: WIP: Make fsck_msdosfs use less memory..

Fix accounting for NumFree.

Aug 31 2019, 9:59 AM
delphij retitled D21479: WIP: Make fsck_msdosfs use less memory. from WIP: Make fsck_msdosfs use less memory. Not yet review-ready. to WIP: Make fsck_msdosfs use less memory..

Fixed a couple of bugs.

Aug 31 2019, 9:54 AM
delphij created D21479: WIP: Make fsck_msdosfs use less memory..
Aug 31 2019, 8:30 AM

Aug 30 2019

delphij committed rS351623: Remove unneeded blank line. No functional change..
Remove unneeded blank line. No functional change.
Aug 30 2019, 6:06 AM

Aug 26 2019

delphij committed rS351502: Comment boot block checks and perform additional sanity checks:.
Comment boot block checks and perform additional sanity checks:
Aug 26 2019, 6:41 AM
delphij committed rS351501: MFV r351500: Fix CLEAR_HASH macro to be usable as a single statement..
MFV r351500: Fix CLEAR_HASH macro to be usable as a single statement.
Aug 26 2019, 12:46 AM

Aug 25 2019

delphij committed rS351500: Import vendor commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:.
Import vendor commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:
Aug 25 2019, 11:52 PM
delphij committed rD53326: Document __FreeBSD_version 1300041..
Document __FreeBSD_version 1300041.
Aug 25 2019, 5:16 PM
delphij committed rS351480: Remove zlib 1.0.4 from kernel..
Remove zlib 1.0.4 from kernel.
Aug 25 2019, 5:13 PM
delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

Remove D21408 portion of change.

Aug 25 2019, 7:52 AM
delphij committed rS351477: GZIO: Update to use zlib 1.2.11..
GZIO: Update to use zlib 1.2.11.
Aug 25 2019, 7:51 AM
delphij closed D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Aug 25 2019, 7:51 AM
D21408: GZIO to update zlib version 1.0.4 to 1.2.11. is now accepted and ready to land.
Aug 25 2019, 7:47 AM

Aug 24 2019

delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

@markj -- do you have some suggestion on how should we test subr_compressor.c changes?

Aug 24 2019, 7:06 PM
delphij added a reviewer for D21375: Remove zlib 1.0.4 from kernel.: markj.
Aug 24 2019, 7:06 PM
delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

PTAL.

Aug 24 2019, 7:02 PM
delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

Fix subr_compressor.c.

Aug 24 2019, 7:02 PM

Aug 23 2019

delphij created D21375: Remove zlib 1.0.4 from kernel..
Aug 23 2019, 7:32 AM
delphij committed rS351418: Convert ng_deflate to use new zlib..
Convert ng_deflate to use new zlib.
Aug 23 2019, 7:24 AM
delphij closed D21186: Convert ng_deflate to use new zlib..
Aug 23 2019, 7:24 AM
delphij closed D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
Aug 23 2019, 6:40 AM
delphij committed rS351417: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED in mtx_assert..
INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED in mtx_assert.
Aug 23 2019, 6:39 AM
delphij committed rS351415: Properly update FSInfo block after generation..
Properly update FSInfo block after generation.
Aug 23 2019, 5:24 AM
delphij closed D21363: Properly update FSInfo block after generation..
Aug 23 2019, 5:24 AM

Aug 22 2019

delphij committed rS351382: When creating a new FAT32 filesystem, use "unknown" (0xFFFFFFFF) for.
When creating a new FAT32 filesystem, use "unknown" (0xFFFFFFFF) for
Aug 22 2019, 6:14 AM
delphij created D21363: Properly update FSInfo block after generation..
Aug 22 2019, 6:05 AM
delphij set the repository for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED. to rS FreeBSD src repository.
Aug 22 2019, 4:54 AM
delphij added a reviewer for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED.: cem.
Aug 22 2019, 4:54 AM
delphij added a reviewer for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED.: mjg.
Aug 22 2019, 4:44 AM
delphij updated the test plan for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
Aug 22 2019, 4:42 AM
delphij added a reviewer for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED.: hselasky.
Aug 22 2019, 4:42 AM
delphij created D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
Aug 22 2019, 4:42 AM

Aug 21 2019

delphij committed rS351326: Use MTX_NEW instead of bzero()..
Use MTX_NEW instead of bzero().
Aug 21 2019, 8:15 AM
delphij committed rS351325: Fix sound on headset jack for ThinkPad T51..
Fix sound on headset jack for ThinkPad T51.
Aug 21 2019, 8:01 AM
delphij committed rS351324: Fix a panic in ubt_do_hci_request..
Fix a panic in ubt_do_hci_request.
Aug 21 2019, 7:45 AM

Aug 20 2019

delphij added a comment to D21186: Convert ng_deflate to use new zlib..

The change looks reasonable based on PPP protocol and comparison to existing zlib code.
I didn't know ng_deflate was for ppp.
I was curious how others implemented and found that NetBSD, OpenBSD, and Linux uses Z_PACKET_FLUSH as well, interestingly.
I never looked at ppp implementation and didn't know all others have same base code along with modified zlib.
I am no longer sure if Z_PACKET_FLUSH was FreeBSD original implementation.

Aug 20 2019, 10:18 PM

Aug 19 2019

delphij committed rS351205: Use calloc()..
Use calloc().
Aug 19 2019, 5:24 AM
delphij committed rS351204: Remove redundant check and wrong fix: fat.c checks already take care.
Remove redundant check and wrong fix: fat.c checks already take care
Aug 19 2019, 4:28 AM

Aug 18 2019

delphij added inline comments to D21186: Convert ng_deflate to use new zlib..
Aug 18 2019, 8:08 PM
D21308: random(4): Reorder configuration of random source modules is now accepted and ready to land.
Aug 18 2019, 5:56 AM

Aug 17 2019

delphij committed rP509139: Update to 1.7.14..
Update to 1.7.14.
Aug 17 2019, 6:50 AM
delphij committed rS351154: MFC r350108: Remove support for FreeBSD 10.x..
MFC r350108: Remove support for FreeBSD 10.x.
Aug 17 2019, 1:50 AM

Aug 16 2019

delphij committed rS351140: Delete sys/dir.h which was deprecated since 1997..
Delete sys/dir.h which was deprecated since 1997.
Aug 16 2019, 8:53 PM
delphij closed D20479: Delete sys/dir.h which was deprecated since 1997..
Aug 16 2019, 8:53 PM
D7897: bspatch: add integer overflow checks is now accepted and ready to land.
Aug 16 2019, 8:47 PM
delphij committed rP509067: Update Chinese Pinyin related ports:.
Update Chinese Pinyin related ports:
Aug 16 2019, 8:32 AM
delphij closed D21177: Update Chinese Pinyin related ports:.
Aug 16 2019, 8:32 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Assert that the empty block actually exists.

Aug 16 2019, 7:58 AM
delphij edited reviewers for D21186: Convert ng_deflate to use new zlib., added: glebius; removed: emaste.
Aug 16 2019, 6:15 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Undo unrelated space change.

Aug 16 2019, 6:15 AM

Aug 15 2019

delphij added a reviewer for D21186: Convert ng_deflate to use new zlib.: emaste.
Aug 15 2019, 5:37 PM

Aug 14 2019

delphij committed rS351008: MFC r350855: Upgrade to Bzip2 version 1.0.8..
MFC r350855: Upgrade to Bzip2 version 1.0.8.
Aug 14 2019, 6:41 AM
delphij committed rS351007: MFC r350855: Upgrade to Bzip2 version 1.0.8..
MFC r350855: Upgrade to Bzip2 version 1.0.8.
Aug 14 2019, 6:39 AM

Aug 13 2019

delphij updated the test plan for D21186: Convert ng_deflate to use new zlib..
Aug 13 2019, 5:50 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Remove bogus inflateInit().

Aug 13 2019, 5:38 AM
delphij added a comment to D21177: Update Chinese Pinyin related ports:.

Address reviewer comments.

Aug 13 2019, 5:22 AM

Aug 12 2019

delphij added a comment to D21186: Convert ng_deflate to use new zlib..

(Hopefully have fixed all issues I have found so far).

Aug 12 2019, 8:45 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Revamp.

Aug 12 2019, 8:43 AM

Aug 11 2019

delphij committed rS350855: Upgrade to Bzip2 version 1.0.8..
Upgrade to Bzip2 version 1.0.8.
Aug 11 2019, 6:26 AM
delphij committed rS350854: "Tag" the Bzip2 1.0.8 vendor import..
"Tag" the Bzip2 1.0.8 vendor import.
Aug 11 2019, 6:23 AM
delphij committed rS350853: Vendor import bzip2 -- upgrade to version 1.0.8..
Vendor import bzip2 -- upgrade to version 1.0.8.
Aug 11 2019, 6:22 AM

Aug 8 2019

delphij created D21186: Convert ng_deflate to use new zlib..
Aug 8 2019, 8:13 AM
delphij closed D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Aug 8 2019, 7:28 AM
delphij committed rS350744: Convert DDB_CTF to use newer version of ZLIB..
Convert DDB_CTF to use newer version of ZLIB.
Aug 8 2019, 7:28 AM
delphij updated the test plan for D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Aug 8 2019, 7:27 AM
delphij added a comment to D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.

I have tested with 'dtrace -lv' which will exercise this codepath and confirmed that it worked fine after change.

Aug 8 2019, 7:26 AM
D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 is now accepted and ready to land.
Aug 8 2019, 7:23 AM
D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 now requires review to proceed.

Refresh patch.

Aug 8 2019, 7:22 AM
delphij edited reviewers for D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11, added: ota_j.email.ne.jp; removed: delphij.
Aug 8 2019, 7:22 AM
delphij retitled D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 from DDB_CFT to update zlib version 1.0.4 to 1.2.11 to DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Aug 8 2019, 6:48 AM
D20479: Delete sys/dir.h which was deprecated since 1997. is now accepted and ready to land.

Whoops, this should be committed already according to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21519#c18 .

Aug 8 2019, 6:34 AM
delphij committed rS350743: Update bxe(4) to use new zlib..
Update bxe(4) to use new zlib.
Aug 8 2019, 6:30 AM
delphij closed D21175: bxe to update zlib version 1.0.4 to 1.2.11..
Aug 8 2019, 6:30 AM
delphij committed rS350742: Update geom_uzip to use new zlib:.
Update geom_uzip to use new zlib:
Aug 8 2019, 6:27 AM
delphij closed D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Aug 8 2019, 6:27 AM
D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. is now accepted and ready to land.
Aug 8 2019, 6:23 AM
delphij added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Properly initialize zstream structure.

Aug 8 2019, 6:20 AM