delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (192 w, 1 d)

Recent Activity

Thu, Jan 11

delphij committed rS327808: MFC r327235:.
MFC r327235:
Thu, Jan 11, 7:06 AM

Wed, Jan 10

delphij requested changes to D13837: Wider adoption of mallocarray(9)..

Is it possible that you can split this into smaller pieces (for instance, archictecture code, CAM/CTL, ABI, drivers that ideally be splitted into smaller ones, etc)? Reviewing a changeset this big can quickly get distracted.

Wed, Jan 10, 11:57 PM
delphij committed rS327765: MFC r327236:.
MFC r327236:
Wed, Jan 10, 9:06 AM

Sun, Jan 7

delphij committed rS327672: stddef.h is not used by cat.c, remove the include..
stddef.h is not used by cat.c, remove the include.
Sun, Jan 7, 7:09 AM

Thu, Jan 4

delphij accepted D13755: Resolve ipfilter seed array size panic.

Looks good to me.

Thu, Jan 4, 4:38 AM
delphij requested changes to D13755: Resolve ipfilter seed array size panic.

Please see my comment inline. Other than that random number generation, the change looks fine to me.

Thu, Jan 4, 4:08 AM

Mon, Jan 1

delphij committed rS327464: Remove unused includes..
Remove unused includes.
Mon, Jan 1, 9:41 AM
delphij committed rS327463: Remove unused includes..
Remove unused includes.
Mon, Jan 1, 8:01 AM

Fri, Dec 29

delphij committed rS327335: The fix in r327273 turns a memory leak into freeing wild pointer..
The fix in r327273 turns a memory leak into freeing wild pointer.
Fri, Dec 29, 6:22 AM
delphij committed rP457490: Update to 2.4..
Update to 2.4.
Fri, Dec 29, 3:14 AM

Wed, Dec 27

delphij committed rS327236: Replace send-mail with the more standarized sendmail, we do not create.
Replace send-mail with the more standarized sendmail, we do not create
Wed, Dec 27, 6:24 AM
delphij committed rS327235: Don't initialize lastlong before assigning it..
Don't initialize lastlong before assigning it.
Wed, Dec 27, 6:00 AM

Tue, Dec 26

delphij committed rS327192: MFC r326791: Close the correct file descriptor..
MFC r326791: Close the correct file descriptor.
Tue, Dec 26, 8:33 AM
delphij committed rS327191: MFC r326791: Close the correct file descriptor..
MFC r326791: Close the correct file descriptor.
Tue, Dec 26, 8:32 AM

Mon, Dec 25

delphij committed rS327172: MFC r326185: Set errno to EFTYPE instead of EINVAL to be more consistent.
MFC r326185: Set errno to EFTYPE instead of EINVAL to be more consistent
Mon, Dec 25, 4:34 AM
delphij committed rS327171: MFC r326185: Set errno to EFTYPE instead of EINVAL to be more consistent.
MFC r326185: Set errno to EFTYPE instead of EINVAL to be more consistent
Mon, Dec 25, 4:32 AM

Wed, Dec 20

delphij committed rS327021: MFC r326561: Use strlcpy()..
MFC r326561: Use strlcpy().
Wed, Dec 20, 7:56 AM
delphij committed rS327020: MFC r326560: Create links for xzdiff..
MFC r326560: Create links for xzdiff.
Wed, Dec 20, 7:43 AM
delphij committed rS327019: MFC r326562: Use strlcpy()..
MFC r326562: Use strlcpy().
Wed, Dec 20, 7:18 AM
delphij committed rS327018: MFC r326562: Use strlcpy()..
MFC r326562: Use strlcpy().
Wed, Dec 20, 7:16 AM

Dec 14 2017

delphij committed rS326843: MFC r326391: Prevent OOB access on corrupted msdos directories..
MFC r326391: Prevent OOB access on corrupted msdos directories.
Dec 14 2017, 7:55 AM
delphij committed rS326842: MFC r326391: Prevent OOB access on corrupted msdos directories..
MFC r326391: Prevent OOB access on corrupted msdos directories.
Dec 14 2017, 7:53 AM

Dec 13 2017

delphij committed rS326818: MFC r326361: Remove unused include..
MFC r326361: Remove unused include.
Dec 13 2017, 6:20 AM
delphij committed rS326817: MFC r326361: Remove unused include..
MFC r326361: Remove unused include.
Dec 13 2017, 6:17 AM

Dec 12 2017

delphij committed rS326791: Close the correct file descriptor..
Close the correct file descriptor.
Dec 12 2017, 6:56 AM
delphij committed rS326790: Revert r326763. The change depends on r264387 which was not merged..
Revert r326763. The change depends on r264387 which was not merged.
Dec 12 2017, 4:08 AM

Dec 11 2017

delphij committed rS326763: MFC r325723:.
MFC r325723:
Dec 11 2017, 5:22 AM
delphij committed rS326762: MFC r325723:.
MFC r325723:
Dec 11 2017, 5:20 AM
delphij committed rS326761: MFC r326244:.
MFC r326244:
Dec 11 2017, 5:10 AM
delphij committed rS326760: MFC r326244:.
MFC r326244:
Dec 11 2017, 5:06 AM

Dec 8 2017

delphij accepted D13418: Update for OpenSSL CVE-2017-3737 and CVE-2017-3738..
Dec 8 2017, 6:05 AM

Dec 5 2017

delphij committed rS326562: Use strlcpy()..
Use strlcpy().
Dec 5 2017, 7:22 AM
delphij committed rS326561: Use strlcpy()..
Use strlcpy().
Dec 5 2017, 7:12 AM
delphij committed rS326560: Create links for xzdiff..
Create links for xzdiff.
Dec 5 2017, 7:01 AM
delphij committed rS326559: MFC r326052: Support SIGINFO..
MFC r326052: Support SIGINFO.
Dec 5 2017, 6:44 AM

Nov 30 2017

delphij committed rS326391: Prevent OOB access on corrupted msdos directories..
Prevent OOB access on corrupted msdos directories.
Nov 30 2017, 8:28 AM

Nov 29 2017

delphij committed rS326361: Remove unused include..
Remove unused include.
Nov 29 2017, 9:18 AM
delphij committed rS326360: Bump patch level..
Bump patch level.
Nov 29 2017, 7:41 AM
delphij committed rD51235: Add SA-17:11..
Add SA-17:11.
Nov 29 2017, 6:13 AM
delphij committed rS326359: Fix OpenSSL out-of-bounds read vulnerability..
Fix OpenSSL out-of-bounds read vulnerability.
Nov 29 2017, 6:00 AM
delphij committed rS326358: Fix multiple vulnerabilities of OpenSSL..
Fix multiple vulnerabilities of OpenSSL.
Nov 29 2017, 5:59 AM
delphij committed rS326357: Avoid out-of-bounds read..
Avoid out-of-bounds read.
Nov 29 2017, 5:35 AM

Nov 27 2017

delphij committed rS326244: Don't assign rs as we will assign it later..
Don't assign rs as we will assign it later.
Nov 27 2017, 4:15 AM
delphij committed rS326243: MFC r325755: Be more careful when doing calculation with request from.
MFC r325755: Be more careful when doing calculation with request from
Nov 27 2017, 3:50 AM
delphij committed rS326242: MFC r325755: Be more careful when doing calculation with request from.
MFC r325755: Be more careful when doing calculation with request from
Nov 27 2017, 3:47 AM
delphij committed rD51227: Document xlint removal..
Document xlint removal.
Nov 27 2017, 2:42 AM

Nov 26 2017

delphij committed rS326223: Fill in date..
Fill in date.
Nov 26 2017, 4:55 AM

Nov 25 2017

delphij committed rS326185: Set errno to EFTYPE instead of EINVAL to be more consistent with the.
Set errno to EFTYPE instead of EINVAL to be more consistent with the
Nov 25 2017, 9:04 AM
delphij committed rP454862: Fix an obvious typo..
Fix an obvious typo.
Nov 25 2017, 2:04 AM

Nov 24 2017

delphij committed rP454811: MFH: r453380.
MFH: r453380
Nov 24 2017, 6:56 AM

Nov 22 2017

delphij committed rS326088: MFC r325532: Update arcmsr(4) to 1.40.00.01:.
MFC r325532: Update arcmsr(4) to 1.40.00.01:
Nov 22 2017, 6:37 AM
delphij committed rS326087: MFC r325532: Update arcmsr(4) to 1.40.00.01:.
MFC r325532: Update arcmsr(4) to 1.40.00.01:
Nov 22 2017, 6:34 AM

Nov 21 2017

delphij committed rS326052: Support SIGINFO..
Support SIGINFO.
Nov 21 2017, 8:14 AM

Nov 20 2017

delphij committed rS326010: MFV r326007: less v529..
MFV r326007: less v529.
Nov 20 2017, 8:52 AM
delphij committed rS326008: Tag less v529..
Tag less v529.
Nov 20 2017, 6:59 AM
delphij committed rS326007: Vendor import of less v529..
Vendor import of less v529.
Nov 20 2017, 6:54 AM
delphij committed rS326006: MFC r325383:.
MFC r325383:
Nov 20 2017, 6:49 AM
delphij committed rS326005: MFC r325383:.
MFC r325383:
Nov 20 2017, 6:48 AM

Nov 19 2017

delphij committed rS325994: Remove unused header..
Remove unused header.
Nov 19 2017, 3:52 AM
delphij committed rS325993: Remove unused header..
Remove unused header.
Nov 19 2017, 3:52 AM

Nov 17 2017

delphij requested changes to D13117: Simplified Chinese Documentation Project: Update share/xml/release.l10n.ent.
Nov 17 2017, 6:11 PM
delphij added a comment to D13120: Simplified Chinese Documentation Project: Update share/xml/l10n.ent.

Quick question -- are these variables really needed, if we don't diverge from English versions?

Nov 17 2017, 6:02 PM
delphij accepted D12132: Avoid spinning in random_harvest_queue.
Nov 17 2017, 6:00 PM

Nov 13 2017

delphij committed rS325755: Be more careful when doing calculation with request from userland..
Be more careful when doing calculation with request from userland.
Nov 13 2017, 7:47 AM

Nov 12 2017

delphij added inline comments to D9396: geli attach multiple providers (with kernel changes).
Nov 12 2017, 5:26 AM

Nov 11 2017

delphij closed D13024: Don't terminate when statfs() fails..
Nov 11 2017, 7:19 PM
delphij committed rS325723: find(1): Don't treat statfs() error as fatal in f_fstype, which can happen.
find(1): Don't treat statfs() error as fatal in f_fstype, which can happen
Nov 11 2017, 7:19 PM
delphij updated the diff for D13024: Don't terminate when statfs() fails..

Address jilles's comments.

Nov 11 2017, 7:46 AM

Nov 10 2017

delphij created D13024: Don't terminate when statfs() fails..
Nov 10 2017, 8:04 AM

Nov 8 2017

delphij committed rS325532: Update arcmsr(4) to 1.40.00.01:.
Update arcmsr(4) to 1.40.00.01:
Nov 8 2017, 8:21 AM

Nov 7 2017

delphij committed rD51179: Please welcome Gordon Tetlow as the new Security Officer..
Please welcome Gordon Tetlow as the new Security Officer.
Nov 7 2017, 3:51 PM
delphij closed D12923: Please welcome Gordon Tetlow as the new Security Officer..
Nov 7 2017, 3:51 PM

Nov 4 2017

delphij committed rS325383: Avoid calling get_controller_count() until attaching, this would avoid.
Avoid calling get_controller_count() until attaching, this would avoid
Nov 4 2017, 6:20 AM

Nov 3 2017

delphij created D12923: Please welcome Gordon Tetlow as the new Security Officer..
Nov 3 2017, 5:59 AM

Oct 30 2017

delphij committed rP453157: Improve robustness of owner/mode settings..
Improve robustness of owner/mode settings.
Oct 30 2017, 5:59 AM
delphij closed D12726: Improve robustness of owner/mode settings..
Oct 30 2017, 5:59 AM
delphij committed rP453156: Workaround an issue with kqueue support..
Workaround an issue with kqueue support.
Oct 30 2017, 5:53 AM

Oct 28 2017

delphij added a reviewer for D12808: Don't set a harvest_mask by default.: O3: Kernel Random Numbers Generator.
Oct 28 2017, 7:56 AM
delphij added a comment to D12813: Ensure random_source_descr[] does not get out of sync.

The change itself looks Okay to me, but I might have missed some background discussion -- why do we need to CTASSERT for something already defined in that way a few lines above?

Oct 28 2017, 7:55 AM

Oct 19 2017

delphij created D12726: Improve robustness of owner/mode settings..
Oct 19 2017, 8:14 AM

Oct 16 2017

delphij committed rS324655: Remove the libstand directory which is now empty..
Remove the libstand directory which is now empty.
Oct 16 2017, 4:46 AM

Oct 12 2017

delphij added a comment to D9396: geli attach multiple providers (with kernel changes).

I like the idea by the way.

Oct 12 2017, 4:49 PM
delphij added inline comments to D9396: geli attach multiple providers (with kernel changes).
Oct 12 2017, 4:49 PM

Oct 7 2017

delphij accepted D12618: random(4): Add missing source descriptions.
Oct 7 2017, 6:56 PM
delphij accepted D12611: random(4): Gather entropy from Pure sources.
Oct 7 2017, 6:45 PM
delphij added inline comments to D12611: random(4): Gather entropy from Pure sources.
Oct 7 2017, 5:47 PM
delphij committed rP451425: Add experimental kqueue support [1]:.
Add experimental kqueue support [1]:
Oct 7 2017, 4:53 AM

Oct 6 2017

delphij added a comment to D12132: Avoid spinning in random_harvest_queue.
In D12132#254430, @jmg wrote:

So, you'll still suffer terribly with this, as random_harvest_fast is not PCPU, so you'll have the cache line bouncing around.

IMO, as we feed in the mbuf (and not the mbuf cluster) we are not getting great entropy from the current ethernet harvester. One solution would be to turn off all ethernet harvesting, and enable INTR_ENTROPY on all the ethernet drivers. This will provide timing data for each interrupt, which is good for a couple bits of entropy. This will automatically scale down the rate as most high end ethernet cards do interrupt coalescing.

We don't need to collect THAT much entropy from the system. We should assume we have a good seed (and an uncompromised seed). If it does get compromised, it's more about a time to recovery. We do not need to be "collecting" thousands of bits of entropy every second, even just 10 bit per second not including RDRAND, (we poll RDRAND a minimum of 10 times per second, it increases 2x+𝛆 per bytes read from /dev/random, and it provides 64-bits EACH poll, or 640 bits per second), would give a recover time of under 30 seconds.

Oct 6 2017, 6:32 PM
delphij added inline comments to D12611: random(4): Gather entropy from Pure sources.
Oct 6 2017, 6:29 PM
delphij accepted D12610: random(4): Discard low entropy inputs.
Oct 6 2017, 6:18 PM
delphij added inline comments to D12611: random(4): Gather entropy from Pure sources.
Oct 6 2017, 6:10 PM

Sep 27 2017

delphij committed rP450722: Reorder several variable definitions in Makefile..
Reorder several variable definitions in Makefile.
Sep 27 2017, 6:58 AM
delphij committed rP450721: Remove unnecessary '@exec mkdir -p %D/libexec/openldap' line from pkg-plist..
Remove unnecessary '@exec mkdir -p %D/libexec/openldap' line from pkg-plist.
Sep 27 2017, 6:41 AM
delphij committed rP450720: Unmute all commands at install stage..
Unmute all commands at install stage.
Sep 27 2017, 6:31 AM
delphij committed rP450718: There is no MODULES options, remove it..
There is no MODULES options, remove it.
Sep 27 2017, 6:15 AM
delphij committed rP450717: Replace 'EXTRACT_SUFX=.tgz' with 'USES=tar.tgz'..
Replace 'EXTRACT_SUFX=.tgz' with 'USES=tar.tgz'.
Sep 27 2017, 6:01 AM
delphij committed rP450716: Remove ftp.dti.ad.jp from MASTER_SITES. It is unavailable for a log time..
Remove ftp.dti.ad.jp from MASTER_SITES. It is unavailable for a log time.
Sep 27 2017, 5:56 AM
delphij committed rP450715: Use @preunexec in favor of the deprecated @unexec..
Use @preunexec in favor of the deprecated @unexec.
Sep 27 2017, 5:53 AM
delphij committed rP450713: Add LASTBIND option..
Add LASTBIND option.
Sep 27 2017, 5:40 AM

Sep 25 2017

delphij added a comment to D12405: Diff showing stock tcpdump 4.9.2 vs FreeBSD 4.9.2.

Looks good to me, adding a few other committers just in case.

Sep 25 2017, 5:59 AM