Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (9)

User Details

User Since
May 14 2014, 3:53 AM (316 w, 9 h)

Recent Activity

Mon, Jun 1

delphij committed rP537458: www/pomerium: revert to 0.8.3 for now due to envoy dependency..
www/pomerium: revert to 0.8.3 for now due to envoy dependency.
Mon, Jun 1, 3:29 AM
delphij committed rP537457: www/pomerium: update to 0.9.0.
www/pomerium: update to 0.9.0
Mon, Jun 1, 2:11 AM

Sat, May 30

delphij accepted D25057: Explicitly zero potentially sensitive data in software crypto and cxgbe..

Looks good to me (there are a few minor nits or optional alternative proposals)

Sat, May 30, 4:41 AM

Fri, May 29

delphij committed rP536933: chinese/fcitx: update to 4.2.9.7..
chinese/fcitx: update to 4.2.9.7.
Fri, May 29, 4:45 AM
delphij closed D25039: chinese/fcitx: update to 4.2.9.7..
Fri, May 29, 4:45 AM

Thu, May 28

delphij added a reviewer for D25039: chinese/fcitx: update to 4.2.9.7.: lichray_gmail.com.
Thu, May 28, 5:56 PM
delphij requested review of D25039: chinese/fcitx: update to 4.2.9.7..
Thu, May 28, 5:55 PM

Wed, May 27

delphij committed rP536705: www/pomerium: update to 0.8.3..
www/pomerium: update to 0.8.3.
Wed, May 27, 6:31 PM

Sat, May 23

delphij updated the diff for D24805: liblzma: Make liblzma use libmd implementation of SHA256..

Remove unused sha256.c and use sed instead of awk.

Sat, May 23, 9:59 AM
delphij added reviewers for D24972: Respect liblzma.pc if available.: bdrewery, antoine.
Sat, May 23, 9:55 AM
delphij committed rP536270: www/pomerium: update to 0.8.1..
www/pomerium: update to 0.8.1.
Sat, May 23, 7:01 AM

Fri, May 22

delphij committed rP536247: Document unbound multiple vulnerabilities..
Document unbound multiple vulnerabilities.
Fri, May 22, 10:20 PM
delphij committed rS361396: MFS r361354: MFC r361260: Update leap-seconds to leap-seconds.3676924800..
MFS r361354: MFC r361260: Update leap-seconds to leap-seconds.3676924800.
Fri, May 22, 5:30 PM
delphij committed rS361354: MFC r361260: Update leap-seconds to leap-seconds.3676924800..
MFC r361260: Update leap-seconds to leap-seconds.3676924800.
Fri, May 22, 3:12 AM
delphij committed rS361353: MFC r361260: Update leap-seconds to leap-seconds.3676924800..
MFC r361260: Update leap-seconds to leap-seconds.3676924800.
Fri, May 22, 2:07 AM

Wed, May 20

delphij requested changes to D24596: vfs: add restrictions to read(2) of a directory.

POSIX allows implementations to do what they want with read() on a directory and grep's behaviour follows from that, so I think it's within the spirit for us to show errors or not, as we see fit.

Please do not change the default, that would just make our greps defaults different than linux and everyone else. Just "recommend" the use of grep -d skip in the UPDATE entry, the RELEASE NOTES, and perhaps by adding t as an example, aka commented out, in /root/csh.cshrc and /root/.profile, and perhaps in the usr/share/skel files.

Wed, May 20, 5:45 PM

Tue, May 19

delphij committed rP535885: MFH: r535884.
MFH: r535884
Tue, May 19, 7:04 PM
delphij committed rP535884: dns/unbound: update to 1.10.1..
dns/unbound: update to 1.10.1.
Tue, May 19, 7:02 PM
delphij committed rS361260: Update leap-seconds to leap-seconds.3676924800..
Update leap-seconds to leap-seconds.3676924800.
Tue, May 19, 4:06 PM

Mon, May 18

delphij committed rS361219: MFS r361069: MFC r360952: Generate zlib.pc from source..
MFS r361069: MFC r360952: Generate zlib.pc from source.
Mon, May 18, 4:33 PM

Fri, May 15

delphij committed rS361069: MFC r360952: Generate zlib.pc from source..
MFC r360952: Generate zlib.pc from source.
Fri, May 15, 12:51 AM
delphij committed rS361068: MFC r360952: Generate zlib.pc from source..
MFC r360952: Generate zlib.pc from source.
Fri, May 15, 12:51 AM

Thu, May 14

delphij added a comment to D24805: liblzma: Make liblzma use libmd implementation of SHA256..

I've requested a new exp-run with this one.

Thu, May 14, 9:42 PM
delphij committed rP535199: MFH: r535198.
MFH: r535198
Thu, May 14, 3:40 AM
delphij committed rP535198: www/dokuwiki: update to 2018-04-22c..
www/dokuwiki: update to 2018-04-22c.
Thu, May 14, 3:39 AM

Wed, May 13

delphij accepted D24596: vfs: add restrictions to read(2) of a directory.
Wed, May 13, 11:03 PM
delphij committed rP535114: www/pomerium: update to 0.8.0.
www/pomerium: update to 0.8.0
Wed, May 13, 5:20 PM
delphij accepted D24596: vfs: add restrictions to read(2) of a directory.
Wed, May 13, 4:25 AM

Tue, May 12

delphij added a reviewer for D24596: vfs: add restrictions to read(2) of a directory: jilles.

IMHO I think it's not worth the effort to make this knob-controllable and the old behavior should be gone: directories are not stored in an uniform format, it varies from file system to file system and I'd be really surprised if anything would depend on the old behavior: for starters, these application would have already been broken many years ago when we move to a different file system. Neither fsck_ffs nor fsck_msdosfs rely on being able to read() directories directly, and I don't see any legitimate reason that an application should do it either.

Tue, May 12, 5:31 AM
delphij added a comment to D24596: vfs: add restrictions to read(2) of a directory.

Could you please incorporate the manual page change from D24814 into this one?

Tue, May 12, 4:21 AM
delphij abandoned D24814: Return EISDIR when read() and pread()'ing a directory..

https://reviews.freebsd.org/D24596 is a superset of this changeset (except manual page change).

Tue, May 12, 4:19 AM
delphij added a reviewer for D24814: Return EISDIR when read() and pread()'ing a directory.: mckusick.
Tue, May 12, 4:14 AM
delphij requested review of D24814: Return EISDIR when read() and pread()'ing a directory..
Tue, May 12, 2:50 AM
delphij committed rS360952: Generate zlib.pc from source..
Generate zlib.pc from source.
Tue, May 12, 1:47 AM
delphij closed D24806: Generate zlib.pc from source..
Tue, May 12, 1:47 AM

Mon, May 11

delphij committed rS360893: MFC r360619:.
MFC r360619:
Mon, May 11, 7:22 AM
delphij committed rS360892: MFC r360619:.
MFC r360619:
Mon, May 11, 7:20 AM
delphij requested review of D24806: Generate zlib.pc from source..
Mon, May 11, 3:47 AM
delphij requested review of D24805: liblzma: Make liblzma use libmd implementation of SHA256..
Mon, May 11, 3:05 AM
delphij committed rP534872: devel/py-python-jsonrpc-server: loosen py-ujson dependency requirement..
devel/py-python-jsonrpc-server: loosen py-ujson dependency requirement.
Mon, May 11, 2:03 AM

Sat, May 9

delphij accepted D24766: Remove ubsec(4)..

LGTM (please be sure to bump .Dd dates for manual pages.

Sat, May 9, 6:44 PM

Wed, May 6

delphij committed rP534148: www/pomerium: update to 0.7.6..
www/pomerium: update to 0.7.6.
Wed, May 6, 6:41 AM
delphij committed rP534147: devel/py-ujson: update to 2.0.3..
devel/py-ujson: update to 2.0.3.
Wed, May 6, 6:27 AM

Tue, May 5

delphij requested review of D24724: Hide forward messages in nd6log().
Tue, May 5, 7:22 PM

May 4 2020

delphij committed rS360619: - Fix logic error in swapoff case: follow same handling of p and.
- Fix logic error in swapoff case: follow same handling of p and
May 4 2020, 5:49 AM

May 3 2020

delphij committed rP533745: www/grafana6: update to 6.7.3..
www/grafana6: update to 6.7.3.
May 3 2020, 5:55 AM

May 1 2020

delphij committed rS360524: Fix build..
Fix build.
May 1 2020, 6:10 AM
delphij committed rS360523: MFC r359201: MFV r359197: xz 5.2.5..
MFC r359201: MFV r359197: xz 5.2.5.
May 1 2020, 5:36 AM
delphij committed rS360522: MFC r359118: Fix race condition in catopen(3)..
MFC r359118: Fix race condition in catopen(3).
May 1 2020, 4:59 AM
delphij committed rS360521: MFC r357757: MFV r357712: file 5.38..
MFC r357757: MFV r357712: file 5.38.
May 1 2020, 4:48 AM
delphij committed rS360520: MFC r360428: Do not overflow when calculating file system size..
MFC r360428: Do not overflow when calculating file system size.
May 1 2020, 4:17 AM

Apr 30 2020

delphij committed rS360490: MFC r345839, r345894, r345897, r345900-r345901, r345976, r346220, r348602….
MFC r345839, r345894, r345897, r345900-r345901, r345976, r346220, r348602…
Apr 30 2020, 6:34 AM
delphij committed rS360489: Fix build: redo MFC r360059 and revert unwanted portion..
Fix build: redo MFC r360059 and revert unwanted portion.
Apr 30 2020, 5:29 AM
delphij committed rS360488: MFC r360359: Fix a bug with dirty file system handling..
MFC r360359: Fix a bug with dirty file system handling.
Apr 30 2020, 4:01 AM

Apr 29 2020

delphij committed rP533305: Document OpenLDAP CVE-2020-12243..
Document OpenLDAP CVE-2020-12243.
Apr 29 2020, 1:35 AM
delphij committed rP533304: MFH: r533303.
MFH: r533303
Apr 29 2020, 1:33 AM
delphij committed rP533303: net/openldap24-server: update to 2.4.50..
net/openldap24-server: update to 2.4.50.
Apr 29 2020, 1:31 AM

Apr 28 2020

delphij closed D24603: Do not overflow when calculating file system size..
Apr 28 2020, 5:10 AM
delphij committed rS360428: Do not overflow when calculating file system size..
Do not overflow when calculating file system size.
Apr 28 2020, 5:10 AM
delphij added a comment to D24603: Do not overflow when calculating file system size..

Makes sense, I've updated the patch, could you please take another look?

Apr 28 2020, 4:11 AM
delphij updated the diff for D24603: Do not overflow when calculating file system size..

Address reviewer comment (unconditionally calculate badbytes).

Apr 28 2020, 4:10 AM
delphij requested review of D24603: Do not overflow when calculating file system size..
Apr 28 2020, 3:30 AM

Apr 27 2020

delphij committed rS360359: Fix a bug with dirty file system handling..
Fix a bug with dirty file system handling.
Apr 27 2020, 2:02 AM
delphij closed D24581: Fix a bug with dirty file system handling..
Apr 27 2020, 2:02 AM
delphij added a comment to D24581: Fix a bug with dirty file system handling..

Please take another look, thanks!

Apr 27 2020, 1:30 AM
delphij updated the diff for D24581: Fix a bug with dirty file system handling..

Address reviewer comments.

Apr 27 2020, 1:29 AM

Apr 26 2020

delphij requested review of D24581: Fix a bug with dirty file system handling..
Apr 26 2020, 8:16 PM
delphij committed rP532994: www/pomerium: update to 0.7.5..
www/pomerium: update to 0.7.5.
Apr 26 2020, 2:10 AM
delphij updated the diff for D24508: Gather writes to larger chunks (MAXPHYS) instead of issuing them in sectors..

Round down chunksize if it's not fully aligned.

Apr 26 2020, 2:06 AM
delphij added inline comments to D24508: Gather writes to larger chunks (MAXPHYS) instead of issuing them in sectors..
Apr 26 2020, 1:27 AM
delphij updated the diff for D24508: Gather writes to larger chunks (MAXPHYS) instead of issuing them in sectors..

Address reviewer comment.

Apr 26 2020, 1:26 AM

Apr 25 2020

delphij committed rS360327: MFC rr359961 (jkim): Do not attempt to remove backward compatibility.
MFC rr359961 (jkim): Do not attempt to remove backward compatibility
Apr 25 2020, 11:36 PM
delphij committed rS360291: MFC r359795: Avoid using a variable solely for sizes that are never meant.
MFC r359795: Avoid using a variable solely for sizes that are never meant
Apr 25 2020, 6:43 AM
delphij committed rS360290: MFC r359736: Always install backward compatibility timezones, as they.
MFC r359736: Always install backward compatibility timezones, as they
Apr 25 2020, 5:52 AM

Apr 23 2020

delphij committed rS360215: MFC r359118: Fix race condition in catopen(3)..
MFC r359118: Fix race condition in catopen(3).
Apr 23 2020, 4:52 AM
delphij committed rS360214: MFC r359736: Always install backward compatibility timezones, as they.
MFC r359736: Always install backward compatibility timezones, as they
Apr 23 2020, 4:28 AM
delphij committed rS360213: Remove include of stdint.h. It was added in r241014 for uintmax_t,.
Remove include of stdint.h. It was added in r241014 for uintmax_t,
Apr 23 2020, 3:47 AM

Apr 22 2020

delphij committed rS360186: MFC r358988: Remove unneeded checks for prelen..
MFC r358988: Remove unneeded checks for prelen.
Apr 22 2020, 5:55 AM
delphij committed rS360185: MFC r360104: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are.
MFC r360104: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are
Apr 22 2020, 5:15 AM
delphij committed rS360184: MFC r360104: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are.
MFC r360104: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are
Apr 22 2020, 5:09 AM

Apr 21 2020

delphij committed rP532248: MFH: r532213 r532225.
MFH: r532213 r532225
Apr 21 2020, 3:27 AM

Apr 20 2020

delphij committed rP532225: Depend on devel/py-hglib..
Depend on devel/py-hglib.
Apr 20 2020, 8:02 PM
delphij committed rP532213: python-hglib is a library with a fast, convenient interface to.
python-hglib is a library with a fast, convenient interface to
Apr 20 2020, 5:21 PM
delphij added a comment to D24508: Gather writes to larger chunks (MAXPHYS) instead of issuing them in sectors..

Tested on a hard drive; this reduced the time for format by 2/3:

x before
+ after
+------------------------------------------------------------+
|+++                                                       xx|
||A|                                                       AM|
+------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   3          7.24          7.33          7.29     7.2866667   0.045092498
+   3          2.36          2.49           2.4     2.4166667   0.066583281
Difference at 95.0% confidence
	-4.87 +/- 0.128884
	-66.8344% +/- 1.50101%
	(Student's t, pooled s = 0.0568624)
Apr 20 2020, 12:05 AM
delphij created D24508: Gather writes to larger chunks (MAXPHYS) instead of issuing them in sectors..
Apr 20 2020, 12:01 AM

Apr 19 2020

delphij added a comment to D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..
In D24500#538939, @wulf wrote:

When INVARIANT is enabled, the prev and next pointers would be TRASHIT'ed (set to -1 or 0xffffffffffffffff).

Thanks for explanation. This means 'TRASHIT' calls in LIST_FOREACH macro in queue.h are bogus. They assumes that free() must be called within FOREACH loop. But that is It is not evdev case. free() is called asynchronously here.

Apr 19 2020, 7:10 PM
delphij added a comment to D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..
In D24500#538844, @wulf wrote:

Do you have some local modifications of cdev.c? Especially with relaxed locking in evdev_dtor()?

Apr 19 2020, 5:47 PM
delphij closed D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..
Apr 19 2020, 5:28 PM
delphij committed rS360104: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing.
Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing
Apr 19 2020, 5:28 PM
delphij added reviewers for D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle.: gonzo, jceel.
Apr 19 2020, 6:37 AM
delphij added a reviewer for D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle.: emaste.
Apr 19 2020, 2:33 AM
delphij created D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..
Apr 19 2020, 2:32 AM

Apr 18 2020

delphij committed rP532049: www/pomerium: upgrade to 0.7.4..
www/pomerium: upgrade to 0.7.4.
Apr 18 2020, 10:05 PM

Apr 16 2020

delphij committed rP531860: www/grafana6: update to 6.7.2..
www/grafana6: update to 6.7.2.
Apr 16 2020, 4:30 PM
delphij committed rS360000: Sync with NetBSD/OpenBSD..
Sync with NetBSD/OpenBSD.
Apr 16 2020, 3:23 AM
delphij committed rP531816: www/pomerium: update to 0.7.3..
www/pomerium: update to 0.7.3.
Apr 16 2020, 3:12 AM

Apr 15 2020

delphij accepted D24288: Allow hostuuid to be preloaded for early-boot use.
Apr 15 2020, 3:19 AM
delphij added a comment to D24288: Allow hostuuid to be preloaded for early-boot use.

Looks good to me overall, but I think we don't really need to scan the first 36 characters because validate_uuid would have checked it.

Apr 15 2020, 2:50 AM

Apr 13 2020

delphij committed rS359849: Sync with OpenBSD:.
Sync with OpenBSD:
Apr 13 2020, 8:42 AM

Apr 12 2020

delphij committed rP531467: www/pomerium: update to 0.7.2..
www/pomerium: update to 0.7.2.
Apr 12 2020, 12:45 AM