delphij (Xin Li)
User

Projects (6)

User Details

User Since
May 14 2014, 3:53 AM (158 w, 6 d)

Recent Activity

Sat, May 27

delphij committed rS318975: Tighten /entropy permissions..
Tighten /entropy permissions.
Sat, May 27, 6:24 AM
delphij added a reviewer for D10922: limit buffer sizes.: alfred.
Sat, May 27, 1:29 AM
delphij updated the diff for D10922: limit buffer sizes..

style(9) fixes for new code.

Sat, May 27, 1:29 AM

Fri, May 26

delphij added a comment to D10945: kernel qsort: use inlined min() implementation from libkern.h.
In D10945#226591, @pfg wrote:

What do we gain from the change?

Performance.. if we do them a lot it may be noticeable.

Fri, May 26, 6:33 PM
delphij requested changes to D10945: kernel qsort: use inlined min() implementation from libkern.h.

What do we gain from the change?

Fri, May 26, 6:21 PM
delphij created D10922: limit buffer sizes..
Fri, May 26, 7:44 AM
delphij added a comment to D10814: Remove qsort copy in hemidal.

So this is just compiling to an empty qsort.o today, and the removal is to prevent it from being discovered in grep -r etc.?

Certainly removing it from the Makefile makes sense. I'm indifferent to deleting the contrib-like copy of the file itself.

Fri, May 26, 6:10 AM
delphij committed rS318917: Disconnect heimdal version of qsort.c from build because we are already.
Disconnect heimdal version of qsort.c from build because we are already
Fri, May 26, 6:09 AM
delphij closed D10814: Remove qsort copy in hemidal by committing rS318917: Disconnect heimdal version of qsort.c from build because we are already.
Fri, May 26, 6:09 AM

Mon, May 22

delphij added reviewers for D10814: Remove qsort copy in hemidal: emaste, cem.
Mon, May 22, 6:24 AM

Fri, May 19

delphij added a comment to D10814: Remove qsort copy in hemidal.

This is related to bugs.freebsd.org/213922

Fri, May 19, 7:38 AM
delphij created D10814: Remove qsort copy in hemidal.
Fri, May 19, 7:36 AM
delphij committed rS318517: Sync qsort.c with userland r318515..
Sync qsort.c with userland r318515.
Fri, May 19, 6:37 AM
delphij committed rS318515: The current qsort(3) implementation ignores the sizes of partitions, and.
The current qsort(3) implementation ignores the sizes of partitions, and
Fri, May 19, 4:59 AM
delphij committed rS318514: Use size_t..
Use size_t.
Fri, May 19, 4:44 AM

Thu, May 18

delphij planned changes to D10767: Sync with OpenBSD..

Need to address issues raised (plus some changes were not correct, need to re-do the dynamic buffer related code).

Thu, May 18, 7:00 AM

Wed, May 17

delphij created D10767: Sync with OpenBSD..
Wed, May 17, 7:05 AM

Fri, May 5

delphij committed rS317829: MFV r317581: less v491..
MFV r317581: less v491.
Fri, May 5, 2:33 PM

Mon, May 1

delphij requested changes to D10544: ndbm.h: Unsign dsize by changing it to unsigned int.
In D10544#218799, @pfg wrote:

OK, it may be worth breaking the ABI but, for now, given that we will
have to carry the old datum for compatibility anyways, how about being
one bit more efficient?

Mon, May 1, 4:38 PM
delphij added a comment to D10544: ndbm.h: Unsign dsize by changing it to unsigned int.
In D10544#218741, @pfg wrote:
In D10544#218736, @pfg wrote:
In D10544#218590, @pfg wrote:

Take 2: Comply with POSIX.

This can't be MFC'd.

No, libc ABI must NOT be broken regardless if it's MFC'ed, you should implement versioned compatibility shims.

That's just not feasible: the datum struct touches everything in dbm(3).

I might be missing something, but can't you just create wrappers around the new dbm(3) APIs to implement old binary interfaces, and __sym_compat these FBSD_1.0 symbols?

Yes but maybe I am the one missing something: I can't wrap a structure. I would have to copy the library with the old struct and provide both implementations.
The struct is only used on libc/db/hash/ndbm.c but it still seems too much bloat to copy the old version for such a "minor" change.

Mon, May 1, 8:14 AM
delphij added a comment to D10544: ndbm.h: Unsign dsize by changing it to unsigned int.
In D10544#218736, @pfg wrote:
In D10544#218590, @pfg wrote:

Take 2: Comply with POSIX.

This can't be MFC'd.

No, libc ABI must NOT be broken regardless if it's MFC'ed, you should implement versioned compatibility shims.

That's just not feasible: the datum struct touches everything in dbm(3).

Mon, May 1, 4:17 AM
delphij added a comment to D10544: ndbm.h: Unsign dsize by changing it to unsigned int.
In D10544#218590, @pfg wrote:

Take 2: Comply with POSIX.

This can't be MFC'd.

Mon, May 1, 3:47 AM

Apr 30 2017

delphij added a comment to D10517: Use const with some read-only buffers in opencrypto APIs..

No objection from secteam@ (if we were blocking).

Apr 30 2017, 6:30 AM
delphij requested changes to D10544: ndbm.h: Unsign dsize by changing it to unsigned int.

Manual pages should be updated too.

Apr 30 2017, 6:09 AM

Apr 29 2017

delphij committed rS317582: Tag less v491..
Tag less v491.
Apr 29 2017, 6:33 AM
delphij committed rS317581: Vendor import of less v491..
Vendor import of less v491.
Apr 29 2017, 6:30 AM

Apr 27 2017

delphij committed rD50208: Add SA-17:04..
Add SA-17:04.
Apr 27 2017, 6:58 AM
delphij committed rS317487: Fix ipfilter(4) fragment handling panic..
Fix ipfilter(4) fragment handling panic.
Apr 27 2017, 6:52 AM

Apr 25 2017

delphij committed rS317398: Tag less v487..
Tag less v487.
Apr 25 2017, 3:43 AM
delphij committed rS317397: Vendor import of less 487..
Vendor import of less 487.
Apr 25 2017, 3:42 AM
delphij committed rS317396: Note r317395 as merged..
Note r317395 as merged.
Apr 25 2017, 3:29 AM
delphij committed rS317395: Apply r316339 to vendor area..
Apply r316339 to vendor area.
Apr 25 2017, 3:28 AM

Apr 14 2017

delphij added a reviewer for D10384: Make crypto(9) multi thread: gnn.

I guess George would have interest on this one.

Apr 14 2017, 2:10 AM
delphij added a comment to D10390: Add an option to create XZ-compressed cores.

Looks good to me (in general).

Apr 14 2017, 2:07 AM
delphij accepted D10048: Replace the kernel RC4 with Chacha20..
Apr 14 2017, 1:58 AM

Apr 13 2017

delphij committed rP438426: MFH: r438425.
MFH: r438425
Apr 13 2017, 4:22 AM
delphij committed rP438425: Security update to 9.9.9-P8..
Security update to 9.9.9-P8.
Apr 13 2017, 4:22 AM
delphij committed rP438424: MFH: r438423.
MFH: r438423
Apr 13 2017, 4:13 AM
delphij committed rP438423: Security update to 9.11.0P5..
Security update to 9.11.0P5.
Apr 13 2017, 4:12 AM
delphij committed rP438422: MFH: r438421.
MFH: r438421
Apr 13 2017, 4:10 AM
delphij committed rP438421: Security update to 9.10.4-P6..
Security update to 9.10.4-P6.
Apr 13 2017, 4:09 AM
delphij committed rP438420: Document BIND multiple vulnerabilities..
Document BIND multiple vulnerabilities.
Apr 13 2017, 3:59 AM
delphij committed rP438418: MFH: r438261.
MFH: r438261
Apr 13 2017, 3:46 AM

Apr 12 2017

delphij committed rD50153: Add EN-17:05 and SA-17:03..
Add EN-17:05 and SA-17:03.
Apr 12 2017, 6:45 AM
delphij committed rS316722: Fix multiple vulnerabilities of ntp. [SA-17:03].
Fix multiple vulnerabilities of ntp. [SA-17:03]
Apr 12 2017, 6:25 AM

Apr 8 2017

delphij committed rS316635: Enable 16-bit longest_match for x86..
Enable 16-bit longest_match for x86.
Apr 8 2017, 6:39 AM

Apr 7 2017

delphij added a comment to D10048: Replace the kernel RC4 with Chacha20..

If this needs additional time, would you mind if I integrate part of your change (arc4random_buf) for now?

Apr 7 2017, 12:00 AM

Apr 5 2017

delphij committed rS316518: Extend EoL date to 2017/10/31..
Extend EoL date to 2017/10/31.
Apr 5 2017, 6:42 AM
delphij committed rS316517: Add recent patches..
Add recent patches.
Apr 5 2017, 6:37 AM

Apr 4 2017

delphij accepted D10244: security/vuxml: Add id Tech 3 remote code execution.
Apr 4 2017, 5:07 PM
delphij accepted D10273: Don't leak a session and lock if a GMAC key has an invalid length..

Looks good to me.

Apr 4 2017, 5:06 PM
delphij accepted D10227: Correct a kernel stack leak in 32-bit compat when vfc_name is short..
Apr 4 2017, 5:05 PM

Apr 3 2017

delphij committed rS316442: MFC r312404, r312519, r313277:.
MFC r312404, r312519, r313277:
Apr 3 2017, 6:14 AM
delphij committed rS316441: MFC r312404, r312519, r313277:.
MFC r312404, r312519, r313277:
Apr 3 2017, 6:13 AM
delphij committed rS316440: MFC r315619: pet manlint..
MFC r315619: pet manlint.
Apr 3 2017, 6:09 AM
delphij committed rS316439: MFC r315619: pet manlint.
MFC r315619: pet manlint
Apr 3 2017, 6:08 AM

Mar 29 2017

delphij committed rS316125: MFV r316124: Fix build when WITHOUT_INET6..
MFV r316124: Fix build when WITHOUT_INET6.
Mar 29 2017, 3:36 AM
delphij committed rS316124: Apply vendor revision 470df104c6f55f6d6f390df7448d8eb65c7642b9:.
Apply vendor revision 470df104c6f55f6d6f390df7448d8eb65c7642b9:
Mar 29 2017, 3:29 AM

Mar 28 2017

delphij committed rS316069: MFC r315871: MFV r315791: ntp 4.2.8p10..
MFC r315871: MFV r315791: ntp 4.2.8p10.
Mar 28 2017, 4:49 AM
delphij committed rS316068: MFC r315871: MFV r315791: ntp 4.2.8p10..
MFC r315871: MFV r315791: ntp 4.2.8p10.
Mar 28 2017, 4:48 AM

Mar 23 2017

delphij committed rS315871: MFV r315791: ntp 4.2.8p10..
MFV r315791: ntp 4.2.8p10.
Mar 23 2017, 10:06 PM
delphij committed rS315792: Tag ntp 4.2.8p10..
Tag ntp 4.2.8p10.
Mar 23 2017, 5:20 AM
delphij committed rS315791: Vendor import of ntp-4.2.8p10..
Vendor import of ntp-4.2.8p10.
Mar 23 2017, 5:19 AM

Mar 21 2017

delphij added a comment to D10048: Replace the kernel RC4 with Chacha20..

I'm not comfortable with critical sections for now. Back to mutexes
as before. I'm happy to revisit this later.

Mar 21 2017, 9:47 PM

Mar 20 2017

delphij added inline comments to D10048: Replace the kernel RC4 with Chacha20..
Mar 20 2017, 6:13 PM
delphij added a comment to D10048: Replace the kernel RC4 with Chacha20..

Could you please also address https://reviews.freebsd.org/D10048?id=26438#inline-59236 ?

Mar 20 2017, 3:15 PM
delphij requested changes to D10048: Replace the kernel RC4 with Chacha20..

Could you please take a look at the arc4rand() portion of my comment?

Mar 20 2017, 7:04 AM
delphij committed rS315619: Pet manlint..
Pet manlint.
Mar 20 2017, 4:41 AM
delphij committed rS315615: Make space style consistent with earlier entries..
Make space style consistent with earlier entries.
Mar 20 2017, 3:47 AM

Mar 19 2017

delphij added inline comments to D10048: Replace the kernel RC4 with Chacha20..
Mar 19 2017, 8:17 AM
delphij requested changes to D10048: Replace the kernel RC4 with Chacha20..

LGTM overall but please consider using explicit_bzero when removing sensitive data from memory.

Mar 19 2017, 7:33 AM

Mar 16 2017

delphij committed rS315370: The adj_free and max_free values of new_entry will be calculated and.
The adj_free and max_free values of new_entry will be calculated and
Mar 16 2017, 5:44 AM

Mar 14 2017

delphij committed rS315272: Implement INHERIT_ZERO for minherit(2)..
Implement INHERIT_ZERO for minherit(2).
Mar 14 2017, 5:11 PM
delphij closed D427: Implement INHERIT_ZERO for minherit(2). by committing rS315272: Implement INHERIT_ZERO for minherit(2)..
Mar 14 2017, 5:11 PM
delphij updated the diff for D427: Implement INHERIT_ZERO for minherit(2)..

Copy avail_ssize, adj_free and max_free.

Mar 14 2017, 8:03 AM
delphij committed rS315227: MFC r315225:.
MFC r315225:
Mar 14 2017, 6:13 AM
delphij committed rS315226: MFC r315225:.
MFC r315225:
Mar 14 2017, 6:11 AM
delphij committed rS315225: Discard first 3072 bytes of RC4 keystream, this is a bandaid.
Discard first 3072 bytes of RC4 keystream, this is a bandaid
Mar 14 2017, 6:00 AM

Mar 10 2017

delphij requested changes to D9915: Use of reallocarray(3) in userland..

Please do not commit as-is.

Mar 10 2017, 6:29 PM

Mar 8 2017

delphij committed rP435662: MFH: r435661.
MFH: r435661
Mar 8 2017, 8:07 AM
delphij committed rP435661: Update to 2017-02-19b "Frusterick Manners"..
Update to 2017-02-19b "Frusterick Manners".
Mar 8 2017, 8:04 AM

Mar 7 2017

delphij committed rS314865: Bump __FreeBSD_version for removal of pcap-int.h..
Bump __FreeBSD_version for removal of pcap-int.h.
Mar 7 2017, 4:09 PM
delphij committed rS314863: Stop installing pcap-int.h, which is the internal interface for libpcap..
Stop installing pcap-int.h, which is the internal interface for libpcap.
Mar 7 2017, 4:07 PM

Mar 6 2017

delphij committed rS314769: Remove compatibility with old libpcap..
Remove compatibility with old libpcap.
Mar 6 2017, 8:13 AM
delphij closed D9606: Remove compatibility with old libpcap. by committing rS314769: Remove compatibility with old libpcap..
Mar 6 2017, 8:13 AM

Feb 27 2017

delphij added a comment to D9809: sys/geom/eli: Switch bzero() to explicit_bzero() for sensitive data.

I think this is good in principle (I have commented inline for the ones that doesn't really matter, but the changes would not hurt either), so no objection here. Please consider waiting for a few more days to see if Pawel have any objections.

Feb 27 2017, 5:52 AM
delphij added a reviewer for D9809: sys/geom/eli: Switch bzero() to explicit_bzero() for sensitive data: secteam.
Feb 27 2017, 5:17 AM
delphij added a reviewer for D9787: Fix memory leak in openssh: des.

Add maintainer. (I think this should be upstreamed?)

Feb 27 2017, 5:13 AM

Feb 24 2017

delphij committed rD50007: Start new year with its own year node..
Start new year with its own year node.
Feb 24 2017, 10:42 PM

Feb 23 2017

delphij committed rD50004: Add EN-17:01-04, SA-17:02..
Add EN-17:01-04, SA-17:02.
Feb 23 2017, 7:29 AM
delphij committed rS314126: Fix OpenSSL RC4_MD5 cipher vulnerability..
Fix OpenSSL RC4_MD5 cipher vulnerability.
Feb 23 2017, 7:12 AM
delphij committed rS314125: Fix multiple vulnerabilities of OpenSSL. [SA-17:02].
Fix multiple vulnerabilities of OpenSSL. [SA-17:02]
Feb 23 2017, 7:12 AM

Feb 21 2017

delphij added inline comments to D9694: sys: replace most zeros with NULL for pointers..
Feb 21 2017, 7:55 PM

Feb 19 2017

delphij committed rP434396: Enable autohint. [1].
Enable autohint. [1]
Feb 19 2017, 6:57 AM
delphij accepted D8236: improve PBKDF2 performance.

Thanks!

Feb 19 2017, 6:15 AM

Feb 16 2017

delphij committed rS313796: MFC r311285,312335: zlib 1.2.11..
MFC r311285,312335: zlib 1.2.11.
Feb 16 2017, 6:17 AM
delphij committed rS313795: MFC r311285,312335: zlib 1.2.11..
MFC r311285,312335: zlib 1.2.11.
Feb 16 2017, 6:16 AM

Feb 15 2017

delphij accepted D9598: Document arbitrary file write in diffoscope < 76.

Please include the URL reference for the quoted information too.

Feb 15 2017, 6:34 PM
delphij added a comment to D9606: Remove compatibility with old libpcap..

This makes sense to me from the standpoint of the removed code being unnecessary given that it is being maintained as part of a version of libpcap that doesn't require it.

Are updates to this file periodically, or even at-some-point-theoretically, merged in from an upstream netmap repo? If so, removing this code locally would create an additional maintenance burden for us later, and maybe then removing it isn't worth it as it is otherwise harmless.

Feb 15 2017, 5:45 PM
delphij added a reviewer for D9606: Remove compatibility with old libpcap.: transport.
Feb 15 2017, 8:15 AM