Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (274 w, 5 d)

Recent Activity

Yesterday

delphij committed rS351205: Use calloc()..
Use calloc().
Mon, Aug 19, 5:24 AM
delphij committed rS351204: Remove redundant check and wrong fix: fat.c checks already take care.
Remove redundant check and wrong fix: fat.c checks already take care
Mon, Aug 19, 4:28 AM

Sun, Aug 18

delphij added inline comments to D21186: Convert ng_deflate to use new zlib..
Sun, Aug 18, 8:08 PM
D21308: random(4): Reorder configuration of random source modules is now accepted and ready to land.
Sun, Aug 18, 5:56 AM

Sat, Aug 17

delphij committed rP509139: Update to 1.7.14..
Update to 1.7.14.
Sat, Aug 17, 6:50 AM
delphij committed rS351154: MFC r350108: Remove support for FreeBSD 10.x..
MFC r350108: Remove support for FreeBSD 10.x.
Sat, Aug 17, 1:50 AM

Fri, Aug 16

delphij committed rS351140: Delete sys/dir.h which was deprecated since 1997..
Delete sys/dir.h which was deprecated since 1997.
Fri, Aug 16, 8:53 PM
delphij closed D20479: Delete sys/dir.h which was deprecated since 1997..
Fri, Aug 16, 8:53 PM
D7897: bspatch: add integer overflow checks is now accepted and ready to land.
Fri, Aug 16, 8:47 PM
delphij committed rP509067: Update Chinese Pinyin related ports:.
Update Chinese Pinyin related ports:
Fri, Aug 16, 8:32 AM
delphij closed D21177: Update Chinese Pinyin related ports:.
Fri, Aug 16, 8:32 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Assert that the empty block actually exists.

Fri, Aug 16, 7:58 AM
delphij edited reviewers for D21186: Convert ng_deflate to use new zlib., added: glebius; removed: emaste.
Fri, Aug 16, 6:15 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Undo unrelated space change.

Fri, Aug 16, 6:15 AM

Thu, Aug 15

delphij added a reviewer for D21186: Convert ng_deflate to use new zlib.: emaste.
Thu, Aug 15, 5:37 PM

Wed, Aug 14

delphij committed rS351008: MFC r350855: Upgrade to Bzip2 version 1.0.8..
MFC r350855: Upgrade to Bzip2 version 1.0.8.
Wed, Aug 14, 6:41 AM
delphij committed rS351007: MFC r350855: Upgrade to Bzip2 version 1.0.8..
MFC r350855: Upgrade to Bzip2 version 1.0.8.
Wed, Aug 14, 6:39 AM

Tue, Aug 13

delphij updated the test plan for D21186: Convert ng_deflate to use new zlib..
Tue, Aug 13, 5:50 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Remove bogus inflateInit().

Tue, Aug 13, 5:38 AM
delphij added a comment to D21177: Update Chinese Pinyin related ports:.

Address reviewer comments.

Tue, Aug 13, 5:22 AM

Mon, Aug 12

delphij added a comment to D21186: Convert ng_deflate to use new zlib..

(Hopefully have fixed all issues I have found so far).

Mon, Aug 12, 8:45 AM
delphij added a comment to D21186: Convert ng_deflate to use new zlib..

Revamp.

Mon, Aug 12, 8:43 AM

Sun, Aug 11

delphij committed rS350855: Upgrade to Bzip2 version 1.0.8..
Upgrade to Bzip2 version 1.0.8.
Sun, Aug 11, 6:26 AM
delphij committed rS350854: "Tag" the Bzip2 1.0.8 vendor import..
"Tag" the Bzip2 1.0.8 vendor import.
Sun, Aug 11, 6:23 AM
delphij committed rS350853: Vendor import bzip2 -- upgrade to version 1.0.8..
Vendor import bzip2 -- upgrade to version 1.0.8.
Sun, Aug 11, 6:22 AM

Thu, Aug 8

delphij created D21186: Convert ng_deflate to use new zlib..
Thu, Aug 8, 8:13 AM
delphij closed D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Thu, Aug 8, 7:28 AM
delphij committed rS350744: Convert DDB_CTF to use newer version of ZLIB..
Convert DDB_CTF to use newer version of ZLIB.
Thu, Aug 8, 7:28 AM
delphij updated the test plan for D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Thu, Aug 8, 7:27 AM
delphij added a comment to D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11.

I have tested with 'dtrace -lv' which will exercise this codepath and confirmed that it worked fine after change.

Thu, Aug 8, 7:26 AM
D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 is now accepted and ready to land.
Thu, Aug 8, 7:23 AM
D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 now requires review to proceed.

Refresh patch.

Thu, Aug 8, 7:22 AM
delphij edited reviewers for D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11, added: ota_j.email.ne.jp; removed: delphij.
Thu, Aug 8, 7:22 AM
delphij retitled D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 from DDB_CFT to update zlib version 1.0.4 to 1.2.11 to DDB_CTF to update zlib version 1.0.4 to 1.2.11.
Thu, Aug 8, 6:48 AM
D20479: Delete sys/dir.h which was deprecated since 1997. is now accepted and ready to land.

Whoops, this should be committed already according to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21519#c18 .

Thu, Aug 8, 6:34 AM
delphij committed rS350743: Update bxe(4) to use new zlib..
Update bxe(4) to use new zlib.
Thu, Aug 8, 6:30 AM
delphij closed D21175: bxe to update zlib version 1.0.4 to 1.2.11..
Thu, Aug 8, 6:30 AM
delphij committed rS350742: Update geom_uzip to use new zlib:.
Update geom_uzip to use new zlib:
Thu, Aug 8, 6:27 AM
delphij closed D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Thu, Aug 8, 6:27 AM
D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. is now accepted and ready to land.
Thu, Aug 8, 6:23 AM
delphij added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Properly initialize zstream structure.

Thu, Aug 8, 6:20 AM

Wed, Aug 7

delphij added a reviewer for D21177: Update Chinese Pinyin related ports:: henry.hu.sh_gmail.com.
Wed, Aug 7, 7:19 AM
delphij set the repository for D21177: Update Chinese Pinyin related ports: to rP FreeBSD ports repository.
Wed, Aug 7, 7:19 AM
delphij created D21177: Update Chinese Pinyin related ports:.
Wed, Aug 7, 7:18 AM
D21175: bxe to update zlib version 1.0.4 to 1.2.11. is now accepted and ready to land.
Wed, Aug 7, 5:20 AM
delphij added a reviewer for D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11: markj.

+markj for DTrace.

Wed, Aug 7, 5:20 AM
D21176: DDB_CTF to update zlib version 1.0.4 to 1.2.11 now requires changes to proceed.

Looks mostly fine to me. I think you don't really need to set zalloc to zcalloc_nowait as the default zcalloc is zcalloc_nowait.

Wed, Aug 7, 5:19 AM
delphij added inline comments to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
Wed, Aug 7, 4:39 AM
delphij committed rP508292: MFH: r508254.
MFH: r508254
Wed, Aug 7, 3:16 AM
delphij added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Rebase over D21156.

Wed, Aug 7, 1:45 AM
delphij edited reviewers for D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11., added: ota_j.email.ne.jp; removed: delphij.
Wed, Aug 7, 1:45 AM
delphij committed rS350670: Expose zlib's utility functions in Z_SOLO library when building kernel..
Expose zlib's utility functions in Z_SOLO library when building kernel.
Wed, Aug 7, 1:41 AM
delphij closed D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..
Wed, Aug 7, 1:41 AM

Tue, Aug 6

delphij committed rP508254: Update to 2.4.48..
Update to 2.4.48.
Tue, Aug 6, 2:23 PM
delphij closed D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Tue, Aug 6, 1:32 PM
delphij committed rP508235: Update to 0.9.24..
Update to 0.9.24.
Tue, Aug 6, 8:26 AM
delphij added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

Thanks! I think I'll commit this at some point this week (doing a tinderbox build now).

Tue, Aug 6, 6:31 AM
delphij added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

Fix compile options for zlib crc32.c.

Tue, Aug 6, 6:30 AM
delphij added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

Fix typo.

Tue, Aug 6, 5:20 AM
delphij added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

Good catch!

Tue, Aug 6, 5:20 AM

Mon, Aug 5

delphij committed rS350581: Remove obsolete header file..
Remove obsolete header file.
Mon, Aug 5, 6:01 AM
delphij added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

Please take another look.

Mon, Aug 5, 5:50 AM
delphij added a comment to D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..

Address reviewer comments.

Mon, Aug 5, 5:49 AM

Sun, Aug 4

delphij created D21156: Expose zlib's utility functions in Z_SOLO library when building kernel. This allows kernel code to reuse zlib's implementation..
Sun, Aug 4, 6:18 AM
delphij committed rS350566: There is no need to explicitly add zlib, we already have it in.
There is no need to explicitly add zlib, we already have it in
Sun, Aug 4, 4:51 AM

Sat, Aug 3

delphij committed rS350554: if_mxge: update zlib version 1.0.4 to 1.2.11..
if_mxge: update zlib version 1.0.4 to 1.2.11.
Sat, Aug 3, 3:36 AM
delphij closed D20272: if_mxge to update zlib version 1.0.4 to 1.2.11..
Sat, Aug 3, 3:36 AM

Fri, Aug 2

delphij committed rS350547: Fix !INET build..
Fix !INET build.
Fri, Aug 2, 10:43 PM
D20272: if_mxge to update zlib version 1.0.4 to 1.2.11. is now accepted and ready to land.

Will commit after a tinderbox build.

Fri, Aug 2, 4:16 AM

Thu, Aug 1

delphij added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Submitted as rS350496.

Thu, Aug 1, 6:44 AM
delphij accepted D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Thu, Aug 1, 6:44 AM
delphij edited reviewers for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib., added: ota_j.email.ne.jp; removed: delphij.
Thu, Aug 1, 6:43 AM
delphij accepted D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Thu, Aug 1, 6:36 AM
delphij committed rS350496: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib,.
Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib,
Thu, Aug 1, 6:36 AM
delphij added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Update license for zcalloc;

Thu, Aug 1, 6:26 AM

Wed, Jul 31

D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11. now requires changes to proceed.
Wed, Jul 31, 5:43 PM
D20272: if_mxge to update zlib version 1.0.4 to 1.2.11. now requires changes to proceed.
Wed, Jul 31, 5:42 PM
delphij added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Modified zlib_mod.c to use standard FreeBSD Foundation license.

Wed, Jul 31, 7:43 AM
delphij added reviewers for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib.: ZFS, mav, avg, mmacy.

+@mav @avg @mmacy for ZFS portion of change as a FYI (sys/cddl/contrib/opensolaris/uts/common/zmod). TL;DR: the bundled zlib (1.2.3) was removed in favor of new zlib; alloc/free functions merged from zmod_subr.c into zmod.c.

Wed, Jul 31, 6:03 AM
delphij added a reviewer for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib.: markm.

+@markm (Please confirm if the license is Okay for sys/dev/zlib/zlib_mod.c, the file is largely based on your change rS130799 in 2004 for sys/net/zlib.c).

Wed, Jul 31, 5:50 AM
delphij added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Add license plate for sys/dev/zlib/zlib_mod.c.

Wed, Jul 31, 5:45 AM
delphij added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Rebase.

Wed, Jul 31, 5:16 AM

Tue, Jul 30

delphij committed rD53284: Document __FreeBSD_version 1300038..
Document __FreeBSD_version 1300038.
Tue, Jul 30, 5:29 AM
delphij committed rS350437: Bump __FreeBSD_version after removal of gzip'ed a.out support..
Bump __FreeBSD_version after removal of gzip'ed a.out support.
Tue, Jul 30, 5:14 AM
delphij committed rS350436: Remove gzip'ed a.out support..
Remove gzip'ed a.out support.
Tue, Jul 30, 5:13 AM
delphij closed D21099: Remove gzip'ed a.out support..
Tue, Jul 30, 5:13 AM
delphij added a reviewer for D21099: Remove gzip'ed a.out support.: kib.

+kib@

Tue, Jul 30, 2:11 AM

Mon, Jul 29

delphij added reviewers for D21099: Remove gzip'ed a.out support.: ota_j.email.ne.jp, emaste.
Mon, Jul 29, 6:45 AM
delphij created D21099: Remove gzip'ed a.out support..
Mon, Jul 29, 6:45 AM

Fri, Jul 26

delphij added inline comments to D21072: Remove support for kernel.tramp and kernel.tramp.gz.
Fri, Jul 26, 7:32 AM

Wed, Jul 24

D21033: Remove cap_random(3). is now accepted and ready to land.

What would happen for existing binaries that uses this?

They would fail to compile. But they are trivial to fix, since the users of the cap_random capability can be directly converted to use arc4random_buf().

Wed, Jul 24, 4:08 PM

Tue, Jul 23

D21033: Remove cap_random(3). now requires changes to proceed.

What would happen for existing binaries that uses this?

Tue, Jul 23, 5:44 AM

Jul 20 2019

delphij added a comment to D20721: motd: Generate from template to /var/run.

LGTM, thanks!

Jul 20 2019, 1:44 AM
D20721: motd: Generate from template to /var/run is now accepted and ready to land.
Jul 20 2019, 1:43 AM

Jul 19 2019

delphij added a comment to D20721: motd: Generate from template to /var/run.

Thanks! Please see my comment inline.

Jul 19 2019, 8:31 PM

Jul 18 2019

delphij committed rS350109: errno.h is no longer needed as of r340239 so remove it..
errno.h is no longer needed as of r340239 so remove it.
Jul 18 2019, 7:37 AM
delphij committed rS350108: Remove support for FreeBSD 10.x..
Remove support for FreeBSD 10.x.
Jul 18 2019, 7:26 AM

Jul 8 2019

delphij accepted D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Jul 8 2019, 9:25 PM
delphij added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Thanks! This looks mostly good to me. I intend to commit this version with some minor tweaks after some testing in a day or two, so please yell if you don't agree with some change proposals (commented inline).

Jul 8 2019, 9:25 PM

Jul 4 2019

delphij committed rS349719: MFC r349505: Upgrade to Bzip2 version 1.0.7..
MFC r349505: Upgrade to Bzip2 version 1.0.7.
Jul 4 2019, 7:36 AM