User Details
- User Since
- May 14 2014, 3:53 AM (238 w, 5 d)
Yesterday
Remove ICH8M specific initialization.
Thu, Dec 6
LGTM, thanks!
Thu, Nov 22
Wed, Nov 14
LGTM.
Mon, Nov 12
Oct 30 2018
Oct 27 2018
Oct 26 2018
Please take another look, thanks!
Address style(9) issues pointed out by oshogbo.
Oct 25 2018
Oct 24 2018
Correct size for dryrun.
Oct 12 2018
Sep 26 2018
Sep 25 2018
Sep 14 2018
Sep 11 2018
I think you might want to bump the date (currently read as "January 10, 1995") when committing but it looks otherwise fine to me.
Sep 10 2018
Minor nit: could you please quote variables with {} (e.g. $VAR -> ${VAR})?
Sep 9 2018
Sep 8 2018
Sep 7 2018
Sep 6 2018
LGTM
LGTM, thanks!
Sep 3 2018
Sep 1 2018
Looks reasonable.
LGTM.
This is reasonable.
Aug 29 2018
LGTM (but are we expecting COMPAT_FREEBSD11 defined in places where FreeBSD is not defined?)
Mostly LGTM.
This would increase stack usage for /dev/random read by 32 bytes, but I think it's small enough and make the code easier to reason for MP safety (the buffer is not meant to be shared by two different threads), so consider this a LGTM from secteam@ as long as there is no objection raised by September 1st.
Aug 26 2018
Aug 23 2018
Looks good to me. @jmg do you have any concerns if this is landed as-is?
LGTM from an earlier review.
It seems that the other read_random instances in network stack should do the same as well (probably beyond scope of this changeset though).
LGTM. cem@ or markm@, could you please commit this before code freeze?
Aug 21 2018
LGTM.
LGTM as-is, but with some minor suggestions inline.
I think the direction is good and the changeset looks good to me in principal. Could you please make a change so it would print errline, which would make it easier for administrators to find out where the issue is?
Aug 20 2018
Oops, omit change in stdlib.h.
Update comment, no functional change.
Aug 19 2018
Addressed contrib/ntp/lib/isc/random.c issue; heimdal part would be left as-is for now (I think we can use HAVE_RAND but let's do it in a follow up commit).
Remove #else in contrib/ntp/lib/isc/random.c.
Remove manual page for arc4random_stir and arc4random_addrandom.
Drop chacha_private.h and address various reviewer comments.
Aug 18 2018
Aug 17 2018
Will commit the arc4random_uniform portion of change (which contained some trivial changes to type to make the code C99 compliant) to reduce the size of this changeset and revise to address some comments with plan outlined inline.