delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (214 w, 1 d)

Recent Activity

Today

delphij committed rS335469: Don't leak tmpstr..
Don't leak tmpstr.
Thu, Jun 21, 7:42 AM

Mon, Jun 18

delphij added a comment to D15886: Expose ZFS quotas over nfs.
In D15886#336083, @sef wrote:
In D15886#336048, @sef wrote:

Is it possible to provide a switch to disable the SETQUOTA RPC?

Sorry, I meant a command line option to rpc.rquotad if it's not clear.

I don't have any code in there right now that handles the SETQUOTA RPC, so I'm still confused. Want to discuss it in email?

Mon, Jun 18, 8:15 PM
delphij added a comment to D15886: Expose ZFS quotas over nfs.
In D15886#336048, @sef wrote:

Is it possible to provide a switch to disable the SETQUOTA RPC?

I'm not sure what you mean by a switch there?

Mon, Jun 18, 8:05 PM
delphij added a comment to D15886: Expose ZFS quotas over nfs.

Is it possible to provide a switch to disable the SETQUOTA RPC? (Assuming I'm understanding correctly that no additional authentication is done before it's permitted; rpc.rquotad runs at root privilege so when it issues vfs_quotactl it would not fail because insufficient privilege).

Mon, Jun 18, 7:08 PM

Fri, Jun 15

delphij accepted D15838: Merge header updates from the English version.

LGTM in principal.

Fri, Jun 15, 11:38 PM
delphij committed rS335189: Added option to cluster-align the start of the root directory..
Added option to cluster-align the start of the root directory.
Fri, Jun 15, 6:04 AM
delphij closed D15672: Add option to cluster-align the start of the root directory.
Fri, Jun 15, 6:04 AM

Thu, Jun 14

delphij updated the diff for D15672: Add option to cluster-align the start of the root directory.

Address reviewer comments.

Thu, Jun 14, 6:23 AM
delphij added inline comments to D15672: Add option to cluster-align the start of the root directory.
Thu, Jun 14, 6:22 AM

Wed, Jun 13

delphij committed rP472283: Readd ibus-table-chinese with github source..
Readd ibus-table-chinese with github source.
Wed, Jun 13, 4:58 AM

Wed, Jun 6

delphij added inline comments to D15672: Add option to cluster-align the start of the root directory.
Wed, Jun 6, 6:23 PM
delphij created D15672: Add option to cluster-align the start of the root directory.
Wed, Jun 6, 7:46 AM
delphij accepted D15671: Update zh_CN.UTF-8/htdocs/index.xsl.
Wed, Jun 6, 7:00 AM

Mon, Jun 4

delphij committed rS334607: MFC r333783: MFV r333779: xz 5.2.4..
MFC r333783: MFV r333779: xz 5.2.4.
Mon, Jun 4, 5:53 AM
delphij committed rS334606: MFC r333098:.
MFC r333098:
Mon, Jun 4, 5:47 AM
delphij committed rS334605: MFC r333098:.
MFC r333098:
Mon, Jun 4, 5:38 AM
delphij committed rS334603: MFC r332905:.
MFC r332905:
Mon, Jun 4, 5:23 AM
delphij accepted D15658: Add the 25th anniversary logo to zh_CN home page.
Mon, Jun 4, 5:02 AM

Thu, May 31

delphij accepted D15526: reduce overhead of entropy collection.
Thu, May 31, 4:25 AM
delphij accepted D15526: reduce overhead of entropy collection.

Accept as secteam@ -- talked with so@ and we have no objection to the change in principal.

Thu, May 31, 2:09 AM
delphij requested changes to D15526: reduce overhead of entropy collection.

The change LGTM in principal but I'd like to request a few minor (cosmetic) change.

Thu, May 31, 2:08 AM

Thu, May 24

delphij updated subscribers of D15446: AES CCM-CBC cryptography code.
Thu, May 24, 8:21 PM
delphij added a comment to D15446: AES CCM-CBC cryptography code.

Mostly LGTM. Is there a reason to keep these #if 0's in tools/tools/crypto/cryptocheck.c?

Thu, May 24, 8:21 PM

May 21 2018

delphij committed rP470508: MFH: r470507.
MFH: r470507
May 21 2018, 3:14 AM
delphij committed rP470507: Security update to 9.12.1P2..
Security update to 9.12.1P2.
May 21 2018, 3:13 AM
delphij committed rP470506: Document BIND multiple vulnerabilities..
Document BIND multiple vulnerabilities.
May 21 2018, 3:12 AM

May 18 2018

delphij committed rS333783: MFV r333779: xz 5.2.4..
MFV r333779: xz 5.2.4.
May 18 2018, 6:10 AM
delphij committed rS333780: Tag xz 5.2.4..
Tag xz 5.2.4.
May 18 2018, 4:14 AM
delphij committed rS333779: Vendor import of xz-5.2.4 (trimmed)..
Vendor import of xz-5.2.4 (trimmed).
May 18 2018, 4:06 AM

May 17 2018

delphij accepted D15443: sysutils/devcpu-data: Use new microcode format.

I think you should exit(EX_OK) or return 0 in main(); without it the compiler would give a warning and caller may or may not get wrong exit status (of whatever was left in %rax) at the point. The change otherwise looks good to me.

May 17 2018, 6:39 PM
delphij added inline comments to D15443: sysutils/devcpu-data: Use new microcode format.
May 17 2018, 5:26 PM

May 10 2018

delphij committed rS333449: Remove "All rights reserved" from my files..
Remove "All rights reserved" from my files.
May 10 2018, 6:41 AM

May 8 2018

delphij committed rS333357: MFC r332877: Correct size for allocation and bzero of fdsr..
MFC r332877: Correct size for allocation and bzero of fdsr.
May 8 2018, 5:11 AM
delphij committed rS333356: MFC r332877: Correct size for allocation and bzero of fdsr..
MFC r332877: Correct size for allocation and bzero of fdsr.
May 8 2018, 5:10 AM
delphij committed rP469349: Corrent settings for fontconfig..
Corrent settings for fontconfig.
May 8 2018, 3:46 AM

May 6 2018

delphij committed rP469174: MFH: r469173.
MFH: r469173
May 6 2018, 4:28 AM
delphij committed rP469173: - Update to 2018-04-22a.
- Update to 2018-04-22a
May 6 2018, 4:27 AM

Apr 30 2018

delphij committed rS333098: Don't bail out from the check if readboot() returns !FSFATAL..
Don't bail out from the check if readboot() returns !FSFATAL.
Apr 30 2018, 5:58 AM

Apr 24 2018

delphij committed rP468189: MFH: r468188.
MFH: r468188
Apr 24 2018, 7:55 AM
delphij committed rP468188: Update to 2018-04-22..
Update to 2018-04-22.
Apr 24 2018, 7:54 AM
delphij committed rS332905: Use calloc() instead of malloc+bzero..
Use calloc() instead of malloc+bzero.
Apr 24 2018, 4:08 AM
delphij closed D15166: Use calloc() instead of malloc+bzero.
Apr 24 2018, 4:08 AM

Apr 23 2018

delphij created D15166: Use calloc() instead of malloc+bzero.
Apr 23 2018, 7:57 AM
delphij committed rS332877: Correct size for allocation and bzero of fdsr..
Correct size for allocation and bzero of fdsr.
Apr 23 2018, 7:16 AM

Apr 22 2018

delphij accepted D10482: freebsd-update: regenerate man page database after update.

LGTM.

Apr 22 2018, 6:39 PM

Apr 21 2018

delphij added inline comments to D10482: freebsd-update: regenerate man page database after update.
Apr 21 2018, 6:00 AM
delphij accepted D15144: pwd_mkdb: retire legacy v3 db support (-l option).
Apr 21 2018, 5:57 AM
delphij added a comment to D7897: bspatch: add integer overflow checks.

Looks good to me in principal.

Apr 21 2018, 5:56 AM

Apr 11 2018

delphij committed rP467041: MFH: r467039.
MFH: r467039
Apr 11 2018, 9:42 AM
delphij committed rP467039: Require netif be run before starting slapd..
Require netif be run before starting slapd.
Apr 11 2018, 9:29 AM

Apr 10 2018

delphij committed rS332348: MFC r331180: Plug a possible memory leak..
MFC r331180: Plug a possible memory leak.
Apr 10 2018, 3:15 AM
delphij committed rS332347: MFC r331180: Plug a possible memory leak..
MFC r331180: Plug a possible memory leak.
Apr 10 2018, 3:12 AM

Mar 30 2018

delphij committed rP465945: Update to 2.4.46..
Update to 2.4.46.
Mar 30 2018, 4:06 AM

Mar 28 2018

delphij accepted D13117: Simplified Chinese Documentation Project: Update share/xml/release.l10n.ent.

LGTM, thanks!

Mar 28 2018, 12:07 AM

Mar 19 2018

delphij committed rS331180: Plug a possible memory leak..
Plug a possible memory leak.
Mar 19 2018, 5:49 AM

Mar 16 2018

delphij accepted D14684: random(4): Poll for signals during large reads.

Just in case an explicit blessing from secteam is needed.

Mar 16 2018, 6:42 PM
delphij added a reviewer for D14684: random(4): Poll for signals during large reads: secteam.
Mar 16 2018, 6:41 PM
delphij accepted D14684: random(4): Poll for signals during large reads.

LGTM, thanks!

Mar 16 2018, 6:39 PM
delphij added inline comments to D14684: random(4): Poll for signals during large reads.
Mar 16 2018, 6:20 AM

Mar 15 2018

delphij added a comment to D14684: random(4): Poll for signals during large reads.

Oops, I thought I have send out the comment but turns out I didn't.

Mar 15 2018, 11:20 PM

Mar 12 2018

delphij added a comment to D14500: Implement getrandom(2) and getentropy(3).

Could you please create a review of just the sys/dev/random/randomdev.c portion of change (see my comments inline) as this is a self-contained bugfix and is orthogonal to the rest part of this review? It's easier to understand smaller changesets and future readers of code history would have an easier time to see the reasoning when they are done in smaller and self-contained units.

Mar 12 2018, 4:28 PM

Mar 7 2018

delphij added a comment to D14380: Remove unused error return from API that cannot fail.

You have not updated manual page, but the change looks otherwise fine to me.

Mar 7 2018, 5:27 PM
delphij added inline comments to D14500: Implement getrandom(2) and getentropy(3).
Mar 7 2018, 8:39 AM
delphij committed rS330571: MFC r316339,317396,317829,326010,329554: less v530..
MFC r316339,317396,317829,326010,329554: less v530.
Mar 7 2018, 6:39 AM
delphij committed rS330570: MFC r316339,317396,317829,326010,329554: less v530..
MFC r316339,317396,317829,326010,329554: less v530.
Mar 7 2018, 6:14 AM

Mar 6 2018

delphij added a comment to D14500: Implement getrandom(2) and getentropy(3).

Please take a look at comments inline.

Mar 6 2018, 10:27 PM

Mar 3 2018

delphij committed rD51457: Regen after r330313, fixes a wrong link [1] and add SA-17:12..
Regen after r330313, fixes a wrong link [1] and add SA-17:12.
Mar 3 2018, 8:54 AM
delphij committed rS330313: Document SA-17:12 and correct EN-17:09 link [1].
Document SA-17:12 and correct EN-17:09 link [1]
Mar 3 2018, 8:52 AM
delphij committed rS330312: Document SA-17:12 and correct EN-17:09 link [1].
Document SA-17:12 and correct EN-17:09 link [1]
Mar 3 2018, 8:46 AM

Mar 2 2018

delphij added a reviewer for D14500: Implement getrandom(2) and getentropy(3): O3: Kernel Random Numbers Generator.

Please do not remove O3: Kernel Random Numbers Generator from reviewers, the proposed change have material impact to the kernel random number generator's behavior and I don't think it's Okay to bypass it.

Mar 2 2018, 1:37 AM
delphij added a comment to D14500: Implement getrandom(2) and getentropy(3).
In D14500#304788, @cem wrote:
In D14500#304139, @cem wrote:

The same criticism can be leveled at /dev/urandom. This uses the exact same kernel interface (READ_RANDOM_UIO).

Yes, but my understanding is this new API is intended for all applications (while /dev/urandom access may be blocked with permission), e.g. an application in capability mode should have access to it.

I guess so, but the concern is still a completely hypothetical attack against SHA256 and Fortuna. And maybe a local DoS — I'm still unclear on that.

Mar 2 2018, 1:33 AM

Mar 1 2018

delphij committed rS330141: MFC r330104: MFV r330102: ntp 4.2.8p11.
MFC r330104: MFV r330102: ntp 4.2.8p11
Mar 1 2018, 4:07 AM
delphij accepted D14519: Allow the "@" and "!" characters in passwd file GECOS fields..
Mar 1 2018, 12:16 AM
delphij added a comment to D14519: Allow the "@" and "!" characters in passwd file GECOS fields..

I don't see any problem in principle, the restriction was introduced in r21052 but it didn't explained why it was introduced, and looks like other operating systems, nor LDAP's posixAccount schema seem to enforce similar restrictions.

Mar 1 2018, 12:16 AM

Feb 28 2018

delphij committed rS330106: MFC r330104: MFV r330102: ntp 4.2.8p11.
MFC r330104: MFV r330102: ntp 4.2.8p11
Feb 28 2018, 9:01 AM
delphij committed rS330104: MFV r330102: ntp 4.2.8p11.
MFV r330102: ntp 4.2.8p11
Feb 28 2018, 8:00 AM
delphij committed rP463184: Document multiple NTP vulnerabilities..
Document multiple NTP vulnerabilities.
Feb 28 2018, 7:35 AM
delphij committed rP463182: MFH: r460670, r463181.
MFH: r460670, r463181
Feb 28 2018, 6:55 AM
delphij committed rP463181: Security update 4.2.8p10 --> 4.2.8p11..
Security update 4.2.8p10 --> 4.2.8p11.
Feb 28 2018, 6:51 AM
delphij committed rS330103: Tag ntp 4.2.8p11..
Tag ntp 4.2.8p11.
Feb 28 2018, 6:26 AM
delphij committed rS330102: Vendor import of ntp-4.2.8p11..
Vendor import of ntp-4.2.8p11.
Feb 28 2018, 6:24 AM

Feb 27 2018

delphij added a comment to D14500: Implement getrandom(2) and getentropy(3).
In D14500#304139, @cem wrote:

What specific changes do you want made?

Feb 27 2018, 8:42 AM

Feb 25 2018

delphij accepted D14504: Add us.iso Macbook/Macbook Pro keyboard support .
Feb 25 2018, 6:46 PM
delphij requested changes to D14500: Implement getrandom(2) and getentropy(3).

I really really don't like the Linux getrandom(2) API in general.

Feb 25 2018, 10:07 AM

Feb 23 2018

delphij accepted D14482: libsa: Const-ify buffer argument of write(2) analog.
Feb 23 2018, 7:45 AM
delphij accepted D14380: Remove unused error return from API that cannot fail.

LGTM.

Feb 23 2018, 7:31 AM

Feb 19 2018

delphij committed rS329554: MFV r329552: less v530..
MFV r329552: less v530.
Feb 19 2018, 5:10 AM
delphij committed rS329553: Tag less v530..
Tag less v530.
Feb 19 2018, 4:56 AM
delphij committed rS329552: Vendor import of less v530..
Vendor import of less v530.
Feb 19 2018, 4:47 AM

Feb 6 2018

delphij committed rS328921: MFC r328273 (kevlo): Document how to load nmdm(4) from a kernel module..
MFC r328273 (kevlo): Document how to load nmdm(4) from a kernel module.
Feb 6 2018, 7:50 AM
delphij committed rS328920: MFC r328273 (kevlo): Document how to load nmdm(4) from a kernel module..
MFC r328273 (kevlo): Document how to load nmdm(4) from a kernel module.
Feb 6 2018, 7:47 AM

Feb 3 2018

delphij committed rS328829: After r328426, g_label depends on UFS (option FFS) code to read UFS.
After r328426, g_label depends on UFS (option FFS) code to read UFS
Feb 3 2018, 9:15 AM
delphij closed D14092: Make g_label depend on FFS for now..
Feb 3 2018, 9:15 AM

Jan 29 2018

delphij added a reviewer for D14092: Make g_label depend on FFS for now.: kib.
Jan 29 2018, 11:05 PM
delphij accepted D14105: Fix kernel build after r328523.
Jan 29 2018, 3:56 AM

Jan 28 2018

delphij accepted D14089: Fix LINT build after r328508.
Jan 28 2018, 10:37 PM
delphij added inline comments to D14092: Make g_label depend on FFS for now..
Jan 28 2018, 9:07 PM
delphij created D14092: Make g_label depend on FFS for now..
Jan 28 2018, 7:56 PM

Jan 25 2018

delphij added inline comments to D14049: Fix architectures where pointer and u_int have different sizes.
Jan 25 2018, 9:02 AM

Jan 23 2018

delphij committed rS328273: Document how to load nmdm(4) from a kernel module..
Document how to load nmdm(4) from a kernel module.
Jan 23 2018, 3:37 AM