delphij (Xin Li)
User

Projects (6)

User Details

User Since
May 14 2014, 3:53 AM (150 w, 1 d)

Recent Activity

Wed, Mar 29

delphij committed rS316125: MFV r316124: Fix build when WITHOUT_INET6..
MFV r316124: Fix build when WITHOUT_INET6.
Wed, Mar 29, 3:36 AM
delphij committed rS316124: Apply vendor revision 470df104c6f55f6d6f390df7448d8eb65c7642b9:.
Apply vendor revision 470df104c6f55f6d6f390df7448d8eb65c7642b9:
Wed, Mar 29, 3:29 AM

Tue, Mar 28

delphij committed rS316069: MFC r315871: MFV r315791: ntp 4.2.8p10..
MFC r315871: MFV r315791: ntp 4.2.8p10.
Tue, Mar 28, 4:49 AM
delphij committed rS316068: MFC r315871: MFV r315791: ntp 4.2.8p10..
MFC r315871: MFV r315791: ntp 4.2.8p10.
Tue, Mar 28, 4:48 AM

Thu, Mar 23

delphij committed rS315871: MFV r315791: ntp 4.2.8p10..
MFV r315791: ntp 4.2.8p10.
Thu, Mar 23, 10:06 PM
delphij committed rS315792: Tag ntp 4.2.8p10..
Tag ntp 4.2.8p10.
Thu, Mar 23, 5:20 AM
delphij committed rS315791: Vendor import of ntp-4.2.8p10..
Vendor import of ntp-4.2.8p10.
Thu, Mar 23, 5:19 AM

Tue, Mar 21

delphij added a comment to D10048: Replace the kernel RC4 with Chacha20..

I'm not comfortable with critical sections for now. Back to mutexes
as before. I'm happy to revisit this later.

Tue, Mar 21, 9:47 PM

Mon, Mar 20

delphij added inline comments to D10048: Replace the kernel RC4 with Chacha20..
Mon, Mar 20, 6:13 PM
delphij added a comment to D10048: Replace the kernel RC4 with Chacha20..

Could you please also address https://reviews.freebsd.org/D10048?id=26438#inline-59236 ?

Mon, Mar 20, 3:15 PM
delphij requested changes to D10048: Replace the kernel RC4 with Chacha20..

Could you please take a look at the arc4rand() portion of my comment?

Mon, Mar 20, 7:04 AM
delphij committed rS315619: Pet manlint..
Pet manlint.
Mon, Mar 20, 4:41 AM
delphij committed rS315615: Make space style consistent with earlier entries..
Make space style consistent with earlier entries.
Mon, Mar 20, 3:47 AM

Sun, Mar 19

delphij added inline comments to D10048: Replace the kernel RC4 with Chacha20..
Sun, Mar 19, 8:17 AM
delphij requested changes to D10048: Replace the kernel RC4 with Chacha20..

LGTM overall but please consider using explicit_bzero when removing sensitive data from memory.

Sun, Mar 19, 7:33 AM

Thu, Mar 16

delphij committed rS315370: The adj_free and max_free values of new_entry will be calculated and.
The adj_free and max_free values of new_entry will be calculated and
Thu, Mar 16, 5:44 AM

Tue, Mar 14

delphij committed rS315272: Implement INHERIT_ZERO for minherit(2)..
Implement INHERIT_ZERO for minherit(2).
Tue, Mar 14, 5:11 PM
delphij closed D427: Implement INHERIT_ZERO for minherit(2). by committing rS315272: Implement INHERIT_ZERO for minherit(2)..
Tue, Mar 14, 5:11 PM
delphij updated the diff for D427: Implement INHERIT_ZERO for minherit(2)..

Copy avail_ssize, adj_free and max_free.

Tue, Mar 14, 8:03 AM
delphij committed rS315227: MFC r315225:.
MFC r315225:
Tue, Mar 14, 6:13 AM
delphij committed rS315226: MFC r315225:.
MFC r315225:
Tue, Mar 14, 6:11 AM
delphij committed rS315225: Discard first 3072 bytes of RC4 keystream, this is a bandaid.
Discard first 3072 bytes of RC4 keystream, this is a bandaid
Tue, Mar 14, 6:00 AM

Fri, Mar 10

delphij requested changes to D9915: Extensive use of reallocarray(3) in userland..

Please do not commit as-is.

Fri, Mar 10, 6:29 PM

Wed, Mar 8

delphij committed rP435662: MFH: r435661.
MFH: r435661
Wed, Mar 8, 8:07 AM
delphij committed rP435661: Update to 2017-02-19b "Frusterick Manners"..
Update to 2017-02-19b "Frusterick Manners".
Wed, Mar 8, 8:04 AM

Tue, Mar 7

delphij committed rS314865: Bump __FreeBSD_version for removal of pcap-int.h..
Bump __FreeBSD_version for removal of pcap-int.h.
Tue, Mar 7, 4:09 PM
delphij committed rS314863: Stop installing pcap-int.h, which is the internal interface for libpcap..
Stop installing pcap-int.h, which is the internal interface for libpcap.
Tue, Mar 7, 4:07 PM

Mon, Mar 6

delphij committed rS314769: Remove compatibility with old libpcap..
Remove compatibility with old libpcap.
Mon, Mar 6, 8:13 AM
delphij closed D9606: Remove compatibility with old libpcap. by committing rS314769: Remove compatibility with old libpcap..
Mon, Mar 6, 8:13 AM

Feb 27 2017

delphij added a comment to D9809: sys/geom/eli: Switch bzero() to explicit_bzero() for sensitive data.

I think this is good in principle (I have commented inline for the ones that doesn't really matter, but the changes would not hurt either), so no objection here. Please consider waiting for a few more days to see if Pawel have any objections.

Feb 27 2017, 5:52 AM
delphij added a reviewer for D9809: sys/geom/eli: Switch bzero() to explicit_bzero() for sensitive data: secteam.
Feb 27 2017, 5:17 AM
delphij added a reviewer for D9787: Fix memory leak in openssh: des.

Add maintainer. (I think this should be upstreamed?)

Feb 27 2017, 5:13 AM

Feb 24 2017

delphij committed rD50007: Start new year with its own year node..
Start new year with its own year node.
Feb 24 2017, 10:42 PM

Feb 23 2017

delphij committed rD50004: Add EN-17:01-04, SA-17:02..
Add EN-17:01-04, SA-17:02.
Feb 23 2017, 7:29 AM
delphij committed rS314126: Fix OpenSSL RC4_MD5 cipher vulnerability..
Fix OpenSSL RC4_MD5 cipher vulnerability.
Feb 23 2017, 7:12 AM
delphij committed rS314125: Fix multiple vulnerabilities of OpenSSL. [SA-17:02].
Fix multiple vulnerabilities of OpenSSL. [SA-17:02]
Feb 23 2017, 7:12 AM

Feb 21 2017

delphij added inline comments to D9694: sys: replace most zeros with NULL for pointers..
Feb 21 2017, 7:55 PM

Feb 19 2017

delphij committed rP434396: Enable autohint. [1].
Enable autohint. [1]
Feb 19 2017, 6:57 AM
delphij accepted D8236: improve PBKDF2 performance.

Thanks!

Feb 19 2017, 6:15 AM

Feb 16 2017

delphij committed rS313796: MFC r311285,312335: zlib 1.2.11..
MFC r311285,312335: zlib 1.2.11.
Feb 16 2017, 6:17 AM
delphij committed rS313795: MFC r311285,312335: zlib 1.2.11..
MFC r311285,312335: zlib 1.2.11.
Feb 16 2017, 6:16 AM

Feb 15 2017

delphij accepted D9598: Document arbitrary file write in diffoscope < 76.

Please include the URL reference for the quoted information too.

Feb 15 2017, 6:34 PM
delphij added a comment to D9606: Remove compatibility with old libpcap..

This makes sense to me from the standpoint of the removed code being unnecessary given that it is being maintained as part of a version of libpcap that doesn't require it.

Are updates to this file periodically, or even at-some-point-theoretically, merged in from an upstream netmap repo? If so, removing this code locally would create an additional maintenance burden for us later, and maybe then removing it isn't worth it as it is otherwise harmless.

Feb 15 2017, 5:45 PM
delphij added a reviewer for D9606: Remove compatibility with old libpcap.: transport.
Feb 15 2017, 8:15 AM
delphij retitled D9606: Remove compatibility with old libpcap. from to Remove compatibility with old libpcap..
Feb 15 2017, 8:14 AM
delphij committed rS313760: MFV r313759: license change for a few headers (4 clause BSD to 3 clause BSD)..
MFV r313759: license change for a few headers (4 clause BSD to 3 clause BSD).
Feb 15 2017, 7:23 AM
delphij committed rS313759: Import license changes from upstream 5c5039637f2be0e3167ff6806b4c2741ebab2181..
Import license changes from upstream 5c5039637f2be0e3167ff6806b4c2741ebab2181.
Feb 15 2017, 7:19 AM

Feb 13 2017

delphij committed rS313695: MFV r313676: libpcap 1.8.1.
MFV r313676: libpcap 1.8.1
Feb 13 2017, 8:24 AM

Feb 12 2017

delphij committed rS313678: Fixup mergeinfo..
Fixup mergeinfo.
Feb 12 2017, 7:09 AM
delphij committed rS313677: Tag libpcap 1.8.1..
Tag libpcap 1.8.1.
Feb 12 2017, 7:05 AM
delphij committed rS313676: Vendor import of libpcap 1.8.1..
Vendor import of libpcap 1.8.1.
Feb 12 2017, 7:05 AM

Feb 10 2017

delphij committed rS313534: MFC r274583: Default to use 10 seconds as nap interval instead of 1..
MFC r274583: Default to use 10 seconds as nap interval instead of 1.
Feb 10 2017, 6:58 AM
delphij committed rS313533: MFC r274583: Default to use 10 seconds as nap interval instead of 1..
MFC r274583: Default to use 10 seconds as nap interval instead of 1.
Feb 10 2017, 6:54 AM

Feb 6 2017

delphij committed rS313327: Reflect actual NetBSD revision we already have..
Reflect actual NetBSD revision we already have.
Feb 6 2017, 7:02 AM
delphij committed rS313324: MFC r312663: When creating record file, use umask 077 instead of the default..
MFC r312663: When creating record file, use umask 077 instead of the default.
Feb 6 2017, 5:35 AM
delphij committed rS313323: MFC r312663: When creating record file, use umask 077 instead of the default..
MFC r312663: When creating record file, use umask 077 instead of the default.
Feb 6 2017, 5:30 AM
delphij committed rS313320: MFC r312664: Always initialize 'c'..
MFC r312664: Always initialize 'c'.
Feb 6 2017, 5:24 AM
delphij committed rS313319: MFC r312664: Always initialize 'c'..
MFC r312664: Always initialize 'c'.
Feb 6 2017, 5:23 AM

Feb 5 2017

delphij committed rS313277: Restore r312404:.
Restore r312404:
Feb 5 2017, 8:52 AM

Jan 27 2017

delphij committed rS312863: Backport OpenSSL commit 56336b6c7a75ed28067cadedd8ac46572348bc2f:.
Backport OpenSSL commit 56336b6c7a75ed28067cadedd8ac46572348bc2f:
Jan 27 2017, 7:45 AM

Jan 24 2017

delphij committed rS312683: Don't reference NULL pointer..
Don't reference NULL pointer.
Jan 24 2017, 7:48 AM

Jan 23 2017

delphij committed rS312664: Always initialize 'c'..
Always initialize 'c'.
Jan 23 2017, 7:33 AM
delphij committed rS312663: When creating record file, use umask 077 instead of the default..
When creating record file, use umask 077 instead of the default.
Jan 23 2017, 6:05 AM

Jan 20 2017

delphij committed rS312519: Revert r312404 as we need to do an exp-run and fix existing ports that.
Revert r312404 as we need to do an exp-run and fix existing ports that
Jan 20 2017, 6:45 AM
delphij committed rS312518: MFC r311504: MFV r311477: xz 5.2.3..
MFC r311504: MFV r311477: xz 5.2.3.
Jan 20 2017, 6:40 AM
delphij committed rS312517: MFC r311504: MFV r311477: xz 5.2.3..
MFC r311504: MFV r311477: xz 5.2.3.
Jan 20 2017, 6:39 AM

Jan 19 2017

delphij committed rS312404: Use S_ISREG instead of manual & (also it's better to compare the.
Use S_ISREG instead of manual & (also it's better to compare the
Jan 19 2017, 8:01 AM
delphij closed D4827: sed: Use S_ISREG. by committing rS312404: Use S_ISREG instead of manual & (also it's better to compare the.
Jan 19 2017, 8:01 AM
delphij committed rS312403: MFC r293040,293341,293435:.
MFC r293040,293341,293435:
Jan 19 2017, 7:30 AM

Jan 18 2017

delphij committed rP431818: Downgrade to 0.9.18 due to regressions..
Downgrade to 0.9.18 due to regressions.
Jan 18 2017, 5:47 PM
delphij committed rS312375: MFC r311275: Restructure libz..
MFC r311275: Restructure libz.
Jan 18 2017, 8:20 AM
delphij committed rS312373: MFC r311275: Restructure libz..
MFC r311275: Restructure libz.
Jan 18 2017, 8:11 AM

Jan 17 2017

delphij committed rS312335: MFV r312333: zlib 1.2.11..
MFV r312333: zlib 1.2.11.
Jan 17 2017, 5:56 AM
delphij committed rS312334: Tag zlib 1.2.11..
Tag zlib 1.2.11.
Jan 17 2017, 5:48 AM
delphij committed rS312333: Vendor import of zlib 1.2.11..
Vendor import of zlib 1.2.11.
Jan 17 2017, 5:47 AM

Jan 12 2017

delphij committed rS311967: MFC r311762: Fix typo..
MFC r311762: Fix typo.
Jan 12 2017, 8:12 AM
delphij committed rP431230: Update to 0.9.20..
Update to 0.9.20.
Jan 12 2017, 7:48 AM
delphij committed rP431229: MFH: r431226.
MFH: r431226
Jan 12 2017, 7:33 AM
delphij committed rP431228: MFH: r431225.
MFH: r431225
Jan 12 2017, 7:32 AM
delphij committed rP431227: MFH: r431224.
MFH: r431224
Jan 12 2017, 7:31 AM
delphij committed rP431226: Security update to 9.11.0-P2..
Security update to 9.11.0-P2.
Jan 12 2017, 7:30 AM
delphij committed rP431225: Security update to 9.10.4-P5..
Security update to 9.10.4-P5.
Jan 12 2017, 7:29 AM
delphij committed rP431224: Security update to 9.9.5-P5..
Security update to 9.9.5-P5.
Jan 12 2017, 7:28 AM
delphij committed rP431223: Document BIND multiple vulnerabilities..
Document BIND multiple vulnerabilities.
Jan 12 2017, 7:27 AM

Jan 11 2017

delphij committed rD49830: Add SA-17:01..
Add SA-17:01.
Jan 11 2017, 6:08 AM
delphij committed rS311916: Fix multiple vulnerabilities of OpenSSH..
Fix multiple vulnerabilities of OpenSSH.
Jan 11 2017, 6:01 AM
delphij committed rS311915: MFC r311914: MFV r311913:.
MFC r311914: MFV r311913:
Jan 11 2017, 5:57 AM
delphij committed rS311914: MFV r311913:.
MFV r311913:
Jan 11 2017, 5:49 AM
delphij committed rS311913: Apply upstream fix for CVE-2016-10009 and CVE-2016-10010:.
Apply upstream fix for CVE-2016-10009 and CVE-2016-10010:
Jan 11 2017, 5:42 AM

Jan 9 2017

delphij committed rS311762: Fix typo..
Fix typo.
Jan 9 2017, 7:36 AM
delphij committed rS311756: MFC r310614: Don't assign rtjp twice..
MFC r310614: Don't assign rtjp twice.
Jan 9 2017, 6:08 AM
delphij committed rS311755: MFC r310614: Don't assign rtjp twice..
MFC r310614: Don't assign rtjp twice.
Jan 9 2017, 6:06 AM
delphij committed rS311753: MFC r310611:.
MFC r310611:
Jan 9 2017, 5:59 AM
delphij committed rS311752: MFC r310611:.
MFC r310611:
Jan 9 2017, 5:57 AM
delphij committed rS311751: MFC r310609: Don't use high precision clock for expiration as only second.
MFC r310609: Don't use high precision clock for expiration as only second
Jan 9 2017, 5:52 AM
delphij committed rS311749: MFC r310609: Don't use high precision clock for expiration as only second.
MFC r310609: Don't use high precision clock for expiration as only second
Jan 9 2017, 5:51 AM
delphij committed rS311747: MFC r310608: Avoid use after free..
MFC r310608: Avoid use after free.
Jan 9 2017, 5:44 AM
delphij committed rS311746: MFC r310608: Avoid use after free..
MFC r310608: Avoid use after free.
Jan 9 2017, 5:42 AM

Jan 8 2017

delphij committed rS311670: MFC r311392:.
MFC r311392:
Jan 8 2017, 7:25 AM

Jan 6 2017

delphij committed rS311504: MFV r311477: xz 5.2.3..
MFV r311477: xz 5.2.3.
Jan 6 2017, 7:55 AM