Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (9)

User Details

User Since
May 14 2014, 3:53 AM (290 w, 3 d)

Recent Activity

Tue, Dec 3

delphij committed rS355318: Explicitly exit() instead of return in main()..
Explicitly exit() instead of return in main().
Tue, Dec 3, 7:03 AM
delphij committed rS355317: newfs_msdos: -A is incompatible with -r, not -o..
newfs_msdos: -A is incompatible with -r, not -o.
Tue, Dec 3, 7:01 AM

Sun, Dec 1

delphij committed rS355260: Simplify code with strlcpy/strlcat..
Simplify code with strlcpy/strlcat.
Sun, Dec 1, 8:04 AM
delphij committed rP518749: Unbreak KQUEUE.
Unbreak KQUEUE
Sun, Dec 1, 3:32 AM

Sat, Nov 30

delphij committed rS355247: Reduce disk write load in /usr/libexec/save-entropy..
Reduce disk write load in /usr/libexec/save-entropy.
Sat, Nov 30, 8:07 PM
delphij closed D22612: Reduce disk write load in /usr/libexec/save-entropy.
Sat, Nov 30, 8:07 PM
delphij added a comment to D22612: Reduce disk write load in /usr/libexec/save-entropy.

(Note that the new revision also changed permission from 400 r-------- to 600 rw-------, and umask from 377 to 177, because the non-root user needs write permission to modify the inode).

Sat, Nov 30, 6:33 PM
delphij updated the diff for D22612: Reduce disk write load in /usr/libexec/save-entropy.

Fix issues pointed out by cem@

Sat, Nov 30, 6:27 PM
delphij added a comment to D22612: Reduce disk write load in /usr/libexec/save-entropy.

Thanks for the review, please take another look.

Sat, Nov 30, 6:27 PM
delphij added reviewers for D22612: Reduce disk write load in /usr/libexec/save-entropy: emaste, gordon, cem.
Sat, Nov 30, 9:16 AM
delphij created D22612: Reduce disk write load in /usr/libexec/save-entropy.
Sat, Nov 30, 9:15 AM
delphij committed rP518705: net/openldap24-server: add support for pbkdf2 password hash.
net/openldap24-server: add support for pbkdf2 password hash
Sat, Nov 30, 6:19 AM
delphij committed rP518704: devel/py-pyasn1: update to 0.4.7.
devel/py-pyasn1: update to 0.4.7
Sat, Nov 30, 6:16 AM
delphij committed rS355223: MFC r342876: Enable use of Capsicum sandbox when there is only one.
MFC r342876: Enable use of Capsicum sandbox when there is only one
Sat, Nov 30, 6:02 AM
delphij committed rS355222: Use strlcat()..
Use strlcat().
Sat, Nov 30, 5:58 AM
delphij committed rS355221: MFC r345839, r345894, r345897, r345900-r345901, r345976, r346220, r348602….
MFC r345839, r345894, r345897, r345900-r345901, r345976, r346220, r348602…
Sat, Nov 30, 5:43 AM
delphij committed rS355220: MFC r355128: Update leap-seconds to leap-seconds.3676924800..
MFC r355128: Update leap-seconds to leap-seconds.3676924800.
Sat, Nov 30, 5:01 AM
delphij committed rS355219: MFC r355128: Update leap-seconds to leap-seconds.3676924800..
MFC r355128: Update leap-seconds to leap-seconds.3676924800.
Sat, Nov 30, 4:55 AM

Wed, Nov 27

delphij committed rS355128: Update leap-seconds to leap-seconds.3676924800..
Update leap-seconds to leap-seconds.3676924800.
Wed, Nov 27, 7:51 AM

Mon, Nov 25

delphij committed rS355085: MFV r355071: libbsdxml (expat) 2.2.9..
MFV r355071: libbsdxml (expat) 2.2.9.
Mon, Nov 25, 7:48 AM

Sun, Nov 24

delphij committed rS355071: Vendor import of expat 2.2.9.
Vendor import of expat 2.2.9
Sun, Nov 24, 11:46 PM

Fri, Nov 22

delphij added a comment to D22482: random(4): Abstract loader entropy injection.

(Note that the refactor is not really needed, but I don't have strong opinion here).

Fri, Nov 22, 6:30 AM
delphij accepted D22482: random(4): Abstract loader entropy injection.

Thanks!

Fri, Nov 22, 6:29 AM
delphij accepted D22484: random(4): Use ordinary sysctl definitions.

Looks reasonable to me.

Fri, Nov 22, 12:26 AM
delphij requested changes to D22482: random(4): Abstract loader entropy injection.

I think the proposed change actually does change the code behavior slightly.

Fri, Nov 22, 12:26 AM

Thu, Nov 21

delphij accepted D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Thu, Nov 21, 11:40 PM
delphij accepted D22370: Trigger soft lifetime expiration on sequence number.
Thu, Nov 21, 11:32 PM
delphij accepted D22485: random(4): De-export random_sources list.
Thu, Nov 21, 11:22 PM
delphij committed rS354939: MFC r333923, r354595, r354802:.
MFC r333923, r354595, r354802:
Thu, Nov 21, 7:39 AM
delphij committed rS354938: MFC r354595, r354802:.
MFC r354595, r354802:
Thu, Nov 21, 7:30 AM

Mon, Nov 18

delphij committed rS354802: MFV r354798:.
MFV r354798:
Mon, Nov 18, 4:22 AM

Sun, Nov 17

delphij committed rS354798: Apply vendor fixes:.
Apply vendor fixes:
Sun, Nov 17, 8:56 PM

Tue, Nov 12

delphij accepted D22300: audio/libmad: Fix CVEs 2017-8372, 2017-8373 and 2017-8374.
Tue, Nov 12, 7:18 AM

Sun, Nov 10

delphij committed rP517221: MFH: r517220.
MFH: r517220
Sun, Nov 10, 6:36 PM
delphij committed rP517220: Remove redundant pidfile check..
Remove redundant pidfile check.
Sun, Nov 10, 6:35 PM
delphij committed rS354595: MFV r354582: file 5.37..
MFV r354582: file 5.37.
Sun, Nov 10, 5:00 PM
delphij committed rS354583: Tag file 5.37..
Tag file 5.37.
Sun, Nov 10, 3:45 AM

Oct 24 2019

delphij committed rD53504: Disable the .cn mirror entity for now, the service is offline for.
Disable the .cn mirror entity for now, the service is offline for
Oct 24 2019, 7:05 AM
delphij committed rP515321: upgrade to v3.3.2..
upgrade to v3.3.2.
Oct 24 2019, 5:30 AM

Oct 15 2019

delphij added a comment to D22037: remove duplicate lz4 implementations.

I like the direction in general.

Oct 15 2019, 5:44 PM

Oct 12 2019

delphij committed rP514353: Return this to pool. I no longer use this port anymore..
Return this to pool. I no longer use this port anymore.
Oct 12 2019, 8:29 PM

Oct 11 2019

delphij accepted D21979: wbwd: move to superio(4) bus.

Looks fine to me, but I no longer have the hardware to actually test the changes, iXsystems may be able to help with that.

Oct 11 2019, 10:03 PM

Oct 2 2019

delphij committed rP513545: x11/slim: Permit setting a default xsession from .xinitrc..
x11/slim: Permit setting a default xsession from .xinitrc.
Oct 2 2019, 5:04 AM

Oct 1 2019

delphij added a reviewer for D21865: avoid compiling in hpt* drivers containing binary blobs: releng.

I'm mostly in favor of the change (smaller kernel size, etc.), but since we are removing driver from GENERIC, it's better if we can provide a mechanism to load the driver on demand, or a binary update can easily brick the system...

Oct 1 2019, 9:55 PM
delphij added a comment to D21855: OpenLDAP refreshment.

Why are we making this change? It was somewhat intentional to not enable SASL by default (to reduce attack surface, e.g. CVE-2019-13565), is this functionality being used by a lot of consumers?

Oct 1 2019, 8:40 PM

Sep 30 2019

delphij committed rS352902: MFS r352872: MFC r351802:.
MFS r352872: MFC r351802:
Sep 30 2019, 2:32 PM
delphij committed rS352891: MFC r351325:.
MFC r351325:
Sep 30 2019, 7:27 AM
delphij committed rS352890: MFC r351417: r351417: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED.
MFC r351417: r351417: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED
Sep 30 2019, 6:38 AM
delphij committed rS352888: MFC r351501: MFV r351500: Fix CLEAR_HASH macro to be usable as a single.
MFC r351501: MFV r351500: Fix CLEAR_HASH macro to be usable as a single
Sep 30 2019, 6:04 AM
delphij committed rS352887: MFC r351382:.
MFC r351382:
Sep 30 2019, 5:44 AM

Sep 29 2019

delphij committed rS352873: MFC r351802:.
MFC r351802:
Sep 29 2019, 8:08 PM
delphij committed rS352872: MFC r351802:.
MFC r351802:
Sep 29 2019, 8:06 PM

Sep 26 2019

delphij added inline comments to D21805: freebsd-update: rehash certs as needed.
Sep 26 2019, 9:02 PM

Sep 25 2019

delphij committed rP512800: MFH: r512162, r512335.
MFH: r512162, r512335
Sep 25 2019, 5:45 PM

Sep 18 2019

delphij accepted D21531: Use zlib's uncompress function for simpler code..

LGTM.

Sep 18 2019, 4:38 AM

Sep 15 2019

delphij committed rS352364: Avoid mixing cluster numbers and sector numbers. Makes code more readable..
Avoid mixing cluster numbers and sector numbers. Makes code more readable.
Sep 15 2019, 7:42 PM
delphij closed D21375: Remove zlib 1.0.4 from kernel..

Landed as rS351480.

Sep 15 2019, 5:37 PM

Sep 5 2019

delphij accepted D21523: Test for ns_parserr() and got a heap-buffer-overflow.
Sep 5 2019, 5:56 AM

Sep 4 2019

delphij committed rS351802: Correct overflow logic in fullpath()..
Correct overflow logic in fullpath().
Sep 4 2019, 4:44 AM

Sep 3 2019

delphij accepted D21496: pkgbase: Move the bootloader related files to a new FreeBSD-bootloader package.

Would like a different @releng member to take a look if possible, but the change looks reasonable to me.

Sep 3 2019, 4:10 PM
delphij committed rS351737: MFC r351205: Use calloc()..
MFC r351205: Use calloc().
Sep 3 2019, 7:02 AM
delphij committed rS351735: MFC r351204:.
MFC r351204:
Sep 3 2019, 6:52 AM

Aug 31 2019

delphij added a comment to D21479: WIP: Make fsck_msdosfs use less memory..

Remove unused field.

Aug 31 2019, 10:01 AM
delphij added a comment to D21479: WIP: Make fsck_msdosfs use less memory..

Fix accounting for NumFree.

Aug 31 2019, 9:59 AM
delphij retitled D21479: WIP: Make fsck_msdosfs use less memory. from WIP: Make fsck_msdosfs use less memory. Not yet review-ready. to WIP: Make fsck_msdosfs use less memory..

Fixed a couple of bugs.

Aug 31 2019, 9:54 AM
delphij created D21479: WIP: Make fsck_msdosfs use less memory..
Aug 31 2019, 8:30 AM

Aug 30 2019

delphij committed rS351623: Remove unneeded blank line. No functional change..
Remove unneeded blank line. No functional change.
Aug 30 2019, 6:06 AM

Aug 26 2019

delphij committed rS351502: Comment boot block checks and perform additional sanity checks:.
Comment boot block checks and perform additional sanity checks:
Aug 26 2019, 6:41 AM
delphij committed rS351501: MFV r351500: Fix CLEAR_HASH macro to be usable as a single statement..
MFV r351500: Fix CLEAR_HASH macro to be usable as a single statement.
Aug 26 2019, 12:46 AM

Aug 25 2019

delphij committed rS351500: Import vendor commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:.
Import vendor commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:
Aug 25 2019, 11:52 PM
delphij committed rD53326: Document __FreeBSD_version 1300041..
Document __FreeBSD_version 1300041.
Aug 25 2019, 5:16 PM
delphij committed rS351480: Remove zlib 1.0.4 from kernel..
Remove zlib 1.0.4 from kernel.
Aug 25 2019, 5:13 PM
delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

Remove D21408 portion of change.

Aug 25 2019, 7:52 AM
delphij committed rS351477: GZIO: Update to use zlib 1.2.11..
GZIO: Update to use zlib 1.2.11.
Aug 25 2019, 7:51 AM
delphij closed D21408: GZIO to update zlib version 1.0.4 to 1.2.11..
Aug 25 2019, 7:51 AM
D21408: GZIO to update zlib version 1.0.4 to 1.2.11. is now accepted and ready to land.
Aug 25 2019, 7:47 AM

Aug 24 2019

delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

@markj -- do you have some suggestion on how should we test subr_compressor.c changes?

Aug 24 2019, 7:06 PM
delphij added a reviewer for D21375: Remove zlib 1.0.4 from kernel.: markj.
Aug 24 2019, 7:06 PM
delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

PTAL.

Aug 24 2019, 7:02 PM
delphij added a comment to D21375: Remove zlib 1.0.4 from kernel..

Fix subr_compressor.c.

Aug 24 2019, 7:02 PM

Aug 23 2019

delphij created D21375: Remove zlib 1.0.4 from kernel..
Aug 23 2019, 7:32 AM
delphij committed rS351418: Convert ng_deflate to use new zlib..
Convert ng_deflate to use new zlib.
Aug 23 2019, 7:24 AM
delphij closed D21186: Convert ng_deflate to use new zlib..
Aug 23 2019, 7:24 AM
delphij closed D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
Aug 23 2019, 6:40 AM
delphij committed rS351417: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED in mtx_assert..
INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED in mtx_assert.
Aug 23 2019, 6:39 AM
delphij committed rS351415: Properly update FSInfo block after generation..
Properly update FSInfo block after generation.
Aug 23 2019, 5:24 AM
delphij closed D21363: Properly update FSInfo block after generation..
Aug 23 2019, 5:24 AM

Aug 22 2019

delphij committed rS351382: When creating a new FAT32 filesystem, use "unknown" (0xFFFFFFFF) for.
When creating a new FAT32 filesystem, use "unknown" (0xFFFFFFFF) for
Aug 22 2019, 6:14 AM
delphij created D21363: Properly update FSInfo block after generation..
Aug 22 2019, 6:05 AM
delphij set the repository for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED. to rS FreeBSD src repository.
Aug 22 2019, 4:54 AM
delphij added a reviewer for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED.: cem.
Aug 22 2019, 4:54 AM
delphij added a reviewer for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED.: mjg.
Aug 22 2019, 4:44 AM
delphij updated the test plan for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
Aug 22 2019, 4:42 AM
delphij added a reviewer for D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED.: hselasky.
Aug 22 2019, 4:42 AM
delphij created D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
Aug 22 2019, 4:42 AM

Aug 21 2019

delphij committed rS351326: Use MTX_NEW instead of bzero()..
Use MTX_NEW instead of bzero().
Aug 21 2019, 8:15 AM
delphij committed rS351325: Fix sound on headset jack for ThinkPad T51..
Fix sound on headset jack for ThinkPad T51.
Aug 21 2019, 8:01 AM
delphij committed rS351324: Fix a panic in ubt_do_hci_request..
Fix a panic in ubt_do_hci_request.
Aug 21 2019, 7:45 AM

Aug 20 2019

delphij added a comment to D21186: Convert ng_deflate to use new zlib..

The change looks reasonable based on PPP protocol and comparison to existing zlib code.
I didn't know ng_deflate was for ppp.
I was curious how others implemented and found that NetBSD, OpenBSD, and Linux uses Z_PACKET_FLUSH as well, interestingly.
I never looked at ppp implementation and didn't know all others have same base code along with modified zlib.
I am no longer sure if Z_PACKET_FLUSH was FreeBSD original implementation.

Aug 20 2019, 10:18 PM

Aug 19 2019

delphij committed rS351205: Use calloc()..
Use calloc().
Aug 19 2019, 5:24 AM