- User Since
- May 14 2014, 3:53 AM (223 w, 3 h)
LGTM as-is, but with some minor suggestions inline.
I think the direction is good and the changeset looks good to me in principal. Could you please make a change so it would print errline, which would make it easier for administrators to find out where the issue is?
Mon, Aug 20
Oops, omit change in stdlib.h.
Update comment, no functional change.
Sun, Aug 19
Addressed contrib/ntp/lib/isc/random.c issue; heimdal part would be left as-is for now (I think we can use HAVE_RAND but let's do it in a follow up commit).
Remove #else in contrib/ntp/lib/isc/random.c.
Remove manual page for arc4random_stir and arc4random_addrandom.
Drop chacha_private.h and address various reviewer comments.
Sat, Aug 18
Fri, Aug 17
Will commit the arc4random_uniform portion of change (which contained some trivial changes to type to make the code C99 compliant) to reduce the size of this changeset and revise to address some comments with plan outlined inline.
Wed, Aug 15
Tue, Aug 14
I think we should come up with a design first, it's important not to repeat other's errors. (I have a version based on earlier OpenBSD arc4random()  that was used in a disk wiper which still suffers from a few issues that OpenBSD have fixed in their later versions, for example the use of MAP_INHERIT_ZERO or FreeBSD's INHERIT_ZERO to detect fork.). My recommendation is to start over from a more recent OpenBSD version.
Sun, Aug 12
Thu, Aug 9
LGTM'ing so we don't become a blocker (the code construction is similar to ivy.c). Please go ahead with commit after 14th August if nobody raises problems that they thinks should block the commit.
Wed, Aug 8
Tue, Aug 7
Mon, Aug 6
LGTM (please verify that rcorder /usr/local/etc/rc.d/* /etc/rc.d/* > /dev/null won't give cycles before committing).
Sun, Aug 5
Clarify the code.
Sat, Aug 4
Referenced wrong review. This was committed as rS337317.
Fri, Aug 3
Wed, Aug 1
Sat, Jul 28
Could you please split the proposed change to smaller pieces, so it would be easier to review?
Fri, Jul 27
Thu, Jul 26
Tue, Jul 24
Jul 20 2018
Jul 19 2018
Jul 18 2018
Update manual pages and other hash rountines.