Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (249 w, 1 d)

Recent Activity

Tue, Feb 19

delphij accepted D18944: freebsd-update: Clarify unclear help text.
Tue, Feb 19, 5:30 PM

Wed, Feb 13

delphij added a comment to D19184: Set process title during zfs send.

Ah I didn't realized that we haven't upstreamed it & thanks for forward-porting it for so many years...

Wed, Feb 13, 9:56 PM

Thu, Feb 7

delphij accepted D18785: Fix quotas for UFS after r339008.
Thu, Feb 7, 9:37 PM

Tue, Feb 5

delphij committed rS343765: MFC r342813: Remove unneeded headers..
MFC r342813: Remove unneeded headers.
Tue, Feb 5, 8:05 AM

Tue, Jan 29

delphij committed rS343545: MFC r343038: Use TD_IS_IDLETHREAD instead of unrolled version..
MFC r343038: Use TD_IS_IDLETHREAD instead of unrolled version.
Tue, Jan 29, 7:48 AM
delphij committed rS343544: MFC r343038: Use TD_IS_IDLETHREAD instead of unrolled version..
MFC r343038: Use TD_IS_IDLETHREAD instead of unrolled version.
Tue, Jan 29, 7:48 AM

Mon, Jan 28

delphij added a comment to D18920: Allow mmap operations for CAPH_READ and CAPH_WRITE..

Is this some common pattern?

Mon, Jan 28, 1:32 AM

Sun, Jan 27

delphij added a reviewer for D18920: Allow mmap operations for CAPH_READ and CAPH_WRITE.: capsicum.
Sun, Jan 27, 7:26 AM

Thu, Jan 24

delphij accepted D18913: freebsd-update: open $PAGER only if necessary.

One last change request -- could you please use ${PAGER} instead of $PAGER while there? The change looks otherwise fine to me.

Thu, Jan 24, 5:51 AM
delphij accepted D18916: Clarify unsupported architecture upgrade message.

LGTM & Thanks for your work!

Thu, Jan 24, 5:50 AM

Tue, Jan 22

delphij added a comment to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.

Note that most IDS_run output shouldn't be considered as "informational", especially checksum differences: these should not be suppressed because they suggest there are real issues.

Where are the checksum diffs? I don't think they are currently suppressed but maybe I missed it.

Tue, Jan 22, 5:29 AM
delphij requested changes to D18913: freebsd-update: open $PAGER only if necessary.

I like this change in principle, but I think you could simplify the code a little bit (see my comments in line).

Tue, Jan 22, 5:26 AM
delphij requested changes to D18916: Clarify unsupported architecture upgrade message.

I really don't like this approach because it would bar us from retrofit publishing freebsd-update bits (and would create problems for users who have their own freebsd-update instance running). I think it's more appropriate to make fetch_key to provide more meaningful output instead of "Fetching public key from ... failed".

Tue, Jan 22, 5:10 AM
delphij created D18920: Allow mmap operations for CAPH_READ and CAPH_WRITE..
Tue, Jan 22, 4:49 AM
delphij committed rS343300: MFC r342856: Added support for the SIOCGI2C ioctl..
MFC r342856: Added support for the SIOCGI2C ioctl.
Tue, Jan 22, 4:21 AM
delphij committed rS343299: MFC r342856: Added support for the SIOCGI2C ioctl..
MFC r342856: Added support for the SIOCGI2C ioctl.
Tue, Jan 22, 4:20 AM

Jan 21 2019

delphij committed rS343251: MFC r342845,342846: Port NetBSD improvements:.
MFC r342845,342846: Port NetBSD improvements:
Jan 21 2019, 6:52 AM
delphij committed rS343250: MFC r342845,342846: Port NetBSD improvements:.
MFC r342845,342846: Port NetBSD improvements:
Jan 21 2019, 6:14 AM

Jan 18 2019

delphij accepted D18881: Allow upgrade from -BETA and -RC releases.

LGTM in principal (except the style issue raised by @emaste which is minor and I think he would take care of it when committing).

Jan 18 2019, 6:08 PM
delphij added inline comments to D18825: Verify the system can perform install/rollback.
Jan 18 2019, 5:58 PM
delphij added a comment to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.

It may be because it is hard to follow but warnings/errors are redirected to the stderr

Jan 18 2019, 5:51 PM
delphij accepted D18849: Use BASEDIR when checking for src component.

LGTM, thanks!

Jan 18 2019, 5:28 PM
delphij requested changes to D18849: Use BASEDIR when checking for src component.
Jan 18 2019, 1:05 AM
delphij added inline comments to D18825: Verify the system can perform install/rollback.
Jan 18 2019, 1:04 AM
delphij requested changes to D18825: Verify the system can perform install/rollback.

I think this is not complete. For example, /usr may be a symlink to somewhere else, and freebsd-update needs to have write access there (this applies to /boot, /var, etc. too).

Jan 18 2019, 12:59 AM
delphij requested changes to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.

I like the idea in general, but I think there were some implementation issues:

Jan 18 2019, 12:41 AM

Jan 15 2019

delphij committed rS343040: MFC r342640: Ensure buffer is nul-terminated..
MFC r342640: Ensure buffer is nul-terminated.
Jan 15 2019, 6:52 AM
delphij committed rS343039: MFC r342640: Ensure buffer is nul-terminated..
MFC r342640: Ensure buffer is nul-terminated.
Jan 15 2019, 6:51 AM
delphij committed rS343038: Use TD_IS_IDLETHREAD instead of unrolled version..
Use TD_IS_IDLETHREAD instead of unrolled version.
Jan 15 2019, 6:44 AM

Jan 13 2019

delphij committed rS342997: MFC r342614, r342633.
MFC r342614, r342633
Jan 13 2019, 8:50 AM
delphij committed rS342996: MFC r342614, r342633.
MFC r342614, r342633
Jan 13 2019, 8:46 AM

Jan 9 2019

delphij committed rP489757: MFH: r489756.
MFH: r489756
Jan 9 2019, 8:14 AM
delphij committed rP489756: Update to 2018-04-22b..
Update to 2018-04-22b.
Jan 9 2019, 8:13 AM
delphij added a comment to D18786: Disable FTS3, FTS4, and RTREE in bundled and private sqlite3.

LGTM now, thanks!

Jan 9 2019, 6:26 AM
delphij accepted D18786: Disable FTS3, FTS4, and RTREE in bundled and private sqlite3.
Jan 9 2019, 6:25 AM
delphij committed rS342876: Enable use of Capsicum sandbox when there is only one.
Enable use of Capsicum sandbox when there is only one
Jan 9 2019, 5:31 AM

Jan 8 2019

delphij requested changes to D18786: Disable FTS3, FTS4, and RTREE in bundled and private sqlite3.

I'd like to request that the change be either extended to disable RTREE (my preference; we don't use rtree in base either), or reduced to build with FTS4 (to match upstream; arguably FTS5 should be also enabled if that's the approach taken) for consistency.

Jan 8 2019, 9:42 PM
delphij committed rS342856: Added support for the SIOCGI2C ioctl..
Added support for the SIOCGI2C ioctl.
Jan 8 2019, 5:41 AM

Jan 7 2019

delphij committed rS342846: Correct documentation year..
Correct documentation year.
Jan 7 2019, 8:29 AM
delphij committed rS342845: Port NetBSD improvements:.
Port NetBSD improvements:
Jan 7 2019, 8:27 AM
delphij committed rS342844: MFC r340359:.
MFC r340359:
Jan 7 2019, 7:12 AM

Jan 6 2019

delphij committed rS342814: Remove unneeded assert.h (there is no assertion in this file)..
Remove unneeded assert.h (there is no assertion in this file).
Jan 6 2019, 8:42 PM
delphij committed rS342813: Remove unneeded headers..
Remove unneeded headers.
Jan 6 2019, 8:39 PM
delphij committed rP489523: Update to 1.8..
Update to 1.8.
Jan 6 2019, 7:28 PM

Jan 4 2019

delphij added a comment to D18536: Add bounds checking to the tws(4) passthrough ioctl handler..

LGTM (the unlocked use of sc->ioctl_data_mem looks worrisome to me, but the proposed change won't worsen the situation). Do you have a chance to test this on real hardware? (@jpaetzel do you know someone who may be able to help with that?).

My last 9750 died a while ago. I'll ping Austin @ ix to see if he can rig up a system for us to test with.

Ping?

I haven't been deemed worthy of a reply, so I guess that's a no.

Jan 4 2019, 6:57 PM

Jan 1 2019

delphij committed rS342665: MFC r342661: Happy New Year 2019!.
MFC r342661: Happy New Year 2019!
Jan 1 2019, 12:48 AM
delphij committed rS342664: MFC r333391 (imp): Remove 'All Rights Reserved' from the collection copyright.
MFC r333391 (imp): Remove 'All Rights Reserved' from the collection copyright
Jan 1 2019, 12:43 AM
delphij committed rS342663: MFC r342661: Happy New Year 2019!.
MFC r342661: Happy New Year 2019!
Jan 1 2019, 12:35 AM
delphij committed rS342661: Happy New Year 2019!.
Happy New Year 2019!
Jan 1 2019, 12:25 AM

Dec 31 2018

delphij committed rP488846: Update to 1.10..
Update to 1.10.
Dec 31 2018, 11:13 PM
delphij committed rP488845: Update to 1.7..
Update to 1.7.
Dec 31 2018, 11:09 PM
delphij committed rP488844: Update to 1.44..
Update to 1.44.
Dec 31 2018, 11:03 PM
delphij committed rS342640: Ensure buffer is nul-terminated..
Ensure buffer is nul-terminated.
Dec 31 2018, 3:08 AM

Dec 30 2018

delphij committed rS342633: Fix various issues with Chinese locales:.
Fix various issues with Chinese locales:
Dec 30 2018, 11:04 PM
delphij closed D18689: Fix various issues with Chinese locales..
Dec 30 2018, 11:04 PM
delphij added a comment to D18689: Fix various issues with Chinese locales..

I would think this would affect any program that calls strftime(3) with abbreviated weekday name (%a),
for example ps(1):

https://svnweb.freebsd.org/base/head/bin/ps/print.c?revision=335023&view=markup#l411

410             } else if (now - k->ki_p->ki_start.tv_sec < 7 * 86400) {
411                             (void)strftime(buf, buflen, "%a%H  ", tp);

then it would just print out a here instead of 周五:

% env LANG=zh_CN.UTF-8 ps auwwx | grep '[s]bin/sshd'
root 26612  0.0  0.0 20784  100  -  IsJ  五12    0:00.02 /usr/sbin/sshd

% env LANG=en_US.UTF-8 ps auwwx | grep '[s]bin/sshd'
root 26612  0.0  0.0 20784  100  -  IsJ  Fri12   0:00.02 /usr/sbin/sshd
Dec 30 2018, 10:37 PM
delphij added a reviewer for D18689: Fix various issues with Chinese locales.: loader.
Dec 30 2018, 8:47 AM
delphij updated the summary of D18689: Fix various issues with Chinese locales..
Dec 30 2018, 8:46 AM
delphij updated the diff for D18689: Fix various issues with Chinese locales..

Rebase after r342614.

Dec 30 2018, 8:39 AM
delphij committed rS342614: Properly set svn:mimetype for zh_CN.UTF-8.src..
Properly set svn:mimetype for zh_CN.UTF-8.src.
Dec 30 2018, 8:30 AM
delphij updated the diff for D18689: Fix various issues with Chinese locales..

Properly set MIME type for zh_CN.UTF-8.src.

Dec 30 2018, 8:03 AM
delphij created D18689: Fix various issues with Chinese locales..
Dec 30 2018, 8:01 AM
delphij committed rP488700: Update to 0.9.23..
Update to 0.9.23.
Dec 30 2018, 6:29 AM

Dec 21 2018

delphij added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

Looks good to me (except please do use FBSD_1.6 version).

Dec 21 2018, 7:21 PM
delphij committed rP487953: Update to 2.4.47..
Update to 2.4.47.
Dec 21 2018, 6:40 AM

Dec 13 2018

delphij accepted D18536: Add bounds checking to the tws(4) passthrough ioctl handler..

LGTM (the unlocked use of sc->ioctl_data_mem looks worrisome to me, but the proposed change won't worsen the situation). Do you have a chance to test this on real hardware? (@jpaetzel do you know someone who may be able to help with that?).

Dec 13 2018, 12:55 AM

Dec 11 2018

delphij committed rS341811: Remove questionable initialization for ICH8M, rely on BIOS to properly.
Remove questionable initialization for ICH8M, rely on BIOS to properly
Dec 11 2018, 5:10 AM
delphij closed D18300: Remove special initialization for ICH8M.
Dec 11 2018, 5:10 AM

Dec 10 2018

delphij added inline comments to D18300: Remove special initialization for ICH8M.
Dec 10 2018, 7:16 PM
delphij retitled D18300: Remove special initialization for ICH8M from Force all ports active after AHCI initialization for Intel controllers. to Remove special initialization for ICH8M.
Dec 10 2018, 7:22 AM
delphij updated the diff for D18300: Remove special initialization for ICH8M.

Remove ICH8M specific initialization.

Dec 10 2018, 7:20 AM

Dec 6 2018

delphij added a comment to D18456: Add zdopen(), for use in capability mode..

LGTM, thanks!

Dec 6 2018, 7:51 PM
delphij accepted D18456: Add zdopen(), for use in capability mode..
Dec 6 2018, 7:02 PM
delphij accepted D18456: Add zdopen(), for use in capability mode..

LGTM.

Dec 6 2018, 6:16 PM

Nov 22 2018

delphij created D18300: Remove special initialization for ICH8M.
Nov 22 2018, 7:33 PM

Nov 14 2018

delphij accepted D17984: Update secteam. Promote remko to Deputy. Update core team liason to reflect brooks taking the job..

LGTM.

Nov 14 2018, 4:55 PM

Nov 12 2018

delphij committed rS340359: Make outfile constant..
Make outfile constant.
Nov 12 2018, 7:14 AM

Oct 30 2018

delphij committed rS339918: Restore backward compatibility for "attach" verb..
Restore backward compatibility for "attach" verb.
Oct 30 2018, 3:11 PM

Oct 27 2018

delphij committed rS339804: Restore backward compatibility for "attach" verb..
Restore backward compatibility for "attach" verb.
Oct 27 2018, 3:37 AM
delphij closed D17680: Restore backward compatibility for "attach" verb..
Oct 27 2018, 3:37 AM

Oct 26 2018

delphij added reviewers for D17680: Restore backward compatibility for "attach" verb.: mav, emaste, gordon.
Oct 26 2018, 5:29 AM
delphij added a comment to D17680: Restore backward compatibility for "attach" verb..

Please take another look, thanks!

Oct 26 2018, 3:51 AM
delphij updated the diff for D17680: Restore backward compatibility for "attach" verb..

Address style(9) issues pointed out by oshogbo.

Oct 26 2018, 3:50 AM

Oct 25 2018

delphij committed rS339706: Now that the portsnap buildbox is generating the raw bits for INDEX-13,.
Now that the portsnap buildbox is generating the raw bits for INDEX-13,
Oct 25 2018, 8:06 AM

Oct 24 2018

delphij added inline comments to D17680: Restore backward compatibility for "attach" verb..
Oct 24 2018, 7:06 PM
delphij updated the diff for D17680: Restore backward compatibility for "attach" verb..

Correct size for dryrun.

Oct 24 2018, 8:34 AM
delphij created D17680: Restore backward compatibility for "attach" verb..
Oct 24 2018, 6:39 AM

Oct 12 2018

delphij added inline comments to D17541: update ZFS to note support of extended attributes.
Oct 12 2018, 10:55 PM

Sep 26 2018

delphij added inline comments to D15119: Handle overflow of uid or gid in arguments for chown.
Sep 26 2018, 6:33 PM · Contributor Reviews (base)

Sep 25 2018

delphij committed rS338923: Partial MFC of r338542:.
Partial MFC of r338542:
Sep 25 2018, 5:18 AM

Sep 14 2018

delphij accepted D17047: Fortuna: Add failpoints to simulate initial seeding conditions.
Sep 14 2018, 5:03 PM
delphij added reviewers for D17047: Fortuna: Add failpoints to simulate initial seeding conditions: O3: Kernel Random Numbers Generator, secteam.
Sep 14 2018, 5:03 PM

Sep 11 2018

delphij accepted D17118: Add OPIE deprecation notice.

I think you might want to bump the date (currently read as "January 10, 1995") when committing but it looks otherwise fine to me.

Sep 11 2018, 4:48 PM

Sep 10 2018

delphij added a comment to D16857: Introduce certctl(8).

Minor nit: could you please quote variables with {} (e.g. $VAR -> ${VAR})?

Sep 10 2018, 5:58 PM

Sep 9 2018

delphij committed rS338542: random(4): Squash non-error timeout codes from tsleep(9)..
random(4): Squash non-error timeout codes from tsleep(9).
Sep 9 2018, 5:12 PM
delphij closed D17049: random(4): Squash non-error timeout codes from tsleep(9).
Sep 9 2018, 5:12 PM

Sep 8 2018

delphij committed rS338531: MFC r338126: MFV r338092: ntp 4.2.8p12..
MFC r338126: MFV r338092: ntp 4.2.8p12.
Sep 8 2018, 4:10 AM
delphij committed rS338530: MFC r338126: MFV r338092: ntp 4.2.8p12..
MFC r338126: MFV r338092: ntp 4.2.8p12.
Sep 8 2018, 4:10 AM

Sep 7 2018

delphij committed rD52232: Update my key..
Update my key.
Sep 7 2018, 10:37 AM

Sep 6 2018

delphij accepted D17050: getentropy(3): Trap non-API errnos from getrandom(2) and abort.

LGTM

Sep 6 2018, 8:38 PM