In D34940#792579, @mav wrote:

I've just noticed this touches only kernel. It would probably be good for consistency do the same in user-space (lib/geom), like gpart_backup()/gpart_restore()/gpart_bootcode()/etc.

Thanks for reviewing! Please take another look, thanks!

Address reviewer comments.

Abandoned in favor of D34952 .

Minor style nit, otherwise looks fine.

Personally I don't really like the bintrans name as it's colliding with some tools that I am using at work, but it's probably just me and I don't insist that :)

In D34699#786398, @emaste wrote:

From the proposed test

// Valid jmp; from specification.
if (sector0[0] != 0xe9 && (sector0[0] != 0xeb || sector0[2] != 0x90))
    return (false);

I don't see this in boot.c now?

I don't think this is right...

Looks mostly good to me, could you please take a look at the minor nits in the inline comments?

LGTM, thanks!

Superseded by D20163