Page MenuHomeFreeBSD

delphij (Xin Li)
User

Projects (9)

User Details

User Since
May 14 2014, 3:53 AM (301 w, 12 h)

Recent Activity

Mon, Feb 17

delphij added inline comments to D23722: Allow default mount options for ZFS.
Mon, Feb 17, 4:58 AM
delphij requested changes to D23722: Allow default mount options for ZFS.

Some minor nits.

Mon, Feb 17, 1:16 AM

Sun, Feb 16

delphij committed rS357993: MFC r356000: Remove unused includes..
MFC r356000: Remove unused includes.
Sun, Feb 16, 7:06 AM
delphij committed rS357992: MFC r357420: Remove unused include..
MFC r357420: Remove unused include.
Sun, Feb 16, 6:35 AM

Tue, Feb 11

delphij committed rS357757: MFV r357712: file 5.38..
MFV r357712: file 5.38.
Tue, Feb 11, 7:03 AM

Mon, Feb 10

delphij committed rS357716: Use humanize_number to format available and bad space sizes..
Use humanize_number to format available and bad space sizes.
Mon, Feb 10, 4:17 AM
delphij closed D23050: Use humanize_number to format available and bad space sizes..
Mon, Feb 10, 4:17 AM
delphij committed rP525689: www/grafana6: update to 6.6.1..
www/grafana6: update to 6.6.1.
Mon, Feb 10, 3:51 AM
delphij committed rS357713: Tag file 5.38..
Tag file 5.38.
Mon, Feb 10, 1:34 AM
delphij committed rS357712: Vendor import of file 5.38.
Vendor import of file 5.38
Mon, Feb 10, 1:34 AM

Sun, Feb 9

delphij committed rP525671: archivers/lzlib: update to 1.11..
archivers/lzlib: update to 1.11.
Sun, Feb 9, 8:45 PM
delphij committed rP525621: net/openldap24-server: skip database existence check..
net/openldap24-server: skip database existence check.
Sun, Feb 9, 4:02 AM

Thu, Feb 6

delphij committed rS357609: MFV r357608: Limit memory usage in xz(1) instead of in tuklib..
MFV r357608: Limit memory usage in xz(1) instead of in tuklib.
Thu, Feb 6, 7:47 AM
delphij closed D23474: Limit memory usage in xz(1)..
Thu, Feb 6, 7:47 AM
delphij committed rS357608: Apply a reduced version of upstream 353970510895f6a80adfe60cf71b70a95adfa8bc.
Apply a reduced version of upstream 353970510895f6a80adfe60cf71b70a95adfa8bc
Thu, Feb 6, 7:45 AM

Wed, Feb 5

delphij committed rS357568: MFC r356249-r356250, r356313, r356434, r356657, r357421.
MFC r356249-r356250, r356313, r356434, r356657, r357421
Wed, Feb 5, 8:55 AM

Tue, Feb 4

delphij committed rP525128: www/pomerium: update to 0.6.2..
www/pomerium: update to 0.6.2.
Tue, Feb 4, 8:19 AM
delphij committed rP525122: www/grafana6: update to 6.6.0.
www/grafana6: update to 6.6.0
Tue, Feb 4, 5:45 AM

Mon, Feb 3

delphij committed rP525019: Update to 2.4.49..
Update to 2.4.49.
Mon, Feb 3, 7:17 AM
delphij accepted D23433: loader: rewrite zfs reader zap code to use malloc.

LGTM. There are a few minor nits but these are optional.

Mon, Feb 3, 2:49 AM
delphij created D23474: Limit memory usage in xz(1)..
Mon, Feb 3, 1:04 AM

Sun, Feb 2

delphij committed rS357421: Diff reduction against NetBSD, no functional change..
Diff reduction against NetBSD, no functional change.
Sun, Feb 2, 8:53 PM
delphij committed rS357420: Remove unused include..
Remove unused include.
Sun, Feb 2, 8:51 PM

Tue, Jan 28

delphij committed rS357196: MFC r356629, r356636.
MFC r356629, r356636
Tue, Jan 28, 7:50 AM

Sat, Jan 25

delphij committed rP524025: Update to 0.6.0..
Update to 0.6.0.
Sat, Jan 25, 10:23 AM

Jan 14 2020

delphij committed rS356722: MFC r356628: Require FAT to occupy at least one sector..
MFC r356628: Require FAT to occupy at least one sector.
Jan 14 2020, 6:28 AM

Jan 12 2020

delphij abandoned D21479: WIP: Make fsck_msdosfs use less memory..
Jan 12 2020, 7:45 AM
delphij committed rS356657: Tighten FAT checks and fix off-by-one error in corner case..
Tighten FAT checks and fix off-by-one error in corner case.
Jan 12 2020, 6:14 AM
delphij closed D23065: Tighten FAT checks and fix off-by-one error in corner case..
Jan 12 2020, 6:14 AM
delphij updated the diff for D23050: Use humanize_number to format available and bad space sizes..

Keep existing code for platforms where humanize_number(3) is not available.

Jan 12 2020, 5:34 AM

Jan 11 2020

delphij committed rS356636: Correct off-by-two issue when determining FAT type..
Correct off-by-two issue when determining FAT type.
Jan 11 2020, 5:41 PM
delphij closed D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..
Jan 11 2020, 5:41 PM
delphij added a comment to D22493: Support for bcm2838 RNG.

Looks mostly fine to me.

Jan 11 2020, 9:43 AM · arm64
delphij updated the diff for D22493: Support for bcm2838 RNG.

Refresh diff with svn head.

Jan 11 2020, 9:30 AM · arm64
delphij updated the summary of D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..
Jan 11 2020, 4:05 AM
delphij updated the diff for D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..

Reduce the patch back to original (NetBSD sync was merged).

Jan 11 2020, 4:05 AM
delphij committed rS356629: Apply typo fix from NetBSD, we have already applied all NetBSD changes so.
Apply typo fix from NetBSD, we have already applied all NetBSD changes so
Jan 11 2020, 4:03 AM
delphij committed rS356628: Require FAT to occupy at least one sector..
Require FAT to occupy at least one sector.
Jan 11 2020, 3:59 AM

Jan 10 2020

delphij updated the summary of D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..
Jan 10 2020, 6:57 AM
delphij updated the diff for D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..

Sync with NetBSD which added more boundary checks.

Jan 10 2020, 6:35 AM

Jan 8 2020

delphij updated the summary of D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..
Jan 8 2020, 8:57 AM
delphij created D23082: sbin/fsck_msdosfs: Correct off-by-two issue when determining FAT type..
Jan 8 2020, 8:56 AM

Jan 7 2020

delphij added a comment to D23050: Use humanize_number to format available and bad space sizes..

My confusion is what "clusters" represent. Apparently a cluster is a 32KB block. Based on your clarification, I now agree with your calculation and printing of free space, but suggest that you clarify that clusters are 32KB blocks (either by replacing the word "clusters" with "32KB blocks", or if clusters is meaningful to administrators change it to "32KB clusters").

Jan 7 2020, 6:31 PM
delphij created D23065: Tighten FAT checks and fix off-by-one error in corner case..
Jan 7 2020, 5:32 AM
delphij planned changes to D23050: Use humanize_number to format available and bad space sizes..

The current output is number of free blocks and number of bad blocks.

Jan 7 2020, 4:49 AM
delphij committed rS356434: fsck_msdosfs.8: document -M..
fsck_msdosfs.8: document -M.
Jan 7 2020, 4:33 AM
delphij closed D23049: fsck_msdosfs.8: document -M.
Jan 7 2020, 4:33 AM

Jan 6 2020

delphij created D23050: Use humanize_number to format available and bad space sizes..
Jan 6 2020, 9:18 AM
delphij created D23049: fsck_msdosfs.8: document -M.
Jan 6 2020, 9:17 AM

Jan 3 2020

delphij committed rP521907: finance/fava: update to 1.12..
finance/fava: update to 1.12.
Jan 3 2020, 7:18 AM
delphij committed rS356313: Reduce memory footprint of fsck_msdosfs..
Reduce memory footprint of fsck_msdosfs.
Jan 3 2020, 12:32 AM

Jan 1 2020

delphij committed rS356250: Revert r356249 for now as it broke GCC builds..
Revert r356249 for now as it broke GCC builds.
Jan 1 2020, 9:22 AM
delphij committed rS356249: Reduce memory footprint of fsck_msdosfs..
Reduce memory footprint of fsck_msdosfs.
Jan 1 2020, 7:43 AM
delphij closed D22965: Reduce memory footprint of fsck_msdosfs..
Jan 1 2020, 7:43 AM

Dec 31 2019

delphij updated the diff for D22965: Reduce memory footprint of fsck_msdosfs..

Address some feedback from kevlo@ for style, avoid using unnecessary
brackets.

Dec 31 2019, 8:09 PM
delphij updated the diff for D22965: Reduce memory footprint of fsck_msdosfs..

copyfat(): distinguish between failed read (fatal) and write (not fatal).

Dec 31 2019, 5:35 AM
delphij updated the diff for D22965: Reduce memory footprint of fsck_msdosfs..

Use FSOK/FSFATAL/FSERROR for fat_flush_fat32_cache_entry instead of
0 and 1, suggested by kevlo@.

Dec 31 2019, 5:19 AM

Dec 30 2019

delphij created D22965: Reduce memory footprint of fsck_msdosfs..
Dec 30 2019, 8:49 AM

Dec 25 2019

delphij added a comment to D6442: Make more use of arc4random() in the kernel..
In D6442#502200, @pfg wrote:

Hmm ...
When arc4random was introduced in OpenBSD the idea was to have one unique random algorithm to replace them all. This patch is old and reflects that idea. I am now thinking , that that is not the real objective for us.

Dec 25 2019, 8:35 PM

Dec 22 2019

delphij committed rP520645: MFH: r520644.
MFH: r520644
Dec 22 2019, 5:46 PM
delphij committed rP520644: Upgrade mediawiki LTS (www/mediawiki131) to 1.31.6;.
Upgrade mediawiki LTS (www/mediawiki131) to 1.31.6;
Dec 22 2019, 5:43 PM
delphij committed rS356000: Remove unused includes..
Remove unused includes.
Dec 22 2019, 5:44 AM
delphij committed rS355999: MFC r355318, r355513.
MFC r355318, r355513
Dec 22 2019, 5:43 AM
delphij committed rS355998: MFC r355318, r355513.
MFC r355318, r355513
Dec 22 2019, 5:39 AM

Dec 20 2019

delphij accepted D22878: random(4): Flip default Fortuna generator over to Chacha20.
Dec 20 2019, 12:20 AM
delphij accepted D22879: random(4): Fortuna: Enable concurrent generation by default for 13.
Dec 20 2019, 12:16 AM

Dec 18 2019

delphij added a comment to D22839: random(4) fenestrasX: Push root seed version to arc4random(3).
In D22839#500542, @cem wrote:

Moving unrelated discussion off the line comment.
@delphij wrote:

I do have some doubts with the benefit of performing reseeding upon root seed refresh. Effectively, it triggers an immediate reseed so applications that does arc4random(3) a lot would hammer the system entropy source in an hourly basis (with the existing code, they are relatively independent and only reseeds when arc4random(3) thinks necessary, either when we generated enough output, or have forked, whichever comes first). This seems to be a bad design choice for both security (the randomness caused by accumulated scheduling skews between arc4random(3) calls in the system are now gone) and performance (tends to do something computational intensive in hourly basis).

Applications that "hammer" arc4random already hammer system entropy much more frequently than hourly; arc4random will reseed every 5 minutes or 1kB today. arc4random(3) can generate 1kB buffers at 400 MB/s, reseeding 400,000 times per second already. A root version reseed only causes an additional reseed to occur that would not have occurred otherwise if the application was reading at a rate of less than 1kB / 5 minutes, or ~3.4 B/sec. That's a fairly low rate. The random device can emit 32-bit PRNG seeds to a single userspace thread at 80 MB/s (2,500,000 times per second), including syscall overhead. (All figures from an INVARIANTS test VM.) I think the performance concern in this particular hypothetical is not especially substantial.
I don't think the security concern is profound, either. We arguably lose a handful of bits of entropy from arc4random(3) syscalls within a few minutes of an hour boundary, sure. If those handful of bits are really all the entropy we're collecting, everything is broken, including Fortuna. Applications only reseed on-demand, when they actually invoke arc4random(3). In practice, this may be long after the root seed version has changed (it is possible for an application to observe the seed version jump by >1 between arc4random(3) reads). I think you are probably overweighing the entropy value of the particular scheduler skew.

Dec 18 2019, 8:58 AM
delphij accepted D22859: oce: Tighten input validation for SIOCGI2C..
Dec 18 2019, 8:27 AM
delphij committed rS355877: MFC r355317:.
MFC r355317:
Dec 18 2019, 8:09 AM
delphij committed rP520365: Update to 6.5.2..
Update to 6.5.2.
Dec 18 2019, 6:53 AM

Dec 17 2019

delphij added inline comments to D22839: random(4) fenestrasX: Push root seed version to arc4random(3).
Dec 17 2019, 11:40 PM
delphij committed rP520316: Fix a typo in startup script..
Fix a typo in startup script.
Dec 17 2019, 8:37 AM

Dec 16 2019

delphij committed rP520218: Add Pomerium, an identity-aware proxy that enables secure access to.
Add Pomerium, an identity-aware proxy that enables secure access to
Dec 16 2019, 6:09 AM

Dec 15 2019

delphij committed rS355772: MFC r355222, r355260:.
MFC r355222, r355260:
Dec 15 2019, 8:23 AM

Dec 14 2019

delphij committed rS355749: MFC r355247: Reduce disk write load in /usr/libexec/save-entropy..
MFC r355247: Reduce disk write load in /usr/libexec/save-entropy.
Dec 14 2019, 9:54 AM
delphij committed rS355748: MFC r345744, r348122, r355247.
MFC r345744, r348122, r355247
Dec 14 2019, 9:49 AM

Dec 12 2019

delphij committed rP519855: www/grafana6: update to 6.5.1.
www/grafana6: update to 6.5.1
Dec 12 2019, 7:39 AM

Dec 11 2019

delphij committed rS355604: MFC r340127,340133,355085: libbsdxml (expat) 2.2.9..
MFC r340127,340133,355085: libbsdxml (expat) 2.2.9.
Dec 11 2019, 6:35 AM
delphij committed rS355603: MFC r340127,340133,355085: libbsdxml (expat) 2.2.9..
MFC r340127,340133,355085: libbsdxml (expat) 2.2.9.
Dec 11 2019, 6:31 AM

Dec 8 2019

delphij committed rS355513: Fix a couple of minor issues with newfs_msdos:.
Fix a couple of minor issues with newfs_msdos:
Dec 8 2019, 1:20 AM
delphij closed D22729: Fix a couple of minor issues with newfs_msdos.
Dec 8 2019, 1:20 AM
delphij created D22729: Fix a couple of minor issues with newfs_msdos.
Dec 8 2019, 1:06 AM

Dec 7 2019

delphij committed rP519256: net/openldap24-server: back_mdb: use robust mutexes..
net/openldap24-server: back_mdb: use robust mutexes.
Dec 7 2019, 11:31 PM
delphij committed rP519246: - Drop support of FreeBSD < 11.0.
- Drop support of FreeBSD < 11.0
Dec 7 2019, 10:47 PM
delphij committed rP519234: Perform sanity check of configuration at start..
Perform sanity check of configuration at start.
Dec 7 2019, 7:19 PM
delphij committed rS355504: MFC r349549: MFV r349535: less v551..
MFC r349549: MFV r349535: less v551.
Dec 7 2019, 7:06 PM
delphij committed rS355503: MFC r349549: MFV r349535: less v551..
MFC r349549: MFV r349535: less v551.
Dec 7 2019, 7:02 PM

Dec 3 2019

delphij committed rS355318: Explicitly exit() instead of return in main()..
Explicitly exit() instead of return in main().
Dec 3 2019, 7:03 AM
delphij committed rS355317: newfs_msdos: -A is incompatible with -r, not -o..
newfs_msdos: -A is incompatible with -r, not -o.
Dec 3 2019, 7:01 AM

Dec 1 2019

delphij committed rS355260: Simplify code with strlcpy/strlcat..
Simplify code with strlcpy/strlcat.
Dec 1 2019, 8:04 AM
delphij committed rP518749: Unbreak KQUEUE.
Unbreak KQUEUE
Dec 1 2019, 3:32 AM

Nov 30 2019

delphij committed rS355247: Reduce disk write load in /usr/libexec/save-entropy..
Reduce disk write load in /usr/libexec/save-entropy.
Nov 30 2019, 8:07 PM
delphij closed D22612: Reduce disk write load in /usr/libexec/save-entropy.
Nov 30 2019, 8:07 PM
delphij added a comment to D22612: Reduce disk write load in /usr/libexec/save-entropy.

(Note that the new revision also changed permission from 400 r-------- to 600 rw-------, and umask from 377 to 177, because the non-root user needs write permission to modify the inode).

Nov 30 2019, 6:33 PM
delphij updated the diff for D22612: Reduce disk write load in /usr/libexec/save-entropy.

Fix issues pointed out by cem@

Nov 30 2019, 6:27 PM
delphij added a comment to D22612: Reduce disk write load in /usr/libexec/save-entropy.

Thanks for the review, please take another look.

Nov 30 2019, 6:27 PM
delphij added reviewers for D22612: Reduce disk write load in /usr/libexec/save-entropy: emaste, gordon, cem.
Nov 30 2019, 9:16 AM
delphij created D22612: Reduce disk write load in /usr/libexec/save-entropy.
Nov 30 2019, 9:15 AM
delphij committed rP518705: net/openldap24-server: add support for pbkdf2 password hash.
net/openldap24-server: add support for pbkdf2 password hash
Nov 30 2019, 6:19 AM
delphij committed rP518704: devel/py-pyasn1: update to 0.4.7.
devel/py-pyasn1: update to 0.4.7
Nov 30 2019, 6:16 AM