delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (183 w, 4 d)

Recent Activity

Today

delphij committed rS325994: Remove unused header..
Remove unused header.
Sun, Nov 19, 3:52 AM
delphij committed rS325993: Remove unused header..
Remove unused header.
Sun, Nov 19, 3:52 AM

Fri, Nov 17

delphij requested changes to D13117: Simplified Chinese Documentation Project: Update share/xml/release.l10n.ent.
Fri, Nov 17, 6:11 PM
delphij added a comment to D13120: Simplified Chinese Documentation Project: Update share/xml/l10n.ent.

Quick question -- are these variables really needed, if we don't diverge from English versions?

Fri, Nov 17, 6:02 PM
delphij accepted D12132: Avoid spinning in random_harvest_queue.
Fri, Nov 17, 6:00 PM

Mon, Nov 13

delphij committed rS325755: Be more careful when doing calculation with request from userland..
Be more careful when doing calculation with request from userland.
Mon, Nov 13, 7:47 AM

Sun, Nov 12

delphij added inline comments to D9396: geli attach multiple providers (with kernel changes).
Sun, Nov 12, 5:26 AM

Sat, Nov 11

delphij closed D13024: Don't terminate when statfs() fails..
Sat, Nov 11, 7:19 PM
delphij committed rS325723: find(1): Don't treat statfs() error as fatal in f_fstype, which can happen.
find(1): Don't treat statfs() error as fatal in f_fstype, which can happen
Sat, Nov 11, 7:19 PM
delphij updated the diff for D13024: Don't terminate when statfs() fails..

Address jilles's comments.

Sat, Nov 11, 7:46 AM

Fri, Nov 10

delphij created D13024: Don't terminate when statfs() fails..
Fri, Nov 10, 8:04 AM

Wed, Nov 8

delphij committed rS325532: Update arcmsr(4) to 1.40.00.01:.
Update arcmsr(4) to 1.40.00.01:
Wed, Nov 8, 8:21 AM

Tue, Nov 7

delphij committed rD51179: Please welcome Gordon Tetlow as the new Security Officer..
Please welcome Gordon Tetlow as the new Security Officer.
Tue, Nov 7, 3:51 PM
delphij closed D12923: Please welcome Gordon Tetlow as the new Security Officer..
Tue, Nov 7, 3:51 PM

Sat, Nov 4

delphij committed rS325383: Avoid calling get_controller_count() until attaching, this would avoid.
Avoid calling get_controller_count() until attaching, this would avoid
Sat, Nov 4, 6:20 AM

Fri, Nov 3

delphij created D12923: Please welcome Gordon Tetlow as the new Security Officer..
Fri, Nov 3, 5:59 AM

Mon, Oct 30

delphij committed rP453157: Improve robustness of owner/mode settings..
Improve robustness of owner/mode settings.
Mon, Oct 30, 5:59 AM
delphij closed D12726: Improve robustness of owner/mode settings..
Mon, Oct 30, 5:59 AM
delphij committed rP453156: Workaround an issue with kqueue support..
Workaround an issue with kqueue support.
Mon, Oct 30, 5:53 AM

Sat, Oct 28

delphij added a reviewer for D12808: Don't set a harvest_mask by default.: O3: Kernel Random Numbers Generator.
Sat, Oct 28, 7:56 AM
delphij added a comment to D12813: Ensure random_source_descr[] does not get out of sync.

The change itself looks Okay to me, but I might have missed some background discussion -- why do we need to CTASSERT for something already defined in that way a few lines above?

Sat, Oct 28, 7:55 AM

Oct 19 2017

delphij created D12726: Improve robustness of owner/mode settings..
Oct 19 2017, 8:14 AM

Oct 16 2017

delphij committed rS324655: Remove the libstand directory which is now empty..
Remove the libstand directory which is now empty.
Oct 16 2017, 4:46 AM

Oct 12 2017

delphij added a comment to D9396: geli attach multiple providers (with kernel changes).

I like the idea by the way.

Oct 12 2017, 4:49 PM
delphij added inline comments to D9396: geli attach multiple providers (with kernel changes).
Oct 12 2017, 4:49 PM

Oct 7 2017

delphij accepted D12618: random(4): Add missing source descriptions.
Oct 7 2017, 6:56 PM
delphij accepted D12611: random(4): Gather entropy from Pure sources.
Oct 7 2017, 6:45 PM
delphij added inline comments to D12611: random(4): Gather entropy from Pure sources.
Oct 7 2017, 5:47 PM
delphij committed rP451425: Add experimental kqueue support [1]:.
Add experimental kqueue support [1]:
Oct 7 2017, 4:53 AM

Oct 6 2017

delphij added a comment to D12132: Avoid spinning in random_harvest_queue.
In D12132#254430, @jmg wrote:

So, you'll still suffer terribly with this, as random_harvest_fast is not PCPU, so you'll have the cache line bouncing around.

IMO, as we feed in the mbuf (and not the mbuf cluster) we are not getting great entropy from the current ethernet harvester. One solution would be to turn off all ethernet harvesting, and enable INTR_ENTROPY on all the ethernet drivers. This will provide timing data for each interrupt, which is good for a couple bits of entropy. This will automatically scale down the rate as most high end ethernet cards do interrupt coalescing.

We don't need to collect THAT much entropy from the system. We should assume we have a good seed (and an uncompromised seed). If it does get compromised, it's more about a time to recovery. We do not need to be "collecting" thousands of bits of entropy every second, even just 10 bit per second not including RDRAND, (we poll RDRAND a minimum of 10 times per second, it increases 2x+𝛆 per bytes read from /dev/random, and it provides 64-bits EACH poll, or 640 bits per second), would give a recover time of under 30 seconds.

Oct 6 2017, 6:32 PM
delphij added inline comments to D12611: random(4): Gather entropy from Pure sources.
Oct 6 2017, 6:29 PM
delphij accepted D12610: random(4): Discard low entropy inputs.
Oct 6 2017, 6:18 PM
delphij added inline comments to D12611: random(4): Gather entropy from Pure sources.
Oct 6 2017, 6:10 PM

Sep 27 2017

delphij committed rP450722: Reorder several variable definitions in Makefile..
Reorder several variable definitions in Makefile.
Sep 27 2017, 6:58 AM
delphij committed rP450721: Remove unnecessary '@exec mkdir -p %D/libexec/openldap' line from pkg-plist..
Remove unnecessary '@exec mkdir -p %D/libexec/openldap' line from pkg-plist.
Sep 27 2017, 6:41 AM
delphij committed rP450720: Unmute all commands at install stage..
Unmute all commands at install stage.
Sep 27 2017, 6:31 AM
delphij committed rP450718: There is no MODULES options, remove it..
There is no MODULES options, remove it.
Sep 27 2017, 6:15 AM
delphij committed rP450717: Replace 'EXTRACT_SUFX=.tgz' with 'USES=tar.tgz'..
Replace 'EXTRACT_SUFX=.tgz' with 'USES=tar.tgz'.
Sep 27 2017, 6:01 AM
delphij committed rP450716: Remove ftp.dti.ad.jp from MASTER_SITES. It is unavailable for a log time..
Remove ftp.dti.ad.jp from MASTER_SITES. It is unavailable for a log time.
Sep 27 2017, 5:56 AM
delphij committed rP450715: Use @preunexec in favor of the deprecated @unexec..
Use @preunexec in favor of the deprecated @unexec.
Sep 27 2017, 5:53 AM
delphij committed rP450713: Add LASTBIND option..
Add LASTBIND option.
Sep 27 2017, 5:40 AM

Sep 25 2017

delphij added a comment to D12405: Diff showing stock tcpdump 4.9.2 vs FreeBSD 4.9.2.

Looks good to me, adding a few other committers just in case.

Sep 25 2017, 5:59 AM
delphij accepted D12405: Diff showing stock tcpdump 4.9.2 vs FreeBSD 4.9.2.
Sep 25 2017, 5:58 AM
delphij added reviewers for D12405: Diff showing stock tcpdump 4.9.2 vs FreeBSD 4.9.2: rpaulo, hiren.
Sep 25 2017, 5:57 AM

Sep 18 2017

delphij accepted D12015: Simplified Chinese Translation Project: Update where.xsl.

Sorry for the delay. Looks good to me now, thanks!

Sep 18 2017, 4:25 PM
delphij accepted D12403: Instead of keeping a one off copy of the generated man page, follow the same pattern as the file(1) utility and generate the man page from the sources as part of the build..

LGTM, approved.

Sep 18 2017, 4:23 PM

Aug 28 2017

delphij planned changes to D12136: Use 64-bit quantities for memory..

Need more work.

Aug 28 2017, 7:35 AM
delphij updated the diff for D12136: Use 64-bit quantities for memory..

(fixed a few bugs, tested with 2+TB ARC by quakelee at gmail.com).

Aug 28 2017, 6:14 AM

Aug 27 2017

delphij added a reviewer for D12136: Use 64-bit quantities for memory.: emaste.
Aug 27 2017, 6:31 PM
delphij created D12136: Use 64-bit quantities for memory..
Aug 27 2017, 6:24 PM

Aug 26 2017

delphij added a comment to D12076: Patch contrib/libpcap 1.8 to fix builds.
In D12076#251688, @feld wrote:

If you meant a FreeBSD bug report, no -- this was something I discovered and resolved, but did not open a bug report for the FreeBSD project.

Aug 26 2017, 5:44 AM
delphij committed rP448750: MFH: r445440 r447762.
MFH: r445440 r447762
Aug 26 2017, 5:00 AM

Aug 25 2017

delphij accepted D12076: Patch contrib/libpcap 1.8 to fix builds.

Sorry didn't act on this earlier.

Aug 25 2017, 5:43 PM
delphij accepted D11606: security.xml: minor wordsmithing.
Aug 25 2017, 5:40 PM

Aug 24 2017

delphij committed rP448646: MFH: r448645.
MFH: r448645
Aug 24 2017, 4:11 AM
delphij committed rP448645: Security update to 2017-02-19e..
Security update to 2017-02-19e.
Aug 24 2017, 4:10 AM

Aug 20 2017

delphij committed rS322725: MFC r322527:.
MFC r322527:
Aug 20 2017, 7:21 PM
delphij committed rS322716: MFC r322527:.
MFC r322527:
Aug 20 2017, 7:04 AM

Aug 17 2017

delphij committed rP448079: MFH: r448078.
MFH: r448078
Aug 17 2017, 5:05 AM
delphij committed rP448078: Update to 2017-02-19c "Frusterick Manners", fixes XSS vulnerability..
Update to 2017-02-19c "Frusterick Manners", fixes XSS vulnerability.
Aug 17 2017, 5:04 AM

Aug 16 2017

delphij added a comment to D12015: Simplified Chinese Translation Project: Update where.xsl.

There are multiple blank space issues. For consistency, please add space after all punctuation, unless they are immediately followed by a closing tag.

Aug 16 2017, 7:06 PM
delphij requested changes to D12015: Simplified Chinese Translation Project: Update where.xsl.

There are multiple blank space issues. For consistency, please add space after all punctuation, unless they are immediately followed by a closing tag.

Aug 16 2017, 7:06 PM
delphij accepted D12021: aesni: quiet -Wcast-qual.

Looks good to me.

Aug 16 2017, 6:52 PM
delphij added a reviewer for D12021: aesni: quiet -Wcast-qual: secteam.
Aug 16 2017, 6:51 PM

Aug 15 2017

delphij committed rS322527: Plug memory leak in arge_encap()..
Plug memory leak in arge_encap().
Aug 15 2017, 6:02 AM

Aug 14 2017

delphij committed rS322482: Restore gordon’s src commit bit. Welcome back!.
Restore gordon’s src commit bit. Welcome back!
Aug 14 2017, 4:48 AM
delphij committed rS322481: Order alphabetically..
Order alphabetically.
Aug 14 2017, 4:47 AM

Aug 10 2017

delphij accepted D11794: Simplified Chinese Translation Project: Update share/xml/header.l10n.ent and remove layout.
Aug 10 2017, 5:34 PM
delphij committed rD50656: Add SA-17:06, EN-17:07 and EN-17:08..
Add SA-17:06, EN-17:07 and EN-17:08.
Aug 10 2017, 7:15 AM
delphij committed rS322344: Fix OpenSSH Denial of Service vulnerability. [SA-17:06].
Fix OpenSSH Denial of Service vulnerability. [SA-17:06]
Aug 10 2017, 7:00 AM
delphij committed rS322343: Fix OpenSSH Denial of Service vulnerability. [SA-17:06].
Fix OpenSSH Denial of Service vulnerability. [SA-17:06]
Aug 10 2017, 6:59 AM
delphij committed rS322342: Fix OpenSSH Denial of Service vulnerability. [SA-17:06].
Fix OpenSSH Denial of Service vulnerability. [SA-17:06]
Aug 10 2017, 6:59 AM
delphij committed rS322341: Apply upstream fix:.
Apply upstream fix:
Aug 10 2017, 6:36 AM

Aug 6 2017

delphij accepted D11792: Simplified Chinese Translation Project: Update index.xsl.
Aug 6 2017, 9:03 AM
delphij requested changes to D11794: Simplified Chinese Translation Project: Update share/xml/header.l10n.ent and remove layout.

Please see comments inline.

Aug 6 2017, 8:55 AM
delphij requested changes to D11792: Simplified Chinese Translation Project: Update index.xsl.

Thanks for the fixes!

Aug 6 2017, 6:47 AM
delphij committed rD50639: Provide a set of stylesheet for printing..
Provide a set of stylesheet for printing.
Aug 6 2017, 6:09 AM

Aug 4 2017

delphij requested changes to D11792: Simplified Chinese Translation Project: Update index.xsl.
Aug 4 2017, 11:59 PM
delphij requested changes to D11794: Simplified Chinese Translation Project: Update share/xml/header.l10n.ent and remove layout.

Looks good overall, please fix the few minor nits.

Aug 4 2017, 11:54 PM

Aug 2 2017

delphij committed rS321907: MFC r320761:.
MFC r320761:
Aug 2 2017, 5:47 AM
delphij committed rS321906: MFC r320761:.
MFC r320761:
Aug 2 2017, 5:30 AM
delphij committed rS321905: MFC r321713:.
MFC r321713:
Aug 2 2017, 5:18 AM
delphij committed rS321904: MFC r321713:.
MFC r321713:
Aug 2 2017, 5:17 AM

Aug 1 2017

delphij created D11806: Enable IPSEC_SUPPORT..
Aug 1 2017, 3:13 PM

Jul 31 2017

delphij added a reviewer for D11792: Simplified Chinese Translation Project: Update index.xsl: loader.
Jul 31 2017, 6:55 AM

Jul 30 2017

delphij committed rS321713: Bump copyright year..
Bump copyright year.
Jul 30 2017, 6:28 AM

Jul 26 2017

delphij added inline comments to D11739: Simplified Chinese Translation Project: articles/leap-seconds.
Jul 26 2017, 6:30 PM

Jul 22 2017

delphij committed rP446370: Return this back to pool, I no longer use this port..
Return this back to pool, I no longer use this port.
Jul 22 2017, 7:09 AM
delphij committed rP446369: Update to 1.6..
Update to 1.6.
Jul 22 2017, 7:06 AM
delphij committed rP446368: Update to 2.3.4..
Update to 2.3.4.
Jul 22 2017, 7:00 AM
delphij committed rP446367: Update to 1.9..
Update to 1.9.
Jul 22 2017, 6:57 AM

Jul 17 2017

delphij committed rS321071: MFC r320468:.
MFC r320468:
Jul 17 2017, 6:47 AM
delphij committed rS321070: MFC r320468:.
MFC r320468:
Jul 17 2017, 6:45 AM
delphij committed rS321069: MFC r320433:.
MFC r320433:
Jul 17 2017, 6:38 AM
delphij committed rS321068: MFC r320433:.
MFC r320433:
Jul 17 2017, 6:37 AM
delphij committed rS321067: MFC r320986:.
MFC r320986:
Jul 17 2017, 6:28 AM
delphij committed rS321064: MFC r320986:.
MFC r320986:
Jul 17 2017, 2:52 AM

Jul 15 2017

delphij added a member for secteam: gordon.
Jul 15 2017, 4:01 PM
delphij accepted D11606: security.xml: minor wordsmithing.
Jul 15 2017, 4:00 PM

Jul 14 2017

delphij committed rS320986: Update arcmsr(4) to 1.40.00.00 in order to add support of.
Update arcmsr(4) to 1.40.00.00 in order to add support of
Jul 14 2017, 2:53 PM