delphij (Xin Li)
User

Projects (8)

User Details

User Since
May 14 2014, 3:53 AM (223 w, 3 h)

Recent Activity

Yesterday

delphij accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

LGTM.

Tue, Aug 21, 10:31 PM
delphij accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

LGTM as-is, but with some minor suggestions inline.

Tue, Aug 21, 8:26 PM
delphij requested changes to D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

I think the direction is good and the changeset looks good to me in principal. Could you please make a change so it would print errline, which would make it easier for administrators to find out where the issue is?

Tue, Aug 21, 6:42 PM
delphij committed rS338126: MFV r338092: ntp 4.2.8p12..
MFV r338092: ntp 4.2.8p12.
Tue, Aug 21, 2:38 AM

Mon, Aug 20

delphij committed rS338093: Tag ntp 4.2.8p12..
Tag ntp 4.2.8p12.
Mon, Aug 20, 6:10 AM
delphij committed rS338092: Vendor import of ntp-4.2.8p12..
Vendor import of ntp-4.2.8p12.
Mon, Aug 20, 6:08 AM
delphij committed rS338084: In r331279 the code used ENOSYS to check the existence of getrandom(2)..
In r331279 the code used ENOSYS to check the existence of getrandom(2).
Mon, Aug 20, 2:18 AM
delphij closed D16807: Use osreldate to check the existence of getrandom(2)..
Mon, Aug 20, 2:18 AM
delphij updated the diff for D16807: Use osreldate to check the existence of getrandom(2)..

Oops, omit change in stdlib.h.

Mon, Aug 20, 2:02 AM
delphij updated the diff for D16807: Use osreldate to check the existence of getrandom(2)..

Update comment, no functional change.

Mon, Aug 20, 2:02 AM
delphij added inline comments to D16807: Use osreldate to check the existence of getrandom(2)..
Mon, Aug 20, 1:56 AM
delphij created D16807: Use osreldate to check the existence of getrandom(2)..
Mon, Aug 20, 12:44 AM

Sun, Aug 19

delphij committed rS338061: Bump __FreeBSD_version after r338059 (Chacha20 based arc4random(3).
Bump __FreeBSD_version after r338059 (Chacha20 based arc4random(3)
Sun, Aug 19, 5:47 PM
delphij committed rS338059: Update userland arc4random() with OpenBSD's Chacha20 based arc4random()..
Update userland arc4random() with OpenBSD's Chacha20 based arc4random().
Sun, Aug 19, 5:41 PM
delphij closed D16760: Use Chacha20 for userland arc4random() and friends.
Sun, Aug 19, 5:41 PM
delphij added a comment to D16760: Use Chacha20 for userland arc4random() and friends.

Addressed contrib/ntp/lib/isc/random.c issue; heimdal part would be left as-is for now (I think we can use HAVE_RAND but let's do it in a follow up commit).

Sun, Aug 19, 5:17 PM
delphij updated the diff for D16760: Use Chacha20 for userland arc4random() and friends.

Remove #else in contrib/ntp/lib/isc/random.c.

Sun, Aug 19, 5:16 PM
delphij updated the diff for D16760: Use Chacha20 for userland arc4random() and friends.

Remove manual page for arc4random_stir and arc4random_addrandom.

Sun, Aug 19, 9:29 AM
delphij updated the summary of D16760: Use Chacha20 for userland arc4random() and friends.
Sun, Aug 19, 9:03 AM
delphij updated the diff for D16760: Use Chacha20 for userland arc4random() and friends.

Drop chacha_private.h and address various reviewer comments.

Sun, Aug 19, 8:53 AM
delphij requested review of D16760: Use Chacha20 for userland arc4random() and friends.
Sun, Aug 19, 8:53 AM

Sat, Aug 18

delphij committed rS338011: Workaround ECAPMODE for kernels between revision [331280, 337999).
Workaround ECAPMODE for kernels between revision [331280, 337999)
Sat, Aug 18, 8:37 AM
delphij committed rS338011: Workaround ECAPMODE for kernels between revision [331280, 337999).
Workaround ECAPMODE for kernels between revision [331280, 337999)
Sat, Aug 18, 8:32 AM
delphij committed rS337999: Regen after r337998..
Regen after r337998.
Sat, Aug 18, 6:34 AM
delphij committed rS337998: getrandom(2) should not be restricted in capability mode..
getrandom(2) should not be restricted in capability mode.
Sat, Aug 18, 6:32 AM
delphij committed rS337997: Split arc4random_uniform into it's own file and sync with OpenBSD..
Split arc4random_uniform into it's own file and sync with OpenBSD.
Sat, Aug 18, 6:20 AM

Fri, Aug 17

delphij planned changes to D16760: Use Chacha20 for userland arc4random() and friends.

Will commit the arc4random_uniform portion of change (which contained some trivial changes to type to make the code C99 compliant) to reduce the size of this changeset and revise to address some comments with plan outlined inline.

Fri, Aug 17, 10:26 PM
delphij added reviewers for D16760: Use Chacha20 for userland arc4random() and friends: emaste, devnexen_gmail.com, op, naddy, holger_gh_freyther.de, lwhsu.
Fri, Aug 17, 8:30 AM
delphij created D16760: Use Chacha20 for userland arc4random() and friends.
Fri, Aug 17, 8:27 AM

Wed, Aug 15

delphij committed rD52127: Add SA-18:09-SA-18:11, refresh SA-18:08..
Add SA-18:09-SA-18:11, refresh SA-18:08.
Wed, Aug 15, 5:18 AM
delphij committed rS337832: Fix unauthenticated EAPOL-Key decryption vulnerability. [SA-18:11.hostapd].
Fix unauthenticated EAPOL-Key decryption vulnerability. [SA-18:11.hostapd]
Wed, Aug 15, 5:05 AM
delphij committed rS337831: MFC r337819 (cy@): MFV r337818: WPA: Ignore unauthenticated encrypted EAPOL-Key.
MFC r337819 (cy@): MFV r337818: WPA: Ignore unauthenticated encrypted EAPOL-Key
Wed, Aug 15, 5:04 AM
delphij committed rS337829: Revis manual pages. [SA-18:08.tcp].
Revis manual pages. [SA-18:08.tcp]
Wed, Aug 15, 2:31 AM
delphij committed rS337828: Revis manual pages. [SA-18:08.tcp].
Revis manual pages. [SA-18:08.tcp]
Wed, Aug 15, 2:30 AM

Tue, Aug 14

delphij added a comment to D16706: Replace userspace arc4random(3) implementation with Chacha20.
In D16706#355122, @cem wrote:

Hi,

Thanks for the quick feedback!

for example the use of MAP_INHERIT_ZERO or FreeBSD's INHERIT_ZERO to detect fork

That would be an additional enhancement, no? I don't think this change introduces a regression there.

Tue, Aug 14, 6:23 AM
delphij added a comment to D16706: Replace userspace arc4random(3) implementation with Chacha20.

I think we should come up with a design first, it's important not to repeat other's errors. (I have a version based on earlier OpenBSD arc4random() [1] that was used in a disk wiper which still suffers from a few issues that OpenBSD have fixed in their later versions, for example the use of MAP_INHERIT_ZERO or FreeBSD's INHERIT_ZERO to detect fork.). My recommendation is to start over from a more recent OpenBSD version.

Tue, Aug 14, 5:42 AM

Sun, Aug 12

delphij committed rS337692: Remove mention of FreeBSD 9.x which is EoL'ed now..
Remove mention of FreeBSD 9.x which is EoL'ed now.
Sun, Aug 12, 9:44 PM
delphij committed rS337691: Remove mention of FreeBSD 9.x which is EoL'ed now..
Remove mention of FreeBSD 9.x which is EoL'ed now.
Sun, Aug 12, 9:42 PM

Thu, Aug 9

delphij accepted D16552: random: Add PowerPC 'darn' instruction entropy source.

LGTM'ing so we don't become a blocker (the code construction is similar to ivy.c). Please go ahead with commit after 14th August if nobody raises problems that they thinks should block the commit.

Thu, Aug 9, 7:12 AM
delphij accepted D16602: net/openldap24-server: Fix PR/229939 - Start slapd before kdc.

LGTM, thanks!

Thu, Aug 9, 5:12 AM
delphij committed rS337522: In read_zones(), check if the file name actually fit in the buffer.
In read_zones(), check if the file name actually fit in the buffer
Thu, Aug 9, 2:47 AM
delphij closed D16595: Always terminate string with nul..
Thu, Aug 9, 2:47 AM
delphij committed rS337521: MFC r336121+r336127(cem): Don't delete outfile unconditionally..
MFC r336121+r336127(cem): Don't delete outfile unconditionally.
Thu, Aug 9, 2:27 AM

Wed, Aug 8

delphij accepted D16615: msdosfs: fixes for Undefined Behavior..

LGTM. Thanks!

Wed, Aug 8, 5:00 AM

Tue, Aug 7

delphij requested changes to D16602: net/openldap24-server: Fix PR/229939 - Start slapd before kdc.
Tue, Aug 7, 5:45 PM

Mon, Aug 6

delphij committed rD52082: Add SA-18:08.tcp..
Add SA-18:08.tcp.
Mon, Aug 6, 8:45 PM
delphij committed rS337395: Bump patch level and document them..
Bump patch level and document them.
Mon, Aug 6, 8:39 PM
delphij accepted D16602: net/openldap24-server: Fix PR/229939 - Start slapd before kdc.

LGTM (please verify that rcorder /usr/local/etc/rc.d/* /etc/rc.d/* > /dev/null won't give cycles before committing).

Mon, Aug 6, 4:07 PM

Sun, Aug 5

delphij added a comment to D16595: Always terminate string with nul..
In D16595#352569, @imp wrote:

Normally, these files aren't in the control of users...

Sun, Aug 5, 5:15 PM
delphij added inline comments to D16595: Always terminate string with nul..
Sun, Aug 5, 5:10 PM
delphij updated the diff for D16595: Always terminate string with nul..

Clarify the code.

Sun, Aug 5, 5:09 PM
delphij created D16595: Always terminate string with nul..
Sun, Aug 5, 6:04 AM

Sat, Aug 4

delphij closed D16588: Sanity check BIOS EDD CHS numbers before using them..

Referenced wrong review. This was committed as rS337317.

Sat, Aug 4, 2:15 PM
delphij committed rS337317: In r337271, we limited the sector number to the lower of calculated.
In r337271, we limited the sector number to the lower of calculated
Sat, Aug 4, 2:13 PM
delphij created D16588: Sanity check BIOS EDD CHS numbers before using them..
Sat, Aug 4, 8:53 AM

Fri, Aug 3

delphij added inline comments to D15713: Bug 182518 - [login.conf] Better Password Hashes .
Fri, Aug 3, 5:58 PM · security

Wed, Aug 1

delphij requested changes to D15713: Bug 182518 - [login.conf] Better Password Hashes .
Wed, Aug 1, 2:51 AM · security
delphij accepted D16527: Require MAC labels to be non-zero in length..
Wed, Aug 1, 2:43 AM

Sat, Jul 28

delphij requested changes to D15713: Bug 182518 - [login.conf] Better Password Hashes .

Could you please split the proposed change to smaller pieces, so it would be easier to review?

Sat, Jul 28, 12:10 AM · security

Fri, Jul 27

delphij committed rS336755: MFC r336236: Detect and handle invalid number of FATs..
MFC r336236: Detect and handle invalid number of FATs.
Fri, Jul 27, 5:40 AM
delphij committed rS336754: Improve --strip-trailing-cr handling:.
Improve --strip-trailing-cr handling:
Fri, Jul 27, 5:21 AM
delphij closed D16451: Improve --strip-trailing-cr handling.
Fri, Jul 27, 5:21 AM

Thu, Jul 26

delphij created D16451: Improve --strip-trailing-cr handling.
Thu, Jul 26, 8:45 AM

Tue, Jul 24

delphij committed rS336661: MFC r336156:.
MFC r336156:
Tue, Jul 24, 5:10 AM
delphij added a comment to D16365: Update devel/libhtp to 0.5.27.

@delphij Is that acceptance for approval to MFH ?

Tue, Jul 24, 4:50 AM
delphij accepted D16365: Update devel/libhtp to 0.5.27.
Tue, Jul 24, 4:45 AM

Jul 20 2018

delphij committed rS336541: libcrypt: There is no need to clear message digest context after they.
libcrypt: There is no need to clear message digest context after they
Jul 20 2018, 7:16 AM
delphij committed rS336540: Get rid of unused variables..
Get rid of unused variables.
Jul 20 2018, 7:07 AM
delphij closed D16314: Get rid of unused variables..
Jul 20 2018, 7:07 AM
delphij committed rS336539: libmd: Always erase context in _Final method, and when doing.
libmd: Always erase context in _Final method, and when doing
Jul 20 2018, 7:02 AM
delphij closed D16316: Consistently use explicit_bzero() for _Final methods..
Jul 20 2018, 7:01 AM

Jul 19 2018

delphij accepted D16050: Automatically run ntpd as non-root when possible..

LGTM, thanks!

Jul 19 2018, 7:11 AM

Jul 18 2018

delphij updated the test plan for D16316: Consistently use explicit_bzero() for _Final methods..
Jul 18 2018, 7:34 AM
delphij updated the diff for D16316: Consistently use explicit_bzero() for _Final methods..

Update manual pages and other hash rountines.

Jul 18 2018, 7:34 AM
delphij created D16316: Consistently use explicit_bzero() for _Final methods..
Jul 18 2018, 7:02 AM
delphij added inline comments to D16050: Automatically run ntpd as non-root when possible..
Jul 18 2018, 4:38 AM
delphij created D16314: Get rid of unused variables..
Jul 18 2018, 3:09 AM

Jul 16 2018

delphij committed rS336329: MFC r335189:.
MFC r335189:
Jul 16 2018, 4:06 AM
delphij committed rS336328: MFC r318355,318366: add -T (timestamp) option for reproducible builds.
MFC r318355,318366: add -T (timestamp) option for reproducible builds
Jul 16 2018, 3:59 AM
delphij added inline comments to D16280: Move the link to Wikipedia to a better place, and rephrase a bit..
Jul 16 2018, 3:16 AM

Jul 13 2018

delphij accepted D16251: Update release entities from the English version..
Jul 13 2018, 8:20 PM
delphij added inline comments to D16251: Update release entities from the English version..
Jul 13 2018, 5:47 AM
delphij committed rS336236: Detect and handle invalid number of FATs.
Detect and handle invalid number of FATs
Jul 13 2018, 2:02 AM

Jul 12 2018

delphij committed rS336218: MFC r335696,r335697:.
MFC r335696,r335697:
Jul 12 2018, 5:38 AM

Jul 10 2018

delphij accepted D16208: Update release information from the English version.
Jul 10 2018, 9:04 PM
delphij committed rS336158: MFC r335655:.
MFC r335655:
Jul 10 2018, 2:46 AM
delphij committed rS336156: Use endian.h le32dec() instead of rolling our own..
Use endian.h le32dec() instead of rolling our own.
Jul 10 2018, 1:42 AM
delphij closed D16192: Utilize le32dec()..
Jul 10 2018, 1:42 AM
delphij accepted D16137: Update the link to BSDTW 2017 conference.
Jul 10 2018, 1:38 AM

Jul 9 2018

delphij committed rS336121: Don't delete outfile unconditionally..
Don't delete outfile unconditionally.
Jul 9 2018, 6:19 AM
delphij committed rS336120: MFC r335559:.
MFC r335559:
Jul 9 2018, 6:03 AM
delphij committed rS336119: MFC r335469: Don't leak tmpstr..
MFC r335469: Don't leak tmpstr.
Jul 9 2018, 5:56 AM
delphij created D16192: Utilize le32dec()..
Jul 9 2018, 5:20 AM

Jul 3 2018

delphij accepted D16093: Update zh_CN information on the Translation Project page.
Jul 3 2018, 5:23 PM
delphij accepted D16072: Delete deprecated files in zh_CN.
Jul 3 2018, 5:06 PM

Jul 1 2018

delphij accepted D16082: Update release information page from the English version.
Jul 1 2018, 5:44 PM
delphij added a comment to D15801: top(1): reimplement header formatting as sbuf.

Steal space from RES and SIZE; incrase username

Jul 1 2018, 6:07 AM

Jun 30 2018

delphij added a comment to D16072: Delete deprecated files in zh_CN.
In D16072#340510, @ygy wrote:

@loader @delphij What I am unsure is zh_CN.UTF-8/htdocs/developers.xml. Is it used anywhere, and should we keep maintaining it?

Jun 30 2018, 6:20 AM

Jun 29 2018

delphij accepted D16062: Change permissions on /dev/acpi.

Looks reasonable.

Jun 29 2018, 10:14 PM
delphij accepted D16065: Update navibar from the English version.
Jun 29 2018, 7:06 PM