User Details
- User Since
- Nov 14 2018, 8:11 PM (237 w, 4 d)
Fri, May 19
looks like this is value is stated in RFC8907 section 6.1 under the authen_type header
Tue, May 16
Thanks
Mon, May 15
small nits - other than that, looks good
not sure that devices should define a snapshot handler when not supported by the device.
Fri, May 12
May 5 2023
Apr 25 2023
Mar 31 2023
so I assume some ACPI devices will have different emulation than others?
Mar 30 2023
Mar 29 2023
the comments from D39315 apply to this review as well
Mar 28 2023
Seems a bit odd making this public? as opposed to keeping a reference of the softc in gpu_passthru and passing that off to pci?
Mar 27 2023
Mar 15 2023
committed in rG2dfd9979d827b36a9ed6ef2d5911a755091216c7 or SVN r279342
Mar 14 2023
Mar 10 2023
Mar 9 2023
Mar 8 2023
I withdraw my request for changes.
Mar 7 2023
Mar 6 2023
Mar 4 2023
Mar 3 2023
! In D38858#884878, @gusev.vitaliy_gmail.com wrote:
Did you mean about format of the image files or something another? If format, I am going to resolve it with coming nvlist changes.
Mar 2 2023
I still don't understand why you haven't addressed my comments that I raised in the original review. Do you feel it's not worth addressing or is that I'm out of line?
Mar 1 2023
Feb 28 2023
I still hold the opinion that the snapshot data should be stored in a single file and the file descriptor for that file should be passed to bhyve.
Feb 25 2023
Feb 24 2023
Feb 23 2023
Feb 22 2023
Tested - works as expected for me,
Feb 17 2023
Feb 16 2023
Feb 7 2023
Feb 6 2023
Jan 30 2023
I don't see any issues with this offhand - be nice to have this fixed for 13.2
Jan 27 2023
would it be worth the effort to fix this upstream? something like:
Jan 26 2023
After a second look, perhaps md's devsw shouldn't even define dv_fmtdev or dv_parsedev and use the defaults instead.
it looked something like: https://reviews.freebsd.org/differential/diff/115789/
My local workaround to fix this was to add md_parsedev() and md_formatdev() and have it only understand md0.
Jan 20 2023
Jan 16 2023
previous diff was incorrect
Jan 15 2023
Jan 6 2023
Dec 5 2022
Dec 4 2022
Nov 7 2022
Nov 6 2022
Not sure if I missed a step while applying this stack of patches but, I got the following error while build testing. I've provided a diff for context that allowed the build to complete, https://reviews.freebsd.org/differential/diff/112707/
Nov 4 2022
Oct 27 2022
Oct 26 2022
Sep 13 2022
Aug 23 2022
Aug 21 2022
Aug 15 2022
Aug 14 2022
I've submitted a pull request upstream: