User Details
- User Since
- Nov 14 2018, 8:11 PM (182 w, 4 d)
Thu, Apr 28
Mon, Apr 25
address feedback from markj:
- wrap long line
- close file descriptor being leaked
Sun, Apr 24
feedback from jhb..use SUN_LEN()
Tue, Apr 19
looks good, thanks
Sat, Apr 16
What about receiving the file descriptors from the nvlist?
Apr 14 2022
Apr 13 2022
From the PR...it looks like ~25 metrics are broken. And compare that to the total number of exported metrics:
% prometheus_sysctl_exporter | wc -l 13360
If the name of the metric being exported changes...how will that not break existing setups?
Apr 11 2022
Apr 10 2022
Apr 9 2022
Apr 6 2022
Apr 5 2022
Taking this review in a different direction..
feedback from imp: use ${NO_WUNUSED_BUT_SET_VARIABLE}
Apr 4 2022
Apr 3 2022
Apr 1 2022
remaining mandoc warnings left to preserve format of original text
Mar 31 2022
All revisions in this stack need to be updated and rebased.
Mar 30 2022
/usr/src/lib/libutil/pidfile.c:369:2: error: implicit declaration of function 'kill' is invalid in C99 [-Werror,-Wimplicit-function-declaration] kill(pid, sig);
Mar 18 2022
Mar 17 2022
You have broken up https://reviews.freebsd.org/D30471 into multiple reviews without addressing the issues I raised in the original review.
Mar 16 2022
Mar 15 2022
Mar 14 2022
I’ll commit this tomorrow.
Mar 8 2022
Mar 7 2022
Mar 3 2022
Mar 1 2022
not sure if using CSTD=c11 in usr.bin/zstd/Makefile would be acceptable/work here, to avoid touching contrib code.
Feb 28 2022
I split out the bhyvectl changes into a separate review:
updated per feedback from jhb
I didn't realize that these mutex's get initialized on FreeBSD, even without your patch.
Feb 26 2022
looking at the comment above the struct virtio_softc definition in usr.sbin/bhyve/virtio.h:
[ ... snipped ... ] * Note: inside each hypervisor virtio driver, changes to these * data structures must be locked against other threads, if any. * Except for PCI config space register read/write, we assume each * driver does the required locking, but we need a pointer to the * lock (if there is one) for PCI config space read/write ops. [ ... snipped ... ]