In D58706#1348195, @markj wrote:

I guess this is Fixes: acd5638e268a6?

this doesn't address the behavior I observed on my test but I can see that this is worth doing still

set anp->an_retries to zero

After re-acquiring an_vnode_lock, check if a vnode is associated with
the autofs node - if one is, clean up the newly created vnode and use
the vnode that is associated with the autofs node

In D57983#1329909, @kevans wrote:

Unrelated, I'm wondering if there's any interest in slightly refactoring this into a prometheus_fbsd_exporter (for lack of better name). Move the bits specific to sysctl output into a separate file and retain a prometheus_sysctl_exporter link to it, but it seems like there's a good opportunity to collect more stats and re-use the same basic CLI interface.

The ones that come to mind most immediately are:

• BE metrics: used* stats for each boot environment, maybe
• pfctl -s seems to have useful facts not currently broken out via sysctl, and I don't know that there's much appetite in doing so
• Jail and VM stats? I guess jail_exporter already exists

spelling nit - other than that, looks good

In D57972#1329617, @kib wrote:

Change the commit message to reflect the new name.

use autfsm for lock description

fix indentation per style(9)

remove log_set_peer_name() and log_set_peer_addr() declarations

In D57159#1310749, @kib wrote:

I spent some time reading autofs, and I see that it is currently quite broken. Your change breaks it even more.

In D57159#1310300, @kib wrote:

• you removed the protection of an_vnode_lock from reclaim. It seems that the lock is needed to synchronize with autofs_node_vn().

minor doc suggestions

the special_media map requires root to work, for determining fstyp(8)

I did an initial smoke test for this phab stack and it worked for me..got a couple questions though

only suggestions, not a request

if possible, it might be worth splitting the ipc changes outside of hot pluggable stack

In D51031#1164660, @glebius wrote:

I am really puzzled how D34550 was created and how did it pass your review :)

use device_get_nameunit(), the attachment displayed should be
vtblkX instead of vtbdX

In D47855#1091215, @emaste wrote:

It's worth adding a comment in the src explaining the ordering

alternate solution committed in 525a177c165740fc697df3de5b92e58b3b41477c

I'm fine with this change as it semantically makes sense and mimics original behavior of pbuf_ctor()

In D43505#991773, @oshogbo wrote:

What about the header fields we have discussed?

In D43505#991783, @imp wrote:

Id also be tempted to always do the requests in host endian and do the happing before we submit. Likewise with the replies. Not sure how feasible that is though.

In D43425#990237, @delphij wrote:

In D43425#990231, @rew wrote:

For ZFS, the argument passed to the shell script is the
pool name to import.

Ah you are right, but the name is not guaranteed to be identical to the filename. Probably zpool import -a -d /dev/$(mdconfig $0).uzip instead? (and maybe -R $1)

incorporate feedback: