Page MenuHomeFreeBSD

rew (Rob Wing)
User

Projects

User Details

User Since
Nov 14 2018, 8:11 PM (135 w, 4 d)

Recent Activity

Fri, Jun 11

rew updated the diff for D30631: periodic: remove obsolete news.expire.

yep, you're right - I missed that.

Fri, Jun 11, 7:46 PM
rew committed R10:e1dfdff10967: bectl(8): don't allow creation of boot environments with spaces (authored by rew).
bectl(8): don't allow creation of boot environments with spaces
Fri, Jun 11, 6:03 PM
rew committed R10:01cf73198d1e: bectl(8): don't allow creation of boot environments with spaces (authored by rew).
bectl(8): don't allow creation of boot environments with spaces
Fri, Jun 11, 5:59 PM
rew committed R10:47ec64b3e801: fsck_ufs: fix segfault with gjournal (authored by rew).
fsck_ufs: fix segfault with gjournal
Fri, Jun 11, 5:00 PM
rew committed R10:157a960058c2: fsck_ffs(8): fix divide by zero when debug messages are enabled (authored by rew).
fsck_ffs(8): fix divide by zero when debug messages are enabled
Fri, Jun 11, 4:54 PM

Thu, Jun 3

rew updated the diff for D30631: periodic: remove obsolete news.expire.

bump .Dd

Thu, Jun 3, 7:38 PM
rew requested review of D30631: periodic: remove obsolete news.expire.
Thu, Jun 3, 7:33 PM
rew committed R10:0e6549c87450: bectl(8): don't allow creation of boot environments with spaces (authored by rew).
bectl(8): don't allow creation of boot environments with spaces
Thu, Jun 3, 4:49 PM
rew closed D30194: bectl(8): don't allow creation of boot environments with spaces.
Thu, Jun 3, 4:48 PM
rew committed R10:441e69e419ef: fsck_ufs: fix segfault with gjournal (authored by rew).
fsck_ufs: fix segfault with gjournal
Thu, Jun 3, 2:33 AM
rew closed D30537: fsck_ffs(8): do bufinit() just before gjournal_check().
Thu, Jun 3, 2:33 AM

Sat, May 29

rew added a comment to D30537: fsck_ffs(8): do bufinit() just before gjournal_check().

I reverted the breaking commits until a solution is found.

Sat, May 29, 3:10 AM
rew added a reverting change for R10:f190f9193bc1: Fix fsck_ufs segfaults with gjournal (SU+J): R10:9b0f1d64b06c: Revert "Fix fsck_ufs segfaults with gjournal (SU+J)".
Sat, May 29, 3:02 AM
rew committed R10:9b0f1d64b06c: Revert "Fix fsck_ufs segfaults with gjournal (SU+J)" (authored by rew).
Revert "Fix fsck_ufs segfaults with gjournal (SU+J)"
Sat, May 29, 3:02 AM
rew added a reverting change for R10:84768d114951: fsdb: add missing bufinit() call: R10:871291c8d478: Revert "fsdb: add missing bufinit() call".
Sat, May 29, 2:58 AM
rew committed R10:871291c8d478: Revert "fsdb: add missing bufinit() call" (authored by rew).
Revert "fsdb: add missing bufinit() call"
Sat, May 29, 2:58 AM

Fri, May 28

rew updated the summary of D30537: fsck_ffs(8): do bufinit() just before gjournal_check().
Fri, May 28, 11:12 PM
rew added a reverting change for R10:f190f9193bc1: Fix fsck_ufs segfaults with gjournal (SU+J): D30537: fsck_ffs(8): do bufinit() just before gjournal_check().
Fri, May 28, 9:26 PM
rew added a reverting change for R10:84768d114951: fsdb: add missing bufinit() call: D30537: fsck_ffs(8): do bufinit() just before gjournal_check().
Fri, May 28, 9:26 PM
rew requested review of D30537: fsck_ffs(8): do bufinit() just before gjournal_check().
Fri, May 28, 9:25 PM

Sat, May 22

rew committed R10:20123b25ee51: fsck_ffs(8): fix divide by zero when debug messages are enabled (authored by rew).
fsck_ffs(8): fix divide by zero when debug messages are enabled
Sat, May 22, 7:26 PM
rew closed D30370: fsck_ffs(8): fix divide by zero when debug messages are enabled.
Sat, May 22, 7:26 PM

May 21 2021

rew committed R10:fdbc86cf7978: bhyve/snapshot: split up mutex/cond initialization from socket creation (authored by rew).
bhyve/snapshot: split up mutex/cond initialization from socket creation
May 21 2021, 7:41 PM
rew closed D30281: bhyve/snapshot: split up mutex/cond initialization from socket creation.
May 21 2021, 7:40 PM
rew committed R10:942e69146ea2: fstyp(8): define HAVE_ZFS macro when built with zfs (authored by rew).
fstyp(8): define HAVE_ZFS macro when built with zfs
May 21 2021, 3:36 PM

May 20 2021

rew added a reviewer for D30370: fsck_ffs(8): fix divide by zero when debug messages are enabled: mckusick.
May 20 2021, 9:18 PM
rew requested review of D30370: fsck_ffs(8): fix divide by zero when debug messages are enabled.
May 20 2021, 9:17 PM

May 15 2021

rew requested review of D30281: bhyve/snapshot: split up mutex/cond initialization from socket creation.
May 15 2021, 8:28 PM

May 14 2021

rew committed R10:91f251b2ab3a: fstyp(8): define HAVE_ZFS macro when built with zfs (authored by rew).
fstyp(8): define HAVE_ZFS macro when built with zfs
May 14 2021, 9:26 PM
rew closed D30221: fstyp(8): define HAVE_ZFS macro when built with zfs.
May 14 2021, 9:25 PM
rew added inline comments to D30221: fstyp(8): define HAVE_ZFS macro when built with zfs.
May 14 2021, 8:23 AM
rew closed D29213: bhyve/snapshot: provide a way to send other messages/data to bhyve.

closed in commit d4870e3a7256704905655e997b37a866024c2894

May 14 2021, 3:00 AM

May 13 2021

rew updated the diff for D30221: fstyp(8): define HAVE_ZFS macro when built with zfs.

previous diff was an error, this is the correct diff.

May 13 2021, 6:31 AM
rew reopened D30221: fstyp(8): define HAVE_ZFS macro when built with zfs.
May 13 2021, 6:30 AM
rew removed reviewers for D30221: fstyp(8): define HAVE_ZFS macro when built with zfs: cem, trasz.
May 13 2021, 6:19 AM
rew removed a reviewer for D30221: fstyp(8): define HAVE_ZFS macro when built with zfs: bhyve.
May 13 2021, 1:45 AM
rew closed D30221: fstyp(8): define HAVE_ZFS macro when built with zfs.
May 13 2021, 1:34 AM
rew committed R10:d4870e3a7256: bhyve/snapshot: provide a way to send other messages/data to bhyve (authored by rew).
bhyve/snapshot: provide a way to send other messages/data to bhyve
May 13 2021, 1:34 AM

May 12 2021

rew retitled D30221: fstyp(8): define HAVE_ZFS macro when built with zfs from fstype(8): define HAVE_ZFS macro when built with zfs to fstyp(8): define HAVE_ZFS macro when built with zfs.
May 12 2021, 3:20 AM
rew added a reviewer for D30221: fstyp(8): define HAVE_ZFS macro when built with zfs: trasz.
May 12 2021, 3:18 AM
rew requested review of D30221: fstyp(8): define HAVE_ZFS macro when built with zfs.
May 12 2021, 3:17 AM
rew committed R10:6fa8a157705d: autofs: best effort to maintain mounttab and mountdtab (authored by rew).
autofs: best effort to maintain mounttab and mountdtab
May 12 2021, 12:13 AM

May 11 2021

rew committed R10:a7f81b488df2: libvmm: explicitly save and restore errno in vm_open() (authored by rew).
libvmm: explicitly save and restore errno in vm_open()
May 11 2021, 11:15 PM

May 10 2021

rew added reviewers for D30194: bectl(8): don't allow creation of boot environments with spaces: allanjude, kevans.
May 10 2021, 8:03 PM
rew requested review of D30194: bectl(8): don't allow creation of boot environments with spaces.
May 10 2021, 8:01 PM

May 8 2021

rew added a comment to D29213: bhyve/snapshot: provide a way to send other messages/data to bhyve.

ping, anyone interested in reviewing?

May 8 2021, 12:48 AM

Mar 12 2021

rew committed R10:88e531f38c24: autofs: best effort to maintain mounttab and mountdtab (authored by rew).
autofs: best effort to maintain mounttab and mountdtab
Mar 12 2021, 3:48 PM
rew closed D27801: automount(8): try umount(8) before unmount(3).
Mar 12 2021, 3:48 PM

Mar 11 2021

rew added a reviewer for D29213: bhyve/snapshot: provide a way to send other messages/data to bhyve: jhb.
Mar 11 2021, 5:27 AM
rew requested review of D29213: bhyve/snapshot: provide a way to send other messages/data to bhyve.
Mar 11 2021, 5:24 AM

Mar 10 2021

rew added inline comments to D29109: bhyvectl: print a better error message when vm_open fails.
Mar 10 2021, 9:30 PM

Mar 8 2021

rew committed R10:38dfb0626fd3: bhyve/snapshot: use SOCK_DGRAM instead of SOCK_STREAM (authored by rew).
bhyve/snapshot: use SOCK_DGRAM instead of SOCK_STREAM
Mar 8 2021, 12:39 AM
rew closed D28983: bhyve/snapshot: use SOCK_DGRAM instead of SOCK_STREAM.
Mar 8 2021, 12:38 AM

Mar 7 2021

rew closed D29109: bhyvectl: print a better error message when vm_open fails.
Mar 7 2021, 6:30 AM
rew committed R10:6bb140e3ca89: bhyvectl: print a better error message when vm_open() fails (authored by rew).
bhyvectl: print a better error message when vm_open() fails
Mar 7 2021, 6:30 AM
rew requested review of D29109: bhyvectl: print a better error message when vm_open fails.
Mar 7 2021, 2:16 AM

Mar 6 2021

rew added a comment to D29084: bhyve: virtio shares definitions between sys/dev/virtio.

take my suggestions/questions with a grain of salt as I'm not familiar with this area of the code..

Mar 6 2021, 3:16 AM

Mar 4 2021

rew added inline comments to D28983: bhyve/snapshot: use SOCK_DGRAM instead of SOCK_STREAM.
Mar 4 2021, 5:53 PM

Mar 2 2021

rew closed D28974: filt_fsevent: only record interested events.
Mar 2 2021, 11:24 PM
rew committed R10:0cc746f19352: filt_fsevent: only record interested events (authored by rew).
filt_fsevent: only record interested events
Mar 2 2021, 11:24 PM
rew closed D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.
Mar 2 2021, 11:23 PM
rew committed R10:ce22a792deed: autounmountd: set filter-specific flags for the EVFILT_FS filter (authored by rew).
autounmountd: set filter-specific flags for the EVFILT_FS filter
Mar 2 2021, 11:23 PM
rew updated the diff for D28983: bhyve/snapshot: use SOCK_DGRAM instead of SOCK_STREAM.

use EPRINTLN for display error messages..

Mar 2 2021, 8:38 PM
rew added a comment to D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.

Looks like related to D28974, in which case it looks fine.

Mar 2 2021, 8:08 PM
rew added a comment to D27801: automount(8): try umount(8) before unmount(3).

if we're on the same page here, I'll pass this patch off to the bugzilla reporter for testing (in addition to the testing I've done)...

Mar 2 2021, 1:04 AM

Feb 28 2021

rew requested review of D28983: bhyve/snapshot: use SOCK_DGRAM instead of SOCK_STREAM.
Feb 28 2021, 10:09 AM
rew added inline comments to D28974: filt_fsevent: only record interested events.
Feb 28 2021, 9:14 AM
rew updated the diff for D28974: filt_fsevent: only record interested events.

update as noted by kib

Feb 28 2021, 9:06 AM

Feb 27 2021

rew closed D28879: bhyve/snapshot: rename and bump size of MAX_SNAPSHOT_VMNAME.
Feb 27 2021, 9:47 PM
rew committed R10:d656ce199d72: bhyve/snapshot: rename and bump size of MAX_SNAPSHOT_VMNAME (authored by rew).
bhyve/snapshot: rename and bump size of MAX_SNAPSHOT_VMNAME
Feb 27 2021, 9:47 PM
rew closed D28878: bhyvectl: reduce code duplication.
Feb 27 2021, 9:46 PM
rew committed R10:da9713917eb2: bhyvectl: reduce code duplication (authored by rew).
bhyvectl: reduce code duplication
Feb 27 2021, 9:46 PM
rew closed D28877: bhyve/snapshot: rename checkpoint_opcodes to be more generic.
Feb 27 2021, 9:46 PM
rew committed R10:b7fd9c4e5ebc: bhyve/snapshot: rename checkpoint_opcodes to be more generic (authored by rew).
bhyve/snapshot: rename checkpoint_opcodes to be more generic
Feb 27 2021, 9:46 PM
rew added a reviewer for D28975: autounmountd: set filter-specific flags for the EVFILT_FS event: trasz.
Feb 27 2021, 7:49 PM
rew added a reviewer for D28974: filt_fsevent: only record interested events: kib.
Feb 27 2021, 7:49 PM
rew requested review of D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.
Feb 27 2021, 7:47 PM
rew requested review of D28974: filt_fsevent: only record interested events.
Feb 27 2021, 7:47 PM

Feb 25 2021

rew committed R10:d9e70f5d97c6: automount(8): fix absolute path when creating a mountpoint (authored by rew).
automount(8): fix absolute path when creating a mountpoint
Feb 25 2021, 6:59 PM
rew committed R10:cf9829d98dc7: automount(8): fix absolute path when creating a mountpoint (authored by rew).
automount(8): fix absolute path when creating a mountpoint
Feb 25 2021, 6:57 PM
rew added a comment to D26976: bhyve - ARMv8 implementation.

Is there a reason why uart (instead of bvmconsole) can't be used to get a shell for armv8?

Feb 25 2021, 6:51 PM

Feb 23 2021

rew added a member for bhyve: rew.
Feb 23 2021, 7:17 PM
rew requested review of D28879: bhyve/snapshot: rename and bump size of MAX_SNAPSHOT_VMNAME.
Feb 23 2021, 1:50 AM
rew requested review of D28878: bhyvectl: reduce code duplication.
Feb 23 2021, 1:50 AM
rew requested review of D28877: bhyve/snapshot: rename checkpoint_opcodes to be more generic.
Feb 23 2021, 1:48 AM

Feb 22 2021

rew committed R10:5ce2d4a1c292: bhyve/snapshot: drop mkdir when creating the unix domain socket (authored by rew).
bhyve/snapshot: drop mkdir when creating the unix domain socket
Feb 22 2021, 8:34 PM
rew closed D28783: bhyve/snapshot: drop mkdir when creating the unix domain socket.
Feb 22 2021, 8:34 PM

Feb 19 2021

rew added a reviewer for D28783: bhyve/snapshot: drop mkdir when creating the unix domain socket: jhb.
Feb 19 2021, 3:43 AM
rew requested review of D28783: bhyve/snapshot: drop mkdir when creating the unix domain socket.
Feb 19 2021, 3:42 AM

Feb 18 2021

rew closed D28410: libvmm: clean up vmmapi.h.
Feb 18 2021, 2:55 AM
rew committed R10:4f4065e0a220: libvmm: clean up vmmapi.h (authored by rew).
libvmm: clean up vmmapi.h
Feb 18 2021, 2:55 AM

Feb 17 2021

rew committed R10:63640b2f552c: automount(8): fix absolute path when creating a mountpoint (authored by rew).
automount(8): fix absolute path when creating a mountpoint
Feb 17 2021, 10:10 AM
rew closed D27832: autmount(8): fix absolute path when creating a mountpoint.
Feb 17 2021, 10:10 AM
rew updated the diff for D27801: automount(8): try umount(8) before unmount(3).

Call rpc.umntall(8) when an automounted filesystem is successfully unmounted.

Feb 17 2021, 8:33 AM

Feb 15 2021

rew added a comment to D27801: automount(8): try umount(8) before unmount(3).

This sounds good to me - I’ll get to this in a couple days/this week.

Feb 15 2021, 5:17 PM
rew added a comment to D27832: autmount(8): fix absolute path when creating a mountpoint.

had to leave town last week - family emergency. I get back tomorrow and will get this in.

Feb 15 2021, 5:14 PM

Feb 8 2021

rew added a comment to D27500: gpart resize: respect requested size when using `-a` and `-s`.
  1. Create MBR
  2. Create one unaligned partition and then create BSD scheme
  3. Try to create aligned partitions in the BSD scheme, they will be unaligned regarding to whole disk.
Feb 8 2021, 2:26 PM

Feb 7 2021

rew reclaimed D27832: autmount(8): fix absolute path when creating a mountpoint.

I’m resurrecting this - I was wrong to abandon it.

Feb 7 2021, 7:53 PM
rew reclaimed D27801: automount(8): try umount(8) before unmount(3).

I’m resurrecting this - I do care about fixing this. The reporter, whose been an invaluable resource for testing and bug reports w.r.t. autofs would like this fixed.

Feb 7 2021, 7:47 PM
rew added a comment to D27500: gpart resize: respect requested size when using `-a` and `-s`.

ae@, thanks for the reply - I looked at g_part_bsd_resize and there’s no reference to using the offset field. The only field it uses is the start field. Let me know if you have any other concerns.

Feb 7 2021, 7:16 PM