Updating D25631: periodic script to create backup of gmirror information

Updating D25631: periodic script to create backup of gmirror information

clarify new variables in periodic.conf(5).

• de-butcher the indenting

Install the new 222.backup-gmirror periodic script.

Fixed ATF test cases to require root user.

• Document changes for new periodic variables in periodic.conf(5). Set defaults for new variables in periodic.conf.

Updating D24289: map capability string for VM_CAP_BPT_EXIT

You’re welcome to finish it up..

@araujo, sounds like you are taking over this review?

Updating D18564: allow creation of non-recursive boot environments (libbe)

Updating D18564: allow creation of non-recursive boot environments (libbe)

Sounds good, I will do that. You can expect to see an updated revision in the next few days.

Updating D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe)

Updating D18564: allow creation of non-recursive boot environments (libbe)

The channel programs look like a cool feature - I have a few questions about it:

I'm not sure why the history is clobbered for this updated diff revision with regards to target_prog.c being copied from be_impl.h.

Updating D18564: allow creation of non-recursive boot environments (libbe)

A question about the added files - am I supposed to include the copyright/license information or...?

Updating D18564: allow creation of non-recursive boot environments (libbe)

Updating D18564: allow creation of non-recursive boot environments (libbe)

Hey Kyle,

Do you use IRC or anything of the sort? Some of this might be easier to hash out in real-time, and we can summarize the results of said discussion back in this review.

It's probably poor style to change the user interface for bectl but, it's
already recursive by default - could always ignore the '-r' flag and add a flag
for shallow creation. Upside here is the current behavior remains unchanged.
Downside being, confusion for current users (i.e. the shell game of
command-line flags).

I agree, the default be_create is adequate for most cases. If anything, I would lean
towards a be_create_shallow, here's my thinking. be_create is, effectively,
a recursive snapshot that gets cloned - which is consistent with the zfs
behavior of 'zfs snapshot -r'. be_create_shallow would be consistent with
a 'zfs snapshot', minus the recursive flag.

Added tests in sbin/bectl/test and fixed styling issues.