Page MenuHomeFreeBSD

rew (Rob Wing)
User

Projects

User Details

User Since
Nov 14 2018, 8:11 PM (283 w, 6 d)

Recent Activity

Feb 21 2024

rew accepted D44013: nextboot: check unlink, but only warn on !ENOENT.
Feb 21 2024, 9:16 PM
rew added a reverting change for rG4cea0cbcc9d3: rc.d/mountlate: discard output from nextboot: rGc7d5cc6f5e64: Revert "rc.d/mountlate: discard output from nextboot".
Feb 21 2024, 6:03 AM
rew added a reverting change for D43979: rc.d/mountlate: discard output from nextboot: rGc7d5cc6f5e64: Revert "rc.d/mountlate: discard output from nextboot".
Feb 21 2024, 6:03 AM
rew committed rGc7d5cc6f5e64: Revert "rc.d/mountlate: discard output from nextboot" (authored by rew).
Revert "rc.d/mountlate: discard output from nextboot"
Feb 21 2024, 6:03 AM
rew closed D43979: rc.d/mountlate: discard output from nextboot.
Feb 21 2024, 6:00 AM
rew committed rG4cea0cbcc9d3: rc.d/mountlate: discard output from nextboot (authored by rew).
rc.d/mountlate: discard output from nextboot
Feb 21 2024, 6:00 AM

Feb 19 2024

rew added a reviewer for D43979: rc.d/mountlate: discard output from nextboot: imp.
Feb 19 2024, 6:49 PM
rew requested review of D43979: rc.d/mountlate: discard output from nextboot.
Feb 19 2024, 6:48 PM

Feb 1 2024

rew committed rGd9b3bba2f302: mpr: endianess fix for set/get dpm page0 (authored by rew).
mpr: endianess fix for set/get dpm page0
Feb 1 2024, 2:47 AM
rew closed D43505: mpr: endianess fix for set/get dpm page0.
Feb 1 2024, 2:47 AM

Jan 22 2024

rew added inline comments to D43425: mkuzip: detect underlying filesystem when building uzip header.
Jan 22 2024, 10:26 PM

Jan 20 2024

rew updated the summary of D43526: libkvm: use correct kvm_arch for powerpc minidumps.
Jan 20 2024, 7:07 PM
rew requested review of D43526: libkvm: use correct kvm_arch for powerpc minidumps.
Jan 20 2024, 7:05 PM

Jan 19 2024

rew added a comment to D43505: mpr: endianess fix for set/get dpm page0.

What about the header fields we have discussed?

Jan 19 2024, 7:41 PM
rew added a comment to D43505: mpr: endianess fix for set/get dpm page0.
In D43505#991783, @imp wrote:

Id also be tempted to always do the requests in host endian and do the happing before we submit. Likewise with the replies. Not sure how feasible that is though.

Jan 19 2024, 7:38 PM

Jan 18 2024

rew requested review of D43505: mpr: endianess fix for set/get dpm page0.
Jan 18 2024, 8:04 PM

Jan 17 2024

rew closed D43472: bhyve: correct slirp_recv_disable().
Jan 17 2024, 6:13 PM
rew committed rGfdd1e1a56457: bhyve: correct slirp_recv_disable() (authored by rew).
bhyve: correct slirp_recv_disable()
Jan 17 2024, 6:13 PM
rew requested review of D43472: bhyve: correct slirp_recv_disable().
Jan 17 2024, 4:05 AM

Jan 13 2024

rew added a comment to D43425: mkuzip: detect underlying filesystem when building uzip header.
In D43425#990231, @rew wrote:

For ZFS, the argument passed to the shell script is the
pool name to import.

Ah you are right, but the name is not guaranteed to be identical to the filename. Probably zpool import -a -d /dev/$(mdconfig $0).uzip instead? (and maybe -R $1)

Jan 13 2024, 5:55 PM
rew added inline comments to D43425: mkuzip: detect underlying filesystem when building uzip header.
Jan 13 2024, 6:16 AM
rew updated the diff for D43425: mkuzip: detect underlying filesystem when building uzip header.

incorporate feedback:

Jan 13 2024, 6:05 AM
rew committed rGc8328f1a7b6e: pmap_init(9): drop MLINKS reference (authored by rew).
pmap_init(9): drop MLINKS reference
Jan 13 2024, 2:31 AM

Jan 12 2024

rew committed rGbc1eea0c0b0a: pmap_init(9): sweep references to pmap_init2() (authored by rew).
pmap_init(9): sweep references to pmap_init2()
Jan 12 2024, 10:29 PM
rew committed rG55e2a7d3ea21: pmap_pinit(9): sweep references to pmap_pinit2() (authored by rew).
pmap_pinit(9): sweep references to pmap_pinit2()
Jan 12 2024, 10:29 PM
rew added a reviewer for D43425: mkuzip: detect underlying filesystem when building uzip header: sobomax.
Jan 12 2024, 8:17 PM
rew requested review of D43425: mkuzip: detect underlying filesystem when building uzip header.
Jan 12 2024, 7:58 PM

Jan 10 2024

rew accepted D43382: uniq: Fix interactive use..
Jan 10 2024, 6:55 PM

Jan 9 2024

rew committed rG0013741108bc: powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1) (authored by rew).
powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1)
Jan 9 2024, 8:24 PM
rew closed D43339: powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1).
Jan 9 2024, 8:23 PM

Jan 8 2024

rew updated the diff for D43339: powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1).
  • drop vm_page_all_valid() change
  • fill added leaf page with mappings
Jan 8 2024, 9:58 AM
rew added inline comments to D43339: powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1).
Jan 8 2024, 9:54 AM

Jan 5 2024

rew added reviewers for D43339: powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1): markj, bnovkov.
Jan 5 2024, 10:51 PM
rew requested review of D43339: powerpc_mmu_radix: add leaf page for wired mappings when pmap_enter(psind=1).
Jan 5 2024, 10:49 PM

Jan 1 2024

rew accepted D43262: libc: locale: fix EUC shift check.
Jan 1 2024, 9:16 PM
rew added inline comments to D43262: libc: locale: fix EUC shift check.
Jan 1 2024, 6:18 PM

Dec 29 2023

rew committed rG0600b575402f: bhyve: verify that user provided fbuf values fall within limits (authored by rew).
bhyve: verify that user provided fbuf values fall within limits
Dec 29 2023, 8:39 PM
rew closed D42692: bhyve: use fbuf defaults when config parsing fails.
Dec 29 2023, 8:39 PM
rew added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.

This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.

Dec 29 2023, 6:20 PM · bhyve
rew committed rG683ea4d22bbc: vmm: MTRR should be saved/restored (authored by gusev.vitaliy_gmail.com).
vmm: MTRR should be saved/restored
Dec 29 2023, 6:15 PM
rew closed D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 29 2023, 6:15 PM · bhyve
rew committed rGb831c7732c71: bhyve: increase SNAPSHOT_BUFFER_SIZE (authored by gusev.vitaliy_gmail.com).
bhyve: increase SNAPSHOT_BUFFER_SIZE
Dec 29 2023, 5:53 PM
rew closed D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
Dec 29 2023, 5:53 PM · bhyve
rew accepted D43226: vmm: [snapshot] MTRR should be saved/restored.
Dec 29 2023, 5:32 PM · bhyve

Dec 28 2023

rew accepted D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.

This looks good - thanks for the fix.

Dec 28 2023, 9:18 AM · bhyve

Dec 19 2023

rew updated the diff for D42692: bhyve: use fbuf defaults when config parsing fails.

address feedback from jhb

Dec 19 2023, 2:09 AM
rew committed rGacd5638e268a: tty: delete knotes when TTY is revoked (authored by rew).
tty: delete knotes when TTY is revoked
Dec 19 2023, 12:49 AM
rew closed D41605: tty: delete knotes when TTY is revoked.
Dec 19 2023, 12:48 AM

Dec 14 2023

rew updated the diff for D41605: tty: delete knotes when TTY is revoked.

address feedback

Dec 14 2023, 8:33 AM

Dec 12 2023

rew committed R9:ae9f16a02d5a: pgpkeys: new key for rew (authored by rew).
pgpkeys: new key for rew
Dec 12 2023, 10:12 PM
rew added a comment to D41605: tty: delete knotes when TTY is revoked.

Why exactly do we need special handling for FREVOKE?

Dec 12 2023, 5:02 PM

Dec 11 2023

rew updated the diff for D41605: tty: delete knotes when TTY is revoked.

Do not clear knotes from the TTY until it gets dealloc'ed unless the TTY
is being revoked, in that case delete the knotes when closed is called
on the TTY.

Dec 11 2023, 7:13 PM

Nov 21 2023

rew requested review of D42692: bhyve: use fbuf defaults when config parsing fails.
Nov 21 2023, 1:41 AM
rew committed rGfb51ddb20d57: bhyve: increase fbuf display resolution limit (authored by rew).
bhyve: increase fbuf display resolution limit
Nov 21 2023, 1:20 AM
rew closed D42620: bhyve: increase fbuf display resolution limit.
Nov 21 2023, 1:20 AM

Nov 15 2023

rew requested review of D42620: bhyve: increase fbuf display resolution limit.
Nov 15 2023, 5:08 PM

Nov 12 2023

rew accepted D42510: bhyve: Add a slirp network backend.

Tested and works as expected - this will be nice to have, thanks.

Nov 12 2023, 7:54 AM

Nov 7 2023

rew accepted D42494: autofs: media: Always use sync option for fat*.
Nov 7 2023, 4:01 PM
rew accepted D42493: autofs: Remove stable comment.
Nov 7 2023, 4:00 PM
rew accepted D42492: autofs: media: Don't include nosuid in the script.
Nov 7 2023, 4:00 PM

Aug 28 2023

rew added a comment to D41605: tty: delete knotes when TTY is revoked.

How do they get removed? tty_dealloc() calls knlist_destroy(), but this presumes that knotes have already been dequeued.

Aug 28 2023, 4:20 PM
rew added a comment to D41605: tty: delete knotes when TTY is revoked.
In D41605#948294, @kib wrote:

What would prevent this situation for other kinds of knotes?

Aug 28 2023, 4:01 PM
rew added a comment to D41605: tty: delete knotes when TTY is revoked.
In D41605#948243, @kib wrote:

But then, what would guarantee liveness of the tty when its detached knote f_event method is called?

Aug 28 2023, 3:11 AM

Aug 26 2023

rew added a comment to D41605: tty: delete knotes when TTY is revoked.
In D41605#948130, @kib wrote:

Can you show the backtrace where tty filter is called without tty lock, please?

Aug 26 2023, 10:16 PM
rew updated the diff for D41605: tty: delete knotes when TTY is revoked.

update revision with missing chunk

Aug 26 2023, 8:16 PM
rew committed rGb3a714652ff0: kqueue(9): sweep references to knlist_remove_inevent() (authored by rew).
kqueue(9): sweep references to knlist_remove_inevent()
Aug 26 2023, 7:13 PM
rew added reviewers for D41605: tty: delete knotes when TTY is revoked: markj, kib.
Aug 26 2023, 6:44 PM
rew requested review of D41605: tty: delete knotes when TTY is revoked.
Aug 26 2023, 6:42 PM

Aug 23 2023

rew committed rG760987ecd39b: bectl: make mount subcommand less verbose (authored by rew).
bectl: make mount subcommand less verbose
Aug 23 2023, 6:48 PM
rew closed D41562: bectl: make mount subcommand less verbose.
Aug 23 2023, 6:48 PM
rew updated the summary of D41562: bectl: make mount subcommand less verbose.
Aug 23 2023, 8:49 AM
rew added a reviewer for D41562: bectl: make mount subcommand less verbose: kevans.
Aug 23 2023, 8:34 AM
rew requested review of D41562: bectl: make mount subcommand less verbose.
Aug 23 2023, 8:24 AM

Jul 13 2023

rew accepted D40972: libbe: recursively promote deep BE datasets.
Jul 13 2023, 5:19 AM

Jul 7 2023

rew accepted D40903: libbe: promote activated BEs all the way.
Jul 7 2023, 3:02 PM

Jun 20 2023

rew updated subscribers of D34717: Warm Migration feature for bhyve [Part 1].

I can't tell you how disappointing it is to see comments like this after a review sits in public review for months. You could have easily voiced any of these concerns during the time leading up to the commit instead of withholding them until after it was made. What exactly is your goal hear?

Jun 20 2023, 5:23 PM · bhyve
rew added a comment to D34717: Warm Migration feature for bhyve [Part 1].

@corvink , I think this commit is too early. Because we haven't finished supporting snapshots, but this commit already fixes the user interface for live migration, which is not finished at all.

Sorry for the late comment, but maybe this commit should be rolled back?

Jun 20 2023, 3:30 PM · bhyve
rew added a comment to D34718: Warm Migration feature for bhyve [Part 2].

I think we should bring support for snapshots first. And enable BHYVE_SNAPSHOT by default.

Jun 20 2023, 3:23 PM · bhyve

May 19 2023

rew added a comment to D40132: taclib: 0 (not set) is a valid auth type in authorization requests..

looks like this is value is stated in RFC8907 section 6.1 under the authen_type header

May 19 2023, 7:00 PM
rew accepted D40132: taclib: 0 (not set) is a valid auth type in authorization requests..
May 19 2023, 6:56 PM

May 16 2023

rew accepted D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.

Thanks

May 16 2023, 4:27 PM · bhyve
rew added a comment to D40108: bhyve: [snapshot] Add .pe_snapshot method for PCI 'hostbridge'.

At least it saves pdi.pi_cfgdata. Do you think it is waste doing and .pi_cfgdata can not be changed by guest OS or be changed between bhyve versions ?

May 16 2023, 3:46 PM · bhyve

May 15 2023

rew added a comment to D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.

small nits - other than that, looks good

May 15 2023, 5:57 PM · bhyve
rew accepted D40108: bhyve: [snapshot] Add .pe_snapshot method for PCI 'hostbridge'.

not sure that devices should define a snapshot handler when not supported by the device.

May 15 2023, 5:39 PM · bhyve
rew accepted D40105: bhyve: [snapshot] Simplify restore kernel structs.
May 15 2023, 5:33 PM · bhyve
rew accepted D40104: bhyve: [snapshot] Rename 'structs' key with 'kern_structs'.
May 15 2023, 5:24 PM · bhyve
rew accepted D40106: bhyve: [snapshot] Rename 'user_dev' with 'devices'.
May 15 2023, 5:23 PM · bhyve

May 12 2023

rew added inline comments to D40076: bhyve: error out if fwcfg user file isn't read completely.
May 12 2023, 9:33 PM
rew added inline comments to D40076: bhyve: error out if fwcfg user file isn't read completely.
May 12 2023, 6:10 AM
rew added inline comments to D40076: bhyve: error out if fwcfg user file isn't read completely.
May 12 2023, 5:55 AM

May 5 2023

rew added a comment to D39979: bhyve: add config option to load ACPI tables into memory.

Do you think we should add this option now or should we wait until someone has some issues or a feature requires it?

It might be helpful for debugging purposes too.

May 5 2023, 5:28 PM

Apr 25 2023

rew accepted D39805: vmm: Dynamically allocate a couple of per-CPU state save areas.

Would anyone be willing to test this on an AMD system?

Apr 25 2023, 7:24 PM

Mar 31 2023

rew added a comment to D39319: bhyve: introduce acpi_device_emul struct.

so I assume some ACPI devices will have different emulation than others?

Mar 31 2023, 6:14 AM

Mar 30 2023

rew accepted D39338: bhyve: return EEXIST when adding a fwcfg item twice.
Mar 30 2023, 2:36 PM

Mar 29 2023

rew added a comment to D39316: bhyve/fwcfg: add QEMU_FWCFG_INDEX_NB_CPUS item.

the comments from D39315 apply to this review as well

Mar 29 2023, 5:20 PM
rew added inline comments to D39315: bhyve/fwcfg: add QEMU_FWCFG_INDEX_MAX_CPUS item.
Mar 29 2023, 3:17 PM

Mar 28 2023

rew added a comment to D39290: bhyve: export passthru softc.

Seems a bit odd making this public? as opposed to keeping a reference of the softc in gpu_passthru and passing that off to pci?

Mar 28 2023, 4:17 PM

Mar 27 2023

rew added inline comments to D39284: bhyve: add helper to create a bootorder.
Mar 27 2023, 5:40 PM

Mar 15 2023

rew closed D1888: Extend the unit test to fix the bug caught in r277925.

committed in rG2dfd9979d827b36a9ed6ef2d5911a755091216c7 or SVN r279342

Mar 15 2023, 5:28 PM

Mar 14 2023

rew accepted D38441: ssh: fix leak and apply style(9) to hostname canonicalization.
Mar 14 2023, 4:56 PM