Page MenuHomeFreeBSD

rew (Rob Wing)
User

Projects

User Details

User Since
Nov 14 2018, 8:11 PM (182 w, 4 d)

Recent Activity

Thu, Apr 28

rew committed R10:65c87a6c81f5: geom_dev: extend kevent support for geom dev (authored by rew).
geom_dev: extend kevent support for geom dev
Thu, Apr 28, 4:42 PM
rew closed D34777: geom_dev: extend kevent support for geom dev.
Thu, Apr 28, 4:41 PM
rew committed R10:690b7ea08179: bhyve/snapshot: ..back to SOCK_STREAM (authored by rew).
bhyve/snapshot: ..back to SOCK_STREAM
Thu, Apr 28, 3:45 PM
rew closed D34863: bhyve/snapshot: ..back to SOCK_STREAM.
Thu, Apr 28, 3:45 PM

Mon, Apr 25

rew updated the diff for D34863: bhyve/snapshot: ..back to SOCK_STREAM.

address feedback from markj:

  • wrap long line
  • close file descriptor being leaked
Mon, Apr 25, 4:02 PM

Sun, Apr 24

rew added a reviewer for D35044: pfilctl: initialize pio_nheads for PFILIOC_LISTHEADS ioctl: glebius.
Sun, Apr 24, 6:18 PM
rew requested review of D35044: pfilctl: initialize pio_nheads for PFILIOC_LISTHEADS ioctl.
Sun, Apr 24, 6:17 PM
rew updated the diff for D34863: bhyve/snapshot: ..back to SOCK_STREAM.

feedback from jhb..use SUN_LEN()

Sun, Apr 24, 4:18 PM

Tue, Apr 19

rew accepted D34952: prometheus_sysctl_exporter: fix metric aliasing.

looks good, thanks

Tue, Apr 19, 5:53 AM

Sat, Apr 16

rew added a comment to D34547: bhyve - snapshot capsicum integration[Part 1].

What about receiving the file descriptors from the nvlist?

Sat, Apr 16, 11:47 PM

Apr 14 2022

rew added inline comments to D34866: nvme: Fix old intel alignment size.
Apr 14 2022, 12:30 AM

Apr 13 2022

rew committed R10:7472cae2e098: mount.8: mention that the snapshot option is exclusive (authored by rew).
mount.8: mention that the snapshot option is exclusive
Apr 13 2022, 9:04 PM
rew committed R10:34116aa48131: ffs_mount(): fix snapshotting (authored by rew).
ffs_mount(): fix snapshotting
Apr 13 2022, 9:04 PM
rew committed R10:d7d8cc989150: ffs_mount(): return early if namei() fails to lookup disk device (authored by rew).
ffs_mount(): return early if namei() fails to lookup disk device
Apr 13 2022, 9:04 PM
rew added a comment to D32886: prometheus_sysctl_exporter: Improve sysctl OID names rewriting..

OTOH, on my system the only collisions are caused by the ZFS sysctls marked "LEGACY", and vm.uma.tcp_log_bucket.size/vm.uma.tcp_log.bucket_size. So a less disruptive option would simply be to ignore the LEGACY sysctls, and rename vm.uma.tcp_log.bucket_size.

Apr 13 2022, 5:58 PM
rew added a comment to D32886: prometheus_sysctl_exporter: Improve sysctl OID names rewriting..

From the PR...it looks like ~25 metrics are broken. And compare that to the total number of exported metrics:

% prometheus_sysctl_exporter | wc -l
    13360
Apr 13 2022, 5:51 PM
rew added a comment to D32886: prometheus_sysctl_exporter: Improve sysctl OID names rewriting..

If the name of the metric being exported changes...how will that not break existing setups?

Apr 13 2022, 5:24 PM

Apr 11 2022

rew abandoned D34880: pf: grab pf_config_lock when freeing a rule.
In D34880#790376, @kp wrote:

I'm very, very tempted to say we should just remove DIOCCHANGERULE, but at least miniupnpd actually uses it.

Apr 11 2022, 2:34 PM
rew added reviewers for D34880: pf: grab pf_config_lock when freeing a rule: kp, mjg.
Apr 11 2022, 7:22 AM
rew requested review of D34880: pf: grab pf_config_lock when freeing a rule.
Apr 11 2022, 7:20 AM

Apr 10 2022

rew committed R10:d4e8207317ca: vmm_instruction_emul.c: fix bhyve build (authored by rew).
vmm_instruction_emul.c: fix bhyve build
Apr 10 2022, 9:39 PM
rew committed R10:5a17f489d584: vmm: fix set but not used warning (authored by rew).
vmm: fix set but not used warning
Apr 10 2022, 6:35 PM
rew committed R10:5241577a223d: vmm: fix set but not used warning (authored by rew).
vmm: fix set but not used warning
Apr 10 2022, 6:35 PM
rew committed R10:3587bfa797cd: vmm: fix set but not used warning (authored by rew).
vmm: fix set but not used warning
Apr 10 2022, 6:35 PM
rew committed R10:5c272efaba29: vmm: fix set but not used warnings (authored by rew).
vmm: fix set but not used warnings
Apr 10 2022, 6:35 PM
rew committed R10:893a3dd697ef: vmm: fix set but not used warning (authored by rew).
vmm: fix set but not used warning
Apr 10 2022, 6:35 PM
rew committed R10:f877977a034b: vmm: fix set but not used warnings (authored by rew).
vmm: fix set but not used warnings
Apr 10 2022, 6:35 PM
rew requested review of D34863: bhyve/snapshot: ..back to SOCK_STREAM.
Apr 10 2022, 5:16 AM
rew committed R10:c79331a42c30: bhyve: use linker set for ipc commands (authored by rew).
bhyve: use linker set for ipc commands
Apr 10 2022, 2:52 AM
rew closed D34760: bhyve: use linker set for ipc commands.
Apr 10 2022, 2:52 AM
rew added inline comments to D34760: bhyve: use linker set for ipc commands.
Apr 10 2022, 2:11 AM

Apr 9 2022

rew abandoned D34792: kern.mk: hook GCC up to src.conf knob.
Apr 9 2022, 5:46 AM

Apr 6 2022

rew added a reviewer for D34792: kern.mk: hook GCC up to src.conf knob: jhb.
Apr 6 2022, 9:07 AM
rew requested review of D34792: kern.mk: hook GCC up to src.conf knob.
Apr 6 2022, 9:05 AM
mhorne awarded D34784: suppress set but not used warnings for kernel builds a Like token.
Apr 6 2022, 12:17 AM

Apr 5 2022

rew committed R10:e8e691983bb7: suppress set but not used warnings for kernel builds (authored by rew).
suppress set but not used warnings for kernel builds
Apr 5 2022, 9:44 PM
rew closed D34784: suppress set but not used warnings for kernel builds.
Apr 5 2022, 9:44 PM
rew added a comment to D34784: suppress set but not used warnings for kernel builds.
Apr 5 2022, 9:06 PM
rew retitled D34784: suppress set but not used warnings for kernel builds from suppress set but not used warnings for kernel modules to suppress set but not used warnings for kernel builds.
Apr 5 2022, 6:49 PM
rew updated the diff for D34784: suppress set but not used warnings for kernel builds.

Taking this review in a different direction..

Apr 5 2022, 6:41 PM
rew updated the diff for D34784: suppress set but not used warnings for kernel builds.

feedback from imp: use ${NO_WUNUSED_BUT_SET_VARIABLE}

Apr 5 2022, 1:13 AM

Apr 4 2022

rew requested review of D34784: suppress set but not used warnings for kernel builds.
Apr 4 2022, 11:46 PM
rew committed R10:f3f6e0ebe9ec: geom_vinum: fix set but not used warnings (authored by rew).
geom_vinum: fix set but not used warnings
Apr 4 2022, 9:25 PM
rew committed R10:8f7878e3e151: geom_eli: fix set but not used warning (authored by rew).
geom_eli: fix set but not used warning
Apr 4 2022, 9:22 PM
rew requested review of D34777: geom_dev: extend kevent support for geom dev.
Apr 4 2022, 5:21 PM

Apr 3 2022

rew added inline comments to D34760: bhyve: use linker set for ipc commands.
Apr 3 2022, 7:27 PM
rew requested review of D34760: bhyve: use linker set for ipc commands.
Apr 3 2022, 7:18 PM

Apr 1 2022

rew updated the diff for D34731: bikeshed.7: the backstory.

remaining mandoc warnings left to preserve format of original text

Apr 1 2022, 6:44 PM
rew requested review of D34731: bikeshed.7: the backstory.
Apr 1 2022, 9:06 AM
rew accepted D34605: bectl: push space-in-name check down into libbe.
Apr 1 2022, 4:05 AM

Mar 31 2022

rew added inline comments to D34688: bhyve: avoid uninitialized variable.
Mar 31 2022, 8:25 PM · bhyve
rew added a comment to D34547: bhyve - snapshot capsicum integration[Part 1].

All revisions in this stack need to be updated and rebased.

Mar 31 2022, 7:00 PM

Mar 30 2022

rew added a comment to D34681: add pidfile_signal and use it in mount.
/usr/src/lib/libutil/pidfile.c:369:2: error: implicit declaration of function 'kill' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        kill(pid, sig);
Mar 30 2022, 9:17 PM

Mar 18 2022

rew accepted D34538: bectl: add some discussion about boot environment layouts.
Mar 18 2022, 6:25 PM
rew accepted D34605: bectl: push space-in-name check down into libbe.
Mar 18 2022, 6:18 PM
rew committed R10:3ebe1109348f: bhyve: sweep MAX_VMNAME (authored by rew).
bhyve: sweep MAX_VMNAME
Mar 18 2022, 5:58 AM
rew closed D34292: bhyve: sweep MAX_VMNAME.
Mar 18 2022, 5:58 AM
rew committed R10:961e6a12efdb: bhyve/snapshot: limit snapshot filename to NAME_MAX (authored by rew).
bhyve/snapshot: limit snapshot filename to NAME_MAX
Mar 18 2022, 5:54 AM
rew closed D34291: bhyve/snapshot: limit snapshot filename to NAME_MAX.
Mar 18 2022, 5:54 AM
rew closed D34290: libvmm: use a const char pointer for vm name in struct vmctx.
Mar 18 2022, 5:46 AM
rew committed R10:3efc45f34e13: libvmm: constify vm_get_name() (authored by rew).
libvmm: constify vm_get_name()
Mar 18 2022, 5:46 AM
rew committed R10:ee0ebaa42028: bhyvectl: drop vm_get_name() (authored by rew).
bhyvectl: drop vm_get_name()
Mar 18 2022, 5:25 AM
rew closed D34399: bhyvectl: drop vm_get_name().
Mar 18 2022, 5:25 AM

Mar 17 2022

rew closed D34584: mount.8: mention that the snapshot option is exclusive.
Mar 17 2022, 10:34 PM
rew committed R10:8772a9117b27: mount.8: mention that the snapshot option is exclusive (authored by rew).
mount.8: mention that the snapshot option is exclusive
Mar 17 2022, 10:34 PM
rew added a comment to D34584: mount.8: mention that the snapshot option is exclusive.
In D34584#783549, @0mp wrote:

MFC?

Mar 17 2022, 10:08 PM
rew requested changes to D34547: bhyve - snapshot capsicum integration[Part 1].

You have broken up https://reviews.freebsd.org/D30471 into multiple reviews without addressing the issues I raised in the original review.

Mar 17 2022, 5:47 PM
rew updated subscribers of D34584: mount.8: mention that the snapshot option is exclusive.
Mar 17 2022, 1:44 AM
rew requested review of D34584: mount.8: mention that the snapshot option is exclusive.
Mar 17 2022, 1:42 AM
rew committed R10:ab2dbd9b871d: ffs_mount(): fix snapshotting (authored by rew).
ffs_mount(): fix snapshotting
Mar 17 2022, 1:41 AM
rew closed D34562: ffs: fix mksnap_ffs.
Mar 17 2022, 1:40 AM

Mar 16 2022

rew committed R10:f6f357efb106: bhyve: missing mutex initializations (authored by andy_omniosce.org).
bhyve: missing mutex initializations
Mar 16 2022, 4:00 AM
rew closed D34372: bhyve: missing mutex initialisations.
Mar 16 2022, 3:59 AM

Mar 15 2022

rew updated subscribers of D34562: ffs: fix mksnap_ffs.
Mar 15 2022, 1:56 AM
rew added a reviewer for D34562: ffs: fix mksnap_ffs: mckusick.
Mar 15 2022, 1:54 AM
rew requested review of D34562: ffs: fix mksnap_ffs.
Mar 15 2022, 1:52 AM

Mar 14 2022

rew accepted D34550: bsnmp: Use mkstemp when creating clients local socket.
Mar 14 2022, 6:32 PM
rew added a comment to D34372: bhyve: missing mutex initialisations.

I’ll commit this tomorrow.

Mar 14 2022, 3:32 PM

Mar 8 2022

rew committed R10:1987ff8abca2: cam: don't lock while handling an AC_UNIT_ATTENTION (authored by rew).
cam: don't lock while handling an AC_UNIT_ATTENTION
Mar 8 2022, 7:13 AM
rew committed R10:901c52f13c46: periodic: remove obsolete news.expire (authored by Nils Johannsen <n.johannsen@beckhoff.com>).
periodic: remove obsolete news.expire
Mar 8 2022, 4:48 AM
rew closed D30631: periodic: remove obsolete news.expire.
Mar 8 2022, 4:48 AM

Mar 7 2022

rew committed R10:0455cc7104ec: ffs_mount(): return early if namei() fails to lookup disk device (authored by rew).
ffs_mount(): return early if namei() fails to lookup disk device
Mar 7 2022, 7:52 PM
rew closed D30870: ffs: skip upgrade from ro->rw if namei fails.
Mar 7 2022, 7:52 PM

Mar 3 2022

rew committed R10:87f6367f1061: bhyve: add varfile option to nvlist of lpc device (authored by c.koehne_beckhoff.com).
bhyve: add varfile option to nvlist of lpc device
Mar 3 2022, 7:57 AM
rew closed D33433: bhyve: add varfile option to nvlist of lpc device.
Mar 3 2022, 7:56 AM · bhyve

Mar 1 2022

rew accepted D34238: zstd: fix benchmarking.

not sure if using CSTD=c11 in usr.bin/zstd/Makefile would be acceptable/work here, to avoid touching contrib code.

Mar 1 2022, 5:41 PM
rew accepted D34387: zfs: Update test format strings to match variable typtes.
Mar 1 2022, 5:02 PM
rew committed R10:2062ce996ddd: vmm: fix "set but not used" warnings (authored by rew).
vmm: fix "set but not used" warnings
Mar 1 2022, 12:12 AM

Feb 28 2022

rew committed R10:39d87a023567: vmm: fix "set but not used" warnings (authored by rew).
vmm: fix "set but not used" warnings
Feb 28 2022, 11:57 PM
rew committed R10:73505a10760c: vmm: fix "set but not used" warnings (authored by rew).
vmm: fix "set but not used" warnings
Feb 28 2022, 11:51 PM
rew updated the diff for D34290: libvmm: use a const char pointer for vm name in struct vmctx.

I split out the bhyvectl changes into a separate review:

Feb 28 2022, 9:17 PM
rew requested review of D34399: bhyvectl: drop vm_get_name().
Feb 28 2022, 9:10 PM
rew updated the diff for D34290: libvmm: use a const char pointer for vm name in struct vmctx.

updated per feedback from jhb

Feb 28 2022, 6:17 PM
rew accepted D34372: bhyve: missing mutex initialisations.

Perhaps I'm getting confused. Are we saying on FreeBSD mutex's are initialized automatically, or in this particular case? If so, where/how does the initialization happen?

Feb 28 2022, 4:55 PM
rew added a comment to D34372: bhyve: missing mutex initialisations.

I didn't realize that these mutex's get initialized on FreeBSD, even without your patch.

Feb 28 2022, 2:52 AM

Feb 26 2022

rew added a comment to D34372: bhyve: missing mutex initialisations.

looking at the comment above the struct virtio_softc definition in usr.sbin/bhyve/virtio.h:

[ ... snipped ... ]
* Note: inside each hypervisor virtio driver, changes to these
* data structures must be locked against other threads, if any.
* Except for PCI config space register read/write, we assume each
* driver does the required locking, but we need a pointer to the
* lock (if there is one) for PCI config space read/write ops.
[ ... snipped ... ]
Feb 26 2022, 8:23 PM

Feb 24 2022

rew closed D34301: bhyve: memory leak in topology_parse().
Feb 24 2022, 5:43 PM
rew committed R10:ad3da82996ff: bhyve: plug memory leak in topology_parse() (authored by andy_omniosce.org).
bhyve: plug memory leak in topology_parse()
Feb 24 2022, 5:43 PM

Feb 23 2022

rew committed R10:0add00229d54: dumpfs(8): add option to only print superblock information (authored by rew).
dumpfs(8): add option to only print superblock information
Feb 23 2022, 6:30 PM
rew committed R10:95eea15111b0: tcp_twrespond: send signed segment when connection is TCP-MD5 (authored by rew).
tcp_twrespond: send signed segment when connection is TCP-MD5
Feb 23 2022, 6:25 PM