Page MenuHomeFreeBSD

rew (Rob Wing)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 14 2018, 8:11 PM (105 w, 6 d)

Recent Activity

Sun, Nov 22

rew accepted D27319: kern: dup: do not assume oldfde is valid.

I can confirm this fixes the panic that I introduced in r367927.

Sun, Nov 22, 10:38 PM
rew closed D18617: free old file descriptor tables when not shared.
Sun, Nov 22, 5:00 AM
rew committed rS367927: fd: free old file descriptor tables when not shared.
fd: free old file descriptor tables when not shared
Sun, Nov 22, 5:00 AM

Sat, Nov 7

rew closed D25631: periodic script to create backup of gmirror information.
Sat, Nov 7, 4:15 AM
rew committed rS367443: Add a periodic script to backup output generated from `gmirror list`..
Add a periodic script to backup output generated from `gmirror list`.
Sat, Nov 7, 4:15 AM

Fri, Nov 6

rew closed D25638: Add periodic script to backup zfs and zpool information.
Fri, Nov 6, 10:58 PM
rew committed rS367436: Add a periodic script to backup output generated from `zfs list`, `zfs get`,.
Add a periodic script to backup output generated from `zfs list`, `zfs get`,
Fri, Nov 6, 10:58 PM

Thu, Nov 5

rew abandoned D26700: ctl.conf(5): add support for an 'include' directive..
Thu, Nov 5, 6:37 PM
rew added inline comments to D27096: top(1): allow filtering by command name.
Thu, Nov 5, 8:56 AM
rew updated the diff for D27096: top(1): allow filtering by command name.

fix missing != NULL check

Thu, Nov 5, 8:43 AM
rew requested review of D27096: top(1): allow filtering by command name.
Thu, Nov 5, 3:29 AM

Oct 20 2020

rew closed D26805: geom_ctl.c: remove unused header files.
Oct 20 2020, 8:59 PM
rew committed rS366903: geom_ctl.c: remove stale header files.
geom_ctl.c: remove stale header files
Oct 20 2020, 8:59 PM

Oct 15 2020

rew requested review of D26805: geom_ctl.c: remove unused header files.
Oct 15 2020, 8:04 PM

Oct 13 2020

rew closed D26716: ctl.conf(5): fix LUN size in UCL format example..
Oct 13 2020, 6:00 PM
rew committed rS366676: ctl.conf(5): fix LUN size in UCL format example..
ctl.conf(5): fix LUN size in UCL format example.
Oct 13 2020, 6:00 PM

Oct 9 2020

rew added a comment to D26700: ctl.conf(5): add support for an 'include' directive..

@asomers, good question...if your configuration is in UCL format, then probably not.

Oct 9 2020, 5:33 PM
rew updated the diff for D26716: ctl.conf(5): fix LUN size in UCL format example..

Updating D26716: ctl.conf(5): fix LUN size in UCL format example.

Oct 9 2020, 4:49 PM

Oct 8 2020

rew updated the diff for D26716: ctl.conf(5): fix LUN size in UCL format example..

Updating D26716: ctl.conf(5): fix LUN size in UCL format example.

Oct 8 2020, 8:52 AM
rew requested review of D26716: ctl.conf(5): fix LUN size in UCL format example..
Oct 8 2020, 6:30 AM

Oct 7 2020

rew added a comment to D26700: ctl.conf(5): add support for an 'include' directive..

The include directive works with the general syntax version or the UCL format version for ctl.conf(5). It doesn't interfere
nor is it compatible with the .include macro offered by libucl - the .include macro is handy though and has more functionality.

Oct 7 2020, 8:30 AM
rew updated the diff for D26700: ctl.conf(5): add support for an 'include' directive..

Updating D26700: ctl.conf(5): add support for an 'include' directive.

Oct 7 2020, 7:32 AM

Oct 6 2020

rew requested review of D26700: ctl.conf(5): add support for an 'include' directive..
Oct 6 2020, 9:18 PM

Oct 4 2020

rew updated the diff for D25638: Add periodic script to backup zfs and zpool information.

Updating D25638: Add periodic script to backup zfs and zpool information

Oct 4 2020, 7:17 PM

Sep 9 2020

rew closed D26023: Don't truncate interface names for periodic script: 420.status-network.
Sep 9 2020, 7:07 PM
rew committed rS365508: periodic.conf(5): don't truncate interface names reported by 420.status-network..
periodic.conf(5): don't truncate interface names reported by 420.status-network.
Sep 9 2020, 7:07 PM

Sep 8 2020

rew committed rS365448: MFC r364369:.
MFC r364369:
Sep 8 2020, 7:37 AM

Aug 19 2020

rew closed D26048: bectl_list: align column output for a mountpoint properly.
Aug 19 2020, 12:09 AM
rew committed rS364369: bectl(8): Fix output of `bectl list` for the 'Mountpoint' column..
bectl(8): Fix output of `bectl list` for the 'Mountpoint' column.
Aug 19 2020, 12:09 AM

Aug 12 2020

rew added reviewers for D26048: bectl_list: align column output for a mountpoint properly: allanjude, kevans.
Aug 12 2020, 7:23 PM
rew requested review of D26048: bectl_list: align column output for a mountpoint properly.
Aug 12 2020, 7:21 PM

Aug 11 2020

rew added reviewers for D26023: Don't truncate interface names for periodic script: 420.status-network: allanjude, kevans.
Aug 11 2020, 7:37 AM
rew requested review of D26023: Don't truncate interface names for periodic script: 420.status-network.
Aug 11 2020, 7:34 AM

Aug 5 2020

rew updated the diff for D25631: periodic script to create backup of gmirror information.

Updating D25631: periodic script to create backup of gmirror information

Aug 5 2020, 7:33 PM
rew added inline comments to D25631: periodic script to create backup of gmirror information.
Aug 5 2020, 5:10 PM
rew updated the diff for D25631: periodic script to create backup of gmirror information.

Updating D25631: periodic script to create backup of gmirror information

Aug 5 2020, 5:00 PM
rew added a reviewer for D25631: periodic script to create backup of gmirror information: kevans.
Aug 5 2020, 7:51 AM
rew updated the diff for D25631: periodic script to create backup of gmirror information.

clarify new variables in periodic.conf(5).

Aug 5 2020, 7:49 AM

Jul 31 2020

lwhsu renamed rew from rob.fx907_gmail.com to rew.
Jul 31 2020, 8:38 AM

Jul 27 2020

rew requested review of D25837: Add myself (rew) as a src committer.
Jul 27 2020, 9:29 PM
rew requested review of D25836: Add myself (rew) as a src committer.
Jul 27 2020, 9:13 PM

Jul 23 2020

rew updated rew.
Jul 23 2020, 9:09 PM

Jul 22 2020

rew retitled D25780: Use NULL for zfs_send_one in be_export from Summary: Use NULL for the fifth argument in openzfs's function zfs_send_one(), used within be_export(). to Use NULL for zfs_send_one in be_export.
Jul 22 2020, 10:41 PM
rew requested review of D25780: Use NULL for zfs_send_one in be_export.
Jul 22 2020, 10:39 PM

Jul 14 2020

rew updated the diff for D18617: free old file descriptor tables when not shared.
  • de-butcher the indenting
Jul 14 2020, 10:27 PM
rew updated the diff for D25631: periodic script to create backup of gmirror information.

Install the new 222.backup-gmirror periodic script.

Jul 14 2020, 9:55 AM
rew updated the diff for D18617: free old file descriptor tables when not shared.

Fixed ATF test cases to require root user.

Jul 14 2020, 8:03 AM

Jul 13 2020

rew requested review of D25653: add 221.backup-gpart to usr.sbin/periodic/etc/daily/Makefile.
Jul 13 2020, 7:42 PM

Jul 12 2020

rew requested review of D25638: Add periodic script to backup zfs and zpool information.
Jul 12 2020, 7:16 PM
rew updated the summary of D25631: periodic script to create backup of gmirror information.
Jul 12 2020, 4:00 AM
rew added reviewers for D25631: periodic script to create backup of gmirror information: allanjude, 0mp.
Jul 12 2020, 3:58 AM
rew requested review of D25631: periodic script to create backup of gmirror information.
Jul 12 2020, 3:45 AM

Jul 11 2020

rew updated the diff for D25628: add backup of efi partition for daily periodic.
  • Document changes for new periodic variables in periodic.conf(5). Set defaults for new variables in periodic.conf.
Jul 11 2020, 8:35 PM
rew requested review of D25628: add backup of efi partition for daily periodic.
Jul 11 2020, 6:55 PM

Apr 7 2020

rew updated the diff for D24289: map capability string for VM_CAP_BPT_EXIT.

Updating D24289: map capability string for VM_CAP_BPT_EXIT

Apr 7 2020, 3:45 PM

Apr 4 2020

rew created D24289: map capability string for VM_CAP_BPT_EXIT.
Apr 4 2020, 2:41 AM

Aug 1 2019

rew added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

You’re welcome to finish it up..

Aug 1 2019, 1:24 AM
rew added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@araujo, sounds like you are taking over this review?

Aug 1 2019, 12:12 AM

Jul 1 2019

rew created D20818: implement sorting for 'bectl list' output.
Jul 1 2019, 11:05 AM

May 12 2019

rew created D20249: add description for create subcommand (bectl.8).
May 12 2019, 8:33 PM

May 11 2019

rew created D20240: create non-recursive boot environments (bectl).
May 11 2019, 8:43 PM

Apr 19 2019

rew updated the diff for D18564: allow creation of non-recursive boot environments (libbe).

Updating D18564: allow creation of non-recursive boot environments (libbe)

Apr 19 2019, 5:49 AM
rew updated the diff for D18564: allow creation of non-recursive boot environments (libbe).

Updating D18564: allow creation of non-recursive boot environments (libbe)

Apr 19 2019, 12:22 AM

Apr 13 2019

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

Sounds good, I will do that. You can expect to see an updated revision in the next few days.

Apr 13 2019, 9:00 PM

Mar 30 2019

rew updated the diff for D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe).

Updating D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe)

Mar 30 2019, 7:51 PM

Mar 19 2019

rew updated the test plan for D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe).
Mar 19 2019, 9:19 PM
rew created D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe).
Mar 19 2019, 9:18 PM

Mar 8 2019

rew updated the diff for D18564: allow creation of non-recursive boot environments (libbe).

Updating D18564: allow creation of non-recursive boot environments (libbe)

Mar 8 2019, 9:40 PM

Mar 7 2019

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

The channel programs look like a cool feature - I have a few questions about it:

Mar 7 2019, 7:22 PM

Mar 4 2019

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

I'm not sure why the history is clobbered for this updated diff revision with regards to target_prog.c being copied from be_impl.h.

Mar 4 2019, 9:59 PM
rew updated the diff for D18564: allow creation of non-recursive boot environments (libbe).

Updating D18564: allow creation of non-recursive boot environments (libbe)

Mar 4 2019, 9:49 PM

Feb 28 2019

rew created D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
Feb 28 2019, 12:58 AM

Feb 24 2019

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

A question about the added files - am I supposed to include the copyright/license information or...?

Feb 24 2019, 10:40 AM
rew updated the diff for D18564: allow creation of non-recursive boot environments (libbe).

Updating D18564: allow creation of non-recursive boot environments (libbe)

Feb 24 2019, 9:56 AM

Feb 22 2019

rew updated the diff for D18564: allow creation of non-recursive boot environments (libbe).

Updating D18564: allow creation of non-recursive boot environments (libbe)

Feb 22 2019, 9:19 AM

Feb 14 2019

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

Hey Kyle,

Feb 14 2019, 6:50 PM

Jan 4 2019

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

Do you use IRC or anything of the sort? Some of this might be easier to hash out in real-time, and we can summarize the results of said discussion back in this review.

Jan 4 2019, 6:05 PM

Dec 27 2018

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

It's probably poor style to change the user interface for bectl but, it's
already recursive by default - could always ignore the '-r' flag and add a flag
for shallow creation. Upside here is the current behavior remains unchanged.
Downside being, confusion for current users (i.e. the shell game of
command-line flags).

Dec 27 2018, 10:30 PM

Dec 26 2018

rew added a comment to D18564: allow creation of non-recursive boot environments (libbe).

I agree, the default be_create is adequate for most cases. If anything, I would lean
towards a be_create_shallow, here's my thinking. be_create is, effectively,
a recursive snapshot that gets cloned - which is consistent with the zfs
behavior of 'zfs snapshot -r'. be_create_shallow would be consistent with
a 'zfs snapshot', minus the recursive flag.

Dec 26 2018, 8:49 PM

Dec 22 2018

rew updated the diff for D18607: bectl: use jail id as the default jail name for a boot environment.

Added tests in sbin/bectl/test and fixed styling issues.

Dec 22 2018, 12:11 PM

Dec 20 2018

rew created D18617: free old file descriptor tables when not shared.
Dec 20 2018, 2:20 AM

Dec 19 2018

rew created D18607: bectl: use jail id as the default jail name for a boot environment.
Dec 19 2018, 11:14 AM

Dec 14 2018

rew created D18564: allow creation of non-recursive boot environments (libbe).
Dec 14 2018, 10:19 PM