Page MenuHomeFreeBSD

mgrooms_shrew.net (Matthew Grooms)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 14 2016, 9:54 PM (349 w, 1 d)

Recent Activity

Aug 1 2022

mgrooms_shrew.net added a comment to D29262: Bhyve - Using JSON format for saving and restoring the state.

What is the real purpose for this review? If debugging, I think this is not right way by adding huge amount of new code. I would suggest to remove all json things, remove all SNAPSHOT_VAR_OR_LEAVE and its variations and move basis to nvlist.

Using nvlist is more elegant and simpler, brings ability to extract (dump) all information for debugging, and gives to snapshot/resume dealing with optional parameters, removing some parameters, adding new parameters without breaking "resume" with previously created snapshots.

Aug 1 2022, 6:12 PM · bhyve

Jun 23 2022

mgrooms_shrew.net added a comment to D35454: bhyve: snapshot capsicum support.

Do these get bhyve closer to what you believe to be required?

Jun 23 2022, 5:14 PM · bhyve

Sep 3 2020

mgrooms_shrew.net edited reviewers for D26268: bhyve: snapshot virtio queues can fail, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.
Sep 3 2020, 5:06 PM · bhyve
mgrooms_shrew.net edited reviewers for D26267: bhyve: snapshot impovements for 'blockif' backend, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.
Sep 3 2020, 5:06 PM · bhyve
mgrooms_shrew.net edited reviewers for D26266: bhyve: snapshot fix for ahci-cd, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.
Sep 3 2020, 5:06 PM · bhyve
mgrooms_shrew.net edited reviewers for D26265: bhyve: snapshot for virtio-rnd, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.
Sep 3 2020, 5:06 PM · bhyve
mgrooms_shrew.net edited reviewers for D26264: bhyve: 'xhci,tablet' snapshot fixes, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.
Sep 3 2020, 5:05 PM · bhyve
mgrooms_shrew.net edited reviewers for D26263: bhyve: Fix build with option BHYVE_SNAPSHOT, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.
Sep 3 2020, 5:05 PM · bhyve

Aug 13 2019

mgrooms_shrew.net added a watcher for bhyve: mgrooms_shrew.net.
Aug 13 2019, 8:48 PM

Mar 23 2018

Herald added a reviewer for D10213: Adding virtualization support for ARMv7 platforms: rgrimes.
Mar 23 2018, 2:43 PM · ARM

Jun 15 2016

mgrooms_shrew.net added a comment to D6786: pf: Filter on and set vlan PCP values.

Do you intend to try and commit this to head before the freeze? It functionally looks the same as D801 which was also accepted by adrian and gnn, but with slightly different syntax.

Jun 15 2016, 5:05 PM

Jun 2 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..
In D801#139427, @kristof wrote:

I noticed that code slush begins May 27th, which is two days from now. Can I help test anything else?

I think this patch isn't going to be ready before the code slush.
I'm honestly not happy with the approach taken here to set and use the PCP bits.

Jun 2 2016, 4:12 PM

May 25 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..

I noticed that code slush begins May 27th, which is two days from now. Can I help test anything else?

May 25 2016, 4:39 PM

May 20 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..

I was able to get some light testing done with this patch applied. Things appear to be working well. NOTE: You'r missing a closing bracket in sys/netpfil/pf/pf.c around line 6078.

May 20 2016, 4:46 AM

May 18 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..

The pf_ieee8021q_setpcp is being called twice in the ipv6 code path. I submitted a patch to fix this in pfSense so it should apply here as well ...

May 18 2016, 2:40 AM

May 16 2016

mgrooms_shrew.net added a comment to D4112: Import Isilon port of VMWare PV SCSI driver.

There's also a OpenBSD VMware PVSCSI driver. If there are licensing concerns with this driver, perhaps the other could be ported instead ...

May 16 2016, 7:35 PM
mgrooms_shrew.net added a comment to D4112: Import Isilon port of VMWare PV SCSI driver.

Any chance this will be reviewed and committed for the 11 release? Seems like it would be a pretty useful addition.

May 16 2016, 6:23 PM

May 11 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..

Could this please make it into the tree for the 11 release? Also, is there a review in progress for the pf related changes yet?

May 11 2016, 8:35 PM

Mar 10 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..

Anything I can do to help as far as testing goes?

Mar 10 2016, 3:17 AM

Feb 23 2016

mgrooms_shrew.net added a comment to D801: Add 802.1p priority code point to vlan(4)..

Just wanted to offer some feedback: I've applied this patch to a 10.2-RELEASE host and have been running it for a week now with zero issues. I also have a patch extracted from pfSense that allows pf to match on or set the vlan pcp values. Both were required to build a FreeBSD pf firewall that works well with Google Fiber internet service. With these applied, I'm able to push/pull the full gigabit up/down using a tiny single core ESXi VM. Without the patches I'm only able to get about 10 megabit up.

Feb 23 2016, 5:54 PM