- User Since
- Jan 14 2016, 9:54 PM (402 w, 1 d)
Jun 20 2023
It's pretty simple: The most constructive way to help a review process is to provide feedback on the proposed code changes.
Aug 1 2022
Jun 23 2022
Do these get bhyve closer to what you believe to be required?
Sep 3 2020
Aug 13 2019
Mar 23 2018
Jun 15 2016
Do you intend to try and commit this to head before the freeze? It functionally looks the same as D801 which was also accepted by adrian and gnn, but with slightly different syntax.
Jun 2 2016
May 25 2016
I noticed that code slush begins May 27th, which is two days from now. Can I help test anything else?
May 20 2016
I was able to get some light testing done with this patch applied. Things appear to be working well. NOTE: You'r missing a closing bracket in sys/netpfil/pf/pf.c around line 6078.
May 18 2016
The pf_ieee8021q_setpcp is being called twice in the ipv6 code path. I submitted a patch to fix this in pfSense so it should apply here as well ...
May 16 2016
There's also a OpenBSD VMware PVSCSI driver. If there are licensing concerns with this driver, perhaps the other could be ported instead ...
Any chance this will be reviewed and committed for the 11 release? Seems like it would be a pretty useful addition.
May 11 2016
Could this please make it into the tree for the 11 release? Also, is there a review in progress for the pf related changes yet?
Mar 10 2016
Anything I can do to help as far as testing goes?
Feb 23 2016
Just wanted to offer some feedback: I've applied this patch to a 10.2-RELEASE host and have been running it for a week now with zero issues. I also have a patch extracted from pfSense that allows pf to match on or set the vlan pcp values. Both were required to build a FreeBSD pf firewall that works well with Google Fiber internet service. With these applied, I'm able to push/pull the full gigabit up/down using a tiny single core ESXi VM. Without the patches I'm only able to get about 10 megabit up.