Page MenuHomeFreeBSD

sobomax (Maksym Sobolyev)
User

Projects

User Details

User Since
Jan 29 2016, 5:27 AM (252 w, 3 d)

Recent Activity

Wed, Nov 25

sobomax closed D27355: Unobfuscate "KERNLOAD" parameter on amd64.
Wed, Nov 25, 11:19 PM
sobomax committed rS368041: Unobfuscate "KERNLOAD" parameter on amd64. This change lines-up amd64 with the.
Unobfuscate "KERNLOAD" parameter on amd64. This change lines-up amd64 with the
Wed, Nov 25, 11:19 PM
sobomax updated the diff for D27355: Unobfuscate "KERNLOAD" parameter on amd64.

Merge in comments for the KERNLOAD into one blob.

Wed, Nov 25, 11:08 PM
sobomax added a comment to D27355: Unobfuscate "KERNLOAD" parameter on amd64.

Updated, thanks @markj !

Wed, Nov 25, 9:43 PM
sobomax updated the diff for D27355: Unobfuscate "KERNLOAD" parameter on amd64.

Eliminate KERNEL_PHYSICAL_BASE althogether, move #include <machine/vmparam.h> into i386/amd64-specific section.

Wed, Nov 25, 9:43 PM
sobomax added inline comments to D27355: Unobfuscate "KERNLOAD" parameter on amd64.
Wed, Nov 25, 5:10 PM

Tue, Nov 24

sobomax updated the summary of D27355: Unobfuscate "KERNLOAD" parameter on amd64.
Tue, Nov 24, 7:31 PM
sobomax updated the summary of D27355: Unobfuscate "KERNLOAD" parameter on amd64.
Tue, Nov 24, 7:28 PM
sobomax updated the summary of D27355: Unobfuscate "KERNLOAD" parameter on amd64.
Tue, Nov 24, 7:25 PM
sobomax requested review of D27355: Unobfuscate "KERNLOAD" parameter on amd64.
Tue, Nov 24, 7:24 PM

Sep 24 2020

sobomax committed rS366126: Fix a typo in the 366098..
Fix a typo in the 366098.
Sep 24 2020, 7:12 PM
sobomax committed rS366098: dd a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file….
dd a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file…
Sep 24 2020, 2:45 AM
sobomax closed D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
Sep 24 2020, 2:45 AM

Sep 23 2020

sobomax added a comment to D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..

Looks ok to me, my comments are just nitpicking.

Sep 23 2020, 9:49 PM
sobomax added a comment to D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..

Thanks Ravi for suggestion, it has been incorporated.

Sep 23 2020, 9:21 PM
sobomax updated the diff for D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..

Clarify intended use case for the new option.

Sep 23 2020, 9:20 PM
sobomax added a comment to D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..

Thank for a review Mark! 4 out of 5 suggestions have been incorporated, please check.

Sep 23 2020, 4:52 PM
sobomax updated the diff for D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
o (void)xyz -> xyz __unused;
Sep 23 2020, 4:35 PM
sobomax updated the diff for D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..

Reset do_log_reopen earlier, so that we don't stuck in a loop calling this function repeatedly if error happens.

Sep 23 2020, 2:53 AM
sobomax updated the diff for D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..

Use signal handler in a safe way.

Sep 23 2020, 2:17 AM
sobomax updated the diff for D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
Sep 23 2020, 1:05 AM
sobomax updated the summary of D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
Sep 23 2020, 1:02 AM
sobomax requested review of D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
Sep 23 2020, 1:02 AM

Aug 24 2020

sobomax committed rS364711: In the endless batch mode (-B), terminate if and when stdout is closed..
In the endless batch mode (-B), terminate if and when stdout is closed.
Aug 24 2020, 4:45 PM

Apr 7 2020

sobomax closed D20520: Normalize deployment tools usage and definitions.
Apr 7 2020, 2:46 AM
sobomax committed rS359685: Normalize deployment tools usage and definitions by putting into one place.
Normalize deployment tools usage and definitions by putting into one place
Apr 7 2020, 2:46 AM

Mar 26 2020

sobomax added a comment to D20520: Normalize deployment tools usage and definitions.

@imp any chance you can review and see if the change can land or indicate what other changes are necessary. Thanks!

Mar 26 2020, 8:30 PM

Feb 18 2020

sobomax added a comment to D20520: Normalize deployment tools usage and definitions.

@imp the requested changes have been applied. Please check. Thanks!

Feb 18 2020, 9:24 PM
sobomax updated the diff for D20520: Normalize deployment tools usage and definitions.

Collapse .if/.else/.endif into one liner.

Feb 18 2020, 9:22 PM

Oct 22 2019

sobomax reopened D22099: Merge from vendor: fix potential infinite loop in when executing -c command.

Might need ("partial?") MFC into stable/11 stable/12.

Oct 22 2019, 12:03 AM

Oct 21 2019

sobomax added a comment to D22099: Merge from vendor: fix potential infinite loop in when executing -c command.

I believe the correct way to handle this is to update the vendor tree and then merge. I'm happy to do that.

Is this only in the new version I imported on the 8th or do we need to MFC as well? If the latter, I suspect it makes sense to direct commit this patch to 12.1 rather than doing a full update this late in the release process.

Oct 21 2019, 11:58 PM
sobomax updated the test plan for D22099: Merge from vendor: fix potential infinite loop in when executing -c command.
Oct 21 2019, 4:27 PM
sobomax created D22099: Merge from vendor: fix potential infinite loop in when executing -c command.
Oct 21 2019, 4:23 PM

Jul 22 2019

sobomax committed rS350224: Allow "update" option to be used in the fstab(5). Document possible use case..
Allow "update" option to be used in the fstab(5). Document possible use case.
Jul 22 2019, 8:05 PM
sobomax closed D18586: mount(8) does not handle "update" option in the fstab(5) correctly.
Jul 22 2019, 8:05 PM

Jul 1 2019

sobomax added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

Document usage scenario bit further. Fix some mandoc formattings nits. Suggested by @mckusick

Jul 1 2019, 9:34 PM
sobomax added a comment to D20520: Normalize deployment tools usage and definitions.

I will keep it at reviews for 1 week and then it will land unless major objections are received. Thanks!

Jul 1 2019, 8:13 PM
sobomax added a comment to D20520: Normalize deployment tools usage and definitions.

Hey @imp can you please review the latest revision and confirm that it looks OK now?

Jul 1 2019, 8:11 PM

Jun 5 2019

sobomax added inline comments to D20520: Normalize deployment tools usage and definitions.
Jun 5 2019, 8:47 PM
sobomax updated the diff for D20520: Normalize deployment tools usage and definitions.

Rename MTREE -> DISTR_MTREE for clarity and in hope to make @rgrimes happier.

Jun 5 2019, 8:30 PM
sobomax added a comment to D20520: Normalize deployment tools usage and definitions.
In D20520#443376, @imp wrote:

bootools is a terrible name, so bad I'm ticking 'request changes'.

Jun 5 2019, 5:32 PM
sobomax added inline comments to D20520: Normalize deployment tools usage and definitions.
Jun 5 2019, 5:24 PM
sobomax updated the diff for D20520: Normalize deployment tools usage and definitions.

src.bootools.mk -> src.tools.mk as suggested by @imp

Jun 5 2019, 4:28 PM
sobomax updated the test plan for D20520: Normalize deployment tools usage and definitions.
Jun 5 2019, 5:32 AM
sobomax created D20520: Normalize deployment tools usage and definitions.
Jun 5 2019, 5:32 AM
sobomax accepted D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Looks good, as long as it compiles.

Jun 5 2019, 5:15 AM

Jun 3 2019

sobomax committed rS348589: Put back MTREE_CMD here for now. Doh, not my day, perhaps..
Put back MTREE_CMD here for now. Doh, not my day, perhaps.
Jun 3 2019, 9:40 PM
sobomax committed rS348540: Rollback the rest of the botched r348521. Re-work would be posted to.
Rollback the rest of the botched r348521. Re-work would be posted to
Jun 3 2019, 3:34 PM
sobomax committed rS348532: Leave mtree hardcoded for now. Reverting partially 348521 and also.
Leave mtree hardcoded for now. Reverting partially 348521 and also
Jun 3 2019, 3:12 PM

Jun 2 2019

sobomax committed rS348521: Fix several places where tool name has been hardcoded:.
Fix several places where tool name has been hardcoded:
Jun 2 2019, 11:38 PM

May 22 2019

sobomax committed rS348091: Make aacraid(4) working on ASR8805 & ASR8402 in particular. This patch.
Make aacraid(4) working on ASR8805 & ASR8402 in particular. This patch
May 22 2019, 4:51 AM
sobomax closed D18408: PR209468: aacraid fixes to work with newer controller firmware.
May 22 2019, 4:51 AM

Apr 10 2019

sobomax removed a reviewer for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib.: sobomax.
Apr 10 2019, 5:48 AM

Mar 28 2019

sobomax abandoned D19707: Prevent atime from being updated when TMPFS(5) is mounted read-only.
Mar 28 2019, 5:37 PM
sobomax accepted D19737: Handle ro remount of tmpfs rw mount..

Looks good to my VFS-naive eye. Thanks!

Mar 28 2019, 5:37 PM

Mar 27 2019

sobomax added a reviewer for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib.: sobomax.
Mar 27 2019, 9:42 PM
sobomax added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Overall looks like a good start, however there are some things that I personally dislike:

Mar 27 2019, 9:26 PM

Mar 26 2019

sobomax resigned from D6208: [geom] g_label_ufs may not find UFS1 header in case of usage GEOM_UZIP.

Not sure why this is still open. @mizhka_gmail.com please GC?

Mar 26 2019, 5:43 PM
sobomax added reviewers for D19707: Prevent atime from being updated when TMPFS(5) is mounted read-only: alc, mjg.
Mar 26 2019, 5:23 PM
sobomax added a comment to D19707: Prevent atime from being updated when TMPFS(5) is mounted read-only.
In D19707#422201, @kib wrote:

Your 'fix' is not enough even for mtime. Look at the tmpfs_sync(MNT_LAZY).

Mar 26 2019, 5:19 PM
sobomax updated the diff for D19707: Prevent atime from being updated when TMPFS(5) is mounted read-only.

Check read-only flag in an unified manner.

Mar 26 2019, 4:55 PM
sobomax created D19707: Prevent atime from being updated when TMPFS(5) is mounted read-only.
Mar 26 2019, 3:33 AM
sobomax committed rS345514: Refine r345425: get rid of superfluous helper macro that I have added..
Refine r345425: get rid of superfluous helper macro that I have added.
Mar 26 2019, 1:28 AM

Mar 22 2019

sobomax added inline comments to D19682: Make it possible to update TMPFS mount point from read-only to read-write and vice versa..
Mar 22 2019, 11:09 PM
sobomax added a comment to D19682: Make it possible to update TMPFS mount point from read-only to read-write and vice versa..
In D19682#421511, @kib wrote:

As I understand, currently ro tmpfs mounts are useless and the code is incomplete. I did very quick look and the first VOP I looked at, tmpfs_mkdir(), seems to allow modifications of the ro mounts (this is from code reading, not from testing). Was code review done to ensure that read-only tmpfs mounts indeed operate as intended ?

Mar 22 2019, 11:00 PM
sobomax committed rS345425: Make it possible to update TMPFS mount point from read-only to read-write.
Make it possible to update TMPFS mount point from read-only to read-write
Mar 22 2019, 9:31 PM
sobomax closed D19682: Make it possible to update TMPFS mount point from read-only to read-write and vice versa..
Mar 22 2019, 9:31 PM
sobomax created D19682: Make it possible to update TMPFS mount point from read-only to read-write and vice versa..
Mar 22 2019, 8:01 PM

Feb 25 2019

sobomax committed rS344555: Improve error handling: bail out if one of the files scheduled.
Improve error handling: bail out if one of the files scheduled
Feb 25 2019, 11:45 PM
sobomax closed D18584: makefs(8) improper error handling (or lack of thereof).
Feb 25 2019, 11:45 PM
sobomax added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

Given that this plausibly works only with two different /etc/fstab files, I think your change should also include an update to the manual page to explain how the update keyword is intended to be used.

Feb 25 2019, 11:27 PM
sobomax updated the diff for D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

Document "update" option, as suggested by @mckusick

Feb 25 2019, 11:27 PM
sobomax requested changes to D19266: Modularize xz..
In D19266#413225, @kib wrote:

Rebase; fix conflicts.
Formatting and comment changes.

Feb 25 2019, 8:52 PM

Feb 23 2019

sobomax closed D18546: dhclient(8) issues unneeded ioctl(SIOCSIFMTU) on every lease renew.
Feb 23 2019, 11:31 PM · network
sobomax committed rS344488: Further refine r336195: do not even attempt to verify/update interface's.
Further refine r336195: do not even attempt to verify/update interface's
Feb 23 2019, 11:31 PM
sobomax committed rS344479: o Get rid of silly comment which seems to have got life of its own via.
o Get rid of silly comment which seems to have got life of its own via
Feb 23 2019, 12:00 AM

Feb 22 2019

sobomax added inline comments to D19266: Modularize xz..
Feb 22 2019, 11:17 PM
sobomax added inline comments to D19266: Modularize xz..
Feb 22 2019, 11:12 PM
sobomax added inline comments to D19266: Modularize xz..
Feb 22 2019, 11:02 PM
sobomax added inline comments to D19266: Modularize xz..
Feb 22 2019, 10:55 PM
sobomax added a comment to D19266: Modularize xz..
In D19266#412957, @kib wrote:
In D19266#412909, @cem wrote:

geom_uzip(4) uses zlib module without the need to add dummy "device zlib" into kernel, why xz code should be any different?

zlib is built if geom_uzip is enabled in conf/files:

libkern/zlib.c                  optional crypto | geom_uzip | ipsec | \
        ipsec_support | mxge | netgraph_deflate | ddb_ctf | gzio

(Also, zlib has many other consumers. xz-embedded has limited general utility, due to being a decompress-only subset of lzma. So I am not sure xz will gain many more consumers. I agree adding 'device xz' to a million MIPS kernel configurations is an ugly repercussion of this choice.)

What you cited is clear example why I (and others) do not do this dependency tracking insanity in the conf/files syntax. Config(8) is only effective at flat dependencies where all required config options are explicitly provided in the kernel config file. Tracking dependencies like turn on B when A is on, but also consider side effects from C, D, E, architecture, and so on, is impossible with it.

I thought it is obvious that the only reason why I wrote this patch is because there are more planned consumers of xz in kernel, which alone is the reason why I want it to be a dedicated option, and why I want (need) to avoid the dependency drama.

Also see the recent discussion of iflib modularization.

That said, are there any other _technical_ notes about the diff ?

Feb 22 2019, 10:46 PM
sobomax requested changes to D19266: Modularize xz..
In D19266#412644, @kib wrote:

Remove 'device geom_uzip', add xz to notes.

Feb 22 2019, 2:59 AM

Feb 21 2019

sobomax added a comment to D19266: Modularize xz..

Also "device xz" needs to be added to the conf/NOTES.

Feb 21 2019, 2:01 AM
sobomax requested changes to D19266: Modularize xz..

Looks good overall. I am little bit puzzled over usage of "option GEOM_UZIP" vs. "device geom_uzip + device xz". I suspect those are functionally equivalent. Half of the kernel configs in the tree use former (including NOTES) and half the latter. Some subset of the two use both. :( Since you are touching those files anyways, perhaps you can go and convert all cases of "device geom_uzip" into plain "option GEOM_UZIP" and not patch it up by adding device xz? It might be also a good idea to adjust geom_uzip(4) accordingly to provide "One-True-Way" to compile geom_uzip(4) statically into the kernel? Thanks!

Feb 21 2019, 1:37 AM

Jan 17 2019

sobomax added a comment to D18382: Add new "trim" conversion for dd(1).

o Due to popular request rename "erase" into "trim".

You need now fix clist[] array in the args.c as it must be sorted or else bsearch() fails to find "trim" and dd conv=trim bails out with error "unknown conversion trim".

Jan 17 2019, 9:54 PM
sobomax updated the diff for D18382: Add new "trim" conversion for dd(1).

Keep clist[] array in the args.c sorted by the name so that bsearch() DTRT.

Jan 17 2019, 9:51 PM

Dec 19 2018

sobomax added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.
In D18586#396514, @kib wrote:

So what happen when somebody run 'mount -a' second time, with non-idempotent mount option + update ?

Dec 19 2018, 6:57 PM

Dec 18 2018

sobomax added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

This change does not seem wrong, though the only way I can see it being usable is to have the read-only mount's in /etc/fstab, then a special fstab that has the desired update mount lines in it.

Dec 18 2018, 3:37 PM

Dec 17 2018

sobomax updated the summary of D18586: mount(8) does not handle "update" option in the fstab(5) correctly.
Dec 17 2018, 10:49 PM
sobomax created D18586: mount(8) does not handle "update" option in the fstab(5) correctly.
Dec 17 2018, 5:14 PM
sobomax updated the summary of D18584: makefs(8) improper error handling (or lack of thereof).
Dec 17 2018, 4:45 PM
sobomax updated the test plan for D18584: makefs(8) improper error handling (or lack of thereof).
Dec 17 2018, 4:43 PM
sobomax added a reviewer for D18584: makefs(8) improper error handling (or lack of thereof): emaste.
Dec 17 2018, 4:43 PM
sobomax created D18584: makefs(8) improper error handling (or lack of thereof).
Dec 17 2018, 4:43 PM
sobomax closed D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.
Dec 17 2018, 4:00 PM · network
sobomax committed rS342168: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4).
Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4)
Dec 17 2018, 4:00 PM
sobomax committed rS342167: MFC r341257: improve speed of empty block detection..
MFC r341257: improve speed of empty block detection.
Dec 17 2018, 3:20 PM
sobomax committed rS342166: MFC r341257: improve speed of empty block detection..
MFC r341257: improve speed of empty block detection.
Dec 17 2018, 3:17 PM
sobomax committed rS342165: MFC r341253: panic() should not apply \n..
MFC r341253: panic() should not apply \n.
Dec 17 2018, 3:14 PM

Dec 14 2018

sobomax added a comment to D18546: dhclient(8) issues unneeded ioctl(SIOCSIFMTU) on every lease renew.
  1. At some point administrator logins and changes MTU from value X prescribed by the DHCP to some other value Y of his liking.

JFYI: the PR 229432 mentiones working way to ignore option 26 (MTU) supplied by DHCP server:

interface "em0" {

supersede interface-mtu 0;

}

Dec 14 2018, 8:39 PM · network