Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (553 w, 6 d)

Recent Activity

Tue, Sep 15

tuexen added a comment to D59708: tcp: Create fewer per-VNET zones.

I think the reason for per VNET zones might have been to protect against the case where a service running in one VNET cannot run the services running in other VNETs out of resources. However, that would require per VNET limits and would need to require that this isolation is done for all resources, which doesn't seem to be the case.

Right, that is one legitimate use for per-VNET zones. In the long term, UMA itself should perhaps provide this functionality, rather than forcing consumers to create separate zones.

Tue, Sep 15, 6:48 PM
tuexen accepted D59708: tcp: Create fewer per-VNET zones.

I think the reason for per VNET zones might have been to protect against the case where a service running in one VNET cannot run the services running in other VNETs out of resources. However, that would require per VNET limits and would need to require that this isolation is done for all resources, which doesn't seem to be the case.

Tue, Sep 15, 6:41 PM

Mon, Sep 14

tuexen committed rGc1fa70c6e9f6: vtnet: offer VIRTIO_NET_F_GUEST_CSUM (authored by timo.voelker_fh-muenster.de).
vtnet: offer VIRTIO_NET_F_GUEST_CSUM
Mon, Sep 14, 8:18 PM
tuexen closed D59052: vtnet: offer VIRTIO_NET_F_GUEST_CSUM independently of RXCSUM.
Mon, Sep 14, 8:17 PM
tuexen accepted D59052: vtnet: offer VIRTIO_NET_F_GUEST_CSUM independently of RXCSUM.
Mon, Sep 14, 8:09 PM

Fri, Sep 11

tuexen accepted D59590: sctp: remove unused variable.
Fri, Sep 11, 2:51 PM

Sun, Sep 6

tuexen closed D59384: tcp: remove redundant assignments.
Sun, Sep 6, 2:07 PM
tuexen committed rG6d3e3afbf96e: tcp: remove redundant assignments (authored by tuexen).
tcp: remove redundant assignments
Sun, Sep 6, 2:07 PM
tuexen accepted D59384: tcp: remove redundant assignments.
Sun, Sep 6, 1:09 PM

Sat, Sep 5

tuexen accepted D59450: loopback: set MTU to IF_MAXMTU.
Sat, Sep 5, 10:50 PM
tuexen added inline comments to D59454: tcp: provide tcp_rttupdated() and call it periodically.
Sat, Sep 5, 10:49 PM
tuexen added inline comments to D59451: tcp: collect and report more statistics on the TCP host cache.
Sat, Sep 5, 10:35 PM
tuexen added inline comments to D59450: loopback: set MTU to IF_MAXMTU.
Sat, Sep 5, 10:11 PM
tuexen added a comment to D59450: loopback: set MTU to IF_MAXMTU.

I like the idea of increasing the MTU. Is there a reason why you select 0xffff? This is the maximum size of an IPv4 packet, but an IPv6 packet can have a size of 0xffff + 40. Why not use that value? Would it make sense to use a multiple of 4?

I didn't measure, but speculatively I decided that it would be better to have it a multiple of PAGE_SIZE rather than multiple + tiny. In the second case a bulk transfer would allocate an extra page (or an mbuf, if optimized) that would be underutilized.

Sat, Sep 5, 10:03 PM
tuexen accepted D59453: tcp: use sparse initializer for host cache metrics.
Sat, Sep 5, 7:43 PM
tuexen added inline comments to D59453: tcp: use sparse initializer for host cache metrics.
Sat, Sep 5, 6:59 PM
tuexen accepted D59452: tcp: turn on TCP hostcache for socket buffer sizes.
Sat, Sep 5, 6:37 PM
tuexen added inline comments to D59453: tcp: use sparse initializer for host cache metrics.
Sat, Sep 5, 6:32 PM
tuexen accepted D59451: tcp: collect and report more statistics on the TCP host cache.
Sat, Sep 5, 6:26 PM
tuexen added a comment to D59450: loopback: set MTU to IF_MAXMTU.

I like the idea of increasing the MTU. Is there a reason why you select 0xffff? This is the maximum size of an IPv4 packet, but an IPv6 packet can have a size of 0xffff + 40. Why not use that value?

Sat, Sep 5, 6:24 PM

Fri, Sep 4

tuexen requested review of D59384: tcp: remove redundant assignments.
Fri, Sep 4, 9:31 AM
tuexen committed rG74d330943b57: tcp md5: improve consistency (authored by tuexen).
tcp md5: improve consistency
Fri, Sep 4, 7:41 AM
tuexen committed rG2fb53436cd05: tcp md5: fix accounting of ACK with bad signatures (authored by tuexen).
tcp md5: fix accounting of ACK with bad signatures
Fri, Sep 4, 7:29 AM
tuexen closed D59302: tcp md5: fix accounting of ACK with bad signatures.
Fri, Sep 4, 7:29 AM
tuexen committed rG5d3e31df7c4f: tcp md5: fix accounting for SYN segments with unexpected signature (authored by tuexen).
tcp md5: fix accounting for SYN segments with unexpected signature
Fri, Sep 4, 7:22 AM
tuexen closed D59303: tcp md5: fix accounting for SYN segments with unexpected signature.
Fri, Sep 4, 7:22 AM

Thu, Sep 3

tuexen accepted D59325: tcp: fix TCPS_CLOSED state underleak in syncache_socket().
Thu, Sep 3, 9:20 AM

Tue, Sep 1

tuexen added a comment to D59305: tcp cc: move the cc relevant part of cc_post_recovery() into cc modules..
In D59305#1360809, @cc wrote:

What about the RACK and BBR stack?

They don't seem to be impacted or relevant.

static void rack_post_recovery(struct tcpcb *tp, uint32_t th_ack);

static void bbr_post_recovery(struct tcpcb *tp);
Tue, Sep 1, 7:41 PM
tuexen added a comment to D59305: tcp cc: move the cc relevant part of cc_post_recovery() into cc modules..

What about the RACK and BBR stack?

Tue, Sep 1, 6:54 PM
tuexen accepted D59305: tcp cc: move the cc relevant part of cc_post_recovery() into cc modules..
Tue, Sep 1, 6:52 PM
tuexen added inline comments to D59305: tcp cc: move the cc relevant part of cc_post_recovery() into cc modules..
Tue, Sep 1, 2:16 PM
tuexen accepted D59284: tests/sys/netinet/tcp_socket: fix build with ATF 0.22+.
Tue, Sep 1, 1:32 PM
tuexen requested review of D59303: tcp md5: fix accounting for SYN segments with unexpected signature.
Tue, Sep 1, 10:37 AM
tuexen updated the summary of D59302: tcp md5: fix accounting of ACK with bad signatures.
Tue, Sep 1, 10:30 AM
tuexen requested review of D59302: tcp md5: fix accounting of ACK with bad signatures.
Tue, Sep 1, 10:23 AM

Mon, Aug 31

tuexen closed D59249: tcp md5: improve handling of tcps_sig_err_sigopt counter.

Committed in c6ae11c1b0d9.

Mon, Aug 31, 2:10 PM
tuexen committed rGc6ae11c1b0d9: tcp md5: improve handling of tcps_sig_err_sigopt counter (authored by tuexen).
tcp md5: improve handling of tcps_sig_err_sigopt counter
Mon, Aug 31, 1:17 PM
tuexen updated the test plan for D59249: tcp md5: improve handling of tcps_sig_err_sigopt counter.
Mon, Aug 31, 11:38 AM

Fri, Aug 28

tuexen requested review of D59249: tcp md5: improve handling of tcps_sig_err_sigopt counter.
Fri, Aug 28, 3:48 PM

Thu, Aug 27

tuexen committed rGbb50bb45f5f6: vtnet: move offload functions to virtio_net.h (authored by timo.voelker_fh-muenster.de).
vtnet: move offload functions to virtio_net.h
Thu, Aug 27, 12:45 PM
tuexen closed D57299: vtnet: move offload functions to virtio_net.h to share them.
Thu, Aug 27, 12:44 PM
tuexen accepted D57299: vtnet: move offload functions to virtio_net.h to share them.
Thu, Aug 27, 12:41 PM

Wed, Aug 26

tuexen committed rG209668726c2f: sockstat: provide more BBLog information (authored by tuexen).
sockstat: provide more BBLog information
Wed, Aug 26, 6:37 PM
tuexen closed D59131: sockstat: provide more BBLog information.
Wed, Aug 26, 6:37 PM

Mon, Aug 24

tuexen committed rG191dad334c64: tcp: minor cleanup (authored by tuexen).
tcp: minor cleanup
Mon, Aug 24, 7:07 PM
tuexen closed D59142: tcp: minor cleanup.
Mon, Aug 24, 7:07 PM
tuexen committed rG74019bc3ea91: tcp: cleanup whitespaces (authored by tuexen).
tcp: cleanup whitespaces
Mon, Aug 24, 7:55 AM
tuexen requested review of D59142: tcp: minor cleanup.
Mon, Aug 24, 7:47 AM

Sun, Aug 23

tuexen requested review of D59131: sockstat: provide more BBLog information.
Sun, Aug 23, 8:18 PM
tuexen committed rG732c8d2a1a0e: sockstat: improve consistency (authored by tuexen).
sockstat: improve consistency
Sun, Aug 23, 8:12 PM

Fri, Aug 21

tuexen added a reverting change for rG44cddaa99dee: vtnet: move offload functions to virtio_net.h to share them: rG8bea280f4325: Revert "vtnet: move offload functions to virtio_net.h to share them".
Fri, Aug 21, 8:18 PM
tuexen committed rG8bea280f4325: Revert "vtnet: move offload functions to virtio_net.h to share them" (authored by tuexen).
Revert "vtnet: move offload functions to virtio_net.h to share them"
Fri, Aug 21, 8:18 PM
tuexen added a reverting change for D57299: vtnet: move offload functions to virtio_net.h to share them: rG8bea280f4325: Revert "vtnet: move offload functions to virtio_net.h to share them".
Fri, Aug 21, 8:18 PM

Tue, Aug 18

tuexen committed rG44cddaa99dee: vtnet: move offload functions to virtio_net.h to share them (authored by timo.voelker_fh-muenster.de).
vtnet: move offload functions to virtio_net.h to share them
Tue, Aug 18, 12:55 PM
tuexen closed D57299: vtnet: move offload functions to virtio_net.h to share them.
Tue, Aug 18, 12:55 PM
tuexen accepted D57299: vtnet: move offload functions to virtio_net.h to share them.
Tue, Aug 18, 12:54 PM

Aug 16 2026

tuexen committed rGf343f036c780: epair: allow disabling receive checksum offloading (authored by timo.voelker_fh-muenster.de).
epair: allow disabling receive checksum offloading
Aug 16 2026, 6:40 PM
tuexen closed D58786: epair: allow disabling receive checksum offloading.
Aug 16 2026, 6:40 PM
tuexen accepted D58786: epair: allow disabling receive checksum offloading.
Aug 16 2026, 6:38 PM

Aug 14 2026

tuexen added a member for Src Committers: tuexen.
Aug 14 2026, 8:02 PM

Aug 10 2026

tuexen committed rG0053a4b9cca7: tcp: fix TF_BITS (authored by tuexen).
tcp: fix TF_BITS
Aug 10 2026, 7:18 PM

Aug 6 2026

tuexen added a reverting change for D57518: loopback: checksum offloading: rG1b8d19dea462: Revert "loopback: improve checksum offloading".
Aug 6 2026, 4:58 PM
tuexen added a reverting change for rGd6c4cea7740d: loopback: improve checksum offloading: rG1b8d19dea462: Revert "loopback: improve checksum offloading".
Aug 6 2026, 4:58 PM
tuexen committed rG1b8d19dea462: Revert "loopback: improve checksum offloading" (authored by tuexen).
Revert "loopback: improve checksum offloading"
Aug 6 2026, 4:58 PM
tuexen committed rG9ac39192d496: tcp: improve SEG.SEQ validation for RST segments (authored by tuexen).
tcp: improve SEG.SEQ validation for RST segments
Aug 6 2026, 9:09 AM
tuexen committed rGe8d1cee43741: tcp: improve handling of stopped timers (authored by tuexen).
tcp: improve handling of stopped timers
Aug 6 2026, 9:08 AM
tuexen committed rGcad0d5772516: tests: fix checksum computation (authored by tuexen).
tests: fix checksum computation
Aug 6 2026, 9:07 AM
tuexen committed rGa2d2f7a97074: loopback: use new names for checksum offloading flags (authored by timo.voelker_fh-muenster.de).
loopback: use new names for checksum offloading flags
Aug 6 2026, 9:06 AM
tuexen committed rGa5423ccd1c26: rack_bbr_common: don't use stale pointer after m_pullup() (authored by thebugfixers_pm.me).
rack_bbr_common: don't use stale pointer after m_pullup()
Aug 6 2026, 9:05 AM
tuexen committed rG265b3e15abf6: loopback: improve checksum offloading (authored by timo.voelker_fh-muenster.de).
loopback: improve checksum offloading
Aug 6 2026, 9:05 AM
tuexen committed rGf059fcf3d1d8: virtio_pci_modern: Remove endianness conversion for config space (authored by timo.voelker_fh-muenster.de).
virtio_pci_modern: Remove endianness conversion for config space
Aug 6 2026, 9:04 AM
tuexen added a reverting change for rGfb53b42e36a9: virtio-modern: fix PCI common read/write functions on big endian targets: rGf059fcf3d1d8: virtio_pci_modern: Remove endianness conversion for config space.
Aug 6 2026, 9:04 AM
tuexen added a reverting change for D28947: [POWERPC] Switch endian of common dev information: rGf059fcf3d1d8: virtio_pci_modern: Remove endianness conversion for config space.
Aug 6 2026, 9:03 AM · PowerPC
tuexen committed rG9f49131806eb: tcp: cleanup resource handling in SYN handling (authored by tuexen).
tcp: cleanup resource handling in SYN handling
Aug 6 2026, 9:03 AM
tuexen committed rG74f750004990: sctp: initialize inp to avoid uninitialized use (authored by bz).
sctp: initialize inp to avoid uninitialized use
Aug 6 2026, 8:37 AM
tuexen committed rG1c62c8bac5ae: tcp: improve SEG.SEQ validation for RST segments (authored by tuexen).
tcp: improve SEG.SEQ validation for RST segments
Aug 6 2026, 8:34 AM
tuexen committed rG85485a570d4f: tcp: improve handling of stopped timers (authored by tuexen).
tcp: improve handling of stopped timers
Aug 6 2026, 8:33 AM
tuexen committed rG0ef3c9162330: tests: fix checksum computation (authored by tuexen).
tests: fix checksum computation
Aug 6 2026, 8:30 AM
tuexen committed rG9a1511e23f79: loopback: use new names for checksum offloading flags (authored by timo.voelker_fh-muenster.de).
loopback: use new names for checksum offloading flags
Aug 6 2026, 8:25 AM
tuexen committed rG1cd388ddf0d3: rack_bbr_common: don't use stale pointer after m_pullup() (authored by thebugfixers_pm.me).
rack_bbr_common: don't use stale pointer after m_pullup()
Aug 6 2026, 8:24 AM
tuexen committed rGfd3582e683d6: loopback: improve checksum offloading (authored by timo.voelker_fh-muenster.de).
loopback: improve checksum offloading
Aug 6 2026, 8:23 AM
tuexen committed rGb1afe190d766: virtio_pci_modern: Remove endianness conversion for config space (authored by timo.voelker_fh-muenster.de).
virtio_pci_modern: Remove endianness conversion for config space
Aug 6 2026, 7:11 AM
tuexen added a reverting change for rGfb53b42e36a9: virtio-modern: fix PCI common read/write functions on big endian targets: rGb1afe190d766: virtio_pci_modern: Remove endianness conversion for config space.
Aug 6 2026, 7:11 AM
tuexen added a reverting change for D28947: [POWERPC] Switch endian of common dev information: rGb1afe190d766: virtio_pci_modern: Remove endianness conversion for config space.
Aug 6 2026, 7:11 AM · PowerPC
tuexen committed rG7d9ab6ff71ec: tcp: cleanup resource handling in SYN handling (authored by tuexen).
tcp: cleanup resource handling in SYN handling
Aug 6 2026, 7:09 AM

Aug 3 2026

tuexen committed rGc9df1a6cf9be: tcp: improve SEG.SEQ validation for RST segments (authored by tuexen).
tcp: improve SEG.SEQ validation for RST segments
Aug 3 2026, 11:17 AM
tuexen closed D58594: tcp: improve SEG.SEQ validation for RST segments.
Aug 3 2026, 11:16 AM
tuexen added a comment to D58594: tcp: improve SEG.SEQ validation for RST segments.

Looks like you do modify the BBR/RACK stack too, unlike the high level description. In both places the same checks used to be done in a mirror image - and this again mirrors each other.

Aug 3 2026, 9:38 AM
tuexen updated the summary of D58594: tcp: improve SEG.SEQ validation for RST segments.
Aug 3 2026, 9:22 AM
tuexen requested review of D58594: tcp: improve SEG.SEQ validation for RST segments.
Aug 3 2026, 7:23 AM

Jul 28 2026

tuexen committed rG52b7cbcb78c1: tcp: improve handling of stopped timers (authored by tuexen).
tcp: improve handling of stopped timers
Jul 28 2026, 8:24 PM
tuexen closed D58484: tcp: improve handling of stopped timers.
Jul 28 2026, 8:24 PM

Jul 27 2026

tuexen retitled D58484: tcp: improve handling of stopped timers from tcp: improve stopping of timers to tcp: improve handling of stopped timers.
Jul 27 2026, 11:06 PM
tuexen updated the diff for D58484: tcp: improve handling of stopped timers.

As suggested by glebius.

Jul 27 2026, 11:04 PM
tuexen added inline comments to D58484: tcp: improve handling of stopped timers.
Jul 27 2026, 10:27 PM
tuexen requested review of D58484: tcp: improve handling of stopped timers.
Jul 27 2026, 6:48 PM

Jul 23 2026

tuexen closed D58411: tcp: make ghost ACK conformant.
Jul 23 2026, 4:08 PM
tuexen committed rGfa2ad70a4511: tcp: make ghost ACK handling more conformant (authored by tuexen).
tcp: make ghost ACK handling more conformant
Jul 23 2026, 4:08 PM
tuexen requested review of D58411: tcp: make ghost ACK conformant.
Jul 23 2026, 1:29 PM

Jul 21 2026

tuexen accepted D58360: tcp_hostcache: explicitly typecast atomic_load_int to (int) on comparsion against negative values.
Jul 21 2026, 2:00 PM