Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (167 w, 1 d)

Recent Activity

Yesterday

tuexen abandoned D19965: Fix various IPV6_CHECKSUM issues.
Fri, Apr 19, 6:11 PM
tuexen added a comment to D19965: Fix various IPV6_CHECKSUM issues.

All for reviews have been committed. Thanks a lot for the very quick reviews!

Fri, Apr 19, 6:10 PM
tuexen closed D19969: Don't send ICMPv6 packets when the checksum is wrong.
Fri, Apr 19, 6:09 PM
tuexen committed rS346406: When an IPv6 packet is received for a raw socket which has the.
When an IPv6 packet is received for a raw socket which has the
Fri, Apr 19, 6:09 PM
tuexen added inline comments to D19969: Don't send ICMPv6 packets when the checksum is wrong.
Fri, Apr 19, 5:40 PM
tuexen updated the diff for D19969: Don't send ICMPv6 packets when the checksum is wrong.

Integrate change suggested by bz@.

Fri, Apr 19, 5:40 PM
tuexen committed rS346402: When a checksum has to be computed for a received IPv6 packet because it.
When a checksum has to be computed for a received IPv6 packet because it
Fri, Apr 19, 5:28 PM
tuexen closed D19968: Improve checksum computation via IPV6_CHECKSUM for received packets.
Fri, Apr 19, 5:28 PM
tuexen added a comment to D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.
In D19967#429234, @bz wrote:

Can you please improve the description before committing stating that it's related to rip6_output().

Fri, Apr 19, 5:22 PM
tuexen committed rS346401: Avoid a buffer overwrite in rip6_output() when computing the checksum.
Avoid a buffer overwrite in rip6_output() when computing the checksum
Fri, Apr 19, 5:21 PM
tuexen closed D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.
Fri, Apr 19, 5:21 PM
tuexen closed D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.
Fri, Apr 19, 5:18 PM
tuexen committed rS346400: Improve input validation for the socket option IPV6_CHECKSUM..
Improve input validation for the socket option IPV6_CHECKSUM.
Fri, Apr 19, 5:18 PM
tuexen added a comment to D19965: Fix various IPV6_CHECKSUM issues.
In D19965#429179, @bz wrote:

Split up in four reviews or committing them separately once approved?

For review already if possible. Means I need less brain cycles now to divide the four apart as well.

Fri, Apr 19, 4:49 PM
tuexen created D19969: Don't send ICMPv6 packets when the checksum is wrong.
Fri, Apr 19, 4:46 PM
tuexen created D19968: Improve checksum computation via IPV6_CHECKSUM for received packets.
Fri, Apr 19, 4:42 PM
tuexen created D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.
Fri, Apr 19, 4:36 PM
tuexen created D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.
Fri, Apr 19, 4:31 PM
tuexen added inline comments to D19965: Fix various IPV6_CHECKSUM issues.
Fri, Apr 19, 4:11 PM
tuexen updated the diff for D19965: Fix various IPV6_CHECKSUM issues.

Address Ed's comment

Fri, Apr 19, 4:11 PM
tuexen added a comment to D19965: Fix various IPV6_CHECKSUM issues.
In D19965#429164, @bz wrote:

This seems like four different issues and it's kind of hard to keep them apart in a single change. For the sake of having a readable history and easily seeing/understanding each problem, can you please split them up?

Fri, Apr 19, 4:05 PM
tuexen created D19965: Fix various IPV6_CHECKSUM issues.
Fri, Apr 19, 3:42 PM

Thu, Apr 18

tuexen added a comment to D19960: Remove support for RFC2675.
In D19960#429029, @jtl wrote:

I agree with @bz about ideal process. I also agree with @kristof about the practical implications of this feature. :-)
Might a valid way forward be to write a draft, propose it, and see if anyone complains by the next IETF (July) before purging this?

Thu, Apr 18, 8:21 PM

Sun, Apr 14

tuexen closed D19898: Don't allow the user to set RTF_RNH_LOCKED.
Sun, Apr 14, 10:19 AM
tuexen committed rS346197: When sending a routing message, don't allow the user to set the.
When sending a routing message, don't allow the user to set the
Sun, Apr 14, 10:18 AM

Sat, Apr 13

tuexen updated the test plan for D19898: Don't allow the user to set RTF_RNH_LOCKED.
Sat, Apr 13, 2:06 PM
tuexen created D19898: Don't allow the user to set RTF_RNH_LOCKED.
Sat, Apr 13, 2:06 PM
tuexen committed rS346182: When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option,.
When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option,
Sat, Apr 13, 10:48 AM
tuexen closed D19181: Improve input validation when when using IP_HDRINCL socket option on SOCK_RAW sockets.
Sat, Apr 13, 10:48 AM

Thu, Apr 11

tuexen committed rS346134: Fix an SCTP related locking issue. Don't report that the TCB_SEND_LOCK.
Fix an SCTP related locking issue. Don't report that the TCB_SEND_LOCK
Thu, Apr 11, 8:39 PM

Tue, Mar 26

tuexen committed rS345525: Fix a double free of an SCTP association in an error path..
Fix a double free of an SCTP association in an error path.
Tue, Mar 26, 8:27 AM

Mon, Mar 25

tuexen committed rS345505: Initialize scheduler specific data for the FCFS scheduler..
Initialize scheduler specific data for the FCFS scheduler.
Mon, Mar 25, 4:41 PM
tuexen committed rS345504: Improve locking when tearing down an SCTP association..
Improve locking when tearing down an SCTP association.
Mon, Mar 25, 3:23 PM
tuexen committed rS345494: Fix the handling of fragmented unordered messages when using DATA chunks.
Fix the handling of fragmented unordered messages when using DATA chunks
Mon, Mar 25, 9:47 AM

Sun, Mar 24

tuexen committed rS345467: Fix build issue for the userland stack..
Fix build issue for the userland stack.
Sun, Mar 24, 12:13 PM
tuexen committed rS345466: Fox more signed unsigned issues. This time on the send path..
Fox more signed unsigned issues. This time on the send path.
Sun, Mar 24, 10:40 AM
tuexen committed rS345465: Fix a signed/unsigned bug when receiving SCTP messages..
Fix a signed/unsigned bug when receiving SCTP messages.
Sun, Mar 24, 9:46 AM

Sat, Mar 23

tuexen committed rS345461: Limit the size of messages sent on 1-to-many style SCTP sockets with the.
Limit the size of messages sent on 1-to-many style SCTP sockets with the
Sat, Mar 23, 10:56 PM
tuexen committed rS345460: Limit the number of bytes which can be queued for SCTP sockets..
Limit the number of bytes which can be queued for SCTP sockets.
Sat, Mar 23, 10:46 PM
tuexen closed D19355: Make RTO.Initial for TCP controllable via sysctl.
Sat, Mar 23, 9:37 PM
tuexen committed rS345458: Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial.
Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial
Sat, Mar 23, 9:37 PM
tuexen closed D19687: Fix KASSERT in tcp_output().

Committed in r345441.

Sat, Mar 23, 9:20 PM
tuexen committed rS345441: Fix a KASSERT() in tcp_output()..
Fix a KASSERT() in tcp_output().
Sat, Mar 23, 9:56 AM
tuexen created D19687: Fix KASSERT in tcp_output().
Sat, Mar 23, 6:55 AM

Mar 8 2019

tuexen committed rS344925: Fix locking bug..
Fix locking bug.
Mar 8 2019, 6:18 PM
tuexen committed rS344924: Some cleanup and consistency improvements..
Some cleanup and consistency improvements.
Mar 8 2019, 6:16 PM

Mar 7 2019

tuexen committed rS344872: After removing an entry from the stream scheduler list, set the pointers.
After removing an entry from the stream scheduler list, set the pointers
Mar 7 2019, 8:43 AM

Mar 3 2019

tuexen committed rS344742: Allocate an assocition id and register the stcb with holding the lock..
Allocate an assocition id and register the stcb with holding the lock.
Mar 3 2019, 7:55 PM

Mar 2 2019

tuexen committed rS344726: Remove debug output..
Remove debug output.
Mar 2 2019, 4:10 PM
tuexen committed rS344724: Allow SCTP stream reconfiguration operations only in ESTABLISHED.
Allow SCTP stream reconfiguration operations only in ESTABLISHED
Mar 2 2019, 2:30 PM
tuexen committed rS344723: Handle the case when calling the IPPROTO_SCTP level socket option.
Handle the case when calling the IPPROTO_SCTP level socket option
Mar 2 2019, 2:15 PM
tuexen committed rS344722: Use correct buffer sizes in sctp_get[lp]addrs()..
Use correct buffer sizes in sctp_get[lp]addrs().
Mar 2 2019, 1:16 PM
tuexen committed rS344721: Report the correct length when using the IPPROTO_SCTP level.
Report the correct length when using the IPPROTO_SCTP level
Mar 2 2019, 1:12 PM

Mar 1 2019

tuexen committed rS344708: Honor the memory limits provided when processing the IPPROTO_SCTP.
Honor the memory limits provided when processing the IPPROTO_SCTP
Mar 1 2019, 6:47 PM
tuexen committed rS344704: Improve consistency, not functional change..
Improve consistency, not functional change.
Mar 1 2019, 3:58 PM

Feb 27 2019

tuexen added a comment to D19371: net/packetdrill: update to 2019/02/26 head.

Looks good to me.

Feb 27 2019, 9:20 AM
tuexen added a comment to D19355: Make RTO.Initial for TCP controllable via sysctl.

The unit would be milli seconds, not seconds for the sysctl-variable. In general, I agree that it would be good to give at least the unit for sysctl variables, but

Feb 27 2019, 9:18 AM
tuexen added inline comments to D19371: net/packetdrill: update to 2019/02/26 head.
Feb 27 2019, 7:42 AM

Feb 25 2019

tuexen created D19355: Make RTO.Initial for TCP controllable via sysctl.
Feb 25 2019, 9:22 PM
tuexen committed rS344516: MFC r344428:.
MFC r344428:
Feb 25 2019, 12:36 PM
tuexen committed rS344515: MFC r343439:.
MFC r343439:
Feb 25 2019, 12:33 PM
tuexen committed rS344514: MFC r343920:.
MFC r343920:
Feb 25 2019, 12:25 PM
tuexen committed rS344512: MFC r343920:.
MFC r343920:
Feb 25 2019, 10:51 AM
tuexen added a comment to D18960: Patch to MFC TCP reassembly rewrite to stable/11.

Quick comment: DSACKs are not working in HEAD. Potentially, the tlenp is set to zero for the duplicate segment, so that tcp_update_sack_list is not called to build the DSACK entry to the next ACK. If this is the reason, this patch may break DSACK in BSD11

This is not to be a shipstopper, but a heads-up as the DSACK not working may be related hereto...

Feb 25 2019, 10:46 AM
tuexen closed D18960: Patch to MFC TCP reassembly rewrite to stable/11.
Feb 25 2019, 10:38 AM
tuexen committed rS344511: Backport the new TCP reassembly code from head to stable/11..
Backport the new TCP reassembly code from head to stable/11.
Feb 25 2019, 10:38 AM

Feb 23 2019

tuexen added a comment to D18960: Patch to MFC TCP reassembly rewrite to stable/11.

Quick comment: DSACKs are not working in HEAD. Potentially, the tlenp is set to zero for the duplicate segment, so that tcp_update_sack_list is not called to build the DSACK entry to the next ACK. If this is the reason, this patch may break DSACK in BSD11

This is not to be a shipstopper, but a heads-up as the DSACK not working may be related hereto...

Can you open a PR for this against head? Is it also broken in stable/12?

Feb 23 2019, 10:23 AM

Feb 21 2019

tuexen accepted D19287: Check the index hasn't changed after writing the cmp entry.
Feb 21 2019, 10:02 PM
tuexen added inline comments to D19181: Improve input validation when when using IP_HDRINCL socket option on SOCK_RAW sockets.
Feb 21 2019, 7:20 PM
tuexen updated the diff for D19181: Improve input validation when when using IP_HDRINCL socket option on SOCK_RAW sockets.

Integrate jtl@'s suggestion.

Feb 21 2019, 7:19 PM
tuexen committed rS344433: The receive buffer autoscaling for TCP is based on a linear growth, which.
The receive buffer autoscaling for TCP is based on a linear growth, which
Feb 21 2019, 10:35 AM
tuexen closed D18375: Improve receive window autoscaling for TCP.
Feb 21 2019, 10:35 AM
tuexen updated the diff for D18960: Patch to MFC TCP reassembly rewrite to stable/11.

Merge r344428.

Feb 21 2019, 10:17 AM
tuexen committed rS344428: This patch addresses an issue brought up by bz@ in D18968:.
This patch addresses an issue brought up by bz@ in D18968:
Feb 21 2019, 9:35 AM
tuexen closed D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Feb 21 2019, 9:35 AM

Feb 20 2019

tuexen added a comment to D19252: Unwire pages when cleaning up the kcov state.

Latest version tested again with running kcovtrace /usr/bin/uptime in a loop and in addition with running syzkaller. Both work fine.

Feb 20 2019, 7:29 PM
tuexen added inline comments to D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Feb 20 2019, 7:26 PM
tuexen updated the diff for D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.

Address bz@'s comment.

Feb 20 2019, 7:23 PM
tuexen retitled D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled from Avoid dereferencing a NULL point when TCP_REASS_LOGGING is enabled to Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Feb 20 2019, 6:05 PM
tuexen closed D18941: RTO.Initial = 1 second for TCP.
Feb 20 2019, 6:04 PM
tuexen committed rS344368: Reduce the TCP initial retransmission timeout from 3 seconds to.
Reduce the TCP initial retransmission timeout from 3 seconds to
Feb 20 2019, 6:04 PM
tuexen committed rS344367: Use exponential backoff for retransmitting SYN segments as specified.
Use exponential backoff for retransmitting SYN segments as specified
Feb 20 2019, 5:57 PM
tuexen closed D18974: Use exponential backoff also for SYN segments.
Feb 20 2019, 5:57 PM
tuexen added a comment to D19252: Unwire pages when cleaning up the kcov state.

Using this version, the memory lockup observed does not occur anymore. Tested with running kcovtrace /usr/bin/uptime in a loop.

Feb 20 2019, 10:47 AM

Feb 19 2019

tuexen created D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Feb 19 2019, 10:14 PM
tuexen added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 19 2019, 9:26 PM

Feb 17 2019

tuexen requested changes to D19000: Avoid cwnd update for SYN sequence space.

Hi Richard,

Feb 17 2019, 11:05 AM

Feb 15 2019

tuexen committed rS344148: Fix a byte ordering issue for the advertised receiver window in ACK.
Fix a byte ordering issue for the advertised receiver window in ACK
Feb 15 2019, 9:45 AM

Feb 13 2019

tuexen created D19181: Improve input validation when when using IP_HDRINCL socket option on SOCK_RAW sockets.
Feb 13 2019, 8:00 PM

Feb 12 2019

tuexen committed rS344048: Improve input validation for raw IPv4 socket using the IP_HDRINCL.
Improve input validation for raw IPv4 socket using the IP_HDRINCL
Feb 12 2019, 10:17 AM
tuexen closed D18834: Check IPv4 options when using IP_HDRINCL socket option on SOCK_RAW sockets.
Feb 12 2019, 10:17 AM

Feb 11 2019

tuexen committed rS344012: Fix flags used when compiling kern_kcov.c and subr_coverage.c..
Fix flags used when compiling kern_kcov.c and subr_coverage.c.
Feb 11 2019, 3:38 PM
tuexen closed D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 3:38 PM
tuexen added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 2:28 PM
tuexen updated the diff for D19135: Fix compiler flags related to kernel coverage.

Follow Andrew's advice.

Feb 11 2019, 2:27 PM
tuexen added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 1:40 PM

Feb 10 2019

tuexen added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 10 2019, 4:29 PM
tuexen updated the diff for D19135: Fix compiler flags related to kernel coverage.

Use underscores instead of hyphens as suggested by Ed.

Feb 10 2019, 4:27 PM
tuexen added a comment to D19135: Fix compiler flags related to kernel coverage.

I tested this patch on a kernel build with clang in base and with the amd64-xtoolchain-gcc cross toolchain.

Feb 10 2019, 2:23 PM
tuexen committed rS343961: Fix a locking issue when reporing outbount messages..
Fix a locking issue when reporing outbount messages.
Feb 10 2019, 2:02 PM