Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (200 w, 1 d)

Recent Activity

Yesterday

tuexen added a comment to D22704: Remove superfluous trailing whitespaces in TCP source files.

Why would cleaning up trailing whitespaces make MFCing harder? Other than possibly adding one adjacent line?

If you don't MFC the whitespace cleanup, you might get merge conflicts...

I made this huge diff, because sneaking these in one-by-one whenever I encounter them around the lines I was modifying was shot down so far ;)

As I said, doing this once is a nice thing in my opinion...

BTW - since lint was removed, what other tool could I use to validate the fbsd code style(9)? Any hint as to how i could integrate that into git or arcanist would be appreciated.

I"m not doing this automated... I just try to follow it (as much as I think is a good thing) when coding... But this is not perfect and others are also not perfect.

Fri, Dec 6, 1:08 PM
tuexen added a comment to D22704: Remove superfluous trailing whitespaces in TCP source files.

When I did similar things in the past, one comment I received was that this does not improve the functionality, but
might make MFCing harder... However, only dealing with this in a single commit is definitely a good idea in my view.
The question is whether to do it at all. Maybe rrs@ or rgrimes@ have an opinion on this.

Fri, Dec 6, 10:55 AM

Sun, Dec 1

tuexen added a comment to D15818: Add a delayed VT attachment for ofwfb.

@jhibbits Thanks for the explanation. I'm using it on a blackbird. I have also a G5 Powermac in my lab, so if there is a need for testing, just let me know. I would like to run an unmodified version of FreeBSD just to make sure I don't commit anything by accident...

Sun, Dec 1, 10:10 PM
tuexen added 1 blocking reviewer(s) for D22438: Improve NewReno after_idle ssthresh per RFC2861 Sec.2: transport.
Sun, Dec 1, 9:08 PM
tuexen added a reviewer for D22438: Improve NewReno after_idle ssthresh per RFC2861 Sec.2: transport.
Sun, Dec 1, 9:07 PM
tuexen requested changes to D22438: Improve NewReno after_idle ssthresh per RFC2861 Sec.2.
Sun, Dec 1, 9:06 PM
tuexen closed D22497: Moving all ECN related flags to flags2.
Sun, Dec 1, 9:01 PM
tuexen committed rS355273: Move all ECN related flags from the flags to the flags2 field..
Move all ECN related flags from the flags to the flags2 field.
Sun, Dec 1, 9:01 PM
tuexen accepted D22497: Moving all ECN related flags to flags2.
Sun, Dec 1, 8:51 PM
tuexen committed rS355272: Make the TF_* flags easier readable by humans by adding leading zeroes.
Make the TF_* flags easier readable by humans by adding leading zeroes
Sun, Dec 1, 8:46 PM
tuexen closed D22428: Editorial change to enhance readability of the TF_* bit constants.
Sun, Dec 1, 8:46 PM
tuexen accepted D22428: Editorial change to enhance readability of the TF_* bit constants.
Sun, Dec 1, 8:36 PM
tuexen closed D21798: Restrict cwnd growth on app-limited flows.
Sun, Dec 1, 8:36 PM
tuexen committed rS355269: This is an initial step in implementing the new congestion window.
This is an initial step in implementing the new congestion window
Sun, Dec 1, 8:36 PM
tuexen accepted D21798: Restrict cwnd growth on app-limited flows.
Sun, Dec 1, 7:22 PM
tuexen committed rS355268: Add a description for the TCP sysctl variable rfc6675_pipe..
Add a description for the TCP sysctl variable rfc6675_pipe.
Sun, Dec 1, 7:20 PM
tuexen closed D22426: Add access to TOS(ECN bits) byte in TCP RACK.
Sun, Dec 1, 6:48 PM
tuexen committed rS355267: Make the IPTOS value available to all substate handlers. This will allow.
Make the IPTOS value available to all substate handlers. This will allow
Sun, Dec 1, 6:48 PM
tuexen accepted D22426: Add access to TOS(ECN bits) byte in TCP RACK.

Don't we need a similar change to BBR?

Sun, Dec 1, 6:47 PM
tuexen committed rS355266: In order for the TCP Handshake to support ECN++, and further ECN-related.
In order for the TCP Handshake to support ECN++, and further ECN-related
Sun, Dec 1, 6:05 PM
tuexen closed D22436: Add access to TOS(ECN bits) to the TCP syncache.
Sun, Dec 1, 6:05 PM
tuexen accepted D22436: Add access to TOS(ECN bits) to the TCP syncache.
Sun, Dec 1, 6:02 PM
tuexen closed D22547: schedule new RTT measurement after MTU update.
Sun, Dec 1, 5:36 PM
tuexen committed rS355265: When changing the MTU of an SCTP path, not only cancel all ongoing.
When changing the MTU of an SCTP path, not only cancel all ongoing
Sun, Dec 1, 5:35 PM
tuexen accepted D22547: schedule new RTT measurement after MTU update.
Sun, Dec 1, 5:31 PM
tuexen closed D22605: SCTP over v6: Update host cache after MTU change.
Sun, Dec 1, 4:15 PM
tuexen committed rS355264: Update the hostcache also for PTB messages received for SCTP/IPv6..
Update the hostcache also for PTB messages received for SCTP/IPv6.
Sun, Dec 1, 4:15 PM
tuexen accepted D22605: SCTP over v6: Update host cache after MTU change.
Sun, Dec 1, 4:11 PM

Fri, Nov 29

tuexen added a comment to D15818: Add a delayed VT attachment for ofwfb.

What is needed to get this in tree? Testing on Apple hardware was mentioned. What should be tested?

Fri, Nov 29, 10:27 PM

Thu, Nov 28

tuexen committed rS355172: Really ignore the SCTP association identifier on 1-to-1 style sockets.
Really ignore the SCTP association identifier on 1-to-1 style sockets
Thu, Nov 28, 12:50 PM

Wed, Nov 27

tuexen added inline comments to D22547: schedule new RTT measurement after MTU update.
Wed, Nov 27, 8:36 PM
tuexen requested changes to D22547: schedule new RTT measurement after MTU update.
Wed, Nov 27, 8:34 PM
tuexen accepted D22547: schedule new RTT measurement after MTU update.
Wed, Nov 27, 8:29 PM
tuexen committed rS355135: Plug two mbuf leaks during INIT-ACK handling..
Plug two mbuf leaks during INIT-ACK handling.
Wed, Nov 27, 7:32 PM

Mon, Nov 18

tuexen retitled D21997: Allow SCTP to be build as a module from to Allow SCTP to be build as a module.
Mon, Nov 18, 7:53 AM

Sat, Nov 16

tuexen committed rS354774: Add boundary and overflow checks to the formulas used in the TCP CUBIC.
Add boundary and overflow checks to the formulas used in the TCP CUBIC
Sat, Nov 16, 12:00 PM
tuexen closed D19118: Add Boundary and Overflow checks in Cubic formulas.
Sat, Nov 16, 12:00 PM
tuexen committed rS354773: Improve TCP CUBIC specific after idle reaction..
Improve TCP CUBIC specific after idle reaction.
Sat, Nov 16, 11:57 AM
tuexen closed D18954: Implement Cubic-specific After-Idle reaction.
Sat, Nov 16, 11:37 AM
tuexen committed rS354772: Implement a tCP CUBIC-specific after idle reaction..
Implement a tCP CUBIC-specific after idle reaction.
Sat, Nov 16, 11:37 AM
tuexen committed rS354771: Revert https://svnweb.freebsd.org/changeset/base/354708.
Revert https://svnweb.freebsd.org/changeset/base/354708
Sat, Nov 16, 11:10 AM

Thu, Nov 14

tuexen committed rS354708: For idle TCP sessions using the CUBIC congestio control, reset ssthresh.
For idle TCP sessions using the CUBIC congestio control, reset ssthresh
Thu, Nov 14, 4:28 PM

Thu, Nov 7

tuexen added a comment to D4810: Properly save the original MSS during blackhole detection.

I didn't know that this review existed when committing r322967, which contains the fix suggested here.

Thu, Nov 7, 3:25 PM

Oct 25 2019

tuexen committed rS354091: MFS r354090:.
MFS r354090:
Oct 25 2019, 6:47 PM
tuexen committed rS354090: MFC r354044:.
MFC r354044:
Oct 25 2019, 6:18 PM

Oct 24 2019

tuexen committed rS354044: Ensure that the flags indicating IPv4/IPv6 are not changed by failing.
Ensure that the flags indicating IPv4/IPv6 are not changed by failing
Oct 24 2019, 8:05 PM
tuexen updated the diff for D21997: Allow SCTP to be build as a module.

Create a file sctp_module.c which handles all modules specific things which are FreeBSD specific. Also add sctp to the global list of modules.

Oct 24 2019, 10:44 AM
tuexen commandeered D21997: Allow SCTP to be build as a module.
Oct 24 2019, 10:41 AM
tuexen committed rS354018: Store a handle for the event handler. This will be used when unloading the.
Store a handle for the event handler. This will be used when unloading the
Oct 24 2019, 9:22 AM

Oct 19 2019

tuexen retitled D22089: Fix compilation of kernel without VNET support from Fix compilation of kernel with VNET support to Fix compilation of kernel without VNET support.
Oct 19 2019, 8:53 PM
tuexen committed rS353770: Fix compile issues when building a kernel without the VIMAGE option..
Fix compile issues when building a kernel without the VIMAGE option.
Oct 19 2019, 8:49 PM
tuexen closed D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 8:49 PM
tuexen added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 8:14 PM
tuexen updated the diff for D22089: Fix compilation of kernel without VNET support.

A version which works on VIMAGE and !VIAMGE kernels.

Oct 19 2019, 8:13 PM
tuexen added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 8:03 PM
tuexen updated the diff for D22089: Fix compilation of kernel without VNET support.

Integrate result of discussion.

Oct 19 2019, 7:57 PM
tuexen added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 7:29 PM
tuexen added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 7:04 PM
tuexen created D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 4:21 PM

Oct 15 2019

tuexen committed rS353570: MFS r353563:.
MFS r353563:
Oct 15 2019, 4:06 PM
tuexen committed rS353567: Fix mergeinfo for r353563..
Fix mergeinfo for r353563.
Oct 15 2019, 3:47 PM
tuexen added a comment to D21997: Allow SCTP to be build as a module.

I think the changes to in_kdtrace.c and sctp_kdtrace.c are not needed anymore, since they are in head.

Oct 15 2019, 3:30 PM
tuexen committed rS353563: MFC r353452:.
MFC r353452:
Oct 15 2019, 2:48 PM

Oct 14 2019

tuexen committed rS353518: Separate out SCTP related dtrace code..
Separate out SCTP related dtrace code.
Oct 14 2019, 8:32 PM
tuexen committed rS353488: Rename sctp_dtrace_declare.h to sctp_kdtrace.h for consistentcy..
Rename sctp_dtrace_declare.h to sctp_kdtrace.h for consistentcy.
Oct 14 2019, 1:03 PM

Oct 13 2019

tuexen committed rS353482: Add missing include which breaks builds without VIMAGE..
Add missing include which breaks builds without VIMAGE.
Oct 13 2019, 7:59 PM
tuexen committed rS353480: Use an event handler to notify the SCTP about IP address changes.
Use an event handler to notify the SCTP about IP address changes
Oct 13 2019, 6:17 PM
tuexen added a comment to D21997: Allow SCTP to be build as a module.

I'll focus on the eventhandler changes...

Oct 13 2019, 9:41 AM
tuexen added inline comments to D21997: Allow SCTP to be build as a module.
Oct 13 2019, 9:40 AM
tuexen committed rS353466: Remove line not needed..
Remove line not needed.
Oct 13 2019, 9:35 AM

Oct 12 2019

tuexen added inline comments to D21997: Allow SCTP to be build as a module.
Oct 12 2019, 9:09 PM
tuexen added a reviewer for D21997: Allow SCTP to be build as a module: rrs.
Oct 12 2019, 9:04 PM
tuexen added a comment to D21997: Allow SCTP to be build as a module.

I would suggest to get

  • the generic fixes from above in head first
  • then get the eventhandler stuff or the dtrace changes in as separate commits.

That reduces the patch set and really focusses on the changes related to allowing SCTP to be a module.

Oct 12 2019, 9:04 PM
tuexen committed rS353452: Ensure that local variables are reset to their initial value when.
Ensure that local variables are reset to their initial value when
Oct 12 2019, 5:57 PM

Oct 10 2019

tuexen committed rS353412: MFS r353402:.
MFS r353402:
Oct 10 2019, 6:39 PM
tuexen committed rS353410: MFS r353395:.
MFS r353395:
Oct 10 2019, 6:19 PM
tuexen committed rS353403: MFC r353303:.
MFC r353303:
Oct 10 2019, 2:56 PM
tuexen committed rS353402: MFC r353290:.
MFC r353290:
Oct 10 2019, 2:54 PM
tuexen committed rS353401: MFC r353145:.
MFC r353145:
Oct 10 2019, 2:53 PM
tuexen committed rS353400: MFC r353123:.
MFC r353123:
Oct 10 2019, 2:51 PM
tuexen committed rS353399: MFC r353122:.
MFC r353122:
Oct 10 2019, 2:50 PM
tuexen committed rS353398: MFC r353119:.
MFC r353119:
Oct 10 2019, 2:50 PM
tuexen committed rS353397: MFC r353071:.
MFC r353071:
Oct 10 2019, 2:49 PM
tuexen committed rS353396: MFC r353069:.
MFC r353069:
Oct 10 2019, 2:47 PM
tuexen committed rS353395: MFC r353060:.
MFC r353060:
Oct 10 2019, 2:46 PM

Oct 8 2019

tuexen committed rS353303: Validate length before use it, not vice versa..
Validate length before use it, not vice versa.
Oct 8 2019, 11:07 AM

Oct 7 2019

tuexen committed rS353290: In r343587 a simple port filter as sysctl tunable was added to siftr..
In r343587 a simple port filter as sysctl tunable was added to siftr.
Oct 7 2019, 8:35 PM
tuexen closed D21619: Update SIFTR man page, and minor trailing whitespace nit..
Oct 7 2019, 8:35 PM

Oct 6 2019

tuexen added a comment to D21907: Move request window scaling computation to tcp_output().

What is the benefit of moving it? Also, at the new location, you perform the checks for every tcp_output() call, although it is only needed when dealing with the connect() call.
Furthermore, if you remove it from tcp_connect(), you also need to remove it from tcp6_connect().

Oct 6 2019, 6:37 PM
tuexen committed rS353145: Plumb an mbuf leak in a code path that should not be taken. Also avoid.
Plumb an mbuf leak in a code path that should not be taken. Also avoid
Oct 6 2019, 8:47 AM

Oct 5 2019

tuexen committed rS353123: Fix a use after free bug when removing remote addresses..
Fix a use after free bug when removing remote addresses.
Oct 5 2019, 1:28 PM
tuexen committed rS353122: Plumb an mbuf leak found by Mark Wodrich from Google by fuzz testing the.
Plumb an mbuf leak found by Mark Wodrich from Google by fuzz testing the
Oct 5 2019, 12:34 PM
tuexen committed rS353119: Fix the adding of padding to COOKIE-ECHO chunks..
Fix the adding of padding to COOKIE-ECHO chunks.
Oct 5 2019, 9:46 AM

Oct 3 2019

tuexen committed rS353071: When skipping the address parameter, take the padding into account..
When skipping the address parameter, take the padding into account.
Oct 3 2019, 8:48 PM
tuexen committed rS353069: Cleanup sctp_asconf_error_response() and ensure that the parameter.
Cleanup sctp_asconf_error_response() and ensure that the parameter
Oct 3 2019, 8:39 PM
tuexen committed rS353060: Add missing input validation. This could result in reading from.
Add missing input validation. This could result in reading from
Oct 3 2019, 6:36 PM
tuexen committed rS353045: MFS r352509:.
MFS r352509:
Oct 3 2019, 1:31 PM
tuexen committed rS353040: MFS r352673:.
MFS r352673:
Oct 3 2019, 12:27 PM
tuexen committed rS353038: MFS r352672:.
MFS r352672:
Oct 3 2019, 11:21 AM
tuexen committed rS353036: MFC r352894:.
MFC r352894:
Oct 3 2019, 10:46 AM