Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (137 w, 9 h)

Recent Activity

Wed, Sep 19

tuexen retitled D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl from Fix changing the MTU for tun devices via TUNSIFINFO iotcl to Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.
Wed, Sep 19, 6:49 PM
tuexen updated the diff for D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.

Add corresponding changes to the tap interface.

Wed, Sep 19, 6:47 PM
tuexen added a comment to D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.

Now I see what you are referring to. Thanks for the clarification. But this is a different issue. The tun/tap interfaces look like an interface and also like a socket. Setting the MTU via the interface way works as expected. The problem is only when changing it via the socket interface. The other tunnelling interfaces only look like interfaces and share a common method for changing the MTU. This works for the tun/tap interfaces but your example shows that there is an issue related to the outer/inner stuff. I might be able to look into this, but this is definitely a different issue.

Wed, Sep 19, 6:28 PM
tuexen added a comment to D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.

Why are also other tunnelling interfaces except for if_tap.c affected? Do they have a socket option to change the MTU? Right now, rt_updatemtu() seems only to be called from if.c, so integrating nd6_setmtu() into rt_updatemtu() can be done. But this would be a separate cleanup in my view.
So I can update the patch to cover also if_tap.c, but for the other tunnelling interfaces could you elaborate why they are also affected?

Wed, Sep 19, 3:42 PM

Tue, Sep 18

tuexen committed rS338749: Remove unused code..
Remove unused code.
Tue, Sep 18, 10:53 AM

Sun, Sep 16

tuexen added a reviewer for D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl: bz.
Sun, Sep 16, 1:09 PM
tuexen updated the summary of D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.
Sun, Sep 16, 1:08 PM
tuexen created D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.
Sun, Sep 16, 1:06 PM

Wed, Sep 12

tuexen committed rS338614: Fix TCP Fast Open for the TCP RACK stack..
Fix TCP Fast Open for the TCP RACK stack.
Wed, Sep 12, 10:28 AM
tuexen closed D16912: Fix TCP Fast Open for TCP RACK.
Wed, Sep 12, 10:28 AM

Thu, Sep 6

tuexen accepted D17057: Don't define sctp probes unless the SCTP option is configured..

Thanks for the fix. I never tested on a system without SCTP support.

Thu, Sep 6, 1:10 PM

Tue, Sep 4

tuexen accepted D17024: net/packetdrill: Take port maintainership and update.
Tue, Sep 4, 8:22 PM

Thu, Aug 30

tuexen added a comment to D16794: Update PPC loader relocations to match the kernel..

Hi John,
here is the TCP module


and here is the kernel

Best regards
Michael

Thu, Aug 30, 7:53 AM

Wed, Aug 29

tuexen added a comment to D16794: Update PPC loader relocations to match the kernel..
In D16794#361490, @jhb wrote:

Michael, I would like to get a copy of your kernel and tcprack.ko when you get some spare time.

I will see how to get this to you. I did a buildworld / installworld yesterday with the result that the system does not boot anymore.
This is NOT related to the change of this review. I posted the error message on the ppc mailing list...

Wed, Aug 29, 10:06 PM

Mon, Aug 27

tuexen added inline comments to D16912: Fix TCP Fast Open for TCP RACK.
Mon, Aug 27, 7:28 PM

Sun, Aug 26

tuexen created D16912: Fix TCP Fast Open for TCP RACK.
Sun, Aug 26, 9:10 PM

Fri, Aug 24

tuexen committed rS338291: Fix a shadowed variable warning..
Fix a shadowed variable warning.
Fri, Aug 24, 10:51 AM

Thu, Aug 23

tuexen committed rS338273: Use arc4rand() instead of read_random() in the SCTP and TCP code..
Use arc4rand() instead of read_random() in the SCTP and TCP code.
Thu, Aug 23, 7:11 PM
tuexen closed D16860: Use arc4rand() instead of read_random().
Thu, Aug 23, 7:11 PM
tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Thu, Aug 23, 11:33 AM
tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Thu, Aug 23, 11:14 AM
tuexen created D16860: Use arc4rand() instead of read_random().
Thu, Aug 23, 7:31 AM
tuexen committed rS338241: Don't use the explicit number 32 for the length of the secrets,.
Don't use the explicit number 32 for the length of the secrets,
Thu, Aug 23, 6:04 AM
tuexen accepted D16850: Update the fragment reassembly code's handling of overlapping fragments to conform to RFC 8200..
Thu, Aug 23, 12:29 AM

Wed, Aug 22

tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Wed, Aug 22, 9:43 PM
tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Wed, Aug 22, 9:40 PM
tuexen added a comment to D16839: Add SCTP support to dtrace.

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

Wed, Aug 22, 9:28 PM
tuexen added a comment to D16839: Add SCTP support to dtrace.

I'll admit to being completely unfamiliar with SCTP, but I can't find any problems with this change. Thanks for adding the tests.

Wed, Aug 22, 9:26 PM
tuexen added a comment to D16839: Add SCTP support to dtrace.

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

Wed, Aug 22, 9:25 PM
tuexen committed rS338213: Add support for send, receive and state-change DTrace providers for.
Add support for send, receive and state-change DTrace providers for
Wed, Aug 22, 9:23 PM
tuexen closed D16839: Add SCTP support to dtrace.
Wed, Aug 22, 9:23 PM
tuexen created D16839: Add SCTP support to dtrace.
Wed, Aug 22, 6:42 AM

Aug 21 2018

tuexen committed rS338138: Enabling the IPPROTO_IPV6 level socket option IPV6_USE_MIN_MTU on a TCP.
Enabling the IPPROTO_IPV6 level socket option IPV6_USE_MIN_MTU on a TCP
Aug 21 2018, 2:12 PM
tuexen closed D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.
Aug 21 2018, 2:12 PM
tuexen closed D16792: Fix inheritance of IPv6 options.
Aug 21 2018, 2:08 PM
tuexen committed rS338137: Fix the inheritance of IPv6 level socket options on TCP sockets..
Fix the inheritance of IPv6 level socket options on TCP sockets.
Aug 21 2018, 2:07 PM
tuexen committed rS338136: Add SOL_SOCKET level socket option with name SO_DOMAIN to get.
Add SOL_SOCKET level socket option with name SO_DOMAIN to get
Aug 21 2018, 2:04 PM
tuexen closed D16791: Add support for SO_DOMAIN in getsockopt().
Aug 21 2018, 2:04 PM
tuexen committed rS338135: Whitespace change..
Whitespace change.
Aug 21 2018, 1:37 PM
tuexen committed rS338134: Refactor the SHUTDOWN_PENDING state handling..
Refactor the SHUTDOWN_PENDING state handling.
Aug 21 2018, 1:25 PM

Aug 20 2018

tuexen added inline comments to D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.
Aug 20 2018, 9:23 PM
tuexen updated the diff for D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.

Address comments from bz@

Aug 20 2018, 9:22 PM
tuexen added a comment to D16794: Update PPC loader relocations to match the kernel..

With this patch the kernel can load the tcp_rack module, which is not special, I think.

Aug 20 2018, 11:46 AM

Aug 19 2018

tuexen committed rS338053: Don't expose the uptime via the TCP timestamps..
Don't expose the uptime via the TCP timestamps.
Aug 19 2018, 2:56 PM
tuexen closed D16636: Improve TCP timestamps.
Aug 19 2018, 2:56 PM
tuexen accepted D16626: Rewrite of TCP Reassembly code.

I ran the packetdrill tests from rcv-data-segments and they all pass.

Aug 19 2018, 8:10 AM

Aug 18 2018

tuexen created D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.
Aug 18 2018, 11:05 PM
tuexen created D16792: Fix inheritance of IPv6 options.
Aug 18 2018, 4:42 PM
tuexen created D16791: Add support for SO_DOMAIN in getsockopt().
Aug 18 2018, 3:23 PM

Aug 14 2018

tuexen committed rS337738: Use a macro to set the assoc state. I missed this in r337706..
Use a macro to set the assoc state. I missed this in r337706.
Aug 14 2018, 8:34 AM
tuexen committed rS337737: Remove a set but not used warning showing up in usrsctp..
Remove a set but not used warning showing up in usrsctp.
Aug 14 2018, 8:32 AM

Aug 13 2018

tuexen committed rS337708: Use the stacb instead of the asoc in state macros..
Use the stacb instead of the asoc in state macros.
Aug 13 2018, 1:58 PM
tuexen committed rS337706: Use consistently the macors to modify the assoc state..
Use consistently the macors to modify the assoc state.
Aug 13 2018, 11:56 AM

Aug 12 2018

tuexen committed rS337688: Add explicit cast to silence a warning for the userland stack..
Add explicit cast to silence a warning for the userland stack.
Aug 12 2018, 2:05 PM

Aug 10 2018

tuexen added a comment to D16626: Rewrite of TCP Reassembly code.

@tuexen latest version of this review as of this comment with your updated packetdrill https://reviews.freebsd.org/P204

Aug 10 2018, 3:00 PM
tuexen added a comment to D16626: Rewrite of TCP Reassembly code.

@tuexen latest version of this review as of this comment with your updated packetdrill https://reviews.freebsd.org/P204

Aug 10 2018, 12:22 PM

Aug 8 2018

tuexen added a reviewer for D16636: Improve TCP timestamps: kbowling.
Aug 8 2018, 11:22 PM
tuexen created D16636: Improve TCP timestamps.
Aug 8 2018, 11:21 PM

Aug 6 2018

tuexen accepted D16604: Rack sends extra FIN.
Aug 6 2018, 7:04 PM
tuexen updated the test plan for D16604: Rack sends extra FIN.
Aug 6 2018, 7:04 PM

Aug 5 2018

tuexen accepted D16579: Rack delayed ack issue.
Aug 5 2018, 11:57 AM

Aug 3 2018

tuexen requested changes to D16579: Rack delayed ack issue.
Aug 3 2018, 12:16 PM

Jul 31 2018

tuexen closed D16377: Add dtrace network provider for UDP-Lite.
Jul 31 2018, 10:56 PM
tuexen committed rS337018: Add a dtrace provider for UDP-Lite..
Add a dtrace provider for UDP-Lite.
Jul 31 2018, 10:56 PM
tuexen committed rS336962: Fix INET only builds..
Fix INET only builds.
Jul 31 2018, 6:27 AM

Jul 30 2018

tuexen committed rS336940: Allow implicit TCP connection setup for TCP/IPv6..
Allow implicit TCP connection setup for TCP/IPv6.
Jul 30 2018, 9:27 PM
tuexen closed D16458: Allow implicit connection setup for TCP/IPv6.
Jul 30 2018, 9:27 PM
tuexen committed rS336937: Send consistent SEG.WIN when using timewait codepath for TCP..
Send consistent SEG.WIN when using timewait codepath for TCP.
Jul 30 2018, 9:14 PM
tuexen closed D16503: Send consistent SEG.WIN when sending from the timewait code path.
Jul 30 2018, 9:14 PM
tuexen committed rS336934: Fix some TCP fast open issues..
Fix some TCP fast open issues.
Jul 30 2018, 8:36 PM
tuexen closed D16485: Fix some TCP fast open issues.
Jul 30 2018, 8:36 PM
tuexen closed D16369: Add missing dtrace receive and send probes for TCP.
Jul 30 2018, 8:14 PM
tuexen committed rS336932: Add missing send/recv dtrace probes for TCP..
Add missing send/recv dtrace probes for TCP.
Jul 30 2018, 8:13 PM
tuexen added a reviewer for D16377: Add dtrace network provider for UDP-Lite: rrs.
Jul 30 2018, 6:14 PM
tuexen added a comment to D16377: Add dtrace network provider for UDP-Lite.

OK. Then I would like to keep the files separate. This way we don't bother people interested in UDP and not knowing about UDP-Lite with UDP-Lite. I guess these cover most users...

Jul 30 2018, 5:09 PM
tuexen added a comment to D16377: Add dtrace network provider for UDP-Lite.

UDP-Lite is a protocol different from UDP. So I just wanted to keep things reflecting that.. However, I can add the contents of udplite.d to udp.d.
I can also add the UDP-Lite stuff to the dtrace-udp man-page. We just should make sure that it shows up, when asking for man dtrace-udplite.

Jul 30 2018, 4:31 PM

Jul 29 2018

tuexen created D16503: Send consistent SEG.WIN when sending from the timewait code path.
Jul 29 2018, 10:17 PM
tuexen updated the diff for D16458: Allow implicit connection setup for TCP/IPv6.

Address final comment from bz@

Jul 29 2018, 12:02 PM
tuexen added a comment to D16458: Allow implicit connection setup for TCP/IPv6.

@bz: I tried to address the issues brought up by you. Regarding the IPv4 related commit: There was no IPv6 support (which is added by this patch) and there was no real checking for IPv4 (which is added by this patch). There was no real IPv4 related commit bringing in a corresponding feature. The checks where added to the connect code path, but where missed in the sendto code path...

Jul 29 2018, 11:44 AM
tuexen updated the diff for D16458: Allow implicit connection setup for TCP/IPv6.

Try to address issues reported by bz@.

Jul 29 2018, 11:40 AM
tuexen added a reviewer for D16458: Allow implicit connection setup for TCP/IPv6: kbowling.
Jul 29 2018, 9:14 AM
tuexen added inline comments to D16485: Fix some TCP fast open issues.
Jul 29 2018, 7:05 AM
tuexen updated the diff for D16485: Fix some TCP fast open issues.

Update the comments as suggested by jtl@.

Jul 29 2018, 7:05 AM

Jul 28 2018

tuexen created D16485: Fix some TCP fast open issues.
Jul 28 2018, 4:35 PM

Jul 27 2018

tuexen accepted D16471: Some TCP reassembly improvements.
Jul 27 2018, 6:19 PM

Jul 26 2018

tuexen added a reviewer for D16458: Allow implicit connection setup for TCP/IPv6: pkelsey.
Jul 26 2018, 2:52 PM
tuexen created D16458: Allow implicit connection setup for TCP/IPv6.
Jul 26 2018, 2:52 PM

Jul 22 2018

tuexen retitled D16369: Add missing dtrace receive and send probes for TCP from Add missing dtrace receive and send probes to Add missing dtrace receive and send probes for TCP.
Jul 22 2018, 11:31 AM
tuexen added inline comments to D16369: Add missing dtrace receive and send probes for TCP.
Jul 22 2018, 11:31 AM
tuexen committed rS336597: Improve TCP related tests for dtrace..
Improve TCP related tests for dtrace.
Jul 22 2018, 10:51 AM
tuexen closed D16288: Improve TCP related dtrace tests.
Jul 22 2018, 10:51 AM

Jul 21 2018

tuexen added a comment to D16377: Add dtrace network provider for UDP-Lite.

Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...

cd cddl/usr.sbin/dwatch/libexec
sed -e 's/udp/&lite/g;s/length/coverage/g' udp > udplite
echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile

Not that easy:

tuexen@head:~/head/cddl/usr.sbin/dwatch/libexec % echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile
Illegal variable name.

Bah, foiled by [t]csh. Use this:

sh -c 'echo "$( awk '\''(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}'\'' Makefile )" > Makefile'
Jul 21 2018, 6:17 AM
tuexen updated the diff for D16377: Add dtrace network provider for UDP-Lite.

Added dwatch script as provided by dteske@.

Jul 21 2018, 6:16 AM
tuexen added a comment to D16377: Add dtrace network provider for UDP-Lite.

Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...

cd cddl/usr.sbin/dwatch/libexec
sed -e 's/udp/&lite/g;s/length/coverage/g' udp > udplite
echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile

Not that easy:

tuexen@head:~/head/cddl/usr.sbin/dwatch/libexec % echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile
Illegal variable name.
Jul 21 2018, 5:52 AM
tuexen added a comment to D16377: Add dtrace network provider for UDP-Lite.

@markj Please let me know your preferred commit split for the files in this review.

Jul 21 2018, 3:34 AM
tuexen updated the summary of D16377: Add dtrace network provider for UDP-Lite.
Jul 21 2018, 3:33 AM
tuexen created D16377: Add dtrace network provider for UDP-Lite.
Jul 21 2018, 3:32 AM
tuexen committed rS336574: Set the IPv4 version in the IP header for UDP and UDPLite..
Set the IPv4 version in the IP header for UDP and UDPLite.
Jul 21 2018, 2:14 AM

Jul 20 2018

tuexen added a reviewer for D16369: Add missing dtrace receive and send probes for TCP: rrs.
Jul 20 2018, 8:25 PM
tuexen updated the summary of D16288: Improve TCP related dtrace tests.
Jul 20 2018, 8:24 PM