In D22704#496723, @rscheff_gmx.at wrote:

Why would cleaning up trailing whitespaces make MFCing harder? Other than possibly adding one adjacent line?

If you don't MFC the whitespace cleanup, you might get merge conflicts...

I made this huge diff, because sneaking these in one-by-one whenever I encounter them around the lines I was modifying was shot down so far ;)

As I said, doing this once is a nice thing in my opinion...

BTW - since lint was removed, what other tool could I use to validate the fbsd code style(9)? Any hint as to how i could integrate that into git or arcanist would be appreciated.

I"m not doing this automated... I just try to follow it (as much as I think is a good thing) when coding... But this is not perfect and others are also not perfect.

When I did similar things in the past, one comment I received was that this does not improve the functionality, but
might make MFCing harder... However, only dealing with this in a single commit is definitely a good idea in my view.
The question is whether to do it at all. Maybe rrs@ or rgrimes@ have an opinion on this.

@jhibbits Thanks for the explanation. I'm using it on a blackbird. I have also a G5 Powermac in my lab, so if there is a need for testing, just let me know. I would like to run an unmodified version of FreeBSD just to make sure I don't commit anything by accident...

Don't we need a similar change to BBR?

What is needed to get this in tree? Testing on Apple hardware was mentioned. What should be tested?

I didn't know that this review existed when committing r322967, which contains the fix suggested here.

Create a file sctp_module.c which handles all modules specific things which are FreeBSD specific. Also add sctp to the global list of modules.

A version which works on VIMAGE and !VIAMGE kernels.

Integrate result of discussion.

I think the changes to in_kdtrace.c and sctp_kdtrace.c are not needed anymore, since they are in head.

I'll focus on the eventhandler changes...

I would suggest to get

• the generic fixes from above in head first
• then get the eventhandler stuff or the dtrace changes in as separate commits.

That reduces the patch set and really focusses on the changes related to allowing SCTP to be a module.

What is the benefit of moving it? Also, at the new location, you perform the checks for every tcp_output() call, although it is only needed when dealing with the connect() call.
Furthermore, if you remove it from tcp_connect(), you also need to remove it from tcp6_connect().