Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (192 w, 4 d)

Recent Activity

Today

tuexen committed rS353518: Separate out SCTP related dtrace code..
Separate out SCTP related dtrace code.
Mon, Oct 14, 8:32 PM
tuexen committed rS353488: Rename sctp_dtrace_declare.h to sctp_kdtrace.h for consistentcy..
Rename sctp_dtrace_declare.h to sctp_kdtrace.h for consistentcy.
Mon, Oct 14, 1:03 PM

Yesterday

tuexen committed rS353482: Add missing include which breaks builds without VIMAGE..
Add missing include which breaks builds without VIMAGE.
Sun, Oct 13, 7:59 PM
tuexen committed rS353480: Use an event handler to notify the SCTP about IP address changes.
Use an event handler to notify the SCTP about IP address changes
Sun, Oct 13, 6:17 PM
tuexen added a comment to D21997: Support a loadable sctp module..

I'll focus on the eventhandler changes...

Sun, Oct 13, 9:41 AM
tuexen added inline comments to D21997: Support a loadable sctp module..
Sun, Oct 13, 9:40 AM
tuexen committed rS353466: Remove line not needed..
Remove line not needed.
Sun, Oct 13, 9:35 AM

Sat, Oct 12

tuexen added inline comments to D21997: Support a loadable sctp module..
Sat, Oct 12, 9:09 PM
tuexen added a reviewer for D21997: Support a loadable sctp module.: rrs.
Sat, Oct 12, 9:04 PM
tuexen added a comment to D21997: Support a loadable sctp module..

I would suggest to get

  • the generic fixes from above in head first
  • then get the eventhandler stuff or the dtrace changes in as separate commits.

That reduces the patch set and really focusses on the changes related to allowing SCTP to be a module.

Sat, Oct 12, 9:04 PM
tuexen committed rS353452: Ensure that local variables are reset to their initial value when.
Ensure that local variables are reset to their initial value when
Sat, Oct 12, 5:57 PM

Thu, Oct 10

tuexen committed rS353412: MFS r353402:.
MFS r353402:
Thu, Oct 10, 6:39 PM
tuexen committed rS353410: MFS r353395:.
MFS r353395:
Thu, Oct 10, 6:19 PM
tuexen committed rS353403: MFC r353303:.
MFC r353303:
Thu, Oct 10, 2:56 PM
tuexen committed rS353402: MFC r353290:.
MFC r353290:
Thu, Oct 10, 2:54 PM
tuexen committed rS353401: MFC r353145:.
MFC r353145:
Thu, Oct 10, 2:53 PM
tuexen committed rS353400: MFC r353123:.
MFC r353123:
Thu, Oct 10, 2:51 PM
tuexen committed rS353399: MFC r353122:.
MFC r353122:
Thu, Oct 10, 2:50 PM
tuexen committed rS353398: MFC r353119:.
MFC r353119:
Thu, Oct 10, 2:50 PM
tuexen committed rS353397: MFC r353071:.
MFC r353071:
Thu, Oct 10, 2:49 PM
tuexen committed rS353396: MFC r353069:.
MFC r353069:
Thu, Oct 10, 2:47 PM
tuexen committed rS353395: MFC r353060:.
MFC r353060:
Thu, Oct 10, 2:46 PM

Tue, Oct 8

tuexen committed rS353303: Validate length before use it, not vice versa..
Validate length before use it, not vice versa.
Tue, Oct 8, 11:07 AM

Mon, Oct 7

tuexen committed rS353290: In r343587 a simple port filter as sysctl tunable was added to siftr..
In r343587 a simple port filter as sysctl tunable was added to siftr.
Mon, Oct 7, 8:35 PM
tuexen closed D21619: Update SIFTR man page, and minor trailing whitespace nit..
Mon, Oct 7, 8:35 PM

Sun, Oct 6

tuexen added a comment to D21907: Move request window scaling computation to tcp_output().

What is the benefit of moving it? Also, at the new location, you perform the checks for every tcp_output() call, although it is only needed when dealing with the connect() call.
Furthermore, if you remove it from tcp_connect(), you also need to remove it from tcp6_connect().

Sun, Oct 6, 6:37 PM
tuexen committed rS353145: Plumb an mbuf leak in a code path that should not be taken. Also avoid.
Plumb an mbuf leak in a code path that should not be taken. Also avoid
Sun, Oct 6, 8:47 AM

Sat, Oct 5

tuexen committed rS353123: Fix a use after free bug when removing remote addresses..
Fix a use after free bug when removing remote addresses.
Sat, Oct 5, 1:28 PM
tuexen committed rS353122: Plumb an mbuf leak found by Mark Wodrich from Google by fuzz testing the.
Plumb an mbuf leak found by Mark Wodrich from Google by fuzz testing the
Sat, Oct 5, 12:34 PM
tuexen committed rS353119: Fix the adding of padding to COOKIE-ECHO chunks..
Fix the adding of padding to COOKIE-ECHO chunks.
Sat, Oct 5, 9:46 AM

Thu, Oct 3

tuexen committed rS353071: When skipping the address parameter, take the padding into account..
When skipping the address parameter, take the padding into account.
Thu, Oct 3, 8:48 PM
tuexen committed rS353069: Cleanup sctp_asconf_error_response() and ensure that the parameter.
Cleanup sctp_asconf_error_response() and ensure that the parameter
Thu, Oct 3, 8:39 PM
tuexen committed rS353060: Add missing input validation. This could result in reading from.
Add missing input validation. This could result in reading from
Thu, Oct 3, 6:36 PM
tuexen committed rS353045: MFS r352509:.
MFS r352509:
Thu, Oct 3, 1:31 PM
tuexen committed rS353040: MFS r352673:.
MFS r352673:
Thu, Oct 3, 12:27 PM
tuexen committed rS353038: MFS r352672:.
MFS r352672:
Thu, Oct 3, 11:21 AM
tuexen committed rS353036: MFC r352894:.
MFC r352894:
Thu, Oct 3, 10:46 AM
tuexen committed rS353035: MFC r352868:.
MFC r352868:
Thu, Oct 3, 10:44 AM
tuexen committed rS353034: MFC r352652:.
MFC r352652:
Thu, Oct 3, 10:38 AM

Mon, Sep 30

tuexen committed rS352894: Don't use stack memory which is not initialized..
Don't use stack memory which is not initialized.
Mon, Sep 30, 12:07 PM
tuexen committed rS352886: MFS r352508:.
MFS r352508:
Mon, Sep 30, 4:54 AM

Sun, Sep 29

tuexen added inline comments to D14387: Further reduce keepalive timer rescheduling.
Sun, Sep 29, 11:41 AM
tuexen added a reviewer for D14387: Further reduce keepalive timer rescheduling: tuexen.
Sun, Sep 29, 10:48 AM
tuexen closed D21665: Don't send TCP segments when the IP header chain and the TCP header doesn't fit in a packet.
Sun, Sep 29, 10:45 AM
tuexen committed rS352868: RFC 7112 requires a host to put the complete IP header chain.
RFC 7112 requires a host to put the complete IP header chain
Sun, Sep 29, 10:45 AM
tuexen added inline comments to D21665: Don't send TCP segments when the IP header chain and the TCP header doesn't fit in a packet.
Sun, Sep 29, 10:41 AM
tuexen updated the diff for D21665: Don't send TCP segments when the IP header chain and the TCP header doesn't fit in a packet.

Allow at least one byte of payload to ensure that making progress is possible. This was suggested in the transport telco.

Sun, Sep 29, 10:41 AM

Sat, Sep 28

tuexen added a comment to D21669: mtod macro: Drop the type argument.

I'm contemplating what we gain by this change... We get a much more complex definition of mtod() and, for example, in the case of the SCTP source, which are shared with other BSD like platforms which don't make that change, we have to provide a way to do it still the old way. I guess, I have to replace mtod() by SCTP_MTOD() with the 2 argument semantic in the SCTP sources and then make platform specific definitions: On FreeBSD, call your version and do the explicit cast, on the other platforms just call mtod(). Another point is that these mechanical global changes might make MFCing code harder...

Sat, Sep 28, 4:18 PM
tuexen committed rS352843: Replacing MD5 by SipHash improves the performance of the TCP time stamp.
Replacing MD5 by SipHash improves the performance of the TCP time stamp
Sat, Sep 28, 1:13 PM
tuexen closed D21616: Replace MD5 by SipHash as TCP keyed hash function.
Sat, Sep 28, 1:13 PM
tuexen committed rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt().
Ensure that the INP lock is released before leaving [gs]etsockopt()
Sat, Sep 28, 1:05 PM
tuexen closed D21825: Fix locking for some RACK specific socket options.
Sat, Sep 28, 1:05 PM

Fri, Sep 27

tuexen created D21825: Fix locking for some RACK specific socket options.
Fri, Sep 27, 7:45 PM

Wed, Sep 25

tuexen committed rS352676: MFC r352594:.
MFC r352594:
Wed, Sep 25, 10:46 AM
tuexen committed rS352675: MFC r352592:.
MFC r352592:
Wed, Sep 25, 10:44 AM
tuexen committed rS352674: MFC r352550:.
MFC r352550:
Wed, Sep 25, 10:42 AM
tuexen committed rS352673: MFC r352512:.
MFC r352512:
Wed, Sep 25, 10:41 AM
tuexen committed rS352672: MFC r352511:.
MFC r352511:
Wed, Sep 25, 10:39 AM

Tue, Sep 24

tuexen committed rS352652: Plumb a memory leak..
Plumb a memory leak.
Tue, Sep 24, 1:15 PM

Sun, Sep 22

tuexen committed rS352594: Don't hold the info lock when calling sctp_select_a_tag()..
Don't hold the info lock when calling sctp_select_a_tag().
Sun, Sep 22, 11:11 AM
tuexen committed rS352592: Cleanup the RTO calculation and perform some consistency checks.
Cleanup the RTO calculation and perform some consistency checks
Sun, Sep 22, 10:40 AM

Fri, Sep 20

tuexen committed rS352550: Fix the handling of invalid parameters in ASCONF chunks..
Fix the handling of invalid parameters in ASCONF chunks.
Fri, Sep 20, 8:20 AM

Thu, Sep 19

tuexen committed rS352512: When the RACK stack computes the space for user data in a TCP segment,.
When the RACK stack computes the space for user data in a TCP segment,
Thu, Sep 19, 10:28 AM
tuexen closed D21666: Let the RACK stack take IP options into account when computing the space for user data in TCP segments.
Thu, Sep 19, 10:28 AM
tuexen committed rS352511: When processing an incoming IPv6 packet over the loopback interface which.
When processing an incoming IPv6 packet over the loopback interface which
Thu, Sep 19, 10:22 AM
tuexen closed D21664: Fix handling of Hop-by-Hop options over the loopback interface.
Thu, Sep 19, 10:22 AM
tuexen committed rS352510: MFC r352438:.
MFC r352438:
Thu, Sep 19, 10:06 AM
tuexen committed rS352509: MFC r352438:.
MFC r352438:
Thu, Sep 19, 10:01 AM
tuexen committed rS352508: MFC r352386:.
MFC r352386:
Thu, Sep 19, 9:59 AM

Tue, Sep 17

tuexen committed rS352438: Only allow a SCTP-AUTH shared key to be updated by the application.
Only allow a SCTP-AUTH shared key to be updated by the application
Tue, Sep 17, 9:46 AM

Mon, Sep 16

tuexen committed rS352386: Don't write to memory outside of the allocated array for SACK blocks..
Don't write to memory outside of the allocated array for SACK blocks.
Mon, Sep 16, 8:18 AM

Sun, Sep 15

tuexen committed rS352361: When the IP layer calls back into the SCTP layer to perform the SCTP.
When the IP layer calls back into the SCTP layer to perform the SCTP
Sun, Sep 15, 6:30 PM
tuexen added inline comments to D21664: Fix handling of Hop-by-Hop options over the loopback interface.
Sun, Sep 15, 6:03 PM
tuexen created D21666: Let the RACK stack take IP options into account when computing the space for user data in TCP segments.
Sun, Sep 15, 5:53 PM
tuexen created D21665: Don't send TCP segments when the IP header chain and the TCP header doesn't fit in a packet.
Sun, Sep 15, 3:36 PM
tuexen created D21664: Fix handling of Hop-by-Hop options over the loopback interface.
Sun, Sep 15, 2:37 PM

Sep 13 2019

tuexen committed rS352284: MFC r352072:.
MFC r352072:
Sep 13 2019, 8:15 AM

Sep 12 2019

tuexen added a reviewer for D21616: Replace MD5 by SipHash as TCP keyed hash function: rscheff_gmx.at.
Sep 12 2019, 2:29 PM
tuexen created D21616: Replace MD5 by SipHash as TCP keyed hash function.
Sep 12 2019, 2:03 PM

Sep 10 2019

tuexen accepted D21591: avoid unneeded call to arc4random() in syncache_add().
Sep 10 2019, 9:12 PM

Sep 9 2019

tuexen closed D21567: Improve DSACK computation.
Sep 9 2019, 4:08 PM
tuexen committed rS352072: Only update SACK/DSACK lists when a non-empty segment was received..
Only update SACK/DSACK lists when a non-empty segment was received.
Sep 9 2019, 4:08 PM
tuexen added a comment to D21567: Improve DSACK computation.

Checked this patch with various "pure FIN after hole" and "data FIN after hole" combinations; the FIN bit becomes part of the SACK (and DSACK) blocks, as it should be when considering that FIN is part of the sequence number space.

Sep 9 2019, 2:25 PM
tuexen added a comment to D21567: Improve DSACK computation.

The patch has been updated to address Richard's comments.

Sep 9 2019, 11:27 AM
tuexen updated the diff for D21567: Improve DSACK computation.

Address Richard's comments.

Sep 9 2019, 11:26 AM
tuexen committed rS352057: MFC r349986:.
MFC r349986:
Sep 9 2019, 11:20 AM
tuexen committed rS352055: The variable names in the description of the port number usage is.
The variable names in the description of the port number usage is
Sep 9 2019, 10:45 AM
tuexen added a comment to D21567: Improve DSACK computation.
In D21567#469962, @rrs wrote:

I would like to see the Rack version of the code be identical to the tcp_input version.. i.e. it should check
if ((tlen > 0) && (tp->t_flags & TF_SACK_PERMITED))
The soon to be committed version of rack will allow a user to use the stack without sack.. so it is best to
put this in place now.

Sep 9 2019, 9:55 AM
tuexen updated the diff for D21567: Improve DSACK computation.

Add a check to the RACK code whether the SACK extension is enabled. This was requested by rrs@.

Sep 9 2019, 9:54 AM

Sep 8 2019

tuexen created D21567: Improve DSACK computation.
Sep 8 2019, 8:31 PM

Sep 7 2019

tuexen committed rS352022: Improve DSACK support:.
Improve DSACK support:
Sep 7 2019, 7:58 PM
tuexen committed rS352008: MFC r351655:.
MFC r351655:
Sep 7 2019, 12:20 PM
tuexen committed rS352007: MFC r351654:.
MFC r351654:
Sep 7 2019, 12:19 PM
tuexen committed rS352006: MFC r351641:.
MFC r351641:
Sep 7 2019, 12:15 PM
tuexen committed rS352005: MFC r351638:.
MFC r351638:
Sep 7 2019, 12:14 PM
tuexen committed rS352004: MFC r351511:.
MFC r351511:
Sep 7 2019, 12:03 PM
tuexen committed rS352003: MFC r350745:.
MFC r350745:
Sep 7 2019, 12:01 PM
tuexen committed rS352002: MFC r350627:.
MFC r350627:
Sep 7 2019, 12:00 PM
tuexen committed rS352001: MFC r350626:.
MFC r350626:
Sep 7 2019, 11:58 AM
tuexen committed rS352000: MFC r350625:.
MFC r350625:
Sep 7 2019, 11:56 AM