Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (225 w, 5 d)

Recent Activity

Today

tuexen closed D25115: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state.
Wed, Jun 3, 1:52 PM
tuexen committed rS361750: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state.
Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state
Wed, Jun 3, 1:52 PM
tuexen added a comment to D25115: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state.

Is EINVAL the correct return code? Or should this be EAGAIN / EBUSY?

OTOH, when a listening socket forks into a connected, it's too late to change on the newly connected socket - or can a socket transition back from CLOSED to LISTEN, after a session has concluded? (I know this is not typically done, and I haven't used such recycling of sockets myself either).

Wed, Jun 3, 12:43 PM
tuexen accepted D25000: Skyzaller crash found by Michael Tuexen.
Wed, Jun 3, 12:10 PM
tuexen updated the summary of D25115: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state.
Wed, Jun 3, 10:45 AM
tuexen requested review of D25115: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state.
Wed, Jun 3, 10:45 AM

Tue, May 26

tuexen committed rS361522: MFS r361469: Fix bug in PR-SCTP.
MFS r361469: Fix bug in PR-SCTP
Tue, May 26, 3:49 PM

Mon, May 25

tuexen committed rS361480: MFC r361227: remove assignment without effect..
MFC r361227: remove assignment without effect.
Mon, May 25, 9:14 PM
tuexen committed rS361479: MFC r361226: Cleanup.
MFC r361226: Cleanup
Mon, May 25, 8:23 PM
tuexen committed rS361478: MFC r361225: Remove redundant assignment.
MFC r361225: Remove redundant assignment
Mon, May 25, 8:22 PM
tuexen committed rS361477: MFC r361224: Cleanup..
MFC r361224: Cleanup.
Mon, May 25, 8:19 PM
tuexen committed rS361476: MFC r361222: Improve ASCONF handling.
MFC r361222: Improve ASCONF handling
Mon, May 25, 8:17 PM
tuexen committed rS361475: MFC r361221: Remove redundant check..
MFC r361221: Remove redundant check.
Mon, May 25, 8:16 PM
tuexen committed rS361474: MFC r361214: Correctly ignore impossible RTT measurements.
MFC r361214: Correctly ignore impossible RTT measurements
Mon, May 25, 8:14 PM
tuexen committed rS361473: MFC r361116: Improve stcb handling during teardown.
MFC r361116: Improve stcb handling during teardown
Mon, May 25, 8:11 PM
tuexen committed rS361472: MFC 360885: Improve SCTP iterator.
MFC 360885: Improve SCTP iterator
Mon, May 25, 8:09 PM
tuexen committed rS361471: MFC r360878, r360942: Improve SCTP timer handling.
MFC r360878, r360942: Improve SCTP timer handling
Mon, May 25, 8:07 PM
tuexen committed rS361469: MFC r360869: Fix bug in PR-SCTP.
MFC r360869: Fix bug in PR-SCTP
Mon, May 25, 8:04 PM
tuexen added a comment to D25000: Skyzaller crash found by Michael Tuexen.

Question: You are introducting the flag RACK_HAS_SIN and you are setting it. But you are never reading it. Is that intended?

Mon, May 25, 2:02 PM
tuexen accepted D25000: Skyzaller crash found by Michael Tuexen.
Mon, May 25, 1:59 PM

Thu, May 21

tuexen accepted D24817: DCTCP: update alpha only once after loss recovery..
Thu, May 21, 2:20 PM
tuexen accepted D23373: Handle ECN handshake in simultaneous open.
Thu, May 21, 1:55 PM
tuexen accepted D23371: Retain only mutually supported TCP options after simultaneous SYN.
Thu, May 21, 1:55 PM

Tue, May 19

tuexen committed rS361243: Replace snprintf() by SCTP_SNPRINTF() and let SCTP_SNPRINTF() map.
Replace snprintf() by SCTP_SNPRINTF() and let SCTP_SNPRINTF() map
Tue, May 19, 7:23 AM
tuexen committed rS361242: Revert r361209:.
Revert r361209:
Tue, May 19, 7:21 AM

Mon, May 18

tuexen committed rS361227: Remove assignment without effect..
Remove assignment without effect.
Mon, May 18, 7:48 PM
tuexen committed rS361226: Don't check an unsigned variable for being negative..
Don't check an unsigned variable for being negative.
Mon, May 18, 7:36 PM
tuexen committed rS361225: Remove redundant assignment..
Remove redundant assignment.
Mon, May 18, 7:23 PM
tuexen committed rS361224: Cleanup, no functional change intended..
Cleanup, no functional change intended.
Mon, May 18, 6:42 PM
tuexen committed rS361222: Avoid an integer underflow..
Avoid an integer underflow.
Mon, May 18, 6:33 PM
tuexen committed rS361221: Remove redundant check..
Remove redundant check.
Mon, May 18, 6:27 PM
tuexen committed rS361214: Fix logical condition by looking at usecs..
Fix logical condition by looking at usecs.
Mon, May 18, 3:02 PM
tuexen committed rS361213: Whitespace change..
Whitespace change.
Mon, May 18, 3:00 PM
tuexen accepted D24781: Allow TCP to reuse local port with different destinations.
Mon, May 18, 2:23 PM
tuexen committed rS361209: Handle failures of snprintf()..
Handle failures of snprintf().
Mon, May 18, 10:07 AM

Sun, May 17

tuexen added a comment to D24781: Allow TCP to reuse local port with different destinations.

Hi Mike,
let me ask you two questions:

  • If there is a wildcard socket bound against *:port, will this local port be used for a particular remote address?
  • If these is a local port and address bound to a specific remote address port. Can you still bind a wildcard address to this port?

Thanks for the answers.
Best regards
Michael

Sun, May 17, 11:07 PM
tuexen committed rS361145: Non-functional changes, cleanups..
Non-functional changes, cleanups.
Sun, May 17, 10:31 PM

Sat, May 16

tuexen committed rS361116: Ensure that an stcb is not dereferenced when it is about to be.
Ensure that an stcb is not dereferenced when it is about to be
Sat, May 16, 7:26 PM

Fri, May 15

tuexen closed D24826: Hung sessions.
Fri, May 15, 2:18 PM
tuexen added a comment to D24826: Hung sessions.

This change is committed in r361080.

Fri, May 15, 2:18 PM
tuexen committed rS361081: Allow only IPv4 addresses in sendto() for TCP on AF_INET sockets..
Allow only IPv4 addresses in sendto() for TCP on AF_INET sockets.
Fri, May 15, 2:06 PM
Herald added 1 blocking reviewer(s) for D24852: Invalid addresses in sending or connecting: transport.
Fri, May 15, 2:00 PM
tuexen accepted D24826: Hung sessions.
Fri, May 15, 1:07 PM

Thu, May 14

tuexen added a comment to D21669: mtod macro: Drop the type argument.
In D21669#546629, @cem wrote:

I'm contemplating what we gain by this change... We get a much more complex definition of mtod()

The complexity only comes with backwards compatibility for the 2-argument variant. With a flag day conversion to 1-arg, there isn't really any additional complexity.

OK. Then I would vote for a flag day.

and, for example, in the case of the SCTP source, which are shared with other BSD like platforms which don't make that change,

That seems like a self-inflicted SCTP problem. If SCTP is not native FreeBSD software, maybe it shouldn't live in the tree. If it is, it should not stand in the way of FreeBSD refactoring. It could use a trivial compatibility definition ifndef FreeBSD.

It is just a problem of supporting multiple platforms with the same code. But it can be handled by #ifdefs. And I agree, it should not stand in the way of generic code evolution.

we have to provide a way to do it still the old way. I guess, I have to replace mtod() by SCTP_MTOD() with the 2 argument semantic in the SCTP sources and then make platform specific definitions: On FreeBSD, call your version and do the explicit cast, on the other platforms just call mtod().

I don't think it's as complicated as that.

OK. Maybe I find an easier way.

Another point is that these mechanical global changes might make MFCing code harder...

Yes, that's true. That's what the complex definition is for. It helps, but does not remove merge conflicts.

So in my view, there is a price to pay. So I would like to understand what we gain.

If it doesn't make sense to you I don't think I can help you with that.

I'm not saying that it doesn't make sense. I just wanted to know what you think is the gain.

I think we should move away from these kinds of macros generally, and the gigantic functions we tend to have as well, but I don't see much enthusiasm in networking for that kind of thing. So I guess I'll butt out.

I think these are two points:

  • macros involving type casts
  • gigantic functions

I guess the first can be solved by small steps. The second is harder to not introduce regressions, but they are independent. Or am I missing something?

Thu, May 14, 9:44 PM
tuexen accepted D24826: Hung sessions.
Thu, May 14, 6:09 PM

Wed, May 13

tuexen added a comment to D24826: Hung sessions.

Except for the whitespace issue, I'm fine with it.

Wed, May 13, 5:11 PM

Mon, May 11

tuexen committed rS360942: Fix a copy and paste error introduced in r360878..
Fix a copy and paste error introduced in r360878.
Mon, May 11, 10:47 PM

Sun, May 10

tuexen committed rS360885: Ensure that the SCTP iterator runs with an stcb and inp, which belong to.
Ensure that the SCTP iterator runs with an stcb and inp, which belong to
Sun, May 10, 10:54 PM
tuexen committed rS360879: Remove trailing whitespace..
Remove trailing whitespace.
Sun, May 10, 5:44 PM
tuexen committed rS360878: Ensure that we have a path when starting the T3 RXT timer..
Ensure that we have a path when starting the T3 RXT timer.
Sun, May 10, 5:19 PM
tuexen committed rS360869: Only drop DATA chunk with lower priorities as specified in RFC 7496..
Only drop DATA chunk with lower priorities as specified in RFC 7496.
Sun, May 10, 10:03 AM

Thu, May 7

tuexen accepted D24747: Responding properly to SYN-ACK.
Thu, May 7, 1:48 PM
tuexen committed rS360772: MFC r360671: Avoid integer underflow.
MFC r360671: Avoid integer underflow
Thu, May 7, 3:50 AM
tuexen committed rS360771: MFC r360662: Fix a bug in SCTP SACK generation.
MFC r360662: Fix a bug in SCTP SACK generation
Thu, May 7, 3:49 AM
tuexen committed rS360770: MFC r360193, r360209: Improve input validation ofor AUTH chunks.
MFC r360193, r360209: Improve input validation ofor AUTH chunks
Thu, May 7, 3:44 AM
tuexen committed rS360769: MFC r359131: Fix MTU candidates.
MFC r359131: Fix MTU candidates
Thu, May 7, 3:37 AM
tuexen committed rS360768: MFC r358621:.
MFC r358621:
Thu, May 7, 3:29 AM
tuexen committed rS360767: MFC r358169: Remove an unused timer type..
MFC r358169: Remove an unused timer type.
Thu, May 7, 3:27 AM
tuexen committed rS360766: MFC r358028: Fix SCTP stream scheduler bug.
MFC r358028: Fix SCTP stream scheduler bug
Thu, May 7, 3:24 AM
tuexen committed rS360765: MFC r358023: Don't use uninitialized memory.
MFC r358023: Don't use uninitialized memory
Thu, May 7, 3:23 AM
tuexen committed rS360764: MFC r357830: Improve handling of memory allocation failure.
MFC r357830: Improve handling of memory allocation failure
Thu, May 7, 3:20 AM
tuexen committed rS360763: MFC r357768: Optimize timer starting.
MFC r357768: Optimize timer starting
Thu, May 7, 3:18 AM
tuexen committed rS360762: MFC r357708: More timer cleanups.
MFC r357708: More timer cleanups
Thu, May 7, 3:16 AM
tuexen committed rS360761: MFC r357705: Cleanup timer handling.
MFC r357705: Cleanup timer handling
Thu, May 7, 3:14 AM
tuexen committed rS360760: MFC r357501: Remote unused timer..
MFC r357501: Remote unused timer.
Thu, May 7, 3:12 AM
tuexen committed rS360759: MFC r357500: Improve dubug information.
MFC r357500: Improve dubug information
Thu, May 7, 3:08 AM
tuexen committed rS360758: MFC r356660: Avoid division by zero.
MFC r356660: Avoid division by zero
Thu, May 7, 3:01 AM
tuexen committed rS360757: MFC r356378: Improve SCTP iterator.
MFC r356378: Improve SCTP iterator
Thu, May 7, 2:57 AM
tuexen committed rS360756: MFC r356377: Improve consistency.
MFC r356377: Improve consistency
Thu, May 7, 2:55 AM
tuexen committed rS360755: MFC r356376: Fix SCTP iterator issue.
MFC r356376: Fix SCTP iterator issue
Thu, May 7, 2:53 AM
tuexen committed rS360754: MFC r356271: Whitespace change.
MFC r356271: Whitespace change
Thu, May 7, 2:47 AM
tuexen committed rS360753: MFC r356270: Improve input validation.
MFC r356270: Improve input validation
Thu, May 7, 2:45 AM
tuexen committed rS360752: MFC r355931: Improve input validation.
MFC r355931: Improve input validation
Thu, May 7, 2:40 AM
tuexen committed rS360751: MFC r355265: Restart RTT measurement.
MFC r355265: Restart RTT measurement
Thu, May 7, 2:35 AM
tuexen committed rS360750: MFC r355264: Handle PTB message consistent for SCTP/IPv[46].
MFC r355264: Handle PTB message consistent for SCTP/IPv[46]
Thu, May 7, 2:31 AM
tuexen committed rS360749: MFC r355172: Ignore assoc IDs on 1-to-1 style SCTP sockets..
MFC r355172: Ignore assoc IDs on 1-to-1 style SCTP sockets.
Thu, May 7, 2:28 AM
tuexen committed rS360748: MFC r355135: Plug memory leaks.
MFC r355135: Plug memory leaks
Thu, May 7, 2:26 AM
tuexen committed rS360747: MFC r353452: Improve remote address scanning in SCTP.
MFC r353452: Improve remote address scanning in SCTP
Thu, May 7, 2:18 AM
tuexen committed rS360746: MFC r353303: Improve SCTP packet handling.
MFC r353303: Improve SCTP packet handling
Thu, May 7, 2:16 AM
tuexen committed rS360745: MFC r353145: Plump a memory leak.
MFC r353145: Plump a memory leak
Thu, May 7, 2:13 AM
tuexen committed rS360744: MFC r353123: Fix use afterfreee..
MFC r353123: Fix use afterfreee.
Thu, May 7, 2:10 AM
tuexen committed rS360743: MFC r353122: Plump memory leak.
MFC r353122: Plump memory leak
Thu, May 7, 2:08 AM
tuexen committed rS360742: MFC r353119: Fix padding of COOKIE_ECHO chunks.
MFC r353119: Fix padding of COOKIE_ECHO chunks
Thu, May 7, 2:07 AM
tuexen committed rS360741: MFC r353071: Improve address parsing.
MFC r353071: Improve address parsing
Thu, May 7, 2:03 AM
tuexen committed rS360740: MFC r353069: add required padding when sending ASCONF-ACK.
MFC r353069: add required padding when sending ASCONF-ACK
Thu, May 7, 2:01 AM
tuexen committed rS360739: MFC r353060: Improve input validation.
MFC r353060: Improve input validation
Thu, May 7, 1:57 AM
tuexen committed rS360738: MFC r352894: Don't use uninitialized memory..
MFC r352894: Don't use uninitialized memory.
Thu, May 7, 1:55 AM
tuexen committed rS360737: MFC r352652: Fix memory leak.
MFC r352652: Fix memory leak
Thu, May 7, 1:43 AM
tuexen committed rS360736: MFC r352594: Improve SCTP locking.
MFC r352594: Improve SCTP locking
Thu, May 7, 1:38 AM
tuexen committed rS360735: MFC r352592:.
MFC r352592:
Thu, May 7, 1:35 AM
tuexen committed rS360734: MFC r352550: Fix invalid handling of ASCONF chunks.
MFC r352550: Fix invalid handling of ASCONF chunks
Thu, May 7, 1:31 AM
tuexen committed rS360733: MFC r352511: Improve IPv6 handling over the loopback interface.
MFC r352511: Improve IPv6 handling over the loopback interface
Thu, May 7, 1:29 AM
tuexen committed rS360732: MFC r351655: Fix initialization of top_fsn..
MFC r351655: Fix initialization of top_fsn.
Thu, May 7, 1:16 AM
tuexen committed rS360731: MFC r351654: Improve handling of cookie parameters in INIT-ACK chunks.
MFC r351654: Improve handling of cookie parameters in INIT-ACK chunks
Thu, May 7, 1:13 AM
tuexen committed rS360730: MFC r351641: Improve function definition..
MFC r351641: Improve function definition.
Thu, May 7, 1:09 AM
tuexen committed rS360729: MFC r351638: Improve handling DATA chunks..
MFC r351638: Improve handling DATA chunks.
Thu, May 7, 1:07 AM
tuexen committed rS360728: MFC r350745: Fix typo..
MFC r350745: Fix typo.
Thu, May 7, 12:56 AM
tuexen committed rS360727: MFC r350626: Fix a locking issue in SCTP.
MFC r350626: Fix a locking issue in SCTP
Thu, May 7, 12:51 AM
tuexen committed rS360726: MFC r350625: Improve compilation on 32-bit OS/.
MFC r350625: Improve compilation on 32-bit OS/
Thu, May 7, 12:44 AM
tuexen committed rS360725: MFC r350520: Fix reporting of unknown paramters in an INIT chunk.
MFC r350520: Fix reporting of unknown paramters in an INIT chunk
Thu, May 7, 12:26 AM