tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (101 w, 6 d)

Recent Activity

Today

tuexen committed rS328081: Add missing assignment to make sure non-first cmsgs are handled as such..
Add missing assignment to make sure non-first cmsgs are handled as such.
Wed, Jan 17, 10:31 AM

Yesterday

tuexen committed rS328066: Fix a bug related to fast retransmissions..
Fix a bug related to fast retransmissions.
Tue, Jan 16, 9:58 PM
tuexen committed rS328059: Improve the printing of cmgs when the length is 0. Fix error handling..
Improve the printing of cmgs when the length is 0. Fix error handling.
Tue, Jan 16, 8:02 PM
tuexen committed rS328058: Using %p already prints "0x", so don't do it explicitly..
Using %p already prints "0x", so don't do it explicitly.
Tue, Jan 16, 7:57 PM

Mon, Jan 15

tuexen committed rS328034: Keep list sorted. Thanks to jhb@ to pointing out that I put it at the.
Keep list sorted. Thanks to jhb@ to pointing out that I put it at the
Mon, Jan 15, 11:17 PM
tuexen committed rS328033: Bump date, which I missed in r328014. Thanks to jhb@ for reporting..
Bump date, which I missed in r328014. Thanks to jhb@ for reporting.
Mon, Jan 15, 11:13 PM
tuexen committed rS328028: Don't provide a (meaningless) cmsg when proving a notification.
Don't provide a (meaningless) cmsg when proving a notification
Mon, Jan 15, 9:59 PM
tuexen committed rS328015: Decode msghdr argument of sendmsg() and recvmsg()..
Decode msghdr argument of sendmsg() and recvmsg().
Mon, Jan 15, 8:39 PM
tuexen committed rS328014: Add support for decoding the nxt_flags, rcv_flags, and snd_flags of.
Add support for decoding the nxt_flags, rcv_flags, and snd_flags of
Mon, Jan 15, 8:37 PM
tuexen committed rS327995: Add support for decoding the type of a cmsg..
Add support for decoding the type of a cmsg.
Mon, Jan 15, 10:59 AM
tuexen committed rS327994: Simplify table generation..
Simplify table generation.
Mon, Jan 15, 8:33 AM

Sun, Jan 14

tuexen committed rS327967: Improve support for sctp_generic_recvmsg() and sctp_generic_sendmsg().
Improve support for sctp_generic_recvmsg() and sctp_generic_sendmsg()
Sun, Jan 14, 2:33 PM
tuexen committed rS327966: Add a function is decode the sinfo_flags of struct sctp_sndrcvinfo..
Add a function is decode the sinfo_flags of struct sctp_sndrcvinfo.
Sun, Jan 14, 2:27 PM
tuexen committed rS327962: Add suppor for the supported PR-SCTP policies..
Add suppor for the supported PR-SCTP policies.
Sun, Jan 14, 12:08 PM
tuexen committed rS327961: Mark the iovec parameters of writev() and readv() as IN and OUT..
Mark the iovec parameters of writev() and readv() as IN and OUT.
Sun, Jan 14, 9:51 AM

Sat, Jan 13

tuexen committed rS327921: Fix a typo introduced in r327919..
Fix a typo introduced in r327919.
Sat, Jan 13, 2:11 PM
tuexen committed rS327919: Add support for readv() and writev() to truss..
Add support for readv() and writev() to truss.
Sat, Jan 13, 1:59 PM

Thu, Jan 11

tuexen closed D13670: Make dtraceall loadable again on arm64.
Thu, Jan 11, 9:17 PM
tuexen committed rS327846: Build systrace_freebsd32 on arm64..
Build systrace_freebsd32 on arm64.
Thu, Jan 11, 9:17 PM
tuexen closed D13652: Set vnet when calling pru_sockaddr and pru_peeraddr.
Thu, Jan 11, 8:26 PM
tuexen committed rS327844: Ensure that the vnet is set when calling pru_sockaddr() and.
Ensure that the vnet is set when calling pru_sockaddr() and
Thu, Jan 11, 8:26 PM

Tue, Jan 2

tuexen added a comment to D13718: TCP Fast Open (TFO) [RFC7413] Client-side Implementation.

Regarding enable versus enabled, here is what I was referring to:

Tue, Jan 2, 6:38 PM

Mon, Jan 1

tuexen added a comment to D13718: TCP Fast Open (TFO) [RFC7413] Client-side Implementation.

I agree with hiren... Splitting this up in three patch sets makes a lot of sense and makes the review much simpler. While doing that, you could also change the name of the sysctl variables net.inet.tcp.fastopen.server_enabled to net.inet.tcp.fastopen.server_enable and net.inet.tcp.fastopen.client_enabled to net.inet.tcp.fastopen.client_enable to be consistent with other sysctl variables controlling the usage of features.

Mon, Jan 1, 8:24 AM

Thu, Dec 28

tuexen created D13670: Make dtraceall loadable again on arm64.
Thu, Dec 28, 8:18 PM
tuexen added a comment to D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

I'll bring this up on todays transport telco...

Thu, Dec 28, 4:11 PM

Wed, Dec 27

tuexen created D13652: Set vnet when calling pru_sockaddr and pru_peeraddr.
Wed, Dec 27, 2:51 PM

Tue, Dec 26

tuexen committed rS327214: White cleanups..
White cleanups.
Tue, Dec 26, 4:34 PM
tuexen committed rS327209: Clearify CID 1008197..
Clearify CID 1008197.
Tue, Dec 26, 4:12 PM
tuexen committed rS327208: Clearify issue reported in CID 1008198..
Clearify issue reported in CID 1008198.
Tue, Dec 26, 4:06 PM
tuexen committed rS327206: Fix CID 1008428..
Fix CID 1008428.
Tue, Dec 26, 3:29 PM
tuexen committed rS327205: Fix CID 1008936..
Fix CID 1008936.
Tue, Dec 26, 3:24 PM
tuexen committed rS327203: Allow the first (and second) argument of sn_calloc() be a sum..
Allow the first (and second) argument of sn_calloc() be a sum.
Tue, Dec 26, 2:38 PM
tuexen added a comment to D13594: ipfw SCTP grew accidental dependency on full options SCTP stack.

Hi Kevin,

Tue, Dec 26, 12:37 PM
tuexen committed rS327200: When adding support for sending SCTP packets containing an ABORT chunk.
When adding support for sending SCTP packets containing an ABORT chunk
Tue, Dec 26, 12:35 PM

Sat, Dec 23

tuexen added a comment to D13594: ipfw SCTP grew accidental dependency on full options SCTP stack.

Hi Kevin,

Sat, Dec 23, 7:35 AM

Dec 17 2017

tuexen added a member for transport: tuexen.
Dec 17 2017, 7:24 PM
tuexen added a comment to D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

I can provide a better description. Please note the the tcp6_usr_bind() has already the similar code:
https://svnweb.freebsd.org/base/head/sys/netinet/tcp_usrreq.c?revision=326023&view=markup#l367
and this was not changed recently.

Dec 17 2017, 7:23 PM

Dec 16 2017

tuexen created D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.
Dec 16 2017, 4:42 PM

Dec 13 2017

tuexen committed rS326829: Cleaup, no functional change..
Cleaup, no functional change.
Dec 13 2017, 5:12 PM

Dec 7 2017

tuexen committed rS326672: Retire SCTP_WITH_NO_CSUM option..
Retire SCTP_WITH_NO_CSUM option.
Dec 7 2017, 10:19 PM
tuexen added a comment to D13409: Fix the amd64 LINT build.

Great. Will fix that later today. I'm right now not able to commit things... Thanks for the notice.

Dec 7 2017, 4:46 PM
tuexen added a comment to D13409: Fix the amd64 LINT build.

That doesn't make sense, since SCTP_WITH_NO_CSUM was introduced ages ago just to test how the performance is with checksum offloading. Not computing the checksum in ipfw doesn't make sense...
I suggest that I will just retire SCTP_WITH_NO_CSUM in the source tree. Would that be acceptable?

Dec 7 2017, 4:36 PM

Nov 26 2017

tuexen added a comment to D13239: Add support for ABORT action in ipfw.

Thanks to bcr@ and ae@ for reviewing this patch so fast!

Nov 26 2017, 6:20 PM
tuexen committed rS326233: Add to ipfw support for sending an SCTP packet containing an ABORT chunk..
Add to ipfw support for sending an SCTP packet containing an ABORT chunk.
Nov 26 2017, 6:19 PM
tuexen closed D13239: Add support for ABORT action in ipfw.
Nov 26 2017, 6:19 PM
tuexen updated the diff for D13239: Add support for ABORT action in ipfw.

Address comments made by bcr@ and ae@.

Nov 26 2017, 6:09 PM

Nov 25 2017

tuexen created D13239: Add support for ABORT action in ipfw.
Nov 25 2017, 3:06 PM

Nov 24 2017

tuexen committed rS326180: Fix SPDX line as suggested by pfg.
Fix SPDX line as suggested by pfg
Nov 24 2017, 7:39 PM
tuexen committed rS326163: Unbreak compilation when using SCTP_DETAILED_STR_STATS option..
Unbreak compilation when using SCTP_DETAILED_STR_STATS option.
Nov 24 2017, 12:19 PM
tuexen committed rS326154: Add SPDX line..
Add SPDX line.
Nov 24 2017, 11:26 AM

Nov 15 2017

tuexen committed rS325864: Fix the handling of ERROR chunks which a lot of error causes..
Fix the handling of ERROR chunks which a lot of error causes.
Nov 15 2017, 10:13 PM

Nov 14 2017

tuexen committed rS325788: Simply the code and use the full buffer for contigous chunk representation..
Simply the code and use the full buffer for contigous chunk representation.
Nov 14 2017, 2:30 AM

Nov 12 2017

tuexen committed rS325746: Cleanup the handling of control chunks. While there fix some minor.
Cleanup the handling of control chunks. While there fix some minor
Nov 12 2017, 9:43 PM

Nov 5 2017

tuexen committed rS325434: Fix an accounting bug where data was counted twice if on the read.
Fix an accounting bug where data was counted twice if on the read
Nov 5 2017, 12:00 PM

Nov 3 2017

tuexen committed rS325370: Allow the setting of the MTU for future paths using an SCTP socket option..
Allow the setting of the MTU for future paths using an SCTP socket option.
Nov 3 2017, 8:46 PM

Nov 1 2017

tuexen committed rS325284: Fix the reporting of the MTU for SCTP sockets when using IPv6..
Fix the reporting of the MTU for SCTP sockets when using IPv6.
Nov 1 2017, 4:32 PM

Oct 27 2017

tuexen committed rS325046: Fix parsing error when processing cmsg in SCTP send calls. Thei bug is.
Fix parsing error when processing cmsg in SCTP send calls. Thei bug is
Oct 27 2017, 7:27 PM

Oct 25 2017

tuexen committed rS324971: Fix a bug reported by Felix Weinrank using the libfuzzer on the.
Fix a bug reported by Felix Weinrank using the libfuzzer on the
Oct 25 2017, 9:12 AM

Oct 24 2017

tuexen committed rS324958: Fix a bug in handling special ABORT chunks..
Fix a bug in handling special ABORT chunks.
Oct 24 2017, 4:24 PM
tuexen committed rS324954: Fix a locking issue found by running AFL on the userland stack..
Fix a locking issue found by running AFL on the userland stack.
Oct 24 2017, 2:29 PM

Oct 18 2017

tuexen committed rS324730: Fix a signed/unsigned warning..
Fix a signed/unsigned warning.
Oct 18 2017, 9:08 PM
tuexen committed rS324729: Abort an SCTP association, when a DATA chunk is followed by an unknown.
Abort an SCTP association, when a DATA chunk is followed by an unknown
Oct 18 2017, 8:17 PM
tuexen committed rS324726: Revert change which got in accidently..
Revert change which got in accidently.
Oct 18 2017, 6:59 PM
tuexen committed rS324725: Fix a bug introduced in r324638..
Fix a bug introduced in r324638.
Oct 18 2017, 6:57 PM

Oct 17 2017

tuexen committed rS324686: MFC r322648:.
MFC r322648:
Oct 17 2017, 12:42 PM

Oct 15 2017

tuexen committed rS324638: Fix the handling of parital and too short chunks..
Fix the handling of parital and too short chunks.
Oct 15 2017, 7:33 PM

Oct 14 2017

tuexen committed rS324615: Code cleanup, not functional change..
Code cleanup, not functional change.
Oct 14 2017, 10:03 AM

Oct 5 2017

tuexen committed rS324317: Ensure that the accept ABORT chunks with the T-bit set only the.
Ensure that the accept ABORT chunks with the T-bit set only the
Oct 5 2017, 1:30 PM

Oct 2 2017

tuexen committed rS324218: Whitespace changes: Remove leading spaces followed by a tab..
Whitespace changes: Remove leading spaces followed by a tab.
Oct 2 2017, 8:02 PM
tuexen committed rS324216: Fix a bug which avoided that rules for matching port numbers for SCTP.
Fix a bug which avoided that rules for matching port numbers for SCTP
Oct 2 2017, 6:25 PM

Sep 30 2017

tuexen committed rS324122: Fix reporting of probing size. This bug was introduced in r324119..
Fix reporting of probing size. This bug was introduced in r324119.
Sep 30 2017, 12:30 PM
tuexen committed rS324120: Add SCTP and TCP as protocols for sending probe packets..
Add SCTP and TCP as protocols for sending probe packets.
Sep 30 2017, 11:45 AM
tuexen committed rS324119: * Update function definitions..
* Update function definitions.
Sep 30 2017, 11:40 AM

Sep 27 2017

tuexen committed rS324056: Remove unused function..
Remove unused function.
Sep 27 2017, 1:05 PM

Sep 26 2017

tuexen accepted D12430: tcp: Don't "negotiate" MSS..
Sep 26 2017, 4:07 AM

Sep 25 2017

tuexen added a comment to D12430: tcp: Don't "negotiate" MSS..

For what it is worth:

Sep 25 2017, 9:15 PM
tuexen added a comment to D12430: tcp: Don't "negotiate" MSS..

Shouldn't we also apply something like

 	/* Map our computed MSS into the 3-bit index. */
-	mss = min(tcp_mssopt(&sc->sc_inc), max(sc->sc_peer_mss, V_tcp_minmss));
+	mss = sc->sc_peer_mss;
 	for (i = nitems(tcp_sc_msstab) - 1; tcp_sc_msstab[i] > mss && i > 0;
 	     i--)
 		;

since we will use the computed index to restore the sc->sc_peer_mss later.

Sep 25 2017, 9:12 PM
tuexen added a comment to D12430: tcp: Don't "negotiate" MSS..

I think it is good to be standards compliant. It helps in case of suboptimal middleboxes likes the ones described by sepherosa which relatively decrement the MSS instead of enforcing a maximum. The benefit is the use larger segments which should improve the performance (less overhead).

Sep 25 2017, 6:18 PM
tuexen added a comment to D12430: tcp: Don't "negotiate" MSS..

Hi Jason,

Sep 25 2017, 3:02 PM

Sep 24 2017

tuexen added a reviewer for D12430: tcp: Don't "negotiate" MSS.: tuexen.
Sep 24 2017, 8:25 AM

Sep 22 2017

tuexen committed rS323904: Add missing locking. Found by Coverity while scanning the usrsctp.
Add missing locking. Found by Coverity while scanning the usrsctp
Sep 22 2017, 6:33 AM
tuexen committed rS323902: Add missing socket lock..
Add missing socket lock.
Sep 22 2017, 6:07 AM

Sep 21 2017

tuexen committed rS323861: Code cleanup, no functional change..
Code cleanup, no functional change.
Sep 21 2017, 11:56 AM
tuexen committed rS323850: Free the control structure after using is, not before..
Free the control structure after using is, not before.
Sep 21 2017, 9:48 AM
tuexen committed rS323847: No need to wakeup, since sctp_add_to_readq() does it..
No need to wakeup, since sctp_add_to_readq() does it.
Sep 21 2017, 9:18 AM

Sep 20 2017

tuexen committed rS323833: Protect the address workqueue timer by a mutex..
Protect the address workqueue timer by a mutex.
Sep 20 2017, 9:30 PM

Sep 19 2017

tuexen committed rS323776: Fix a warning..
Fix a warning.
Sep 19 2017, 8:24 PM
tuexen committed rS323774: Avoid an overflow when computing the staleness..
Avoid an overflow when computing the staleness.
Sep 19 2017, 8:10 PM
tuexen committed rS323763: Remove a no longer used variable..
Remove a no longer used variable.
Sep 19 2017, 3:00 PM

Sep 17 2017

tuexen committed rS323670: Fix an accounting bug and use sctp_timer_start to start a timer..
Fix an accounting bug and use sctp_timer_start to start a timer.
Sep 17 2017, 9:27 AM

Sep 16 2017

tuexen committed rS323657: Remove code not used on any platform currently supported..
Remove code not used on any platform currently supported.
Sep 16 2017, 9:26 PM

Sep 15 2017

tuexen committed rS323628: Remove tailing whitespace..
Remove tailing whitespace.
Sep 15 2017, 8:47 PM
tuexen committed rS323627: Remove empty line accidently introduced in r323626..
Remove empty line accidently introduced in r323626.
Sep 15 2017, 8:41 PM
tuexen committed rS323626: Add references. Suggested by Maxim Konovalov..
Add references. Suggested by Maxim Konovalov.
Sep 15 2017, 8:35 PM

Sep 14 2017

tuexen committed rS323599: Bump date missed in r323596. Trim trailing whitespace..
Bump date missed in r323596. Trim trailing whitespace.
Sep 14 2017, 8:42 PM
tuexen committed rS323596: Add a description how tcpdrop handles the case of specifying the.
Add a description how tcpdrop handles the case of specifying the
Sep 14 2017, 6:50 PM

Sep 13 2017

tuexen committed rS323521: Add a command line option for using a wider field for displaying.
Add a command line option for using a wider field for displaying
Sep 13 2017, 6:58 AM

Sep 12 2017

tuexen committed rS323507: Add support for printing the path state for SCTP association..
Add support for printing the path state for SCTP association.
Sep 12 2017, 9:36 PM
tuexen committed rS323505: Export the UDP encapsualation port and the path state..
Export the UDP encapsualation port and the path state.
Sep 12 2017, 9:09 PM
tuexen committed rS323504: Add printing of the remote encapsulation port for SCTP associations..
Add printing of the remote encapsulation port for SCTP associations.
Sep 12 2017, 9:08 PM