User Details
- User Since
- Feb 4 2016, 4:45 PM (263 w, 6 d)
Sun, Feb 21
Sat, Feb 20
Thu, Feb 18
This fixes actually a bug. With this patch the following packetdrill runs successfully:
0.000 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0.000 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0 +0.000 bind(3, ..., ...) = 0 +0.000 setsockopt(3, SOL_SOCKET, SO_LINGER, {onoff=1, linger=0}, 8) = 0 +0.000 listen(3, 1) = 0 +0.000 < S 0:0(0) win 65535 <mss 1460,sackOK,eol,eol> +0.000 > S. 0:0(0) ack 1 win 65535 <mss 1460,sackOK,eol,eol> +0.000 < . 1:1(0) ack 1 win 65535 +0.000 accept(3, ..., ...) = 4 +0.000 close(3) = 0 +0.000 getsockopt(4, SOL_SOCKET, SO_LINGER, {onoff=128, linger=0}, [8]) = 0 +0.000 close(4) = 0 +0.000 > R. 1:1(0) ack 1 win 0
Thanks for finding the bug and fixing it.
Tue, Feb 16
Let me have a look into it tomorrow. I agree, it looks strange.
Any chance to have a more specific name than newsack?
Mon, Feb 15
Let's discuss this at the next Transport call...
My understanding is that if net.inet.tcp.fastpath.acceptany is set, all cookies are excepted. This includes empty cookies as mentioned in RFC 7413.
Sun, Feb 14
The above modifications are necessary in combination with D28656 to allow the following packetdrill script to run successfully:
0.00 `sysctl -w net.inet.tcp.hostcache.purgenow=1` +0.00 `sysctl -w net.inet.tcp.syncookies_only=0` +0.00 `sysctl -w net.inet.tcp.syncookies=1` +0.00 `sysctl -w net.inet.tcp.rfc1323=1` +0.00 `sysctl -w net.inet.tcp.sack.enable=1` +0.00 `sysctl -w net.inet.tcp.ecn.enable=2`
Sat, Feb 13
Tue, Feb 9
Mon, Feb 1
Sun, Jan 31
Thu, Jan 28
Please consider MFC'ing to stable/13.
Wed, Jan 27
Let us discuss this on the bi-weekly transport call... I'm not convinced that the gain you get from this is higher than the risk to run into bugs on peer implementations.
I tested the patch. It fixes: panic: pfi_dynaddr_setup: non-NULL dyn (2).
Jan 25 2021
I would suggest to separate the whitspace changes and the functional changes into two commits.
Jan 24 2021
Maybe mm@ can test this?
Jan 21 2021
Can you describe how one can hit the code you are suggesting to be removed?
Jan 14 2021
Committed in cc3c34859eab1b317d0f38731355b53f7d978c97.
Committed in d2b3ceddccac60b563f642898e3a314647666a10.
Rebase.
Jan 13 2021
Jan 9 2021
Jan 8 2021
Address jhb's comments.
Jan 4 2021
Jan 1 2021
Dec 22 2020
Dec 21 2020
I guess you need a similar dance (for 16-bit) in pf_normalize_tcpopt() when updating the MSS.
Dec 18 2020
Dec 15 2020
Dec 14 2020
Dec 13 2020
Dec 12 2020
Dec 10 2020
Dec 6 2020
Dec 3 2020
When committing, please add a reference to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251540
It fixes the issue. For SCTP we would need something like sctpdrop. I can try to add that...