Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (148 w, 3 d)

Recent Activity

Tue, Dec 4

tuexen committed rS341506: MFC r339042:.
MFC r339042:
Tue, Dec 4, 10:54 PM
tuexen committed rS341504: MFC r339989, r339991:.
MFC r339989, r339991:
Tue, Dec 4, 10:47 PM
tuexen committed rS341503: MFC r341335:.
MFC r341335:
Tue, Dec 4, 10:27 PM
tuexen committed rS341502: MFC r341335:.
MFC r341335:
Tue, Dec 4, 10:19 PM
tuexen committed rS341501: MFC r340782:.
MFC r340782:
Tue, Dec 4, 10:15 PM
tuexen committed rS341500: MFC r340781:.
MFC r340781:
Tue, Dec 4, 10:15 PM
tuexen committed rS341499: MFC r340777:.
MFC r340777:
Tue, Dec 4, 10:12 PM
tuexen committed rS341498: MFC r340774:.
MFC r340774:
Tue, Dec 4, 10:12 PM
tuexen committed rS341497: MFC r340738:.
MFC r340738:
Tue, Dec 4, 10:08 PM

Fri, Nov 30

tuexen closed D18366: Limit option_len for the TCP_CCALGOOPT option.
Fri, Nov 30, 10:52 AM
tuexen committed rS341335: Limit option_len for the TCP_CCALGOOPT..
Limit option_len for the TCP_CCALGOOPT.
Fri, Nov 30, 10:51 AM

Thu, Nov 29

tuexen added a reviewer for D18366: Limit option_len for the TCP_CCALGOOPT option: bz.
Thu, Nov 29, 5:19 PM
tuexen added a comment to D18375: Improve receive window autoscaling for TCP.

Only nit in the comment to this patch:

  • 2. the number of bytes received during 1/2 of an sRTT
  • is equal to 1/2 of the current socket buffer size.

    Should be
  • 2. the number of bytes received during 1/2 of an sRTT
  • is equal to 3/8 of the current socket buffer size.

    from tp->rfbuf_cnt > ((so->so_rcv.sb_hiwat / 2)/ 4 * 3)

    Also,
  • This algorithm does one step per RTT at most and only if

    should be
  • This algorithm does two steps per RTT at most and only if

    correct?

Yepp. I changed the comments to address your comments.

The increase by slightly more than 50% of the (effective) old rwnd twice per RTT, since it's triggered at the 3/8 point, can indeed keep up with slowstart.

Thu, Nov 29, 3:52 PM
tuexen updated the diff for D18375: Improve receive window autoscaling for TCP.

Address Richard's comments.

Thu, Nov 29, 3:52 PM
tuexen added a reviewer for D18375: Improve receive window autoscaling for TCP: rscheff_gmx.at.
Thu, Nov 29, 11:05 AM
tuexen created D18375: Improve receive window autoscaling for TCP.
Thu, Nov 29, 9:11 AM

Wed, Nov 28

tuexen added a comment to D14599: Implement kernel code coverage (kcov).

Is it possible to make progress? I would really love to see a kcov variant committed which can be used by syzkaller...

Wed, Nov 28, 6:06 PM
tuexen created D18366: Limit option_len for the TCP_CCALGOOPT option.
Wed, Nov 28, 10:46 AM

Thu, Nov 22

tuexen accepted D18301: Plug networking sysctl leaks..
Thu, Nov 22, 8:08 PM
tuexen committed rS340782: A TCP stack is required to check SEG.ACK first, when processing a.
A TCP stack is required to check SEG.ACK first, when processing a
Thu, Nov 22, 8:06 PM
tuexen closed D18034: The TCP RACK stack need to verify SEG.ACK first when in SYS-SENT state.
Thu, Nov 22, 8:06 PM
tuexen closed D18033: TCP RACK stack should honor net.inet.tcp.drop_synfin sysctl variable.
Thu, Nov 22, 8:03 PM
tuexen committed rS340781: Ensure that the TCP RACK stack honours the setting of the.
Ensure that the TCP RACK stack honours the setting of the
Thu, Nov 22, 8:02 PM
tuexen closed D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Thu, Nov 22, 7:57 PM
tuexen committed rS340777: Ensure that the default RTT stack can make an RTT measurement if.
Ensure that the default RTT stack can make an RTT measurement if
Thu, Nov 22, 7:57 PM
tuexen committed rS340774: Ensure that TCP RST-segments announce consistently a receiver window of.
Ensure that TCP RST-segments announce consistently a receiver window of
Thu, Nov 22, 7:50 PM
tuexen closed D17949: Advertise a zero window when sending TCP RST segments via tcp_output().
Thu, Nov 22, 7:50 PM

Wed, Nov 21

tuexen committed rS340738: Improve two KASSERTs in the TCP RACK stack..
Improve two KASSERTs in the TCP RACK stack.
Wed, Nov 21, 6:19 PM
tuexen closed D18021: Improve KASSERTs in rack.c.
Wed, Nov 21, 6:19 PM
tuexen updated the diff for D18021: Improve KASSERTs in rack.c.

Use SEQ_LEQ instead of <= since sequence number arithmetic needs to be used.

Wed, Nov 21, 11:32 AM
tuexen updated the diff for D18021: Improve KASSERTs in rack.c.

Use SEQ_LT instead of <= since sequence number arithmetic is used.

Wed, Nov 21, 11:30 AM

Tue, Nov 20

tuexen added inline comments to D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Tue, Nov 20, 9:14 PM

Sun, Nov 18

tuexen created D18034: The TCP RACK stack need to verify SEG.ACK first when in SYS-SENT state.
Sun, Nov 18, 12:31 PM
tuexen created D18033: TCP RACK stack should honor net.inet.tcp.drop_synfin sysctl variable.
Sun, Nov 18, 12:16 PM
tuexen created D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Sun, Nov 18, 11:36 AM

Sat, Nov 17

tuexen created D18021: Improve KASSERTs in rack.c.
Sat, Nov 17, 8:41 PM

Thu, Nov 15

tuexen committed rS340459: MFC r340361:.
MFC r340361:
Thu, Nov 15, 5:25 PM

Mon, Nov 12

tuexen committed rS340361: Fix printing of 64-bit counters on 32-bit ppc platforms..
Fix printing of 64-bit counters on 32-bit ppc platforms.
Mon, Nov 12, 1:26 PM
tuexen closed D17838: Fix printing of 64-bit counters in systat on 32-bit ppc.
Mon, Nov 12, 1:26 PM

Sun, Nov 11

tuexen created D17949: Advertise a zero window when sending TCP RST segments via tcp_output().
Sun, Nov 11, 7:45 PM

Nov 7 2018

tuexen added a reviewer for D17838: Fix printing of 64-bit counters in systat on 32-bit ppc: transport.
Nov 7 2018, 6:02 PM

Nov 6 2018

tuexen committed rS340179: Don't use a function when neither INET nor INET6 are defined..
Don't use a function when neither INET nor INET6 are defined.
Nov 6 2018, 12:55 PM

Nov 4 2018

tuexen added a reviewer for D17838: Fix printing of 64-bit counters in systat on 32-bit ppc: mr.
Nov 4 2018, 11:21 PM
tuexen created D17838: Fix printing of 64-bit counters in systat on 32-bit ppc.
Nov 4 2018, 11:19 PM

Nov 3 2018

tuexen committed rS340101: MFC r339914:.
MFC r339914:
Nov 3 2018, 8:35 PM

Nov 1 2018

tuexen added inline comments to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Nov 1 2018, 9:01 PM
tuexen committed rS339991: Remove debug code which slipped in accidently..
Remove debug code which slipped in accidently.
Nov 1 2018, 11:42 AM
tuexen added inline comments to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Nov 1 2018, 11:37 AM
tuexen committed rS339989: Improve a comment to refer to the actual sections in the TCP.
Improve a comment to refer to the actual sections in the TCP
Nov 1 2018, 11:35 AM

Oct 31 2018

tuexen added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

@lstewart Could you be more specific what you think is not handled correctly?

@lstewart Found the line you were referring to. Let me check...

Oct 31 2018, 9:44 PM
tuexen added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
In D17595#375876, @bz wrote:

For as much as my brain still functions this seems ok

Question to be ignored: does it also apply to non-default TCP stacks (which I have never looked at)?

Oct 31 2018, 8:35 PM
tuexen added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

@tuexen Any thoughts on the TFO case?

@lstewart Could you be more specific what you think is not handled correctly?

Oct 31 2018, 8:54 AM

Oct 30 2018

tuexen committed rS339914: Bump the number of fans supported from 8 to 12..
Bump the number of fans supported from 8 to 12.
Oct 30 2018, 11:51 AM
tuexen closed D17754: Support up to 12 fans on PowerMacs.
Oct 30 2018, 11:51 AM

Oct 29 2018

tuexen added a reviewer for D17754: Support up to 12 fans on PowerMacs: jhibbits.
Oct 29 2018, 8:46 PM
tuexen committed rS339871: MFC r339869,r339870:.
MFC r339869,r339870:
Oct 29 2018, 8:08 PM
tuexen created D17754: Support up to 12 fans on PowerMacs.
Oct 29 2018, 8:03 PM
tuexen committed rS339870: Insert a .El line accidently committed in r339869..
Insert a .El line accidently committed in r339869.
Oct 29 2018, 7:25 PM
tuexen committed rS339869: Fix a nit.
Fix a nit
Oct 29 2018, 7:15 PM
tuexen committed rS339867: MFC r339791:.
MFC r339791:
Oct 29 2018, 7:02 PM

Oct 26 2018

tuexen closed D3583: Document sysctl MIBs in sctp(4).
Oct 26 2018, 9:04 PM
tuexen committed rS339791: Add initial descriptions for SCTP related MIB variable..
Add initial descriptions for SCTP related MIB variable.
Oct 26 2018, 9:04 PM

Oct 18 2018

tuexen closed D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 7:21 PM
tuexen committed rS339430: The handling of RST segments in the SYN-RCVD state exists in the.
The handling of RST segments in the SYN-RCVD state exists in the
Oct 18 2018, 7:21 PM
tuexen updated the summary of D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 4:11 PM
tuexen updated the summary of D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 4:11 PM

Oct 17 2018

tuexen added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
In D17595#375585, @bz wrote:

Scrolling through it looks OK with cross-checking to the RFCs.
Mostly commenting on the fact that we should get this in before BETA as it does change the kernel KPI.

That is my hope. I could not change the signature of syncache_chkrst(), but it would be better to
include the change. I guess if I can convince people to review it tomorrow, I could try to get it in on Friday.

Hope someone will do the full technical review (want to add lstewart as well?)

Added Lawrence.

Oct 17 2018, 5:41 PM
tuexen added a reviewer for D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path: lstewart.
Oct 17 2018, 5:39 PM
tuexen created D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 17 2018, 8:59 AM

Oct 16 2018

tuexen accepted D17461: truss: handle shm_open's special SHM_ANON value better..
Oct 16 2018, 9:55 AM

Oct 12 2018

tuexen accepted D17525: Move variable into proper block..
Oct 12 2018, 7:30 AM

Oct 10 2018

tuexen accepted D17511: Add stat counter for ipv6 atomic fragments.
Oct 10 2018, 8:28 PM

Oct 8 2018

tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 8 2018, 7:44 PM

Oct 7 2018

tuexen accepted D17457: Teach truss how to display shm_open(2), shm_unlink(2).
Oct 7 2018, 6:21 PM
tuexen committed rS339223: Address the warning regarding duplicate option 'GEOM_PART_GPT' when.
Address the warning regarding duplicate option 'GEOM_PART_GPT' when
Oct 7 2018, 3:54 PM
tuexen closed D17458: Fix warning when configuring kernel.
Oct 7 2018, 3:54 PM
tuexen committed rS339221: Avoid truncating unrecognised parameters when reporting them..
Avoid truncating unrecognised parameters when reporting them.
Oct 7 2018, 3:14 PM
tuexen committed rS339220: Enable TCP Fast Open support for PPC platforms..
Enable TCP Fast Open support for PPC platforms.
Oct 7 2018, 12:56 PM
tuexen closed D17407: Enable TCP Fast Open support on PPC.
Oct 7 2018, 12:56 PM
tuexen created D17458: Fix warning when configuring kernel.
Oct 7 2018, 12:52 PM
tuexen added a comment to D17406: Fix ips_localout counter for SCTP.
In D17406#371337, @ae wrote:

Looking at the how IP_FORWARDING flag is used, I think gif/gre/me interfaces should not use this flag. What you think?

Oct 7 2018, 11:30 AM
tuexen committed rS339219: Ensure that the ips_localout counter is incremented for.
Ensure that the ips_localout counter is incremented for
Oct 7 2018, 11:26 AM
tuexen closed D17406: Fix ips_localout counter for SCTP.
Oct 7 2018, 11:26 AM

Oct 6 2018

tuexen added a comment to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Hi Tom,

Oct 6 2018, 4:59 PM
tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 6 2018, 4:43 PM
tuexen added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 6 2018, 4:36 PM

Oct 4 2018

tuexen created D17407: Enable TCP Fast Open support on PPC.
Oct 4 2018, 2:06 PM
tuexen created D17406: Fix ips_localout counter for SCTP.
Oct 4 2018, 1:41 PM

Oct 3 2018

tuexen committed rS339121: Use strlcpy() instead of strncpy()..
Use strlcpy() instead of strncpy().
Oct 3 2018, 7:35 AM

Oct 1 2018

tuexen committed rS339042: Mitigate providing a timing signal if the COOKIE or AUTH.
Mitigate providing a timing signal if the COOKIE or AUTH
Oct 1 2018, 2:05 PM
tuexen committed rS339040: After allocating chunks set the fields in a consistent way..
After allocating chunks set the fields in a consistent way.
Oct 1 2018, 1:09 PM
tuexen accepted D17357: Convert UDP length to host byte order.
Oct 1 2018, 11:47 AM

Sep 30 2018

tuexen committed rS339028: Plug mbuf leak in the SCTP input path in an error case..
Plug mbuf leak in the SCTP input path in an error case.
Sep 30 2018, 9:54 PM
tuexen committed rS339027: Plug mbuf leaks in the SCTP output path in error cases..
Plug mbuf leaks in the SCTP output path in error cases.
Sep 30 2018, 9:31 PM
tuexen committed rS339024: Fix the handling of ancillary data for SCTP socket. Implement.
Fix the handling of ancillary data for SCTP socket. Implement
Sep 30 2018, 4:21 PM
tuexen accepted D17335: Relax INP_INFO_UNLOCK_ASSERT() assertion in tcp_input() .

Assuming this change is tested somehow...

Sep 30 2018, 12:21 PM
tuexen committed rS339022: Increment the corresponding UDP stats counter (udps_opackets) when.
Increment the corresponding UDP stats counter (udps_opackets) when
Sep 30 2018, 12:16 PM

Sep 29 2018

tuexen committed rS339012: For changing the MTU on tun/tap devices, it should not matter whether it.
For changing the MTU on tun/tap devices, it should not matter whether it
Sep 29 2018, 1:01 PM
tuexen closed D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.
Sep 29 2018, 1:01 PM
tuexen added a comment to D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.
In D17180#369833, @bz wrote:

Ok, I started three times already and got an INTR every time; let me ask the question: why are we doing this all manually here rather than calling the (from here) the generic ioctl to set the MTU and avoid the code duplication?

Sep 29 2018, 9:50 AM