Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (461 w, 5 d)

Recent Activity

Yesterday

tuexen requested review of D48001: icmp: improve INVARIANTS check.
Mon, Dec 9, 4:41 PM

Wed, Dec 4

tuexen added inline comments to D47925: tcp_hpts: refactor the per tcpcb call to either input/output method.
Wed, Dec 4, 9:40 PM

Thu, Nov 21

tuexen added a comment to D44258: ixgbe: Make masks for TCP flag handling during TSO sysctl'able.

@tuexen just a note that the X552 is also using the same middle value as 82599

Thu, Nov 21, 9:49 AM

Sun, Nov 17

tuexen committed rG8caa2f5351de: tcp: define tcp_lro_log() only when TCP_BLACKBOX is defined (authored by tuexen).
tcp: define tcp_lro_log() only when TCP_BLACKBOX is defined
Sun, Nov 17, 6:21 PM
tuexen closed D47401: tcp: don't define and use BBLog function when TCP_BLACKBOX is not defined.
Sun, Nov 17, 6:21 PM

Thu, Nov 14

tuexen accepted D47541: tcp: fix cwnd recalculation during limited transmit.
Thu, Nov 14, 3:24 PM
tuexen accepted D47474: tcp: Use segment size excluding any options for all cwnd calculations.
Thu, Nov 14, 3:24 PM
tuexen accepted D47542: Change the SOCKBUF_LOCK calls to use the more refined SOCK_XXXBUF_LOCK/UNLOCK..
Thu, Nov 14, 8:32 AM
tuexen accepted D47567: tcp: chance SOCKBUF_LOCK calls to SOCK_[RECV|SEND]BUF_LOCK.
Thu, Nov 14, 8:29 AM

Nov 7 2024

tuexen committed rG35874d28c839: sctp: fix debug message (authored by tuexen).
sctp: fix debug message
Nov 7 2024, 9:48 AM
tuexen committed rGa0bc4ec08bef: sctp: improve handling of address changes (authored by tuexen).
sctp: improve handling of address changes
Nov 7 2024, 9:48 AM
tuexen committed rG2a6bd6e37b47: sctp: garbage collect two unused functions (authored by tuexen).
sctp: garbage collect two unused functions
Nov 7 2024, 9:47 AM
tuexen committed rG33197f22b5c5: sctp: editorial cleanup (authored by tuexen).
sctp: editorial cleanup
Nov 7 2024, 9:47 AM
tuexen committed rGbb6af83fe47b: sctp: don't consider the interface name when removing an address (authored by tuexen).
sctp: don't consider the interface name when removing an address
Nov 7 2024, 9:47 AM

Nov 6 2024

tuexen committed rG0e8faabc270f: sctp: fix debug message (authored by tuexen).
sctp: fix debug message
Nov 6 2024, 12:35 PM
tuexen committed rG331db93815af: sctp: improve handling of address changes (authored by tuexen).
sctp: improve handling of address changes
Nov 6 2024, 12:35 PM
tuexen committed rGe3f26ce52b71: sctp: garbage collect two unused functions (authored by tuexen).
sctp: garbage collect two unused functions
Nov 6 2024, 12:34 PM
tuexen committed rG66628552a387: sctp: don't consider the interface name when removing an address (authored by tuexen).
sctp: don't consider the interface name when removing an address
Nov 6 2024, 12:33 PM
tuexen committed rG651772e2219d: sctp: editorial cleanup (authored by tuexen).
sctp: editorial cleanup
Nov 6 2024, 12:32 PM
tuexen committed rG69a31343a464: sctp: fix debug message (authored by tuexen).
sctp: fix debug message
Nov 6 2024, 10:14 AM
tuexen committed rG5616189419f8: sctp: improve handling of address changes (authored by tuexen).
sctp: improve handling of address changes
Nov 6 2024, 10:14 AM
tuexen committed rG1550ba066216: sctp: garbage collect two unused functions (authored by tuexen).
sctp: garbage collect two unused functions
Nov 6 2024, 10:12 AM
tuexen committed rG7fe14d4bb8c0: sctp: don't consider the interface name when removing an address (authored by tuexen).
sctp: don't consider the interface name when removing an address
Nov 6 2024, 10:11 AM
tuexen committed rG107704217b57: sctp: editorial cleanup (authored by tuexen).
sctp: editorial cleanup
Nov 6 2024, 10:11 AM

Nov 5 2024

tuexen closed D47439: tcp: consistently set CWND to MSS in case of SYN/SYN ACK retransmissions.
Nov 5 2024, 10:06 AM
tuexen committed rG625835c8b5e8: tcp: fix the initial CWND when a SYN retransmission happened (authored by tuexen).
tcp: fix the initial CWND when a SYN retransmission happened
Nov 5 2024, 10:06 AM
tuexen added a comment to D47439: tcp: consistently set CWND to MSS in case of SYN/SYN ACK retransmissions.
In D47439#1081965, @cc wrote:

I think you meant the title be:
tcp: consistently set CWND to MSS => tcp: consistently set CWND to 1
in case of SYN/SYN ACK retransmissions => in case of SYN retransmissions

Nov 5 2024, 8:14 AM

Nov 4 2024

tuexen retitled D47439: tcp: consistently set CWND to MSS in case of SYN/SYN ACK retransmissions from tcp: consistently handle CWND in case of SYN/SYN ACK retransmissions to tcp: consistently set CWND to MSS in case of SYN/SYN ACK retransmissions.
Nov 4 2024, 6:47 PM
tuexen requested review of D47439: tcp: consistently set CWND to MSS in case of SYN/SYN ACK retransmissions.
Nov 4 2024, 6:46 PM

Nov 3 2024

tuexen committed rG518a1163d0aa: sctp: fix debug message (authored by tuexen).
sctp: fix debug message
Nov 3 2024, 11:34 AM
tuexen committed rG523913c94371: sctp: improve handling of address changes (authored by tuexen).
sctp: improve handling of address changes
Nov 3 2024, 10:24 AM

Nov 2 2024

tuexen committed rG470a63cde428: sctp: garbage collect two unused functions (authored by tuexen).
sctp: garbage collect two unused functions
Nov 2 2024, 5:59 PM
tuexen added a comment to D47401: tcp: don't define and use BBLog function when TCP_BLACKBOX is not defined.

Wouldn't it be possible to #define tcp_lro_log in a #else of the first block, such that this scattering of #ifdef's throughout the file could be avoided?

#ifdef TCP_BLACKBOX
static void
tcp_lro_log(struct tcpcb *tp, const struct lro_ctrl *lc,
    const struct lro_entry *le, const struct mbuf *m,
    int frm, int32_t tcp_data_len, uint32_t th_seq,
    uint32_t th_ack, uint16_t th_win)
{
:
}
#else
#define tcp_lro_log(tp, lc, le, m, frm, tcp_data_len, th_seq, th_ack, th_win)
#endif
Nov 2 2024, 5:56 PM
tuexen committed rGbf11fdaf0d09: sctp: don't consider the interface name when removing an address (authored by tuexen).
sctp: don't consider the interface name when removing an address
Nov 2 2024, 4:35 PM
tuexen committed rGd839cf2fbb47: sctp: editorial cleanup (authored by tuexen).
sctp: editorial cleanup
Nov 2 2024, 4:04 PM
tuexen requested review of D47401: tcp: don't define and use BBLog function when TCP_BLACKBOX is not defined.
Nov 2 2024, 2:03 PM

Oct 31 2024

tuexen committed rGeac97072d19b: sctp: another cleanup (authored by tuexen).
sctp: another cleanup
Oct 31 2024, 5:07 PM
tuexen committed rGc274b69f43cc: sctp: cleanup the addition of addresses which are already known (authored by tuexen).
sctp: cleanup the addition of addresses which are already known
Oct 31 2024, 5:06 PM
tuexen committed rG03de3fc2ca00: sctp: further cleanup (authored by tuexen).
sctp: further cleanup
Oct 31 2024, 5:06 PM
tuexen committed rGf735547b21a0: sctp garbage collect sctp_update_ifn_mtu (authored by tuexen).
sctp garbage collect sctp_update_ifn_mtu
Oct 31 2024, 5:04 PM
tuexen committed rG76c6a76ea1dd: sctp: cleanup (authored by tuexen).
sctp: cleanup
Oct 31 2024, 5:03 PM
tuexen committed rGc7f2035e1fc4: sctp: improve debug output (authored by tuexen).
sctp: improve debug output
Oct 31 2024, 5:02 PM
tuexen committed rG88dfcee5521a: sctp: check locking requirements (authored by tuexen).
sctp: check locking requirements
Oct 31 2024, 5:02 PM
tuexen committed rG9830fed0de06: sctp: make sctp_free_ifn() static (authored by tuexen).
sctp: make sctp_free_ifn() static
Oct 31 2024, 5:01 PM
tuexen committed rG258e38014cad: sctp: cleanup sctp_delete_ifn (authored by tuexen).
sctp: cleanup sctp_delete_ifn
Oct 31 2024, 5:01 PM
tuexen committed rG6fb92db1b362: getsockopt: improve locking for SOL_SOCKET level socket options (authored by tuexen).
getsockopt: improve locking for SOL_SOCKET level socket options
Oct 31 2024, 5:00 PM
tuexen committed rG5818c74e34a8: tcp: small cleanup (authored by tuexen).
tcp: small cleanup
Oct 31 2024, 4:59 PM
tuexen committed rG7174ef705c03: tcp: improve mbuf handling when processing SYN segments (authored by tuexen).
tcp: improve mbuf handling when processing SYN segments
Oct 31 2024, 4:59 PM
tuexen committed rG5414cef63485: tcp: whitespace cleanup (authored by tuexen).
tcp: whitespace cleanup
Oct 31 2024, 4:58 PM
tuexen committed rGcdd0ab2374a0: tcp: improve MAC error handling for SYN segments (authored by tuexen).
tcp: improve MAC error handling for SYN segments
Oct 31 2024, 4:50 PM
tuexen committed rG6421a70e6238: MAC: improve handling of listening sockets (authored by tuexen).
MAC: improve handling of listening sockets
Oct 31 2024, 4:49 PM
tuexen committed rGc7e7794e9546: MAC: improve consistency in error handling (authored by tuexen).
MAC: improve consistency in error handling
Oct 31 2024, 4:47 PM
tuexen committed rG822e06011ed9: al_eth: improve TCP LRO (authored by tuexen).
al_eth: improve TCP LRO
Oct 31 2024, 4:39 PM
tuexen committed rGb245bcc1460e: neta: improve TCP LRO (authored by tuexen).
neta: improve TCP LRO
Oct 31 2024, 4:38 PM
tuexen committed rG0567f7cc1a46: tcp: improve consistency of syncache_respond() failure handling (authored by tuexen).
tcp: improve consistency of syncache_respond() failure handling
Oct 31 2024, 4:38 PM
tuexen committed rG3e8226cb8c83: tcp rack, bbr: improve handling of soft errors (authored by tuexen).
tcp rack, bbr: improve handling of soft errors
Oct 31 2024, 4:37 PM
tuexen committed rGd27f63fa8cbf: sctp: another cleanup (authored by tuexen).
sctp: another cleanup
Oct 31 2024, 2:06 PM
tuexen committed rGabbfa0cb48b3: sctp: cleanup the addition of addresses which are already known (authored by tuexen).
sctp: cleanup the addition of addresses which are already known
Oct 31 2024, 2:05 PM
tuexen committed rG676b45d04b60: sctp: further cleanup (authored by tuexen).
sctp: further cleanup
Oct 31 2024, 2:04 PM
tuexen committed rG129057d5fadd: sctp garbage collect sctp_update_ifn_mtu (authored by tuexen).
sctp garbage collect sctp_update_ifn_mtu
Oct 31 2024, 2:04 PM
tuexen committed rG18a20a430691: sctp: cleanup (authored by tuexen).
sctp: cleanup
Oct 31 2024, 2:03 PM
tuexen committed rG8689398f0921: sctp: improve debug output (authored by tuexen).
sctp: improve debug output
Oct 31 2024, 2:03 PM
tuexen committed rGbbb73d8941d4: sctp: check locking requirements (authored by tuexen).
sctp: check locking requirements
Oct 31 2024, 2:02 PM
tuexen committed rGebdee305b160: sctp: make sctp_free_ifn() static (authored by tuexen).
sctp: make sctp_free_ifn() static
Oct 31 2024, 2:01 PM
tuexen committed rGefcaa63aca0c: sctp: cleanup sctp_delete_ifn (authored by tuexen).
sctp: cleanup sctp_delete_ifn
Oct 31 2024, 2:00 PM
tuexen committed rG1e980fdf7ade: getsockopt: improve locking for SOL_SOCKET level socket options (authored by tuexen).
getsockopt: improve locking for SOL_SOCKET level socket options
Oct 31 2024, 2:00 PM
tuexen committed rGb785f83e987d: tcp: small cleanup (authored by tuexen).
tcp: small cleanup
Oct 31 2024, 1:59 PM
tuexen committed rG67e469299821: tcp: improve mbuf handling when processing SYN segments (authored by tuexen).
tcp: improve mbuf handling when processing SYN segments
Oct 31 2024, 1:58 PM
tuexen committed rG9a3bb25babfe: tcp: whitespace cleanup (authored by tuexen).
tcp: whitespace cleanup
Oct 31 2024, 1:57 PM
tuexen committed rG00c3c39fcc4c: tcp: improve ref count handling when processing SYN (authored by tuexen).
tcp: improve ref count handling when processing SYN
Oct 31 2024, 1:57 PM
tuexen committed rG2f5ac48d9b6d: tcp: improve MAC error handling for SYN segments (authored by tuexen).
tcp: improve MAC error handling for SYN segments
Oct 31 2024, 1:56 PM
tuexen committed rG66c7d5365a78: MAC: improve handling of listening sockets (authored by tuexen).
MAC: improve handling of listening sockets
Oct 31 2024, 1:55 PM
tuexen committed rG406d75a5816e: MAC: improve consistency in error handling (authored by tuexen).
MAC: improve consistency in error handling
Oct 31 2024, 1:47 PM
tuexen committed rG8df12a277f09: tcp: make tcp_lro_flush() static (authored by tuexen).
tcp: make tcp_lro_flush() static
Oct 31 2024, 1:43 PM
tuexen committed rGf84956ab3781: al_eth: improve TCP LRO (authored by tuexen).
al_eth: improve TCP LRO
Oct 31 2024, 1:41 PM
tuexen committed rGc87c8fda44ba: neta: improve TCP LRO (authored by tuexen).
neta: improve TCP LRO
Oct 31 2024, 1:41 PM
tuexen committed rG003f1ebcbce1: tcp: improve consistency of syncache_respond() failure handling (authored by tuexen).
tcp: improve consistency of syncache_respond() failure handling
Oct 31 2024, 1:40 PM
tuexen committed rG2e45166856e2: tcp rack, bbr: improve handling of soft errors (authored by tuexen).
tcp rack, bbr: improve handling of soft errors
Oct 31 2024, 1:38 PM

Oct 27 2024

tuexen committed rGd08713dcdb15: sctp: another cleanup (authored by tuexen).
sctp: another cleanup
Oct 27 2024, 2:03 PM

Oct 25 2024

tuexen committed rGa05620b0f67f: sctp: cleanup the addition of addresses which are already known (authored by tuexen).
sctp: cleanup the addition of addresses which are already known
Oct 25 2024, 2:59 PM
tuexen committed rG02478e65910a: sctp: further cleanup (authored by tuexen).
sctp: further cleanup
Oct 25 2024, 2:29 PM

Oct 24 2024

tuexen committed rGce5b5361d4d1: sctp garbage collect sctp_update_ifn_mtu (authored by tuexen).
sctp garbage collect sctp_update_ifn_mtu
Oct 24 2024, 8:02 PM
tuexen committed rGe4ac0183a1a8: sctp: cleanup (authored by tuexen).
sctp: cleanup
Oct 24 2024, 1:04 PM
tuexen committed rGce20b48a60fb: sctp: improve debug output (authored by tuexen).
sctp: improve debug output
Oct 24 2024, 12:58 PM

Oct 11 2024

tuexen added a comment to D47056: tcp: allow TSO even while RX path is unordered.

Do you mean tcp: allow TSO even while RX path is unordered instead of tcp: allow LRO even while RX path is unordered?

Oct 11 2024, 4:07 PM

Oct 10 2024

tuexen committed rG4466a97e83fd: sctp: check locking requirements (authored by tuexen).
sctp: check locking requirements
Oct 10 2024, 1:52 PM
tuexen committed rGe1a09d1e9df3: sctp: make sctp_free_ifn() static (authored by tuexen).
sctp: make sctp_free_ifn() static
Oct 10 2024, 8:44 AM
tuexen committed rG2e9761eb80f3: sctp: cleanup sctp_delete_ifn (authored by tuexen).
sctp: cleanup sctp_delete_ifn
Oct 10 2024, 8:38 AM

Oct 9 2024

tuexen added inline comments to D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
Oct 9 2024, 8:41 PM

Oct 7 2024

tuexen added a comment to D46884: sctp: propagate cap rights on sctp_peeloff.

It would be great if you can do a functional test...

See D46999, D46995 and D47000

Oct 7 2024, 8:42 PM
tuexen accepted D46884: sctp: propagate cap rights on sctp_peeloff.
Oct 7 2024, 8:42 PM
tuexen accepted D47000: capsicum-test: rights propagated on sctp_peeloff.
Oct 7 2024, 8:41 PM
tuexen committed rG3326ab87cc22: getsockopt: improve locking for SOL_SOCKET level socket options (authored by tuexen).
getsockopt: improve locking for SOL_SOCKET level socket options
Oct 7 2024, 2:49 PM
tuexen closed D46881: getsockopt: improve locking for SOL_SOCKET level socket options.
Oct 7 2024, 2:49 PM

Oct 4 2024

tuexen added a comment to D46881: getsockopt: improve locking for SOL_SOCKET level socket options.

All of the races are harmless though, i.e., the getsockopt call would return garbage in the worst case. There might be applications which query these socket options frequently, especially the socket buffer sizes. Do you think the extra overhead of acquiring the socket lock is unlikely to matter?

Oct 4 2024, 6:50 AM

Oct 3 2024

tuexen retitled D46425: Add TCP round counting logic for default stack. from Add TCP round couting logic for default stack. to Add TCP round counting logic for default stack..
Oct 3 2024, 3:13 PM
tuexen added a comment to D46884: sctp: propagate cap rights on sctp_peeloff.

It would be great if you can do a functional test...

Oct 3 2024, 2:45 PM

Oct 2 2024

tuexen requested review of D46881: getsockopt: improve locking for SOL_SOCKET level socket options.
Oct 2 2024, 8:34 PM
tuexen added a comment to D46824: tcp_output: Clear FIN if tcp_m_copym truncates output length.
In D46824#1068981, @jhb wrote:

I can fix the type mismatch during commit. I have not looked to see if other stacks are affected.

Oct 2 2024, 7:11 PM

Oct 1 2024

tuexen committed rG2eacb0841c7d: tcp: small cleanup (authored by tuexen).
tcp: small cleanup
Oct 1 2024, 3:35 PM