♟ tuexen

All for reviews have been committed. Thanks a lot for the very quick reviews!

When an IPv6 packet is received for a raw socket which has the

Integrate change suggested by bz@.

When a checksum has to be computed for a received IPv6 packet because it

In D19967#429234, @bz wrote:

Can you please improve the description before committing stating that it's related to rip6_output().

Avoid a buffer overwrite in rip6_output() when computing the checksum

Improve input validation for the socket option IPV6_CHECKSUM.

In D19965#429179, @bz wrote:

In D19965#429167, @tuexen wrote:

Split up in four reviews or committing them separately once approved?

For review already if possible. Means I need less brain cycles now to divide the four apart as well.

Address Ed's comment

In D19965#429164, @bz wrote:

This seems like four different issues and it's kind of hard to keep them apart in a single change. For the sake of having a readable history and easily seeing/understanding each problem, can you please split them up?

In D19960#429029, @jtl wrote:

I agree with @bz about ideal process. I also agree with @kristof about the practical implications of this feature. :-)
Might a valid way forward be to write a draft, propose it, and see if anyone complains by the next IETF (July) before purging this?

When sending a routing message, don't allow the user to set the

When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option,

Fix an SCTP related locking issue. Don't report that the TCB_SEND_LOCK

Fix a double free of an SCTP association in an error path.

Initialize scheduler specific data for the FCFS scheduler.

Improve locking when tearing down an SCTP association.

Fix the handling of fragmented unordered messages when using DATA chunks

Fix build issue for the userland stack.

Fox more signed unsigned issues. This time on the send path.

Fix a signed/unsigned bug when receiving SCTP messages.

Limit the size of messages sent on 1-to-many style SCTP sockets with the

Limit the number of bytes which can be queued for SCTP sockets.

Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial

Committed in r345441.

Fix a KASSERT() in tcp_output().

Some cleanup and consistency improvements.

After removing an entry from the stream scheduler list, set the pointers

Allocate an assocition id and register the stcb with holding the lock.

Remove debug output.

Allow SCTP stream reconfiguration operations only in ESTABLISHED

Handle the case when calling the IPPROTO_SCTP level socket option

Use correct buffer sizes in sctp_get[lp]addrs().

Report the correct length when using the IPPROTO_SCTP level

Honor the memory limits provided when processing the IPPROTO_SCTP

Improve consistency, not functional change.

The unit would be milli seconds, not seconds for the sysctl-variable. In general, I agree that it would be good to give at least the unit for sysctl variables, but

In D18960#413211, @rscheff_gmx.at wrote:

Quick comment: DSACKs are not working in HEAD. Potentially, the tlenp is set to zero for the duplicate segment, so that tcp_update_sack_list is not called to build the DSACK entry to the next ACK. If this is the reason, this patch may break DSACK in BSD11

This is not to be a shipstopper, but a heads-up as the DSACK not working may be related hereto...

Backport the new TCP reassembly code from head to stable/11.

In D18960#413211, @rscheff_gmx.at wrote:

Quick comment: DSACKs are not working in HEAD. Potentially, the tlenp is set to zero for the duplicate segment, so that tcp_update_sack_list is not called to build the DSACK entry to the next ACK. If this is the reason, this patch may break DSACK in BSD11

This is not to be a shipstopper, but a heads-up as the DSACK not working may be related hereto...

Can you open a PR for this against head? Is it also broken in stable/12?

Integrate jtl@'s suggestion.

The receive buffer autoscaling for TCP is based on a linear growth, which

This patch addresses an issue brought up by bz@ in D18968:

Latest version tested again with running kcovtrace /usr/bin/uptime in a loop and in addition with running syzkaller. Both work fine.

Address bz@'s comment.

Reduce the TCP initial retransmission timeout from 3 seconds to

Use exponential backoff for retransmitting SYN segments as specified

Using this version, the memory lockup observed does not occur anymore. Tested with running kcovtrace /usr/bin/uptime in a loop.

Fix a byte ordering issue for the advertised receiver window in ACK

Improve input validation for raw IPv4 socket using the IP_HDRINCL

Fix flags used when compiling kern_kcov.c and subr_coverage.c.

Follow Andrew's advice.

Use underscores instead of hyphens as suggested by Ed.

I tested this patch on a kernel build with clang in base and with the amd64-xtoolchain-gcc cross toolchain.

Fix a locking issue when reporing outbount messages.

tuexen (Michael Tuexen)
User

Projects

User Details

Recent Activity
View All

Yesterday

Thu, Apr 18

Sun, Apr 14

Sat, Apr 13

Thu, Apr 11

Tue, Mar 26

Mon, Mar 25

Sun, Mar 24

Sat, Mar 23

Mar 8 2019

Mar 7 2019

Mar 3 2019

Mar 2 2019

Mar 1 2019

Feb 27 2019

Feb 25 2019

Feb 23 2019

Feb 21 2019

Feb 20 2019

Feb 19 2019

Feb 17 2019

Feb 15 2019

Feb 13 2019

Feb 12 2019

Feb 11 2019

Feb 10 2019

tuexen (Michael Tuexen)User