Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (184 w, 4 d)

Recent Activity

Sun, Aug 18

tuexen created D21314: Identify emag 8180 CPU.
Sun, Aug 18, 9:35 AM

Thu, Aug 8

tuexen committed rS350745: Fix a typo..
Fix a typo.
Thu, Aug 8, 8:24 AM

Tue, Aug 6

tuexen committed rS350627: Reference the RFC instead of the internet draft..
Reference the RFC instead of the internet draft.
Tue, Aug 6, 11:26 AM
tuexen committed rS350626: Fix a locking issue in sctp_accept..
Fix a locking issue in sctp_accept.
Tue, Aug 6, 10:29 AM
tuexen committed rS350625: Fix build issues for the userland stack on Raspbian..
Fix build issues for the userland stack on Raspbian.
Tue, Aug 6, 8:33 AM

Mon, Aug 5

tuexen committed rS350588: Improve consistency. No functional change..
Improve consistency. No functional change.
Mon, Aug 5, 1:22 PM

Thu, Aug 1

tuexen committed rS350520: Fix the reporting of multiple unknown parameters in an received INIT.
Fix the reporting of multiple unknown parameters in an received INIT
Thu, Aug 1, 7:45 PM
tuexen committed rS350508: When responding with an ABORT to an INIT chunk containing a.
When responding with an ABORT to an INIT chunk containing a
Thu, Aug 1, 5:36 PM
tuexen added inline comments to D21038: DSACK patch to conform fully with RFC2883.
Thu, Aug 1, 2:01 PM

Wed, Jul 31

tuexen committed rS350488: Small cleanup, no functional change intended..
Small cleanup, no functional change intended.
Wed, Jul 31, 9:39 PM
tuexen committed rS350487: Consistently cleanup mbufs in case of other memory errors..
Consistently cleanup mbufs in case of other memory errors.
Wed, Jul 31, 9:29 PM

Mon, Jul 29

tuexen closed D20550: Fix bugs in DCTCP on TCP events.
Mon, Jul 29, 9:20 AM
tuexen committed rS350404: When performing after_idle() or post_recovery(), don't disable the.
When performing after_idle() or post_recovery(), don't disable the
Mon, Jul 29, 9:20 AM
tuexen added inline comments to D20550: Fix bugs in DCTCP on TCP events.
Mon, Jul 29, 9:19 AM
D20550: Fix bugs in DCTCP on TCP events is now accepted and ready to land.
Mon, Jul 29, 9:08 AM
tuexen committed rS350403: * Improve input validation of sysctl parameters for DCTPC..
* Improve input validation of sysctl parameters for DCTPC.
Mon, Jul 29, 8:50 AM
Herald added a reviewer for D20549: fixing sysctl interface for DCTCP and types of dctcp variables: manpages.
Mon, Jul 29, 8:50 AM

Sun, Jul 28

tuexen added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Sun, Jul 28, 6:15 PM
tuexen added a comment to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.

Addressed all comments so far.
Question around the default for alpha still remains; the current default renders dctcp flows very unreactive on CE marks during the initial few windows. Linux is using MAX_ALPHA_VALUE as the inital, which IMHO would be the conservative approach...

Sun, Jul 28, 6:14 PM
tuexen added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Sun, Jul 28, 3:17 PM
tuexen added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Sun, Jul 28, 2:30 PM

Sat, Jul 27

tuexen added a reviewer for D20549: fixing sysctl interface for DCTCP and types of dctcp variables: bcr.

Add Benedict for man page change.

Sat, Jul 27, 7:25 PM
tuexen added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Sat, Jul 27, 7:24 PM
tuexen added a reviewer for D19329: address possible illegal SACK block after FIN when client keeps sending data: tuexen.
Sat, Jul 27, 2:22 AM
tuexen added a comment to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.

Please update also share/man/man4/cc_dctcp.4 to describe the valid ranges of the sysctl variables and the defaults. Please fix inconsistencies like the default for dctcp_shift_g given there and in the code.

Sat, Jul 27, 1:30 AM

Tue, Jul 23

tuexen added inline comments to D21038: DSACK patch to conform fully with RFC2883.
Tue, Jul 23, 9:40 PM
tuexen added a comment to D21038: DSACK patch to conform fully with RFC2883.

The patch doesn't apply, since the indentation is based on spaces instead of tabs. Please fix.

Tue, Jul 23, 9:34 PM
tuexen committed rS350265: Add a sysctl variable ts_offset_per_conn to change the computation.
Add a sysctl variable ts_offset_per_conn to change the computation
Tue, Jul 23, 9:28 PM
tuexen closed D20980: Add sysctl to use per end point pair TCP timestamp offsets instead of per connection based offsets .
Tue, Jul 23, 9:28 PM
tuexen committed rS350254: Don't hold a mutex while calling sbwait. This was found by syzkaller..
Don't hold a mutex while calling sbwait. This was found by syzkaller.
Tue, Jul 23, 6:31 PM
tuexen committed rS350248: Fix a LOR in SCTP which was found by running syzkaller..
Fix a LOR in SCTP which was found by running syzkaller.
Tue, Jul 23, 6:07 PM

Mon, Jul 22

tuexen committed rS350216: Wakeup the application when doing PD-API for unordered DATA chunks..
Wakeup the application when doing PD-API for unordered DATA chunks.
Mon, Jul 22, 6:11 PM

Jul 17 2019

tuexen created D20980: Add sysctl to use per end point pair TCP timestamp offsets instead of per connection based offsets .
Jul 17 2019, 6:16 PM

Jul 16 2019

tuexen closed D20971: Fix compilation on platforms using gcc.
Jul 16 2019, 5:54 PM
tuexen committed rS350061: Fix compilation on platforms using gcc..
Fix compilation on platforms using gcc.
Jul 16 2019, 5:54 PM
tuexen created D20971: Fix compilation on platforms using gcc.
Jul 16 2019, 3:22 PM
tuexen committed rS350028: Add support for ICMPv6 messages indicating a parameter problem related.
Add support for ICMPv6 messages indicating a parameter problem related
Jul 16 2019, 12:58 PM
tuexen committed rS350027: Let packet_op() explicitly return the type and code instead of doing.
Let packet_op() explicitly return the type and code instead of doing
Jul 16 2019, 12:38 PM
tuexen committed rS350026: Whitespace change. No functional change..
Whitespace change. No functional change.
Jul 16 2019, 10:06 AM

Jul 15 2019

tuexen committed rS350011: Don't free read control entries, which are still on the stream queue when.
Don't free read control entries, which are still on the stream queue when
Jul 15 2019, 8:45 PM
tuexen committed rS349999: Add support for MSG_EOR and MSG_EOF in sendmsg() for SCTP..
Add support for MSG_EOR and MSG_EOF in sendmsg() for SCTP.
Jul 15 2019, 2:54 PM
tuexen committed rS349998: Fix socket state handling when freeing an SCTP endpoint..
Fix socket state handling when freeing an SCTP endpoint.
Jul 15 2019, 2:53 PM

Jul 14 2019

tuexen closed D20948: Input validation for l_linger.
Jul 14 2019, 9:44 PM
tuexen committed rS349989: Improve the input validation for l_linger..
Improve the input validation for l_linger.
Jul 14 2019, 9:44 PM
tuexen added a comment to D20948: Input validation for l_linger.

We also have the (unused) so_linger_set(), which should possibly assert that the input value is valid.

Jul 14 2019, 7:03 PM
D20948: Input validation for l_linger now requires review to proceed.

Use KASSERT in so_linger_set() to ensure that the value is valid as suggested by markj@.

Jul 14 2019, 7:02 PM
tuexen created D20948: Input validation for l_linger.
Jul 14 2019, 2:44 PM
tuexen committed rS349986: When calling sctp_initialize_auth_params(), the inp must have at.
When calling sctp_initialize_auth_params(), the inp must have at
Jul 14 2019, 12:04 PM

Jul 13 2019

tuexen committed rS349968: r348494 fixes a race in udp_output(). The same race exists in.
r348494 fixes a race in udp_output(). The same race exists in
Jul 13 2019, 12:45 PM
tuexen closed D20936: Fix a race in udp6_output.
Jul 13 2019, 12:45 PM

Jul 12 2019

tuexen added inline comments to D20936: Fix a race in udp6_output.
Jul 12 2019, 8:26 PM
tuexen added inline comments to D20936: Fix a race in udp6_output.
Jul 12 2019, 11:27 AM
tuexen created D20936: Fix a race in udp6_output.
Jul 12 2019, 7:59 AM

Jul 11 2019

tuexen accepted D20908: Fixing the DSACK code to properly clean up after sending a DSACK..
Jul 11 2019, 6:11 AM

Jul 10 2019

D20834: First step in bring hpts and infrastructure up for bbr v1 update part1 is now accepted and ready to land.

I tested this on a slow system with and without VIMAGE. It works now also on these platforms.

Jul 10 2019, 7:46 PM

Jul 6 2019

D20834: First step in bring hpts and infrastructure up for bbr v1 update part1 now requires changes to proceed.

tcp_input_data needs some tweaks to work in kernels with options VIMAGE in its configuration file.

Jul 6 2019, 1:16 PM

Jul 3 2019

D20834: First step in bring hpts and infrastructure up for bbr v1 update part1 now requires changes to proceed.

The already removed #include "opt_kern_tls.h" found its way back and breaks compilation.

Jul 3 2019, 8:02 PM
D20834: First step in bring hpts and infrastructure up for bbr v1 update part1 is now accepted and ready to land.
Jul 3 2019, 1:58 PM
tuexen added a comment to D20110: Fix infinite loop on older hardware.

D20834 fixes the issue for me.
@shurd: Could you test if D20834 fixes your issue?

Jul 3 2019, 12:32 PM
D20834: First step in bring hpts and infrastructure up for bbr v1 update part1 is now accepted and ready to land.

You might want to address the nits. All of them are whitespace issue.

Jul 3 2019, 12:20 PM

Jul 2 2019

tuexen added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

With removing these four header files, I can compile and use RACK on a head system.

Jul 2 2019, 12:00 PM

Jun 23 2019

tuexen added a comment to D20110: Fix infinite loop on older hardware.

I observed also a lockup of a bhyve VM on a slow system, where the VM used the config file:

tuexen@syzkaller:~ % cat head/sys/amd64/conf/SYZKALLER 
include         GENERIC
ident           SYZKALLER
Jun 23 2019, 8:55 PM

Jun 20 2019

tuexen committed rS349228: The variable names in the description of the port number usage is.
The variable names in the description of the port number usage is
Jun 20 2019, 12:38 PM
tuexen closed D20708: Improve traceroute man-page.
Jun 20 2019, 12:38 PM
tuexen created D20708: Improve traceroute man-page.
Jun 20 2019, 10:30 AM
tuexen committed rS349226: MFC r348728:.
MFC r348728:
Jun 20 2019, 7:50 AM

Jun 6 2019

tuexen committed rS348728: r347382 added receiver side DSACK support for the TCP base stack..
r347382 added receiver side DSACK support for the TCP base stack.
Jun 6 2019, 7:49 AM
tuexen closed D20372: Fix TCP RACK after adding DSACK support.
Jun 6 2019, 7:49 AM

May 30 2019

tuexen committed rS348441: Unbreak the powerpc, powerpc64, and sparc64 builds..
Unbreak the powerpc, powerpc64, and sparc64 builds.
May 30 2019, 5:31 PM
tuexen committed rS348435: MFC r338053:.
MFC r338053:
May 30 2019, 4:32 PM
tuexen committed rS348415: MFC r348290:.
MFC r348290:
May 30 2019, 1:51 PM

May 29 2019

tuexen added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

I'll register strong desire to discard fragments immediately on interface vanishing. I don't expect that to come with any significant weight, my rational is whatever makes state management easier within current codebase and usage patterns of fbsd.

May 29 2019, 9:28 AM

May 26 2019

tuexen closed D20374: Add PAWS check for ACK segments in the syncache code.
May 26 2019, 5:18 PM
tuexen committed rS348290: When an ACK segment as the third message of the three way handshake is.
When an ACK segment as the third message of the three way handshake is
May 26 2019, 5:18 PM
tuexen committed rS348289: MFC r347975:.
MFC r347975:
May 26 2019, 4:43 PM

May 23 2019

tuexen committed rS348174: MFC r347975:.
MFC r347975:
May 23 2019, 4:05 PM
tuexen created D20374: Add PAWS check for ACK segments in the syncache code.
May 23 2019, 12:26 PM
tuexen created D20372: Fix TCP RACK after adding DSACK support.
May 23 2019, 8:18 AM

May 19 2019

tuexen committed rS347976: Allow sending on demand SCTP HEARTBEATS only in the ESTABLISHED state..
Allow sending on demand SCTP HEARTBEATS only in the ESTABLISHED state.
May 19 2019, 5:53 PM
tuexen committed rS347975: Improve input validation for the IPPROTO_SCTP level socket options.
Improve input validation for the IPPROTO_SCTP level socket options
May 19 2019, 5:28 PM

May 17 2019

tuexen committed rS347902: MFC r347382:.
MFC r347382:
May 17 2019, 8:25 AM
tuexen committed rS347901: MFC r347381:.
MFC r347381:
May 17 2019, 8:21 AM
tuexen committed rS347900: MFC r347233:.
MFC r347233:
May 17 2019, 8:20 AM

May 16 2019

tuexen committed rS347882: MFC r347381:.
MFC r347381:
May 16 2019, 6:29 PM
tuexen committed rS347878: MFC r347233:.
MFC r347233:
May 16 2019, 6:26 PM
tuexen committed rS347688: MFC r346402:.
MFC r346402:
May 16 2019, 11:20 AM
tuexen committed rS347687: MFC r346401:.
MFC r346401:
May 16 2019, 11:19 AM
tuexen committed rS347686: MFC r346400:.
MFC r346400:
May 16 2019, 11:14 AM
tuexen committed rS347685: MFC r346182:.
MFC r346182:
May 16 2019, 11:10 AM
tuexen committed rS347681: MFC r346134:.
MFC r346134:
May 16 2019, 9:33 AM
tuexen committed rS347680: MFC r345525:.
MFC r345525:
May 16 2019, 9:32 AM
tuexen committed rS347679: MFC r345505:.
MFC r345505:
May 16 2019, 9:29 AM
tuexen committed rS347678: MFC r345504:.
MFC r345504:
May 16 2019, 9:28 AM
tuexen committed rS347677: MFC r345494:.
MFC r345494:
May 16 2019, 9:27 AM
tuexen committed rS347676: MFC r345467:.
MFC r345467:
May 16 2019, 9:26 AM
tuexen committed rS347675: MFC r345466:.
MFC r345466:
May 16 2019, 9:24 AM
tuexen committed rS347674: MFC r345465:.
MFC r345465:
May 16 2019, 9:22 AM
tuexen committed rS347673: MFC r345461:.
MFC r345461:
May 16 2019, 9:21 AM
tuexen committed rS347672: MFC r345460:.
MFC r345460:
May 16 2019, 9:19 AM
tuexen committed rS347671: MFC r344925:.
MFC r344925:
May 16 2019, 9:17 AM