User Details
- User Since
- Nov 23 2015, 12:29 AM (452 w, 5 d)
Yesterday
This change seems to revert the commit 6134aabe38c8. Is there any behavior change on V_functions_inherit_listen_socket_stack == 0 after this change? Is the TCP function block from the listener changed dynamically once the default stack is changed?
ship after update
Looks good to me, after the comment update for struct cc_var.
Thu, Jul 25
Wed, Jul 24
Just saw https://reviews.freebsd.org/D46068. If this patch has not been committed, we can still further revise it, so that D46068 can be cleaner on function re-use.
Tue, Jul 23
code clean up
Mon, Jul 22
Thanks for the update. Looks better and just a small concern about TCP_MAXWIN for 65535.
Fri, Jul 19
Tue, Jul 16
After reading the paper and IETF slides, it looks good to me on top of the general view. Just some small concerns below.
Fri, Jul 12
Thanks for the update! Looks good to me.
Over all looks good to me. Thanks for the update.
Thu, Jul 11
Jun 18 2024
I started to draft the results into wiki pages from testing this patch. Please let me know any metrics you would like to see.
Jun 7 2024
Other than the comment wording like "rtwn supports the default set of net80211 supported ciphers (IEEE80211_CRYPTO_[WEP, TKIP, AES_CCM])", looks good to me.
Jun 5 2024
Jun 4 2024
Looks good to me. :)
May 17 2024
May 15 2024
Start to pick up slowly about where I left, and touch the water. :)
May 13 2024
I see you made comments of "ieee80211_set_software_ciphers() is not needed" in if_rtwn.c. Do you mind to add it in the rest of the drivers files? Or is there any better/central place to put such comment or document it?
May 7 2024
update based on bz@ comments
May 6 2024
rebase before scrutiny check
May 2 2024
Individual accept.
May 1 2024
Apr 30 2024
Just some minor issues.
Apr 29 2024
If you have a plan to figure out TEXT_SET(crypto##_set, name##_modevent) and TEXT_SET(ratectl##_set, alg##_modevent), I have no problem with this patch.
Cautious individual accept.
Apr 26 2024
I don't get it why this change made a difference in your test. Is it because of the bug I pointed in TEXT_SET ?
LGTM
The rest looks good to me.
Apr 24 2024
Also do you have any plan to update the man page regarding the new field ic_sw_cryptocaps besides ic_cryptocaps ?
Also please update the Summary section in this review, i.e. the mentioned new field ic_wpa_cryptocaps is actually the ic_sw_cryptocaps in the code change.
LGTM
I am intending to give approval, but I am afraid of missing the new response to my review comment for the code comment update. So let's be patient. :)
Apr 23 2024
Apr 17 2024
Mar 22 2024
During association with the AP, sw/hw keys (indexes) are set. And before tx, the hw key is selected by sw key's index returned from ieee80211_crypto_get_txkey(), same way as without LKPI_80211_HW_CRYPTO.
Mar 21 2024
Mar 15 2024
I am working the "multi-key" support these days on top of D43634(this patch) and D43648, but it turns out this patch is causing more trouble than it is trying to solve.
In fact, it caused this "Abort trap" from the console and then my VM is shutdown silently. The kernel is main with LKPI_80211_HW_CRYPTO on top of this patch.
Mar 14 2024
code update according to comments
Mar 7 2024
Mar 6 2024
I think LKPI_80211_LHW_LOCK_ASSERT can help remind us of such LKPI_80211_LHW_LOCK requirement for lkpi_80211_mo_* functions.
Mar 5 2024
Mar 4 2024
Mar 1 2024
The ktls draws my attention. Hope you add reviewers.
Feb 29 2024
Shall correct the typo first before committing.
Feb 26 2024
Please add PR: 277095 in the summary, as this patch also fixes that.
Feb 23 2024
Feb 22 2024
Good catch! Always keep an eye on the cubic_data->t_epoch refresh.
Feb 21 2024
Feb 20 2024
Initial test shows this error when I changed the channel number in AP. Looks like a reproduce of PR 277100 without LKPI_80211_HW_CRYPTO enabled, or a separate issue?
Feb 19 2024
Feb 16 2024
Feb 13 2024
Feb 12 2024
Feb 9 2024
Given D43389 is the FIRST of a series, is this the SECOND one or is there any dependence? Please help clarify.
Remove Copyright headnote and myself from if_iwn.c, as noted in review.