Page MenuHomeFreeBSD

cc (Cheng Cui)
User

Projects

User Details

User Since
Nov 23 2015, 12:29 AM (447 w, 6 d)

Recent Activity

Tue, Jun 18

cc added a comment to D41715: tcp: Align cubic cc with rfc9438.

I started to drafting the results into a wiki page from testing this patch. Please let me know any metrics you would like to see.

Tue, Jun 18, 5:01 PM

Fri, Jun 7

cc accepted D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().

Other than the comment wording like "rtwn supports the default set of net80211 supported ciphers (IEEE80211_CRYPTO_[WEP, TKIP, AES_CCM])", looks good to me.

Fri, Jun 7, 12:12 PM · wireless

Wed, Jun 5

cc added inline comments to D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().
Wed, Jun 5, 3:55 PM · wireless

Tue, Jun 4

cc accepted D43967: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)().

Looks good to me. :)

Tue, Jun 4, 2:21 PM

May 17 2024

cc requested changes to D41715: tcp: Align cubic cc with rfc9438.
May 17 2024, 8:23 PM

May 15 2024

cc added a comment to D41715: tcp: Align cubic cc with rfc9438.

Start to pick up slowly about where I left, and touch the water. :)

May 15 2024, 1:35 PM

May 13 2024

cc added inline comments to D45178: linuxkpi: sk_buff: Resize the control buffer in struct sk_buff..
May 13 2024, 4:34 PM
cc requested review of D45178: linuxkpi: sk_buff: Resize the control buffer in struct sk_buff..
May 13 2024, 4:32 PM
cc requested changes to D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().

I see you made comments of "ieee80211_set_software_ciphers() is not needed" in if_rtwn.c. Do you mind to add it in the rest of the drivers files? Or is there any better/central place to put such comment or document it?

May 13 2024, 2:37 PM · wireless

May 7 2024

cc updated the diff for D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.

update based on bz@ comments

May 7 2024, 3:05 PM

May 6 2024

cc updated the diff for D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.

rebase before scrutiny check

May 6 2024, 7:17 PM

May 2 2024

cc accepted D44864: net80211: add new ciphers and RSN flags.

Individual accept.

May 2 2024, 5:54 PM · wireless

May 1 2024

cc accepted D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
May 1 2024, 8:55 PM · wireless
cc added inline comments to D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
May 1 2024, 7:28 PM · wireless
cc added inline comments to D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
May 1 2024, 7:25 PM · wireless

Apr 30 2024

cc requested changes to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.

Just some minor issues.

Apr 30 2024, 7:41 PM · wireless

Apr 29 2024

cc requested changes to D44921: net80211: add 256 bit CCMP support.
Apr 29 2024, 9:00 PM · wireless
cc added inline comments to D44901: net80211: allow a single wlan crypto module to register for >1 cipher.
Apr 29 2024, 5:01 PM · wireless
cc accepted D44901: net80211: allow a single wlan crypto module to register for >1 cipher.

If you have a plan to figure out TEXT_SET(crypto##_set, name##_modevent) and TEXT_SET(ratectl##_set, alg##_modevent), I have no problem with this patch.

Apr 29 2024, 3:53 PM · wireless
cc accepted D44820: net80211: add a new field specifically for announcing specific ciphers.

Cautious individual accept.

Apr 29 2024, 3:13 PM · wireless
cc requested changes to D44864: net80211: add new ciphers and RSN flags.
Apr 29 2024, 2:57 PM · wireless

Apr 26 2024

cc added a comment to D44901: net80211: allow a single wlan crypto module to register for >1 cipher.

I don't get it why this change made a difference in your test. Is it because of the bug I pointed in TEXT_SET ?

Apr 26 2024, 6:16 PM · wireless
cc accepted D44900: net80211: add placeholder module names for the new ciphers.

LGTM

Apr 26 2024, 4:19 PM · wireless
cc added inline comments to D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
Apr 26 2024, 3:42 PM · wireless
cc requested changes to D44820: net80211: add a new field specifically for announcing specific ciphers.

The rest looks good to me.

Apr 26 2024, 2:18 PM · wireless

Apr 24 2024

cc requested changes to D44864: net80211: add new ciphers and RSN flags.
Apr 24 2024, 8:11 PM · wireless
cc added a comment to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.
In D44827#1023209, @bz wrote:

eg ath(4) would do something like:

How do you want to implement ath_settkipmic() "nicely" without exposing the field?

oops my bad. it'll be a flag for hardware encryption support! I fixed the code snippet.

Apr 24 2024, 3:17 PM · wireless
cc added a comment to D44820: net80211: add a new field specifically for announcing specific ciphers.

Also do you have any plan to update the man page regarding the new field ic_sw_cryptocaps besides ic_cryptocaps ?

Apr 24 2024, 2:54 PM · wireless
cc added a comment to D44820: net80211: add a new field specifically for announcing specific ciphers.

Also please update the Summary section in this review, i.e. the mentioned new field ic_wpa_cryptocaps is actually the ic_sw_cryptocaps in the code change.

Apr 24 2024, 2:28 PM · wireless
cc accepted D44821: wpa: Remove the now not-needed local logic to hard-code cipher support.

LGTM

Apr 24 2024, 2:23 PM · wireless
cc requested changes to D44820: net80211: add a new field specifically for announcing specific ciphers.

I am intending to give approval, but I am afraid of missing the new response to my review comment for the code comment update. So let's be patient. :)

Apr 24 2024, 2:20 PM · wireless

Apr 23 2024

cc requested changes to D43967: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)().
Apr 23 2024, 7:17 PM
cc accepted D43966: LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls.
In D43966#1023788, @bz wrote:

@cc Adding LOCK asserts is a very good idea; not all the functions need them if I remember correctly. Should I really add it to this "fix" or should I do a separate full pass on the linux_80211_macops.c file?

Apr 23 2024, 2:09 PM

Apr 17 2024

cc added inline comments to D44820: net80211: add a new field specifically for announcing specific ciphers.
Apr 17 2024, 2:35 PM · wireless

Mar 22 2024

cc added a comment to D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.

you negotiate it as an extension, and then it's used to switch STA keys without dropping frames.

During association with the AP, sw/hw keys (indexes) are set. And before tx, the hw key is selected by sw key's index returned from ieee80211_crypto_get_txkey(), same way as without LKPI_80211_HW_CRYPTO.

Mar 22 2024, 1:30 PM

Mar 21 2024

cc updated the test plan for D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.
Mar 21 2024, 10:14 PM
cc updated the summary of D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.
Mar 21 2024, 10:12 PM
cc requested review of D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.
Mar 21 2024, 10:11 PM

Mar 15 2024

cc added a comment to D43634: net80211: crypto: fix check for driver having done decryption.

I am working the "multi-key" support these days on top of D43634(this patch) and D43648, but it turns out this patch is causing more trouble than it is trying to solve.
In fact, it caused this "Abort trap" from the console and then my VM is shutdown silently. The kernel is main with LKPI_80211_HW_CRYPTO on top of this patch.

Mar 15 2024, 6:30 PM

Mar 14 2024

cc updated the diff for D44260: LinuxKPI: LKPI_80211_HW_CRYPTO: add crypto debug flag in LinuxKPI.

code update according to comments

Mar 14 2024, 3:09 PM

Mar 7 2024

cc added inline comments to D44260: LinuxKPI: LKPI_80211_HW_CRYPTO: add crypto debug flag in LinuxKPI.
Mar 7 2024, 1:09 PM

Mar 6 2024

cc requested review of D44260: LinuxKPI: LKPI_80211_HW_CRYPTO: add crypto debug flag in LinuxKPI.
Mar 6 2024, 10:28 PM
cc added inline comments to D43648: LinuxKPI: 802.11: hardware crypto offload improvements.
Mar 6 2024, 8:35 PM
cc added inline comments to D43648: LinuxKPI: 802.11: hardware crypto offload improvements.
Mar 6 2024, 7:48 PM
cc requested changes to D43966: LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls.
Mar 6 2024, 2:04 PM
cc added a comment to D43966: LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls.

I think LKPI_80211_LHW_LOCK_ASSERT can help remind us of such LKPI_80211_LHW_LOCK requirement for lkpi_80211_mo_* functions.

Mar 6 2024, 2:04 PM
cc accepted D43965: LinuxKPI: 802.11: remove unneeded re-lookup in lkpi_80211_txq_tx_one().
Mar 6 2024, 1:45 PM

Mar 5 2024

cc accepted D44208: LinuxKPI: 802.11: return proper value for IEEE80211_CRYPTO_AES_CCM.
Mar 5 2024, 8:38 PM

Mar 4 2024

cc accepted D44165: ktls: enumify tcp_tls_mode magic numbers.
Mar 4 2024, 1:05 AM

Mar 1 2024

cc added inline comments to D44165: ktls: enumify tcp_tls_mode magic numbers.
Mar 1 2024, 1:58 PM
cc added a comment to D44165: ktls: enumify tcp_tls_mode magic numbers.

The ktls draws my attention. Hope you add reviewers.

Mar 1 2024, 1:58 PM

Feb 29 2024

cc requested changes to D43634: net80211: crypto: fix check for driver having done decryption.
Feb 29 2024, 8:01 PM
cc requested changes to D43967: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)().
Feb 29 2024, 4:31 PM
cc accepted D43944: LinuxKPI: 802.11: try to fix iwlwifi("Invalid TXQ id").

Shall correct the typo first before committing.

Feb 29 2024, 3:44 PM

Feb 26 2024

cc accepted D43751: net80211: amrr_init: change order of commands.
Feb 26 2024, 9:31 PM
cc requested changes to D43648: LinuxKPI: 802.11: hardware crypto offload improvements.

Please add PR: 277095 in the summary, as this patch also fixes that.

Feb 26 2024, 8:58 PM

Feb 23 2024

cc abandoned D43945: LinuxKPI w/ LKPI_80211_HW_CRYPTO: fix non-sleepable mutex use..
Feb 23 2024, 3:06 PM

Feb 22 2024

cc accepted D44023: tcp: cubic - restart epoch after RTO.

Good catch! Always keep an eye on the cubic_data->t_epoch refresh.

Feb 22 2024, 8:26 PM

Feb 21 2024

cc added inline comments to D43945: LinuxKPI w/ LKPI_80211_HW_CRYPTO: fix non-sleepable mutex use..
Feb 21 2024, 9:45 PM
cc accepted D43968: LinuxKPI: 802.11: implement a deferred RX path.
In D43968#1003515, @bz wrote:
In D43968#1003463, @cc wrote:

Initial test shows this error when I changed the channel number in AP. Looks like a reproduce of PR 277100 without LKPI_80211_HW_CRYPTO enabled, or a separate issue?

Yes, looks likely same/similar than in the PR.

You've seen the comments (1)-(4) above?

Feb 21 2024, 3:48 PM

Feb 20 2024

cc added a comment to D43968: LinuxKPI: 802.11: implement a deferred RX path.

Initial test shows this error when I changed the channel number in AP. Looks like a reproduce of PR 277100 without LKPI_80211_HW_CRYPTO enabled, or a separate issue?

Feb 20 2024, 5:09 PM

Feb 19 2024

cc added inline comments to D43945: LinuxKPI w/ LKPI_80211_HW_CRYPTO: fix non-sleepable mutex use..
Feb 19 2024, 6:12 PM

Feb 16 2024

cc requested review of D43945: LinuxKPI w/ LKPI_80211_HW_CRYPTO: fix non-sleepable mutex use..
Feb 16 2024, 9:44 PM

Feb 13 2024

cc accepted D43753: LinuxKPI: 802.11: update the ni/lsta reference cycle.

My initial test on the three patches of D43389, D43725, D43753 looks to be good. No more panics. And I need to figure out some issues in my testbed, so I give the approval first as I don't want my test to delay the schedule.

Feb 13 2024, 2:54 PM
cc accepted D43725: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss).

My initial test on the three patches of D43389, D43725, D43753 looks to be good. No more panics. And I need to figure out some issues in my testbed, so I give the approval first as I don't want my test to delay the schedule.

Feb 13 2024, 2:54 PM
cc accepted D43389: net80211: deal with lost state transitions.

My initial test on the three patches of D43389, D43725, D43753 looks to be good. No more panics. And I need to figure out some issues in my testbed, so I give the approval first as I don't want my test to delay the schedule.

Feb 13 2024, 2:54 PM

Feb 12 2024

cc added a comment to D43770: Rename HT Operation Protection micros to represent the state of the art..
In D43770#999610, @bz wrote:

Can we please NOT do this. I explained it in my other review (D43658) twice by now.

This is (a) only changing some defines to change and not all the others for the same structure, (b) it's been in at least 3 major releases this way why still change it? It fits with the entire HT code. For VHT which is not used yet we still can do and do.

Also, if doing I said replace them with the names from LinuxKPI so we do not have two versions. You are just trading one name for another name and still leaving us with more compat names.

Feb 12 2024, 3:08 PM

Feb 9 2024

cc added a comment to D43725: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss).
In D43725#999202, @cc wrote:
In D43725#999194, @cc wrote:

Given D43389 is the FIRST of a series, is this the SECOND one or is there any dependence? Please help clarify.

I think there is dependence, as I applied this patch only, restarted netif, and hit the panic:

--- trap 0x9, rip = 0xffffffff80cf8661, rsp = 0xfffffe00ab111d00, rbp = 0xfffffe00ab111d10 ---
node_free() at node_free+0x11/frame 0xfffffe00ab111d10
lkpi_sta_auth_to_scan() at lkpi_sta_auth_to_scan+0x27f/frame 0xfffffe00ab111d80
lkpi_iv_newstate() at lkpi_iv_newstate+0x253/frame 0xfffffe00ab111df0
ieee80211_newstate_cb() at ieee80211_newstate_cb+0x226/frame 0xfffffe00ab111e40
taskqueue_run_locked() at taskqueue_run_locked+0xab/frame 0xfffffe00ab111ec0
taskqueue_thread_loop() at taskqueue_thread_loop+0xd3/frame 0xfffffe00ab111ef0
fork_exit() at fork_exit+0x82/frame 0xfffffe00ab111f30
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00ab111f30
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 0 tid 100192 ]
Stopped at      kdb_enter+0x32: movq    $0,0xe394d3(%rip)
db>
Feb 9 2024, 9:16 PM
cc added a comment to D43658: LinuxKPI: 802.11: correct HT protection fields.

I thought the ports tree contains user-space applications. Are you talking about some user-space drivers in the ports tree?

There are a number of kernel modules in the ports tree as well. drm-kmod is one well known example.

Feb 9 2024, 7:43 PM
cc added a comment to D43725: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss).
In D43725#999194, @cc wrote:

Given D43389 is the FIRST of a series, is this the SECOND one or is there any dependence? Please help clarify.

Feb 9 2024, 7:11 PM
cc added inline comments to D43725: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss).
Feb 9 2024, 6:55 PM
cc added a comment to D43725: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss).

Given D43389 is the FIRST of a series, is this the SECOND one or is there any dependence? Please help clarify.

Feb 9 2024, 6:51 PM
cc added inline comments to D43770: Rename HT Operation Protection micros to represent the state of the art..
Feb 9 2024, 3:14 PM
cc updated the diff for D43770: Rename HT Operation Protection micros to represent the state of the art..

Remove Copyright headnote and myself from if_iwn.c, as noted in review.

Feb 9 2024, 3:14 PM
cc accepted D43658: LinuxKPI: 802.11: correct HT protection fields.

With D43770 in mind, I think we can go ahead and commit this change.

Feb 9 2024, 1:05 PM

Feb 7 2024

cc updated the test plan for D43770: Rename HT Operation Protection micros to represent the state of the art..
Feb 7 2024, 9:00 PM
cc updated the diff for D43770: Rename HT Operation Protection micros to represent the state of the art..

add Copyright in if_iwn.c

Feb 7 2024, 8:47 PM
cc updated the diff for D43770: Rename HT Operation Protection micros to represent the state of the art..

Add missing update in if_iwn.c and keep IEEE80211_HTINFO_OPMODE_S from the kernel build lesson.

Feb 7 2024, 8:40 PM

Feb 6 2024

cc added a comment to D43658: LinuxKPI: 802.11: correct HT protection fields.

I have created D43770 to clarify/illustrate my idea.

Feb 6 2024, 10:47 PM
cc requested review of D43770: Rename HT Operation Protection micros to represent the state of the art..
Feb 6 2024, 10:45 PM
cc added a comment to D43658: LinuxKPI: 802.11: correct HT protection fields.
In D43658#997148, @bz wrote:

If I understand correctly, these defines are from the Table 8-130—HT Operation element fields and subfields (continued) on page 615. I quoted them below. I think it's better to use cleaner names for these defines in sys/net80211/ieee80211.h and use an indent similar to the Linux version.

There's a lot to be said about the "native" net80211 version. But that's not part of this review request. I tend to not change the old stuff there if it is used (VHT is not used yet, so that's why there is cleanup going on there still). Simply MFCing it could be a pain without leaving compat defines. In this case it seems only iwn(4) would be affected so we could argue we can but I haven't checked all the other related fields and that's where the real pain comes in.

I think a separate patch "just rename these defines in sys/net80211/ieee80211.h" shall be OK, and can MFC, because their corresponding values are correct. If you agree, I can submit a patch for review.

The defines in net80211 are part of the public KPI and have been for a decade.
They are used at least in one device driver as well. I have not recently checked if there are any usable wlan(4) drivers in ports still supporting HT but that's due diligens to be done then as well.
If we are fine with breaking out-of-tree then we should probably just move the ones from LinuxKPI into net80211 and have a single definition of them.
But them we'll have inconsistent naming with the other fields for "HTINFO" etc. and that makes no sense either.
Hence my leaning of leaving the "legacy bits" as-are.

Feb 6 2024, 8:37 PM
cc accepted D43655: net80211: fix checks for (*iv_preamble_update)/(*iv_ht_protmode_update).
Feb 6 2024, 4:05 PM

Feb 5 2024

cc added inline comments to D43647: iwlwifi: adjust to make d3.c compile.
Feb 5 2024, 5:16 PM

Feb 2 2024

cc added a comment to D43658: LinuxKPI: 802.11: correct HT protection fields.
In D43658#996657, @bz wrote:
In D43658#996222, @cc wrote:

This patch also fixes the wrong/old values used in sys/compat/linuxkpi/common/include/linux/ieee80211.h. thanks

No, this patch ONLY fixes the wrong values there. The fact that they are defined to a native version is cosmetics.

I meant this patch fixes the wrong/old values here, in the LinuxKPI. For example, IEEE80211_HT_OP_MODE_PROTECTION_NONHT_MIXED should have a value 3, not the old 0x02.

Feb 2 2024, 1:26 PM

Feb 1 2024

cc accepted D43635: LinuxKPI: 802.11: fix field order in ieee80211_key_conf.

Good catch!

Feb 1 2024, 3:13 PM

Jan 31 2024

cc accepted D43646: LinuxKPI: 802.11: extend ieee80211_key_seq and WLAN_KEY_LEN_* defines.
Jan 31 2024, 3:18 PM
cc added a comment to D43658: LinuxKPI: 802.11: correct HT protection fields.

This patch also fixes the wrong/old values used in sys/compat/linuxkpi/common/include/linux/ieee80211.h. thanks

Jan 31 2024, 2:36 PM

Jan 29 2024

cc accepted D43647: iwlwifi: adjust to make d3.c compile.
Jan 29 2024, 4:14 PM
cc requested changes to D43647: iwlwifi: adjust to make d3.c compile.

I see two "MFC after" in the summary section, and the summary section seems to contain two parts that it looks you are going to split this patch into two when you MFC it. Am I understanding correctly? Are you going to manually MFC the two parts?

Jan 29 2024, 3:41 PM

Jan 24 2024

cc accepted D43536: tcp: pass maxseg around instead of locally calculating anew.
Jan 24 2024, 2:51 PM
cc added inline comments to D43536: tcp: pass maxseg around instead of locally calculating anew.
Jan 24 2024, 2:24 PM

Jan 23 2024

cc added a comment to D43512: net80211: make sure calls to (*iv_update_bss)() are locked.

By the way, I forgot to ask, is it also helpful to add IEEE80211_LOCK_ASSERT in lkpi_iv_update_bss()?

Jan 23 2024, 8:43 PM
cc accepted D43512: net80211: make sure calls to (*iv_update_bss)() are locked.
Jan 23 2024, 5:22 PM

Jan 22 2024

cc accepted D43539: tcp: style changes.
Jan 22 2024, 2:53 PM
cc added inline comments to D43539: tcp: style changes.
Jan 22 2024, 2:25 PM

Jan 19 2024

cc committed rG404b91dac415: libexec/rc/rc.initdiskless: make tar's path flexible (authored by cc).
libexec/rc/rc.initdiskless: make tar's path flexible
Jan 19 2024, 3:46 PM

Jan 17 2024

cc accepted D43469: net80211: fix a NULL deref in ieee80211_sta_join1().
Jan 17 2024, 3:22 PM

Jan 10 2024

cc added a comment to D43389: net80211: deal with lost state transitions.

I think this patch as a fix is targeting 271979#c28. If I am right, I will use the reproduce method to test this patch. thanks

Jan 10 2024, 2:45 PM

Jan 8 2024

cc accepted D43170: tcp: clean PRR state after ECN congestion recovery..
Jan 8 2024, 2:24 PM
cc accepted D43343: tcp: prevent spurious empty segments and fix uncommon panic.

Good catch!

Jan 8 2024, 1:59 PM