Differential D44821

wpa: Remove the now not-needed local logic to hard-code cipher support
ClosedPublic
Actions

Authored by adrian on Apr 17 2024, 2:13 AM.

Tags

Referenced Files

	F108323746: D44821.diff
	Thu, Jan 23, 9:04 PM

	Unknown Object (File)
	Sat, Jan 18, 1:00 PM

	Unknown Object (File)
	Fri, Jan 17, 8:20 PM

	Unknown Object (File)
	Tue, Dec 31, 3:43 AM

	Unknown Object (File)
	Dec 19 2024, 12:59 AM

	Unknown Object (File)
	Nov 24 2024, 8:49 AM

	Unknown Object (File)
	Nov 22 2024, 10:23 AM

	Unknown Object (File)
	Nov 21 2024, 4:23 PM

View All 74 Files

Subscribers

Details

Reviewers

cy
cc

Group Reviewers

Commits

rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support

Summary

A previous commit now exposes the supported net80211 ciphers for the
given NIC, rather than the hardware cipher list. This is going to be
especially important moving forward when we add more cipher and key
management support.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Apr 17 2024, 2:13 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 17 2024, 2:13 AM

adrian requested review of this revision.Apr 17 2024, 2:13 AM

adrian added a parent revision: D44820: net80211: add a new field specifically for announcing specific ciphers.

Harbormaster completed remote builds in B57141: Diff 137211.Apr 17 2024, 2:13 AM

adrian retitled this revision from [wpa] Remove the now not-needed local logic to hard-code cipher support to wpa: Remove the now not-needed local logic to hard-code cipher support.Apr 17 2024, 2:52 AM

adrian added a reviewer: wireless.

LGTM

This revision is now accepted and ready to land.Apr 17 2024, 3:20 AM

Update description

This revision now requires review to proceed.Apr 17 2024, 4:46 PM

Harbormaster completed remote builds in B57146: Diff 137262.Apr 17 2024, 4:46 PM

adrian added a child revision: D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.Apr 18 2024, 2:09 AM

adrian added a project: wireless.Apr 20 2024, 8:46 PM

LGTM

This revision is now accepted and ready to land.Apr 24 2024, 2:23 PM

cy accepted this revision.Apr 25 2024, 12:49 AM

Is is likely mis-sorted in the stack as this should go after D44922?

You didn't answer my previous question?

Closed by commit rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support (authored by adrian). · Explain WhyMay 9 2024, 12:50 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support.

Revision Contents
Changeset List

Path

Size

contrib/

wpa/

src/

drivers/

12 lines

Diff 138280

contrib/wpa/src/drivers/driver_bsd.c

Loading...