Page MenuHomeFreeBSD
Differential D44821

wpa: Remove the now not-needed local logic to hard-code cipher support
ClosedPublic
Actions

Authored by adrian on Apr 17 2024, 2:13 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, May 17, 5:29 AM
Unknown Object (File)
Thu, May 9, 10:24 AM
Unknown Object (File)
Fri, Apr 26, 5:16 AM
Unknown Object (File)
Sat, Apr 20, 11:21 AM
Unknown Object (File)
Sat, Apr 20, 12:34 AM
Unknown Object (File)
Fri, Apr 19, 4:46 PM
Unknown Object (File)
Apr 17 2024, 3:22 PM
Unknown Object (File)
Apr 17 2024, 2:54 AM
Subscribers
adrian
bz
cc
cy
imp

Details

Reviewers
cy
cc
Group Reviewers
wireless
Commits
rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support
Summary

A previous commit now exposes the supported net80211 ciphers for the
given NIC, rather than the hardware cipher list. This is going to be
especially important moving forward when we add more cipher and key
management support.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57141
Build 54029: arc lint + arc unit

Event Timeline

adrian created this revision.Apr 17 2024, 2:13 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 17 2024, 2:13 AM
adrian requested review of this revision.Apr 17 2024, 2:13 AM
adrian added a parent revision: D44820: net80211: add a new field specifically for announcing specific ciphers.
Harbormaster completed remote builds in B57141: Diff 137211.Apr 17 2024, 2:13 AM
adrian retitled this revision from [wpa] Remove the now not-needed local logic to hard-code cipher support to wpa: Remove the now not-needed local logic to hard-code cipher support.Apr 17 2024, 2:52 AM
adrian added a reviewer: wireless.
cy accepted this revision.Apr 17 2024, 3:20 AM
cy added a subscriber: cy.

LGTM

This revision is now accepted and ready to land.Apr 17 2024, 3:20 AM
adrian updated this revision to Diff 137262.Apr 17 2024, 4:46 PM

Update description

This revision now requires review to proceed.Apr 17 2024, 4:46 PM
Harbormaster completed remote builds in B57146: Diff 137262.Apr 17 2024, 4:46 PM
adrian added a child revision: D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.Apr 18 2024, 2:09 AM
adrian added a project: wireless.Sat, Apr 20, 8:46 PM
cc accepted this revision.Wed, Apr 24, 2:23 PM
cc added a subscriber: cc.

LGTM

This revision is now accepted and ready to land.Wed, Apr 24, 2:23 PM
cy accepted this revision.Thu, Apr 25, 12:49 AM
bz added a subscriber: bz.Thu, Apr 25, 3:36 AM

Is is likely mis-sorted in the stack as this should go after D44922?

bz added a comment.Thu, May 2, 7:27 PM

You didn't answer my previous question?

Closed by commit rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support (authored by adrian). · Explain WhyThu, May 9, 12:50 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support.

Revision Contents
Changeset List

PathSize
contrib/
wpa/
src/
drivers/
12 lines

Diff 137211

View Options

contrib/wpa/src/drivers/driver_bsd.c

Loading...